From patchwork Fri Apr 12 07:30:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 13627050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DC14C00A94 for ; Fri, 12 Apr 2024 07:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ol0j3wG7vsijWIuiBXe4cdHSQ5ZizClWVn28iqlE1Gg=; b=Z14IFtT1Ls4dN1 0RY9k4/YxN63tpna4ZoE4ftUnE/0q/J9emF0KKjW07b3yLA82qKavdmQovhC1kKb+/CvSJpNUwJyQ qUtQDHqXIU9MQ8bTZcE/1ZN6SasxC5Fd8xEU09udjgYflpVeMu9u/C6JNBj7tKcqmbAlTm244VcQ4 n+y3ML+9Pz2lJjloaWQL639K153WPaDAwSxCHiD3MJcWx5xoHDhe42yUtoTSofL+L15rKOycHr+g8 4X8uy6bgPhgLPLQIotD/w562Ew6LOT3sSZU+Xp2c9rDrq4uydsvVL2OZ29hRlelbEA0oPZ7zyJ2G2 txaRV1eq65qPCeBiJdlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvBNL-0000000Fqzv-1aXF; Fri, 12 Apr 2024 07:31:07 +0000 Received: from mail-oo1-xc2e.google.com ([2607:f8b0:4864:20::c2e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvBNE-0000000Fqtk-0XdW for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 07:31:02 +0000 Received: by mail-oo1-xc2e.google.com with SMTP id 006d021491bc7-5a4f7a648dbso355198eaf.3 for ; Fri, 12 Apr 2024 00:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712907058; x=1713511858; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NPVvWMAJiQ9bH1Vh3FBxv8RA77e8O4OnA04Edjj3+7c=; b=CH7B/YzCTnJGm+t3sJFG1DK2vD7Myalruj9M2urSX163AkPsQEFvdg8c1Sp9GTFHfb Rq5UY5B0Kt7Lt+dw06F7mbGA7H52QQ7YgqI333pGuaKEj9oIfBXUv86PZiaP7aKc//7U ZKSTDmHEuY8GeHz5kFXeD3aZ7S7hrvn2GgO4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712907058; x=1713511858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NPVvWMAJiQ9bH1Vh3FBxv8RA77e8O4OnA04Edjj3+7c=; b=gTcO+l0iBbegt0Q35C7B7gNrqgqhOkTKulMlBzOD1GMrhG8ChcSabsMHMVcqj4897x 4iUc/TARwuW0OqFllY5TMTUlBRX9pTul1K98irwRTRe/2nDAQlVJF5ef2zy+2GrGxNCk 17CgpJyjMG5wIPMVIe7yMzNGAo38JoJhLgADlDlo8/9ToLOus5TAM2tgY3+WSPonwyr2 /pYRBh6kRHAS4u5y8gbKpH4Lxuukxf7MdEPxY/FkvqUHs1ofNgD5jKI9HgCeeR2UaBr5 cnisaUcQz7qVvMCuxaUyQfwBGCb+KOe+znnLrJk83WiqRU1kL6rXnb63Rwq/YeWg9I/B 0oSw== X-Forwarded-Encrypted: i=1; AJvYcCXxbIlUbiYVjigFWHvPX4vgQzz3DeoECKQ+iZiTzZDtGSHOeXmbsFaVhbU9ZWD/si1oH28rWCUDwEEhMZ6ZLfJm+fjSk/8th/BIjUY6afJYwO5tOCo= X-Gm-Message-State: AOJu0YxuXM7kNjM1TRK5K8VQn91ZH0Z4CHgK1Db/N2mhB02YrMtjcqUV dLQJdNfU3NV3ct+AqWnuHC7Lzs2TvBmcUdHALwM3s7p0V0Nk5PufnjMer+bzXQ== X-Google-Smtp-Source: AGHT+IHbqeFZC+Q0e8Ic2lEtKsE2fsonI92D1nvKY+dlmohGFGapjLW9bPiT6QlzY3Dyk6ly/4CfLw== X-Received: by 2002:a05:6358:6b0c:b0:186:431:d9d6 with SMTP id y12-20020a0563586b0c00b001860431d9d6mr1648558rwg.17.1712907057809; Fri, 12 Apr 2024 00:30:57 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:e3c8:6e1:dcfa:3e8c]) by smtp.gmail.com with ESMTPSA id d6-20020a637346000000b005d3bae243bbsm2149609pgn.4.2024.04.12.00.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 00:30:57 -0700 (PDT) From: Chen-Yu Tsai To: Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , Sean Wang , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Date: Fri, 12 Apr 2024 15:30:42 +0800 Message-ID: <20240412073046.1192744-2-wenst@chromium.org> X-Mailer: git-send-email 2.44.0.683.g7961c838ac-goog In-Reply-To: <20240412073046.1192744-1-wenst@chromium.org> References: <20240412073046.1192744-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_003100_313221_9B2C5794 X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over SDIO. WiFi and Bluetooth are separate SDIO functions within the chip. While the Bluetooth SDIO function is fully discoverable, the chip has a pin that can reset just the Bluetooth core, as opposed to the full chip. This should be described in the device tree. Add a device tree binding for the Bluetooth SDIO function of the MT7921S specifically to document the reset line. This binding is based on the MMC controller binding, which specifies one device node per SDIO function. Cc: Sean Wang Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring --- Changes since v2: - Expand description and commit message to clearly state that WiFi and Bluetooth are separate SDIO functions, and that each function should be a separate device node, as specified by the MMC binding. - Change 'additionalProperties' to 'unevaluatedProperties' - Add missing separating new line - s/ot/to/ Angelo's reviewed-by was not picked up due to the above changes. Changes since v1: - Reworded descriptions - Moved binding maintainer section before description - Added missing reference to bluetooth-controller.yaml - Added missing GPIO header to example --- .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 55 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml diff --git a/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml new file mode 100644 index 000000000000..67ff7caad599 --- /dev/null +++ b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/bluetooth/mediatek,mt7921s-bluetooth.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MT7921S Bluetooth + +maintainers: + - Sean Wang + +description: + MT7921S is an SDIO-attached dual-radio WiFi+Bluetooth Combo chip; each + function is its own SDIO function on a shared SDIO interface. The chip + has two dedicated reset lines, one for each function core. + This binding only covers the Bluetooth SDIO function, with one device + node describing only this SDIO function. + +allOf: + - $ref: bluetooth-controller.yaml# + +properties: + compatible: + enum: + - mediatek,mt7921s-bluetooth + + reg: + const: 2 + + reset-gpios: + maxItems: 1 + description: + An active-low reset line for the Bluetooth core; on typical M.2 + key E modules this is the W_DISABLE2# pin. + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include + + mmc { + #address-cells = <1>; + #size-cells = <0>; + + bluetooth@2 { + compatible = "mediatek,mt7921s-bluetooth"; + reg = <2>; + reset-gpios = <&pio 8 GPIO_ACTIVE_LOW>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 88981d9f3958..218bc2a21207 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13818,6 +13818,7 @@ M: Sean Wang L: linux-bluetooth@vger.kernel.org L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) S: Maintained +F: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml F: Documentation/devicetree/bindings/net/mediatek-bluetooth.txt F: drivers/bluetooth/btmtkuart.c From patchwork Fri Apr 12 07:30:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 13627051 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C297DC04FFE for ; Fri, 12 Apr 2024 07:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUzjS40rszo0F1OY0Ld38HFh2a/iErYAvinYOOhpf8k=; b=W/SXVjNIUE2Ai8 vEWRWwtfh1ZeQw90PQwO8fGudop+wt4WZUhtWlaQCh0ODmAUg4suku49GLuOwDBVduxxBSnMKqpSx pKJt+uMZXqdyyYT0T17qBcg43xpVMNMU/Xw6cxVBCck8UcREDAPBMf9g67d4aj7HOviVu7qDzFoMU vIIob+S3/N2H2Jo74rbqLx6acsUySyeFbDXi20MhdFxP4mqI4G1THNf7a07E2iBtXlNSSueDQCVAI RPDrj4TxnTr9VeeEE9M/2jSSi36xuLHo/RKRZlwwx7A6Y4OoFPl167cmA14hbtb6npKOJghBOGBL6 DgY3bRbOm0J0FlEoBftQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvBNN-0000000Fr1X-1EKH; Fri, 12 Apr 2024 07:31:09 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvBNH-0000000Fqvx-19rO for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 07:31:04 +0000 Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-36afd27170fso2870345ab.1 for ; Fri, 12 Apr 2024 00:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712907061; x=1713511861; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5RdZHSk4TFU7CzZXHHxRZDn956keZAqDxJBl6Nwvleg=; b=AtHLPww6OYyXPFCjkHI4WG/zwAzfyQDeR9vkAuiQuAlLz0TWPgxmlnYEJObRw/5jQu GdkLaZrvKmZILdIF0x2TfDAqOi02xdwL7iQXzccwmOGvbeUz2WYipiDaMT+obRIO993i Pw+spsgpS7lVDGOlKlOVMQEiRr8Cq3JH1nzu4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712907061; x=1713511861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5RdZHSk4TFU7CzZXHHxRZDn956keZAqDxJBl6Nwvleg=; b=EzTGLwHCUQOIcG11OpSUEJKjRUf4O0Hbgx/dfdt/MyXv5/mxWl2YdzGeCC0kIDAKt9 zh/rGG2yflqHPR0rqZlFTXOUhwOa0egVITQ09nTA7m3jUP+JrXCm814xOHalEeCxnpm3 E77IJQ6Cy58glQB7jP2B7zWP7WexmvJSHCvg5uDACzNhCcheV2Ex7JK7vH2vHcYrZxfb MnJfrxyVxb6DUtVxhJx4kGmFyjIbzckVDirYVju9viUYW92eWD0zx7ZZgXQfHGMcYnPa 8PMAUeh4GuxWmsHt/dHAQ2ofqUnc4QvRde0FhxqF9vNx3WcLQOJ1MExtnDjKkOOYsenJ Rh4w== X-Forwarded-Encrypted: i=1; AJvYcCXU6LPwGbe1y4CsfLXPTEUwSTRYHBtJsJcsRj1WMjjGihEC76GI/A92IhWplBHQ5VcA9Y4OqTFXjl53U+WhdD/LJm5reeiF4ITI531phcTv2/6qFVE= X-Gm-Message-State: AOJu0YwTutfgelSFUbnK9DAz8fJ4v0HSY/z3ZD0TpS8dAt8bKQYg/vvr BvGWzqwmgjgtr0/v/ggCbkQTyW5t5l8/BxfXDrSm9v5BPG6Co+gZ9L3KJCE84Q== X-Google-Smtp-Source: AGHT+IEL4CHJZN6cyV51F6bVm8k72tn6WE6KhBCBOK+lKr3ueEZGkvYYXfBhK3hbMLBmSdrvlM2k9Q== X-Received: by 2002:a05:6e02:160a:b0:369:9492:c24b with SMTP id t10-20020a056e02160a00b003699492c24bmr2090150ilu.10.1712907061055; Fri, 12 Apr 2024 00:31:01 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:e3c8:6e1:dcfa:3e8c]) by smtp.gmail.com with ESMTPSA id d6-20020a637346000000b005d3bae243bbsm2149609pgn.4.2024.04.12.00.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 00:31:00 -0700 (PDT) From: Chen-Yu Tsai To: Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , Sean Wang , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node Date: Fri, 12 Apr 2024 15:30:43 +0800 Message-ID: <20240412073046.1192744-3-wenst@chromium.org> X-Mailer: git-send-email 2.44.0.683.g7961c838ac-goog In-Reply-To: <20240412073046.1192744-1-wenst@chromium.org> References: <20240412073046.1192744-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_003103_367867_C774E4A4 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Bluetooth is not a random device connected to the MMC/SD controller. It is function 2 of the SDIO device. Fix the address of the bluetooth node. Also fix the node name and drop the label. Fixes: 055ef10ccdd4 ("arm64: dts: mt8183: Add jacuzzi pico/pico6 board") Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- No changes since v1. arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts index a2e74b829320..6a7ae616512d 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts @@ -82,7 +82,8 @@ pins-clk { }; &mmc1 { - bt_reset: bt-reset { + bluetooth@2 { + reg = <2>; compatible = "mediatek,mt7921s-bluetooth"; pinctrl-names = "default"; pinctrl-0 = <&bt_pins_reset>;