From patchwork Sun Apr 14 14:46:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumadhura Kalyan X-Patchwork-Id: 13629019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B44BC4345F for ; Sun, 14 Apr 2024 14:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vxwqJQSUbelUYV3DDIX3zVCQn3xRtMjvCrVEtkow850=; b=p1sr2IDgeotsEX TU9whej17SNMfnLZNXNsnXZy9GJ9Xebo1b7D1eK96mJfMhWeyGySj6wpQSfHN1fQRJUn3oS1eF/JQ geucfZLQ53tRkaFLXAvc4n8uTjQInGvT3rB6DVxClKPfkhn8+vrnNTz2tsNw2IUPMXQp/QtkRE3YV Sx2fTXEWExkHiHyWV4rZ2MgqHLkL2sk+khiH4d37UXgGwZ8eptSAWB/EK/1Ma8iWQx4jFs/3B2lqd vSY4pQL5yFJlA4rgBSICB37/C2ttbVrt6gwaeu/nsxtRRXC/sl9xwF5bu94rE0MyVPdxf2xAXKxs7 5biTQz/0Qhkw9H068WLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rw17s-00000005fo8-12bn; Sun, 14 Apr 2024 14:46:36 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rw17n-00000005fnB-2MCO; Sun, 14 Apr 2024 14:46:32 +0000 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-5f415fd71f8so1882757a12.3; Sun, 14 Apr 2024 07:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713105990; x=1713710790; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B3tViLkTicsEqeEJWOwiTN/e7BHPxS/OI+grJULG3HM=; b=BxxGM7PaOHuQbzDMGqs/VdkbwcqYBEVVmS1kLwHENhBw4BNgyx/lKlnL3vKRSDMCQ0 2smSEloM+heqGpc7zygaV+I+q4rbBkChInEIII2ZYOG9jrZW6qPNfOIJMMuPr2kZoR7k /bb8ODy2fPgHXS0Mia2utoibBsg1duCHCDvUdm7JH3gMRuo4MQvlJzH2HAN7naPzhOdj SU3KjkrwIbUl0hcryk+UbTibHUQXuheHMR64jkp9ExktwtlL2fzP0zYj7Ygxsy5OUIJb yCov6bY1ClzJsQp9wIFIN3WN5fN7a0BocmowYNudl0AzOfZCjGR2THLXxqV+HjVKYu8s GHpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713105990; x=1713710790; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B3tViLkTicsEqeEJWOwiTN/e7BHPxS/OI+grJULG3HM=; b=IyR5LDX3Iw5Wd6mdB6S9NxRGW6fJJkDIcC/FV1cUm2ZBGyKS3gndaBmiLX8HaNj4H7 YVpTtGFG9h9otzA/XBhXUMFBWRjnLsRV1DkcA/YgCsxP5tpwsjZNVXrrAz91P+DlXSlH kf8GTsKUyjdy6wKH5tbrDq56r4cQsQxtCQUeMlcg+kc/ukBxst09gQi8w9pbqDltXjqa XGUtSSHtrbAMTrtycGAhl1fuob9USmxCI3khjh+V7X1FVQyezOf+1c1WCV0qISZKXybg aOTC3UlVrthPaKt7irGfju+hw0EnQCKZxVnnaW7AT8ejGWOx2uGwHuVFwTfdaDbTOoYh 7xzA== X-Forwarded-Encrypted: i=1; AJvYcCWiDVaoGg8nUGn46RIlzQQLmuAqwTmmJ45TVk8Nqz7kKDnp5q4MU4+5UYYWCF20aMKxDa9mly0DkM3Mk1K5jW4bJxsJrjnmaLwY5GektXf/GDNBvHY= X-Gm-Message-State: AOJu0YwnJm7lcA8XtkG7Ha5OJrPf14BQ1QOhP29GRVuUzKkyt6iymVs+ zGowQd4kDd8uV00Jn4pBu1jcNkhHZNz1n7esn0q6JeWxfv1fbJJF X-Google-Smtp-Source: AGHT+IFZq/s/lmveYTlCBXK+H1HNANw04Kjky+33wlLezYN9D6uBCi2pfeFOVwDbLR348xK5M/fbwQ== X-Received: by 2002:a17:902:eb81:b0:1e4:7cc5:2292 with SMTP id q1-20020a170902eb8100b001e47cc52292mr8096811plg.49.1713105990200; Sun, 14 Apr 2024 07:46:30 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:1cb8:5ab4:8eca:a8e7:b24c:7514]) by smtp.gmail.com with ESMTPSA id d15-20020a170902654f00b001e41ffb9de7sm6196325pln.28.2024.04.14.07.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 07:46:29 -0700 (PDT) From: Sumadhura Kalyan To: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, gregkh@linuxfoundation.org Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, sumadhura kalyan Subject: [PATCH V3] staging: vc04_services: Re-align function parameters Date: Sun, 14 Apr 2024 20:16:14 +0530 Message-Id: <20240414144614.125672-1-opensourcecond@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240414_074631_629979_9BD5CA70 X-CRM114-Status: UNSURE ( 9.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: sumadhura kalyan Checkpatch complains that: CHECK: Lines should not end with a '(' +typedef void (*vchiq_mmal_buffer_cb)( Re-align the function parameters to make checkpatch happy. Signed-off-by: Sumadhura Kalyan --- v1 -> v2: Repharse the subject line. .../vc04_services/vchiq-mmal/mmal-vchiq.h | 29 +++++++------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h index 09f030919d4e..98909fde978e 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h @@ -42,8 +42,7 @@ struct vchiq_mmal_port_buffer { struct vchiq_mmal_port; -typedef void (*vchiq_mmal_buffer_cb)( - struct vchiq_mmal_instance *instance, +typedef void (*vchiq_mmal_buffer_cb)(struct vchiq_mmal_instance *instance, struct vchiq_mmal_port *port, int status, struct mmal_buffer *buffer); @@ -101,31 +100,25 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance); /* Initialise a mmal component and its ports * */ -int vchiq_mmal_component_init( - struct vchiq_mmal_instance *instance, - const char *name, - struct vchiq_mmal_component **component_out); +int vchiq_mmal_component_init(struct vchiq_mmal_instance *instance, + const char *name, struct vchiq_mmal_component **component_out); -int vchiq_mmal_component_finalise( - struct vchiq_mmal_instance *instance, - struct vchiq_mmal_component *component); +int vchiq_mmal_component_finalise(struct vchiq_mmal_instance *instance, + struct vchiq_mmal_component *component); -int vchiq_mmal_component_enable( - struct vchiq_mmal_instance *instance, - struct vchiq_mmal_component *component); +int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance, + struct vchiq_mmal_component *component); -int vchiq_mmal_component_disable( - struct vchiq_mmal_instance *instance, - struct vchiq_mmal_component *component); +int vchiq_mmal_component_disable(struct vchiq_mmal_instance *instance, + struct vchiq_mmal_component *component); /* enable a mmal port * * enables a port and if a buffer callback provided enque buffer * headers as appropriate for the port. */ -int vchiq_mmal_port_enable( - struct vchiq_mmal_instance *instance, - struct vchiq_mmal_port *port, +int vchiq_mmal_port_enable(struct vchiq_mmal_instance *instance, + struct vchiq_mmal_port *port, vchiq_mmal_buffer_cb buffer_cb); /* disable a port