From patchwork Tue Apr 16 17:37:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 13632258 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49FC4133435; Tue, 16 Apr 2024 17:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713289038; cv=none; b=ID8Y+5BG8lqHzEajBe/tilwZkmA3ifSuAwowzPa47unIJ3SudfM/Fs614yW5kBGBae5RXTA9jPSPuOESvnYDd39Yi7wCZBbAvxPcopoe2Jtk3qdWfgtYbed27mMNb/RGHyNI8ojgbLND6T9bM2leSXTDoNd9LwwAXo+44hwVYNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713289038; c=relaxed/simple; bh=EjV2famXhIb7IZNI071UhvkpAcAeqfFS/DP81q74RJY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=b/meY4vDE5p/0VAM3cKK6Pu3+BMcWZjb9FUHA0OZtBXuLzI1IzeOyebKYZE6kn0K3JwKWxxo03id08Ym4/qmzoLvHhqGrBZzSqk8AtaasXLuPHRMTFXiN2kccT6/d37FyyfPBX5IHeVciB+rX5KQUx9+mtES7PIGMwqksK8IJ6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N8WPemrt; arc=none smtp.client-ip=209.85.219.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N8WPemrt" Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-dcc80d6006aso4621907276.0; Tue, 16 Apr 2024 10:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713289036; x=1713893836; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fu3d9ue0RJEN40rHB+pClBdAIk5T18keph2dg8V6BMg=; b=N8WPemrtbc+OeBYGbUOwmrMhLdu/QRn4aX4DP/AFgvMyTXEeWyOEKrP4DeAWd0cyvF XdYW7cIT/zTD3wg/OEJV5LVQsdgCEPAFqKzZBNrLLKfsd38HMb8QUj3bDxqPaaEhhdNp 3OXzlAYE7leBeqbZhRRf2UWhWjc6qPomcfkw9R0EkCzwMizrzJjAKhzSuS6vNNE/eHzy TtxJKcalw9wXlLi/aHNXX+7wSy8WnpukYxkj/O4Eir6XAzqBBl7UeVlO6MZskjikjr0+ cckAkxkGO8eGZoLEovP/fnYyMDsgDTLOU5ZjpdZgJ6OSbxC8oIek8JUIJtt4nVD2fHWU HKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713289036; x=1713893836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fu3d9ue0RJEN40rHB+pClBdAIk5T18keph2dg8V6BMg=; b=moxAzyODITX2Ojae6war1BnoG9xpIh6ZRND78AnsBVOXMlCZRRrZ7QrgMKRDvcAb6c Hx7NnfPZK18BFWtRpIG2TRKY7bGZ5VqX+fDyYdyJ7bDmKRo3N6y6xdKvfVirIKdLuGbL c86ru9MINaNcNAnH2MVofWkj1mtAlFGmQEjEOy/lkNEQMLTQ8RO7tZJZXGuoq8QpMz4M aaZ9qgL/XZXJe3BM4jfk0aRO82ZzvabrV2B74y6H4/1HxeNrhg3wHQUz1IsGhvgcoV+s UcePx7TYJmitxHvYN/SjO3gm6xe1APrVZGTgcknsTDLxJhFnTyEUgzfjdzW7UOsMVgxg lwLQ== X-Forwarded-Encrypted: i=1; AJvYcCX/kXpUZz4+JjG1f7NSKxntqX9fU/JGcTwZWbTK8vGg6yhEYSJVakO4sGKb8/eOoOrtoEf/vcBBKhOeHi0pxE/d7qBauU9x4ByUF+veY1vxV1H07ZxoRf1EGSzT+jvg+JEfplq+CJE7Ow== X-Gm-Message-State: AOJu0YztJWY736VBZE34ZsN90gCJW2KRjmu2atbLTYiKlWkny6pHJr81 jrh5yqB+RlPypq1TRVxKjJXqzK+rTGEuquXr9hWaDMkIy3tiWpvYB11Lzg== X-Google-Smtp-Source: AGHT+IGpi4j7BJBWcfngMBM3FmhJTvcQtjqX7peZRqeqRJXKrj9I7NEaTrypsMKeO6hPZwC3Bg44ew== X-Received: by 2002:a05:6902:2b84:b0:dc2:41de:b744 with SMTP id fj4-20020a0569022b8400b00dc241deb744mr15263478ybb.32.1713289036231; Tue, 16 Apr 2024 10:37:16 -0700 (PDT) Received: from localhost ([2601:344:8301:57f0:2767:ac3e:3052:cd0]) by smtp.gmail.com with ESMTPSA id c6-20020a258806000000b00dc6d51c8555sm2486186ybl.17.2024.04.16.10.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 10:37:15 -0700 (PDT) From: Yury Norov To: Thomas Bogendoerfer , Florian Fainelli , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yury Norov Subject: [PATCH v2 1/2] MIPS: SGI-IP27: micro-optimize arch_init_irq() Date: Tue, 16 Apr 2024 10:37:10 -0700 Message-Id: <20240416173711.613750-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240416173711.613750-1-yury.norov@gmail.com> References: <20240416173711.613750-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The function sets adjusted groups of bits in hub_irq_map by using for-loops. There's a bitmap_set() function dedicated to do this. Because [0, CPU_CALL_B_IRQ] and [NI_BRDCAST_ERR_A, MSC_PANIC_INTR] ranges belong to the same machine word, bitmap_set() would boil down to an inline wrapper in both cases, avoiding generating a loop, with the associate overhead. Effectively, it would be a compile-time: *hub_irq_map = GENMASK() | GENMASK(); Signed-off-by: Yury Norov Reported-by: kernel test robot Signed-off-by: Yury Norov --- arch/mips/sgi-ip27/ip27-irq.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/mips/sgi-ip27/ip27-irq.c index 8f5299b269e7..d8acdf0439d2 100644 --- a/arch/mips/sgi-ip27/ip27-irq.c +++ b/arch/mips/sgi-ip27/ip27-irq.c @@ -277,7 +277,6 @@ void __init arch_init_irq(void) { struct irq_domain *domain; struct fwnode_handle *fn; - int i; mips_cpu_irq_init(); @@ -286,11 +285,8 @@ void __init arch_init_irq(void) * Mark these as reserved right away so they won't be used accidentally * later. */ - for (i = 0; i <= CPU_CALL_B_IRQ; i++) - set_bit(i, hub_irq_map); - - for (i = NI_BRDCAST_ERR_A; i <= MSC_PANIC_INTR; i++) - set_bit(i, hub_irq_map); + bitmap_set(hub_irq_map, 0, CPU_CALL_B_IRQ + 1); + bitmap_set(hub_irq_map, NI_BRDCAST_ERR_A, MSC_PANIC_INTR - NI_BRDCAST_ERR_A + 1); fn = irq_domain_alloc_named_fwnode("HUB"); WARN_ON(fn == NULL); From patchwork Tue Apr 16 17:37:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 13632259 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3BC134411; Tue, 16 Apr 2024 17:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713289040; cv=none; b=JTo+4DXZFf8YJ2VCuToct64rFQbE30icjxg2Pab4X4+GrvBDHaSZzQs7PHlgtIdC4+gtVq7mPglTnn5+9/hvNV0PyuO/HXTrT9TQCsDY0NGSj/5J5vmnTcAKrDBb0F4za6UD5i7scl1T48bF5r1LMe8Anu5vJIrTfFBpTdPicvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713289040; c=relaxed/simple; bh=kCXkydWYRKWeR7tI1rDndpU6YNBEBtTWlczdEFMI3iw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HuyMIw9FBqOIYq3fkotCQ/UpfFpeXItVDLKNVGSDW5VhfcRjcmzIXOgL+l//Nzk5wqB2o1BaT8OdmwYd29AuPsZJE5PFRNyTYAwUsrzhQ6HI/zVeErGZw0MrBX2nmlExwydPJKnndvTa0rhmXQsQ+OjUVQS78RwrBvQqhA8UsoA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fqqqZymI; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fqqqZymI" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-61acfd3fd3fso27009777b3.1; Tue, 16 Apr 2024 10:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713289038; x=1713893838; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CEJ4Kzu1ZMQKDN5Ea8M9owwXpw6cPm4vJBsPoRrcQW0=; b=fqqqZymIyO69r/+uAwkMTu2Zg0s0bPITU5/UNsKK1l/h/7zQrgE9CvMKEp/f8hM4aw 1qzDFedajjPK2CJdH+VdeUNy1m7SgXdKNQwBmPYUfsE/19uDpbLTF8HZal4LL0+h23B+ jy4FCTjyjMdJSXm5lech0UFmqxG4EnHKv+rMRVSDiHgiGdS2EvmfsovbrEnF/KdlkECK wCfh5s9/1JP0rdHgU0Wznsbf2wJWIfYNi/5+6tzB+NXf55hNMEYxxc7xqamWGUlZnyDx BUZjUMpkXl4x8i0k90QADI/g1reaOJ1MkYr/P3UtEjXyIa6LIfl9T04nAoAP0+9coke2 MGiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713289038; x=1713893838; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CEJ4Kzu1ZMQKDN5Ea8M9owwXpw6cPm4vJBsPoRrcQW0=; b=kVOPpN3d4CjUYH0Lpde8XGFlH+Apy2JaVrIlGkMOdA9rCqrJAg9ZNB1YXMCljroGoV fWUwfUZRi0MF5VLVJ6+0BIdmhBcGA8jp3Hd7n6FiqQBwHNLDWGUxLIf/Upc9zlh0H47R n1KY4oI1EAxVtphvOHcNPSWYHea1sdgzPWfeUsXQS6+Bcz1WWNG/p6b7xHUPRf1XRWtp 0RVLPDnc8aSqRUMfwNj2cMfxiF4rcGzVHJXlOFdjuCUeskxC++UgNnYeg6oScRe1Ehzb VxLaS8XfHwa91KggC5ZhC82s17zEUjArIFyzP5lhi6vQwJJuT48d4izbD6cBcXZd3y5v IY+w== X-Forwarded-Encrypted: i=1; AJvYcCU1sSzWbdzx0m46l1dYdCh4vXBo7Ds3qo2tkOxhXierydObq/FkRNePaZSu2cEpudHv0cI/rUfF5fDwnYKbR81Ec+vTUDEnRdS7YhPE/hmaPf+zBqWMv5rkNC2CWvpBI8yxlVM69jdiMw== X-Gm-Message-State: AOJu0YxJG9hinlbiFhFDzmLshJleouOsPhP3ej28lDb5qwS5rtRcWzaA X9HXM/UAmFiGA+os23a/z9bR+PXp5jPwP+efcYN3FujvPcOXF1kvEdFDQw== X-Google-Smtp-Source: AGHT+IG7MGMWwZqNEMCRBfFRsR92czsXN34/Nje9Ozynleb2QnQrYFzNBnsetytngtZGkiAhzVn2mA== X-Received: by 2002:a81:a00f:0:b0:61a:cf94:97b2 with SMTP id x15-20020a81a00f000000b0061acf9497b2mr7153482ywg.8.1713289037837; Tue, 16 Apr 2024 10:37:17 -0700 (PDT) Received: from localhost ([2601:344:8301:57f0:2767:ac3e:3052:cd0]) by smtp.gmail.com with ESMTPSA id m124-20020a817182000000b00611213d62adsm2582820ywc.124.2024.04.16.10.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 10:37:17 -0700 (PDT) From: Yury Norov To: Thomas Bogendoerfer , Florian Fainelli , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Yury Norov Subject: [PATCH 2/2] MIPS: SGI-IP27: use WARN_ON() output Date: Tue, 16 Apr 2024 10:37:11 -0700 Message-Id: <20240416173711.613750-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240416173711.613750-1-yury.norov@gmail.com> References: <20240416173711.613750-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 WARN_ON() propagates the result of conditional expression, and it can be used to return early in the following expression in the arch_init_irq(). This is a no-op cleanup, except that compiler may optimize the error paths better because WARN_ON() implies 'unlikely()'. Signed-off-by: Yury Norov --- arch/mips/sgi-ip27/ip27-irq.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/mips/sgi-ip27/ip27-irq.c index d8acdf0439d2..00e63e9ef61d 100644 --- a/arch/mips/sgi-ip27/ip27-irq.c +++ b/arch/mips/sgi-ip27/ip27-irq.c @@ -289,13 +289,12 @@ void __init arch_init_irq(void) bitmap_set(hub_irq_map, NI_BRDCAST_ERR_A, MSC_PANIC_INTR - NI_BRDCAST_ERR_A + 1); fn = irq_domain_alloc_named_fwnode("HUB"); - WARN_ON(fn == NULL); - if (!fn) + if (WARN_ON(fn == NULL)) return; + domain = irq_domain_create_linear(fn, IP27_HUB_IRQ_COUNT, &hub_domain_ops, NULL); - WARN_ON(domain == NULL); - if (!domain) + if (WARN_ON(domain == NULL)) return; irq_set_default_host(domain);