From patchwork Wed Apr 17 14:27:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Chevallier X-Patchwork-Id: 13633450 X-Patchwork-Delegate: kuba@kernel.org Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27117140397; Wed, 17 Apr 2024 14:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713364049; cv=none; b=fPVfzLUyIICJC2WLNwsRQaGbFnjDDQxwpw3oSIILQPngbTeue28Ks0d6P+gw4kL9qotPRL/vfaJpGc1urikuIjSyREdP0zjB/1FTssfCEsqZFzwjHLFRvWyC8eFfl3RAnbu2hwQuOKaeJI+ZwJMplV6MuuEqt39DAfCG5Xw+Le8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713364049; c=relaxed/simple; bh=K+f/3Fw0l/IbMbZkGP+l5j+8E9MRO2mxZSVM7HRjjgU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Tho4BYbHbMpkme1FZrnPq35Y75vHQBMoD1jYLIape1Uq02nIaxJ8caBbOiKUxk1BtKCKYR4hHlhvR9IZWAdtvO4TPUnP6pnEVBbXRf7IrrEt4zTeYEJQS/lMCmfPFUMYz9kMD9yeuNwe9QzsxQnRNmme0K2iX++2yfnatAuuny0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=XCQvZbM4; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="XCQvZbM4" Received: by mail.gandi.net (Postfix) with ESMTPSA id 4F879C0011; Wed, 17 Apr 2024 14:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713364044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+gblB2roJbwC6k0Ap41QA3FYglfv4FFJz0F7EnAebFE=; b=XCQvZbM4nqNpj6mMFURbYjC7Sp/+tvMg/HEtaMxlh0cCcgU3JtIHPxNUETADzJzzbISEUG CwbRAHSEthGj0nEzp1Ab6SSx0aRONpZkAf6zrALy0SOA/d35LpzEiU55ZtmAsbfGCJu3AS 8x33SC7ycOCYTD9XSUvlGipx1+lFMbdavNFj2hp57pzYBUsdeRuwkZe+jkGOKCuukXpBlb WMOt/ByIdnwRdgLm71mwRbFK2v4NDejcZh9Gh7rqQfro20z8PhhEHNHiaisDcLLCPF9u6l +iSysDrG9ODCQSLJCVUgpJ8qZ/flJ93DOGL0YStli+0eiXVTEFJBZp39bnBOjA== From: Maxime Chevallier To: davem@davemloft.net Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?utf-8?q?K=C3=B6ry_Maincent?= , Jesse Brandeburg , =?utf-8?q?Marek_Beh=C3=BAn?= , Piergiorgio Beruto , Oleksij Rempel , =?utf-8?q?Nicol=C3=B2_Veronese?= , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart Subject: [PATCH net-next] net: phy: link_topology: Don't stub-away the topology creation Date: Wed, 17 Apr 2024 16:27:05 +0200 Message-ID: <20240417142707.2082523-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-Patchwork-Delegate: kuba@kernel.org Some of the phy_link_topology operations are protected by IS_REACHABLE, which can lead to scenarios where the consumer, built as modules, sees the topology unstubbed, whereas the initialization didn't occur. Don't stub away the creation of the topology, it has no dependency on any other parts like phylib, so we can make it always available. Signed-off-by: Maxime Chevallier Closes: https://lore.kernel.org/netdev/2e11b89d-100f-49e7-9c9a-834cc0b82f97@gmail.com/ Closes: https://lore.kernel.org/netdev/20240409201553.GA4124869@dev-arch.thelio-3990X/ --- Hi Nathan, Heiner, I'm currently at EOSS, so I'm sending this patch without having been able to properly test it (build-tested only), but as this addresses an issue for people using -next, I'm sending this anyway, sorry about that. Hopefully it can address the issue for now, I haven't given-up on your idea to introduce a config option Heiner :) Thanks, Maxime include/linux/phy_link_topology_core.h | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/include/linux/phy_link_topology_core.h b/include/linux/phy_link_topology_core.h index 0a6479055745..61e2592f24ac 100644 --- a/include/linux/phy_link_topology_core.h +++ b/include/linux/phy_link_topology_core.h @@ -4,22 +4,7 @@ struct phy_link_topology; -#if IS_REACHABLE(CONFIG_PHYLIB) - struct phy_link_topology *phy_link_topo_create(struct net_device *dev); void phy_link_topo_destroy(struct phy_link_topology *topo); -#else - -static inline struct phy_link_topology *phy_link_topo_create(struct net_device *dev) -{ - return NULL; -} - -static inline void phy_link_topo_destroy(struct phy_link_topology *topo) -{ -} - -#endif - #endif /* __PHY_LINK_TOPOLOGY_CORE_H */