From patchwork Thu Apr 18 21:51:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635469 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B169199EB5 for ; Thu, 18 Apr 2024 21:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477131; cv=none; b=AMVllV0k+Up1nLJnMY5DFWhzNIij9zYejxv/C+c/1Ke+yKrKlee1WLmor67rLcBpEOVURVr3RHGJG9GppzKg7sD+Zu7XfTRHYDMb0b2ehTYQgk+0POEUYAugmd9HMbs7GKMK9/YHd2OdIRQWaDnwSeckBhEUziYID9qLDv6TFz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477131; c=relaxed/simple; bh=a33aUx6uDd7fCJDKDyyVt9kCWO0ewSQOAwf+wVOH64Y=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=u9tZqEzwvPeCIX9J8Bk1t8MopsxLtJ2Qb1VGzpEzPacbdt+KEkJ7i7Ph8fECwv7Chp2ROJpBXgYpf9q430mavjnXPY1x8KwHPH+C5z6Zgmjf5+VawuXXjrxlzTPkGMN27cECDmLqZ8ULBhRQrEhKSb2sHhYL3iOkMuzzpE7dTnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LaZ5wWOw; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LaZ5wWOw" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-417e327773cso14360255e9.1 for ; Thu, 18 Apr 2024 14:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477128; x=1714081928; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=dWDYRnXiT5ALn/eZBaAfW9pu9IafcMSa7MSKor8obBY=; b=LaZ5wWOw90ZrN6wCm1IzaBOhcKXJbOejFYliDjyD+ku041kcjlYOB9iYDdi6U9WYuL 5xvKQcZ/ZrnKKEoHujsce+FNzGTkSJRhHCXShEkgDiF0fxwqfEYxpTlkuh2uMux37nrS YIgBb9Sp/Duj7ihdGFXgaAEzwQtN4XSYkWviiEGSbBjExRpCtYZVSI4zIfG9o4/TgaRx Nd4WJC4RJ8lJ2KkWU1sAyDVr4aNpoVjn0W1sixveB7hsvnORhlMAFbXrpnX0ch6J6F7M Z5YJatg/8FnvBqQFnDZjKZRhby1S7OcsR36m/se2iHyiqBLzfO6eaEu/uYNIo4LSyAHK mkjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477128; x=1714081928; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dWDYRnXiT5ALn/eZBaAfW9pu9IafcMSa7MSKor8obBY=; b=KOkaQmoay2lgL1qzdKXnVXTbG34obgqyy2VKaz7BPJTrFS9ncgJMcOcevqEmRd7fwv zs/QJAVWK64AF6uzRpXIoPIvzAeTRRjf0VMMTRUMNlGXCTJyZbpNPyyLxPhQG02qdOcB 56Ax1s3/EsD0FOZ7g2u/wkMHw/pMggxcwVZYk3gAfTsGhnuLnnmqNw2gsZ0CxpVTpk3m yHGk3LegYY4M9YNKkM6Pb11hk+wDVadyav5PfjVIckAscSVOQYKUgADWWLZ0FcaOJVvA hRbNNia6ZkX5/sA5R7cFELn7rh578bvfbc75MinYs/gM1kEy+mB34a8rnQpZbsKlC7MA 4TiA== X-Gm-Message-State: AOJu0YyXhpWcnlAi7C97VIBJmK5DPHF5yqJ26M7LDktCDVzUYrDiyeRW JQJdr+OIKoevkvs0oZ6RQSfAt9LlKRcIn+9xYaud6t9+wyC1p/BKqG72Ag== X-Google-Smtp-Source: AGHT+IGOS3+KVI0wKitPGBAxCM00ZMY0rT8vdQRUBzo9hNkY8vj1B6ADwVZEAzNQcALrp7YDsraHPA== X-Received: by 2002:a5d:6184:0:b0:349:e211:e4a5 with SMTP id j4-20020a5d6184000000b00349e211e4a5mr2462837wru.8.1713477128191; Thu, 18 Apr 2024 14:52:08 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id n2-20020a05600c4f8200b0041884b79b81sm4079944wmq.1.2024.04.18.14.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:07 -0700 (PDT) Message-Id: <4ced981b82e9978116592ad6533b683192d33bba.1713477125.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Thu, 18 Apr 2024 21:51:58 +0000 Subject: [PATCH v6 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Although we've had this script since 4d06402b1b (contrib: add git-contacts helper, 2013-07-21), we don't mention it in our introductory docs. Do so now. Helped-by: Junio C Hamano Signed-off-by: Linus Arver --- Documentation/MyFirstContribution.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt index f06563e9817..e41654c00a6 100644 --- a/Documentation/MyFirstContribution.txt +++ b/Documentation/MyFirstContribution.txt @@ -1116,6 +1116,15 @@ $ git send-email --to=target@example.com psuh/*.patch NOTE: Check `git help send-email` for some other options which you may find valuable, such as changing the Reply-to address or adding more CC and BCC lines. +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + +not part of the core `git` binary and must be called directly. Clone the Git + +codebase and run `perl contrib/contacts/git-contacts`.] + +NOTE: If you're not sure whom to CC, running `contrib/contacts/git-contacts` can +list potential reviewers. In addition, you can do `git send-email +--cc-cmd='perl contrib/contacts/git-contacts' feature/*.patch`{contrib-scripts} to +automatically pass this list of emails to `send-email`. + NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but please don't send your patchset from the tutorial to the real mailing list! For now, you can send it to yourself, to make sure you understand how it will look. From patchwork Thu Apr 18 21:51:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635470 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0352199E87 for ; Thu, 18 Apr 2024 21:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477132; cv=none; b=YR5Df3slTO+nYFR+0zAIqS0gJ2xiLdB0E1706/daa5HDW99IG/fIIDpksugPq0AnIKwDiIrR8WBgc4h3nOKqbrpYJWZ+34sRGN6P3RTDHVZ4Tweg1SAB6/uxrwfoFHW4A5NLZFMoffSRX5xnVEn5xH5d2B1C4rq/01z2CNIivaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477132; c=relaxed/simple; bh=Go1i3gWV7ueko/MvAzRoptBPHsEqivRITvJiUj0BCJs=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=t0W0wSLi1RJJQPV0qn+I7xC9MoPzoCu0/kjuqcvmoj3gueESMXuV3ZFSXiN5UBDWaB3vq/dQeujYwPfCTt3Dq5GcOnDmWNzd/FI9HWovIH9Kz6z1dbRhMBKenyh5jwUuJ5XugPbjzDwFn4p9n998yMXTtsLSPhOxAIPIUwYAxJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TmDVvb7G; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TmDVvb7G" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-41551639550so9707845e9.2 for ; Thu, 18 Apr 2024 14:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477129; x=1714081929; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=y1QFBaAsqZYFIx/JQD0X57hfvYi+kiS0nMiL94V0cwk=; b=TmDVvb7G3rYS1GMpwC8lxikP8KUnwuNbAoC5MeejeEhMEMc/jR99+Uz9Vszf80/xLw owcO5Vpg+xxEVghRRI5ohUI8vTYOXMgJVPFY2QXfxeWw4BaOrdoYyQPzi8n+ctd7vxae Bw8Y1MH3eEj/houKUo9uAqdfuTSrD+1pTCu18emJ8C0iLCFfvfi27VsuqTDf+V7h9mN1 jrOXcJy/GR5+hScB9E1qPpYeAJBpOh54E1q84Gci0okk/l8gJ2rLva5TTEE7mU7Z178l rS+STpqcw6KUKhW22aVsh+smhm96l4hLNU/F2w8jPFhxm53aVobcvwlyIO29oDFsEQu1 MXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477129; x=1714081929; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y1QFBaAsqZYFIx/JQD0X57hfvYi+kiS0nMiL94V0cwk=; b=WG15eGsuhXB3j2bG2S3vl6hIIssL7LueMH8CfPZoFmhV6FZK1yvvpFW4kEVLL7g+OJ bZLcXXBhMMRPwNKPXp1PkMQVBzNEjG2/bhg+GjzBIJ4/sY39SFExnENl4amQ4QBYVGnE cwd4WD11o2OIzphGdndMmLeWfVVHmJDZ1rHOtoUDfaXmFYkU9uM5CatMQY/gB0JqpYM7 GvKAMLBie2qd26r0S6NSCr8jWjxH1OX1KSCoR/wEuQ5hD09XuL1ZF3sIpwxwPL/udWf4 xQMMEXRY4FYXYyEKDA84oFZCUb8+8AYYrnpQrHxpWe1RUabsZs1XSwJprPQb1753vAAQ VQ0w== X-Gm-Message-State: AOJu0YwMWoabahkVNmxu3OL8jP+8+61SzOxngLJG7N6uldPC3k3lZOEx wOW0fVpE8u4wXoOJixLcgFfdBddk5z3XHzTMTfn05cT8majF+mEYqD3bGQ== X-Google-Smtp-Source: AGHT+IHRaiBbMaMC5wjrILKCjGMS5ArK5JGTzOlaBSiBnJaslJGw8c6J+hPaPjnPx1LerMSHtSSXxQ== X-Received: by 2002:a05:600c:215:b0:418:fa37:60c0 with SMTP id 21-20020a05600c021500b00418fa3760c0mr106024wmi.22.1713477128833; Thu, 18 Apr 2024 14:52:08 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id f18-20020adff592000000b00343a0e2375esm2768455wro.27.2024.04.18.14.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:08 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 18 Apr 2024 21:51:59 +0000 Subject: [PATCH v6 2/8] SubmittingPatches: clarify 'git-contacts' location Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Use a dash ("git-contacts", not "git contacts") because the script is not installed as part of "git" toolset. This also puts the script on one line, which should make it easier to grep for with a loose search query, such as $ git grep git.contacts Documentation Also add a footnote to describe where the script is located, to help readers who may not be familiar with such "contrib" scripts (and how they are not accessible with the usual "git " syntax). Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index e734a3f0f17..d4173d4fe84 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -493,9 +493,13 @@ security relevant should not be submitted to the public mailing list mentioned below, but should instead be sent privately to the Git Security mailing list{security-ml-ref}. +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + +not part of the core `git` binary and must be called directly. Clone the Git + +codebase and run `perl contrib/contacts/git-contacts`.] + Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git -contacts` command in `contrib/contacts/` can help to +people who are involved in the area you are touching (the `git-contacts` +script in `contrib/contacts/`{contrib-scripts} can help to identify them), to solicit comments and reviews. Also, when you made trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility From patchwork Thu Apr 18 21:52:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635471 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC74919DF40 for ; Thu, 18 Apr 2024 21:52:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477133; cv=none; b=H1gsjLYCmo0d0H8gTK2PrAWLh19LUKBWFJJkkG+WKfn5uwRV+X8ITD2aSf74uj2I2KwdtmmSL6A4tP7Mg1HVqBoJioSRCzh4wf2OIthjd7AVxSOwIo7MwDVfdcryUG8BwrU18W9mUqS5RqLuHxNZHav0+83XR7xMUnNKIDa50bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477133; c=relaxed/simple; bh=KaawRCSqIwI3Nz31I1au7IthDncYxXQc+wO0oyYv9b4=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=UYYvEFwm73QJG4+lRqxqsRYZ8mm7w1jUd+8ZXkdgfQRRGidmdtdJkyp2DYPGVv66ZWztdCAA/xql2gXsVZ5tDhQMifGWyXqwWKju3COKd/5kz/3jpRZ/SybcuhogwerYXT2CqFJ6MOWfPHxFlTiRjgit0Hn1dNoYbj11z3uCqBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jP8Roz8e; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jP8Roz8e" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-418c979ddf3so10807595e9.0 for ; Thu, 18 Apr 2024 14:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477130; x=1714081930; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=HlY5twN+80OZ4NTMvW6gQ34sTTTkc0q1J4BSPAgByM0=; b=jP8Roz8eKfz/pwad1seNlZLqQleMeSBduMo0DxcOvolJe4aNGW+51Aamp0wow/abPS 3AD9Ul1kz0Xc0fL0vNYgOHICOoR122f/0fKrs29mD66AU3Xh+Ge2v1VRIV4D6hhdSoMP NnigxcM2HPorf4f04Bs1ZYMVTfO9vu2VqRgj6GKn7EiCsEobPp1+ssWJg8zZYxGbihQ0 QyfmKUwhNn90u4J8XiVpvBFMPTdHsnHVrMMTFV1A9HQ2kyMkynwAtoRhdy5/qCo2Iuly NjZOB5NnSmWC5tsDyplpfn6Le12bPm1YYiPTnKcSJFHoMBPJNxeJY1fYOxoLQJZIgfYT 260w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477130; x=1714081930; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HlY5twN+80OZ4NTMvW6gQ34sTTTkc0q1J4BSPAgByM0=; b=D4r33n8q09PDeOiq/71/++CzNVKmNI2uZCxE52V6ZPS8+yvkyKDj3kD9gZIbxT3YXU 12vozKvw1dBGwOxdb0LmT00DV9Prs6o2jPBJumgDTyyu71B7iDyTvLeFcufGvMBxBupz HfPAlmGVOGWJjVnfPrUP1ysCc7sz3l/CdpDlNmxfjpIFoiB0fjfMrYyz6TCfPUER8D7w Yv/E+zo5dP/hRiP6qsxAtWerY+jyHgMO9N8GgMP0vPUHMeKLuf7DkzZt413VJgidxIa+ jWulykW2ztDWq4jQypcWELwS5ZRPq0lpW1y3N7ZBuGs3PXcJ4WLyLZuGR+cwck4PAwFk Vg3w== X-Gm-Message-State: AOJu0Yx6cDhOPJVwgN4oZkNoZb8EupVyCmg8pUt268SrEVdLQgTCB/En ebpX5L8hBZntbB2kYsG78vwkjqkD97SjW+PS6E0kJOmZtqC9gNGQEVaxXQ== X-Google-Smtp-Source: AGHT+IFUhdGXEFcMYuFzl1MjSFO+cg49FlNgpyW2ZjdtDlGaPgFfaKrpRDLZeTcYB/vOfXGNhaFM9w== X-Received: by 2002:a05:600c:1906:b0:418:5ed2:5aa6 with SMTP id j6-20020a05600c190600b004185ed25aa6mr72460wmq.31.1713477129911; Thu, 18 Apr 2024 14:52:09 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c501100b00418f1d77098sm2429531wmr.25.2024.04.18.14.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:09 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 18 Apr 2024 21:52:00 +0000 Subject: [PATCH v6 3/8] SubmittingPatches: mention GitGitGadget Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index d4173d4fe84..26055a1fe2b 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -408,6 +408,10 @@ are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. +NOTE: Here we outline the procedure using `format-patch` and +`send-email`, but you can instead use GitGitGadget to send in your +patches (see link:MyFirstContribution.html[MyFirstContribution]). + People on the Git mailing list need to be able to read and comment on the changes you are submitting. It is important for a developer to be able to "quote" your changes, using standard From patchwork Thu Apr 18 21:52:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635472 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3920C199E89 for ; Thu, 18 Apr 2024 21:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477134; cv=none; b=imAcd7KUeBYnupp3yqP5RVSY0rMTk5UPSJHnrNqz3+MiSIiHYtK5Z2g27hetAmnUsFa1+fq9+snvPwFgojuUossLq8J1yIYorrw6zCYBJfmQQy9WEiaZmOreCVSI+VrGwi0YWXJMo+imuP0B8L5S1yVqjxxHOVjlJfJqou3rCsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477134; c=relaxed/simple; bh=XsDY3ATOGu8qFz4TOBERwKCG3vKCC2dht5Us0lhvIuc=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=OKXoQiG5eTNim08QM29TpXCALK4BykZhZIEcqEO//W+LHFzBnSIci+qKLXYXf2sFIguPYQHum6NNVutT3XCh4WCBTaBCQYZ7DOlmnZbdjIB3xDat+4llDpywIexxokXEqgNeJubxg/uhKRGrM51ktP0Gq7SKYmbgCaaNaqisxRY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iKorNqjS; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iKorNqjS" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-418f1d77adaso7278415e9.2 for ; Thu, 18 Apr 2024 14:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477131; x=1714081931; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=N6cQZIi/4irN5VCcOFdP3ls2MTP1dKp8KP/x+/tqhDA=; b=iKorNqjSioNiN1iwW27IUCMbQlorhrZutZwHrbDRXL7YCasEAHv5REmCwL1EGgnIuC IlpSkRVMoTV4XQGYWQKuzev1EKjvhEiFM6mtwivZPwjr+xYkGU4whjWPogSG29EsgyXd ZhscjuSNS++BrBxNAyySdFdhr354sh0JcVyghj+i+tR8RsmM1r0Xe/7Sh0VMjQUQAqxH +Ep59UOO08uo8X7FAak0vN6OpkV6YB2zw2XT9EVv8xN0DzJ+03BRWh8RNM7N/QuSvpSl pyNqG2vK9ZAbuLpYvSqvEWkP6QTkvUSwYr8x+nK+SPCcVS5x9PksCvK8S7ncgN3o2kJ1 xCDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477131; x=1714081931; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N6cQZIi/4irN5VCcOFdP3ls2MTP1dKp8KP/x+/tqhDA=; b=vAT7jMkyhQ5vDngqTUBF+dnwpOuT4nnql04EuEkB+21stExxIPHsV1gcy4Tw86pXZM aijImfiRveA5ON7oYvCt/FlmMOi5OoFguXcMwZBm06wDAAbpwD9wCXllcgkHpUOkJ0vz QwzU9j11yaKKQWcUBAMoOgkvRIKncTlsAfROC0AKl9t5EVLvDeWFPPB+8sxk7vC7zJXv RLYAL8/TIsb0Zv1fdTCLHjPR0olXyq7kOv6stmMagB9MMJLebtYPY28WnXsfTtIz7xxn zWKopuFWi+dyIjz0jAjVuh3f5jHe/P+MHlTzgk/K8ctg9OidInrQmbdcKKqaePjHgS0C DBWg== X-Gm-Message-State: AOJu0YzN6C5I22ZUG76olPRc1gLTMT0WjHNGAuxJ3MT3N4K2C40C6uj0 ef9ijrNU4cHB7hWZqDSnODev9JnODueerBxxAb00zy+Q1WeTupaZnivrjg== X-Google-Smtp-Source: AGHT+IHXBT6YN5TozSlagOdoKPLq4lWW+ORaUUF3xXgrxAIr0dWnUPzDARMcn8EJLSFvsbOCZclWEA== X-Received: by 2002:a05:600c:1c05:b0:418:a3e6:c5e6 with SMTP id j5-20020a05600c1c0500b00418a3e6c5e6mr124379wms.27.1713477130929; Thu, 18 Apr 2024 14:52:10 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id e13-20020a05600c4e4d00b00418e869f896sm3321517wmq.17.2024.04.18.14.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:10 -0700 (PDT) Message-Id: <0a79615cf2feea974be709e44326547ef31930c7.1713477125.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Thu, 18 Apr 2024 21:52:01 +0000 Subject: [PATCH v6 4/8] SubmittingPatches: quote commands Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 26055a1fe2b..6b9e954a47d 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -403,7 +403,7 @@ Before sending any patches, please note that patches that may be security relevant should be submitted privately to the Git Security mailing list{security-ml}, instead of the public mailing list. -Learn to use format-patch and send-email if possible. These commands +Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. From patchwork Thu Apr 18 21:52:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635473 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227C419DF6C for ; Thu, 18 Apr 2024 21:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477135; cv=none; b=HPaCddBzJGaHPC3naxmAz0HdtFinaFq8SOEIFEKLr24nTKC9xj965kKPszFQKjrjTmhGWLEvG/6gh1fH5O+ZnqGz1AissS++mUVT0aX9SnlZ3peamOOzSaFaxGS9a5BfxcNb58TMgB9vWTj20+1wYGOhjC8HCPQnHlfwGOQrk60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477135; c=relaxed/simple; bh=iPjfJWV4L7ohD3S8vxND21ne9Q+4QfV5GYmt5HHebF4=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=aL3ZNlcoeIc1XD5C/quZEarxIXKBKhEq0nVzAr6QbFfyzgMnuTsmR2Iw9b0ef082O+LAbBh05Fxj7tv4hYDUwGcXHyOAESuVtxT669WF6n0g1wXO+brmmRp3Vt0CJzbZTYG1WhqNm7XH6yCFuhKJJxQyhBY3bCGtf1rvWRTOSGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SmJRKgh6; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SmJRKgh6" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-343e46ec237so946247f8f.2 for ; Thu, 18 Apr 2024 14:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477132; x=1714081932; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=D+pQR/iTPI0boEf3Pw/FXGSj5dlLZUxa7vhy3Jw7Hxs=; b=SmJRKgh6M0YBdm6wVwqsnKUS/CW7y+4TjPRSkr8PHNVXeGSy1L1vC0grXtdJbc/D52 PYcs1gVLwBfVWEb9VCIBjOEW8Nfw4EAzTTUjKc0NXZ70m69gt/qXDabA1qatl4D6Xfsj z9cm6AlpFg+chnsBC0WRdOL+QskWKpCys4W3gYEeNSxHvSiHPaHx57UIQIKnV34NwGpq CiplN7txHslyoj2u1nwyg0REItbv282HwOuGsqo3OYGHsx5B2TK+H4ughSjr5mo5G2Xb usruTV8KzveDm4GoCHNAr4VCHDAS7YrhOuW02nc8j+1PaRrcPQgNx1KvaNJbcoUZhsWh 8KCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477132; x=1714081932; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D+pQR/iTPI0boEf3Pw/FXGSj5dlLZUxa7vhy3Jw7Hxs=; b=YBxlpdMItWLUOFDzfp8NPgGfX4fioQ+mduiEjhxMFoou/BABoUYjwdlhHxGPWStCR4 3ATY0aNZ7WtD8vm07VpkFA5bO6zPjTJAqqQmCPmo/6iFbAt8sklqeAq/Gr9kYlPSo5/p EfL1XajgDcjA5SWNC3EgVKuJF1DZO/BynXVb6+rBoBzWGaZGTr9iOSXKPK6/ukpiU11T wEORN8O66Zgcqn38IhlomhyDX/X7W7XbxlhXZSHz44K3Nlc4JmodFBMm32YSckMrlIjU Y4PgdWyP313tUAGFMCcOvjtU/3oxdsFxqxIu2YWJ010fwJkugJ0ugRX/AFgOZzJ8Rw5p lgxQ== X-Gm-Message-State: AOJu0YykChSsViubL9kIoJ7GqtH3B5QtS+wCM6NrNdEdR4rSpcy1hzVN jsavTzfNfVw9CJP9Qutfkk+KEmk4eXZgx3PNNoV/A03OLa6q+ZEYkob5mA== X-Google-Smtp-Source: AGHT+IGVTAOAc3llIHgLD9dNuuipzq6DINDg+TqUaY58NohcUhMjGzNGP7aq1jMxe/atXZhfpmihhA== X-Received: by 2002:a5d:6087:0:b0:343:3a67:85f4 with SMTP id w7-20020a5d6087000000b003433a6785f4mr126178wrt.41.1713477131658; Thu, 18 Apr 2024 14:52:11 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id b4-20020a5d6344000000b00347363b77dasm2768345wrw.33.2024.04.18.14.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:11 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 18 Apr 2024 21:52:02 +0000 Subject: [PATCH v6 5/8] SubmittingPatches: discuss reviewers first Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver No matter how well someone configures their email tooling, understanding who to send the patches to is something that must always be considered. So discuss it first instead of at the end. In the following commit we will clean up the (now redundant) discussion about sending security patches to the Git Security mailing list. Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 66 +++++++++++++++++---------------- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 6b9e954a47d..5d5046fa954 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -397,6 +397,40 @@ letter. [[send-patches]] === Sending your patches. +==== Choosing your reviewers + +:security-ml-ref: footnoteref:[security-ml] + +As mentioned at the beginning of the section, patches that may be +security relevant should not be submitted to the public mailing list +mentioned below, but should instead be sent privately to the Git +Security mailing list{security-ml-ref}. + +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + +not part of the core `git` binary and must be called directly. Clone the Git + +codebase and run `perl contrib/contacts/git-contacts`.] + +Send your patch with "To:" set to the mailing list, with "cc:" listing +people who are involved in the area you are touching (the `git-contacts` +script in `contrib/contacts/`{contrib-scripts} can help to +identify them), to solicit comments and reviews. Also, when you made +trial merges of your topic to `next` and `seen`, you may have noticed +work by others conflicting with your changes. There is a good possibility +that these people may know the area you are touching well. + +:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] +:git-ml: footnote:[The mailing list: git@vger.kernel.org] + +After the list reached a consensus that it is a good idea to apply the +patch, re-send it with "To:" set to the maintainer{current-maintainer} +and "cc:" the list{git-ml} for inclusion. This is especially relevant +when the maintainer did not heavily participate in the discussion and +instead left the review to trusted others. + +Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and +`Tested-by:` lines as necessary to credit people who helped your +patch, and "cc:" them when sending such a final version for inclusion. + :security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] Before sending any patches, please note that patches that may be @@ -490,38 +524,6 @@ patch, format it as "multipart/signed", not a text/plain message that starts with `-----BEGIN PGP SIGNED MESSAGE-----`. That is not a text/plain, it's something else. -:security-ml-ref: footnoteref:[security-ml] - -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. - -:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + -not part of the core `git` binary and must be called directly. Clone the Git + -codebase and run `perl contrib/contacts/git-contacts`.] - -Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git-contacts` -script in `contrib/contacts/`{contrib-scripts} can help to -identify them), to solicit comments and reviews. Also, when you made -trial merges of your topic to `next` and `seen`, you may have noticed -work by others conflicting with your changes. There is a good possibility -that these people may know the area you are touching well. - -:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] -:git-ml: footnote:[The mailing list: git@vger.kernel.org] - -After the list reached a consensus that it is a good idea to apply the -patch, re-send it with "To:" set to the maintainer{current-maintainer} -and "cc:" the list{git-ml} for inclusion. This is especially relevant -when the maintainer did not heavily participate in the discussion and -instead left the review to trusted others. - -Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and -`Tested-by:` lines as necessary to credit people who helped your -patch, and "cc:" them when sending such a final version for inclusion. - == Subsystems with dedicated maintainers Some parts of the system have dedicated maintainers with their own From patchwork Thu Apr 18 21:52:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635474 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6274A19DF6F for ; Thu, 18 Apr 2024 21:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477135; cv=none; b=eHiBRednl7khDXtlLtjKB07DqteHWeEy6OYdPtOpB37mwSLN7LLMzNrQz6GsTCHnZOaUsTaD7En9pSgdPe0cMpTXbY5LJGMJQDcmTp7sZfFglaTnKg6A+0Vrx10URwmdT0G4HTfZ/5PXuWdtQ40NpKgTF0ry9XEx8es5QNy/Uxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477135; c=relaxed/simple; bh=EAPMNTEhL7anBQWJwC/AIHMVD1ITjJ9N+qlXgdbGI1Y=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=qHS3UzYMwXA+uxEondxbzJI2OnnURsQEML/QQxJjvkC7o/6IOp/lD7pRGO9mENhKeDH6Ud17YXjM8Mk5gRbFTsxUUWX6Bu5VMugCUAnqmAzq/oUTNs/zNb0Tb3eRGuLCa0RUFSVM/wFb5uFylQOY/xiVYWwnZRIwSVejzQVNSYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ik5JVOAt; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ik5JVOAt" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-418ee51e280so7054025e9.1 for ; Thu, 18 Apr 2024 14:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477132; x=1714081932; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KIxLv7fyLh0XvcQ+/Q0x6RYPo93HdGIsjRRzS0B8NnY=; b=ik5JVOAtvJngpbiAaqyVFWtPVDl8K41/m08tMRb2DzTc9GfGzH/R1jwBfZTzC2bp0j UsRbn+n7hYTVgPcVvVj9L8ID8tpb11T1QmvvxPSMPWRxP6COwrcCjngQVj2wfEy9Ok4X JsUTzZo6WsnkOIBGKBbVlrJTlyGPaZPOVfhFZiR7TWthWTQJ+j56W+zi/g99Q2elMLHu /Fp8QG+0Gbe1oTZw6rTxt3mjan9aRbp92dbVBSI9D7UgS3pYbc1Snq+1YQRo8hiLwu3z C76FnkZ/o8U6cbR2uPXGuVSKax0HfCe41vmJi0I/1YAWbkpuBZ/Gpd8JVK9rxeZ/bAm6 0OMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477132; x=1714081932; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KIxLv7fyLh0XvcQ+/Q0x6RYPo93HdGIsjRRzS0B8NnY=; b=ogiiQ44pdyp62GNlws0E3fKJHjwBfNn/L5YWDYsIB87pPDvSJqYpNtnQB7IrqeHf0P IOTOg1XwnNhzYnXCw5pm27/Jij3+qarS5cg2eaTcA5R7S4vWqs9sJ2gs6rcurAPp2yAx NfaxHDN5DniypXqcD8xpXwuyZ6TcPhCoFtUJCljnZo61gG2oglBUNN89P7J61HlZeBJz X2vb1MF33+foBcGQNr4pFQmm+5eaYVrKdLUI9k3mBsvuLshue7+koPcwLWj//LMxjsQk nYRaRa4jJyxiNFUbr9IAXiTB8gmxbWKN1v8CAieyMhQfzN0JQdAXlZ7VkP1tVZC03zkK albQ== X-Gm-Message-State: AOJu0Ywgs/m7Wq8kreOWq9eBWQhOjyqIPyfhZvyb3ut0qgZRtq6v6gw8 +U+ol+9uFLBWWOhcg36r8Sio1CbYvGyH9AtAyIMm9Qt0fHKBxBBDm0biNQ== X-Google-Smtp-Source: AGHT+IEne0a8XVONNadPxI2zrpbwd08Mtwl5xnAWdz00BKHNlTVaLVocQL+FVUYUeFmYX455XefcDQ== X-Received: by 2002:adf:f48c:0:b0:34a:42d6:982a with SMTP id l12-20020adff48c000000b0034a42d6982amr88194wro.39.1713477132362; Thu, 18 Apr 2024 14:52:12 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id t11-20020a05600001cb00b0034a21842accsm2066006wrx.86.2024.04.18.14.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:11 -0700 (PDT) Message-Id: <333775d4129bc94aac5f872113d07851ffc19040.1713477125.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Thu, 18 Apr 2024 21:52:03 +0000 Subject: [PATCH v6 6/8] SubmittingPatches: dedupe discussion of security patches Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 5d5046fa954..dd248513a50 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -399,12 +399,11 @@ letter. ==== Choosing your reviewers -:security-ml-ref: footnoteref:[security-ml] +:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. +NOTE: Patches that may be +security relevant should be submitted privately to the Git Security +mailing list{security-ml}, instead of the public mailing list. :contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + not part of the core `git` binary and must be called directly. Clone the Git + @@ -431,12 +430,6 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. -:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] - -Before sending any patches, please note that patches that may be -security relevant should be submitted privately to the Git Security -mailing list{security-ml}, instead of the public mailing list. - Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Thu Apr 18 21:52:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635475 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BC0319DF7B for ; Thu, 18 Apr 2024 21:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477137; cv=none; b=Hvn9BMpDzHgo/rDumprGjZpK9rcEoIhleF9Wq9Btp6uxdR8WIYeIVCUHBWU3H+p9AD0ntkUUsyLDEQSmqPQWWX5WXH46d5r74Y4X+rVOsXk/wvkdykJhQgPABGu1vOWLmQmysB+sbgA05FBHZowhRVZL/4cQdG8V/T3SVcPReG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477137; c=relaxed/simple; bh=fJN+qBi0s5VNP9m8DpjehtGDSjxnFyZsPzew7s3noyY=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=ZIv3IBGIEHPDxjgw653yuuYaeRDHHzWGfiTuKZEjv6lhchCG6olexGFpr6zrR4S7NhJmbxVexVrXjA6Vr4YVDEjwYTsfwGutJUQNiRspXHL5EL1FWD9CTDidkECRR7PgJ8VB7Iz3FhT7cLXh/ppceRNTMX6ZsxWPEsHZfqx7D7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=al5ns0GN; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="al5ns0GN" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-34782453ffdso1308580f8f.1 for ; Thu, 18 Apr 2024 14:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477133; x=1714081933; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=F+wEyyaFAboVQkPPirt36lM7eyqSklJ9+eNmZA4zTo8=; b=al5ns0GN2OHgX+1YarMOXc5MbzFTMgxVllOPrhWpNMQKcfAOEULjahslCgHOLNRjS3 Kq5d65IHw8wBrZwRccwy3C2jbhAXXewUa0eSGUPDyfI1trwSTpIdSQ9xWgZUO80Q/i8V zutexH4XfvfsH8L7NucxJbTq66XZ+gXk4hbIRRa+mWB0xZazhzi5VACAphkS+yuz/stZ lItTVnbu5u+HeCgU1KK1nTu43iLfwzYlzi0jcQnXyVPYXbGMzXdvYEdOLRC4A0XUhMeH Tk+zdvRoiUlKUyuBZi2VCtrxXJhzMVNilJWRzv0FflRtrV6uo5O32hFeZvRnVPaCEipL o4KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477133; x=1714081933; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F+wEyyaFAboVQkPPirt36lM7eyqSklJ9+eNmZA4zTo8=; b=IoIkkjR9kH69ygA2+AhE1CT5P2UVd7I7W/xcPxXGLDL/MaW0XliUHOqCW1VXG5A/rD s7aLPCOIQU8CucQuTjBjQJYjCCwY8Eo0cbPzE9KS12wpjpkp8alRp83KcdT5EwG/LfY7 JHAU4XoSvNl26q8oV6FH84YIRliDeB/lf96jepOY5x1Q84ng1w2hycEvrfy0OL1NIfoW 1qddv9+4KHDHjIBVBRb93UL7Y7Mgn1ig7cbpFEmukyXPqBv7vnJnVlsj3f8GucKlLbaZ WUqKWTDRe7Qk9WefSsABsAAxVj6+VUZHiO2rAeP6fwFilJHmnO9LqbwUYhSoAJcZDTEN Xg/Q== X-Gm-Message-State: AOJu0YwifleRW6GrKKEBvyzr+CpS+HSlCeU1w8+jA4W1C9kyOhoaIz19 /zPFFdch6aY4lXIGPNs9scGy9sCHoO8y1dLTGBQvtW9o0cgGjzWRZaIk0g== X-Google-Smtp-Source: AGHT+IH5ISbHAbAP7GejloAjHzDNPaOHIsdVbD+fFINq8F00LpZLpgenfTWOY99VuS2kunZvaXjsAg== X-Received: by 2002:a5d:460f:0:b0:349:cc8c:56ed with SMTP id t15-20020a5d460f000000b00349cc8c56edmr129619wrq.6.1713477133505; Thu, 18 Apr 2024 14:52:13 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id u6-20020a5d6da6000000b00346ab3c372bsm2814619wrs.73.2024.04.18.14.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:12 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 18 Apr 2024 21:52:04 +0000 Subject: [PATCH v6 7/8] SubmittingPatches: add heading for format-patch and send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index dd248513a50..ef3985459a4 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -430,6 +430,8 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. +==== `format-patch` and `send-email` + Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Thu Apr 18 21:52:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13635476 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 243DB1A0AF1 for ; Thu, 18 Apr 2024 21:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477138; cv=none; b=KY6OptHnN+7AFuRZQpZMbWq7rfZLDhRWOR/D0YrPIqmU8iQ5T3vX459FbcLCjAWjoarFzyeMXWWpf74bhBxvUvJN7vVJQZxlZ3eWbsoiF8lbrueYb97kZ5HeILuVN8KyXPZZX/4m9ezryuvYcTemGn0kzEAC4ATDdQfPIHRTg/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713477138; c=relaxed/simple; bh=6hRNSGyz3uZsyELwf4nzoLmlPx0s3agHui6OfS7JyaU=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=KkH79vBjscJNtIGsynlNyZzIAFeUFC8FH9GWB2ZFz+DawHgRBpOIPJQwoWQuQ2IGfODHWgCzRqmIFVidii9qqQv0FbPdXRE7uzlvyr1LxDrcAxc9E8t8uK/0DKv4NrlCWYM+TG7qcXFX/b1095kQa0xmRtIuHD1yVrzLN5wPDXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NDBaASJ5; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NDBaASJ5" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-418e4cd1ffaso8809985e9.1 for ; Thu, 18 Apr 2024 14:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713477135; x=1714081935; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=bWCmGqLz5qlVPr0cXv3s+aiOSUjGs2uMbTP3zozJ1io=; b=NDBaASJ5Bdk3wiFXSm+YvDLOMuNOZ7DejtVmRwYenP1KD9jgjhT9urkNCnVAtNNsuj 40+9/4WUfQPuC1dene7D066RZQlhvOOfIM1oNu7wxJ94lMP0vA4XVznIFLThq/EcXTtq mzeh/LMXWj9c4OSZyTvaPF1GrlgG3qHAPGYEx1Y03nzeOKIazsTT7dofnel/lqfthbWs HekQFWuxtJn8GMAbc5Gg0ACwyJjMvJXfyJgEtRz7OE9+NqCFeMYvBncSrJuDWxZLq9Bm q7qFN9m1KiaEgYj1Mfpl7MDw6OC5O5VT7YCCMr3TsojrkgOyLy2dRajnwhEj2npJBZO+ CD5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713477135; x=1714081935; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bWCmGqLz5qlVPr0cXv3s+aiOSUjGs2uMbTP3zozJ1io=; b=B7/6OnG3/zVmX/KtiJo3tB8lAKLv9eX0NV43OzXvnNl5N0xEB4Bf4fWe3EpBTw4t/E 97TtAWMrQx9BE/owAPzvzBDreGuvKbhsYggptMQtQx5L6bDQeQygYYqB32kiAPYsttAM oWS1PZpn0bv7bIPl4K3UMyUYjfb1RW4V0wJhImpy4IBZzrD6pxEJrAqwqBxg3xrjV+xX CqvSL5oFNo+MNPeoLPkm2qFQGlOaZKBxyIioR+IbO8l4mKDhOaTcnOBz+MNwcRsjLP1A Uxwutos6Tf2Vhq5fR+93sKMBZ7Ov8KQVehZAGCcMFUrLDIAoLVU1RYgeouj2afl02mF9 0+UQ== X-Gm-Message-State: AOJu0YyCedMS/g3+oXp55toyfGURNUF+OdmLDtl8U60cI3kV9vpwZn3+ ZLqtwLeDeA7HAY30sbrsfuNv5skBx2LGgMtUN8M5CdrRwpp0V6mMtTa0fw== X-Google-Smtp-Source: AGHT+IFwXdNF5XWEBG0lxVdFacHLb9vsUUoWUNBOsoh3oH+Lu6P994uwJ3ZBbrIhYt8tmphrl7j38Q== X-Received: by 2002:a05:600c:4708:b0:418:6eb6:5cd5 with SMTP id v8-20020a05600c470800b004186eb65cd5mr105293wmo.32.1713477134904; Thu, 18 Apr 2024 14:52:14 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id iv19-20020a05600c549300b004186c58a9b5sm4026979wmb.44.2024.04.18.14.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:52:13 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 18 Apr 2024 21:52:05 +0000 Subject: [PATCH v6 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index ef3985459a4..b684e28c0d0 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -417,6 +417,13 @@ trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility that these people may know the area you are touching well. +If you are using `send-email`, you can feed it the output of `git-contacts` like +this: + +.... + git send-email --cc-cmd='perl contrib/contacts/git-contacts' feature/*.patch +.... + :current-maintainer: footnote:[The current maintainer: gitster@pobox.com] :git-ml: footnote:[The mailing list: git@vger.kernel.org]