From patchwork Fri Apr 19 20:44:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Peter_M=C3=BCnster?= X-Patchwork-Id: 13636759 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp-out.a16n.net (smtp-out.a16n.net [87.98.181.171]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A6ED10A2C for ; Fri, 19 Apr 2024 20:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=87.98.181.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713559476; cv=none; b=I271B0CCMwpk0MLpFQa3vGX+bXV0ZiFuGUpxIHxebjhrVkfI6EYSMvDRgGIEHj1wQn9cxyY+vThMyHqS1J3fqai1YKIAFNCGrXpvoI0HG2kB3vk0Ou3U91KQhbwwomwJZZCUWvM2Nw4ujVcqDIqqdPE0tG9gWy0YxF2VKW3xVUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713559476; c=relaxed/simple; bh=LFUrNakum0XVuxhZRBSWcBRIV6r3vy12+r8Qv84ueKg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=DAMdnAjt8YgjdGLyzLUBf81tBSzCZ8v3P53Mi5lvIjU48j2P6m4Cr5Yz/2/sRPWz0iaKfAXN4D5xSfHaqDFE3SreJoOAEEcC6QOVhPzLRL5KFYZH4Db0kZV2676m3CAGkSRGQxYhNG4AVn0yTZE+6szVt+3k6CO0i9KAXuo6yFA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=a16n.net; spf=pass smtp.mailfrom=a16n.net; dkim=pass (2048-bit key) header.d=a16n.net header.i=@a16n.net header.b=l4IWr7k9; arc=none smtp.client-ip=87.98.181.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=a16n.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=a16n.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=a16n.net header.i=@a16n.net header.b="l4IWr7k9" Received: from server.a16n.net (server.a16n.net [82.65.98.121]) by smtp-out.a16n.net (Postfix) with ESMTP id 5BCFD4604B0; Fri, 19 Apr 2024 22:44:29 +0200 (CEST) Received: from ws.localdomain (unknown [192.168.13.254]) by server.a16n.net (Postfix) with ESMTPSA id 688A3800E2D; Fri, 19 Apr 2024 22:44:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1713559469; bh=Iig9dPdFfv3mgbHamMTPFFLz2+4tCtmVkqfZ6IiCEgI=; h=From:To:Cc:Subject:Date; b=l4IWr7k9dqbct+Sn4MuD09CAKuBdZ+SvPw5Xo23Kxy5ZqOCmqMmJNSAWKVyOcHmaX l7WXRn5QpdNTJLI9vMr6E9egeYH+m/TIcT8UfAhT0soohjfsHdw9m3s8dbGq5u5wZ8 nMPWg8LjITvJT18PEHbGum1B6ZHTCSks9VLIFmXtXAODPdg5YPaXh5AF100N0+VAbG moYZc2PY+4h0CY7gdWDlGMa6Bw29bFHxk8HOXwk+D5pGWRyTZQLKCkucLuVlMrVHZC BWDTf9V67nSnnEF8Zj9SyZr59xrV4yEoPKb25jVG2YXTiENmJrd9Js89I/R1567aot 8GpDeuAInhdhA== Received: by ws.localdomain (Postfix, from userid 1000) id 3A0DB20682; Fri, 19 Apr 2024 22:44:29 +0200 (CEST) From: Peter =?utf-8?q?M=C3=BCnster?= To: netdev@vger.kernel.org Cc: Michael Chan Subject: [PATCH net v3] net: b44: set pause params only when interface is up Date: Fri, 19 Apr 2024 22:44:28 +0200 Message-ID: <87o7a5yteb.fsf@a16n.net> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Hi, This patch fixes a kernel panic when using netifd. Kind regards, Reviewed-by: Andrew Lunn b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers) unconditionally, but b44::rx_buffers is only valid when the device is up (they get allocated in b44_open(), and deallocated again in b44_close()), any other time these is just a NULL pointers. So if you try to change the pause params while the network interface is disabled/administratively down, everything explodes (which likely netifd tries to do). Link: https://github.com/openwrt/openwrt/issues/13789 Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2) Cc: stable@vger.kernel.org Reported-by: Peter Münster Suggested-by: Jonas Gorski Signed-off-by: Vaclav Svoboda Tested-by: Peter Münster Signed-off-by: Peter Münster --- drivers/net/ethernet/broadcom/b44.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c index 3e4fb3c3e834..1be6d14030bc 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c @@ -2009,12 +2009,14 @@ static int b44_set_pauseparam(struct net_device *dev, bp->flags |= B44_FLAG_TX_PAUSE; else bp->flags &= ~B44_FLAG_TX_PAUSE; - if (bp->flags & B44_FLAG_PAUSE_AUTO) { - b44_halt(bp); - b44_init_rings(bp); - b44_init_hw(bp, B44_FULL_RESET); - } else { - __b44_set_flow_ctrl(bp, bp->flags); + if (netif_running(dev)) { + if (bp->flags & B44_FLAG_PAUSE_AUTO) { + b44_halt(bp); + b44_init_rings(bp); + b44_init_hw(bp, B44_FULL_RESET); + } else { + __b44_set_flow_ctrl(bp, bp->flags); + } } spin_unlock_irq(&bp->lock); -- 2.35.3