From patchwork Sat Apr 20 11:53:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13637128 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DBC7C4345F for ; Sat, 20 Apr 2024 11:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3jm8l9+bGH7c0oqOVc1YeqmdzMAEqKcDglBJX5wvnUQ=; b=YMp4EIVpVmHwLp L9/EkUVQOs8pNuTvbqUYrtx8n8/IShIKHeJCb/wMHglumXuzMCXB4qSyV8497qhyUrPRq/zhnWuzn GK3zmhItUFVUmIfZXwOFpnBeZqF5LjCrVE4WYGwgqrclaNNT6Lb59Jemu9IVJygJuWcUZbcMIBI0u OXMHuuALHt+aAfd+mPp1z3koBt8yKGm5Z35xxQnT1PVUPrcMdtLXzEcE9wLgmV5YwVxxLjCY7oDdW LJ51ffCT3TGXBc7ml6YOMWOBSJ4alcHLzC4CW66ZFLAnlJSZFTvKC6MYM3pI8DFCAsp+A4K7IMpRt n2pQdAxa8gMhWM00zR1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9Id-00000008QAI-3EjS; Sat, 20 Apr 2024 11:54:31 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9IN-00000008Q6K-3JBu for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 11:54:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713614048; x=1714218848; i=wahrenst@gmx.net; bh=IdPvZZcmTz/4Jhv3avJuKOovLJWs7cPlfVl3VPx2mj4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=FTj1ugb1U9y4U3dVfJb4o6MJM0vjc/2mLan38rWrQPytq94fVEyru2yjY3BAh3T0 WL495muh4tXjBEF1GU/m+SxW2t9U2bLqcgESF4OdYHtb+fha7k/w6sTX5NbWwpb1I nAfndgbqcRQEqr7f0fNGQcVWxt0YNygxyWlY1oGImyXUc2rqd/sokG1J95/ZNLOUy vek/AeZvZXvF+7XGR7Q5uRIzAto82uFbHeafQbz5ykrookKp3D7UcU7CXMGvT83dW Rj/YFQmJSGJF2c/dbRHGtjB81KrEDO+Xj4zBP82F/8mi+AEZXtRNaSFe8YmYzlyIX quD+NdZr1fRleLFbTA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mlf4S-1sNpKM2fCc-00igeX; Sat, 20 Apr 2024 13:54:08 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 1/4] staging: vchiq_core: Use printk messages for devices Date: Sat, 20 Apr 2024 13:53:48 +0200 Message-Id: <20240420115351.27713-2-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240420115351.27713-1-wahrenst@gmx.net> References: <20240420115351.27713-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:S4WO36eka4RpRX8zyZMI+Fh++NjZMYAbPn2LYBG5ZAagsBg9bZv +6dTxW4u/SJ+KIbjIV/e3GMnw9g3buzUiWYIUuf9qJ1r9WAiPPOMTcgLiaEXkeQckOmGOKf QZBAVAhYz91qqEcBlW2IpCErlth2cYHFz0mQDdYl+ihk5+7vpLY5+SjogEvGvo4zD+T6ihL PbfsSLkzTPv3QBxXldJ9Q== UI-OutboundReport: notjunk:1;M01:P0:djpi2O3a8Wo=;qsU22WJ6PCigW2NRqdwRNbuPShI IFS9yWoFI2j55iLe4wVAXme4QNlnZf30doClR1NLOXHgBZHBdzTSTz8N3a74qfLv0fF6r5LaV 7dINF0c7AGzfaHgPjK2kMFfAySCkeKjuHo31EZuSUV+mgxY128Z5FijQN3xIXv2UKO8SbNjDU 81voc4j02rM+531fq5Ia/4pVPgfM/KuzQZItxL8yBlVMav/Vgh4JYVSQeDJcooYsVAol4ZtCM Wl+YeXihZj4GBcyIEA6+pM4N5viq0XjRQnFCu1UUo0f+PD+xZKH+NQmgDuxccfQYfruG27HRL hbKoPWGXVU+nPZD1efcQ8Pvz/gK9g/4JtaKZ4nTvcgBV40ce4Q16jlLDMmBWQIWA5cZh/c/JQ iuNsvBS75rPDBkdmGNcbaA87J7rBkMkgLSbb4IBuyP6V5z+wLxeNHyLrbQpfkIEfgEwmsPngY qpbFafbWAPqToDHVbsmqDlhgSrBaNssyIZ7Kgu6X/TsL7JvOfgVCcD8LwuthvxIE1bJBlYV+u E4c4Bx1VWlzURC/VohaJdbHJ6eu8O2BDuVT94VtTGpPDfxg0r/9+V9SRewnupzxNq3QM9eSs+ OFqxXF4cNiTOx8Vdj983y5tWRfR6EQkpOubH/6wN+V60vXjjDqH/Wc/Mu7ck692Nuvkmh43kz wp8b3KNx0ca/1qkk+pK9drZ4cUa6wmSxOU1BNm7EGFcvPx0YcVJJc9udiuboyXiCdbFnWEEtP lPIOLPrUoIGUI6CzhdlSRTPpPd1i18J//55FF/PsR9wz4rxTLqlQzEDTvdjsfZZLNSjDQbnP7 /DO6ZF19u2ELafKv9SBX0uZ7F4cDVc6rBY6zdg6uqKIwQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_045416_225082_A9C9CFE4 X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that struct vchiq_state has a device reference, we can convert the remaining printk message helpers. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 3397365e551e..129d73fec2bf 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -697,7 +697,8 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking) if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) { complete(&state->slot_available_event); - pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos); + dev_warn(state->dev, "%s: invalid tx_pos: %d\n", + __func__, tx_pos); return NULL; } @@ -1732,10 +1733,9 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) break; } if (queue->process != queue->remote_insert) { - pr_err("%s: p %x != ri %x\n", - __func__, - queue->process, - queue->remote_insert); + dev_err(state->dev, "%s: p %x != ri %x\n", + __func__, queue->process, + queue->remote_insert); mutex_unlock(&service->bulk_mutex); goto bail_not_ready; } From patchwork Sat Apr 20 11:53:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13637127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9910AC4345F for ; Sat, 20 Apr 2024 11:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chAuDcgNNuii0Bk3leHQFM6XOu9EAc4d4kXBuIo30Xg=; b=K99dSJsJXa/h96 1CYDM+HqnCW+lj14VLynanC7NlzIlzRYqdNPtVA8w54j2m0kUhktTPBKScWatpjAoRcwAASvxrd55 6BDZlyH8NbAdx+jbvSyKvGFkO5PhyZd2cYfxPqRdeYeMnO8/Z1plQT/t9A/kCFPYhTkiHN6+KqKyR 7P/2TFeB2LFBKna2d5wvTVQvUVP+3GlJkDh6fMGfNZrxDakz4SjN+tgbsAbuN2HijSsE6CcOOJLqW sHPDYnYdhqS1hNluT65R10W16R72YNKSlUfCuQ5oyTCeuE/3/B+p/rjXYPkIFZybHFOuhGxHM9u2u DFzwzp7o/PPM0sd5RkOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9Ie-00000008QAg-1sl4; Sat, 20 Apr 2024 11:54:32 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9IN-00000008Q6I-3JMS for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 11:54:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713614049; x=1714218849; i=wahrenst@gmx.net; bh=97M1kqdll0hOVOhu6BLb3J+FkpgASkRSTSLyTAp4RCc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=OjqcXsaqu5G1OxqAilaVzHcMtIildwQK4Ks2wiazorgrm+D47RDkCMf1uPK3NX+5 XmwBN7oxfkhq1pM9Gc7CwagvDsINHzfSWIpwdpFhkTiaQ9e+tVZNrJJoFqcomh+Cs a0Z0j2rZ9bt6uk6x1hR/bmsqEKm4/dNkKEFRat1KiVI86mnDqSDk8tSkgg3D3uiqU jfA7NB2CKGYaSSlZFzYOQeby+t3vWoeWDvgvajawyTFEKtmPrF5oxnAK+EQjsVkeV tlpS3qUK39dwuqDCN/t2FR1j/4I1H6EGHazv7NSGLBSsd5Fb3oTwGL2pssxzpeQzl yr08Au4hQb58C8wyAQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MSbxD-1s8tqL42pd-00Swz4; Sat, 20 Apr 2024 13:54:09 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 2/4] staging: vchiq_core: Add parentheses to VCHIQ_MSG_SRCPORT Date: Sat, 20 Apr 2024 13:53:49 +0200 Message-Id: <20240420115351.27713-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240420115351.27713-1-wahrenst@gmx.net> References: <20240420115351.27713-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:AnSiHOkS6hjzQRD2VWP8Zn82xpdkf3SjMpF2G3UPKQwjbPXYfjb SAthhB2XBhku5ikcwBKzHD0T4FttuDzh3TAigAoVJA2inMlm+jznBaGsEIxP/FhX5rK0D9N TeCVIfha22rHR9gBteqKALepOFvXW2Yn53IwDnwDgqQynT7LTdQ1g9XJ3CmVtTLh9myYaIo ziLuv+lVUrGqh4lvR9ipA== UI-OutboundReport: notjunk:1;M01:P0:YE7E3tS8fb0=;ybjA1Bvs1LGMGqv8XdTgPBKBTZF qhDxwtml5zjYXGJsVOgp3wktkUXM6zAuxjF0OsawMnrL0MYYACdyX/+GMco5TqvECQXXeRBIq eFzOuI5ZKNXOXfpzyjW0tUQL2s9OOe/xgeu6/X5kSX7I4RqXXBG3zmnsgaJ9ZZ8HwBw8hesgG JxDeKQiD5KZ9nyUCHTeFc4hOdLXmQ2u3BXwNOd8EPA3tIJv0ofH3PZRXkFdD2EJ4fZvaCJ653 +UyIWXzKBhSSrbQk0LgYOKMvo9SSebVpN3VQbdHGJnCpXu8J3Gs7t1lt2e4wdEsIYITaWxNGn XMtxc6AeLXHgFmhfbYjddHwJLq6BAy89dLJhUdV4vnVuQidEpLKMswGZuyRXTyNrUKUWeUA0F +xKEsHUdht23aOd38jJJYbiruMRE+5Y/zffm9I+ReVvWb68R7bxYXFoyM2NtnQ873dMdXeQBo ixbBdAe+mfc9ShZPaIQ8qu+0hzu7wJteFdY8otaE8OvOtgDAb2RjbPKJJGiRBsUMgsne+oIAA 0lrq2rcXk5lei5norTu3v1P6w1lCM736oAkHCPHw57GOfgqUtzrYYnG/qmeHZLfyAilh3JWrL f6+150MT+uK+KZWvW3TWnVIBgZaK6hknufOV+ggdaKZtpOitRcauenAUyOv1TxvseJ5pQfoIF /f4c6gaZS+V1h9uzpbvDY9qe7Sc1DISopVl5UZseYhzz+++UksKZ3fuNSt9380iK8yqHhWBIr 3fvxXdmD9xMfM9Ci+hBSjfiAn+QMKgCLRWpD88xnMGamloWm/+hxve7YwN2HJjiI/2pmK6lq5 DMqGqemLUrWTZqMcWlVwCQF9d5bhUPFFZm9mQOjE7nOs0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_045416_210621_52B2E548 X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org checkpatch.pl complains ERROR: Macros with complex values should be enclosed in parentheses +#define VCHIQ_MSG_SRCPORT(msgid) \ + (unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff) Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 129d73fec2bf..58451ee08abc 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -43,7 +43,7 @@ (((type) << TYPE_SHIFT) | ((srcport) << 12) | ((dstport) << 0)) #define VCHIQ_MSG_TYPE(msgid) ((unsigned int)(msgid) >> TYPE_SHIFT) #define VCHIQ_MSG_SRCPORT(msgid) \ - (unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff) + ((unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff)) #define VCHIQ_MSG_DSTPORT(msgid) \ ((unsigned short)(msgid) & 0xfff) From patchwork Sat Apr 20 11:53:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13637125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A24E1C4345F for ; Sat, 20 Apr 2024 11:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I0HP2+rps44sgG58kqNGx2sloWT3Q7qrFS7n1H35R10=; b=vr0Id2OJpzffLj vH0cvrCMCWOKSPa5VtZK8b94m//TEerR/8NFewjoYYoGTjTslF+TnBMoyAlnVO1ZbX37/8MYLDeZC Kgr28TIOw5LD3z8+46Aml4ax0884mhHGnz6h00AdHtOrr1yQOkfpKoWUhLBEoHvjoHmnYGFlyz3Bu XGT9O8vu/vOe8LncFBLF4IVpynRrQfGpytnUlFp1kueUtkzIHTihmQWQGiIl78zZ3V6xv9g2chwVB 3EPqeuc0uFhb0thM446u/qlJqUoDbBSLlJ/qNO2qxf6XKQ7o+3B5PsZiRi1WmCMHKjPCFX7vfcVT2 RK8TYc81q64n29KRZ4PQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9IR-00000008Q8D-01Gy; Sat, 20 Apr 2024 11:54:19 +0000 Received: from mout.gmx.net ([212.227.15.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9IN-00000008Q6L-2T3L for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 11:54:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713614049; x=1714218849; i=wahrenst@gmx.net; bh=koFzLm44dz4nDuoKZ+qXrHUg624FQA2jhb5ki/HL6Wo=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=cgTyjjHPrUsJo6cECgixcObTD/Rjsg1Jf8b4VnzyR48BjjWYyH1VS3+qIQvqELpW xtwlchUNGoKNJJQ1i1wCWndfYcBF3dxwiu6QBpGIPyURl2JkxwCSQwtHDeHHq86Zk slFwLKCh7yEdCJED3NcfB548GY7DohKMi567YAOHANuIt/ubWsGY4324oxxlImVje XmFGxzrv3WCt8JgxbDzV5+X8gNkt37G6d3WD2LK/39hFiWq2bNV48fhA7UTzx/nmq ADF8i+Wn16K+E7VCP3SCIQPWmZa9VII33kgmEz7HdB/hQdy7DNgJ66vdWoVz4ayT6 dq0G5whphOOpVZjOfQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvK0R-1sobOC1QUT-00rJO6; Sat, 20 Apr 2024 13:54:09 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 3/4] staging: vchiq_core: Drop unnecessary blank lines Date: Sat, 20 Apr 2024 13:53:50 +0200 Message-Id: <20240420115351.27713-4-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240420115351.27713-1-wahrenst@gmx.net> References: <20240420115351.27713-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:uTlXW34JNlZ4mLO6+ajkGBBjOwyvdCMN8b5ub2Sp5sIacnLGRfC V/9sclercDEc4kp/UQjsIUj63bHWDFHfYzng4O8BEJyT8SCe0dPfHuNv+cCeqAwKk96DuiD EhrGIewtf64kMMd8ABUUFCrY8WLEax5QxR6pC3bFSXkg9l43XOZkNGasPgnF76iZOEFaD8G BfrvEdUw687AXWLmoDGBg== UI-OutboundReport: notjunk:1;M01:P0:Woy9xTKfInc=;7NVdj+ErgKk9VttAJp+Ybf7MmUh uRVNLiNvEVtTFrEHgIwm8Mh089JSlG9qhoienC56TbllfdskflVPaVBhzmx+yXbAHiHCBNse5 HQ8lkXoM5Vjq1aqWHzMB0EJQEBttca3M9mhQ0ziLRqCE81Rqxl3Po5uyX0j3NLq5uwyQfI/V2 S187Agc1TivDTaqlVoLqIip9JsnS9kIhrOQ0rNOSBaVg7nNtCVNmDdmSdutSR43/BpxQUzphA nFn7HJ9p+1glYUsFAgjR1jobCEo2D2c5yfKsw/huCNCrVnuPH6gJX5Ql611BpoQrxhfm4lrJu lS3bl+tDsM+t/BmnJvG94o5ZTsm3SBDICeSOm5gsPyyxWErXMpc1BF6ZaEAmDmcxIrtzG2u6B T/H2PdVHyst9bOg8k7D/2PBRgiVORUnKxVSWhJYcnt641JD8DInXVfaMAuzEZMjKPBTZ2LlnO Owq/X85L8jlBnMLEsriNRBU55BovdaKx6NVzFEu2DcfEiC4cS1R/tAARxhV+ed1pdadNTxSiD o/o2UWP9Gq00fjKW/zsfkyrVtyMlQQ8rn+yvguFpiFo1VnO5v9m4gus67uA2N2KrGA3SFvxGn gTe4sFndAjfbrmdAMMfH9NSJT2WIlypzgYtGmrqhoFDa5eDrFLYrM3juduOFRk4xnmmNcNMgz eGH3AvThxNwx3Rya+LbyOMiIwt6W+grpnXQdqSbHkCe05FAp5O/p5QCEy0PFRK9mXoE8JrcT0 Ws/dfAug1AEWMAzhaGJMOr359U2GFkO5oVJ3/acAlO2clIJL/dq0hlO6rQEsYno47cQ503vaB p15v2XUXuKnPU3PBB16vqDreK5eRphLX70uUMkQj7ghKE= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_045415_972949_27D139C5 X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org chechpatch.pl noticed CHECK: Please don't use multiple blank lines So drop them. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 -- 1 file changed, 2 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 58451ee08abc..ca32902afe06 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -1190,7 +1190,6 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service, header->size = size; header->msgid = msgid; - svc_fourcc = service ? service->base.fourcc : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); @@ -1616,7 +1615,6 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) break; } - svc_fourcc = service ? service->base.fourcc : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); From patchwork Sat Apr 20 11:53:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13637126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3350BC4345F for ; Sat, 20 Apr 2024 11:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ov1Qz9HcGmlAfoQyg3j7KB7aHbcii5+UkTAfBueI1LU=; b=1eoPgYsNqb5rTX 8cP2yMCxfPKgUzS6J6O34u/rsz4ARWMYL0zbR5XU07SnygbzvNYZv8nybMdqDJ25N2Qye8cXg1bSd qefmeqKWs+g7T5l3mOKps3fxZKBruIBOZkFauIb8Wm6VEqmIu+U5wdZ4vdU0+JV2mtoccQj4ENV5v fvIy3PRVsPA5NZkqVM4JI26R23x5hIJJ2YtvREd3CiKWzaXuOK+kCkKIutk8y5y7iXZ3g2dWeondN i7n31b1FxP4c6HGWy7+bwKOK6YLnhs+XSsgpifLHeJNUn++jWrj8+dnlj2jR5Ufv1z2f4OmVBM9Z1 nj3j5BUC3Gx+90X8y9qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9IR-00000008Q8L-2UlX; Sat, 20 Apr 2024 11:54:19 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry9IN-00000008Q6M-2TF0 for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 11:54:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713614049; x=1714218849; i=wahrenst@gmx.net; bh=XBz6vLDOKmPiyoGHSaBiqOwfqoSTVC8G8FHmgrlgS+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=sOlUYjhlB1Qo2orodh1n2/0CKwbhRN1gECha9OLRvsqGsfxKugsBTbEsgsLmymrq oySD17jd5oIQT0q8ZzTo4g9+GwobDB6jNADRstjecQJl/7rIDNqEVWYKoKAQnIURB 5HjvClTKw1kSxC1/Oka7gKkgDi2geiJJjIYiQ8L8+Z+w6yKgoGo29JlrufwiZXpSO RHZnS0/0pqlpwq7wK8AJPA3Mtk5kfwTe3768xTlzx1gIZI8Kp0f6Y6AtUQpZr641q fA7yrB1miI7RzY11zwero4JD18WCsXvb8lTZagRKWJ3AibiSOHrKySWxYtFOUNhH4 iUbHcDZuHDqij9+cfw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6siz-1smvMc2wbn-018MGy; Sat, 20 Apr 2024 13:54:09 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH 4/4] staging: vchiq_core: Add missing blank lines Date: Sat, 20 Apr 2024 13:53:51 +0200 Message-Id: <20240420115351.27713-5-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240420115351.27713-1-wahrenst@gmx.net> References: <20240420115351.27713-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:UciPNtNmNbb/tnBiK7doL+w+C3Illm4dS3sRX1UkFtoouuJtCNp KFRX+2L50PpIGA5QtaxvBrR7uw7hVT6vriyarXn4wDRV1NBT0ZgtIkEPlACJvxxDBotrnAF 1gwAx+DrgNEO2gzJ+XWujLAulckWjQ4GOWs3hDZT+/s2rfVLNnpeAr2FTgHMti8VQU8wh7b 4h5UFLFfqjArJ5cLE3Org== UI-OutboundReport: notjunk:1;M01:P0:jbuVK7QtgZU=;vRu3sJclAy02O9V9zAaz748T8zY HphDShhpRk6s5+jLpCETYrMIQEVvhJ6vt9MaBCr0YUOP/TQzfemHS+c+TPL/vaOWx0Wzx9Kye 6Vshb4YWODldECMdmGkqLENLoB0yXB2uPXh1m0zaNacZsM9cZ4/9/FtcQnpF0QSWhb3MOUjAj 6RgRX+caSEdCGmNPYVxg0QZo+zq/RUcDgGfh0aFwLWJxb8EMW3xwgx+IIk1NypgqomfYcFilw ZfBkGuOQbv5hEI0OdArEd8Of3loI4cWRnlni+2RwaNYTFqFD5nZIOARwlS5aluuk51MbRoiAA 3XxVf1re3hbr6EMXT3awPeJMVNYuSGOazs8eSfINzp40jIBMvb4KfWDySFsXRZGN2iBH0mGlX wYIvpuwpfkC/IRFn7TKVITI5G0w5W3+0W99JSq6/1rniiRj2lr0LI0OgEw2JQiOf0MvKasnhc cN9WU76EeJLTU5VDoy5yLyXviU/E0WS5dKMNzuFDXbVz3dru+IeLpwoCKXND+F/ZIEmlvfuly U/0ajkVKZX1gY0vkfflSjPHmOdr1xZYOQ2rhJlUbr4yeilSkLXLbT2zBdKF514TstjJnfeb2N b7qq2YrMyNLA8ha5PiwO5RFs6QQdEZ1YDrlVnZZTfSlOwgTy7ENZqhanrrqeKKqoA4SroX6LT /0fODogBL8GDLOLP+GTweC7yAEloKIhfja/G2qpl6S7jnGCX59oZgYI3Sc9H+UtuzXAPvSvdr k18SikKIZ7hdUDheYUboX9lEzocIYCU002VnkbZD6ivk+LRhsI8vO5yBeKm4C7yix+JGLLscD z5mdyi2+xgYAtHl8cYTu65f26II7Yc/U9WI1HFOubXXhs= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_045415_957956_D6ABBBAB X-CRM114-Status: UNSURE ( 9.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org checkpatch.pl noticed about missing blank line after 2 declarations. So add them for better readability. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index ca32902afe06..df3af821f218 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -227,6 +227,7 @@ struct vchiq_service *handle_to_service(struct vchiq_instance *instance, unsigne return rcu_dereference(instance->state->services[idx]); } + struct vchiq_service * find_service_by_handle(struct vchiq_instance *instance, unsigned int handle) { @@ -2176,6 +2177,7 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s for (i = 0; i < VCHIQ_MAX_SERVICES; i++) { struct vchiq_service_quota *quota = &state->service_quotas[i]; + init_completion("a->quota_event); }