From patchwork Mon Apr 22 13:35:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kory Maincent X-Patchwork-Id: 13638531 X-Patchwork-Delegate: kuba@kernel.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A0C715098F; Mon, 22 Apr 2024 13:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713792970; cv=none; b=mextamYu45FPPOTOlxtanVUAVIvO6BjTOAD09a1WKuhKN4kAQlO1SADnLapD8rd2MblOuhim9w19Tds224W1YxohVx99qwK0MFZcPQkZLwQCrWoOBCIz5F0QMA1O1e1QT/XR1t/ruTjkKYwU1AZo4bC/SZf97CxR3lsaJbjnQF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713792970; c=relaxed/simple; bh=bXi29gIZ4zvr8ZuPsErOR7MMJWSFxgIYO6IzdNg2uN4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gUmcTFLBJaadFNPSGY1YwQ8QEwlNJgWS/Itxc7LRAHPlHVidAlBTLr0N5pObWsBWHokFzFV8UeXXDtkXRf9AagTuX4CIcZjVhFzZTbkeF5/I6CxTVadCk+aR+fFPS4NYDvyQONjRhVjlwjopwrmIjy8qQFxN4cW2JXMk2r+jKbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=kHIahNTS; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="kHIahNTS" Received: by mail.gandi.net (Postfix) with ESMTPSA id A41BE1C000B; Mon, 22 Apr 2024 13:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713792961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SJjYjznxGBCfpOCBWtP0dj9JIhOm2DN+x+GnGTRrtMw=; b=kHIahNTSmfwXcFHJ/G+FlcgRVC0CRptEJhxaUPTq/AgDR15eQOZykngop4H6k47cIkASp6 Ro4DqA2XZGytehFHmvtUbJmB197/xO0lHUrhZUihn+/ASpGaiNz9DJL9sGbZN1e/zfz/EW s6XTx5cMpFtZd+1H0D6Nz+CcqCNcayDwOXO+DCx57jhy2qWo0fs1o6eczdR4AYnU7UsK5y 9AzfylSiF+CfOWl5ibH7tCWQl5I3DEPmMDcchEPGXfQNZ+IShwO1pDGFdByCz/lJ6UN28D GX0ooOOwp4HDpwHmhZwfT3ld7xnPUemQ2kjcmilxqZKAapyTtOD45KIZzxxM0w== From: "Kory Maincent (Dent Project)" Date: Mon, 22 Apr 2024 15:35:46 +0200 Subject: [PATCH net-next v2 1/3] net: pse-pd: pse_core: Add missing kdoc return description Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240422-fix_poe-v2-1-e58325950f07@bootlin.com> References: <20240422-fix_poe-v2-0-e58325950f07@bootlin.com> In-Reply-To: <20240422-fix_poe-v2-0-e58325950f07@bootlin.com> To: Oleksij Rempel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Swenson , Kory Maincent X-Mailer: b4 0.14-dev X-GND-Sasl: kory.maincent@bootlin.com X-Patchwork-Delegate: kuba@kernel.org From: Kory Maincent (Dent Project) Add missing kernel documentation return description. This allows to remove all warning from kernel-doc test script. Reviewed-by: Andrew Lunn Signed-off-by: Kory Maincent Acked-by: Oleksij Rempel --- drivers/net/pse-pd/pse_core.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c index 31f23c454678..bad29eaa4d01 100644 --- a/drivers/net/pse-pd/pse_core.c +++ b/drivers/net/pse-pd/pse_core.c @@ -320,6 +320,8 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev, /** * pse_controller_register - register a PSE controller device * @pcdev: a pointer to the initialized PSE controller device + * + * Return: 0 on success and failure value on error */ int pse_controller_register(struct pse_controller_dev *pcdev) { @@ -401,6 +403,8 @@ static void devm_pse_controller_release(struct device *dev, void *res) * Managed pse_controller_register(). For PSE controllers registered by * this function, pse_controller_unregister() is automatically called on * driver detach. See pse_controller_register() for more information. + * + * Return: 0 on success and failure value on error */ int devm_pse_controller_register(struct device *dev, struct pse_controller_dev *pcdev) @@ -627,6 +631,8 @@ EXPORT_SYMBOL_GPL(of_pse_control_get); * @psec: PSE control pointer * @extack: extack for reporting useful error messages * @status: struct to store PSE status + * + * Return: 0 on success and failure value on error */ int pse_ethtool_get_status(struct pse_control *psec, struct netlink_ext_ack *extack, @@ -704,6 +710,8 @@ static int pse_ethtool_podl_set_config(struct pse_control *psec, * @psec: PSE control pointer * @extack: extack for reporting useful error messages * @config: Configuration of the test to run + * + * Return: 0 on success and failure value on error */ int pse_ethtool_set_config(struct pse_control *psec, struct netlink_ext_ack *extack, From patchwork Mon Apr 22 13:35:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kory Maincent X-Patchwork-Id: 13638532 X-Patchwork-Delegate: kuba@kernel.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5702A1509AF; Mon, 22 Apr 2024 13:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713792971; cv=none; b=lmgMSnHOKJdHbCQlCHIxWxaVcmwhw6Zhrjc+t9YlEqkNBDGG+q4cNa0wMQONGxS7c4v1aubykC7uu7iRdzB78Mfh81XasX+EEVuZj8kZ9BYU8vm4XgRQWYkfnmHW0i1OsqihGtdFxIL80m8DWpgY4qlRG9IHgOpk8E00vWj5Q2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713792971; c=relaxed/simple; bh=+w06Be0TAX3C5KYPO88oXI77bWnptU5o1vfpfDnP5CY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=si5GT/Zk2oPdEwPnr4Z5EEXB28mmzmPhpOk1LvqHbWDdQQc5G421y2lFyZCFh0gCpqqzKj73Q5O/3uO6YJBz+M9xrZy2L/0qdJPP2c/rlYOaLRMCtbB7JuziyXE5SyecieiwdJvRdyfzT/RwIsvwSy45R0yMhUWoLQL+THfShbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=LkJ9hzO2; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="LkJ9hzO2" Received: by mail.gandi.net (Postfix) with ESMTPSA id 428651C000A; Mon, 22 Apr 2024 13:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713792961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cNswcMmS0UYfsHKzGlg9eZWnaGdsyWARoSLz/i+rBuk=; b=LkJ9hzO2NSwzw9itaFvpwdJx+aik2qdRH/KeHDycjZDHEE2UeLUPWgZQs2cF4XAa8hQOBH mKWT00mNYNx7zge54CVDzm79Ene73xxkts3IfBBJwKU36+3y7lKPUaO2kjXZbKCkKM2cND iuP80+12/YLfjalfmYtw+vGmyWXapRgidUoJtMoZHOXZ+kNZ8sKruXRH+oOnRnTlMMwviO 7PfqKSBKoVHw0oLTA/SHdsvYW6bgTynr4djRBDUhMHMiw9LhnS07dMgboAzXk0miWs/pw9 IEU5bfsVYL0o95bECyMp47YlblmI3r/aEW+MRuNTtz6eNuRfVHDQ8UGctj9s4A== From: "Kory Maincent (Dent Project)" Date: Mon, 22 Apr 2024 15:35:47 +0200 Subject: [PATCH net-next v2 2/3] net: pse-pd: pse_core: Fix pse regulator type Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240422-fix_poe-v2-2-e58325950f07@bootlin.com> References: <20240422-fix_poe-v2-0-e58325950f07@bootlin.com> In-Reply-To: <20240422-fix_poe-v2-0-e58325950f07@bootlin.com> To: Oleksij Rempel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Swenson , Kory Maincent X-Mailer: b4 0.14-dev X-GND-Sasl: kory.maincent@bootlin.com X-Patchwork-Delegate: kuba@kernel.org From: Kory Maincent (Dent Project) Clarify PSE regulator as voltage regulator, not current. The PSE (Power Sourcing Equipment) regulator is defined as a voltage regulator, maintaining fixed voltage while accommodating varying current. Reviewed-by: Andrew Lunn Signed-off-by: Kory Maincent Acked-by: Oleksij Rempel --- drivers/net/pse-pd/pse_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c index bad29eaa4d01..795ab264eaf2 100644 --- a/drivers/net/pse-pd/pse_core.c +++ b/drivers/net/pse-pd/pse_core.c @@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev, */ rdesc->id = id; rdesc->name = name; - rdesc->type = REGULATOR_CURRENT; + rdesc->type = REGULATOR_VOLTAGE; rdesc->ops = &pse_pi_ops; rdesc->owner = pcdev->owner; From patchwork Mon Apr 22 13:35:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kory Maincent X-Patchwork-Id: 13638533 X-Patchwork-Delegate: kuba@kernel.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56FDF746E; Mon, 22 Apr 2024 13:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713792971; cv=none; b=Msdt49HAGkvs0DSxtMCQ0hazTPxEBxGidv2EA0Wdh6mz3vTCY8LJx5jd4vvxe/6gnkW/CBZLqG+U9p3+at8XBUlujuYHoEO3E6HM/EZ74CvEIG5JE2hNxs/uhl0vYQDLA14VCMPAyYJ4Kht3G8ez91vMMAgDBfwgpEHPFLig070= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713792971; c=relaxed/simple; bh=MOieSkGFlLap9YqZh1kDWE4xoA3yyZ85BdHa4q/AEjY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sQyqbpvdTNNoG9z7gWqmeFWMymNCXFrFc1XdcjXkQ3JQau7IulN/N527wqqY7NhZgVcPaDKUr5yzTjbze0wsOMRNqKHSL463UmgIwgx+n2TNSHvpeyJ8cxa7+HZHLOCp2QhpTWMs8XkbnhCMOwnMAju+34FokZg8ppp8OUae/Is= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jIH1GQXi; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jIH1GQXi" Received: by mail.gandi.net (Postfix) with ESMTPSA id 0140E1C0012; Mon, 22 Apr 2024 13:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713792962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k2f64ANu3PLImfYGjhtzlKzsVrMAXXlyB8IVnzSIbzQ=; b=jIH1GQXi2hnbWCvqH9FvnVxSgSQbO+u0U4T7PfJRF8cSZ/ciZ6Bt8ZEjh87MJ3UiP8Ohgi xr3K3izrHsmttmBYS03DJigcLXh+KWJQKnTV1CN1qbsBx33ULXJ/WPGnjh6v3rTZsopnsB CB3pYpI7nikrB3+/Ve42SocQGUNjTb1BoBgSTsnId/iWrjPjVoy2za593Q0goTXILNdSek 0SPcjzNZHNZ70LQ/qywQOlig1OBhQdVZpy+lyWivMuubPCngBBk5EMOdnG4VyyYOW2zOZ3 gdvPfh4PiRCkuNLjdscVYQ7iCU9On9m8SMEpuFdqg60zFyOhZzNms/zuadY8KA== From: "Kory Maincent (Dent Project)" Date: Mon, 22 Apr 2024 15:35:48 +0200 Subject: [PATCH net-next v2 3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240422-fix_poe-v2-3-e58325950f07@bootlin.com> References: <20240422-fix_poe-v2-0-e58325950f07@bootlin.com> In-Reply-To: <20240422-fix_poe-v2-0-e58325950f07@bootlin.com> To: Oleksij Rempel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Swenson , Kory Maincent , kernel test robot X-Mailer: b4 0.14-dev X-GND-Sasl: kory.maincent@bootlin.com X-Patchwork-Delegate: kuba@kernel.org From: Kory Maincent (Dent Project) The PSE (Power Sourcing Equipment) API now relies on the Regulator API. However, the Regulator dependency was missing from Kconfig. This patch adds the necessary dependency, resolving the issue of the missing dependency and ensuring proper functionality of the PSE API. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404201020.mqX2IOu7-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202404200036.D8ap1Mf5-lkp@intel.com/ Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework") Reviewed-by: Andrew Lunn Signed-off-by: Kory Maincent Acked-by: Oleksij Rempel --- drivers/net/pse-pd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig index 80cf373a5a0e..577ea904b3d9 100644 --- a/drivers/net/pse-pd/Kconfig +++ b/drivers/net/pse-pd/Kconfig @@ -5,6 +5,7 @@ menuconfig PSE_CONTROLLER bool "Ethernet Power Sourcing Equipment Support" + depends on REGULATOR help Generic Power Sourcing Equipment Controller support. @@ -14,7 +15,6 @@ if PSE_CONTROLLER config PSE_REGULATOR tristate "Regulator based PSE controller" - depends on REGULATOR || COMPILE_TEST help This module provides support for simple regulator based Ethernet Power Sourcing Equipment without automatic classification support. For