From patchwork Tue Apr 23 09:21:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kory Maincent X-Patchwork-Id: 13639661 X-Patchwork-Delegate: kuba@kernel.org Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D046B58105; Tue, 23 Apr 2024 09:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713864078; cv=none; b=JjTG8BPBCc7hOa4NHay+cEBsaRPyzbpIVVyycZ+8WJxsnmRpEGCUNKV/dCAehsDdtDS+qT5wkxXvpHiWy5ygdO4dQQdIrjy60KULpM16aN2dMkv+fdG9qkT3EgH7+2Zgf7ViAaRJuDkXRVH4k2XqaThL8HLiQHiFrAD1OU9XKAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713864078; c=relaxed/simple; bh=yWNGNKRAobsTyRSC8HBOw5su3v89weJyamUOkfBbARw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q7VhNz83o/UyoWR/SXwJrnisnsvqEMjABYkb5SheQRIz1Kcj5xvs3NYLaAqAt4gvwZJ2fVL9Mr93tjg6DzLBj9kZkCp9JXM+tlWbzB86qKnvo0axl63KQBU4FpYc7hpM7gSIilCF3XbOkICTBXQBbF/6dnp943HuzsdPKRyi9f0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KVrwJmNz; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KVrwJmNz" Received: by mail.gandi.net (Postfix) with ESMTPSA id D0C8E240002; Tue, 23 Apr 2024 09:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713864075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H9/+gdlcc0RNLyeZGAneUT93PRl+K8VA2IX8p/L0w+g=; b=KVrwJmNzOcrrH6oRwXLHkF97A8idzsb9WR4n5FH+HBMjsgricvPehGnHf5AfDGOzQ3896C 2bhNi7UNX89yKL8GgHCtxSzp/NNTYLLD2KHXsQm+yI0XIRhUDDWfi8Gl2+bvJiP482YCMd urN8/O8+LNXJTcEYrRTO04u9dcNG/0twtKTOHoBP+49z2cTbBtptYDjkXSdjEUxE6HAJhc 5bRT2qW1484JJCm+oTe5pR405C/4njXd7FgSzxbJwMPsYNN1g1jf9/QaISC64UF87JuYRg /48qD0qA3QkaxgmkY27rQpVKhSTDXNuBjFurjRfQay1+4uc/fiJFssinfy4oKA== From: Kory Maincent Date: Tue, 23 Apr 2024 11:21:10 +0200 Subject: [PATCH net-next v3 1/3] net: pse-pd: pse_core: Add missing kdoc return description Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240423-fix_poe-v3-1-e50f32f5fa59@bootlin.com> References: <20240423-fix_poe-v3-0-e50f32f5fa59@bootlin.com> In-Reply-To: <20240423-fix_poe-v3-0-e50f32f5fa59@bootlin.com> To: Oleksij Rempel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Swenson , Kory Maincent X-Mailer: b4 0.14-dev X-GND-Sasl: kory.maincent@bootlin.com X-Patchwork-Delegate: kuba@kernel.org From: Kory Maincent (Dent Project) Add missing kernel documentation return description. This allows to remove all warning from kernel-doc test script. Reviewed-by: Andrew Lunn Acked-by: Oleksij Rempel Signed-off-by: Kory Maincent --- drivers/net/pse-pd/pse_core.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c index 31f23c454678..bad29eaa4d01 100644 --- a/drivers/net/pse-pd/pse_core.c +++ b/drivers/net/pse-pd/pse_core.c @@ -320,6 +320,8 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev, /** * pse_controller_register - register a PSE controller device * @pcdev: a pointer to the initialized PSE controller device + * + * Return: 0 on success and failure value on error */ int pse_controller_register(struct pse_controller_dev *pcdev) { @@ -401,6 +403,8 @@ static void devm_pse_controller_release(struct device *dev, void *res) * Managed pse_controller_register(). For PSE controllers registered by * this function, pse_controller_unregister() is automatically called on * driver detach. See pse_controller_register() for more information. + * + * Return: 0 on success and failure value on error */ int devm_pse_controller_register(struct device *dev, struct pse_controller_dev *pcdev) @@ -627,6 +631,8 @@ EXPORT_SYMBOL_GPL(of_pse_control_get); * @psec: PSE control pointer * @extack: extack for reporting useful error messages * @status: struct to store PSE status + * + * Return: 0 on success and failure value on error */ int pse_ethtool_get_status(struct pse_control *psec, struct netlink_ext_ack *extack, @@ -704,6 +710,8 @@ static int pse_ethtool_podl_set_config(struct pse_control *psec, * @psec: PSE control pointer * @extack: extack for reporting useful error messages * @config: Configuration of the test to run + * + * Return: 0 on success and failure value on error */ int pse_ethtool_set_config(struct pse_control *psec, struct netlink_ext_ack *extack, From patchwork Tue Apr 23 09:21:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kory Maincent X-Patchwork-Id: 13639662 X-Patchwork-Delegate: kuba@kernel.org Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9235C5730D; Tue, 23 Apr 2024 09:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713864079; cv=none; b=SvSIj7GnZMIEtM9xlqANFjqSBVS2NegvG9t4VrWjba9HwBioSkhMGgDyEf+vWZbJ9dawh+P8HMvduQx7uaHHOHJ3sEg17CoUswuUbtQ+E9tlXbQYbymRl7lMaV01CRD3Naoa1jbClwL/LiYW6swcdaEy0S4ZpW+EQfiGA8VEt6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713864079; c=relaxed/simple; bh=+bcOG7iwFtnTz2lO3InRZDB83IfORLXmlQlsJoEGxnw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tL0eShSYHDPk4l7WQojWmex8BvkeXal0aISfMZq9I0+IUvrDx/bPFNWruF3dLlH+8/+TnX6mgDDiSO/kXq0xMWWq38axbFZzmhkCCzzGrj8Oh8AI9DXCLtGR9hUJHFCTwIGKxwGCkIUD2M2iCGqHzfxSjisZy2fZbg0EZfB3Yes= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=CDIXZBin; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="CDIXZBin" Received: by mail.gandi.net (Postfix) with ESMTPSA id 6947D240005; Tue, 23 Apr 2024 09:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713864076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgnZ9zkLYTGa0PybM1NeuEhzLN21P/rf+/AbMdi1VXM=; b=CDIXZBinKb58tvc+8OO9aLxk2NOB9NHuGFKFEBruVht5n4Zd5ygFqxwIeA1ZlbaxXcRSiz fgl+MVMMCTgVDlTUbQl1Vx0lnbgoR/ArTYS2wqDup9jTKnoaqLbQLKWeXSIPpIh0SA1r6f GAO5enmLMFj13KRJjZ00N7wnez/f1wpRpOgCETd1HYZ44GUj3e/mkZ5NTbvxCEgB4CCdSc Gz/jzACbosfAtLZsJrznT0VrSIEUhkFaK0uoyKja9HPFLOrcs22cErgnEaZPfckZFnquVI Bhs89zU+a77Hh2mdSkQ7Grhwm1J/0900hFCnot9XDzkXHLmavanUJVGBVQdh9w== From: Kory Maincent Date: Tue, 23 Apr 2024 11:21:11 +0200 Subject: [PATCH net-next v3 2/3] net: pse-pd: pse_core: Fix pse regulator type Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240423-fix_poe-v3-2-e50f32f5fa59@bootlin.com> References: <20240423-fix_poe-v3-0-e50f32f5fa59@bootlin.com> In-Reply-To: <20240423-fix_poe-v3-0-e50f32f5fa59@bootlin.com> To: Oleksij Rempel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Swenson , Kory Maincent X-Mailer: b4 0.14-dev X-GND-Sasl: kory.maincent@bootlin.com X-Patchwork-Delegate: kuba@kernel.org From: Kory Maincent (Dent Project) Clarify PSE regulator as voltage regulator, not current. The PSE (Power Sourcing Equipment) regulator is defined as a voltage regulator, maintaining fixed voltage while accommodating varying current. Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework") Reviewed-by: Andrew Lunn Acked-by: Oleksij Rempel Signed-off-by: Kory Maincent --- Change in v3: - Add a missing Fixes tag. --- drivers/net/pse-pd/pse_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c index bad29eaa4d01..795ab264eaf2 100644 --- a/drivers/net/pse-pd/pse_core.c +++ b/drivers/net/pse-pd/pse_core.c @@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev, */ rdesc->id = id; rdesc->name = name; - rdesc->type = REGULATOR_CURRENT; + rdesc->type = REGULATOR_VOLTAGE; rdesc->ops = &pse_pi_ops; rdesc->owner = pcdev->owner; From patchwork Tue Apr 23 09:21:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kory Maincent X-Patchwork-Id: 13639663 X-Patchwork-Delegate: kuba@kernel.org Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 530113399A; Tue, 23 Apr 2024 09:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713864080; cv=none; b=M1KAwfSUJR50vHIKZ2t9fx7iY081oPOmabm9k3Ih8w4EniXU6aiG1arCEta42mXT3AyDYO31zSA8dTQCyHcw2mfKo1DtJYwcJo6So9Mz/slEp4w2QRNGj8bf1qB7LfDSxrVzD+Xu20N65k+uurkpmKT/IjvVa24f/DXdnGAY8Ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713864080; c=relaxed/simple; bh=bJDjV5+y19iYs0jsERhc9wrq10cgSv0rW0l3K679Kjs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fg01wd/nGnSM7OLk80Ng4gGHg/QiAvFSW9wik8Coqek8r742daI6oWioUY/SOoOoefBtVBg0xhby4IUUtVzHD5xqvHbLRjv+AC8z1b5ws6GJytHQAlxnBCt7EqKoswk0a5bF4JHSUY07FffEiik+Aw0J9+sxLwXsSnhN0UgkAp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jEr4m6Xm; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jEr4m6Xm" Received: by mail.gandi.net (Postfix) with ESMTPSA id 15E42240008; Tue, 23 Apr 2024 09:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713864076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZUMcCLKyqM24JFjjdsriw3H19crjA0icuaIuq2mB64=; b=jEr4m6Xm3ryzjHiFJEZdmLg2cFVG8aoWfweW7CUkS7GHN9UJMRBJfgr73hl18DaXmrN5Iw P3+BIDN8CnzRtSd6GYGRL5OfsFLjJYDdHJp3X9p7hqZSMZQRk7ew6ym95jviL2DmIKEB29 eOCA+Rzp4k59wDoOCCT9Klv434eKpJwLxaXRfGoc9Jx5yd/qI2U1rsc3tdUz3ZBtpPIdc+ Dpsz9CszArOzCsJkmP8X2cWXx3IDgDCVDmO30MyTzp56HMNTEix4xfYdz3z3C4RlWMeYuR 4TpYDWws65etjYfTvcQPIAFp+o0HEyfdpXYmmlglrg9aqpppR0Jmk8zfhcx+ww== From: Kory Maincent Date: Tue, 23 Apr 2024 11:21:12 +0200 Subject: [PATCH net-next v3 3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240423-fix_poe-v3-3-e50f32f5fa59@bootlin.com> References: <20240423-fix_poe-v3-0-e50f32f5fa59@bootlin.com> In-Reply-To: <20240423-fix_poe-v3-0-e50f32f5fa59@bootlin.com> To: Oleksij Rempel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Swenson , Kory Maincent , kernel test robot X-Mailer: b4 0.14-dev X-GND-Sasl: kory.maincent@bootlin.com X-Patchwork-Delegate: kuba@kernel.org From: Kory Maincent (Dent Project) The PSE (Power Sourcing Equipment) API now relies on the Regulator API. However, the Regulator dependency was missing from Kconfig. This patch adds the necessary dependency, resolving the issue of the missing dependency and ensuring proper functionality of the PSE API. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404201020.mqX2IOu7-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202404200036.D8ap1Mf5-lkp@intel.com/ Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework") Reviewed-by: Andrew Lunn Acked-by: Oleksij Rempel Signed-off-by: Kory Maincent --- drivers/net/pse-pd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig index 80cf373a5a0e..577ea904b3d9 100644 --- a/drivers/net/pse-pd/Kconfig +++ b/drivers/net/pse-pd/Kconfig @@ -5,6 +5,7 @@ menuconfig PSE_CONTROLLER bool "Ethernet Power Sourcing Equipment Support" + depends on REGULATOR help Generic Power Sourcing Equipment Controller support. @@ -14,7 +15,6 @@ if PSE_CONTROLLER config PSE_REGULATOR tristate "Regulator based PSE controller" - depends on REGULATOR || COMPILE_TEST help This module provides support for simple regulator based Ethernet Power Sourcing Equipment without automatic classification support. For