From patchwork Mon Feb 25 15:59:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 10828801 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88C111575 for ; Mon, 25 Feb 2019 16:00:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7585D2BCCD for ; Mon, 25 Feb 2019 16:00:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 733262BCDF; Mon, 25 Feb 2019 16:00:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60EE12BCCD for ; Mon, 25 Feb 2019 16:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727902AbfBYQAt (ORCPT ); Mon, 25 Feb 2019 11:00:49 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:60233 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727684AbfBYQAt (ORCPT ); Mon, 25 Feb 2019 11:00:49 -0500 Received: from stefan-Vostro-260.fritz.box ([109.104.53.79]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M7Jj2-1guzoG1ske-007kBs; Mon, 25 Feb 2019 16:59:56 +0100 From: Stefan Wahren To: Kamil Debski , Bartlomiej Zolnierkiewicz , Jean Delvare , Guenter Roeck , Rob Herring , Mark Rutland Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH RFC V2 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan Date: Mon, 25 Feb 2019 16:59:17 +0100 Message-Id: <1551110359-19860-2-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1551110359-19860-1-git-send-email-stefan.wahren@i2se.com> References: <1551110359-19860-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K1:eQ6be8+xN/Kp+WdWtHteev5zaicZG8qo2dkAXGE1IW8/s/jeT5h 9yvyLGBTulrXXKI0eBgBGkQtyhZM2cC7e2r327/hYsvalgR7DrwoQldzuGF3g8B1uPIbZUs vvvjZE13Ws94I8YsZqOphX1wh/Qf8pd1W6LL38iUGujbal9CDy2VN1yQc6Wixd7kbsYVwk3 uL5iHge0hZhwktbXSWGwg== X-UI-Out-Filterresults: notjunk:1;V03:K0:VNLDuthaZDg=:1Ek/LC5E/KdBMYdlGAmMb6 sQ3MKCbop9trcckHGb97Aop6PehW0jNFRXlhj4se+7jv3S6Gw5+gbYBMzc9tuyAccPvKKcUPa UzumIFE3SR6N/z/tTMhh8DcebzSo89pZ9gDOhevHnrA5K/NHPEaPNubbsPwzZP7psfCYGFHLC rzCAaTcMu6vgs9iGGAnmHnvfDDnz1mUjd6VGh97PqXZR18j4LtC45+URGQuKy8HPBHSKkx+t2 fQNrwly5kZSx8OJx52tUdLRya1goIKflgUqd7esN1D+PFEVqJGqkavN3DT0zW9bUOcr7/15ry /oVSJgbxFBMhTelP891lvrxs5oLiRs+XkmaUYZBVaZjB5s6TpTWRvLyeNrUY0xrXv4m+JWvzq tTTT1r4YbUpcg8XPJtZrzEYlGJsDg4wjglaAfxJDH1T4pynbsCgVP+96il3XsKRKzvnudqn0a BoBEmwJGwrCo9m/n7DGAvSSvMHRBD5z5gMgbWSzleqYV4R4x4yKEXQsKYwqedeDuLo8TOOhWe fXWP7UIyXZjkXTiWOmydeqxkuMkrIr+MeTSoB3+yazOk+9sDRiIaJ0DqEdBl0RTYfljdL5JkE h3GM0cNHx4fcQo2+zaeqsagv0XFbAUXw7GEcaVQMxHpqxNSIj7di1+YEK6f4R8jDwLvexbyon D66f2s1Fk3zmN50ZwTrvCKyf7NAsLH8SdHX+Wlqj0smkhEtOKFAe0UlqZKsq4PLAJvXNi2O/R b4hDus7oWE/iOSb5YusX65b66tgBBFIVqGaC7excUv9xw1E5/2kg0Rn1xIc= Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This adds the tachometer interrupt to the pwm-fan binding, which is necessary for RPM support. Signed-off-by: Stefan Wahren --- Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt index 49ca5d8..7d09623 100644 --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt @@ -8,6 +8,14 @@ Required properties: Optional properties: - fan-supply : phandle to the regulator that provides power to the fan +- interrupts : This contains a single interrupt specifier which + describes the tachometer output of the fan as an + interrupt source. The output signal must generate a + defined number of interrupts per fan revolution, which + require that it must be self resetting edge interrupts. + See interrupt-controller/interrupts.txt for the format. +- interrupt-ratio : defines the ratio interrupts per fan revolution as an + integer (default is 2 interrupts per revolution) Example: fan0: pwm-fan { @@ -38,3 +46,14 @@ Example: }; }; }; + +Example 2: + fan0: pwm-fan { + fan0: pwm-fan { + compatible = "pwm-fan"; + pwms = <&pwm 0 40000 0>; + fan-supply = <®_fan>; + interrupt-parent = <&gpio5>; + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; + interrupt-ratio = <2>; + }; From patchwork Mon Feb 25 15:59:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 10828793 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5A3961575 for ; Mon, 25 Feb 2019 16:00:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44B7F2BCC1 for ; Mon, 25 Feb 2019 16:00:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B89D2BCAE; Mon, 25 Feb 2019 16:00:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB5712BCAD for ; Mon, 25 Feb 2019 16:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727704AbfBYQAa (ORCPT ); Mon, 25 Feb 2019 11:00:30 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:51621 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727659AbfBYQAa (ORCPT ); Mon, 25 Feb 2019 11:00:30 -0500 Received: from stefan-Vostro-260.fritz.box ([109.104.53.79]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mzi3l-1hBxnh38z3-00vieL; Mon, 25 Feb 2019 16:59:56 +0100 From: Stefan Wahren To: Kamil Debski , Bartlomiej Zolnierkiewicz , Jean Delvare , Guenter Roeck , Rob Herring , Mark Rutland Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH RFC V2 2/3] Documentation: pwm-fan: Add description for RPM support Date: Mon, 25 Feb 2019 16:59:18 +0100 Message-Id: <1551110359-19860-3-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1551110359-19860-1-git-send-email-stefan.wahren@i2se.com> References: <1551110359-19860-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K1:rDt8rM8KQB7JFkh3ue3qtgnNVwqdhgTVjkuzq7YJjfKcx4G3RLQ ZAOY6VuACZp32WN3rZ76TCxfMuEueg/h4gOamV6qi97+sWRAa3MEGLeIpzIg0Ox3X8H4AGB K7TXTDMVcUH9xuDejYbE7qBMRd+Ng66UKhhpiDDNoI5vIDCVmW5JxgvyNJxDDkcU7WEuVVa gw1k+JKQDD494X0dzxJxg== X-UI-Out-Filterresults: notjunk:1;V03:K0:YcnrOrRgbC4=:bKedZtA2+xcuV9deovjPhf o+C2kfVozulnUkG7GtEPbXm6erhPX1zyFPUqahEO7IKz7rgTK7U4p8gdcaPSIT/OZopMK6UWj dhamxS2Iip7xvuJ/ulNYVDifvfUezgP4RX+ovv65d/2nX1ghjaTwuUSkZnXrtYogoocDoRkuS TsexyT0XGPJN9UmICwIxnM8j6DBwx2IEtQoir78NSnx8ioKNv4W6VDe0IbZ7wnyyV+xqXUa1e MKvjyAz0lkUsO3Lf8XTbC2nvcsMIuJA5spEajA9NzubVzXZiq+Dfm7yLObOp+SP90ue7SO8gY RYaXxGvOT8zLXgH4AeMkjtCY8ND8XLoOv2mGfHD0FihIv6n3Faan228vC5dsHE7SPZRSIazUl 5COllol5FZ6y2pL7S92bmhvIDWewBxEqVdHSs6gPKMQD6h1/UcoYM16/tXW0hfirKA5sQNIyk QgU9Fo5ZLVEfUXVOb/kbWQ0OC2yq1Ui0VBCnrIjaAVZ6rPvUoRU0iAV5pCijEp5Trq2eTNTKT NNS42Dc3PLTehnn2Znat+BsHqJ/GUdIUFaGQBCzf6m0vj2XzdlZEVVWVUGMqwY0nWgrjNcXpi BNcGpVOzLHKfNsqrACzT++C0ec4zTbUMHqTLfI59rJUCQsO4rIptdUMNIobdppKZqFORJl9dT fv8GQjdR0MvdfeCTueq9ICJf2CvhHG+2+gB9cGlCe5nA19Tt64+uqBC9kRCCaciXbzDXTEcDL rinKUfqN+g80bRfcmZo+34Wv1BaktXJip+jTavqemJ7Nr5gO4sPhh2CuiLU= Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This adds a short description for the new RPM support of the pwm-fan driver. Signed-off-by: Stefan Wahren --- Documentation/hwmon/pwm-fan | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/hwmon/pwm-fan b/Documentation/hwmon/pwm-fan index 18529d2..82fe967 100644 --- a/Documentation/hwmon/pwm-fan +++ b/Documentation/hwmon/pwm-fan @@ -15,3 +15,6 @@ The driver implements a simple interface for driving a fan connected to a PWM output. It uses the generic PWM interface, thus it can be used with a range of SoCs. The driver exposes the fan to the user space through the hwmon's sysfs interface. + +The fan rotation speed returned via the optional 'fan1_input' is extrapolated +from the sampled interrupts from the tachometer signal within 1 second. From patchwork Mon Feb 25 15:59:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 10828797 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3AD38922 for ; Mon, 25 Feb 2019 16:00:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 285922B7CB for ; Mon, 25 Feb 2019 16:00:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2652D2BB75; Mon, 25 Feb 2019 16:00:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6B932BCBE for ; Mon, 25 Feb 2019 16:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727901AbfBYQAb (ORCPT ); Mon, 25 Feb 2019 11:00:31 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:44497 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727684AbfBYQAa (ORCPT ); Mon, 25 Feb 2019 11:00:30 -0500 Received: from stefan-Vostro-260.fritz.box ([109.104.53.79]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MkYHO-1hQXCd04hq-00m0gc; Mon, 25 Feb 2019 16:59:57 +0100 From: Stefan Wahren To: Kamil Debski , Bartlomiej Zolnierkiewicz , Jean Delvare , Guenter Roeck , Rob Herring , Mark Rutland Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren Subject: [PATCH RFC V2 3/3] hwmon: pwm-fan: Add RPM support via external interrupt Date: Mon, 25 Feb 2019 16:59:19 +0100 Message-Id: <1551110359-19860-4-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1551110359-19860-1-git-send-email-stefan.wahren@i2se.com> References: <1551110359-19860-1-git-send-email-stefan.wahren@i2se.com> X-Provags-ID: V03:K1:LwcArMQy/ey2a01eMuwgWYAwoo/T8wEmK05hkYl2hOZTW2ciUh+ q7Ty+3mW33rWOOg6TacSfQxt/uNnEz82irp+E720/xXNAwbx6XbyXsrHTHu5mKwVoasJMPp JPQbxEzxT90mGT7+mZTgVp8HhbmK8Nb7Qlgcy20HPV8nmGCQJqjEWEyoWBSfmEyVRsA7dSJ l9Ak6xRFhGPMDIXRqdVLg== X-UI-Out-Filterresults: notjunk:1;V03:K0:BPHHqNE7ZSw=:lxL7hosapKqdz2RNnXHk9X OqJm604J9zNow/mo+8ioiOptwFjaT8o6tceicE1ShdnXB3X70Dvx3QN93Xq9bhicDrHQBXejh HHoDUt1+sN9eQ7Fa8K8mVXzdv2Bkjm20mVP//T3zboik97x8HXfZLIIfs8yS4uMBX3PiGhrGe xXpnItHOFSd15N0/ohDaULRRaZcZFwkcs5SQ/MHCIZixKiDbOuWe7XjTXzRmlXx1kpQ9CJ/Nm pcxjk7D1cxL6rIpOt35jqMAarWvoHqv3tV0L0/A3iJgkpKuvnAjTG6FRTj5bcDAfW8YRUwMkl yqkzlfms+DbYgNovmBLw5YU+yvj6q91gvWMOJCWKUIGK5FDvmqa/OBpuP6tdPG2CYK6FjAxN5 Nv5cbpzGKOSPGm/5nf4D9ZUUnf1cQDkHe7ZPefClL6tMYMGMWI/T/aKoHrlEFTINkQ4122fwC +Wx2wG2zo1CJ/zYLXbS/I6xk01FBkRSVzpB07vxuOu2Y5OHsT9AtJ3l+NtkmOyXb8Tjx8Y+E6 VyIYZ7S9eBL3Cx0wfND3uSnIv6yz4+LhSbtsAF1cWhpcVy8p+RLBegasJVdXaJDmRheHyiV1u bydR+KQC4cCo+e9g9ZqiMc51jkct7OHYTNeMor5I04rcfVUjOb6LjAEb/huMuq5gpSX9OLlUg Zze3Mr6MjrBrPPFGSLhGQj7Zr5n2LlyKlkxG3+Gn8NCTkVYEzhbUMjco3yY4ZZqv6+i6zTjpV 2DPeW+Xa2aUtc6jLRAKGT4wsAZBW69fuHOFQx5k+rRqurMpQtIPu0siYrag= Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This adds RPM support to the pwm-fan driver in order to use with fancontrol/pwmconfig. This feature is intended for fans with a tachometer output signal, which generate a defined number of pulses per revolution. Signed-off-by: Stefan Wahren --- drivers/hwmon/pwm-fan.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index 167221c..0bacaba 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -18,6 +18,7 @@ #include #include +#include #include #include #include @@ -26,6 +27,7 @@ #include #include #include +#include #define MAX_PWM 255 @@ -33,6 +35,14 @@ struct pwm_fan_ctx { struct mutex lock; struct pwm_device *pwm; struct regulator *reg_en; + + int irq; + atomic_t pulses; + unsigned int rpm; + u32 pulse_per_revolution; + ktime_t sample_start; + struct timer_list rpm_timer; + unsigned int pwm_value; unsigned int pwm_fan_state; unsigned int pwm_fan_max_state; @@ -40,6 +50,32 @@ struct pwm_fan_ctx { struct thermal_cooling_device *cdev; }; +/* This handler assumes self resetting edge triggered interrupt. */ +static irqreturn_t pulse_handler(int irq, void *dev_id) +{ + struct pwm_fan_ctx *ctx = dev_id; + + /* Avoid possible overflow */ + if (atomic_read(&ctx->pulses) < 100000) + atomic_inc(&ctx->pulses); + + return IRQ_HANDLED; +} + +static void sample_timer(struct timer_list *t) +{ + struct pwm_fan_ctx *ctx = from_timer(ctx, t, rpm_timer); + int pulses, sample_ms; + + pulses = atomic_read(&ctx->pulses); + atomic_sub(pulses, &ctx->pulses); + sample_ms = ktime_ms_delta(ktime_get(), ctx->sample_start); + ctx->rpm = pulses * 60 * sample_ms / 1000 / ctx->pulse_per_revolution; + + ctx->sample_start = ktime_get(); + mod_timer(&ctx->rpm_timer, jiffies + HZ); +} + static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm) { unsigned long period; @@ -100,15 +136,49 @@ static ssize_t pwm_show(struct device *dev, struct device_attribute *attr, return sprintf(buf, "%u\n", ctx->pwm_value); } +static ssize_t rpm_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); + + return sprintf(buf, "%u\n", ctx->rpm); +} static SENSOR_DEVICE_ATTR_RW(pwm1, pwm, 0); +static SENSOR_DEVICE_ATTR_RO(fan1_input, rpm, 0); static struct attribute *pwm_fan_attrs[] = { &sensor_dev_attr_pwm1.dev_attr.attr, + &sensor_dev_attr_fan1_input.dev_attr.attr, NULL, }; -ATTRIBUTE_GROUPS(pwm_fan); +static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute *a, + int n) +{ + struct device *dev = container_of(kobj, struct device, kobj); + struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); + struct device_attribute *devattr; + + /* Hide fan_input in case no interrupt is available */ + devattr = container_of(a, struct device_attribute, attr); + if (devattr == &sensor_dev_attr_fan1_input.dev_attr) { + if (ctx->irq < 0) + return 0; + } + + return a->mode; +} + +static const struct attribute_group pwm_fan_group = { + .attrs = pwm_fan_attrs, + .is_visible = pwm_fan_attrs_visible, +}; + +static const struct attribute_group *pwm_fan_groups[] = { + &pwm_fan_group, + NULL, +}; /* thermal cooling device callbacks */ static int pwm_fan_get_max_state(struct thermal_cooling_device *cdev, @@ -261,6 +331,26 @@ static int pwm_fan_probe(struct platform_device *pdev) goto err_reg_disable; } + timer_setup(&ctx->rpm_timer, sample_timer, 0); + + if (of_property_read_u32(pdev->dev.of_node, "interrupt-ratio", + &ctx->pulse_per_revolution)) { + ctx->pulse_per_revolution = 2; + } + + atomic_set(&ctx->pulses, 0); + ctx->irq = platform_get_irq(pdev, 0); + if (ctx->irq >= 0) { + ret = devm_request_irq(&pdev->dev, ctx->irq, pulse_handler, 0, + pdev->name, ctx); + if (ret) { + dev_err(&pdev->dev, "Can't get interrupt working.\n"); + return ret; + } + ctx->sample_start = ktime_get(); + mod_timer(&ctx->rpm_timer, jiffies + HZ); + } + hwmon = devm_hwmon_device_register_with_groups(&pdev->dev, "pwmfan", ctx, pwm_fan_groups); if (IS_ERR(hwmon)) { @@ -306,6 +396,8 @@ static int pwm_fan_remove(struct platform_device *pdev) struct pwm_fan_ctx *ctx = platform_get_drvdata(pdev); thermal_cooling_device_unregister(ctx->cdev); + del_timer_sync(&ctx->rpm_timer); + if (ctx->pwm_value) pwm_disable(ctx->pwm);