From patchwork Thu Apr 25 12:08:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 13643269 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D43B112BEA4 for ; Thu, 25 Apr 2024 12:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714046955; cv=fail; b=PRcTzvoox7IRMV/B+mnc6M2yW9CF2e792F8245ys2QzDsYWKndH31tyhAbxHKzhii1NWJqS/And5YqEh1UvEYeTFzCFlyq1Pz1Jjf5wNK2nHMNPuH5xi0bArtpT4xpACKqBdNzKO6+Q9f/qjwpY8/b4N4SPeq/Ic7bhso7YoZy0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714046955; c=relaxed/simple; bh=+5tedtcvqiZYqMC+2tgJoOUX79OeMtgOPwGMApe83Ns=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=tNBsvauGGa9bnTjMGruUfazxdW5sfBniVZ6t6w97ZnFkfN7M7JohODIR9HLXffObR4luilkJdqFrt6GGL4V9Iao+3txMd8oiMFpjE7ttWux1UFWjy7hTWbortb+aVDOXSjxv4UFq6iMQocFTLfJLt0Gyw6IeIH6LVP2jdUTyOk8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=ftGRZNBF; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=LS/6Xzo/; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ftGRZNBF"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="LS/6Xzo/" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43P8x3NS000742; Thu, 25 Apr 2024 12:09:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=0x2z2lMXeq2TDbYdq31rRHqCtFnplUO/Ay3oh395OUA=; b=ftGRZNBFf70AGqpLPNp+ABsdLzT4w+KHtZ4+ikaJAfqTjrH61riOF0/UY6vevCD+5dRb gEMTMlZcad78PvJ4WsjOcDOX0slMtNb3Y7TSnQmR01UbZq3hqFNSVi1EYCHRCFCvFsbP f3sqEG7/jJ2TyiPQUVd4jSEBOlzRhST0PgaGOO/gnTLGaAf8Q5eG9U6X+dfyIyq0xaf3 zXY2bK7gxaFFnj/gJxfkBz7YiNzQBg3FdX9dDo/ONzZpw5sP4H3iWhdN3o1Bd3mRsS3P WzKiJvDXBq9xelIM/VJ4CkNvygg0+9IFWsj2qUjN2VlwGmpEG9jFyUFK5y18PwhbSzzH Sg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xm4g4jb80-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 12:09:02 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43PBGSf2006164; Thu, 25 Apr 2024 12:09:01 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2041.outbound.protection.outlook.com [104.47.73.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3xm45a9v1q-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 12:09:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9YQGQ2mLGoSDYvc94HXRHcTd+oj3J+dr7OkTHEPxFwqpSSJSI+2mQKlQkN8US6ee6ZV0WXn0DV5+uXuL3nb7LxEc/lHEwZEnaEQkEZCUtyNpPVm/l+aM6+Pwj1h6nvkI6Ht2ekuq7RMacYw5UAkAlTSqh7mKa43NnrZ5fUzpHNzgqJHn7HQHDPhreEvNZxN11f5RaaCVmZgLtdHy9wzTsKIq3w6F/cmtdPEVIoFUr2Flx2FixI5sxeiy/685jEe5q15JDXeeC/3dDqK0m89ajNPCzTebW4Rw8qHeA4VETDAGFLZUvhpIqjysce+7tVECclkEOzcgOaNSMs0/t12kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0x2z2lMXeq2TDbYdq31rRHqCtFnplUO/Ay3oh395OUA=; b=YAxKrF2hWCUz7ERg+S19B4kwhkU0Iudv4Lx4EA0xgguK8CPEHjniRys+PCEBuHF/vIXgv6tdtgqQTCnmNtpAhnv6dIgEtnB59kEgvPh/Fw6DCu9tZ3aROA/W7jikutYNBWAyAIOTqComaAQjZ7vyqOLUSm3R3YSNv6WJ7v9r/yKvvtaFgUugIWSiv1xvinZLOHrAsYh0a90SpXl+PISZQY8agf/yP2FKUdxdLR7eIogNzwB2yiweg06tSFklx8PMFeNx0GDcvGf8mnUDc6ufN5AZtAxnTb6rau9RrTBB/s7lcEjmTSPXU86lISMwfOHl+xxkNeVbO6pwk4IVyd3szQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0x2z2lMXeq2TDbYdq31rRHqCtFnplUO/Ay3oh395OUA=; b=LS/6Xzo/kxBt+wkrO5fwE1JScdX7X0/ON4PWBtHiLLNDj6xMhYmolbsHV9NMQ1KjnoUWHE3Q8PxiCmc7l0WmeECwxXAwUaKhES4ducW79qHSW4u1Vt1loucCfEIB3BRF/Q2MnhwphKB4tlpA51rnr9IpGAf4ONA76+kinhbVE0o= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by IA1PR10MB7197.namprd10.prod.outlook.com (2603:10b6:208:3f2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Thu, 25 Apr 2024 12:08:59 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%4]) with mapi id 15.20.7519.021; Thu, 25 Apr 2024 12:08:59 +0000 From: John Garry To: chandan.babu@oracle.com, djwong@kernel.org Cc: linux-xfs@vger.kernel.org, John Garry Subject: [PATCH 1/2] xfs: Clear W=1 warning in xfs_iwalk_run_callbacks(): Date: Thu, 25 Apr 2024 12:08:45 +0000 Message-Id: <20240425120846.707829-2-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240425120846.707829-1-john.g.garry@oracle.com> References: <20240425120846.707829-1-john.g.garry@oracle.com> X-ClientProxiedBy: BL0PR01CA0003.prod.exchangelabs.com (2603:10b6:208:71::16) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|IA1PR10MB7197:EE_ X-MS-Office365-Filtering-Correlation-Id: 62543036-ef19-4a8a-7772-08dc65207d19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?IcAt+487LZZycTAoKXCWAf+BY2Q40OM?= =?utf-8?q?nePTC2uj3dL3bYx7Buh98N3dBu+UmaO+o5wt6k5jVogDHY6MAN/FNbjFyHBqdhH0m?= =?utf-8?q?1PBjCf1q6xz+tvVNddElHToMdvt0Up/2oXlJb3la91WJZBKTHoD5hb1WWabKuYtDY?= =?utf-8?q?EC0+ahhVJIaklxeCVaAzDFherptQr7TAOJmbaYgC/2vHE3tdJqa4yU7Vh6WbnUElm?= =?utf-8?q?PiZosjDQH3dgvkDBERFAP89lkJ8OABQYLZ7LHlAL+ujLP/+W9fID8GwGyqfJxfpL5?= =?utf-8?q?UNzYFKeKnDZaDbOv7rDUO5Ptl48vSICPd/Hm+CLA9jkZlNGmgRUXYLGQvpGAhJlr5?= =?utf-8?q?z5J5a129d1ZO++1+1VtOpYx7EiX/7LCGTCHon/Zac6dxdoBUx6T2Sz5r/VJNGT96U?= =?utf-8?q?z669KKZjUhpKFl0FQPXVJS1QSL2tOgI5FXxy+hIX/sidFuf11Dsy0lq09lWpNgzcX?= =?utf-8?q?PGuySCftpLX4QIcpYhZXcrTFZ01HOIpPy2kjqVBHLZ3pqAEifbILwXefQ+P0DtPb3?= =?utf-8?q?XKtBlu1jrrpuEjIgr8ypR/HnaGuZXeOYiOBc58s/+PztqV0sQEDRUKphnR6XUtT0U?= =?utf-8?q?lMRpnlN3d/FNzXxjcMWhsJPLO3ZSN6VZmtwmZjHplRe+Pin17fE9B6ZER3uV/b4Zp?= =?utf-8?q?UGikGLnqBjzO0LBYQajWB+nZC8BG5DkG5Ct5DIWf4HcFRgYH9E5NsLtKA+JmvzXi/?= =?utf-8?q?rG2tsCnhmHbqy8bCA78cvm4X8zNNr8nZxXiqwy3gf+ERJiiHRzUl44ZLLCVb24RkL?= =?utf-8?q?u0ZaZrciL1QsXzo3JAc2DyENXmoifoYGwXa56d1JAL7uLCe4MmEzqGKAFDIoueL6y?= =?utf-8?q?IhwAqvbighFJ72xzJ6ICUNPqlxcMC3VwQ49Mdw07PYGOt9wxB9rJCan6KhhQtweMe?= =?utf-8?q?amHfkC4SL+/wwNAhfe8aVx5w+7JyMtELMQY4QXT+G68lQNXUiWLkpia90ddc4koV+?= =?utf-8?q?NpsnZhqA4EsEEQ10tI2Vhlwmm05/EqRsWaRDM+ptoqROWGajsOyjicI6R4CcrMhs7?= =?utf-8?q?UvJ3pCrd0nov+bJzrnCNWCqiuH9djhP5X2TvsWaDfV4wJfkM9eXE1THciSVb/wI6Q?= =?utf-8?q?dEKm/lgwC+4hLtcdqDz9UJZuFREipDi7fcw5D8oiJd0ygPBvzbYJ/uVMax5fCTdEQ?= =?utf-8?q?OYRXAq9opv5Cdm6hWznSrbmE7yPcfMN7NbtCC9qYWpf2E+8SoqQCjbUnxUvroFaCW?= =?utf-8?q?qMr5Ln9g9VFQX5jnUpd+TvvWXYxBClQ4Jdaw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?CZ/wZAWLMQslGYGxeIayiSQyWV2W?= =?utf-8?q?NmEph9h8iwMrZrAOCVFbTswQ4zaOzNXnczaRp1cpZnemMz3zzkKuiOJ1fgdiNYQ5a?= =?utf-8?q?XXz90YiMonZ0WVnHtiXcfDFZw/OrohAeO0S46wgntoLwgRU+hLlN2pLLIspWCNdms?= =?utf-8?q?Snv6dLlkqjkoJ4QDsiNJE8qafvka5pIeaXYSBV1tVq3PK4VDMEEBywLlI5BeJCe5u?= =?utf-8?q?s+9mJiP8Fyc+6ERAZdMpLO/XBdqeG5BUeFKJdqnv3U7c4fgJ6CTRiFwF0JHqUwd26?= =?utf-8?q?e4S37tga8ZOajOjaR1HqJZCrmialiepysJ9JQdArEydwOmIwaO7sE7NIBUU4o7mGQ?= =?utf-8?q?tLCnOG1yrW5wedCqXh80Cb1J4X33qcZjHeAb2FkVrk5eN8+LJUG7134uQgcszdW9m?= =?utf-8?q?2zwVqimAvLTOEv5NRPAOkWJ+OYMvcOY8kjr5g6W2s4T2U4OUBdnLVgeWhD00s6wnt?= =?utf-8?q?dF0dgX1v2h4PcJflN58JkJI48yyCqXsC4XcgplpWE5HbPlJcgXLLr4cUx5nNMV/7f?= =?utf-8?q?rBNYEx+t1qjMgADzwSub260cWlC0MyqNce1FMl//B5M3tyrAmI6dmLg56usPaXBcN?= =?utf-8?q?rRRjGtb4DZvR/8uKINPsrhbP6pQ+VHABSdRZ9HtrzgrNBR0PFKZq7OxDirMwzWzA/?= =?utf-8?q?RQCWa8FcbTa81zXCDik8CpgcICpecRynSAVLGZ3f+SZrlKGX9zW16N1AbmNrnoakA?= =?utf-8?q?rWtEGlscSW3pY2di/7nByfXwdNWVHQr7LfXFUDzUydhMFxt7/HVcoqnKqUXeCy/yf?= =?utf-8?q?mG3SMAQuC4gCgON1ZjG5E+xO5ki3A9BtL+KN7JNkf5va7t28lPuca0dB2XAMqx9JC?= =?utf-8?q?rsmwK3w3XWjoUiz2zp1K8xUWV080F5zUqptyk/Zk87ViLQlDc04Mc9d+XumIru7FN?= =?utf-8?q?x/YX3BAGacQGu0o9WMuZOmHIQyXSdd/yO7UV+dD6dSA5S0aIWBeWQswSrJ1IF7ZBF?= =?utf-8?q?KNOWGPHPQQ+ru1aqzoWEuRyUbX9Diym4pQIHa8eNmAkomrLu4/jLF0LptwIPAkYw2?= =?utf-8?q?VnRkO1z6AoryzQm0vQL+AJmm/m+PAcVYDpxJTaIpDGIA5dOJP10iy01Fh0zTSNi7G?= =?utf-8?q?tfZY0lqhCPrqPafhtS4NaMOQ7G3ZtMrmgZYLH/YQ6gsbIqpUeK7Uk8wKDJy1dvAVd?= =?utf-8?q?H21DJHnkUK/fxsUkRb7Wgfiwxp4C5Jv6ljayiUa/v/Ag2oJfV7dHLnIxim+oHH6mR?= =?utf-8?q?GlOuiRdlvI5xLl+at2vIIkN0jeRyxHa6BHBI+YbyZ3RWxctu7fKxqBJOksbooiunf?= =?utf-8?q?eWwm4iZaP9Gj/XqP5gbl6CXmqX7rCRIURGwGTOSyuzS22Zxrrgv4temnYgEflGalR?= =?utf-8?q?2awWS80Yw5XKEy/sTFXyMv+1qRCLgrrE40ab8cmgsQhWeL3ziNBgoQj3DbTov7Rvc?= =?utf-8?q?qTg5bmfeuX5XQF29Escw5/nuPPYV0dvO23YbwBNisWIy6rGMn3LdoaY0In26PsFtI?= =?utf-8?q?h+e/9Lxt9wwibS0oa/1vbx8kxABWe+OjPxhYEK0od1hvZJOoZqQBJsllemhGdxe3w?= =?utf-8?q?+GYCV0nbfWZbe9ZK4l+7iezkzfu8RipaYg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CMHNcXBQc1MPkcZsiOOCy6blbqy9RrlJMdk3NTdSqmNPqNtIOgEYy0wPZw+sI8B2Br8gACJ0TwsSayR01drPrDKtfVkwRqym/VqdNN9FPpsAoJS5iw2fs5NYJeJwH0wg0bmz9U1pbdF/PprU5tQCsT7HeDHQ7M3WAte9nx+G2EC6+7POJG28e+uHnqHL/mbgk1nfNmFASrR4gh2rONE5x4p/Bw5ZN1aRSZ0Jr6VEUtZEbSXd/htFrny3UFjIdb2O3AEKfc6PUuJxU1OYwhEUgkKn3b6L4edGiDiJq6m4HLRncLFmfd2uTxk3rts96jEZStUSpTmzr0Kz49gmtO9PFfuptZ2nEEx0dOYFwEBUYfSqoJEOlG5Y787NP5tEchCy/lClLizRs5OqGrin5pxF+yCVHqikpTlS8f9Pymg+yjvD7ui/k3GQkH0OVeYCLWCTAgHlgkOJ0urhz3yWnxSZtpznbsnqn+xvVR/U8Z9Nt6gpQRXAzeAD83GCVVEGoccQ7SoCKXJWr6cLMFTejFFMYAFQhcZakLIbX0ObgwfL0j1ljMQoFafmiX9tigTnOEANVSm9LP23Q0Rw7QOQvEn2I/fhPxgVCcBweL7Zm59aSjw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62543036-ef19-4a8a-7772-08dc65207d19 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 12:08:59.2739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yr7cDqjD9h91caNvIXBpfcEEtUHn2TfHnvwSMBmKtGVyFAWFKniJ6y0kb685gzjhgh1kqHsenUPBzo/wDSuSrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7197 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_12,2024-04-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404250088 X-Proofpoint-GUID: gunM0sVaBIvLJRWcubwTaTmUKLDwrwPK X-Proofpoint-ORIG-GUID: gunM0sVaBIvLJRWcubwTaTmUKLDwrwPK For CONFIG_XFS_DEBUG unset, xfs_iwalk_run_callbacks() generates the following warning for when building with W=1: fs/xfs/xfs_iwalk.c: In function ‘xfs_iwalk_run_callbacks’: fs/xfs/xfs_iwalk.c:354:42: error: variable ‘irec’ set but not used [-Werror=unused-but-set-variable] 354 | struct xfs_inobt_rec_incore *irec; | ^~~~ cc1: all warnings being treated as errors Mark irec as __maybe_unused to clear the warning. Signed-off-by: John Garry --- fs/xfs/xfs_iwalk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_iwalk.c b/fs/xfs/xfs_iwalk.c index 01b55f03a102..a92030611ff4 100644 --- a/fs/xfs/xfs_iwalk.c +++ b/fs/xfs/xfs_iwalk.c @@ -351,7 +351,7 @@ xfs_iwalk_run_callbacks( int *has_more) { struct xfs_mount *mp = iwag->mp; - struct xfs_inobt_rec_incore *irec; + struct xfs_inobt_rec_incore __maybe_unused *irec; xfs_agino_t next_agino; int error; From patchwork Thu Apr 25 12:08:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 13643270 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D43E512BEB8 for ; Thu, 25 Apr 2024 12:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714046956; cv=fail; b=gUVIkxfhYzZ97XiEFbWnFDhA71vNjoyIJLwPJvGfz/8AlYXysAt2LDEZ+mPRkEQjeWjHp6y8IgYQhh3lPXGBh0jI3ygvHpTljJn7I8cC2hxah1fKrN6TLlWOMPdlj3SAOptuK6YbNNDVrHWrjTqjPh8JspJ8DLRPxNfG1p4daY8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714046956; c=relaxed/simple; bh=iXMGZ70ztuU3bcP38BT1XMRW1i5NNSp683f8I5dRQdA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=BakPO+GlwLRVefs3lqE4RofHeJGYJgStSf3cRh/6UfH+wc5FRwJ8c9I8HZvV8CsvP+t9QgFT8re1rOofSipoPFgnhLDp5Xxp0EVuRFZTcaNgcRqdoYDyGHxi2JaQmkv+3cntxucGQlNFMOPnQ6oDT1ge338cDlM0EGeIMJ/ogrU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=oufEeh9M; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=AfOyqyJK; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="oufEeh9M"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="AfOyqyJK" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43P8wsZE019551; Thu, 25 Apr 2024 12:09:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=ZWSxq4AG5T8EyPv4Qi8kPa7W+vlkMf13MJ4uusSmwU4=; b=oufEeh9Mj3kboUJOj/y15FJ3BnTYuw/EsSfyE0No8cEQjB8/JkGyVu63nf9hmxKD79QF Ojhjp9W0LPhnJIZSWthTaAqN9Sv5mlXqrJGEMZQzb8ZeLfzAP1LuJqefXMnix0Px6JJJ hpxjNgWg8k/7vWF/FbVwvWAaVDXe6BBW0HbFPa1+z5HR49H9z8b9V4+843q/Z+8n7+R4 O14YEiYE4P55dCXhJwC43dn1napjByPjPabwHIYbslrGJHd+eeIqp87oXPUdlq5UoHUp uaPfs7GqbLlE2//KY7bek5QJ2qDww8HkGwzzBehJNBgGO0AeKQ+qygCbdkoCgVkiolSD sQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xm44f26ka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 12:09:04 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43PBVXO1001770; Thu, 25 Apr 2024 12:09:03 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xm45awk8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Apr 2024 12:09:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JsOioyFOMLpIvLCvfFj0O0VGwDTTUncN32gkUCnQS0tYhtV3wWettrqGnpe2elfGARSDFM5LnE5wbADMRYKr9L3rXs2DDKN3a4il7biICLtyMcnSAM/XgYdu3bS1e3zOa5Y9D2NMFbH5FNlDFb9XYC3DEMnUAOpHYUNfMR8ml/FuEnOEdmjN6tufmEzpVFKcIPz4gb/8RuMantMvawdiXcNhi3WdaWe1egacNUAuaV25LemHkrFre8102zJ7HsRi4iVEUua/KfNliqnazlLQHt/w3ZjqcasLlNlXlZ9MX5wGfFl+3TJCDga9izwzJ4J+dtuvWs/q8BydbtoJGdZq8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZWSxq4AG5T8EyPv4Qi8kPa7W+vlkMf13MJ4uusSmwU4=; b=K3RrkjFsOKRbWayvZ0RktZMwAbiW+cvgYUQvD3FrFvZBlYoOFoSQD23Qkr3WqdQ8YRrCPCEV8cPjUrgic2HwXN25QeWrXs37/ZwCKa/NqqV3ly13+jaRYrgJ4kTJ8DLJ1gPzDMQTiuSTqpYV9NTcU4pOrKMgJfGyILQFydq7V6VlYByT6KDht7YDfMn2qJaRI1sFSAhFYc0sZNFaYhB8ib/bM4+Yc/qZyV/Fi4MVMm7dtR+NmRz6+csRTlmelNCgWDD39rSyzk/5lm/KHHNl13RpT4KpBDcrnQwlZ/cwED2f+mNC11gXYvSTOCoxvRBSk7lc/kShqifZJJc+kqCTiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZWSxq4AG5T8EyPv4Qi8kPa7W+vlkMf13MJ4uusSmwU4=; b=AfOyqyJKU//B6Yr9fhxhWIadY6m8KoTvM+PMvqq1/cSFbXEOQNOd/NFsJHlllStYLj9+h+VjgjnaKO7XcLAnxQRLLrIAI6Hx5rfniRXw3d4DRLOepNcQF0/HZOaQaVUfx5HbEzYX16UFAXw/9Fr9BMJx03m2OY22/0TQmaEHZ1c= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by IA1PR10MB7197.namprd10.prod.outlook.com (2603:10b6:208:3f2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Thu, 25 Apr 2024 12:09:01 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%4]) with mapi id 15.20.7519.021; Thu, 25 Apr 2024 12:09:01 +0000 From: John Garry To: chandan.babu@oracle.com, djwong@kernel.org Cc: linux-xfs@vger.kernel.org, John Garry Subject: [PATCH 2/2] xfs: Clear W=1 warning in xfs_trans_unreserve_and_mod_sb(): Date: Thu, 25 Apr 2024 12:08:46 +0000 Message-Id: <20240425120846.707829-3-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240425120846.707829-1-john.g.garry@oracle.com> References: <20240425120846.707829-1-john.g.garry@oracle.com> X-ClientProxiedBy: BL0PR01CA0019.prod.exchangelabs.com (2603:10b6:208:71::32) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|IA1PR10MB7197:EE_ X-MS-Office365-Filtering-Correlation-Id: e72b7563-6f7a-4901-d73c-08dc65207e46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Oy7NAr2uJK5oMg5vkfmGH4QKsM6bVbj?= =?utf-8?q?2rzeHNkUcO4IR9gfPsBDYHNGA0pN0yP7+O8mE5Khnm84k5NjCsoMntvG/6A7RS9Gz?= =?utf-8?q?HEpjmvDhAcVXCUSkRnqLaDxZ/TYkDctVk4CCFeDn+8MCBU53Nrl+Q0xF983mbaATq?= =?utf-8?q?IbbWD9LF7+zjmtrmbHkIze/y2bT29Jsqv4Nz1iG7JwSPl/0qCr9OSKJDQZ7QRkIbN?= =?utf-8?q?wLkM1Ew0tmoMwIwb2R4iP5HyX6n9l9RXqi4BUvEqrvcOGTPb2kOnF7VufKC9CqVIv?= =?utf-8?q?WA+DwfLB+54yTcCN6VvUiWRfuuluYhudxVGJ+JrM14QL+VIvqX9KKyEuRy5g6zBEC?= =?utf-8?q?3yU/iMA/19WuEb7kmojwZjcSYbm8JlIkfrsH1//dPKSkdjhuhjJfHo5ZZQzNqtweU?= =?utf-8?q?2+8eZYq+3DAiAmawGMHb6pFwoNhYCOhI4DqcOBAMi+z2A7cw4obLcfkQ19bGSozvV?= =?utf-8?q?guMjq6+qjN+5maVzBwctYvciMK1Ve2o//QgeGdCBIpLtb1FkdvFCJPYXT08pxmW9S?= =?utf-8?q?cG2DfsOaSmwzAky0OR2rdLbnpW2NoHXIT6s+fNjhs80sCA26u1neJInj3cA2i1VnI?= =?utf-8?q?TurNHncEgNTn0nLeB8sLzUdo6MDT6hjWXk3JqPvq/4ymrOuaMnns3p19xVpmTW6wL?= =?utf-8?q?OPu0/RRm6nrXvxmMbLhTln27nXua9+wxLBkVH+hQgICOWS086uCKY3misNUA5Ufus?= =?utf-8?q?glwBihDMLRSPY4Lb84fP10+wAsMwlEpcWtz3G04HKEDS95VyBhWmk5gTmz63c+3pu?= =?utf-8?q?dhJ7sTzZ2V3lCkuPWeqxI0B2IW/9rWQbPFionz2u3tKzUFPHAGdDuuFYfQ6DFSUbR?= =?utf-8?q?Pos4ZTGwIF7nsaYWI6+pUHKvApsJI/VUN4u/fVtSp4SSI3qKYH7PJx328zaCxhghg?= =?utf-8?q?3OW0YXHNNm1PXlA/1nJnYg5vMSOgKEPGKL9Y0gP6hJQKF/w4pi0Q2y3ilJy5eA3Ij?= =?utf-8?q?zUKzGqNc8tLV39H8nolxKFB5nhlo4jm560j8IXAoOdGjF53ThWbICW7Ca3sApz9dx?= =?utf-8?q?vEQ/aie9LTseXF0XhsUq3p/5YCKB5MzlmIOebNsBrt3YKcL9Zd+x49pn94jcB2j7T?= =?utf-8?q?7/nwDL3SnjQcLRfQEZQyG1LraD5q7blLAtzpQSxiWJ3BhXMzdHQ0EH46b9CC/7hId?= =?utf-8?q?rIu3wAZTSLOSHdhm7GiCLmT2gBlnfXqTXW/quOt0ih5C6OMz8rI3ICvo5Qg9z3MBa?= =?utf-8?q?viQHjMMODPpbNhHjT5qe4vjXKYBYb4y/ZlOw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0zKGT9Wcqr9uN4f+NtS49giq6W7s?= =?utf-8?q?aMxrEqyweHdeOVMWFZALbEFTNZUtGsFR1tOLksElZGqa1OJTZm+bwW0by8O4f0Q+N?= =?utf-8?q?Lhz9g1fZDSleO+xjhTDzk125hwVPf49Tkr4M36CQrWXICGseQrpDgDCzsxJ1HVr6X?= =?utf-8?q?yAeZ1ICtngluqUGKfEr3VVg+BFSluxQLpdtyLHycWPOwvL8dd7qfEpvnaUobGtiT1?= =?utf-8?q?BF6pTACe40dV71Q6u6AtGKerqRoBznaBorA9EMTc7LwYmEqgdYK9jBsJBy+qgCJgj?= =?utf-8?q?NkJSGEvvjTVbZzKALoFm/ITyoY0tz88iaKcJA3lKLeJehHiClqs8IC/r2dTVaXMco?= =?utf-8?q?EHJm8aW6hu7YYNbxfpdthJ1fSms0PgoCdWMjiQm15NyBHOC6QtpsyKlNPbInM3yV4?= =?utf-8?q?5VwuKpaqqpSG5aLNgAaEWVk5auQ+oTCoG+7HpVFkUPgMNBmPWyZiSjpuG2Yc4X4CN?= =?utf-8?q?jpBE5x08FCYqM+QCc1BQcbupuZSAMyJGDppf00aPLGRFeY0yTSAlqqmX0c5nuBvop?= =?utf-8?q?QLhqk/p4AP81J+C6e4JOyBe3bN8z6mAl3c8sj4gR1+ptkP8/MHdgj9LqPkc7gzn8U?= =?utf-8?q?/qVrT5zQHv1BqZ0UxcZkUjdLboQNlpRRYtcX0bu0tKBk652sNx+G68pssUawp8xh+?= =?utf-8?q?dPD0ayn3betjvfw7iMgCEZLL7vNvxt+t+dQE+2ASgIvAz0SWwUHZWvf2Kkv4flH5P?= =?utf-8?q?2/Avc0i3tbJLdpAWcaZnpcAV4UduWp7V26bDLyPzfkq+30XbJy0IqCWo4EDqtwfjV?= =?utf-8?q?VIrSOTXSpz2XYYVDM+zLPsyphoSxDeNsgPZnQuZbPdMKEc/mQFjEVpPCcVvmeZ14d?= =?utf-8?q?i5wugw4+VvBae1ZElFikrlopSJesxurfaQopxENoG9Z4rz8JT1uWA9cl2q0Vr/R3I?= =?utf-8?q?zvF6H8stmeGARYyc/SHxjoQD2AGTHd5j0xbQtY4gBGyMT4n+ZF8H1McSKZXv5tQqk?= =?utf-8?q?EvFgQ44TmljTAK5E7XVEyCJWzNHgbWsAvwAMgRdvPc5fxt8lDh9P3hwi0RyEFRwDr?= =?utf-8?q?FeKjq88olQgwU0jzUSDaqcPPyIxjV/z8s/yHsEJo1sykXzZp3gIC1gv0+PUL+stDK?= =?utf-8?q?f0yt3KZ2hXij1Aq7UchtaQfYVDW9rP7PTZnbp4vsZIaMDJZDX6oaOw/TxNawK3Fut?= =?utf-8?q?g2vJ1uWj3cI+KTTODHTcuyQpjRBzok/yajVbwIwn0Sd/as/ry3OSy/WpUP7Cvcx+z?= =?utf-8?q?MknsMYjOBkkV/gzSZ871atJLgM+2ZBlTXgiYD3TxcVD2kQGVnqaNx1qWPreX0okSu?= =?utf-8?q?uBcgr5RH72udoFFV/PdgDtiW8y4oneo/Hh7r6o5ItCbtUcllSGeLQH19CGePiyptV?= =?utf-8?q?BiVfbj7e7T0P2GQMbW4Wq0cLz9/sTMTg5iglqbumM6VvWsyeAgSLBsWk50w+1uPbe?= =?utf-8?q?v0B/DKl0WOrBt63vZLHALAVjbpr+8Cfsfky8D5fexWLPmspPE/AUKKW8BItkbrVjB?= =?utf-8?q?G/8M3n5uU/4iJnGdAIy7Tvjidw6TGmgFN+OyUaXr3y84CwC1qWCg2w35xjIOW2Z3t?= =?utf-8?q?ncWH9QU5j9XzIOLXTfoPcetLXd9APE4SQQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gK2TKwficUzV3Rvrs8I4Nbk/S8f71vdm63o4Ilm2WW0SvZlptnJMoMU1wzpEoGts87okeWJDYKM7zhu8Zb2fiqWCR4sgw8eROcr/kadhsO29/eFl9Aq8F5WO+fdaghVOUNhiflxDltZpzNsWo3TWNPL2XXmwjXI5NpTPRqC4BsDf4ZPPGmZpJvlrSzlfDcAYAeXTuuEJDdtGb2pqjLkR5HGN5hx/uInXW2k/gsemPu23+Wrju6M+JJx2kwA0nJfsnj1B5nkI7qpyC6Klro1dxBFExbimmv2bpwcm/dXvgWw2hJccrv2uBpZC3UKLw8AuziqVdFxa67p53kseBSGH5Bh8aa1GzG3/TQPsANQQM0+yqHxSKrawI6ka2Y7yzNTVqXaQe78AqX/LW/8RV8tPJj2v3BGVaRg5MXkM2sq+2E1lRsTENnoKoF74OrzYQufJ8F2iDC8ou0VNkxaBtgwNrMnKy8+M7ib2+//Jdd9z+GFRFjxr865CWlIzfn4caGCESAloEArGXmHviNSvOYiSN+n474guYkJr9om6wCcdNFMwN/jFQjcRUoHV47rYdwoAQC2TvT+wr1insna+RM8Me0wmJMEoopX07iUlqN1GUjQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e72b7563-6f7a-4901-d73c-08dc65207e46 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 12:09:01.3360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8uUutKK7wpM9DABxYe0N7sqVjd0bXXZp6xcS1nPE1gQHP9kuXys63dso6QS8eHWUpCyU4Jzoo5V3veD6irCOEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7197 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-25_11,2024-04-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404250088 X-Proofpoint-ORIG-GUID: E6E110vMRzK-k_YQuuikKVqdvG6LJbiI X-Proofpoint-GUID: E6E110vMRzK-k_YQuuikKVqdvG6LJbiI For CONFIG_XFS_DEBUG unset, xfs_trans_unreserve_and_mod_sb() generates the following warning for when building with W=1: CC fs/xfs/xfs_trans.o fs/xfs/xfs_trans.c: In function ‘xfs_trans_unreserve_and_mod_sb’: fs/xfs/xfs_trans.c:601:17: error: variable ‘error’ set but not used [-Werror=unused-but-set-variable] 601 | int error; | ^~~~~ cc1: all warnings being treated as errors Mark ret as __maybe_unused to clear the warning. Signed-off-by: John Garry --- fs/xfs/xfs_trans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index 7350640059cc..46674a9b1c97 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c @@ -598,7 +598,7 @@ xfs_trans_unreserve_and_mod_sb( int64_t rtxdelta = 0; int64_t idelta = 0; int64_t ifreedelta = 0; - int error; + int __maybe_unused error; /* calculate deltas */ if (tp->t_blk_res > 0)