From patchwork Thu Apr 25 15:03:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13643468 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB5E814A4F4 for ; Thu, 25 Apr 2024 15:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057417; cv=none; b=tPN6ZGfZaBy6pDdcMlz2fc9awVPEcqE7S679kFLxoyJukp4wr67J7gj1FKSrUOQqQY8ECxEGYoQG98jm2bmL+jPgndvMCKS13HXDWwuizpGRw/saQGxq1rYTpmwdLNAz7c0oxeHClSQt4bpDOCKjs7QkuPyNp2tizB9t0c1npxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057417; c=relaxed/simple; bh=Tsa8/Wzig6FNUfuFlRIUELjsQKPsOH3Pulp9FrfGw6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nnPK+F6YTr6AFVRogf4W5evm/GUNWofhZfYfwjOcyEl5EePfEYZronmIqBVg39IOTBTY9ZJZo5WObZlieYs6g8AsrEJXBX8/9n8zBEZ75dGTqodIAaYpkAhfumafPxsZLAy2JZ9N5SU+p4WswjvNs047lGSiU6rKvrKtDzjKt+s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=SPM1uHex; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="SPM1uHex" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-23333ef4a02so682902fac.1 for ; Thu, 25 Apr 2024 08:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714057415; x=1714662215; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GHHT3V3NAkn80zT3ZwzVgbMDW8DV/51JYCXCI4YMBAU=; b=SPM1uHexnEBhOSVWka1X0eqblTuy3ykmHmW+JiwgDQaKeedbL2p/xyRAsEdVCiMygP qt6HmtQRXY8Os4U4A8d8PtKVgaBm+yU8T3hclaMV1kch4U9wb5m4/wHOcoX80JF2j+/7 fgCqiR1BdK8k7n1bBhHTnlfAAYJPiD0LhGrHX25XtA1aTgZxpppNRr2eWUmSDNu/LVmt gwaHjolmSRBPpvkyXLOZ3ObaiBDJFldQ/P3Kbf6VszGydijQr+Cad52OLjpNBKjC0ET3 KmpwnhAQwLWP9KxkK3DDq4PZmXzfjZeMm8KzMJ3QO39LlrllPrAs4tEYVHiT3hKJj6Xg de1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057415; x=1714662215; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHHT3V3NAkn80zT3ZwzVgbMDW8DV/51JYCXCI4YMBAU=; b=wLEjAmh7iJkVhCdINl/7VUZE46LUtIjpZcpUEw22MhrQh0QL3kXUlgNY/9v/RRubKI i3QSI3t9r4ZcFUmF0uJvl8Wqq/W6PsqZShOzolCFDahnu+wpCC67hIM6nKxMpTeM7Qeh /bgMzPtVyH5NFRAGPlnzOUk9sE9X/xggwogEIMqSbmlenKjtDPH53wZAX5V7waPH22yr zqIA7j1inQm/U68XfpJH00PP/F+rf7Dx3D2V0iV/jCgRB4scn9vk/agL7DWbWEBw5iIu /KoDIhidFPMhSqvQp+jYtiWDvUvb9ZgIMf8Tt4EkWyi+ufnO4V27tiyHfyaj0l5vndru MEFQ== X-Forwarded-Encrypted: i=1; AJvYcCW+OdUQLL061Ffav7U9MLuyo3OacEDlP1l5+17eo88z9avQddsY4fK6t4mHU362It7Viru9PL4I6zNsqVadv53X2/+Q X-Gm-Message-State: AOJu0YwWrTfTZfUy3P5S9U6n07dTisJyxNQLBysqMmlQIP+/VDFHqZVt yaLIgXLSQuUQC7dMreJT8bU69dnCOQgmkryhgWM/1SFMyd5tR7qkzsi8EjzYQiU= X-Google-Smtp-Source: AGHT+IGKUzbiZmA4xkuzW4Obu31RHZOeYQIUKpUb81CCZ1vyHCvuVjk+AQ/mnzT8PDS0gPeY3MKOiA== X-Received: by 2002:a05:6871:b13:b0:22e:c787:5fa2 with SMTP id fq19-20020a0568710b1300b0022ec7875fa2mr6465784oab.58.1714057414871; Thu, 25 Apr 2024 08:03:34 -0700 (PDT) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id mp2-20020a056871328200b0023b6d4723edsm166739oac.14.2024.04.25.08.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:03:34 -0700 (PDT) From: David Lechner To: Jonathan Cameron Cc: David Lechner , Lars-Peter Clausen , Michael Hennerich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] iio: adc: ad7266: don't set masklength Date: Thu, 25 Apr 2024 10:03:27 -0500 Message-ID: <20240425-b4-iio-masklength-cleanup-v1-1-d3d16318274d@baylibre.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> References: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.12.4 The masklength field is marked as [INTERN] and should not be set by drivers, so remove the assignment in the ad7266 driver. __iio_device_register() will populate this field with the correct value. Signed-off-by: David Lechner --- drivers/iio/adc/ad7266.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c index 468c2656d2be..353a97f9c086 100644 --- a/drivers/iio/adc/ad7266.c +++ b/drivers/iio/adc/ad7266.c @@ -371,7 +371,6 @@ static void ad7266_init_channels(struct iio_dev *indio_dev) indio_dev->channels = chan_info->channels; indio_dev->num_channels = chan_info->num_channels; indio_dev->available_scan_masks = chan_info->scan_masks; - indio_dev->masklength = chan_info->num_channels - 1; } static const char * const ad7266_gpio_labels[] = { From patchwork Thu Apr 25 15:03:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13643470 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54A3414A616 for ; Thu, 25 Apr 2024 15:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057418; cv=none; b=G8o66b01FWRoEHWE5XkwPCYdG1KVyImZM3cuwqMYJ5fizmO4S/ob11jmHsYhTImgCzHfGtmQQi0hcqO/VUXcdXZT8uvo7O9WYG90A0rrTDFXBd64yPSI09rEYz6M/UU2hNg3mCgeA4snCn0+zwtfdksZpy8Ji4x7wZyz+5+tPWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057418; c=relaxed/simple; bh=c0UVqkjMuNtarShlxI0bIDMYPsBOuAUJ6QeQyiAWEuY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i7J+7WOQY+2tdd1YWOSzNE4ec0CDpoAFxPQ83ztNVyLTTMrB+cGaw/vHzSqMIc954DlPg+R8/KQ+IFB9XfBT47vVy1TXU6dsuv5x6L7qI58mcYkBlBJGKPDmizK10hK484B/FOK5MckpEPTY0MtvNd1GMzQlxs80sAv0TrcpQ08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Xz/BHl4p; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Xz/BHl4p" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2390335b67cso355549fac.0 for ; Thu, 25 Apr 2024 08:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714057416; x=1714662216; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FuUgN+eqDnD1TSwHoUcLirGapuP4idukeuGNZ2DNfLI=; b=Xz/BHl4puv74JoTQXRE4A5mi2fAv9wAR/WXhblrI9t6cWmM+C9TDqykcWrDhO6gQp0 IGv+iqMnznDDqZclmgpVhHjEQcQObkwGPS69KiFvuRjhnizcgkidmlQywBr+pVjaw2YP 0AD6wmZ8NdWewmNjFG+gVPdoIY0RtG0IWgERi1IpZDnKnz8GPs9sXUl8CXcjgq7C+U6+ WjrsM1qrhVM31LHZq5CWu8cudPmAg+4Ze4frAqnv1aV00RpsAQ9ENvrJADkw/qGiJaKP lS6RxCSaTIgp0j6ukGv0Hb/rVq9wCVMLH/VKywRN5COXX9GaS/yScXXuVKK8Eo2Nrs5W 8NAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057416; x=1714662216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FuUgN+eqDnD1TSwHoUcLirGapuP4idukeuGNZ2DNfLI=; b=Gjd3gElFqm5roPZkmoAIwGbQFowyVxeOQsj6H8LZDWSQX70HgMTx3F/+PF0xcHy+Yg HVQ1hzCZk/L9TzCkpHiNtph4od+EIv44K1r4SKaq0VIFqQ/57J/QHtb5I8bhYUeunRWq IjwFOkHWbk7UI/ndVwJNNWbyz+aqURnMBKpXX4mHcjo7itxFg9LisiqPhelKdfLyKcnC p3l24MP0coq8qlLmKiw2o5OxwywWn4iZlgaAh8+p+vKVYQGoU9NYsp6JroU1SjDZPavn Z3sDsPIXgCaUf4eAzCMSnleijL0TYGuYACuSDsPaesa8H8v5LPB+3U8GavjsGHB29/uU DduQ== X-Forwarded-Encrypted: i=1; AJvYcCU3WcZbUz0kH0ok/YEBVoRfBWCcsbFMws5ij5M99M3vZ7nepwxJj8LcBvMc+M+PwnUfPosz4sijPJ5QjQz5s8eBnL4D X-Gm-Message-State: AOJu0YxjKVHC1gM/jYfmEiceTf499mG9vyJqO0O9Hc5IMM9cJLOFAxfP hkDGFxE8LpgjdDE1putdfwUUapxODxyTwwUP+c4TOB1b+6G+cjDxfDMTKeWrJqM= X-Google-Smtp-Source: AGHT+IFvAtaidOO7h0zkTLuuS0Zuix9lqDgu9+DKxThfm0jLTYtjgYSEE2bX05vg7lHkXPUfguF9Bw== X-Received: by 2002:a05:6870:9f86:b0:22e:de21:e084 with SMTP id xm6-20020a0568709f8600b0022ede21e084mr7083274oab.9.1714057415874; Thu, 25 Apr 2024 08:03:35 -0700 (PDT) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id mp2-20020a056871328200b0023b6d4723edsm166739oac.14.2024.04.25.08.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:03:35 -0700 (PDT) From: David Lechner To: Jonathan Cameron Cc: David Lechner , Lars-Peter Clausen , Michael Hennerich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] iio: adc: mxs-lradc-adc: don't set masklength Date: Thu, 25 Apr 2024 10:03:28 -0500 Message-ID: <20240425-b4-iio-masklength-cleanup-v1-2-d3d16318274d@baylibre.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> References: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.12.4 The masklength field is marked as [INTERN] and should not be set by drivers, so remove the assignment in the mxs-lradc-adc driver. __iio_device_register() will populate this field with the correct value. Signed-off-by: David Lechner --- drivers/iio/adc/mxs-lradc-adc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c index 2e60c10ee4ff..8c7b64e78dbb 100644 --- a/drivers/iio/adc/mxs-lradc-adc.c +++ b/drivers/iio/adc/mxs-lradc-adc.c @@ -724,7 +724,6 @@ static int mxs_lradc_adc_probe(struct platform_device *pdev) iio->dev.of_node = dev->parent->of_node; iio->info = &mxs_lradc_adc_iio_info; iio->modes = INDIO_DIRECT_MODE; - iio->masklength = LRADC_MAX_TOTAL_CHANS; if (lradc->soc == IMX23_LRADC) { iio->channels = mx23_lradc_chan_spec; From patchwork Thu Apr 25 15:03:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13643471 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90367149DFA for ; Thu, 25 Apr 2024 15:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; cv=none; b=U+TfwVygC8LV9czXRDpY114T5XtRapOrXaMgIvXXCOPPtOymSnZLW8vP1ko6QBw46FNMbikzQTll6sMfNmxbGLmTj7cHahFJlBY8dCxrfaGIY/2QCFtfcg3EKpZcBg26BcLWkOiu3j/42llXjpkLS1mBiHMxgh38HwwnBhKXYiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714057419; c=relaxed/simple; bh=InEifnlaJ03rA8QgNLlhw6s+Q05Y2oXvccfChwmxIgw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Olmdw8aJM1qwwpgK8LGNWHzaSoMzMhoFrbVzF1sFvbCDpfNKh+81MW/uaZ24BpZlffVLF+ar1E9o7ZjMUmzNCrmUqouM27nipdQmW1q3vHDsd4QyQ4zD4og8hx3LyZiEwSgCYbyBFmp/S9lyjwzJ4lvxGQq98+ar6mpIoHvZbMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Bina+rE8; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Bina+rE8" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-2228c4c5ac3so602517fac.0 for ; Thu, 25 Apr 2024 08:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714057417; x=1714662217; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ALDEBHn1/H2TDQekY233nOtWpDkhb+DBBbFG5htxIm8=; b=Bina+rE8IujWxbW6a33YOVCaEyftmIcUG/3gbdd6Z50gRbo3Q4spnYFnL/otVhyMhA SDUdbmwVp4aUwjQoIob+Hf+tZ7udSTQnLJiFcih+nvJ1XPURiZAk0W8u0Bkq8gqONbbh TFcUwRiUFH5Q0ZPG4VG7xzN1Cy1h8UsNqZPj2EqsOQ442FEmuZNoBIJA7CBnXm7avHxl ePXHXCetH7Ob5mbCAJSND4fdwtnyaeTpKig6DWHMNtDsFqZMMr5O30uQrv2m+gGeI72f CptFj1ZHCUx1gk0AYQWFz/Fm/W1Ce2MRZglGaHudOBNAUFMTdhZ6joXexuaepn8RBuOG SJoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057417; x=1714662217; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ALDEBHn1/H2TDQekY233nOtWpDkhb+DBBbFG5htxIm8=; b=LIH5si83Z2x74pSZ7TmKAsZI90IGwgohE3XflbTTUKc5IRMea2OlC5Fems6gptxfC6 VCajsniE2yeME5u5t7BCy1FCvUQ+wEMDr3TO0U5C2URlgkCLZah5NMRmhVPPAnigm+4v U9Hv+CmTBLl5g5mUYakeSW0E7u9+YTHF1zrCSmlzu9Zr9a62JCXQGdYrJb/zPA4oMkJT pYSvlEZjPRgNy5GbVf/V1PfoexVjqKqQPDykQWGY//TnXM70PwkZgwIfeCACq6uGoEQ0 Bv5vRzqvMufAztRNO566gR9FhOig8cKz77glnEMC+pBGLlLkQqHqGPonRbZnpU8AULKL 0vLA== X-Forwarded-Encrypted: i=1; AJvYcCWaKOklRWggiF4SC/XdsIm5fGkz3aFOBGmejZXMWpxazCiHK7s+kTPQurQCllunTmB6TUeqeezns2wrJo6YaRn/FYh8 X-Gm-Message-State: AOJu0YzyCmXm3OpeEk2ighwsljr3/5MF33/1i4vxIE2LIfT6/KI6zVpZ C3zwmmDlP1OBN7H9wXfJ5UmZA9oeuH5zdBb4bFsEqSU4jV09zHfrf29K/7T6wLg= X-Google-Smtp-Source: AGHT+IF+ytB1gMG5gdlzfQf5qI8kdu3jxsrVIZyaQCoI1mcDdWPMWQNB0NwCuMDh4O5EGMwTLzBV2A== X-Received: by 2002:a05:6870:c394:b0:23b:8a59:f5b4 with SMTP id g20-20020a056870c39400b0023b8a59f5b4mr702248oao.2.1714057416777; Thu, 25 Apr 2024 08:03:36 -0700 (PDT) Received: from freyr.lechnology.com (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id mp2-20020a056871328200b0023b6d4723edsm166739oac.14.2024.04.25.08.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:03:36 -0700 (PDT) From: David Lechner To: Jonathan Cameron Cc: David Lechner , Lars-Peter Clausen , Michael Hennerich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] iio: buffer: initialize masklength accumulator to 0 Date: Thu, 25 Apr 2024 10:03:29 -0500 Message-ID: <20240425-b4-iio-masklength-cleanup-v1-3-d3d16318274d@baylibre.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> References: <20240425-b4-iio-masklength-cleanup-v1-0-d3d16318274d@baylibre.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.12.4 Since masklength is marked as [INTERN], no drivers should assign it and the value will always be 0. Therefore, the local ml accumulator variable in iio_buffers_alloc_sysfs_and_mask() will always start out as 0. This changes the code to explicitly set ml to 0 to make it clear that drivers should not be trying to override the masklength field. Signed-off-by: David Lechner --- drivers/iio/industrialio-buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c index 1d950a3e153b..cec58a604d73 100644 --- a/drivers/iio/industrialio-buffer.c +++ b/drivers/iio/industrialio-buffer.c @@ -1744,7 +1744,7 @@ int iio_buffers_alloc_sysfs_and_mask(struct iio_dev *indio_dev) channels = indio_dev->channels; if (channels) { - int ml = indio_dev->masklength; + int ml = 0; for (i = 0; i < indio_dev->num_channels; i++) ml = max(ml, channels[i].scan_index + 1);