From patchwork Thu Apr 25 16:58:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13643570 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 413F9C10F15 for ; Thu, 25 Apr 2024 16:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/IEJQD8eYKI4BqWiaw1PIylmSG013BumCv3ChbhB5eQ=; b=y29wqUtd+BF8Hh R/xh63XvXMr152q/za40on9hDYZOMnkHYO6di7XYoRsiFO4ZKXl4GYeerKS8L00ckhJJylgMx5C/e uGVweW/sCfQ2Q3hwLMQjNsffeLwyLlSutA03NPvo/oquhU0ImFWkdVPiGbXC6QIrIZhxWUQt2zpo7 Nt7O8OIRG39CC8xkrLxzcJX5ZdwXbIgssCVacY4jMCASGsSQSgdu8zLcynbrfERJm+u/Ycd+40LQ+ 7xs1K9wjKTmW2j7HCdcEFquS9+rvR4Tp/uILphj5Zbo4O8u6x0nYZbfESA9nj4D68rYtnAujbgfBc Y20kkNQFFwMbP7b/mW2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02Rj-00000009TyI-31UN; Thu, 25 Apr 2024 16:59:43 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02RN-00000009ToR-0pq6 for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 16:59:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714064354; x=1714669154; i=wahrenst@gmx.net; bh=h7WL1l3kzh5o9Rl4X2yF/GPxgKaU9BKPZn/MU+snOYU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=IC/BsgY9KWEsdM5qNz7NE1GeJ3uSMJluicQJFzKQd9n4434yEJBA+P6ZNJWh4Evn awrJyjS1uKyfyQqBgHnKjmD8UsOVonIUtkqVDsvAJkcD6EHSvDL+hG3n4nlYpB6la S2i4iWn8Iqy8SIErt+RpJnzk+lPwmAfsTPuFAX2aEHCqWREetJQdX9ywsPrj16o/U TQ9L2UnrKdMakSAUcWJMe/2ETNs2mbsUgfn6si0SzKwkiZFcbjw/X0+rNcpC34J1T JANr+nXrdkI9xj8Y0SbHp0UnYRFJCKZiRa3V2TtS8m1i3D8Y1KHeAcpJgUxqGzMES zKNiPovNf4K7lSA5TQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3se2-1si04g21nE-011YR4; Thu, 25 Apr 2024 18:59:14 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren , kernel test robot Subject: [PATCH V2 1/5] staging: vchiq_arm: Drop unnecessary NULL check Date: Thu, 25 Apr 2024 18:58:48 +0200 Message-Id: <20240425165852.6681-2-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240425165852.6681-1-wahrenst@gmx.net> References: <20240425165852.6681-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:KiUUZ5NMFofHqLqChs85AYuddbYy1L3UO5tmdxsBl6/R+c+Pz8i lsZ+8MbLWCvshmxhtfneJh/36wpDWezhAj3Epb1nk6FJHRz4zw6Dnsg/BLDXMnJ2chNG7nH N9ZNliiu9hOmY0AG/ekl72gs6bA+oLzHQ8GEH1QJm1bEEjymc4CWPcK8ASmQhILeqArhAi7 xfYAJtvFW6WEdzgp+kV8Q== UI-OutboundReport: notjunk:1;M01:P0:Kf2NzxddZa8=;83rBTtOAcEo5uJKhI4e3Zose7kn tR+0Wh4T9/Da4F6CdboeuSwKdoLAO1jz3UWaVG3v4OW9K21+yVOzWXTsjNd613bv10Jt1S5cm J6z8U8C7JUMK40aepxAmt2cvEwTv+d/EAbW0cfRWxpiMVQ/UodY0qftrNHZjgca0QaxXBWcTJ v1eTe96Ehpr8h8XXc4LDQ/0GUvgX1ZWUDiExqPGpYGMaRuCcc79Xb0k3WNo29qYQxaw/Wh9v6 mNHf3qjsmuAw/hd98XHg+kInIf46BumAIkMhAEty4XeV0qGlWnO8SGPCLIDt/cRypYZ0/30ke jMVShTJsgZj/J/oGdg0j51NFm5S5OzBqg+lwlVhC5eRGmjnZppdYVufAZP9hdfg4nr+WRKprV qRQG+w2z5iS/dr7coYwoWoWOfE4Cp/ARTjVB2LX+pGZyyg0vMQA33vaEzzhVGzlYu8NYMHuDN +72rCWfxgfd1jLyVgexPFMO7Vw0NWCUlEu1GfRWyL5HxVNQw65b9Ji5XukU2nqZFjlHJwIc+K Bhk7A45XQdYJMMbvW8U6e0aMOmlmp9zHGGt5+u7g9CwSZYnmAfbwockWfUO/t2hnpMu5BJ9sz fU9BN4ykgV2cYA4plANJFLREev26L5nKUVOMQvadHiw/vy6d2FBxakcbEbiy6y3SrCQguwf6U B0lW+MwCB/1mpfE8EXTcwLU2+D86XUkOSk8O+JbciLraR69ysJQdVfU5Bg6kHx0E3Brh5B9G5 KqWF5jLB/jKlUOncDaMAp36fY+sXEU8pvCf8tbtHKNCPNNgkAS+KXK5cXCjbslTZf7BiWWn68 JRR+cEdFZsDOdnXmXpOlULSyCNodXw0dmow+jnN9uGDBg= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_095921_570475_F71F588D X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Looking at the handling of service instance within the VCHIQ driver shows that it's not possible that service_callback is called with instance is a NULL pointer. So drop the unnecessary NULL check and fix: vchiq_arm.c:1109 service_callback() warn: variable dereferenced before check 'instance' (see line 1091) Reported-by: kernel test robot Closes: https://lore.kernel.org/linux-arm-kernel/202404230315.vx7ESZ3r-lkp@intel.com/ Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index c06232fcb0fb..297af1d80b12 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -1106,7 +1106,7 @@ service_callback(struct vchiq_instance *instance, enum vchiq_reason reason, user_service = (struct user_service *)service->base.userdata; - if (!instance || instance->closing) { + if (instance->closing) { rcu_read_unlock(); return 0; } From patchwork Thu Apr 25 16:58:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13643572 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 878ECC19F4E for ; Thu, 25 Apr 2024 16:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OubbxwNhDibWZzCfKeXDQjqMQ9K0xoGl30Zp4acWcyM=; b=gzUiqfo+anBcIt 0MnoOHLIkrQKngazVNseTq/AJEo38YEc5smJmPcljDIIX5wUwobbak+GJRwAy35qWuOnEbefnV05s v0dIr8OV8GubJUGCd7WwqdBkDcLURSGChMtU2OR0jouLdceI6M65x39zyl2ugcjmNnhoNNDBDjxA9 stc/Wy7IaZny6W0L3in33xio8Q9Kd0pi5tfJqoRwO/Dpw1Gm5/J7aYzuzH4ZHDeI2xuzVe/u+/GdD nN9kQH08o8s8xmx9NuuxiD9LUyGtRwz8IPjY0kTaBvkg1s6TJJqFzVkOYsOLTbn2PZ6yEp0pBhnH8 B6HfXDZ7sgQ8OLHaqY+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02Rm-00000009TzL-0D3h; Thu, 25 Apr 2024 16:59:46 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02RO-00000009ToD-0UxE for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 16:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714064355; x=1714669155; i=wahrenst@gmx.net; bh=qxbEz+OYjkfKXFV1gUswI7ZceQqaUjKdCgHNV4HXajg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=DaQj8fgkNmsbDFD7MMBtLJzeP6jCOpYZTjWj7/hfcA3odkSRvfBeTmL6V4OCOf/T 4Scv4++nX72hABDyBmkQiGplBFPc9I/eF5vgGFHLaZyermHBQww+ocOfwifSP1+lT NzcIF+rNtIVGeUvQxPCM5j+JOI3grtpsyo2wE95h4F1hRj667yBkVXqwRzhl07k5q mYT5T6NP1i1OAoeFu7Om1W0f0Gi2Ets4+nmhet65ao2FBAVVeG8BYuZ9gZJxnVTsx +zqy4hFVlnLqDh0yzJO20m7k7Uz119s4ebvfyi0CSNyq5B9eUKq6YEoXG5fhgmLtM qGkFv6XhwRLbzzrjfg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNKhs-1sJMVs3k30-00PjqW; Thu, 25 Apr 2024 18:59:14 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 2/5] staging: vchiq_core: Use printk messages for devices Date: Thu, 25 Apr 2024 18:58:49 +0200 Message-Id: <20240425165852.6681-3-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240425165852.6681-1-wahrenst@gmx.net> References: <20240425165852.6681-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:cd7rHLvt5pHpDdQEbBWy4OYx1oqQcqVOfqkrjV4LM7ueZm1902V dvXGoedOggvt3H6ezl47JIY2mGwRnWXjIiGPWrE5oWXw+xJdrIY8JMw4FbPxzsamiCjWqvA PDDgD3WK5WvDVfgUPAeEZFJW7gvidgZsP4bDBEf10b/TAsZo3h0+UGP2+obdpoi6NrpeWP+ Cot2BuofRNMp7o5X3HC0w== UI-OutboundReport: notjunk:1;M01:P0:ZI1hX3BJO34=;5f0rW5JSHuGRdOKUhyOzyajOZEs PVHVzO+w4lp2bh2ByURnO+NaXIEeMUrofBc0sBwAsg93jAdnVPdkUIkGuPYtM8na1pGgmW9JV 7OMQ2Y6FPzbzaTGnDq30NaETAzxRsd7wHWGmbObomw/YOj8hh5OMXdaHaWhngnqoWwj8ke+f5 EFp6HS/WRieLyZTVuftB91k8wv9xhLiPziWvq1v1/v/JmGTbXQLL3v1GV+Wd2AcyV8QEOyWf+ fUnyuL1s8XvTfGTMGpjw5dGZFQI45XifjFizdJfkpYvlAYZzoIm040SMM76QC35Jdbz4cQLiQ k+NBMNSIdxD5V3NYJ1dLKqDE8kYPYdqeSAWQDwL/XmlL6+LrMavKkSQN5j5/mBlT4PhdJV12n oChMh1QQleaWA8PczX5QUJlWTVnGZDe1Eh+dwmIV+b+2asFi1j4nG+2R1zT0beUcwcOlrOwEN PbZKbkK6ZpGsuDFpiOlVl/CAmT1Jo/pKq9KlFNQbIpSkw+XN2QO5+hrGxPiy0rYjHi+OQ7gWN PE0UWHDI1w3boBI7nObJ93uohIeFVJeAEFqeWrfNCxV9EFep01pfwS70I0UqztOpnzJnxd+bp 2+IuqfX/eLYAolYJ/laIubzC/cJTgPGV3fa8H4K5Hj9gse63jpnt/rNrqBhWZSxx7617TDm9u XOba7IZbN4qLD0VTF8/QU90FUYhoAwIwfRM58EOUYGgvphuuk11OpTymKk3QYs2stsWuPtbj4 uhbvCrXSvu/Xjm7v6y/jeYXZIJh5LatJcX+OvT8Z4zqNAHFz9LxqfDScJmp1Z/W6otACLenx5 eQ00S+xA0Wjh4g+Y5ejV0kYeFCKfQ8yVPrOd+LTe8080Y= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_095922_538127_FBFE6032 X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Now that struct vchiq_state has a device reference, we can convert the remaining printk message helpers. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 3397365e551e..129d73fec2bf 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -697,7 +697,8 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking) if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) { complete(&state->slot_available_event); - pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos); + dev_warn(state->dev, "%s: invalid tx_pos: %d\n", + __func__, tx_pos); return NULL; } @@ -1732,10 +1733,9 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) break; } if (queue->process != queue->remote_insert) { - pr_err("%s: p %x != ri %x\n", - __func__, - queue->process, - queue->remote_insert); + dev_err(state->dev, "%s: p %x != ri %x\n", + __func__, queue->process, + queue->remote_insert); mutex_unlock(&service->bulk_mutex); goto bail_not_ready; } From patchwork Thu Apr 25 16:58:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13643571 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47FE6C4345F for ; Thu, 25 Apr 2024 16:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mm9EKXRFmWNz8XmVeez10SsYBXqQE+rt1CIUrn2Xbzw=; b=UG2Ykxd9OeBOWX Ee0C9CMw8r70tZM7npnjD9tAhTGt/RmMieMnOba5JSL0/IKcbx9Y42c6nFo7WEuM3UN7xMULDQLeJ 9BkCVIaeYumm5T7HVg2w1XGWTb1VQoP42seVOEMF7i8pmU1Lx+SuuawhijnwRC5/ZW5wVkOkG7htI n1N21MiXse6kZJXc+ppwK0aqs99vcRu8qRGn/MXk+gXIBkyx2T8sOGvwZh7n/V9D0HZZsvEDwVR82 x1WGaagTYx3tYT/LOJu2YQi4CSg8wwKVSEyWSUDpfqEBmGd3bddhVG1yBo+vaut4cYeGMwLcbyWV8 jdHQErCP2tsIcxCNLxeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02Ro-00000009U0F-0TXN; Thu, 25 Apr 2024 16:59:48 +0000 Received: from mout.gmx.net ([212.227.15.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02RO-00000009ToI-1Bxn for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 16:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714064355; x=1714669155; i=wahrenst@gmx.net; bh=wPypIIQTokbo4EjM6YVsR7tSk2WsbqJ0JopVFbdtfEc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=Nhhu7SWfZQBYDq7s9vyY1wVX5ZeCH+aCghLvy2Gzfz4O2hjCGylkiU5WwtY7cSgN vQJxFN4GC32J9DbtVelL1UYZrA4Mp7kjnw/WzdaJzw/CQri0wbxRZLWlMm0okC0Pz y/QpBkHDI5x2dESiF4kxpGZvTf7v9WyOcU1mqEHukxUSpGHKnBWIW00JMH+KJL9Pe sgEn7skQW+0xuIlx8f/FV4alCV8h51wRwDNB1LB+eygN43o1p8NEP8F00Bh2zfptd 6p6rXfCYvYRr20WLLbDsl3c1HoaatVBpSzHoZGwe53ewnyJWb57hAIZKgC13Sf1Du Qfxh1vzmD275rGbeBA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mr9Bk-1sVImb0p3m-00mnX6; Thu, 25 Apr 2024 18:59:15 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 3/5] staging: vchiq_core: Add parentheses to VCHIQ_MSG_SRCPORT Date: Thu, 25 Apr 2024 18:58:50 +0200 Message-Id: <20240425165852.6681-4-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240425165852.6681-1-wahrenst@gmx.net> References: <20240425165852.6681-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:oY5UNS83PsUXx5/TDMB16nrcmlHYSAjojirgi4e3inJkU1bQEAg 5nqS80rj7SvicOQQlNv1kF8LnDtsd3/R3Nw3K6KC+iAy+nMJtlQfBzK4tfTGq61uTAeJgP3 sgXz+4zIU5T7dMO6tL49z3KS1Yf5oRZ5xFb3weG19XlFgtIiTenDEl0DlIwvGa4Sc6p9Mba FohIoHB0DPbs8EvqIQlww== UI-OutboundReport: notjunk:1;M01:P0:kjHtP95uzF0=;Wv2JQC4KtR6rfUa5iTBJk4ofXt+ WkwAEecJK+VhEPR6oOFXAh7tBegI1aPG66zxehOkc+yJvmvd8SDHSSgtnMn9Vwig8v8Iu/BRN tpERlKNOKQIsJTGOP6OqJA7S3TzrlCp9SkRxnyfnszJWmmlBovcqCebOS3RyeMq9cjrFC5cXA f55QOphoB4ykXVPUM8GD4mq/pX+7A+qpKVnP0xPD5QDq1Yag6msWgeA7a6jw5uQVBIoZUPah6 9g36XvgYx0uhGYboHzLEAFfSJj5rmqgu1ND/Am9GCp9pobhMSwt36zuEMqgQZi9nX9deuA66d GuSdG6CHSbEZaad0dNO9T1iW927KfFCtDHxuEnBDkE7SZsfzC+0Qwt+AgO76ISI8AnitLLSj7 QeCYfWEUPeWyVDKmtDOGPZ8Yd2c5zW9Z97DVFTKGK8LZJ41cAVT/Lawdt+sn/CbSBAaBvngpE CyWsh086Esrtylhfa/fv8oyRul947OYHhQQBs/fP0499+T3Nzg3fgyX9sW76CGgnzEt9hyZd3 OcwP4imab+Abi2IJtw4bspr6KcaRMJc0WEDtnHtjYvZe/CDcYGhL+Y6ZK5qAwBOzk1a2FZycj 7Mf6bTBEotXuoMKlcW+csl1cljmINEoL3mguFZMD1ZjPFUItWWo/G7NsQUxJSeDyMhgmiGC6/ 9hWiVtWtrLASzoxm841M0MIot0cqDmsoEuhd9A6TJgD0NW/fZpZRmHFhOcmlei72jdEtviTNM fGMpA8JZDwQRucCNLxTgACPvcvB74xJcuQmzQo7af7DZmz6jBzd/d8dyN7N++dc4u8czgBq0z mFd09K0GlUWDq6EebO2VGI+f+YmsmJe7IBbum5mmuJor8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_095922_724919_5B1116F9 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org checkpatch.pl complains ERROR: Macros with complex values should be enclosed in parentheses +#define VCHIQ_MSG_SRCPORT(msgid) \ + (unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff) Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 129d73fec2bf..58451ee08abc 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -43,7 +43,7 @@ (((type) << TYPE_SHIFT) | ((srcport) << 12) | ((dstport) << 0)) #define VCHIQ_MSG_TYPE(msgid) ((unsigned int)(msgid) >> TYPE_SHIFT) #define VCHIQ_MSG_SRCPORT(msgid) \ - (unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff) + ((unsigned short)(((unsigned int)(msgid) >> 12) & 0xfff)) #define VCHIQ_MSG_DSTPORT(msgid) \ ((unsigned short)(msgid) & 0xfff) From patchwork Thu Apr 25 16:58:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13643568 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EA37C4345F for ; Thu, 25 Apr 2024 16:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m+HxcL5SCKHLy5q+0Xr47ruqzph7iAtDe3OYi/4hTCI=; b=YbKFT5HOD6+iq2 z8ekcoZOhytTQGmVNhR57ulD22EVCFbkuBkk/gEmPL2Dcm+jxfLFvbxND9SQD/HG+LA0X+zNYs1Ww 0dgb/bhT8wihLR29BJYRRsoNgQCjewNnk6nuqFmKOOpRh9BwuiGUrhFNVVubnRFTQRnGN8jKURUD/ 7Wm6TGfi3ovgzmgUkcRFPiFs8rfKdU8B0VqswFT5B9q3we3GB1nxmy+klpwdtpJeUi/w84PKv16vz J8/L+G3Jxlj5e7Ben7ZDuGytMjGQ5JcDnc+E7T+CxaJomRb698appUCaRPU4Kbo5rLK6ZAchY8zPi LrrQP92F3EulQkXqBilw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02RP-00000009Tqi-1zmt; Thu, 25 Apr 2024 16:59:23 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02RM-00000009ToJ-3BuP for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 16:59:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714064355; x=1714669155; i=wahrenst@gmx.net; bh=za0lJFAEFEu+cMcc9yHS8hoYGNCjR3OLjeYClJuw8rk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=eSUAkGcm5W84kQ67+of5QhN+QTS4WiL8vNDowhTAb58k6z2HoCVIUN/v4IoVP5VK j1NH+pnsu3wvTybn3aa+orrIRvWtUvSM8GRdN55J+JTyY5MXSvaALREQxQA3f9ASZ ULNg9Y+9h/Dq3zGFYmle1MicrLbqI0BHjtdma8oydvq5T5QFayX9cac548rdlP7JZ xFOg8U6MXDxJwc2yqplixEOwmh64KYnSP3a58kqd6ufDDEtOSbTG/Azg1BRIXK/+0 P7ZIjIgfcjo8zuRD/wzajWda7lEta0a9tona76RLa3yMwOGyPgoIjXvinuagb+5yD zwoFMR+iYg7k3L0GuA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvK4Z-1sr2V01wvJ-00sRlX; Thu, 25 Apr 2024 18:59:15 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 4/5] staging: vchiq_core: Drop unnecessary blank lines Date: Thu, 25 Apr 2024 18:58:51 +0200 Message-Id: <20240425165852.6681-5-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240425165852.6681-1-wahrenst@gmx.net> References: <20240425165852.6681-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:R2zJddKy9tKReoZwWYeSSaEfZ/0hze3wV0CJZT97g80bjq9F2QY 0iW1W0k21YhkOMFlPKK32gIAYD6Bb4+U01QppAw9qMhon/MYZL69AD4M0io7Z3l14mxOX9Y qFl76++ZydjL0zFRjGITcpeV1hcdYUpMajmG0H/iFTAksunbmn1i5XPf6k23X/liPXG0tRG OOzBBb/X8bX9zXtnkeWbw== UI-OutboundReport: notjunk:1;M01:P0:gaCvF27H48k=;og+93i9Qn5Kn0WWZdqcvAWJPtVP JTfiKmNr9LMNLQwqJ5dWwF2w+gnGJCoEDL4tAbvEmbFuRPzUMV1Z0PACVQqegYk/shm34YSTT amFahc1i6O/0hJomShVtCSAKUHLKihgKh8tWBpQ82SewKT809fuU8JeQxNDHWS33dQNobAMj1 pYvg8MAlCRi/Dy9pIHy3hNJ2UAztPb/dallLlY+zC2NYfuADRoH9anrkIXGkcwDSfbRpFHPfw yZUeLWNE9VXGPeIOhVZCWlwAgIFh6J5wkJs7jrhWyBVAPfeiACnU870M3yc+Rr3tgNH3JWTzw 4+0T51sQ6l3AJjTM+1txGJ8rhApK62pnwGjBX3Br/DP9odzhPsArf7LPDgdg2yJa2fxzWps+9 fgB2iOa+S9TB52RP2fBAUSk/ioQpNWvwsimfsSCnMIdOzEF2TSvrCKNvySndYRpfy6b0IlMKu 21AhVxHyA9ogrNWSHGETOK9+Pg/CJEwmJgMCSaQySF5uPVTFNmrma56/aiS5vRt8b3ajCi330 S06L1cZAbGIZ6FF959jvhAnVBCgvZWtMBSvfJnoqaTqbRXLdTfcrjVKdz1b/Rbiy3MTP7s2z5 z9p9g/MJAztk1Jp0lj+EmT1PcRDnp3fK6pXphv4RC6QWmg3XeQ6gle6ouVSRnfFq6019DEfEt oT3lCDV5ceiRREUj+k7DfiqNpbpXApAoMzVLAfUULcLuqAvWuFindc9FnY8xwgvhU4Zp55oNg lt8H93F09JS5u8E2TaiM3T+Ghy+aJQZbrM+R6MnCwsd8ypRbyDMP8xN6DOvzxJ0B1ZfgKntWd TGVKDi1g5H7nZYUKLFUZkgYEkp7Ctdf72Gy6O3jOOyOPA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_095921_162130_E85E9C5E X-CRM114-Status: UNSURE ( 8.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org checkpatch.pl noticed CHECK: Please don't use multiple blank lines So drop them. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 -- 1 file changed, 2 deletions(-) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 58451ee08abc..ca32902afe06 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -1190,7 +1190,6 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service, header->size = size; header->msgid = msgid; - svc_fourcc = service ? service->base.fourcc : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); @@ -1616,7 +1615,6 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) break; } - svc_fourcc = service ? service->base.fourcc : VCHIQ_MAKE_FOURCC('?', '?', '?', '?'); From patchwork Thu Apr 25 16:58:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 13643569 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71D55C4345F for ; Thu, 25 Apr 2024 16:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y9eTliXBxaPBP0htSnAcDKf5pgWwSefDr6eS3sYhKpQ=; b=2Qg+rFukkwuBX9 fRn79wjN8FhYpWDfJEwTjv4APLj4myNtFDkcBDANommNnXGpZxwstyjqe9wlakpXhlUSD/78iAIOZ 5uU3ydvE8VUlZWellf70584zkTRq+HYZYC6/KlUAPGZbb15yVQjuQVqeZhNw5kOYoo8ZqrrZ2iFLY /DdkPeK4M2zvWZA5I4Xc7LLQa4kmqPsrdDVjEWfEqAaBS/XpRcP88jtjW94FCcjeY5L1mQod2MwNo FTRyR1hnagVRaYIfFSmw0ID8rqL8UuPzaVjUG4q/2ezeh7myEBJ8K6mp6WcHfIsCXaZ6AB02P3eIo YXAIJuLeMdRZXhnIoV+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02Rk-00000009Tyj-2VdM; Thu, 25 Apr 2024 16:59:44 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s02RO-00000009ToL-0QH5 for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 16:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1714064356; x=1714669156; i=wahrenst@gmx.net; bh=CNQeXx88+PWs4m7o5y0Jq0wLFvN1UeH9xseza45YiAE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-Id:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=coA+a2cr1eeN/EKaUndygwblIprNpeT7DtXjuWdHbGJyVKiEwQnFNkQKJtkbg538 CuM39PRB67+9hL7cBPaZf2I+F4LApF8JH9bjKbnIheBD1wCkvyN8AszcPlsVXCfsd gp4jE0yvArpFdLyu4jqaGXOb8Qla54bFA1/XOCh9qJZ8h3IQW1+KeXFLXTCN/PI7l EFQ0D7MafY7yopLTfA+nNc01yF3i2XWxJ2H0MSmzY5Dv78h1Ck8emJXu2HlYQj9W2 v5rU0e1IaD3NLRxxTvLUz3gGxxDqVJWISXTFCLFVkfwoEQv742eg6m2tfFO94CC9Q +RTi98l5bZjwupqAoA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from stefanw-SCHENKER ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MMobO-1sIoHH3A0q-00IZ7C; Thu, 25 Apr 2024 18:59:15 +0200 From: Stefan Wahren To: Greg Kroah-Hartman , Florian Fainelli Cc: Umang Jain , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH V2 5/5] staging: vchiq_core: Add missing blank lines Date: Thu, 25 Apr 2024 18:58:52 +0200 Message-Id: <20240425165852.6681-6-wahrenst@gmx.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240425165852.6681-1-wahrenst@gmx.net> References: <20240425165852.6681-1-wahrenst@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K1:5ZmdyL0d0n11brCiTDARa/Sl7DKBkm+kiTclKZk6DhVNQzTPHsP 9WDM42//cGxaQreIHeUX2Ek0Y2tAkHwqU3uOeQgz2fKfRbAgeFDXvqkOL5/6aLzr1kSTbQa U8klil03sFNREkm1QqLOljrp/b3c9iY/cXb5PPafHb7tAgKuE5c/1i/i0D7mby9nCxhRHNB Ke/g89AMLNrApdWCkBqbg== UI-OutboundReport: notjunk:1;M01:P0:BdrE43XugC8=;gsKDqjA48TcgVEhomlzSkZfp/Xk Oq3uf7UZ3G17GWDA4cO9+B32F/cT5s/v1NSXkPngp9dBZfhNFAd4yaDbuYuSilfp4b1/zcGzZ O8Gy/GAbTNkhzzV9OPP6tsAcxv/h8RdRg5Y+a05KJbBfxd9wnNN6vd/HgELWRuH84SyzCFEn+ 0izpy4ECxGLzRWjU0dWMsG5B7MnkaukzfqHjRcHGb+zqzTN1c9Rs/esRMHfbLSZ3RSkIv/TgU i00xWn7Ch9rzPJRHznz6lOy4SzOXClYsxGYXWJqqcbuC0KczajZDgyoQAFFrq7TCNt4Qzhsig SOfh0segilTio4u3VPSKYifu6ieBj1DeNZkILGtweHxhxwKdbHruD9Gm+t8Jo4eO2mHz9R5yk q5SN3+i0B4QBc0nsQzygDlLtufqzMIyrWLfeJk4EV2DVjUevRMRru24+pT+t3MRgkgNiszHY9 5fsZnZROTiPt9moAGOaooNOgDkT6Vn+0FMpLtAoOJB6GO2CEQVD5QRjwpXy/gmUCtba5/bKpn 5ImiXuC4Rr6ky4tun0nBKGOxvFAnEiCI/+7MQeXNc3SBfjB7KS28adA/Zo2cvBdOBe5wAJb59 O+QyLU66CvdVGOQBIW8RswKz4olx1erQGkQ1B+gQrmkq400iGfp2oRyINUeewIdwgKUxgU6O1 vCKFw+Elh8H/T2HQ9qehIdrvc7b2uUTyicKQ2pqbLRlmFOrvaiilydsig3f0puMhRo6MAjTz3 uHfCL09wS8oZs4vQgMbdr6/Eu5dqKVOqjy67ln6dG+MdMd/c0A0gbIwy5cWCui/euXolGUtTN aUCqJYue8vlzmXxNMGL2vZgx8hdC6+SUt0TVzupCxI7po= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_095922_485281_12429C47 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org checkpatch.pl noticed about missing blank line after 2 declarations. So add them for better readability. Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.34.1 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index ca32902afe06..df3af821f218 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -227,6 +227,7 @@ struct vchiq_service *handle_to_service(struct vchiq_instance *instance, unsigne return rcu_dereference(instance->state->services[idx]); } + struct vchiq_service * find_service_by_handle(struct vchiq_instance *instance, unsigned int handle) { @@ -2176,6 +2177,7 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s for (i = 0; i < VCHIQ_MAX_SERVICES; i++) { struct vchiq_service_quota *quota = &state->service_quotas[i]; + init_completion("a->quota_event); }