From patchwork Mon Apr 29 04:13:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Ni X-Patchwork-Id: 13646262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADDFDC4345F for ; Mon, 29 Apr 2024 04:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=iAWbSm4V0gw3LRVd/2Xc1zVe7F3cj6sP1kgMLiBKQps=; b=vTjnwWFnYVMPsI FVNqkP2il/Mkpsqm8MAj4X/JJfoox4OvJZvabkbT8bRHCgetwOjTQcWMNeuNmGhJrJKxlO23mv/Ue QDkT5KTwrnV3KBvM5vz//yPv681zwMEaYWir09NscXfRk/bYbK24WlGH8p5VAJhWUQJ9oaPPBE3Ib 72aJVawirtQljPtKvTrrhBDvk3Qa5KGHqPjJTfXCnep6OSrjf85N/Ty9KXMI2kPdpnP8xwV98C+Zn JEeb0p0pzzshktRjkWh818K82DWiNOS9ueyj7zW7mlSQb0Pz8kDj+Vh+lwespZhGKI1MqclDSKRh7 HBoVdMHrgXU5ApiCQTFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1IOy-00000001Oht-0YA7; Mon, 29 Apr 2024 04:14:04 +0000 Received: from smtp21.cstnet.cn ([159.226.251.21] helo=cstnet.cn) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1IOs-00000001Oh5-0urK; Mon, 29 Apr 2024 04:14:00 +0000 Received: from localhost (unknown [124.16.138.129]) by APP-01 (Coremail) with SMTP id qwCowAAnGJl4Hi9m+W8SAQ--.23177S2; Mon, 29 Apr 2024 12:13:45 +0800 (CST) From: Chen Ni To: vkoul@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com Cc: bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] dmaengine: bcm2835-dma: Add check for dma_set_max_seg_size Date: Mon, 29 Apr 2024 12:13:12 +0800 Message-Id: <20240429041312.2150441-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: qwCowAAnGJl4Hi9m+W8SAQ--.23177S2 X-Coremail-Antispam: 1UD129KBjvdXoW7XryfXw1UKr4xCF1xtF1DWrg_yoWfJFb_tr 48uFWfWr1kGF40y3s0krWSvrWSvFZ0gr4rWr1xtaySq34UCwsxJrW7Zr1kZF4UZa48AFWD Ar15urWfCr15CjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb38FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr 1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02 628vn2kIc2xKxwCY02Avz4vE14v_Gryl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7 v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF 1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIx AIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI 42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWI evJa73UjIFyTuYvjfUe89NUUUUU X-Originating-IP: [124.16.138.129] X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240428_211358_677859_9D62B921 X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add check for the return value of dma_set_max_seg_size() and return the error if it fails in order to catch the error. Signed-off-by: Chen Ni --- drivers/dma/bcm2835-dma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 9d74fe97452e..d1e775a2f6b3 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c @@ -899,7 +899,11 @@ static int bcm2835_dma_probe(struct platform_device *pdev) if (!od) return -ENOMEM; - dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF); + rc = dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF); + if (rc) { + dev_err(&pdev->dev, "Unable to set dma device segment size\n"); + return rc; + } base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base))