From patchwork Mon Apr 29 04:40:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorine Tipo X-Patchwork-Id: 13646273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 896FFC4345F for ; Mon, 29 Apr 2024 04:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=97FpiCy6X3gGALxRZF1GyTaZS3Qt/TEWxAd6IeAimSw=; b=WZHeqcd/2FDklO DdbWmUPbV7nF16UWkZauMMCRR4X7C6/c6ZV4QMsOBw6munH5UP1jeQJJOsknb/NdDHMDJ+kffUwzc 0FCCN8rHMbu3tZIiE2Z6UYhA7YD938nAku6wIeosEn7krnUTUDvPpYOtUamdhk1FjkhXulDnEMu4Q wyqT8N4kVtnzgEXOaGP2BxcYjUWgLomUtzfQLLk9G3uh2vh53PLuGm0Xn1FkgsQE6CLZupnbWC4st gLkhtvQYeMZFXnQjAgzxuQxgcHjVxtL4FR6fr5M4/rooRwzxXoQmpiqU/YuZwEvIPP+JIK7QmAgGu QIZmNbM2IUc1uwvTNP3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Iow-00000001RDG-05I1; Mon, 29 Apr 2024 04:40:54 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Ior-00000001RCY-3YYi for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2024 04:40:51 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-41a1d88723bso28342395e9.0 for ; Sun, 28 Apr 2024 21:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714365646; x=1714970446; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=solEmZTLUT9rrgpr8rWc5di4N0OBO3L9+P0yMo2Rqts=; b=lb7DvJVof5ET6FN8OOwj6LRsC9OFLwWXX+xjSV0RyaI7AtDVDzpWRzGhAPeSaOZ/gn 1rU5iyi38UKryyskW73rgcM7p43kbLcXKQ99eEkiI1aGspUBvf4EyvxCI8S7nTT64wfr hSshX+R9O60WhSVCZQJp1UFt19LjvpR056xXchybujx193XzJOL8LOgUqOfkr2c0pnOJ L7kcPmtmCYZG1RJkuL9zs3GiEQQtr+nZyT0Mhss7AUFy21mMRuyjr3Ch6vV1KphlmWoC p7W30can2ty4WbnGh5PKp5p/6FXeKXwbZNuSjYHHwCqcn6+lpzZe6gVSFC0cB+sPz/kd RKcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714365646; x=1714970446; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=solEmZTLUT9rrgpr8rWc5di4N0OBO3L9+P0yMo2Rqts=; b=gpdIQYgWQEJr66oA4/vcvQ7483TFSTu86G+RF+8RE0qocAKIsFf1ur1Yd7jrKqj111 CTS5xZ5lM9lcHcEy+ui9k8j9IYtqhmwVvpkb7i35LVDY7DLYdBwjh5hi6Zy1lB5L6S9s lITIubqbLCJCBpHUJiQmkpOEXvoCAwYe9yEWYqxp9isVMhmbNrh0NgoKy4D/iP+HnRxF ObxNZ3HWLmJpmcApEqOpRb985dwfcwvzYSjjy4LdNd4P1h28tmHtiZFMSYvW4SckD/mF 1QZ6pTnHNJgrUE/OfIvxRNbThDxH//vbrQUUyJYXNeAg4nHb58I7jQFpjiNV57jw2lyh tk0A== X-Forwarded-Encrypted: i=1; AJvYcCWDrQznTwQz7uwwddg1DwxxJXTYfoLoZ/sSMhINQcKZyk4aLrWKZAWAGnrkI/xgkBIrRmObvU5FPK5AXjHi2x5GMcNfW2TTYvvc5ywetM0YmcFh/XU= X-Gm-Message-State: AOJu0Yz/GcF4f/itDDdY2tD4YIDIiFOcZgPqkfKmfBgIGLZQjTr4fqlf Mp+paXlgcvRi62eg9XZctVxXawJrgj1/5PvXXluXcGWTuxJZ/fnb X-Google-Smtp-Source: AGHT+IGLyIURNb/0G7vU9X1cZNkRP4t+/yiUDBQmcmDw3eUtAqWgWVXNvatw9THmMZMddpB4KawfaQ== X-Received: by 2002:a05:600c:500c:b0:41b:e416:43d3 with SMTP id n12-20020a05600c500c00b0041be41643d3mr4112231wmr.35.1714365645751; Sun, 28 Apr 2024 21:40:45 -0700 (PDT) Received: from ubuntu-focal.zuku.co.ke ([197.237.50.252]) by smtp.gmail.com with ESMTPSA id u5-20020a05600c138500b0041c5151dc1csm1409367wmf.29.2024.04.28.21.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 21:40:45 -0700 (PDT) From: Dorine Tipo To: Catalin Marinas , Will Deacon , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dorine Tipo , linux-kernel-mentees@lists.linuxfoundation.org, Javier Carrasco Subject: [PATCH] selftests:arm64: Test PR_SVE_VL_INHERIT after a double fork Date: Mon, 29 Apr 2024 04:40:12 +0000 Message-Id: <20240429044012.5018-1-dorine.a.tipo@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240428_214049_911824_36B62788 X-CRM114-Status: GOOD ( 18.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a new test, double_fork_test() to check the inheritance of the SVE vector length after a double fork. The `EXPECTED_TESTS` macro has been updated to account for this additional test. This patch addresses task 7 on the TODO list. Signed-off-by: Dorine Tipo --- tools/testing/selftests/arm64/fp/za-fork.c | 95 +++++++++++++++++++++- 1 file changed, 94 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/tools/testing/selftests/arm64/fp/za-fork.c b/tools/testing/selftests/arm64/fp/za-fork.c index 587b94648222..35229e570dcf 100644 --- a/tools/testing/selftests/arm64/fp/za-fork.c +++ b/tools/testing/selftests/arm64/fp/za-fork.c @@ -11,7 +11,7 @@ #include "kselftest.h" -#define EXPECTED_TESTS 1 +#define EXPECTED_TESTS 2 int fork_test(void); int verify_fork(void); @@ -69,6 +69,97 @@ int fork_test_c(void) } } +int double_fork_test(void) +{ + pid_t newpid, grandchild_pid, waiting; + int ret, child_status, parent_result; + + ret = prctl(PR_SVE_SET_VL, vl | PR_SVE_VL_INHERIT); + if (ret < 0) + ksft_exit_fail_msg("Failed to set SVE VL %d\n", vl); + + newpid = fork(); + if (newpid == 0) { + /* In child */ + if (!verify_fork()) { + ksft_print_msg("ZA state invalid in child\n"); + exit(0); + } + + grandchild_pid = fork(); + if (grandchild_pid == 0) { + /* in grandchild */ + if (!verfy_fork()) { + ksft_print_msg("ZA state invalid in grandchild\n"); + exit(0); + } + + ret = prctl(PR_SVE_GET_VL); + if (ret & PR_SVE_VL_INHERIT) { + ksft_print_msg("prctl() reports _INHERIT\n"); + return; + } + ksft_print_msg("prctl() does not report _INHERIT\n"); + + } else if (grandchild_pid < 0) { + ksft_print_msg("fork() failed in first child: %d\n", grandchild_pid); + return 0; + } + + /* Wait for the grandchild process to exit */ + waiting = waitpid(grandchild_pid, &child_status, 0); + if (waiting < 0) { + if (errno == EINTR) + continue; + ksft_print_msg("waitpid() failed: %d\n", errno); + return 0; + } + if (waiting != grandchild_pid) { + ksft_print_msg("waitpid() returned wrong PID\n"); + return 0; + } + + if (!WIFEXITED(child_status)) { + ksft_print_msg("grandchild did not exit\n"); + return 0; + } + + exit(1); + } + } + if (newpid < 0) { + ksft_print_msg("fork() failed: %d\n", newpid); + + return 0; + } + + parent_result = verify_fork(); + if (!parent_result) + ksft_print_msg("ZA state invalid in parent\n"); + + for (;;) { + waiting = waitpid(newpid, &child_status, 0); + + if (waiting < 0) { + if (errno == EINTR) + continue; + ksft_print_msg("waitpid() failed: %d\n", errno); + return 0; + } + if (waiting != newpid) { + ksft_print_msg("waitpid() returned wrong PID\n"); + return 0; + } + + if (!WIFEXITED(child_status)) { + ksft_print_msg("child did not exit\n"); + return 0; + } + + return WEXITSTATUS(child_status) && parent_result; + } +} + int main(int argc, char **argv) { int ret, i; @@ -86,11 +177,13 @@ int main(int argc, char **argv) ret = open("/proc/sys/abi/sme_default_vector_length", O_RDONLY, 0); if (ret >= 0) { ksft_test_result(fork_test(), "fork_test\n"); + ksft_test_result(double_fork_test(), "double_fork_test\n"); } else { ksft_print_msg("SME not supported\n"); for (i = 0; i < EXPECTED_TESTS; i++) { ksft_test_result_skip("fork_test\n"); + ksft_test_result_skip("double_fork_test\n"); } }