From patchwork Tue Apr 30 21:36:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 13649988 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AE01C10F16 for ; Tue, 30 Apr 2024 21:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x8A7PRajhMHtvHPJUXvE1jOc1QSxRwrQIQpALZM1e5M=; b=Cv4WmJSmRJQRi5 NSxqP+/7ORNHRq3RRaCL6tVAc3H5YFyKkp3q56aUuSBrt3rGr/eGXzJBt8tlY/8C5nUI6SU9AVOJ6 UjzXYRT6hlqEeUInAmtg4aV20HjJ95MqKl7yvwYoEKzPaCyfzFayHd9QLD9+7sxh6n+msK4fposcL iKmxp6SMXz14ggWjYnxoxQRxFwMeCTRhkCtJZgDcILCukOoWACHA9cgTSQUizkGe4yAdkAFYgDX+u 9FYxOijEAKFOt/IU+2ZVYwTfD/uEoWFhkMC94kpvWrVXclUNpcJV8kf51cwIZpsX4zLvKtpDFYeIy 4fMfNTQdeU5UWJiqLwOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1v9Z-00000007z9H-2E5W; Tue, 30 Apr 2024 21:36:45 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1v9W-00000007z8Q-1JmH; Tue, 30 Apr 2024 21:36:44 +0000 Received: from pendragon.ideasonboard.com (unknown [109.130.69.237]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CA0966F; Tue, 30 Apr 2024 23:35:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1714512943; bh=0Qj+D69jEcpqaHMFgZ7FoyOuv7/ML8F9fuodPYJB9X4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jhwOjB2/QdCt3pb/4iqM21+Dd2f4UA25f9N0jpS19nz/XOZqWjsW78VJxUafll4+2 fHaBCkbVwYzmnSNDhTXm6V7x+My4iMitDGRTMG3DG/fi87msmsO0+QiNEsnwkN02XL KkkHVaso2cwBUUW2SjUaY34/CZZyK2w/O3zLUZ6I= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Naushir Patuck , Dave Stevenson , Sakari Ailus , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] media: bcm2835-unicam: Drop usage of of_match_ptr() Date: Wed, 1 May 2024 00:36:32 +0300 Message-ID: <20240430213633.23767-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240430213146.23187-1-laurent.pinchart@ideasonboard.com> References: <20240430213146.23187-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_143642_526286_48B30C75 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using of_match_ptr() to set the .of_match_table field of the device driver results in the unicam_of_match table being unused on non-OF platforms, causing a compilation warning. Fix it by dropping usage of of_match_ptr(), which can be done because the .of_match_table field is part of the device_driver structure regardless of whether or not CONFIG_OF is selected. Signed-off-by: Laurent Pinchart Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/ --- drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c index bd2bbb53070e..c590e26fe2cf 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver = { .driver = { .name = UNICAM_MODULE_NAME, .pm = pm_ptr(&unicam_pm_ops), - .of_match_table = of_match_ptr(unicam_of_match), + .of_match_table = unicam_of_match, }, }; From patchwork Tue Apr 30 21:36:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 13649987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CF75C4345F for ; Tue, 30 Apr 2024 21:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=crnbtz+urHay5GejihqN15hg68jdwNVQUHyFtp4R2nM=; b=2G9lMewKRlFh5n MlzTHOtW2KpVrS58bCVfvFUZmNwp+XhWC8X7y72ryWIblozER7BsFlt4rG3qQ3xybIlKWCv9iDDvK rXTHG68msDkEFf1BnzHzQQTIg+Vpuze1/4UV9Cw64MLDcVS3xjuhwe3erL2+IXbiXvLE15lXL9aIa 8CcEaJClTR4xW/y1BXOzRzyd7HI/ncKSygAVEPbZZVUoFVM50n099dBj62cR2jk0OFt0FOzSOfXe9 8eJEKY58hAmcBM5NEQng2MoWQBH3d9UPsq3x6KzaR9SkRSeupR7v0JvEDJX0G2j09P3/eQDu8TTrS XRf4+zabj4vZF9ynatoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1v9a-00000007z9N-0mfZ; Tue, 30 Apr 2024 21:36:46 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1v9W-00000007z8R-1K8L; Tue, 30 Apr 2024 21:36:44 +0000 Received: from pendragon.ideasonboard.com (237.69-130-109.adsl-dyn.isp.belgacom.be [109.130.69.237]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6279CDFB; Tue, 30 Apr 2024 23:35:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1714512944; bh=8wmctBpBoob2v9+vY4JOC+E0Zgc0jTFshoOo4TzelD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kW3Pqz3xsVKcPSo0AMj5291wkB7VvNxzY5t9iGFdhEQXsmcKNt7Y4LcPt8F5dGdbT X7YNb8Rlzq5umn6j0c6Uy8LxS5ZQG8xMLUJtDbCUds9qcIddaIaurOtHhlCxzoCDKT GcCTHIVfMNqU4vz2a2sAOYOIgb2BSjxB+Z3NlpgE= From: Laurent Pinchart To: linux-media@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Naushir Patuck , Dave Stevenson , Sakari Ailus , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h Date: Wed, 1 May 2024 00:36:33 +0300 Message-ID: <20240430213633.23767-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240430213633.23767-1-laurent.pinchart@ideasonboard.com> References: <20240430213146.23187-1-laurent.pinchart@ideasonboard.com> <20240430213633.23767-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_143642_528861_965798E8 X-CRM114-Status: UNSURE ( 7.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The unicam driver uses the v4l2_subdev structure. Include the corresponding header instead of relying on indirect includes. Signed-off-by: Laurent Pinchart Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/ Reviewed-by: Ricardo Ribalda --- drivers/media/platform/broadcom/bcm2835-unicam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c index c590e26fe2cf..3c7878d8d79b 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -55,6 +55,7 @@ #include #include #include +#include #include #include "bcm2835-unicam-regs.h"