From patchwork Thu May 2 10:08:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 13651540 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9676E57301 for ; Thu, 2 May 2024 10:09:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644562; cv=fail; b=FL78wmHJi0OjWKnJWOgyYDsWQD56aKDy5TeAfK23cML/PjGY78JUAREhiG3wbn/QEHPZkH/s6qHTEqLN6cAYt7NQ3TgTxfMrB3e6kkbNIv9LFh+1yCliBGyPkF/1h5b8FZSujTydgPe5CVZOSQTQ2AUFXddwc0/tzoi/OHNObJU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644562; c=relaxed/simple; bh=Un+7lO7z/YnjDATPScNMaiA5lGXGe9Ryj0WfC901gcE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=ROxjwU1kTxr4IOjNir2JamejVFCYvpchhYrabseyXK4+ECcsJ8PSwfrBnVU2ezlBz6G54fzNutpzNSDhgEGxQPSRgr7z5zMZvx7G5DtMd/kSeKCUrClc15NJP9CojG5uCZ1Y+w0rNoGV82vmcql4dbmSyZJ9a4iqdq9qDGaPIhQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=kclacQPo; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=unoZU8pH; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="kclacQPo"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="unoZU8pH" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44283wMq026428; Thu, 2 May 2024 10:09:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=4dqs9aGjC4pllo5h+FMxJdIbw+ikMU+042jgZ8VGVNI=; b=kclacQPo4JAb2PNACP5tRwQ0ttV4Kvq+JP2PupB9ernbLbyo654/TEvpMC7tP2uF4arC 6SjhArNclf/J1zDi1ufsBvcTjchjdjJ+/fnq6+wLSvtigTfzqEAt4J1a2zhY2IS8BeHW UDllx54nZkyO6wKj3zrDzp7wI1nTXDJMjOJ+dcU3IQ+TkJd9rFO5ebYqAaWkRmsJb7al sjTld0bynqduOr+VDwxYSG0OJS7s+KEE1UmIlPy8gp5YS/T5kzyfiArkEyd/DMaxnOuu CEDXjpGUMan6yNuR0w1M9xnqhAb/FyQJ1Igkw8R+RtmeiQzB2iMcB5N8/d0Km4/tlBH8 Ew== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xrqsf57wk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 May 2024 10:09:14 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4428oEER020063; Thu, 2 May 2024 10:09:04 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xrqta6s6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 May 2024 10:09:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzeBg1ymidbxw8c2+CaQRaDW7HDkZRcxzygzcaSweGZNgBuYLVUEhD9QmIP7I0X6kK3acSvBmP69LgAIupnJkow0v8mDjrTqR69dhsWfGx5NLMzWTPmehQ9mxxtETvNd4adQydBH1j4ds/aWi6PFVvboOlBcb6StcCuMnuH3EMk7E0zzPv3wZ1EbsfvkP4S830rcD7pvEyDDOziR9JEeAjY8U49iyooTe5mMkmjtFnSipUp6C6DDJP9Noh0bvrX29tZtsR9K1oWAXlC/LanrbZWuEeQltiRaj8hFK8HlxqSJt6fjYCxcnSopmmC3kmxTDr02XgCvreidb5ln5rHc0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4dqs9aGjC4pllo5h+FMxJdIbw+ikMU+042jgZ8VGVNI=; b=dQZCtdiu/EfBA89Q46OiYMRLAbbdjCHeCXd0kXtPsJWIWUOhwGwkT7TM70Lt6OWKicHABrqQCZfzh5tQZfAhJoQF3BCevUySltaDH/vxYl4NhbJEmiZeE9VR+qk7YauyUjTFKYK8a+zR5IkplESS09sfms41lA7oi4cCUqM6ANiFue9xfDduN6WvTpkeja+Qc0SjfNSYzaQ+iL6g/CfrtHJqxI61GfaaCMQUiVdradycAcOc3TvJfaiZ7X5Ji6N07AFfFcX2fygAJaBsjvkHO4D10w4RIG2lj2QoDJwanxmVcsuZv90usY3kjyx0OmMRmY2pUy9wOgiaNTvjjU0mbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4dqs9aGjC4pllo5h+FMxJdIbw+ikMU+042jgZ8VGVNI=; b=unoZU8pHtIMEghG4JIznFwrmcoxkIifFRl/TmbkiJCXyuQ8Nh3brTT5xfrFim9FKCV4BY9s4aftxWRNkyKWm28G5mJQr4L0C/U4uR4dedDe+TQxStoWjdXpD/ORDxczKtCHapxfPhXTpZFydmQnHkV0w3r2bWfWLB+ZJLKDDcws= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by MW5PR10MB5737.namprd10.prod.outlook.com (2603:10b6:303:190::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.40; Thu, 2 May 2024 10:09:01 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%5]) with mapi id 15.20.7544.029; Thu, 2 May 2024 10:09:01 +0000 From: John Garry To: chandan.babu@oracle.com, dchinner@redhat.com, djwong@kernel.org, hch@lst.de Cc: linux-xfs@vger.kernel.org, John Garry Subject: [PATCH v2 1/2] xfs: Clear W=1 warning in xfs_iwalk_run_callbacks() Date: Thu, 2 May 2024 10:08:25 +0000 Message-Id: <20240502100826.3033916-2-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240502100826.3033916-1-john.g.garry@oracle.com> References: <20240502100826.3033916-1-john.g.garry@oracle.com> X-ClientProxiedBy: LO2P265CA0124.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::16) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|MW5PR10MB5737:EE_ X-MS-Office365-Filtering-Correlation-Id: f6bc4fc4-5b8c-49d6-e738-08dc6a8fe362 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?LE1oKnRGBd+OkD0ZabTMitCf/lxMaCM?= =?utf-8?q?r/GywN8Zb3vjdjd7Xrk9abb6Y5oHEgJUujOJGO/C79+7J9fVdE/9eMf3FNoostO0h?= =?utf-8?q?6BDkBW8wRB22YcvVGT2pNCqUQGB/8iol7vc0Y0nhH3B8EBN8ck/3+NOVNNRM04ZRw?= =?utf-8?q?TQTCeRjSsZP0YbzZWJhvh2iq4Gm/nZpb7M/4lcOTqDyWzeb4pb8kM11ZySHiPeWSa?= =?utf-8?q?WxTXo4vVH9VF/+At7slrbd2wfIp+G87Hs1cBQFtF685PB1qAgHFFd9SDoILdoXVpT?= =?utf-8?q?X4R28Otx5ipHPPBFkyDl51P7KRufEZc5fzN3awlyG915vdT+wwyHB6sU3VTHSAFVW?= =?utf-8?q?sXRQdnpQR5+QaMV+T4T+8rw2dhixIGcCCEJAgbjwePY4GYzNbiHEjLDH7zyLehiH8?= =?utf-8?q?S3PsIpYAaX1lJ5/U8cuOGkcUdhjHGJ4qSXZpqW6ZD0wRlWnVq9TA8+spD/sB7Inrx?= =?utf-8?q?NXnxNYTCZQ/UBRkkVoCurqA3BBknDCWgA9Lb06vmhX+oeCbW4/6l+WyqynvjtXqb8?= =?utf-8?q?w7bPo+zUlmQytrw4cTPy5/nzJOaSrLkaR/uxHsUfaEgYilamRMCeJRW+g0VRMZa3B?= =?utf-8?q?Um2KZBh9dfn/VmWQHFHtZpsPTxpY2nkOlYNmv030SPhfAUqo7TPAO4UVmBzcnresh?= =?utf-8?q?1d02CdUkcJt2AwnPl1WSmpf4KzwX6WeQ+jzKJlXjWa4++/c7mppxnQZ3XxDsjw5nh?= =?utf-8?q?h+i6KHIAgzb80syNjjRiX6hQWhXV5aTpXrla9Yr68WgVnbEa5WDBMg2u1F30QV/v8?= =?utf-8?q?jF/Lexs6VM+jg88VGCYBcGkejkvz4P49rtE5Cat+H/Osd85rdDR2ECVWZziSA96fo?= =?utf-8?q?zHceuuuZsU6ZuZv19ZNGcZjfi0rLalaVwCcGxmxEruYaduf4h0JiKyugOLIAS20No?= =?utf-8?q?gX1HlnBYvUB8fKNNaxJM2gjPJVRwaMOrg0qnM7B6g3UKNoxqG4LRifB653YIWatPd?= =?utf-8?q?/YDBnnfrOcvXg/0D4zw0VItb2rWbL1NsW5M+hsh921q0aaB5y73Mht5XEPWtsT0hD?= =?utf-8?q?WReurKoPepKmld72Rg0q3Ukh8Pcwbipt/ObBhvUQjXQ7xkKoS0zvCWgqWrX71+rIo?= =?utf-8?q?RgLL9E7IuxUwPIyx+bNR1ktALCqowlPprDJqUjcrgxdxexKwsL4BSCwmc/9KvB29w?= =?utf-8?q?fH68RJ1sidX+YL9is4AUDYTQx58PzJp8dbZJ32hRcGlF6IzoKwXCeeR0L5goDgr3B?= =?utf-8?q?tOIz19dIqQnVMhcfWOqdL1sng9Q+yd6WPGNQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?xtt6ZZ9dVS2jO8ZWXv66njQGD166?= =?utf-8?q?yw3PTAIs5q0uwbIt/dSXbUHQ1UV+oJC49yMDJkT4EPbPs08qsb/EV40cwwdjYNVMz?= =?utf-8?q?sPZHKRyg+xNsOnEkwxWFBjSUH4EVCChZYXgteA5x6NVLG8vsfRC+6Gx2hxH8KyU/e?= =?utf-8?q?WntExF2lsjIHTiQLGwleD7cLI6brxSx7nWDtI9UBAcbAVIEVk4G13vs9KvReGxP1t?= =?utf-8?q?Defvvp50Cyaun1C8x0T14dKZC9Hf2IdY20Zwo8axOExupTmodbWwruwOH+E8eBLGv?= =?utf-8?q?zpxPJ4roQKrDnaWb9GQXJA69ujFGxkvh66CPoJad/9fgNLYOprwm8McqVk8TMMoLV?= =?utf-8?q?qHRup5MaeZYQ8McjGcr+Z9Uz03UB5hxm1POKgg5u6wl+dVlex6qXoO6YyIp1jAFS/?= =?utf-8?q?vQZ8U0JdEe1L8sSTJeGQx6Q5iijaYzx+UI/jzq/mgg4UCAtXTZKmw6N/+1c0qee47?= =?utf-8?q?/UAq6uxDkPJ/xhV2vg/agz5Bat9yjW2kknl6FzQY6dwAmYRR4frsLYbSXQ/hbq/FY?= =?utf-8?q?rv/CDCor7t+LY6Dds5rOaXPMlfviQlZdoqjwRGcQpPZvJm0vcVwhH5+JIU6gyWKGG?= =?utf-8?q?yg217A+f0zkK8LvfNIvgADWny0WFnEXATJ/jLbcUw8H/8x5XLbfVFaS2ls2DD7NGF?= =?utf-8?q?KUue+LAgLoS4znhdotkmsVW6pXgPKzMWEUZVrozfRl9/LCIDT43XdfLVOuyOSznHx?= =?utf-8?q?mgkUHiF9uNwTBwQ0e4JVNuP7B7HaO9NACPBjzyKfFCzrKeebe/jiVCe1ZCabHxV4l?= =?utf-8?q?3tExP+wh5IYS6XKm0nfWoflkwFdK1tgk2EyNuO0I7UkudVKcHd/tc2/1S8xrs829J?= =?utf-8?q?xNZ7pmPgfoVsSDe6NmonJef8L8JnC6y6yQ4vO1UBQybl9WOODHkkxBwkB5UQTw+wj?= =?utf-8?q?/AetKHoie+2dpdYqAMTPWjAqsndLtnha+nCEQfoffhMmS9SXd4SPY2jziOfY9eJJ6?= =?utf-8?q?TRl4b7+h8Uw+BlhGhrZcylSIM0JbcV+RWHO/Ta49Gr4v/0ZuHa2Dj6dkzjlKkXSSd?= =?utf-8?q?lx/JcRSv3lz2Hc7gOKgXYJSqg0F6/5s1NFJ72KjPWmNVqHXTdm1GPQDpDHdo1zEPv?= =?utf-8?q?6W7KA+YA2oKKTjJo/2hlXnXMxE8BmNO46DFHplfirNdT+/MrDEzeA8YXSb5uXuB+f?= =?utf-8?q?eky54t+xz3HcNb8GJW5uO387DrglUxpbDhtEp/6vBpw+kiKZC+qQ1SPyOT4st5YFU?= =?utf-8?q?Vkyd5VNLLB/B9/hVcFtVDMRvJr2vrSXXEV8vbg5yzrVG9gZixHuEf471XjMZ9Z/H4?= =?utf-8?q?kE5kJCuk2a3hY/2Veyp8JYk/VaJORXEvVPc0SUJEDe73pyM79R7A06S3aTTCK3hE4?= =?utf-8?q?sYB6CHNf3ZlRw5KjdvDcvkiXh80PO2QLBg0Vf2kIpjvh23ebU2+ZkLBiPDoby9f3T?= =?utf-8?q?y9WQx36PfhMd/Xn0b5J/h15KnX192mZ3sFm4reyG3Rhkq/Lxo4VlrhiKkys+Hrcoo?= =?utf-8?q?aGpy07otCijrvgDIFyajsLS+vgXuxkIcegIY9boVvKINw80S4ts5dKpWFDMNvW/Aq?= =?utf-8?q?1YsVb1DeEEWVy9pbGEQqWdW+Bn8Xg15Ufw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zQDoJDkx1kby9fs3f+TZlTjEcAmPO+jUVy8R6GzRixiJv1Kay49fvF6ophY+O583euRao6gQuGU38tf04OrDEQXXXMloOvjoD6GsbmRYfbI+x41p767KwMJgpR5k+dAzzGfncQqaLU7TzRncl5VZBBt23IgfsMqp0mHt8v8yvDYfug+t2LyLxBPv22ze3/F9uiXqUn92TkDyrx2BDaVYu+gufzDt1ALnnji7d70Yxt9yRzHKZKsJhdrLOl+5OtmQ1xFmaQdICY1DC69cDVcnvvsWWwxyfHnUd0DuqP9Konxz3ExBuxpGw6pSS4Bc4pfz2ceUbVjQxbPDzKdHUzih6LmD8B7es5QZRMxhVYID3VQwtg9GvN0HKVZ6jAutILWImPs9Je9YgTD2+dCqOwTC+IJ1zOIn2Olj3Hswwv32gqp94OdZ9BLsxw4cK4DX7vG0VNLtxfQ8wZ+gyTE9OByNMc82UCUB3VH5rcOKjpPlknAILTe4sqiaa8ZlteDgExNDMZ5KMAKsWyxkfnOrR9Yf1cvHsROrSGFKfM5W06lo4vNnZymJqa5H59oXP9e0Cyc3HMfC351j/TdX7ookzejvVFY5AFWnk3UvjKDicnoLKMo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6bc4fc4-5b8c-49d6-e738-08dc6a8fe362 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 10:09:00.9359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L88C68UDPmS4F/psMbLovVmqIyUEbetewNzmW/Xsl8aBJmqgCP1eS8Ft+LwWZC7ScXB8FClCqGYiDbLAxFdtIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5737 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-01_16,2024-05-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2405020063 X-Proofpoint-ORIG-GUID: 93fD0k5H1js0OiDUWxr6fSgWR__xJ_ty X-Proofpoint-GUID: 93fD0k5H1js0OiDUWxr6fSgWR__xJ_ty For CONFIG_XFS_DEBUG unset, xfs_iwalk_run_callbacks() generates the following warning for when building with W=1: fs/xfs/xfs_iwalk.c: In function ‘xfs_iwalk_run_callbacks’: fs/xfs/xfs_iwalk.c:354:42: error: variable ‘irec’ set but not used [-Werror=unused-but-set-variable] 354 | struct xfs_inobt_rec_incore *irec; | ^~~~ cc1: all warnings being treated as errors Drop @irec, as it is only an intermediate variable. Suggested-by: Christoph Hellwig Signed-off-by: John Garry Reviewed-by: Christoph Hellwig --- fs/xfs/xfs_iwalk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/xfs/xfs_iwalk.c b/fs/xfs/xfs_iwalk.c index 730c8d48da28..86f14ec7c31f 100644 --- a/fs/xfs/xfs_iwalk.c +++ b/fs/xfs/xfs_iwalk.c @@ -351,7 +351,6 @@ xfs_iwalk_run_callbacks( int *has_more) { struct xfs_mount *mp = iwag->mp; - struct xfs_inobt_rec_incore *irec; xfs_agino_t next_agino; int error; @@ -361,8 +360,8 @@ xfs_iwalk_run_callbacks( /* Delete cursor but remember the last record we cached... */ xfs_iwalk_del_inobt(iwag->tp, curpp, agi_bpp, 0); - irec = &iwag->recs[iwag->nr_recs - 1]; - ASSERT(next_agino >= irec->ir_startino + XFS_INODES_PER_CHUNK); + ASSERT(next_agino >= iwag->recs[iwag->nr_recs - 1].ir_startino + + XFS_INODES_PER_CHUNK); if (iwag->drop_trans) { xfs_trans_cancel(iwag->tp); From patchwork Thu May 2 10:08:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 13651539 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C43A856B7C for ; Thu, 2 May 2024 10:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644556; cv=fail; b=fus8mDAkjUp4Bkfa6taR/LDuMGOicK7RVUbK1k9iOPbeQlqad3ZeJS85Uj2olqkNDZN/OlZWESsFjb9QVrbhHpuWAZmj2cTG22kTulTtB2/DXUkyjOUGmUXK7QVzXJmli9aF69WgsCDYxAqK5D2v1KQivWzw2tXC0KRfnVEzNm4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644556; c=relaxed/simple; bh=qDtm3MlrYGRwBLaQ+hq4KSLTtrQVUrCGnKPB2UeGnEg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=tZhU9dRn52/g45PLc7V+daSM0axuw4rf2sEK4Mz8yBZwOImdrZGPFnNRVbmubLrnsvf4KeHd4g2pliuQ42NnaI7Ci3ee7cH82UYEGOzfYJYaI5a8/MsZdMVZKepYaKCfFy6U34ZoJaNQXUjODWMiGDLYQKgvDgRFtf1ywun8jwM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=PisuYqvT; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=szL+x+/O; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="PisuYqvT"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="szL+x+/O" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44283l1C030763; Thu, 2 May 2024 10:09:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=H0L/s9WhyLNXEQjch8q1D2vVU/Wvh87dL6iSUzyQ908=; b=PisuYqvTxwT0aAEhV402oePl5ixMcZKJ6wDV49qGFBVS7jVG+nJVVmCCqJO/w7PF7yTR m1WZz9osvOt1PbpbE9wlyG3rOe89hrv+rlOGjVljrA0NMbRS6/GwMW9uRSnyyxJAAD31 MmwRyRGKbwy1Dtu1H6PsQqEYZasyYbpgffODy1r4tdsxasnBin3PFlAETnzrw0yhA5gv ZcpYM9lRtBWHldsLw1sBOhHLMg+ZxtzwJbDENZYvFDDieUkRuwnMtFe2OTDeXSctz4/x Gk8N+kso6p4da7kl8miaw0F5ZRPwrDQE90aG6vWUKZrHsxoI7GFnzbMJgo2TYA5jQdv3 cg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xrr54ny2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 May 2024 10:09:09 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4428oCXP006091; Thu, 2 May 2024 10:09:08 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xrqtapcc1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 May 2024 10:09:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LrrKIp9IjbEKMV3paSa4Dwc4RqpMWjweIz4iWjZyWhA92B8adGKi2GLcPeC2UMpYKu5e/O6EGIBoNKImxmB9IjTnvMiul3rK2cSaQxv93G7ZP9/gZ2sI2cTUrxqJoneAVogzWUzgotc2qtb/GTmETC4aEoodHiLHd5RtV7a1od3+hLGRien7m0eu4/re+zVsVkE7RknKaFOh+YE35qh9rsz6Ggct5GBA7MvWTqtTw1pnAL5GNxhNKKnaJa3PfJlNy4TvO0Q0IM18t/unAqGlQBd0gOTzcYFRtWmoKDjCRcWLhXTC8loE/U+EY3/t9d9Y/JXI5Ed5K3bjNZg295aZlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H0L/s9WhyLNXEQjch8q1D2vVU/Wvh87dL6iSUzyQ908=; b=lqzfvnl8cYmMz2tEpsvuKjYADTRRA8ymO2VNjLn+4seH9E4VMtTy7aGoEBCznSiI1lJJ+vIZrvbl1y1+NJpMjnp5mU53Tm3S7RQuh6fNvvKVhIDJ3y683nfjgJ9okv6IbPt18LcduJ4bC7Gth4tMy4xEXu0fBXy+jFqgbxkXvD84lnokbGMQ0CfEIJjEd5f6N7X8tgh2dFcRV+X4TG8/EYXcW+lAdvir9WpnzZHrzowLW+dKtRCQgspnRiCZXQSGKU4GwEn9TSARwV8duPeELqD5OnQbV2AOTANuVYlvMKFkfK0RkNIP0noJlmikpCuiXpkz2iNENFbkOwxnulXOdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0L/s9WhyLNXEQjch8q1D2vVU/Wvh87dL6iSUzyQ908=; b=szL+x+/OqbF9Q9ir6056213GgEdmDDJG+WYcblLQt7pVdyOHpK4dxMPeCcfC5xl5DWt10uyCqQ5J8m/fqS5O9Fc2BIdAmm6wGqNtECfN9zSsXlsDqWZdVGKelsmSh7nZ6kjSE4UPw8iXVqGPoGity3b7PePjMLZiYKtfB6Y/iIA= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by MW5PR10MB5737.namprd10.prod.outlook.com (2603:10b6:303:190::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.40; Thu, 2 May 2024 10:09:05 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%5]) with mapi id 15.20.7544.029; Thu, 2 May 2024 10:09:05 +0000 From: John Garry To: chandan.babu@oracle.com, dchinner@redhat.com, djwong@kernel.org, hch@lst.de Cc: linux-xfs@vger.kernel.org, John Garry Subject: [PATCH v2 2/2] xfs: Stop using __maybe_unused in xfs_alloc.c Date: Thu, 2 May 2024 10:08:26 +0000 Message-Id: <20240502100826.3033916-3-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240502100826.3033916-1-john.g.garry@oracle.com> References: <20240502100826.3033916-1-john.g.garry@oracle.com> X-ClientProxiedBy: LO2P265CA0103.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::19) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|MW5PR10MB5737:EE_ X-MS-Office365-Filtering-Correlation-Id: c6495999-28c8-4445-1e7b-08dc6a8fe5da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: mb26gOQl/PZioZK+TVMhgSO+eA2mEBgGlab5XRlvigv7sM9uzOApOgT6q8wnIJ/q8U5GgyJMHSIgKSatDe9047svxrASL9ZMZkgDapxXG6bzALbTB+5Vl0r4ENoYjWW5hMyCH02umbrDpDKOqRrsiaUOC9qxn+4FILXG7CKxYrER1ARux4bzmfDvcMwO8orUYIuNj74vnguScrfKI76IeKB8+l6wzbR8XHsqaBSjwcaxcc0Rw2Xln4iWRmvLrzoC7a1iNgtmzRDWgCXOdlBMA+rW42UN9COdoxRJo+VbbichwW7/BgI++0M4/BLHvmfCbNdXsHT8LSF5Egq3X7MRfDAAXsi0bcsHCE4toXGdxINcpSLnwRduorYCUwY7KL5CZnYcoGokJxJzohfGF//gq8nK6jCRHZfpHslrVeefnCITu/BJTSomcucldFSKYWVgXQMR7vXXZw/V0S7KTb8Jtm49a6ZObv2Q/NlyDI8nlXAknkEGcRzfNNtif6+GJvyXd6kVY8LYvbadAg6QKdv85tJ9METgkSLBo0iHjz2scYXM3Krtuxd19OgJHq9fftvIgyWEiXf5J1PQGjdgmrWnvrNDwKaR09QYY/1ZloZD6LE1wtIU41dSUo910DM4pJQJt7ccmuJtit7UDNcfDMWbFeq3Viyp+Lu7+mNUGrvqq5OVtYD1o4fi5H5zwLfMC3zFwYXy1JpDqoXZ/cx6+naRhd4Q2STwSYFhBit8dxou1Uiuwu63ESDHFSl/JOhB79QkpUfjHadscnn89rF/2I8VbWkywtWP3oRj+4bEil0go7eCEmv/chyg8dDlR5KLwkaMk21dQXXnH6g8q6BYgQAdfgXqFra1oyfcdFUvcu+vO4PqoCwlW+4vRZ4SUDcx1B/icVCVoqZQk1518W6DI9+vs0w/11q3WHFv9mZmsSPj1Za6VaKy4hkC0T817MoRuPXOGalUVodSxzBnpdiJa3/QD2Visqc2BssUvMWyFD7NL1KERwDL+ebDPvEUUoMUFpAJALwSzxjDVnLrn6bECNEadRfAiAY3zHW6FVcF6960H5IKTZAitAxIKunQVbyNxHs1qd5TkWfT2MYrkvZuadAGE3n7ZmKzRjrtZN2fgXkvJzOcoW8CeBWa0dLbitpRCyaY3my+/d7L1zaiV82nbMWnPmVT4D7MKftkHWDBVRvngsLxmg5XEap5cdsTEjrjlTwDUCREdfRnJLpyHpcvHbEOUBQ8tBD8gMOp9NTTAzFQdqFUHsfQWMXe8T9YhO2LXvVTggTv1vLSGYUs7Z6f0CJ+9g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fsJ8mkD1WUbFKQRwf3t6zaNIxfzYRlXRtNb91Mq0w5rboqhDxY36E9AwXupKR4vPTcgEIQsYAZXY8nbqD2j4N6V6NMJFbYz29m57eCLyTeLgchwSjy4NCqKHG1IcQWG491oje2LSPNNyn4eIBNFcgs/gkE76WINaMJijOj+Py9S2+gSxG6hBRmev3g8hJeXmlyb5EGNEBgT8uVZw0zHZjlZwzlF0K36VJv8FOqYyG6rR7hqArQTEODm9DPOb1/VqrbHnuOQ4zuTVhIuBbKy7w/icefhGBrRj8FQ87Wyqn9QeqW5VkzbJBkrfBSdtLhJMj9somW+v/yCr86skvTT1c2xTiiFDtGqG7eK0ILUEsMSSqI0nXSEBHLkJGPgbVzPNSW/tyU7KzaDR6A6oa1CKWEoPLVwqXbJ2sfBkE5lXJkC4utI4cXHmkN8ZaawUzluQ5BYVXMKn/q7WdodPaYy/dwHaCTezRYddMpCVbRnx1ho6pY5qHSvP4EyAPd/NQxldukhlLXGC8wNgZN9hl6dg/rlmU2V3slQ82xsvXaL4KCZvXFkWrIT+9u6F7eunDENoSyg2wN2o2y13Iyp1sYc2Qjyb15eDS0JLn2GcCqRA7OBJ2KJ/cN7Wn6A6GnAN1tmdhdMS4e9c01th+zxxZtby5YfEoxoEOZVzBlDwgs/4h6LwYrtaEitqPzurw86ir/QsUV646C599G13K5oAmeMSTgV8ANjnxFoSCchO7x3WdychFC43/UsVXiVElnWkV2PWQc7wZpe5SXGytn09fydpmcw86zyObf/Zz8jcEeCpBViQzcVkKaSNeAbkHVlYKvljy7arA7S/LKiWO4RVmb9YBgy59GPfW5cEBiHE03IFYDFjHzXTuate9tAWGeBAj5mDzBdHg+ZTzKR/lQJVDcTw0tLIrL+Ac5kyRqi+BREYuOpVN1XVfmvtFVjg/88j2yXJpETFyhqt4VlyLzcc6vCpH/evLVfUxv8F1oMwAGNy+PF/22SNuS7QP1pRIg58XXgRAXHS8bfiitY3ijJs1bl4ZieUpQiNmLCtYM1gmEeEd9xMJEXHCOxeUhR/+15YlnHKwBM+KtmVWTFMsi/WPjFUTDijN3FLGnRGegeY8VQZ61+fyRdrHO2UHQAIrUR7Jas63SRsWTtFXjOz8X1gvjZ2S2+n1uC9bimWsOD4rqKFd5u1lw8lMqjfOy82CHf+iLmUO7FvmMlEtYLutTqD7QjsMh5aVCLDISQpa6oqzH1aFks24u2BFwlUcr7fFU8aLrzVe0231go3CxVbN7XRysFdiWUq6/urKdZGMnlHxtmrnDuZrsYcwZ0+gE6cCUyhaa3/ImgRayYrD98l95LBWBax2icHVc2FTI/pKi1xXctE0ItkHgSgHITa3ooiBtt/VmQfnX4trNevf6fTxGEv/Mv8ZOSpegJ82UAfsdLCndO/19/vO6yJs8GiQFFyhO+8qLbp14DpTgQB6942KHVbTppalLVXUxm6HD4E2NunuORExxNveZsyyRcFiHryiCex0W1gJM8Z7YZWcHg/v/3MZ5ZMW33rPI0JJ/cE3ECwc0HKMcIKXPeUXUpxyoWjoOsmAsPpRNQnTVsZHcqMuQk1DGWjBw== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: cw4gq6BVcLNp4UM4aonmF/fDUncGqT7NghX9f3cMpqAC8LJ0BM5CxXcA1DIaDoQbmMp8n225toQe9Z73hgXQWKsKUQuwXbTznxdZjNiCMY9r2sGDYN8zZiyp6OKo5elJSl2LPzbMIwiYlc9XE9mZOEIoP7e3PqKops4N7fBoOGVHzNvfy7sfSewJD0ICiWD+ykcSa80uGgZufoktb+buvglyWsQQNVYKtF8u+n+rfBrz3IGxoqPp6Mc5T9fA4tWlxFalyXElV1SGIB4vqHp5TN7k3oasYH7Tpk0gXBa2WrJWi/+NrTrKXzxGRNGurN28/m23v/ksTkSdOtEUnhwoBoOdDg+akYPG+9nlFPjScexLnaf+hSrtvEumTVCE+vIs3GpwaKlNVvhiBmfokA/E1nSpWiyL6T8vghwQl/uTF9jd7/yPBVG26x4Hid4XX1qsyEpDQySLyG/Mz/GXr6TgF9xdGhv28Ay0gaWoSrGgMB0rInRFgGZAm01FN2H4KJCxwZvYGK3ZiPmjDi7UtF/SXfdpxT5tfiSY4bD1OEYlle5tAXMiCrMP2mTFZHgqcq46sxc7CHe04SaLZZqHQESrYiv3r4MUXVueVqwij9rcfYY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6495999-28c8-4445-1e7b-08dc6a8fe5da X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 10:09:05.0029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KbNthHjURN9J9EfBRLW+KSv7YQ4h+3RAoKrog+Pi3/sl6lTjAZitX62f8okEhriQZYExHAmn5/bl62EKNBkcIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5737 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-01_16,2024-05-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2405020063 X-Proofpoint-ORIG-GUID: z4_A3KudTQ_2xPxK-40MpRBIAuwBcUhy X-Proofpoint-GUID: z4_A3KudTQ_2xPxK-40MpRBIAuwBcUhy In both xfs_alloc_cur_finish() and xfs_alloc_ag_vextent_exact(), local variable @afg is tagged as __maybe_unused. Otherwise an unused variable warning would be generated for when building with W=1 and CONFIG_XFS_DEBUG unset. In both cases, the variable is unused as it is only referenced in an ASSERT() call, which is compiled out (in this config). It is generally a poor programming style to use __maybe_unused for variables. The ASSERT() call is to verify that agbno of the end of the extent is within bounds for both functions. @afg is used as an intermediate variable to find the AG length. However xfs_verify_agbext() already exists to verify a valid extent range. The arguments for calling xfs_verify_agbext() are already available, so use that instead. An advantage of using xfs_verify_agbext() is that it verifies that both the start and the end of the extent are within the bounds of the AG and catches overflows. Suggested-by: Dave Chinner Signed-off-by: John Garry Reviewed-by: Christoph Hellwig --- fs/xfs/libxfs/xfs_alloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c index 6cb8b2ddc541..6c55a6e88eba 100644 --- a/fs/xfs/libxfs/xfs_alloc.c +++ b/fs/xfs/libxfs/xfs_alloc.c @@ -1008,13 +1008,12 @@ xfs_alloc_cur_finish( struct xfs_alloc_arg *args, struct xfs_alloc_cur *acur) { - struct xfs_agf __maybe_unused *agf = args->agbp->b_addr; int error; ASSERT(acur->cnt && acur->bnolt); ASSERT(acur->bno >= acur->rec_bno); ASSERT(acur->bno + acur->len <= acur->rec_bno + acur->rec_len); - ASSERT(acur->rec_bno + acur->rec_len <= be32_to_cpu(agf->agf_length)); + ASSERT(xfs_verify_agbext(args->pag, acur->rec_bno, acur->rec_len)); error = xfs_alloc_fixup_trees(acur->cnt, acur->bnolt, acur->rec_bno, acur->rec_len, acur->bno, acur->len, 0); @@ -1217,7 +1216,6 @@ STATIC int /* error */ xfs_alloc_ag_vextent_exact( xfs_alloc_arg_t *args) /* allocation argument structure */ { - struct xfs_agf __maybe_unused *agf = args->agbp->b_addr; struct xfs_btree_cur *bno_cur;/* by block-number btree cursor */ struct xfs_btree_cur *cnt_cur;/* by count btree cursor */ int error; @@ -1297,7 +1295,7 @@ xfs_alloc_ag_vextent_exact( */ cnt_cur = xfs_cntbt_init_cursor(args->mp, args->tp, args->agbp, args->pag); - ASSERT(args->agbno + args->len <= be32_to_cpu(agf->agf_length)); + ASSERT(xfs_verify_agbext(args->pag, args->agbno, args->len)); error = xfs_alloc_fixup_trees(cnt_cur, bno_cur, fbno, flen, args->agbno, args->len, XFSA_FIXUP_BNO_OK); if (error) {