From patchwork Tue May 7 13:18:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84A0DC10F1A for ; Tue, 7 May 2024 14:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f3yeDfVVLSl/m0bWs74h/7JAfYLm8/zmpRKiqYsoxDY=; b=YKEmi4lijmalQi aqR4bdYJDNl/A9Q9aOy4ojFL9nlgs0V8SfwGIA5jE9Um9YRbKNzGyK4EeiVZGDRlFbOAbvDMgKxyD Z2qMpK8UN5auG1nlvw+HErkurFYbn/iGMIOOdITt7mjfmpp/yhXjBLZ6VmhYPdV6RmNQUs27sNFtn 0p2IN0zh+LL4bW8vL6lh5Z+NaSZZHSrGG4txQ4AYTmchz8yUD58a6Yy+4DRusaR9sdVaa9ybqJEtf ffXZ6w0I+64Mn3YplGFKTbgX1F1j6aeubrf4mumm6qxb4zTG38E/+lIrYaJL7hjTctlcGoUOruzj4 hmqBNCA3QAmZtHlZYYfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4LqG-0000000BVhp-0KBi; Tue, 07 May 2024 14:30:52 +0000 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiI-0000000B9iF-2gMI for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:41 +0000 Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-6a0ce3e823fso19356716d6.1 for ; Tue, 07 May 2024 06:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087911; x=1715692711; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XvJOy5lJ/u6e9yHF9m7H/WFxuEXKyxfgmG432+rwWPs=; b=E4D12QGjyjudasSWGhzhLZ0zLP2rTxXHiKslDxwAJKarke5keVAaiyEjRDzhxLTfhr p4SIV+4ofA6LmpS5Ux2FBQJDpOILvMCgWWkCQcxuDmNg/H49JvLu36prg3V8xvZsm7xK aLwMIXhfWycfTiPxYYqnQXBQgV7Z8TjhW8Zu8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087911; x=1715692711; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XvJOy5lJ/u6e9yHF9m7H/WFxuEXKyxfgmG432+rwWPs=; b=hx/opg7OJOX89KTNCpahU+Ms0jR/ANTEAnA9nQ9itmmin39ZyaLMbT/GsD4Pqbm2+p 6JSyOaIA90H+BJdPZjhlRNNRzc8/zAONk3uZXhtRmavcgzvZdQMRXuLCR32TjzJzH9h3 Znxi4oMiSjHqyLPTzsuB8RDDoBVb8PtKdOnrTptXkrbaXPF0AKv+bZWFTt2842S1GbwT sEQQ5OV++o5yDz+ioQnBsg9OOmKfjgQfyl/gRbIcRvACSKdfCeXhKeuudrXEiKB6FbYb dZJcge5UQpi+Vy4qHcHKCgNN859PoVOzi/UV9SQPlpovicUjNKemNla4rLwiREcTlBH0 fs9g== X-Forwarded-Encrypted: i=1; AJvYcCXLvDDkBaFww7ly1W06rjSloXtjlC5C+sSlOcDMcwVRMwfzqhH2vgZoJIYyYNhE0CdkI0XOXEPyYTfGXUX9tIkvGy/RKF8tPVqBtiEWa3wOPsFKw78= X-Gm-Message-State: AOJu0Yyv3M+Ta6boCP307UkC8NDv6XR47ci1rJObgA+zn62aQwFCuoIZ Ibulc3lthAwc5F7LAjEJFWq2dBxUgfwBfkQLa6d5Lrux9JDq+ZDJVU8dPsJ3Ag== X-Google-Smtp-Source: AGHT+IGm6pXwHMdL9pFaV0FwWg8eqwPdftA0BUaILiny2B4bPC36O7QRhpTkxvdwYUJMzUmDBO5Kmg== X-Received: by 2002:a05:6214:1253:b0:6a0:b3ec:902f with SMTP id r19-20020a056214125300b006a0b3ec902fmr19399470qvv.15.1715087910820; Tue, 07 May 2024 06:18:30 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:30 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:27 +0000 Subject: [PATCH 01/18] media: allegro: nal-hevc: Refactor nal_hevc_sub_layer_hrd_parameters MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-1-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061835_095966_111CACD7 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace all the single elements arrays with the element itself. Pahole shows the same padding and alignment for x86 and arm in both situations. This fixes this cocci warning: drivers/media/platform/allegro-dvt/nal-hevc.h:102:14-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/allegro-dvt/allegro-core.c | 6 +++--- drivers/media/platform/allegro-dvt/nal-hevc.c | 11 +++-------- drivers/media/platform/allegro-dvt/nal-hevc.h | 6 +++--- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/allegro-core.c index da61f9beb6b4..369bd88cc0ae 100644 --- a/drivers/media/platform/allegro-dvt/allegro-core.c +++ b/drivers/media/platform/allegro-dvt/allegro-core.c @@ -1852,14 +1852,14 @@ static ssize_t allegro_hevc_write_sps(struct allegro_channel *channel, hrd->dpb_output_delay_length_minus1 = 30; hrd->bit_rate_scale = ffs(channel->bitrate_peak) - 6; - hrd->vcl_hrd[0].bit_rate_value_minus1[0] = + hrd->vcl_hrd[0].bit_rate_value_minus1 = (channel->bitrate_peak >> (6 + hrd->bit_rate_scale)) - 1; cpb_size = v4l2_ctrl_g_ctrl(channel->mpeg_video_cpb_size) * 1000; hrd->cpb_size_scale = ffs(cpb_size) - 4; - hrd->vcl_hrd[0].cpb_size_value_minus1[0] = (cpb_size >> (4 + hrd->cpb_size_scale)) - 1; + hrd->vcl_hrd[0].cpb_size_value_minus1 = (cpb_size >> (4 + hrd->cpb_size_scale)) - 1; - hrd->vcl_hrd[0].cbr_flag[0] = !v4l2_ctrl_g_ctrl(channel->mpeg_video_frame_rc_enable); + hrd->vcl_hrd[0].cbr_flag = !v4l2_ctrl_g_ctrl(channel->mpeg_video_frame_rc_enable); size = nal_hevc_write_sps(&dev->plat_dev->dev, dest, n, sps); diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/nal-hevc.c index 9cdf2756e0a3..575089522df5 100644 --- a/drivers/media/platform/allegro-dvt/nal-hevc.c +++ b/drivers/media/platform/allegro-dvt/nal-hevc.c @@ -210,14 +210,9 @@ static void nal_hevc_rbsp_vps(struct rbsp *rbsp, struct nal_hevc_vps *vps) static void nal_hevc_rbsp_sub_layer_hrd_parameters(struct rbsp *rbsp, struct nal_hevc_sub_layer_hrd_parameters *hrd) { - unsigned int i; - unsigned int cpb_cnt = 1; - - for (i = 0; i < cpb_cnt; i++) { - rbsp_uev(rbsp, &hrd->bit_rate_value_minus1[i]); - rbsp_uev(rbsp, &hrd->cpb_size_value_minus1[i]); - rbsp_bit(rbsp, &hrd->cbr_flag[i]); - } + rbsp_uev(rbsp, &hrd->bit_rate_value_minus1); + rbsp_uev(rbsp, &hrd->cpb_size_value_minus1); + rbsp_bit(rbsp, &hrd->cbr_flag); } static void nal_hevc_rbsp_hrd_parameters(struct rbsp *rbsp, diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/nal-hevc.h index eb46f12aae80..afa7a9d7d654 100644 --- a/drivers/media/platform/allegro-dvt/nal-hevc.h +++ b/drivers/media/platform/allegro-dvt/nal-hevc.h @@ -97,9 +97,9 @@ struct nal_hevc_vps { }; struct nal_hevc_sub_layer_hrd_parameters { - unsigned int bit_rate_value_minus1[1]; - unsigned int cpb_size_value_minus1[1]; - unsigned int cbr_flag[1]; + unsigned int bit_rate_value_minus1; + unsigned int cpb_size_value_minus1; + unsigned int cbr_flag; }; struct nal_hevc_hrd_parameters { From patchwork Tue May 7 13:18:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B5B3C25B5F for ; Tue, 7 May 2024 14:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yOxSJPYMVILXVHKr9QFGiN3vyCzsOlNMM+g8RZc0kjs=; b=wK9HrLs6L+d+/B 680k1LM0h63KBlpX9cBekKMzajXM2MGrANZcEJ6jTw3AH4VtOUWbTGOHoMD08ZC3HzGMODGQf7DSl X936DnHa5qENkg+u4Y85rKuEZtEyKT2AAyY6PLmoJfm6C7WRXOYS/oI2UZlGLpoVbR4ntXufSW7WL 9mvWKazHxHw1zeXqVreyGMlYQNfjCLupOPX+z9TdzO3joqi1Mf10H8I/Dd+vaFZbQlSsO4vRZw5/o 6lIkYkXHfloDQGppiqrtCk8rUr6OfHsi/mwQYhFJEJs6Zetlpyx7bcKSTtNo3oz7IYzEolCKTD9zn YDf1sMpwdx6DmUTT09BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4LqH-0000000BVif-03YC; Tue, 07 May 2024 14:30:53 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiI-0000000B9jL-2gZ1 for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:42 +0000 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-43ca9047bd2so39274561cf.1 for ; Tue, 07 May 2024 06:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087912; x=1715692712; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dp/a3NMmYGz+hm8qsmJibF9yTx35ajv4b4FGHxOOJ3Q=; b=dotJ9KzRMQmjBKyyj0rToug4zCxjr5vD6i+Hz2LqRnnH0jO5UbWEf9zhkPfJlT4PLI RN3OU3OIS3i1Y/Xc+1KDEZQCcydRCZmrJQ746OVSe3y8HPJj1NkXwSZjgYEirZLBjf5s +RzmwjFMOXuWASS/VW03wf5nZamiA9/5oAEsw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087912; x=1715692712; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dp/a3NMmYGz+hm8qsmJibF9yTx35ajv4b4FGHxOOJ3Q=; b=h2ILW5aP+F5itnnDUghOz7ucy+5uVWprSimhhyytK7qupC7KauV0tdG73PuqAvZlQD 0mwQN3roVUYg7dLCjN05K8T4VN2jf8EP1GISXZP8M1FGgIYV22Y9z8OXKC5Y/in/xny2 KMqPEL3tqx2qVey/aBYtC5f4TjtvbvikLWLbtmNhetLFhgHcNO9uYH52o3Dc9sIsCTAI 6agRYJpfiVFW96mDEQzf2ugPo0Xya4i/F4stOGZJKcgjeJor0sHC9XjbrSQzuPtnfemT RVDqPzp+gQA1HoNEcbjWPe45EZLthoV7NvzoFoX69cIWUIJHIup2aYwOBKVx4GXN6r0C HaXQ== X-Forwarded-Encrypted: i=1; AJvYcCXKC3yeg5yudtcGn5WG4rfYqJzVeY8U/fXoyScSObhxC8GK9sTnspnzgx3Cw5sb92UwXY3Pxa+5w6/PAc5MVfXqlOIezwP/T6wz+KI0opqhpf1WcgI= X-Gm-Message-State: AOJu0Yz98YxKxD5XzpknJ8JoTEUhF1z91YxkvcImAr19DoMqFC4t6Aud M88TKHjBJBRBamNftBeiHVXqxWJmuuam6mAHZJlBD7RPbTjt1yfy3l1qrilmPw== X-Google-Smtp-Source: AGHT+IEDglfo4F9kZks6VdwXO2dFsis27euicA9VsC2TmfkNWeTSlqrnmzGMgOLPrUCqKhp03xspNw== X-Received: by 2002:ad4:5ca8:0:b0:6a0:c242:16d0 with SMTP id q8-20020ad45ca8000000b006a0c24216d0mr4441213qvh.31.1715087911865; Tue, 07 May 2024 06:18:31 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:31 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:28 +0000 Subject: [PATCH 02/18] media: xilinx: Refactor struct xvip_dma MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-2-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061835_192850_0F5DBB26 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace a single element array with a single field. The following cocci warning is fixed: drivers/media/platform/xilinx/xilinx-dma.h:100:19-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/xilinx/xilinx-dma.c | 4 ++-- drivers/media/platform/xilinx/xilinx-dma.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/xilinx/xilinx-dma.c b/drivers/media/platform/xilinx/xilinx-dma.c index a96de5d388a1..a1687b868a44 100644 --- a/drivers/media/platform/xilinx/xilinx-dma.c +++ b/drivers/media/platform/xilinx/xilinx-dma.c @@ -348,8 +348,8 @@ static void xvip_dma_buffer_queue(struct vb2_buffer *vb) } dma->xt.frame_size = 1; - dma->sgl[0].size = dma->format.width * dma->fmtinfo->bpp; - dma->sgl[0].icg = dma->format.bytesperline - dma->sgl[0].size; + dma->sgl.size = dma->format.width * dma->fmtinfo->bpp; + dma->sgl.icg = dma->format.bytesperline - dma->sgl.size; dma->xt.numf = dma->format.height; desc = dmaengine_prep_interleaved_dma(dma->dma, &dma->xt, flags); diff --git a/drivers/media/platform/xilinx/xilinx-dma.h b/drivers/media/platform/xilinx/xilinx-dma.h index 9c6d4c18d1a9..18f77e1a7b39 100644 --- a/drivers/media/platform/xilinx/xilinx-dma.h +++ b/drivers/media/platform/xilinx/xilinx-dma.h @@ -97,7 +97,7 @@ struct xvip_dma { struct dma_chan *dma; unsigned int align; struct dma_interleaved_template xt; - struct data_chunk sgl[1]; + struct data_chunk sgl; }; #define to_xvip_dma(vdev) container_of(vdev, struct xvip_dma, video) From patchwork Tue May 7 13:18:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31CA0C25B4F for ; Tue, 7 May 2024 14:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YQW9nKVYWLAlTneeBCiw6Zcl6tMRyRyAYPeoayHtKhQ=; b=htNJP7dCY4c6Gp T+xy/OZL3OIXSYEfED0OxDtd3AppDG/yXH/TAQy5eG/uzatqYuEZnbr+vU05rsdz+RzPXAHlCqo2D pqjdwtkeiWOO4nOYXe7FNFfQvwf250xqIDVpsk6upkHpcjGb7xjWaDuUS4qDvIZpqkFa9ArGWu+En l1rz6uuJyfc0mHaBamsy7bN5lpMZm/ffvVVUgWAPHQxxA0XHQNK06B8pLIf8wq+Y3UjuYKxxWt+8A z5MySr5eIruxRUX+EycX2U2VY0MNxxcNJ3EcynUIESCyaRRt90Yc4IfbEYq+OlRc5IBfZoXcd4Hp+ Vvs8Qdu52eK1vUyU1SZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4LqG-0000000BViL-2zdf; Tue, 07 May 2024 14:30:52 +0000 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiI-0000000B9kG-2hoK for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:41 +0000 Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-6969388c36fso15047676d6.1 for ; Tue, 07 May 2024 06:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087913; x=1715692713; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2A/cdtQJ5ubVGGh9zBSnEjfvf8aW68DShS0IQqplaqg=; b=GlfimdwxT9aaN9phzqjMtFpeTdhTa2Rs2KNWXWqCY5geDCxaE1h3TM+wWujngRCWyv tG9/DWCZ5bKROnhFQw0EwTQ0CVbeAD0beFnjAaPgiWz8Zjx7WfflGoPeXMQSl64LvgZp IHOjpVXfA7EcCKol59dxJLliWEGJnfzdJ2yNg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087913; x=1715692713; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2A/cdtQJ5ubVGGh9zBSnEjfvf8aW68DShS0IQqplaqg=; b=Hy9MdE6ZHcjdxO4LKfsjfkl906ZPF0FxfXnXf6VA+wTTPhoz0kd5R2bRQ0W/xBJUgk NmSUcQiK7eeDbxvb0Lg2meQdHw/7cNkZTpk2pv0We7XuJlSebws6S/KyIUlq78wIPD4M /ysUfIfIJjgMaD6wVc+mCUplW/KpsPt1HPnilJqaWR1VwHBQOY7EnhP0MeO5m/Bf1qww RIum5yRqdzleHrNTQOrQGtCblXEtzHXjoWfpW4OdtaxYF9yB8ZGBwv4qpK69uOZzUUst nK4H1JsIcjEPOl3hEznCgq1r7kAYkhydeWBr7wC5TDkZVM8BPOoOhWRbuCBl82uRUu+n 973A== X-Forwarded-Encrypted: i=1; AJvYcCVe77CWIbGMUmr2GzzZ+0mi5yqlel9LkeJkIKEUD4Qj8XN0rn9HMc8pTIO361THOTPUwWQCjFlom1WZf1jDz1JylVlEpjUoIEDeDE1FK5quWX0Yzr8= X-Gm-Message-State: AOJu0YymeJSEs0sv3Auy0K/3cEy7V3vZ9T8wWVji4+1IJa8ogLsv6Q1w bSO1IhoJLAbzHwSO57wznDl1mUfRj6nF1AX5QGMMihaU1hv68/LwKihSANLD1w== X-Google-Smtp-Source: AGHT+IHQmC234jVmBfThVSOfa4/hAJa6mJSOT+8IOLfwmMAfT5gaNt64PTRiybToFecmCSMHrjM2CA== X-Received: by 2002:a05:6214:d8a:b0:6a0:7d91:8752 with SMTP id e10-20020a0562140d8a00b006a07d918752mr17005843qve.58.1715087912800; Tue, 07 May 2024 06:18:32 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:32 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:29 +0000 Subject: [PATCH 03/18] media: dvb-frontend/mxl5xx: Refactor struct MBIN_FILE_T MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-3-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061835_148891_57B64979 X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace a single element array, with a single element field. The following cocci warning is fixed: drivers/media/dvb-frontends/mxl5xx_defs.h:171:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-frontends/mxl5xx.c | 2 +- drivers/media/dvb-frontends/mxl5xx_defs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/mxl5xx.c b/drivers/media/dvb-frontends/mxl5xx.c index 91e9c378397c..a15c0438b07a 100644 --- a/drivers/media/dvb-frontends/mxl5xx.c +++ b/drivers/media/dvb-frontends/mxl5xx.c @@ -893,7 +893,7 @@ static int do_firmware_download(struct mxl *state, u8 *mbin_buffer_ptr, status = write_register(state, FW_DL_SIGN_ADDR, 0); if (status) return status; - segment_ptr = (struct MBIN_SEGMENT_T *) (&mbin_ptr->data[0]); + segment_ptr = (struct MBIN_SEGMENT_T *)(&mbin_ptr->data); for (index = 0; index < mbin_ptr->header.num_segments; index++) { if (segment_ptr->header.id != MBIN_SEGMENT_HEADER_ID) { dev_err(state->i2cdev, "%s: Invalid segment header ID (%c)\n", diff --git a/drivers/media/dvb-frontends/mxl5xx_defs.h b/drivers/media/dvb-frontends/mxl5xx_defs.h index 097271f73740..3c5d75ed8fea 100644 --- a/drivers/media/dvb-frontends/mxl5xx_defs.h +++ b/drivers/media/dvb-frontends/mxl5xx_defs.h @@ -168,7 +168,7 @@ struct MBIN_FILE_HEADER_T { struct MBIN_FILE_T { struct MBIN_FILE_HEADER_T header; - u8 data[1]; + u8 data; }; struct MBIN_SEGMENT_HEADER_T { From patchwork Tue May 7 13:18:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657062 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDBDAC10F1A for ; Tue, 7 May 2024 13:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BnvzN667+K1j+jfD1oZ2By0WG4Vnw968IrFif1l6WQE=; b=Ai5eMrdkndpNER pvmLNhi6fl5SeBpCZZ1UUrHDlwSx9ezirQJnGjJBi3qcQP2BD0baTFpWWMUflizILSWTvKJ0vTOq3 sew0G5ZABPY4OeZ8Z0SKuCrxPeIH1p8BxICtyOx8sBlT1p2OQcll1LVlNA0wCm9KhiM/H+MnJSN+F Y0h6sfYbIOhVYeByaBqRubF1vVGI8bM29kpsYIGfgIjCMng+qQRXARyYDl9KU/Hfbx9InP3lOcQ7S iKNMah2bMsfmJbkRCn6JYxroyBVN729bYRGRA3IzJqS0piWTwOpjpKSwcL4iReqkSMDAJ2SW0NDTW d00KOqs1TUx2yc/zetCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kmr-0000000BD61-1g0x; Tue, 07 May 2024 13:23:17 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kis-0000000BAGq-28gD for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:19:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=1/P1ujR64RjpeY3CCEbW1xPPMvUuqlT7weCmbLOLgyg=; b=ZLbjZJEGY/t4NUso1l9kFOKmxU 6FMiUBO3ThthCHL0RNvDm4tC9L9UsqiXeFfxZgJWGDnkRz6MIJIDZXohEH0zxtq7hOdi1hqQYXqQT I2rSaptlFGpul6kicpiuFZse9Jw5QjZ6Jceukawt8CZvD1DvH/3V0W/Crb4uFnBFocuKoSyAgKmXf qTFoKtu0iLyG/yMmF+i8hoCwxcvtQaQpAAYmGAf6NnAZ3pyLy5hdy36vwjygmApz24Hm+XWfmLuYe fY9AW+iRfBkCDMw1dAC61n1vLaXiECTxSXi94Tfit4SFCcNS9D3aGkCAV04yn++daZ4V+DykSQ6D5 DJmgWTAQ==; Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kil-0000000DIdy-3ltv for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:19:09 +0000 Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-6a073f10e25so18230676d6.3 for ; Tue, 07 May 2024 06:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087914; x=1715692714; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1/P1ujR64RjpeY3CCEbW1xPPMvUuqlT7weCmbLOLgyg=; b=Z6AFC9XYMf73b6Reuc5fWrAzCyIdGDAUDAFLfd9J0E1oDMy9zDDaL7EphOMtBSSDJ2 9oFJ9V9ykHxz/QSwg9tGKuUildjwg0JsW0mBUykmGAQJh06Ep4AdkAsYAwXebSLUlOeg K11lwKyFkZm1bgjJqioqojeOXFtZP6YDXc6Tk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087914; x=1715692714; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1/P1ujR64RjpeY3CCEbW1xPPMvUuqlT7weCmbLOLgyg=; b=r2aVHzrzTlu2dm6bPIZqegpnBVRtn9l21XzqWA491C2CoFbQGBoRquFWagfLIgqReD Ip89hYnN/mnQiEQ+yXNkMv8RPxkUj2xYQo7/IIKDWdYsN+WyZ4lHvYI9k7/PRgBcmAOH jAdpT8R5C5UgNQoEUQpE8e1RZq/wPJlX7ThQmN9zLrhBbpLVshzJrZlWdw842gz56Qfc iwGJuswUEG3Yf7qKW47cFur7q4V+8uAIMgSM7IDpVFo9XiTWaLJLWAmhSfSHw7BuLzQX PQkkiIbMY0JSmjpgukWnCx5ol4LlMy8eqkHriSQoR2A8W7R8EXsg5TQ5H20wfYht5x/4 2MQA== X-Forwarded-Encrypted: i=1; AJvYcCW0c3f6Qb9+OIlcx6c/kcZCHnRVsM6h2lkSe91NUxfL8cvG1uy8vDTRWvxaVEtwfZpnNiOkT1Ba/LnvRjtjW1yPnio7tXeaukI5ix8IfAxk0HlEJ2U= X-Gm-Message-State: AOJu0YyCxuH67XZuYiNw5S6dzxMvPweeHAglWUyWlbk4H1814OeL9t31 pXieL3nDZe+knmGNnk82dkwPWtxOTeM9j4hARgV+ohqNsxMh3nKljf9Ys+OW+Q== X-Google-Smtp-Source: AGHT+IEHmgR44JJkt0kGIzW7NOaECWfdPMcTxHBijYkMDjUQ//6R0gtSxgRSvy3DiBlPMd5HBstr/Q== X-Received: by 2002:ad4:576b:0:b0:6a0:6545:2306 with SMTP id r11-20020ad4576b000000b006a065452306mr15355570qvx.28.1715087913906; Tue, 07 May 2024 06:18:33 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:33 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:30 +0000 Subject: [PATCH 04/18] media: dvb-frontend/mxl5xx: Use flex array for MBIN_SEGMENT_T MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-4-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141903_961162_22E8C4D7 X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace the older style one-element array with a flexible array member. There does not seem to be any allocation for this struct in the code, so no more code changes are required. The following cocci warning is fixed: drivers/media/dvb-frontends/mxl5xx_defs.h:182:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-frontends/mxl5xx_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/mxl5xx_defs.h b/drivers/media/dvb-frontends/mxl5xx_defs.h index 3c5d75ed8fea..512ec979f96f 100644 --- a/drivers/media/dvb-frontends/mxl5xx_defs.h +++ b/drivers/media/dvb-frontends/mxl5xx_defs.h @@ -179,7 +179,7 @@ struct MBIN_SEGMENT_HEADER_T { struct MBIN_SEGMENT_T { struct MBIN_SEGMENT_HEADER_T header; - u8 data[1]; + u8 data[]; }; enum MXL_CMD_TYPE_E { MXL_CMD_WRITE = 0, MXL_CMD_READ }; From patchwork Tue May 7 13:18:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD2B4C25B4F for ; Tue, 7 May 2024 14:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wGeXZQ9Ul9l+8vbaRqcCa/GelSvbP5tj15V9xMhCHQQ=; b=dzRQIECNTACY7z 5TPD9iUFwf50aKBxSgNFX5mIR1ann00fZ54RsNGtpaL/Ny4Pv76Fxr+sfSBezMSuKE1Llt8YD8eRH DONhAsZnkRpEEym17RbGWXFoGiSQer2LwB2a0Fc1Bha5LTvBCiKMwLwkSxNMqnh6egz8tIbKUNn4Q ABsM5YHgi2WEWP4cxulm9jCajmC2IGetyFm5UtsiY0ZZ6ClP7UwNpvley2hnuW4ISn6vkfNpfwu7+ q658/R+1/ciSq4jnqPospREP7qBIzusHIeMKemHJxG2gKMF+SavUl9FzV5wTMWBCi6Jov4hkssD6y UqcGKaQymjGS+dLcGJTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4LqJ-0000000BVkg-1bST; Tue, 07 May 2024 14:30:55 +0000 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiK-0000000B9mM-1bFS for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:44 +0000 Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-69b514d3cf4so42886456d6.0 for ; Tue, 07 May 2024 06:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087915; x=1715692715; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yEp5ZozBkj0x9D1ws5SUxXE7DcMsbsSxhL1FOw8KqVY=; b=OzsKlRCRmSmZuU2LNMGm4eY6FgJCmWB9Fb34oS/YD4pq1o45/f3REkjJwT+TD8V4zU HRoH0f57ouFQ0y/0JDgRoEsaAD+AWaVADikbzqy7Z5VNdE9+/2+it00NbkxWsZ5mJO9H tjYwBcfxLTlzkxl5GXg3p7FWpMjmTKofYFuZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087915; x=1715692715; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yEp5ZozBkj0x9D1ws5SUxXE7DcMsbsSxhL1FOw8KqVY=; b=wWbCUmCPpic3vvV/bCKWSkknrZo4rL0R3j4iKG4/W5eGr9pcn1Acey0fpeQRVE7C6A DofXqvdsoG5obEgZqo0zswtwZ8yZM/0zYX0iumV4xDbGJDOsR3iQlNVjPWBcDDHVw3nR WEfkQBzz+YX1b983U3UO1qBjFCPZYIftWc/f4HLHr/9oCeLFqGHw5kCXmsZlgOTUvpDm kt9iUnSmNs6WTkK2sOAj/xo7A4kgNi9RhZRFhBJAwCnQiZsmdRAG+5qJ/m5JD0ClUj2z zD4mj9qsF1dbRAmKpt86qZH3V2TUXUTHhWxq5skKcu8bO2E7yUluBQOUpK9Zev2SIz1B cv6Q== X-Forwarded-Encrypted: i=1; AJvYcCVkbwqOu/kRyfLkkVTLIN4zJozASw/BIxTKmDpTmJGFXWsYfyhWl0SSwqvnpKF+PuvA3V4E/Vt+QWEWjmpcpDVOluPEyHZtgqPdun6BEL4kcm8VQRQ= X-Gm-Message-State: AOJu0Yx507wS4HqVZK7BzlhkkzRonBt4ad0tf3GwWpJNK4fJez6fsixB vBHFJEphYJh9ghRXIxT/DM/23Xfz/CFUCqgOF4htr5xVr5rvAeT3sIXbR0xfNw== X-Google-Smtp-Source: AGHT+IH9XIpdU6+Gw+h8MPHG1GU0bBRHihk9hGC3h7gFftMNuTBDqQiQrQXelAgXIOFhdENJileoHA== X-Received: by 2002:ad4:4c48:0:b0:6a1:1f45:84b3 with SMTP id cs8-20020ad44c48000000b006a11f4584b3mr9905483qvb.5.1715087914592; Tue, 07 May 2024 06:18:34 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:34 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:31 +0000 Subject: [PATCH 05/18] media: pci: cx18: Use flex arrays for struct cx18_scb MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-5-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061836_587202_CD968885 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace the old-style single element array with a flexible array. This structure does not seem to be allocated in the code, so there is no need to change anything else. The following cocci warning is fixed: drivers/media/pci/cx18/cx18-scb.h:261:22-29: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/pci/cx18/cx18-scb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx18/cx18-scb.h b/drivers/media/pci/cx18/cx18-scb.h index f7105421dd25..841edc0712ab 100644 --- a/drivers/media/pci/cx18/cx18-scb.h +++ b/drivers/media/pci/cx18/cx18-scb.h @@ -258,7 +258,7 @@ struct cx18_scb { struct cx18_mailbox ppu2epu_mb; struct cx18_mdl_ack cpu_mdl_ack[CX18_MAX_STREAMS][CX18_MAX_MDL_ACKS]; - struct cx18_mdl_ent cpu_mdl[1]; + struct cx18_mdl_ent cpu_mdl[]; }; void cx18_init_scb(struct cx18 *cx); From patchwork Tue May 7 13:18:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D24B9C25B4F for ; Tue, 7 May 2024 13:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3Bv8sku/fvFolzv6/Usepw1V8DhwKdepeW6smjyhsYY=; b=nLvkT3CUhazVqU k+pacA/q83LVGtgDk96k8TMS8HNuPcdjm3aOe03sYmLnsWN6S9y2dFt5ytQAb6I4N2n37CWmaX6+D KHjk95JizREtXiV/EZcm1uA8loK9Xdbu8lP3mXfsRXp5J9269SuYuPWqr2OFjK7YQgL9gSXdzQ4Ag cxyDohAK/rtvRnhk3cQzilvlhhDsukbbcQj4iDbqf3EFHdpIMufoDidKF5oaP5KgHx4LYaNolLJlP B72TNiXNbesNn6x9X3PqCIvzFjt/WUwGsbIgedPKTKyI/FAon7IY6NivoByPttBpSNHryAM8H0hlS 3tjpu6pRfvlTk8vjwrwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kjh-0000000BAvJ-3rOt; Tue, 07 May 2024 13:20:01 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiK-0000000B9mu-3vSZ for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:45 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-79291d441fbso286951885a.0 for ; Tue, 07 May 2024 06:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087915; x=1715692715; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o/4oby1OzvPbisoZWbigQhOZs4utcCTPvU7cAHaoXZY=; b=iHdewvW2EEAt/lFCU/sKRcneOLkda/ooI+pKursG+pYrCUOcuGkHrlREi7kxFTN2qu zUCOe1RNIzPzDWvIZ8iCLfD0IPH6UX/vWsUD8txotdSXzW3hVs6VTjnHWDDuIXRKyFBu XdLgeTc2hKjGuYLPFFMFgGs1jqDgDYvkwuwgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087915; x=1715692715; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o/4oby1OzvPbisoZWbigQhOZs4utcCTPvU7cAHaoXZY=; b=UeaqhUUnGnSuTWBM4fRMm8t0uwmum0eNaktoj2kP6cNo6Dkn/AJpP5u/zFvcUT8FYK 6pcmou9m9JvhoTdBMLM0Jpm71Fyvn+5ktqtJarpHg1YrUY2Y/otMRoQpKEra7XBidX8t 1DXXJw1bmy3L8OOjM/QzhjHGfQFlLr9nWnHxAcyDT2F7ZPaefDTTt2k1CqhuDby0Df+/ kxBixi+afzDOnkLDIDr9E6ZgwHZmhLhgM/Buk97fwXasThw1Qlu4RhRU+kp10Tx4q6Va 3tvcqejtKG6pjftINVvLLtB2F7Ba7fEZuFZoDuDYWe3eS2E2DP44fjocQZidpPebAR1x WUCw== X-Forwarded-Encrypted: i=1; AJvYcCVwVvzMJ8UpQAe+w/Tm2RLhWfjDffkfL8lvblvUIrkeJdsx5LjZD275yT6l79W7KzTorc2tkJtdsaoe4WPOXV0u8ErmELSOa+MFaoJvEVQv4iiS7tQ= X-Gm-Message-State: AOJu0YwBMfGctm7LJkQOzQxdHpxGOjPZrFYh3YtHgRE8wezhch9juzTS ZSJFqDo912EJ6+YraEkAW/aPs8lS1iS3sbS4A+iNdve6m8oq+Tukw8n0hnU6naAxmBxB5nO5oCL 1dg== X-Google-Smtp-Source: AGHT+IEwGqKCP2RodY96Q7BvikThgfGTcpEIa62+nhVbtzbMCCA4jSL8KZCOlBJ4ow7E8ohEtntOvA== X-Received: by 2002:a05:6214:2401:b0:6a0:cd2a:8ae2 with SMTP id fv1-20020a056214240100b006a0cd2a8ae2mr15077797qvb.21.1715087915445; Tue, 07 May 2024 06:18:35 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:35 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:32 +0000 Subject: [PATCH 06/18] media: siano: Refactor struct sms_msg_data MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-6-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061837_251605_34DA6427 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace a single element array with a single element field. This fixes the following cocci warning: drivers/media/common/siano/smscoreapi.h:619:5-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/common/siano/smscoreapi.c | 10 +++++----- drivers/media/common/siano/smscoreapi.h | 2 +- drivers/media/common/siano/smsdvb-main.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c index 7ebcb10126c9..b6f1eb5dbbdf 100644 --- a/drivers/media/common/siano/smscoreapi.c +++ b/drivers/media/common/siano/smscoreapi.c @@ -839,7 +839,7 @@ static int smscore_configure_board(struct smscore_device_t *coredev) mtu_msg.x_msg_header.msg_flags = 0; mtu_msg.x_msg_header.msg_type = MSG_SMS_SET_MAX_TX_MSG_LEN_REQ; mtu_msg.x_msg_header.msg_length = sizeof(mtu_msg); - mtu_msg.msg_data[0] = board->mtu; + mtu_msg.msg_data = board->mtu; coredev->sendrequest_handler(coredev->context, &mtu_msg, sizeof(mtu_msg)); @@ -852,7 +852,7 @@ static int smscore_configure_board(struct smscore_device_t *coredev) SMS_INIT_MSG(&crys_msg.x_msg_header, MSG_SMS_NEW_CRYSTAL_REQ, sizeof(crys_msg)); - crys_msg.msg_data[0] = board->crystal; + crys_msg.msg_data = board->crystal; coredev->sendrequest_handler(coredev->context, &crys_msg, sizeof(crys_msg)); @@ -1306,7 +1306,7 @@ static int smscore_init_device(struct smscore_device_t *coredev, int mode) msg = (struct sms_msg_data *)SMS_ALIGN_ADDRESS(buffer); SMS_INIT_MSG(&msg->x_msg_header, MSG_SMS_INIT_DEVICE_REQ, sizeof(struct sms_msg_data)); - msg->msg_data[0] = mode; + msg->msg_data = mode; rc = smscore_sendrequest_and_wait(coredev, msg, msg->x_msg_header. msg_length, @@ -1394,7 +1394,7 @@ int smscore_set_device_mode(struct smscore_device_t *coredev, int mode) SMS_INIT_MSG(&msg->x_msg_header, MSG_SMS_INIT_DEVICE_REQ, sizeof(struct sms_msg_data)); - msg->msg_data[0] = mode; + msg->msg_data = mode; rc = smscore_sendrequest_and_wait( coredev, msg, msg->x_msg_header.msg_length, @@ -1554,7 +1554,7 @@ void smscore_onresponse(struct smscore_device_t *coredev, struct sms_msg_data *validity = (struct sms_msg_data *) phdr; pr_debug("MSG_SMS_DATA_VALIDITY_RES, checksum = 0x%x\n", - validity->msg_data[0]); + validity->msg_data); complete(&coredev->data_validity_done); break; } diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h index f8789ee0d554..46dc74ac9318 100644 --- a/drivers/media/common/siano/smscoreapi.h +++ b/drivers/media/common/siano/smscoreapi.h @@ -616,7 +616,7 @@ struct sms_msg_hdr { struct sms_msg_data { struct sms_msg_hdr x_msg_header; - u32 msg_data[1]; + u32 msg_data; }; struct sms_msg_data2 { diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c index d893a0e4672b..44d8fe8b220e 100644 --- a/drivers/media/common/siano/smsdvb-main.c +++ b/drivers/media/common/siano/smsdvb-main.c @@ -689,7 +689,7 @@ static int smsdvb_start_feed(struct dvb_demux_feed *feed) pid_msg.x_msg_header.msg_flags = 0; pid_msg.x_msg_header.msg_type = MSG_SMS_ADD_PID_FILTER_REQ; pid_msg.x_msg_header.msg_length = sizeof(pid_msg); - pid_msg.msg_data[0] = feed->pid; + pid_msg.msg_data = feed->pid; return smsclient_sendrequest(client->smsclient, &pid_msg, sizeof(pid_msg)); @@ -711,7 +711,7 @@ static int smsdvb_stop_feed(struct dvb_demux_feed *feed) pid_msg.x_msg_header.msg_flags = 0; pid_msg.x_msg_header.msg_type = MSG_SMS_REMOVE_PID_FILTER_REQ; pid_msg.x_msg_header.msg_length = sizeof(pid_msg); - pid_msg.msg_data[0] = feed->pid; + pid_msg.msg_data = feed->pid; return smsclient_sendrequest(client->smsclient, &pid_msg, sizeof(pid_msg)); From patchwork Tue May 7 13:18:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657051 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14D2BC25B77 for ; Tue, 7 May 2024 13:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DOhoLbbLSacaop6Yur4t6X8Amzgi/yV85uJqpgy474M=; b=JhkSoDI0UOPZQk 8VJgtkm+Pxvmj80OJ6mHw2+AEb//4zxJSPIchNZz7GHPyKCs1ZCiIpkSwOHGJcU7f4ir1s52kUAYZ Deagbgxw0qh5KlOPJo/e5UfWOMbMjGJhfHsAy/WJtajZAZscBIPL2jNIXJFRoJwUbBzyvLZzyM4bi 22uwfCcTKOHY57+d1CzHC86BOOw32ydwIZqk0XMK2RkWaVed+1BQiyhQ3svY/KdAaby/YHxygDuKr y6LkIoC89QU3KfGItzUXS9J6nbfT2+kEqYEpl2JIPSDaSgZRlBlEP1JoLvGTtKpfJSlghNM+IbTzw fmLgbZAJ6FdhMgUtAB4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kmj-0000000BCzn-1HbZ; Tue, 07 May 2024 13:23:09 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kin-0000000BACG-1XQd for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:19:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=bajBIKBKiGkzVrECr+DrCDdr2oyOzpQYYR0WAIoyaos=; b=GxOhnzEqZZ8crWKC4Ge7kVvG9E SGbYlw30apHHhq/0pQ+mQVn4cImw09AY+LeBriAGmibjhoc0tg4q4q9kH8x2VslaKt9wjrUrKcHWm 1fQZOc690MyRW71Rljv8Bq7p2Y2MgcxDG7PddG4bUnGlt8pBcU5z/LTrv6Hv6Purqg/l2jDeECVCu wmpQiWxaUflLFDCCdvc7rQuArvlGbSB5Rx1ggZlLjDuNu+sD8Zo1vjgTRH9QmwoNyfQg/MLiPrVdE 2MTiw9I4+90jOaNY1838xPCQASVVZ/TM7pUc6ANPL6xTXBXGRktaTYT9AzTpG215Icuba+AViiMxU 8hI3+Hiw==; Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kii-0000000DIaW-2QQh for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:19:04 +0000 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3c97066a668so644906b6e.0 for ; Tue, 07 May 2024 06:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087916; x=1715692716; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bajBIKBKiGkzVrECr+DrCDdr2oyOzpQYYR0WAIoyaos=; b=KlmGerX+c7B3ss2qtXQRRCkiZi1XjX3VWUiYLkxOZBkt4rKNUWzz0KcIVVfu4dPbB4 iJYdnmCb/8OsGNjs6p7+s1RZP9rIGKRDfB6ke1Whz0SNoCEFgPnYRpFuKqUjrLPqV95u K1YBJc6tmlk30tw21wuJxDXXasquQW0kfp3Yg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087916; x=1715692716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bajBIKBKiGkzVrECr+DrCDdr2oyOzpQYYR0WAIoyaos=; b=PG1ApateSOs7w4cccmTaxzEiXdX8mfCcXYc5m+Sy8dHMY+iHEjY6mF8ohC5HQ5+pp3 2nBI/ASW/H1/HEVXPzozkuEaKY+jQFC+27v3BCBmtMFA8+doGsvnlAhtUlg7jLUIurir qFbdbW3z8vu0oWgHsp8MTZfAStGf0T2BSscwDHGAVFqPg28QQUtRJpwUSKrUjN4Wr/Fr s1Q7NWT3qZxsqfCoIPXO1X9UTuTMHGuWRG82t2097m71JzqicQDGf+JLFrGt6zrhTaIF uRKVq5+NFz5YsBuRQ75dObYP545Mr6mmQBDjPYh5G16RwIobe5LswR83R8TDNlVSu+wK GvkA== X-Forwarded-Encrypted: i=1; AJvYcCW7g+1wggK3Cm4VLsYZzi/kiVie6RfUybpFnaradouB2jn2m5SC5zDmk+53bdaFvsBppz0gqxKR9WgUGyUmaLDj/d1EhDDmHPCltFWRlCb9m7ZFRS0= X-Gm-Message-State: AOJu0Yzw5rOm6pE3XxQxrHAjWkQ+h7cvmaW5YI2qm3lcVODAfL1G6Yck AUr64R5ChMMRD6982AGFy3/ZqvuFUPb4a0Q7ssuq82DpTdxjs8uQae9QZAImUw== X-Google-Smtp-Source: AGHT+IEfgZc+3NqAZNZgDbuMWn1SodDQc1fgSaycXBKpVQJhCw/vqcobpSG60CD78oLq4SUhp6OVxQ== X-Received: by 2002:a54:4195:0:b0:3c9:6e70:cf99 with SMTP id 21-20020a544195000000b003c96e70cf99mr5053014oiy.57.1715087916576; Tue, 07 May 2024 06:18:36 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:35 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:33 +0000 Subject: [PATCH 07/18] media: siano: Remove unused structures MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-7-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141900_687267_397D66A4 X-CRM114-Status: UNSURE ( 9.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These structs are not used in the code, remove them. This fixes the following cocci warning: drivers/media/common/siano/smscoreapi.h:1049:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/common/siano/smscoreapi.h:1055:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/common/siano/smscoreapi.h | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h index 46dc74ac9318..bc61bc8b9ea9 100644 --- a/drivers/media/common/siano/smscoreapi.h +++ b/drivers/media/common/siano/smscoreapi.h @@ -1042,20 +1042,6 @@ struct sms_srvm_signal_status { u32 request_id; }; -struct sms_i2c_req { - u32 device_address; /* I2c device address */ - u32 write_count; /* number of bytes to write */ - u32 read_count; /* number of bytes to read */ - u8 Data[1]; -}; - -struct sms_i2c_res { - u32 status; /* non-zero value in case of failure */ - u32 read_count; /* number of bytes read */ - u8 Data[1]; -}; - - struct smscore_config_gpio { #define SMS_GPIO_DIRECTION_INPUT 0 #define SMS_GPIO_DIRECTION_OUTPUT 1 From patchwork Tue May 7 13:18:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F07E7C10F1A for ; Tue, 7 May 2024 13:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QaO2bNnF968t7JXaftnAFuEpo1t26tO8D7IcFSYv0GE=; b=Ngdp43VgoVFoDS Jrxlc+v44fpkhiUjgsAEFLgYGDZvXVH0ItiO3GBG8UbYrlfe64/R3CFANz3IyEs60ooN01CLmjKof btSpe6Udtx0KSqRGppKm+t+A7CmxcL85XDGA6a66b5YfkP+FiacMMDTI3yKJewAiA3y3PKYayKdfp YtcAo8OTABYvjkPy0AEf15rM+rkyfNRK98bzZMPUnqaDgfThUNHCiwQ+LDshZhiTrIfjCkhWPY4Yg uA5IL8tv6/vBpzF4ShWQMAho57Z0rVVifBDDUc2Ps6LGRgUmDUX2/m4YXfuD3pi5raR5D4q83tK3m cSLcBsRoIASVpU/xPJ5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kmm-0000000BD27-2DdO; Tue, 07 May 2024 13:23:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kio-0000000BADr-2JBM for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:19:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=JKfhOSoHE1VqyRhgB0xYInvnK6a8zz5LZUqmCULZe+M=; b=o5jwnc/qva2tTLUsJG/VAZ3Htb /4D0BmJDvTZcSp2QJWB34LPZjJLFQj5Tew0zLqy2fdADpUNVS/lIb3Mzf3DC7yWfQheDbm1w5wwWn OKgsJ3NKUMVc9WRhTOh2M9ra3WoKHNWDIuRrSIKSjKCtwMgWOQtksdNivv/V4PTWueNd19WT9p7aT CdRfMgc1aozRJZK6ySGDtQtpEa9I2sBqtoE85gOQgvW0lK3UxxFOmAb6HxcsLXmtvr+85A6XP8W4X SzB0ZDlaPRxc5BQGWYxYcdkSbjXV3lKS4eXjHW6WyJ2z4jvzv/fPVpda6LPVi6yPTldzmdOPP385K Ou3O+LmQ==; Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kii-0000000DIac-2RWz for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:19:05 +0000 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-7928ec5308cso288067285a.1 for ; Tue, 07 May 2024 06:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087917; x=1715692717; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JKfhOSoHE1VqyRhgB0xYInvnK6a8zz5LZUqmCULZe+M=; b=jboO69SdzgaJshs9ffExsz/m+4Eon26eAq3qp3yxRCwc73B1unCE7m5+PKP2InRc+Q ryZQLYZGfmwD0Nf5xwqlYLISNWW5rbClImeMxrrt+UqnjXZraeFUXKWKZ9FpbtOj03pY 1U1jFQzINJ1z/equrjIYJCyI7cJblev5jcfSY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087917; x=1715692717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JKfhOSoHE1VqyRhgB0xYInvnK6a8zz5LZUqmCULZe+M=; b=CAB4+bBoELDPhDaBMWfDuawg9xoC5ZIO/8IszBHr5h7pemnEUQRkHPQGFPq/+nb8lD XqL2lSbva97tQJbDtw+lVwLpdnd4XdtxSmdVCPpdjK7UwZGQ0VpTP3rR2nvzwLCsr6N1 7fOwQU/1GuSdZ+NEfKWLMWD5nxQ5L6f9I1nszBQfKFrr7kC7yjr2O/yQvPwx/CdmQIfz QrvapFn3ElpcTtp+tbLxyOcgNUbVY/qpb90xEu0QDR0Co3WhYUn9MnxHGmi5qxm1PkV3 li3syoIcoa4XrWx+4YR0l/L2tkeEC+3EnY2CIDEAOb8J4zTf74qc7spnuTZAQHAfnn5E WJaA== X-Forwarded-Encrypted: i=1; AJvYcCUXBbuqGdBFnh5COZR7Zu55xre5CltRAckBz1l0nXBKtgvDD79HM6OQXZ3fLecGJUOxhsC8P/mAYJkdWHy669TgiKw3hRAi8HQLLxp9VxeLOZNrFtU= X-Gm-Message-State: AOJu0YwnfWKuJIV5EOXTLnvZ63VahYSX7CbHnL+fqjYloXDGNrM6hY4a 1A62fkdm+jmU4+2f/sGbYx4jVNb20/9ZIqCo78Fs1Pjahfhsgv4VCpPsyqUf4A== X-Google-Smtp-Source: AGHT+IFKliypIzu0YjFcg14a69MBEAau+ZXpSAYRUE5dq1ueGc4ePsCBbZXpGGTph+KzlVWTljAkDg== X-Received: by 2002:a0c:e082:0:b0:6a0:f637:667 with SMTP id 6a1803df08f44-6a14600e407mr45875746d6.12.1715087917380; Tue, 07 May 2024 06:18:37 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:36 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:34 +0000 Subject: [PATCH 08/18] media: siano: Use flex arrays for sms_firmware MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-8-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141900_724591_7AFBF7A7 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace old style single array member, with flex array. The struct is allocated, but it seems like there was an over allocation error: fw_buf = kmalloc(ALIGN(fw->size + sizeof(struct sms_firmware), SMS_ALLOC_ALIGNMENT), GFP_KERNEL | coredev->gfp_buf_flags); This change fixes this cocci warning: drivers/media/common/siano/smscoreapi.h:669:6-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/common/siano/smscoreapi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h index bc61bc8b9ea9..82d9f8a64d99 100644 --- a/drivers/media/common/siano/smscoreapi.h +++ b/drivers/media/common/siano/smscoreapi.h @@ -666,7 +666,7 @@ struct sms_firmware { u32 check_sum; u32 length; u32 start_address; - u8 payload[1]; + u8 payload[]; }; /* statistics information returned as response for From patchwork Tue May 7 13:18:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C81A3C10F1A for ; Tue, 7 May 2024 14:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NeruxJp++s2NcFSdstSug3PAIF9/9TqUukR2T/0X+9Y=; b=YuMmai3Qt+5dVR gkR5Jb/w41ZfvVXDchPy9PT1z5cLfwbN5vboky/mf0cX1oHsMtiiqrgagbdVKzD42Ly3Q2PKLZ9RX 3LwppRjhA5dLEdNqdhSiHgHMX5XqZVCcVF/mBAxMske/1/AuqTKKEk6xj+lRB5pVugln5ToPxccud sBnKQjG+08v9R7lPUd4AGJNm4J2Hvu84GOAuJm8AH1uCBwE8fOdGLP6dgYHE+vST365F81F8u44RG NnepUjmKrxi5rnEF7yGR/SWA9wYY8nFQakLXLeN3i+qWrMOLKmxasLgdQavwWnt2wvLZ+BRfDK/Np OfLOv9FGuVhlD6aCRUYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Lqf-0000000BW4L-3abn; Tue, 07 May 2024 14:31:17 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KjB-0000000BAXi-45M7 for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:19:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=kaj6FcAMdKWO/HBrdvIpPTLyis7BoUMkhPcms6B+rAo=; b=e/rHTiFEBrOLjnupd6/dLSj/c0 HVyButQVbpYuxE8TsKjn7AXfDiDOlQQrrh6SNzqeghp0ijggY71OBET5/Ml4ILMSk5ssF4BUxETBm d7KL+RJpHmmaRtNpM5YZa57fhIeZDnCcrwYeHvFjkJfNnACLy3mz2muIKzb6ayiDOYq7tyf2s/S5m Krq0unymXzuzXcznV5NS78lROLBqGDeoZXPegBDJS135yTRAGEwVpEKimnjQ13KEThgOiLhvyyjdA +FIFklH8rRlcyAvM9jdwOXo6VoBi2CNWN6EMDF+0ol/Gl17w4pE55uMLNCH/4NSy08eW//+hPTCJx qaJ6NA3A==; Received: from mail-qv1-f42.google.com ([209.85.219.42]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kiy-000000026HM-2Fgg for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:19:28 +0000 Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6a073f10e8eso12915876d6.2 for ; Tue, 07 May 2024 06:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087918; x=1715692718; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kaj6FcAMdKWO/HBrdvIpPTLyis7BoUMkhPcms6B+rAo=; b=dcTG8NPj2jWjk4LRlrKk4X0BrngretQ4YwfnVNPo5U7EDq+DfQMK4a6phngBhoGD5Y HDnCI+ane20WV5PNw98c28RNZZsogUy71/m+KtBfkXP2yWylKArK6NKQZQ5WvsDAm8JI A/IfpE6b6EjQDgSNSaN2wzWCyx8IBmcXaunzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087918; x=1715692718; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kaj6FcAMdKWO/HBrdvIpPTLyis7BoUMkhPcms6B+rAo=; b=fNJ9Fk4CJuhKYMqWZqOSy/pSIhvFbB9Q+LyurkzLrWPVcrLkSrIPs+JGZIfmRLTgeG KRVmBIvsgSMbyJfyt6RkBbEgzR7NnebVOz7AGdo0lSTH7FAhNfiLCJy/PywLAYAMIhE/ oMex6oK8w5qgIvVKhdtEGOM/4IEwKC9q94NxXB6xTTU7qmgGHlDpIGK0dCCIUDblbWXw 61VrxHVQA8QPEj6QXsmOiIfcXYO9rdlLNQqsgVe0+1HzUnRQAmpBG50zu6OrLTkXirS6 PNnk+QDNXaHBczyeBqNCIPz5Z6s9lGQDnumwvcU1/7Q46x47mi65HVLOnhMUfcjDdL4B I9xg== X-Forwarded-Encrypted: i=1; AJvYcCWu8fGh4uv0Ivcp+Dfgp6C/f8iKQVgbeQTTQxTCv3jL0x1gU5SW8zgngcLdv+QmN97+GOlPT7yifBiRIsO/1EOqolDMqSlms1Qsv7KI5yz2H/UAkRE= X-Gm-Message-State: AOJu0YxWE6nRrimEuJwk4HzWf3bpOKOG5ke0YU9V6UZA5iV9jKaI0gM0 QnmSgooAukZ89JsQb1eB6zczTKjJd6y4+dGjC8QmPbVrlfIQzReYD0uxwBoR+w== X-Google-Smtp-Source: AGHT+IFE9fQ9HKDwH26yKAPAZM/6TAnCx7pGdD2pD8NawZpJRVZDBF6akmAtnEWwGOg/Xa6r/F29MQ== X-Received: by 2002:a05:6214:e69:b0:6a0:cd65:5996 with SMTP id jz9-20020a0562140e6900b006a0cd655996mr15329957qvb.8.1715087918540; Tue, 07 May 2024 06:18:38 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:37 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:35 +0000 Subject: [PATCH 09/18] media: venus: Remove unused structs MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-9-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141925_589652_9F536EB6 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This structures are not used, and have a single element array at the end of them. Remove them. This fix the following cocci warnings: drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 26 ----------------- drivers/media/platform/qcom/venus/hfi_helper.h | 39 -------------------------- 2 files changed, 65 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index 20acd412ee7b..41f765eac4d9 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -77,14 +77,6 @@ struct hfi_sys_get_property_pkt { u32 data[1]; }; -struct hfi_sys_set_buffers_pkt { - struct hfi_pkt_hdr hdr; - u32 buffer_type; - u32 buffer_size; - u32 num_buffers; - u32 buffer_addr[1]; -}; - struct hfi_sys_ping_pkt { struct hfi_pkt_hdr hdr; u32 client_data; @@ -171,24 +163,6 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pkt { u32 data[1]; }; -struct hfi_session_empty_buffer_uncompressed_plane1_pkt { - u32 flags; - u32 alloc_len; - u32 filled_len; - u32 offset; - u32 packet_buffer2; - u32 data[1]; -}; - -struct hfi_session_empty_buffer_uncompressed_plane2_pkt { - u32 flags; - u32 alloc_len; - u32 filled_len; - u32 offset; - u32 packet_buffer3; - u32 data[1]; -}; - struct hfi_session_fill_buffer_pkt { struct hfi_session_hdr_pkt shdr; u32 stream_id; diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h index e4c05d62cfc7..7c0edef263ae 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -759,11 +759,6 @@ struct hfi_multi_stream_3x { u32 enable; }; -struct hfi_multi_view_format { - u32 views; - u32 view_order[1]; -}; - #define HFI_MULTI_SLICE_OFF 0x1 #define HFI_MULTI_SLICE_BY_MB_COUNT 0x2 #define HFI_MULTI_SLICE_BY_BYTE_COUNT 0x3 @@ -1036,11 +1031,6 @@ struct hfi_codec_supported { u32 enc_codecs; }; -struct hfi_properties_supported { - u32 num_properties; - u32 properties[1]; -}; - struct hfi_max_sessions_supported { u32 max_sessions; }; @@ -1083,16 +1073,6 @@ struct hfi_resource_ocmem_requirement { u32 size; }; -struct hfi_resource_ocmem_requirement_info { - u32 num_entries; - struct hfi_resource_ocmem_requirement requirements[1]; -}; - -struct hfi_property_sys_image_version_info_type { - u32 string_size; - u8 str_image_version[1]; -}; - struct hfi_codec_mask_supported { u32 codecs; u32 video_domains; @@ -1135,15 +1115,6 @@ struct hfi_index_extradata_config { u32 index_extra_data_id; }; -struct hfi_extradata_header { - u32 size; - u32 version; - u32 port_index; - u32 type; - u32 data_size; - u8 data[1]; -}; - struct hfi_batch_info { u32 input_batch_count; u32 output_batch_count; @@ -1234,11 +1205,6 @@ static inline void hfi_bufreq_set_count_min_host(struct hfi_buffer_requirements req->count_min = val; }; -struct hfi_data_payload { - u32 size; - u8 data[1]; -}; - struct hfi_enable_picture { u32 picture_type; }; @@ -1267,11 +1233,6 @@ struct hfi_buffer_alloc_mode_supported { u32 data[1]; }; -struct hfi_mb_error_map { - u32 error_map_size; - u8 error_map[1]; -}; - struct hfi_metadata_pass_through { int enable; u32 size; From patchwork Tue May 7 13:18:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657034 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5D67C25B4F for ; Tue, 7 May 2024 13:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sXQiJjTM84JxC0wfuVBr5hJf9W/E/s5ZFdsaAZRhT34=; b=Oww0Xxsj+sN02y CMOcUe98iaYwUeurXF9Ljs7huuu7U9M10lOKLN+XZpeJIjPrrqstkZsZs9CRw/CzzxLkxnGiudTGj 8/LSAefYzRx9cO3OtrS1qfCsOiWZtDuhAi5DY32JNil0eBXn851JGh1LBoE/mT0GF6OdyxTsRvwJR Or9TfG7bckXEs8e85pKpAfxeNjPipg/LWIYA8oE+/aao8WSQrvZdJN9c6e/tVDaqGr2/A7gaMFF6a KY8Gr4tGK/Gzyjuh7cDyyGVIWaJA8btpDsmWvOxLWpNzObUClSBt89FDa4CFcQlYgwfLUCzukqmZM A4bA8Xo1PvZjaR61nJUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kk3-0000000BBB8-3dRQ; Tue, 07 May 2024 13:20:23 +0000 Received: from mail-qk1-f171.google.com ([209.85.222.171]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiP-0000000B9qr-3pqp for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:48 +0000 Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-79291d441fbso286959585a.0 for ; Tue, 07 May 2024 06:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087920; x=1715692720; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WR87o59ttHnNvNigBqZHzwph/s3gT6BLw9Ga86sRtPA=; b=CCBEAUCmVQCV4HgUb7ikTuzL+/REumiSDhlefIq4y0RuGg9V1ef3alMUMvmKRn4ocz Ivc0tWd/kCSelrHvCwJLXsZ3P0LFvoc0wSBm5h/wdrPeC2v/dvLpJc0nPjX4WH11/+c6 z+EUgZLe/Q8aiyBKNB0IkcEHElGU34R89Gvzg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087920; x=1715692720; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WR87o59ttHnNvNigBqZHzwph/s3gT6BLw9Ga86sRtPA=; b=GabedgyKK7vMGgtAuBuFvbK2YlKfxiG0WcttUv2hnWmzjr0IU9ENIXwYGwmJIahhSb Xw0DaKK1cX7m0CK6vno09g+gWWz+AYfOya+c58WO/hImRADiI0/2k8eATfqUjauh2H8+ ZmHunVyH3ibhdZXEsZHN5niDxzwcTdkMWli2xLFbPm6z60TpVEEJk2t+jPopZchelL/A Ej9QsWL0ZmAGZKv7fxyrqvs5Sej+gjU9QTq80p3lRP1OPZMpnt/oNs8gdk2F90F79sWa Gi5iHg3rBYyzD7AgV6OxXO/yQsZvbrn0yvHh+oXooGA3dtdEEyuUnnnPe8+MhR5l2i1c 16Rw== X-Forwarded-Encrypted: i=1; AJvYcCV+ARqLV77703JtStmaJaOXNarLgukbed+csh7Gs4X8gAw3aogU1CpI+I1mQWeg7wU3bVP6MrJuQNC7JArt2E4WS5zODqfj5lsll87t0OSptOt3ZAE= X-Gm-Message-State: AOJu0YyM9B9Scy0Zp1aRLfU7Rg2O80to+iN/2HQ63VKDGdLAlfxBCXkC uyqvOaW6rWENM4VqMZJ2bpDxfdqP+x/y68ZwB2xmxuedyGEECRd91qBw9zA25A== X-Google-Smtp-Source: AGHT+IGatpIQRwE9h01tY7yyLZRrAcLmql6eJb+YKcxD2Wq6gpUB9pyNvjqWHkivGZUb+9PKsnvIcg== X-Received: by 2002:a05:6214:c4b:b0:6a0:def6:6c8f with SMTP id r11-20020a0562140c4b00b006a0def66c8fmr15390917qvj.47.1715087919625; Tue, 07 May 2024 06:18:39 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:38 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:36 +0000 Subject: [PATCH 10/18] media: venus: Use flex array for hfi_session_release_buffer_pkt MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-10-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061842_296208_C0161F32 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace the old style single element array with a flex array. We do not allocate this structure, so the size change should not be an issue. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:204:5-16: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index 41f765eac4d9..6dff949c4402 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -201,7 +201,7 @@ struct hfi_session_release_buffer_pkt { u32 extradata_size; u32 response_req; u32 num_buffers; - u32 buffer_info[1]; + u32 buffer_info[]; }; struct hfi_session_release_resources_pkt { From patchwork Tue May 7 13:18:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49080C25B4F for ; Tue, 7 May 2024 13:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XGa3ThgN/NchEDnAYE79VJL/C2b2q73NN+/wpuxb0no=; b=ZeNX8+a8CRwx+z F4S1bC0jRWka/no19wxX2tVU93/lVpJwwQUAcfYNDB7X8i6hzi9eGm2CgYuu9Zn7VLhMIDJljXJeH hNQkLXE7DsLjubvBFyD0qWtN5LE/HWCNgWNuOM8Pcs5k6+wbGwdAXBijhaiqDrb0Q806rAl0S4NE2 5qErerlADBFPuszM1DjM1OnkAuBH6JFkmbHjNmpT+tE6OMLjs0mL65kEQyMhhVxQTSJRGEU0bwHBc mWXzYYw+gy21jO2lOnWxSqBw3xaWA6AElaeLuDtLr1IJs/z82EI6n70DpMakhgPLHSoF9G35HNXLN SO0vOtRB5ReRN28VsCdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KkA-0000000BBFi-2fva; Tue, 07 May 2024 13:20:30 +0000 Received: from mail-qv1-f43.google.com ([209.85.219.43]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiQ-0000000B9s8-45If for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:49 +0000 Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6a0ce3e823fso19358076d6.1 for ; Tue, 07 May 2024 06:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087921; x=1715692721; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sqFGKWXdCy9k153fMpH4CQDZP31MGLQ/EHV/2T77xUQ=; b=Za+9cSvRxbRsPjrrTqPrinLuC4ffnri79EFMSAkM7auy0r8oYSBBaWu+bY8VsDS6lF E4HVuThz5XmIxHUKWfbOb4lOKj+85SlAddClpfusZxRIdwn+ZpxfN0kumGlsIVi7D48x AOq0Az9zZvghDPaEoO2kBol4e3ZfNkcuRVbpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087921; x=1715692721; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sqFGKWXdCy9k153fMpH4CQDZP31MGLQ/EHV/2T77xUQ=; b=bxSIIAUEvHK+hkQfX2vk+9u08WX7Zt0/2U9XNeu6z4eV2CT6gREpkT6+dnvz2AQWLE fTXCZiEqctZwrLo3HvROI8n0pedDUKnYIX1xfFBCKYT2V0KDHifFpwanh/eom0bqlWB2 ykSzBzPD9ZxXPEmQIo3/ris0z+KJJxJ3gqGvrsrlXF1k0LrSl/4Vp9PcFqnpwcRzEUuh OijWudqlpl7RJqXu0CknComhOoi1PuTw2dcTDpw53u7tu3eGAWzm7iDIdujuI1vY+czR zdfulWBCt4kgC63m1WIA6rrwfz+hdoGSnNI9ZbIij8TTCC90dDMJZo5WXzZN1g84Yw+S h4kg== X-Forwarded-Encrypted: i=1; AJvYcCUPHlAV5Fn1Mr24wdWxKfAMWzh2pbfmj0hANRnJ8iYrujo3TUpJVSTkRaNmwMMMGA8ZfbV/1aoXP9LGO2Ay3pySC7ijDtOt1ge18JdcPY+4c4quDbU= X-Gm-Message-State: AOJu0YwBR2EoGemFb89iSQK/k0SDfSH61O07A2RMpFdC8s6k8jNAtfxK EZBf6MXozUWduY5erAvG93PXxifRc9KdkPJ5X3qGrxwtN0BW0VmV6Pd+L8JH3A== X-Google-Smtp-Source: AGHT+IE/nAbjO9kVczxA1gk0GPTE0dAFY7dS/lNzVrz9t9IGNz9TsBD03sWLikOngI39+ClQ/E7Uhg== X-Received: by 2002:ad4:5e8a:0:b0:6a0:b705:27db with SMTP id jl10-20020ad45e8a000000b006a0b70527dbmr17551263qvb.13.1715087920745; Tue, 07 May 2024 06:18:40 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:39 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:37 +0000 Subject: [PATCH 11/18] media: venus: Refactor struct hfi_uncompressed_plane_info MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-11-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061843_356139_0F2A9138 X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This field is never used, but if we remove it we would change the size of the struct and can lead to behavior change. Stay on the safe side by replacing the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1003:43-60: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h index 7c0edef263ae..eb0a4c64b7ef 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1000,7 +1000,7 @@ struct hfi_uncompressed_plane_constraints { struct hfi_uncompressed_plane_info { u32 format; u32 num_planes; - struct hfi_uncompressed_plane_constraints plane_constraints[1]; + struct hfi_uncompressed_plane_constraints plane_constraints; }; struct hfi_uncompressed_format_supported { From patchwork Tue May 7 13:18:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76394C25B75 for ; Tue, 7 May 2024 13:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z/FRoWxHms4MsWOTS+cPrZpjxWrYPm/tPR1ciC0aCZ4=; b=n9qeMm3GLA5EMT 97X/ZrGd8Vt5soIGS8fJIR8mRep5P+RnhnRpG26nr44ENBYcv4HZdt9r3qM04UHcrgZWWibJ4+3DU iyWl93VKuoBkMsG2m8bYlVu9PS4x0YTZU0xOTAE0iGnHnHNNP55x3XZW2scWMG8nGYkI0FbqLLXfh SrEtYn2dwgPsWUaEhX+y97ub67vkeASJ1X7LkpvcSdgkmYF5j8pgH54FodK2L6ubcW6f2oCcbqAau uzRINbW+TOeG54k9gUZiZJhiOvC6w7SXMV5UKVz4IplfidabQCMMWoIBvcGC1A8D1A5ZnsrFB8nMV JfZ1T/VEOPqAVl3Va1Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kk8-0000000BBE4-2fr0; Tue, 07 May 2024 13:20:28 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiR-0000000B9sK-0hoU for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:49 +0000 Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-43d4c5f7b1bso17265771cf.1 for ; Tue, 07 May 2024 06:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087921; x=1715692721; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1Dzq1v7dj+VBVNk1zZzFNzIZj2cxfHYcizI+MBp1ZX8=; b=NzdrWUURfwnISiaPFK5byD4G6sMgDFM5XUheJukVCImYOEDdGc29lUixHqBXI/OjOq /VuaTU1qmZC+xbDTWBdkL/hBnGrz5n/FRe21QQ3JpATW/JoAGnVSnOroR7RONBFLm8R7 XU47/rMp62Fo+G3JnIGfAi7bgalM3FFAT8ZCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087921; x=1715692721; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Dzq1v7dj+VBVNk1zZzFNzIZj2cxfHYcizI+MBp1ZX8=; b=o4WobfpXNDIHS3CvXPvS293F6lPLI3pVpWs9RY5M0RF61qdeW6gIvoYDdDif+6gEsM A87cR83p9tKBnnwN7JGjaSGwhvdfIsItq0ottgnXM2BNqAxdgrv4tHfUrVeJCG+wtWSr 7H8NvhEKnz4b0ZnyOyssp0btNBOTcdvvUc/iNXlnvNLMokLTc5TueVF2tlKQfaVqSx50 /2L1iG6pc9OTjQ1vKZFkGzwiTJfwM+H/IG8pnWpWGFd9SptwWGvvhwvr4pY0TUXEZ+5F QFkkK5pDQWiDsOQev1Dv2O31c4tipwBVQ4lGMrlSLUV3/xvq/KSv1cVxbt602HVV3xi/ 1vBA== X-Forwarded-Encrypted: i=1; AJvYcCW7LUVnL/g68Xi0L5cDMdoOPkYJ1jbIA8b3d9UnKcPutwTc5MGOKJDLNZW9gJRQr/MnUC4ycwFLYn2r56Og5i4nrzYePR17xwv8KiRce9TP1zr1dhg= X-Gm-Message-State: AOJu0Yygh5PZ1MUSjxebaS6H7iTdeKdaDV2lOPCVe0GTjNOiJHRvMMya z6lMdF8ePogWc6JxRD2Y4LAVv8w/18j85zTTP68e8tAaxoGgD/hBABf/HxFpcg== X-Google-Smtp-Source: AGHT+IEAUZYdUkG16+sKKGfbxJ3Nv32xMw8WTErK9sJC2vrPaqjhZxuw8OroCcIO1SEdeCxTaiebPw== X-Received: by 2002:ad4:5be8:0:b0:6a0:55c6:9b47 with SMTP id k8-20020ad45be8000000b006a055c69b47mr16507653qvc.37.1715087921664; Tue, 07 May 2024 06:18:41 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:41 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:38 +0000 Subject: [PATCH 12/18] media: venus: Refactor struct hfi_session_get_property_pkt MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-12-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061843_407882_989C3B4A X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The struct hfi_session_get_property_pkt is always used to fectch a single property. Make that explicit in the code and avoid a single element array at the end of the struct. This change fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:194:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 8 ++++---- drivers/media/platform/qcom/venus/hfi_cmds.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c index 3418d2dd9371..520ff8a587e6 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -401,8 +401,8 @@ static int pkt_session_get_property_1x(struct hfi_session_get_property_pkt *pkt, pkt->shdr.hdr.size = sizeof(*pkt); pkt->shdr.hdr.pkt_type = HFI_CMD_SESSION_GET_PROPERTY; pkt->shdr.session_id = hash32_ptr(cookie); - pkt->num_properties = 1; - pkt->data[0] = ptype; + pkt->one = 1; + pkt->data = ptype; return 0; } @@ -1106,11 +1106,11 @@ pkt_session_get_property_3xx(struct hfi_session_get_property_pkt *pkt, pkt->shdr.hdr.size = sizeof(struct hfi_session_get_property_pkt); pkt->shdr.hdr.pkt_type = HFI_CMD_SESSION_GET_PROPERTY; pkt->shdr.session_id = hash32_ptr(cookie); - pkt->num_properties = 1; + pkt->one = 1; switch (ptype) { case HFI_PROPERTY_CONFIG_VDEC_ENTROPY: - pkt->data[0] = HFI_PROPERTY_CONFIG_VDEC_ENTROPY; + pkt->data = HFI_PROPERTY_CONFIG_VDEC_ENTROPY; break; default: ret = pkt_session_get_property_1x(pkt, cookie, ptype); diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index 6dff949c4402..e1dd0ea2be1a 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -190,8 +190,8 @@ struct hfi_session_resume_pkt { struct hfi_session_get_property_pkt { struct hfi_session_hdr_pkt shdr; - u32 num_properties; - u32 data[1]; + u32 one; + u32 data; }; struct hfi_session_release_buffer_pkt { From patchwork Tue May 7 13:18:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657064 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D08DC25B4F for ; Tue, 7 May 2024 13:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+/Yt5910Y+odXkH1kkFE9ce8p4Rhtm1vAAvEtt6lXE0=; b=ZBdxAxopQFuYJn 7+8Czx5AFHj+vz66gP6Tp/Essqvm0dCR8cYliAatiXLn1twb1TyIaHtrwHHNSH7CEMf5Eiu3XQcU/ eIC1pMoI/R5+0PXrpxvUSWtHZLj98sorueDOl7epEdSSPHfz5fIx0ko+/Yz0LPzw5AWWObzHFQIdq CzGW+lM1NxAGVUGrKyfyJZmYff6gw0JGUAK4wKFbzwa/9XiJyxsNx4Ywtip6o0DeHVNNuK5JlkHhb ay9DRXw+GeKUgiozqUDXDwexhBnFOqnat7kLfqcmrDaZKDnQv1mfEScM6tNj4w3RhaYT21PKRMdjb pM1DHeFMZpFwzFJFehSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kp4-0000000BE9o-3k7t; Tue, 07 May 2024 13:25:34 +0000 Received: from mail-oo1-xc34.google.com ([2607:f8b0:4864:20::c34]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kp1-0000000BE7x-1Ykb for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:25:33 +0000 Received: by mail-oo1-xc34.google.com with SMTP id 006d021491bc7-5b208cc22feso1074951eaf.3 for ; Tue, 07 May 2024 06:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715088329; x=1715693129; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=grfwfbVNg0FYwVP8zOHueia/jYu69rJdnTVnLodDO7c=; b=LTVj906b3Ajp8Bsff3PtDDUlPng8DjW/uSgm61jwmH1nUbIbALGcTgscdWpcM3kWeb Q0e66x6cI5XgH8H4vCXQB9wrgaEUY3P+7wc/1l+C6MYbzF6yVX8Iqjqjwr5yl4sNbRhK OraFa3Dz+/qi47Z0DkD9Qx1k/tFawKjXr/f7g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715088329; x=1715693129; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=grfwfbVNg0FYwVP8zOHueia/jYu69rJdnTVnLodDO7c=; b=viQP4gCEMsBbqO+d4qHLfhi9RnM6FKySUKJDDLVb3y92pt5hI4cYDvo1pv3oMXU5us Ws2umUtOg5tme6Pns/Q1yt0iyZcqZKIQ0UoQXKuy81potYVsNSzhnKogNMFc9B/aioXl 9IO0ZLjOxidJi7fpvm7VBC5C0B/5kp+ZJEs2tMigzTDFgzmAJrkafOwNMSkMs4cMrcPG C5Z7m9lSN1KsvQP+eJWXvP94HAx9JHtBbam6p9PVDPQE5rOB7nGALf/AvJe8cL1OL0Yz K2IZcw2aZz+4A5U3z2IRYUwvmTZcnQApB6vPyqKS39+l+UWGusKalYWTI+c6mkz2Q3OV aQuQ== X-Forwarded-Encrypted: i=1; AJvYcCUKDy/wW3lnZbYUDfPg0nUBLi+iMrxqK0e3y1NToUlnC57oPIFhIaSDdPL2yTm0rYIU5rlG40JS0nCXMfT2EwoXQKgamjylwZ6kxLR8ZSBzm+vPIdw= X-Gm-Message-State: AOJu0YwoMsu34MLRfZWtveBYCPEALI6kuX2JJgMnKcf8AODhmjQmA4B2 g4WYl8n0Pv/dyh6YiG7lkUuQ0PHXgeKbGRv2hy110J15cQj0vEtpvabEamy73cGUSy60fNmpEqE KBA== X-Google-Smtp-Source: AGHT+IFSSR3o5HtKdgIS/uE+VKpBV5Rv+stUdj3V5A3bS3LVQVk3ZyFe5CBq7bVuSTRuzIUL5DJ6ng== X-Received: by 2002:a05:6808:210a:b0:3c8:6223:c7bc with SMTP id r10-20020a056808210a00b003c86223c7bcmr17391584oiw.7.1715087922276; Tue, 07 May 2024 06:18:42 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:42 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:39 +0000 Subject: [PATCH 13/18] media: venus: Refactor struct hfi_uncompressed_format_supported MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-13-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_062531_444989_65DC9B46 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org plane_info is not a typical array, the data is not contiguous: pinfo = (void *)pinfo + sizeof(*constr) * num_planes + 2 * sizeof(u32); Replace the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1009:36-46: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- drivers/media/platform/qcom/venus/hfi_parser.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h index eb0a4c64b7ef..dee439ea4d2e 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1006,7 +1006,7 @@ struct hfi_uncompressed_plane_info { struct hfi_uncompressed_format_supported { u32 buffer_type; u32 format_entries; - struct hfi_uncompressed_plane_info plane_info[1]; + struct hfi_uncompressed_plane_info plane_info; }; struct hfi_uncompressed_plane_actual { diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media/platform/qcom/venus/hfi_parser.c index c43839539d4d..3df241dc3a11 100644 --- a/drivers/media/platform/qcom/venus/hfi_parser.c +++ b/drivers/media/platform/qcom/venus/hfi_parser.c @@ -157,7 +157,7 @@ static void parse_raw_formats(struct venus_core *core, u32 codecs, u32 domain, void *data) { struct hfi_uncompressed_format_supported *fmt = data; - struct hfi_uncompressed_plane_info *pinfo = fmt->plane_info; + struct hfi_uncompressed_plane_info *pinfo = &fmt->plane_info; struct hfi_uncompressed_plane_constraints *constr; struct raw_formats rawfmts[MAX_FMT_ENTRIES] = {}; u32 entries = fmt->format_entries; From patchwork Tue May 7 13:18:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657046 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7210DC25B4F for ; Tue, 7 May 2024 13:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IVa5QhugHk8RKpbCNnzp0FkqGubqWd6vDvaRKuCi8Fs=; b=wS83V9Qst/62k4 /6O/q5ZoFb1QVFRLTzFKTRgGQzVLFETJxzsOF4QD80ZXDGqaXPUZnB1ZXR4FYRYIAxx1a9UzdQ8Pq 9r49JREFEs+Dxvuz1qhtTefZdw/TswxN0NXyB6X3zNrbTZIsCm7NVVxgpfpX2FZ+jJIWmbtKQjQer YfZTA5oaEwI65iMo/e19/c3tG9OlcOb5oaw+GvcMDEg9mUY2zPszkIcD1hdLMLB82siCTBag/q3VB xUuC5VHwLkHwWHXSSIkKIkpG1m2tz0C/Yt2P+3IgoEA+DUd7l66tXrCD6X03kl2ZJePfqclCsmnWB /Ouy6ohCvxfusoNbSyaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kmc-0000000BCuM-0NVS; Tue, 07 May 2024 13:23:02 +0000 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiS-0000000B9sz-2rZX for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:50 +0000 Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-6a0ff97a9c7so42639976d6.0 for ; Tue, 07 May 2024 06:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087923; x=1715692723; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7NkWJe8JlogUB1KQ6tzpQTV71nluZthbO4z82dt8idE=; b=OCKme8fhjHnF/mabHi47aUUI8FTATBa2G6DPchi5bw6W0hL2bUQZmINXehsHW8k+I3 snRdIx2V7yCqsXvhnr9AfHze3iuTHYZ/YfQqH7/n1TFNAtpZIEvti/qMF0aOPmK41eoB v4zYEenTqJXN7lU0s2rG2Mm3jImXI8UFHXrH4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087923; x=1715692723; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7NkWJe8JlogUB1KQ6tzpQTV71nluZthbO4z82dt8idE=; b=bvH5FJsXceNfiWKPRIBy3qf7XXT1MApfgwGEbSxTWQztEiF6nyGyJHPj4aX1BWsDnS psUK9/Qyp2uH7mrOVjAum/+uk90tCwEZgXVbWTZ3SD2O1x+2JoEFRTcFZYgKnClDNs7q H09+650ce286wVreS3gpY3Z6LPx0lI1nlcp3EPRyKaURT46mIiKW4O5mogtM2eXypvv+ AAzlHwWuPIG3w089A8v0mo/JE9EAD0D2LlVZ6661uE57saei5jLX0MVDK6NTknYJ3yWb MsXT9tQKABW0IVlWSU/w+IRsPUJNg8tFPscX5sKYkPQ9eaJgf6jxsD6f/JG42SyiYrcL vLWw== X-Forwarded-Encrypted: i=1; AJvYcCWQuMpX46foBpgCq+DBFLabIxcP+SZx44F4Td/ikQImKpyRbUNePFqG/bZRzu2sjVyvUSbwEmRmPyq2gpDDMWpWHiLXyAmsnjbH5nM3ElUTIuJi5dQ= X-Gm-Message-State: AOJu0YyreKaQD23DRhUWFdhz9WfvzDJof8lbjI2oedwAsVsxR5e7pGAy 7B/hHgpdsQhYMnzCKA/nAsMwusL0x5D+idTqeCE3HNAbDIxEXLye4fDjwHdH9g== X-Google-Smtp-Source: AGHT+IHtK11JNQ0Mp4ZynJH1X6U9hIM5Ax6eZry5/k41CUicJOL6ws6WrCLsSXzFe5ZsTI8+M4i8kQ== X-Received: by 2002:a05:6214:288:b0:6a0:f057:402f with SMTP id 6a1803df08f44-6a14608b428mr41532076d6.32.1715087922869; Tue, 07 May 2024 06:18:42 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:42 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:40 +0000 Subject: [PATCH 14/18] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-14-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_061844_969204_A85ECA11 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The single element array data[1] is never used. Replace it whit a padding field of the same size. This fixes the following cocci error: drivers/media/platform/qcom/venus/hfi_cmds.h:163:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index e1dd0ea2be1a..15271b3f2b49 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -160,7 +160,7 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pkt { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 padding; }; struct hfi_session_fill_buffer_pkt { From patchwork Tue May 7 13:18:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A904AC10F1A for ; Tue, 7 May 2024 13:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t0grvpGCTC4yCBEENJxAX6sjSiO3dIpCfA6xuJh4mQg=; b=Lc2VA3/IQmD/t/ QIwdRbn5bzZgm5OoMM6EoX2sWYQfs9i2FrtwJHr5r2DtDs9wF6DLUG531GE2tnnKRU7ziL0uZL2g8 Q9z0llJpYG2I0FYCzb84dahH3+b3OsJzK21qBZZhM1PZ2LoYiigDFqUde7q0QGgK3/KFWLepDufa5 nSwmOnJhRRxPPhYKKnzGrQUGsJ6EFOzfwQ4WRYRKUkK+JnjPzumqHJBbBQ89PpyJFACfGUGXSaSGu ETMnwRrSlPLksNwNTlVTgVxUqJ0FrWS/lrpvCZO140mAWKIS/7FNBNeyTHPOA0LBdFbfQtPS+5/9Y SHTqNB+WH7up0Wmey9Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kme-0000000BCw7-30lg; Tue, 07 May 2024 13:23:04 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kib-0000000BA1M-0xpk for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:18:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=ksOWhtvDjU4SOAc5LYb/tmHPugkENGAwplW75xl0q6I=; b=lDuGjTbSfimCONoQpCiWRI7ud5 Vrd6eelIxbGE42l5ryGHZFUZayZQbkFIIV8kpb3+BwHdk+YtV6rKlwISRjszU768597y4hmE6gHFg yr7nAhhdt3KgbeFJVK91LTVOUAnr6RiuGy5Q/T0DC1BAx4JOJbbzL2i70I/0lMUHsEsndlTPSrYvY lwaPlxEFefLAmJbvJrEZFE0NZqL6qsASUZKnjJCA4wmAZlTbdBWSRjHvJ+Z+VTPDruUk49v6t2nCN S846QLfWvFcYUKrV0+vkgmUlrZ/G5yqDl010BT6FHW5njC8kNl2ZGPGW4Mh0nay8kV8EAZe3gheil tOsdnkGg==; Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiX-0000000DIVR-41l1 for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:52 +0000 Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-43b06b803c4so21011681cf.1 for ; Tue, 07 May 2024 06:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087924; x=1715692724; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ksOWhtvDjU4SOAc5LYb/tmHPugkENGAwplW75xl0q6I=; b=dzR6T6NFNGO2tbjdl8CJEl5CISCvQXRMlOPBU98JfP+C1ofvcbuZCHI3MgBw8Cb4Rz eK4SZg5dANIEHbaWgAll4VHD0IDD7G2K11pbJbu3xDGxOHcBuIuiGW57PUnMwv7xd0DL ZxeKZ3nRY6cQOJVcIcG12p+ErWKfjirSXIp/U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087924; x=1715692724; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ksOWhtvDjU4SOAc5LYb/tmHPugkENGAwplW75xl0q6I=; b=wxjV31plYH8cvbVwJb0IQ+0vVlViRXu3CdOlC/tWeMYv1xrSBMVmC0SqqmABCqZSZn G5OG8gQlJsFdaKJN701mmv4kgE/3toT8CkWD8EzEVNzPSwqjCfr6mjbKK4SgZggJ1Fy6 XNAAeDm5Fe+YiK3Lp6EPgOJMhKuVsoRz8qa6/qLBURo8EeJWullA+gOvs0nqWxfhVqbP WEY27ldbEY/FU+cG/5IX/+6S+qFwqNGR8QJ0M1d22TMaoPvU3A2eCvzN1XC8kxd6k6Pt bu0J6ETFRTwYQwup9Th4XXj9FKCRiapMv891LfH2BovAyT8Iou/Khth1tBkEdXCes42Q xsHQ== X-Forwarded-Encrypted: i=1; AJvYcCV1s/IBR4yS9Nlz8QNql8W3DHAapqNRFM59E+mzYgoAp20mqCFH6sOBnGUaumV0BCgaqIU5gyb6+l5SYBC96zB3AQ6IdIA2M28SHoLWX0rGigwRK7o= X-Gm-Message-State: AOJu0Yw48dfLBi2JnJe3lX55iYskEtARGR2sn6W+Xb4CIgaGF4a13qHz 74i1DSmidypxuWpkFWaFKpwusfHzpVxILQVtBoUmY870XfFMFrQiGP0smbF9CA== X-Google-Smtp-Source: AGHT+IGtSin+RqjeeAuWjhc+2Qu533gps/bRqdwUKUS9So7G1IUcL44UetlZwIWAlGuPmz38aWSKJQ== X-Received: by 2002:a05:6214:d63:b0:6a0:c117:372e with SMTP id 3-20020a0562140d6300b006a0c117372emr15802826qvs.12.1715087924051; Tue, 07 May 2024 06:18:44 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:43 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:41 +0000 Subject: [PATCH 15/18] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-15-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141850_068630_89C57AA1 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The single element array data[1] is never used. Replace it with a padding field of the same size. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:146:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index 15271b3f2b49..02e9a073d0c1 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -143,7 +143,7 @@ struct hfi_session_empty_buffer_compressed_pkt { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 padding; }; struct hfi_session_empty_buffer_uncompressed_plane0_pkt { From patchwork Tue May 7 13:18:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657248 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64049C25B4F for ; Tue, 7 May 2024 14:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=46D9IXQ0Wufn0Itk0GGfVnxOrfwvMSl2JJ+vj8ugDgw=; b=kuhBaoYHzF4KAY KZd+NP/dlaeaK8oigVRwe3h0mAWAle1hdfZ96o3T6WGMA9rYr9RHIF5k3rHFRXsPRR4pciR+Pw+WG lKCaa4CM+g+6wPb3OW2FMPte1m7k7QYJaCYWrZzy1Ts4Q/ALG2nk3+2aAusYFgjmNoqenLSIpEF+m Wpj73kMBA2LGjlY2qbtYgpbt74SsNBxxKd740rQBEPVrD7/VLdNva/2o58OthcJjKRscOzKhdj7Ds peh2+HWST/Ze/20CLGN3bHrPVZyEQhxJanHrZP+I2qJ9KolDnc0NHi8UvGZer/1luJdH9hofSYh6a S9RsdU7hqgZlQr9CbCSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Lqa-0000000BVzv-1zvd; Tue, 07 May 2024 14:31:12 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kj8-0000000BATf-29P9 for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:19:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=AxOzymIGy9oIqpVIjgGXcOBfnvf3rPmoINBWnjxn4+k=; b=HfjON8bjREYmJip8CISeXBwAVi +stQWL9UxSSsidpg6B7mg03NivyTIaA1YjN1BW69ZW9wODQdXMLdbBt1PZWe9D5taDFFoljK3Sv/U toW8NQ0iT25zDgrkfXVQsEAJk2o1LrTcDVWBlNdl6L/W44nU9Rr0rB9vjWKM1G8ttUATRXmRpXye1 VeCUoKJXhr4Ro6Rf0QirkDbCL1UkTw5k8nwhWPRxQ4kG6PGcXcdfbqD/iY1xX0bBmzSX2sv1kVnhu QKId+Ta252dEkq/x+Y1+3YKDzFUmTwVbKvJE5xcUUUqbUtb8iXXecmilVqG0tbtWdVAMLssqXNgnY j+2fuE+g==; Received: from mail-qk1-f173.google.com ([209.85.222.173]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kiy-000000026HI-2FlJ for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:19:24 +0000 Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-78f02c96c52so229834285a.1 for ; Tue, 07 May 2024 06:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087925; x=1715692725; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AxOzymIGy9oIqpVIjgGXcOBfnvf3rPmoINBWnjxn4+k=; b=YLY51WFYF83nak+9HAganT1D+XCuPozFAXismSfO+OzS5Y/IYEphxipvuspbHCpNrx Hluruox0Zhwn1zUI7vOE+5bmgL4E4jyyDf6gna3JUB+51JkQkgSUy4zrSp9KY6HQUPRZ ieoJAv/cqHW/dasVIHbvUYYxDzpjgCgBaUfEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087925; x=1715692725; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AxOzymIGy9oIqpVIjgGXcOBfnvf3rPmoINBWnjxn4+k=; b=XnMbWu9tBJRUd2z6qMB/LFXgVJ0VLs+W2AKeb+kjmhBHlB/f206ZezJXHwozPUQmTX 8J6AJB9wAORaBIH4xXd5v3Usb8H6XD5Dvpt9Vj8TdYAJu6R3Ktot59m96wFr8ipeIHEI TOxe3oTjS/5dOjivYJLQgeqU4N/DUVVk+eJ8uLW3fQF0+KQCbTOneKDpSKRZU446DSMh uQq2E+B/tB+hK8V2m8/bYh3ed9ZVW0tit+nacF1dh1Mi5QzvUbEcy1MFpJh5hlCys+7K rtW3zhOLuUwK3Gg2wAKMVcJdioqJpI0XLNWQao7HBhymkWMoHId3XMs2wX+l7gpNn2UR Z2Ng== X-Forwarded-Encrypted: i=1; AJvYcCVJwCyeV2kd+Jl8eCW5FPGTVXa7CQzuaxC99hN9FAfl9uu3tyRfawXvgvVRFYoyEpoZAVq3aP287MAGJuW1l6ymPzFaWJ1G0yZW2I0EbK6qBI0Ubbs= X-Gm-Message-State: AOJu0YzRYhoajXuzcCnqXUwj0sSM6ZWXCZUN5B8OFaol/LTodZ//M1W6 uG9ONYJsEKWtNz1izT0reV0amYopqbCm++PnLlylEkDh5Kzs0/8f6jVS/AdAWw== X-Google-Smtp-Source: AGHT+IFjQZjYTO14egmCt9EZ5CsVr4euVVQfMTbFSXKPd+8yhvIiVkrVYxti26YpbA+ubiSl4OVazw== X-Received: by 2002:ad4:5fcf:0:b0:6a0:cb53:a78 with SMTP id jq15-20020ad45fcf000000b006a0cb530a78mr15569643qvb.8.1715087925149; Tue, 07 May 2024 06:18:45 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:44 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:42 +0000 Subject: [PATCH 16/18] media: venus: Refactor hfi_sys_get_property_pkt MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-16-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141917_913553_E85603AF X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This struct was only used to get the version from the core. Make that explicit. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:77:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 6 +++--- drivers/media/platform/qcom/venus/hfi_cmds.h | 8 ++++---- drivers/media/platform/qcom/venus/hfi_venus.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c index 520ff8a587e6..c5123f2e76fe 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -151,12 +151,12 @@ int pkt_sys_ssr_cmd(struct hfi_sys_test_ssr_pkt *pkt, u32 trigger_type) return 0; } -void pkt_sys_image_version(struct hfi_sys_get_property_pkt *pkt) +void pkt_sys_image_version(struct hfi_sys_get_version_pkt *pkt) { pkt->hdr.size = sizeof(*pkt); pkt->hdr.pkt_type = HFI_CMD_SYS_GET_PROPERTY; - pkt->num_properties = 1; - pkt->data[0] = HFI_PROPERTY_SYS_IMAGE_VERSION; + pkt->one = 1; + pkt->version = HFI_PROPERTY_SYS_IMAGE_VERSION; } int pkt_session_init(struct hfi_session_init_pkt *pkt, void *cookie, diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index 02e9a073d0c1..cd7902743f62 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -71,10 +71,10 @@ struct hfi_sys_set_property_pkt { u32 data[]; }; -struct hfi_sys_get_property_pkt { +struct hfi_sys_get_version_pkt { struct hfi_pkt_hdr hdr; - u32 num_properties; - u32 data[1]; + u32 one; + u32 version; }; struct hfi_sys_ping_pkt { @@ -239,7 +239,7 @@ void pkt_sys_debug_config(struct hfi_sys_set_property_pkt *pkt, u32 mode, u32 config); void pkt_sys_coverage_config(struct hfi_sys_set_property_pkt *pkt, u32 mode); void pkt_sys_ping(struct hfi_sys_ping_pkt *pkt, u32 cookie); -void pkt_sys_image_version(struct hfi_sys_get_property_pkt *pkt); +void pkt_sys_image_version(struct hfi_sys_get_version_pkt *pkt); int pkt_sys_ssr_cmd(struct hfi_sys_test_ssr_pkt *pkt, u32 trigger_type); int pkt_session_init(struct hfi_session_init_pkt *pkt, void *cookie, u32 session_type, u32 codec); diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c index f9437b6412b9..745c2c0c0d55 100644 --- a/drivers/media/platform/qcom/venus/hfi_venus.c +++ b/drivers/media/platform/qcom/venus/hfi_venus.c @@ -1142,7 +1142,7 @@ static int venus_core_init(struct venus_core *core) { struct venus_hfi_device *hdev = to_hfi_priv(core); struct device *dev = core->dev; - struct hfi_sys_get_property_pkt version_pkt; + struct hfi_sys_get_version_pkt version_pkt; struct hfi_sys_init_pkt pkt; int ret; From patchwork Tue May 7 13:18:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F37B0C25B75 for ; Tue, 7 May 2024 13:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PgS0DtdRe4cXNtmNJKJcPLwOal8073jJHJmev6VcxvU=; b=qIRBciXu290Yal ckbPMrTdx+JVhLo+i6biX7Tt5Ipq8FdmT6RcxLYBQFkvo6QXybT37TxF6lqMqapal42Zj5tkbfDtB WM0kZr4mbfxzjPNweUb7l4lzgh9AEU2jGmC3ow19T9LZua5B8ftEHPGGtmMq1/sXfG24lWqo4ivCV gUgDIC1EQmX/V948GD9Ewjp6FCL0fZfCHuu+9qkfqku80yQtfFExd5xotoMAp+x2uvfSzY9SWOnpl 2YSxIn+bLO4i8oL/YWCfZ3an+51Etzsai3RSvIjt0rVlVpE0pXavCmv63ssnGj829Qp4F+MCjvQe8 hhxz5K6wv9AORPUNNWoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kkj-0000000BBdA-3fD6; Tue, 07 May 2024 13:21:05 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kib-0000000BA1u-3n9t for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:18:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=LytlgeivFEVadVFPCSFVFsEkz0aZMS5bY0SwfM06VYA=; b=iUOreH8rGR39hdkoZrMdRopPgy e2tozUCfM2D7upZiTKgadAjdReIodsIfukSD6u8FhSu8cYcE3LwanurxiD+DK92+x1HgMrVzhcGnn 4IJWgDsdyXSXohG4i8F6UD1VAC4drqhhpAqA7NGMEA/aM2fODAno55UKqX0P/aNlFwQw0kSY3Dmq1 YrtCZm4G89iziTfbYnXS32wEK3TdvcSOTALbcVCKOSSp1sY/9kO1lFAE8Y7Q2eSY8R/2fpTIzx9pI bhEtDpf+25cjc1HpA0C50OqPc5KbGIgLd4WhSdVkMCdE2KeOmwkx2k1m05ccN4OftH6qTZ6SMsB62 x8/Mltkg==; Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiX-0000000DIVI-3XPt for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:52 +0000 Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3c86f066256so1750306b6e.2 for ; Tue, 07 May 2024 06:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087926; x=1715692726; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LytlgeivFEVadVFPCSFVFsEkz0aZMS5bY0SwfM06VYA=; b=QCWng/0kjWT/0y028pNfkm/r6MIjyruVMVGjYKtdGkyqu8u3jPnx0dxU4qUEcYrfEP xrX8LpaXE/o8xKX+ynFT1EqmR3m4S244leboObUC96cmKZLqrzhZKraGY86EgtvA/hZy zOdcjgSzKDDE31C/TC05kxuwaY0Vjt+5nDfyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087926; x=1715692726; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LytlgeivFEVadVFPCSFVFsEkz0aZMS5bY0SwfM06VYA=; b=r90PkGou9H0VT45HHpQhT7c420inhBk4lloeDiiAlt14gnAjbhSE1V7N3xsAi5PxRk tL63FM6vQv3mpBCqCh9mbXmCpa4igt99HwhSIJUNzpolI4HifpPeUjj+NYrKDL7M8Z6Z taCDRgepZt7sfU/0k5DI2qV3psXz5QesRT5mD4E7q+pdLFUQhnVk8G2ig3IMGFy1XsKr FrGN3rigBw6wlnoFCMIc9Twxo8OUYoEtYL8EkkHskIR1rchSylz29ldTopybS/8IpPj2 usdHtn/c2fT2KGoQ4qjE0SIhxXMJLJa4nf8F7O6SNfrDteisR3SPgJL3i/f6KgPA5IMq BhSA== X-Forwarded-Encrypted: i=1; AJvYcCVtQjTCGzRb3mb1d459Yok2lIMjDLepS10bp/aGIZ9z9DruSyEdMNaiXcLlBcZW+NpUHUgPXeEj9sD6250Td96XDw9nmlC0MglF11QVaToGjteUtag= X-Gm-Message-State: AOJu0Ywzw41IrlZhMkjeCjgwzazdXR8e2xHfn8Spcwwoz6UzKrmVG3t8 iwkrzEbg5HFKCs3o+lLuFG8/tDifYfHZYYpInIh0dl0XRWtdJlJPIa/JOKUMa1dWf1my7MCsl6x YOQ== X-Google-Smtp-Source: AGHT+IGZMw5Pha/VROCdriiOpH8uUYadLoc23B2z0lYFRFwtANajXpC+2XNhKb0eZC6xMtAWx6sdeA== X-Received: by 2002:a05:6808:4d3:b0:3c9:70eb:151b with SMTP id a19-20020a05680804d300b003c970eb151bmr4342969oie.59.1715087925910; Tue, 07 May 2024 06:18:45 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:45 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:43 +0000 Subject: [PATCH 17/18] media: venus: Refactor hfi_session_fill_buffer_pkt MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-17-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141849_977039_92CA6517 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The single data array data[1] is only used to save the extradata_size. Replace it with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:175:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c index c5123f2e76fe..35423e211ddd 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -331,7 +331,7 @@ int pkt_session_ftb(struct hfi_session_fill_buffer_pkt *pkt, void *cookie, pkt->alloc_len = out_frame->alloc_len; pkt->filled_len = out_frame->filled_len; pkt->offset = out_frame->offset; - pkt->data[0] = out_frame->extradata_size; + pkt->extradata_size = out_frame->extradata_size; return 0; } diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h index cd7902743f62..0ccc4102ac3d 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -172,7 +172,7 @@ struct hfi_session_fill_buffer_pkt { u32 output_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 extradata_size; }; struct hfi_session_flush_pkt { From patchwork Tue May 7 13:18:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13657040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28340C25B4F for ; Tue, 7 May 2024 13:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y+y2ZDUvltj1ZCT1ojJHtresOj6mldQyxz3PcjlJeCY=; b=GEZvEiLLmBkfyH McHmcPF3hbOlWRcCwxPMRbe0PsnWMCkXzzVvYlTP5vW1ijS7Rp2CCxOIt+9My/RVTOfDWprm5sBQ8 aEyNN9mAWc6DnBdZHMiwjTnv2f7nfRd+zCecFOhw225sSTD/KE/YlK+ad5UT+XMoHxuHQrAMi3s2V zsUNdlW4K36pda0OQnGhIoE7OxogYz51+JW3+sFrGXocg1lHlSbXBtNkol8bdHJTxPmcoQTNFrITm DTprAH+MnDxHe+lYBGNwYfohNbrm3+BCHFJ5TXxOXZIqXj4MW/SVcRfjY32kerid9x9QWpErRKQTo J7W3eV67drAogmkoqtfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kkr-0000000BBjg-0veR; Tue, 07 May 2024 13:21:13 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4Kid-0000000BA3F-1ilV for linux-arm-kernel@bombadil.infradead.org; Tue, 07 May 2024 13:18:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=24yjDTHuOCF+C8SbX9O7bVVIA87jnk99ezK2b/3Gma4=; b=pEH2YBGdjYTMw8l4Bf9ZeXuryx 8Df4YD6j8S67vOBqXs/40rrk+eP+yoWCt2x0ULr4WnZOu93C95oqyOkNtnbRsEaV62+5S+2Pg/XZ0 6FK/xEltu6US8myN8ftNEINRAKO2DmEPWqtksmtOi3sUX49D5IVQrpnysWk1sofm6eeYANGWjmtAf tA3OTrigLd3Sn/2PbjQRWVKkmqdORzyWFbpt8WYY9lsDssIEm+6dIQkftw+d3Zhv53EjZA8G3g0js wsU3K0wsN/8WRZnlD5UfPXZvPv8CmHgBZvp7wv3r2ZkBvFSZIsVdetBKzYFMNSr7RERixn4SvgbHc VRzv94SQ==; Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4KiX-0000000DIVV-42Jc for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2024 13:18:54 +0000 Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-6a073f10e8eso12916616d6.2 for ; Tue, 07 May 2024 06:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715087926; x=1715692726; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=24yjDTHuOCF+C8SbX9O7bVVIA87jnk99ezK2b/3Gma4=; b=NwJPY1RdAnqzfkavSZk7I1uh1YCKOtbE+ZzGvxacO1SOW/7GKQbZe7E8+o65AOCHFF cNkJ4Q3OQakZ+YIGt3vSxHoaBokTVj8J/ymcg3D5v7qOzJdwr9ZnbwrbwWKFPLvC5jEw qj/yxADWC+ewwDsjkr7UmLB/N/LMxyWfXoYw8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715087926; x=1715692726; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=24yjDTHuOCF+C8SbX9O7bVVIA87jnk99ezK2b/3Gma4=; b=FDVP1iqYcwM4sj0Btbjr3MmqRq3FddETxwFH3mt31FuFmOpB1OEXst9Oq637CpY84W enjTbq5+Qj3op4CVI+RMN3ISop02SS4PVPRT9shEYs4XQ4eh0cKHUUgwk/P58bvh3SFD 3wwy5ZyPDR1o50Zu9eR1D8/Ln8cLoPHTmBhSzZZqp7aMX8+1YQGuFCkbzE8xKFavicde /p83+kpYGtItkynCR8Nk0/71U/Tl29lyfRy1lDc5Pbg3Ybrnx4xmuQBlFJI6zf1/wCZw YerKCYIpIZetBmt5YF5dyRDcDsyAW2JvC5hm1yw7ANWsoSUIaLsfhTB3zmYt0NcQU0DW vHbA== X-Forwarded-Encrypted: i=1; AJvYcCWAgHmQkidp4qseewXTJmc4qVZl0cm+wyxDA0AyVEx6g2N6jMlpOM1Y4eYyVdGvzmiXTGrjnRzxlC4Ev1ERYH5+9hSS/ngrIYgbsxgJceoh2fjEjcI= X-Gm-Message-State: AOJu0Yz3RmtgZe1iVnfu7XTEIK5L1FLAeOe9YiJ5APfYk/Ej49S8eddC 3LTpNLMfJhT0A/fKHwK0GGXw18Iq0dTTJ+Z0bFiUDQqPY70tUHwuZyhHFUKyPg== X-Google-Smtp-Source: AGHT+IE6WEUHWsRpAsJ5BK3gENbuRTlCVd8egHvgiFgdym5FLM6gUWkr0leru0COMDpv6wPoQvFI8w== X-Received: by 2002:a05:6214:d6a:b0:6a0:c903:7243 with SMTP id 10-20020a0562140d6a00b006a0c9037243mr17142784qvs.55.1715087926638; Tue, 07 May 2024 06:18:46 -0700 (PDT) Received: from denia.c.googlers.com (114.152.245.35.bc.googleusercontent.com. [35.245.152.114]) by smtp.gmail.com with ESMTPSA id t15-20020a05621405cf00b006a0d19c3139sm4655105qvz.118.2024.05.07.06.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 06:18:46 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 07 May 2024 13:18:44 +0000 Subject: [PATCH 18/18] media: venus: Refactor hfi_buffer_alloc_mode_supported MIME-Version: 1.0 Message-Id: <20240507-cocci-flexarray-v1-18-4a421c21fd06@chromium.org> References: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> In-Reply-To: <20240507-cocci-flexarray-v1-0-4a421c21fd06@chromium.org> To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab , Laurent Pinchart , Michal Simek , Andy Walls , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_141850_073605_036489A8 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace the old style single element array at the end of the struct with a flex array. The code does not allocate this structure, so the size change should not be a problem. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1233:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h index dee439ea4d2e..9545c964a428 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1230,7 +1230,7 @@ struct hfi_interlace_format_supported { struct hfi_buffer_alloc_mode_supported { u32 buffer_type; u32 num_entries; - u32 data[1]; + u32 data[]; }; struct hfi_metadata_pass_through {