From patchwork Fri May 17 23:35:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dr. David Alan Gilbert" X-Patchwork-Id: 13667430 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1C09C04FFE for ; Fri, 17 May 2024 23:36:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D7B4A10E1D5; Fri, 17 May 2024 23:35:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=treblig.org header.i=@treblig.org header.b="XNVySUsQ"; dkim-atps=neutral Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3FEB10E1AE for ; Fri, 17 May 2024 23:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=LvtRfjS2hxOURJcIdMjVVgisf5I/X5Frx5qJPUGE7P8=; b=XNVySUsQ3TsJCAr8 Msgt+rSgCOU4aa1KXWSWdzCvF2x1MgkC/4KzUkJcv0LP23aGSiRHQWScc7y6lEkmy2KAOt9mhutPv Eoccs3tc7WMDsF8nr3GfXR+RqxKTPvQ++bhEE4SvlX+awvcMJg2ayxp0utLOeIzoeBsd0M4I/Si0Z h7MFmHlJi87RHXlNafyZVY0wj8hYe0piWsLNVd2+6yymAIrHzU/KHc79d7cNIMszqCBxW3UXLVXnk OP8g/Xlyq0YYCtFMNQM1mfzkx0gIJDeKlhNJyUN0zHmc7fT+4AyvVvf9a3cOGgihi+XiD3fMQk/8Q ZgwBryAWK7RALhwEpQ==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1s877B-001TpV-10; Fri, 17 May 2024 23:35:53 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 1/3] drm/amdgpu: remove unused struct 'hqd_registers' Date: Sat, 18 May 2024 00:35:46 +0100 Message-ID: <20240517233548.231120-2-linux@treblig.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240517233548.231120-1-linux@treblig.org> References: <20240517233548.231120-1-linux@treblig.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: "Dr. David Alan Gilbert" 'hqd_registers' used to be used in a member of the 'bonaire_mqd' struct. 'bonaire_mqd' was removed by commit 486d807cd9a9 ("drm/amdgpu: remove duplicate definition of cik_mqd") It's now unused. Remove 'hqd_registers' as well. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 38 --------------------------- 1 file changed, 38 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 541dbd70d8c7..f3544f02ffb9 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c @@ -2757,44 +2757,6 @@ static int gfx_v7_0_mec_init(struct amdgpu_device *adev) return 0; } -struct hqd_registers { - u32 cp_mqd_base_addr; - u32 cp_mqd_base_addr_hi; - u32 cp_hqd_active; - u32 cp_hqd_vmid; - u32 cp_hqd_persistent_state; - u32 cp_hqd_pipe_priority; - u32 cp_hqd_queue_priority; - u32 cp_hqd_quantum; - u32 cp_hqd_pq_base; - u32 cp_hqd_pq_base_hi; - u32 cp_hqd_pq_rptr; - u32 cp_hqd_pq_rptr_report_addr; - u32 cp_hqd_pq_rptr_report_addr_hi; - u32 cp_hqd_pq_wptr_poll_addr; - u32 cp_hqd_pq_wptr_poll_addr_hi; - u32 cp_hqd_pq_doorbell_control; - u32 cp_hqd_pq_wptr; - u32 cp_hqd_pq_control; - u32 cp_hqd_ib_base_addr; - u32 cp_hqd_ib_base_addr_hi; - u32 cp_hqd_ib_rptr; - u32 cp_hqd_ib_control; - u32 cp_hqd_iq_timer; - u32 cp_hqd_iq_rptr; - u32 cp_hqd_dequeue_request; - u32 cp_hqd_dma_offload; - u32 cp_hqd_sema_cmd; - u32 cp_hqd_msg_type; - u32 cp_hqd_atomic0_preop_lo; - u32 cp_hqd_atomic0_preop_hi; - u32 cp_hqd_atomic1_preop_lo; - u32 cp_hqd_atomic1_preop_hi; - u32 cp_hqd_hq_scheduler0; - u32 cp_hqd_hq_scheduler1; - u32 cp_mqd_control; -}; - static void gfx_v7_0_compute_pipe_init(struct amdgpu_device *adev, int mec, int pipe) { From patchwork Fri May 17 23:35:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dr. David Alan Gilbert" X-Patchwork-Id: 13667432 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40642C25B7A for ; Fri, 17 May 2024 23:36:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5257810E341; Fri, 17 May 2024 23:36:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=treblig.org header.i=@treblig.org header.b="lQD3r4zV"; dkim-atps=neutral Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6314810E1F0 for ; Fri, 17 May 2024 23:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=zCEGpkp3Zmdhb06kEQRsXk9mj5wYCe5bu+6wwSjIgUA=; b=lQD3r4zVStcDT0Rz L3K0k99h6eTjHTq1uMj7Pb7fRpKfCatEf+J6ysrXs5czg7mR9BJRjbhrIzmlBW9/p9OPWoWBXmyvs jWDNZ2U0kNqhkG8sKlkIGYCCUEteDB1Jx55QdyCQVHSDw7NC9/tZT9Sot4o1LIzCTtTIZW/ZefEaC N2eukhCTw7S5k9Zrkky4sHQHOMIBTSKstAvIjFbDyRYnEbBan6JfO7nhW8ugvL3TEQEVZAMPo/4rm E1zkAc++pw6lBfvib9Q1k3BBpX8V3mp+6tsaxE7QrBUqRKHohmqtNLYOFXtErP0lWixEFkeY22x3w RR5dkugoATolFb0T4A==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1s877E-001TpV-1Y; Fri, 17 May 2024 23:35:57 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 2/3] drm/amd/display: remove unused struct 'aux_payloads' Date: Sat, 18 May 2024 00:35:47 +0100 Message-ID: <20240517233548.231120-3-linux@treblig.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240517233548.231120-1-linux@treblig.org> References: <20240517233548.231120-1-linux@treblig.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: "Dr. David Alan Gilbert" 'aux_payloads' is unused since commit eae5ffa9bd7b ("drm/amd/display: Switch ddc to new aux interface") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/display/dc/link/protocols/link_ddc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_ddc.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_ddc.c index c2d40979203e..d6d5bbf2108c 100644 --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_ddc.c +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_ddc.c @@ -51,10 +51,6 @@ struct i2c_payloads { struct vector payloads; }; -struct aux_payloads { - struct vector payloads; -}; - static bool i2c_payloads_create( struct dc_context *ctx, struct i2c_payloads *payloads, From patchwork Fri May 17 23:35:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dr. David Alan Gilbert" X-Patchwork-Id: 13667431 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F681C04FFE for ; Fri, 17 May 2024 23:36:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C34210E1F0; Fri, 17 May 2024 23:36:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=treblig.org header.i=@treblig.org header.b="IZyO9295"; dkim-atps=neutral Received: from mx.treblig.org (mx.treblig.org [46.235.229.95]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3158410E1F0 for ; Fri, 17 May 2024 23:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=MIME-Version:Message-ID:Date:Subject:From:Content-Type:From :Subject; bh=Q0VyvDtbmcL1dq3FHqWs/cX5D8LXTUaBhnMmbxFsZGQ=; b=IZyO9295QgLrX89a LkBO3bbxouDubvSE81EJbpSQ5eWvpbci6iHZro92ANhX5cJozO6QbHKsfh6spD0R3BqSQzTz218XT CKG4+FNUvQF47qUiU5LhLxWrmb7BMbS3NnqCtfkg2563YSzunj64b4Xv2ogeR/9t+7WYW9Rj4QBAu qkdvhV0mXaJd/VDIcCTpzSJ2lLCBKdhqbvqNtFoflfKBZoZPGumu8upf+q+Tjs74wokE5SzFKYc2Y AT7gVm9SORrPbYlIejog1BfPgLut4zI818ZRw7pLgBC39phnXSrxSAOJr/DtJ800BzO3mtuqyqROB 06pHCpou+Fz+vf6gtA==; Received: from localhost ([127.0.0.1] helo=dalek.home.treblig.org) by mx.treblig.org with esmtp (Exim 4.96) (envelope-from ) id 1s877F-001TpV-0n; Fri, 17 May 2024 23:35:57 +0000 From: linux@treblig.org To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Dr. David Alan Gilbert" Subject: [PATCH 3/3] drm/amd/display: remove unused struct 'dc_reg_sequence' Date: Sat, 18 May 2024 00:35:48 +0100 Message-ID: <20240517233548.231120-4-linux@treblig.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240517233548.231120-1-linux@treblig.org> References: <20240517233548.231120-1-linux@treblig.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: "Dr. David Alan Gilbert" 'dc_reg_sequence' was added in commit 44788bbc309b ("drm/amd/display: refactor reg_update") but isn't actually used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/amd/display/dc/dc_helper.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_helper.c b/drivers/gpu/drm/amd/display/dc/dc_helper.c index 8f9a67825615..b81419c95222 100644 --- a/drivers/gpu/drm/amd/display/dc/dc_helper.c +++ b/drivers/gpu/drm/amd/display/dc/dc_helper.c @@ -91,11 +91,6 @@ struct dc_reg_value_masks { uint32_t mask; }; -struct dc_reg_sequence { - uint32_t addr; - struct dc_reg_value_masks value_masks; -}; - static inline void set_reg_field_value_masks( struct dc_reg_value_masks *field_value_mask, uint32_t value,