From patchwork Wed Feb 27 06:41:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 10831279 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 58FD71575 for ; Wed, 27 Feb 2019 06:42:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33C942D188 for ; Wed, 27 Feb 2019 06:42:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 273EB2D1CD; Wed, 27 Feb 2019 06:42:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37CFC2D188 for ; Wed, 27 Feb 2019 06:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729155AbfB0GmD (ORCPT ); Wed, 27 Feb 2019 01:42:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:56922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728905AbfB0GmC (ORCPT ); Wed, 27 Feb 2019 01:42:02 -0500 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E54D218D0; Wed, 27 Feb 2019 06:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551249722; bh=JBoF3HU1t59pDsRnFc5VGm0W+yBXTA3oqukYlQ3ndeY=; h=From:To:Cc:Subject:Date:From; b=vfgXzZg+6cIUXJaQA5Up56RhqPa0JbPJIZVBSBoXUM0gRDf//IXV916u8NP1H9e+c WLfq/eXxvqWVTPq3L7as2r73etKwQBIDnAhDiwziXx0V3K21koU6eckwIXKgitvJUm ubTXyeEEDoMkqxMRHLblUY8R3GEUh8l+bEEEiCMg= From: Leon Romanovsky To: David Ahern , Lijun Ou , Steve Wise Cc: Leon Romanovsky , netdev , RDMA mailing list , Stephen Hemminger Subject: [PATCH iproute2-next] rdma: Add the prefix for driver attributes Date: Wed, 27 Feb 2019 08:41:51 +0200 Message-Id: <20190227064151.25445-1-leon@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Leon Romanovsky There is a need to distinguish between driver vs. general exposed attributes. The most common use case is to expose some internal garbage under extremely common and sexy name, e.g. pi, ci e.t.c In order to achieve that, we will add "drv_" prefix to all strings which were received through RDMA_NLDEV_ATTR_DRIVER_* attributes. Signed-off-by: Leon Romanovsky a --- rdma/utils.c | 34 ++++++++++++++++++++++------------ 1 file changed, 22 insertions(+), 12 deletions(-) -- 2.19.1 diff --git a/rdma/utils.c b/rdma/utils.c index 6bc14cd5..1f6bf330 100644 --- a/rdma/utils.c +++ b/rdma/utils.c @@ -829,27 +829,37 @@ static int print_driver_entry(struct rd *rd, struct nlattr *key_attr, struct nlattr *val_attr, enum rdma_nldev_print_type print_type) { - const char *key_str = mnl_attr_get_str(key_attr); int attr_type = nla_type(val_attr); + int ret = -EINVAL; + char *key_str; + + if (asprintf(&key_str, "drv_%s", mnl_attr_get_str(key_attr)) == -1) + return -ENOMEM; switch (attr_type) { case RDMA_NLDEV_ATTR_DRIVER_STRING: - return print_driver_string(rd, key_str, - mnl_attr_get_str(val_attr)); + ret = print_driver_string(rd, key_str, + mnl_attr_get_str(val_attr)); + break; case RDMA_NLDEV_ATTR_DRIVER_S32: - return print_driver_s32(rd, key_str, - mnl_attr_get_u32(val_attr), print_type); + ret = print_driver_s32(rd, key_str, mnl_attr_get_u32(val_attr), + print_type); + break; case RDMA_NLDEV_ATTR_DRIVER_U32: - return print_driver_u32(rd, key_str, - mnl_attr_get_u32(val_attr), print_type); + ret = print_driver_u32(rd, key_str, mnl_attr_get_u32(val_attr), + print_type); + break; case RDMA_NLDEV_ATTR_DRIVER_S64: - return print_driver_s64(rd, key_str, - mnl_attr_get_u64(val_attr), print_type); + ret = print_driver_s64(rd, key_str, mnl_attr_get_u64(val_attr), + print_type); + break; case RDMA_NLDEV_ATTR_DRIVER_U64: - return print_driver_u64(rd, key_str, - mnl_attr_get_u64(val_attr), print_type); + ret = print_driver_u64(rd, key_str, mnl_attr_get_u64(val_attr), + print_type); + break; } - return -EINVAL; + free(key_str); + return ret; } void print_driver_table(struct rd *rd, struct nlattr *tb)