From patchwork Wed Feb 27 06:51:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 10831283 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 668F91669 for ; Wed, 27 Feb 2019 06:51:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F1882CFAF for ; Wed, 27 Feb 2019 06:51:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 431CF2CFBB; Wed, 27 Feb 2019 06:51:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8BB02CFAF for ; Wed, 27 Feb 2019 06:51:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729249AbfB0Gvq (ORCPT ); Wed, 27 Feb 2019 01:51:46 -0500 Received: from mail-eopbgr70081.outbound.protection.outlook.com ([40.107.7.81]:60384 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726889AbfB0Gvq (ORCPT ); Wed, 27 Feb 2019 01:51:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7hPqqmPJ9EcUYN7EAw/LtT/JOZykYGgtkhGqqP2KmPc=; b=TZIADX2L7NHuAM7uD9bovGcx28ky5h3qx/UPwH5fjAycYrScNtKyKFjRPIWNNOouwquzntFWj+aTzkjK7N7ltuXjuENvkgl/h4LM5zHDVflsrw4OfAP/XRo+LlQu2c3m/3JtREHGRh11Mc+H/QdQSXIVT/66x71krUb78NlCOlg= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.52.16) by VI1PR04MB6271.eurprd04.prod.outlook.com (20.179.26.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Wed, 27 Feb 2019 06:51:29 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2%3]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 06:51:29 +0000 From: Peter Chen To: "gregkh@linuxfoundation.org" CC: "linux-usb@vger.kernel.org" , Jun Li , Peter Chen Subject: [PATCH 1/5] usb: chipidea: imx: remove unused header files Thread-Topic: [PATCH 1/5] usb: chipidea: imx: remove unused header files Thread-Index: AQHUzmjdgENTxWU9lEOKGLEolRvSug== Date: Wed, 27 Feb 2019 06:51:29 +0000 Message-ID: <20190227064908.17731-2-peter.chen@nxp.com> References: <20190227064908.17731-1-peter.chen@nxp.com> In-Reply-To: <20190227064908.17731-1-peter.chen@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.14.1 x-clientproxiedby: HK0PR03CA0034.apcprd03.prod.outlook.com (2603:1096:203:2f::22) To VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:60::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 161c1cc8-05d6-41cf-3399-08d69c80000d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB6271; x-ms-traffictypediagnostic: VI1PR04MB6271: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB6271=3B23=3ABK?= =?iso-8859-1?q?1093wQfks7jOmzEKcVuTgXDADoOPh8lXNg+paH5KUu/wy4X1mvNUPi0uLDsb?= =?iso-8859-1?q?zyHJTh1f8kxKFi2TGlQnv6UeI17oT472GPR/oxZKnCFLHQ2H8ah6JeqgduKN?= =?iso-8859-1?q?aLxgcYpNHVaTBUsBRpiLZfWunmFx9LTR6rJ5oQ+AXA/pWsZoQioSxPqJsqTv?= =?iso-8859-1?q?xwiH8CtBbtMJ3Q0l+QGQ0vt8xmpi0SIMJLugDlSUjEmxPL/mMh2PxtUVJItO?= =?iso-8859-1?q?6uR3qNkdhoM8t5U0gfO4KDGGLD0KHDVBUVTXBLSDJX86e/IKrF27W4VcVOvJ?= =?iso-8859-1?q?2yh4h0Q+f2ScfEG1Spvud67n67ruBWRjAer5wtU7+GA6bfWlSCHm0vtEeQJj?= =?iso-8859-1?q?84aD0kX+qXLnppwcUQ2e+yPrKLLT0Ocdmg+yjlYGvmcZFTNWs9YUoTguluUL?= =?iso-8859-1?q?HvuAvPHt/RVaVw/lfvfBYVF5kOaBSeryQfIdbKTJTzHGUY16QT1r1w52juna?= =?iso-8859-1?q?W2tPrr1nWAgmR/p34KBfgpf6+3SOZAWhrj57V0WkKkEzHxkyT4VHKt+h0FKz?= =?iso-8859-1?q?3olG3jVCFYc1DFTVWsOSJVtrJnh9GaxTXesTPDVQUYPJznpF5zxsaVA9nX3Z?= =?iso-8859-1?q?83fP/bO2uGayw4FoTILtiN4F2W1NJUV+/uJrtXdQ/iGa4nd5pxPUXvZmAIfB?= =?iso-8859-1?q?ri1XDgM1igLMAOSWbVAQQNCR3hWPRjDT6vH9iZqlZq4vXJmG9KSechiaOYRh?= =?iso-8859-1?q?JnGw5piEUBLaX23dAOkKy+O10Jk3WWefpdoQd3cH2POcwJIQkU5Ffaln8++n?= =?iso-8859-1?q?b2nBhO8kpnYc3uuZ1NbMhHKE2n4LRDRyeCeykIkfKSowiT3BjGqeJMqN8mlR?= =?iso-8859-1?q?YHGn6zRhb8JSlSxLAuqTFpH2JPpODwWgSHB/XidSJKz/wYdO0ROvmIzAs0Ir?= =?iso-8859-1?q?MZm5qSsnl+rO0YhYDDHRehRJ5gqjsS54UrY2j5SLjUzwfSGGWs9LdaTH5iTL?= =?iso-8859-1?q?EZiUnUcfwX5Um/NQWmleGw1IC1tUA0qeXUfNsX8+o0CM9CsPiqCqRn17We/S?= =?iso-8859-1?q?E5iHxVVXABWZXl3ilqoSgg23nP5UJgj3tK4Owmh59oxe0b708QNG44WruDEp?= =?iso-8859-1?q?fa8Qt4IzKLqlJ6j9Ud5RG1Y3iOqgEA96cy0dirJfYwbawi7+1NLhvhUQc9Xi?= =?iso-8859-1?q?CPsfcQ1AvXBfVqBa5lItsDoV+dwtyqaVqcdw7MyvWDrSye5LJ4VNjobz6pRj?= =?iso-8859-1?q?KT5zU7+fN4heZxDttDvW21Aigk5eY1xrZehugRfdA9nI53fN7DsvDTxhdkTh?= =?iso-8859-1?q?XMnyIYyhjrWuDzZ/ObroRrj8uV9UkYfY/x0J9b0V+hPTiqXEeaw6GayplIhQ?= =?iso-8859-1?q?gi5A81kIR8jnuWhGvsmP5L?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(376002)(396003)(366004)(346002)(39860400002)(189003)(199004)(446003)(6486002)(6916009)(478600001)(1076003)(5660300002)(36756003)(2351001)(26005)(6512007)(106356001)(386003)(186003)(6506007)(68736007)(486006)(102836004)(5640700003)(6436002)(4744005)(44832011)(105586002)(81166006)(81156014)(1730700003)(97736004)(8676002)(14454004)(54906003)(76176011)(53936002)(71200400001)(66066001)(6116002)(71190400001)(3846002)(8936002)(2501003)(2906002)(50226002)(316002)(476003)(2616005)(99286004)(25786009)(256004)(52116002)(11346002)(7736002)(86362001)(305945005)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB6271;H:VI1PR04MB5327.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /aEd5GljQ1nBvjbB5Bz0LnI7+i5DoX6L/2lcjMw1tkuyxnCQ9PGjDrCib4yE+xbLa7TtIXvX/+kuVi+XYUPYT3/CxU1cqc3sW9VvtXArzo0ewcsUJSXa3llpMDYmtsXys48/IE231j1qetDg3kfQ32TxxWMG6oSe+BNZfm2ycs0UYwqCMZWwRGY79np3CJg8INtnRU2Cwkj359KsR7UEWPUpbDYPZ0GTu6N1p3RgwPb3+5xS5yA3coa2fwraDNW15x7dDWVlp9Qm1oa/ilubp4SM1ESJQz3Yn8JLWRjN4chUu/lXgFdQjTwm0cHe0j5/dF1P8CbZDkNblWmfVMTnuxNCEpYyKuHB1CeV0CYsa5JjQYmp7W94ndM5zmc0BTT1YERP7tM99dpEjDXohldxfVq3+0oGQb55T0ENC0ti908= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 161c1cc8-05d6-41cf-3399-08d69c80000d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:51:27.3614 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6271 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jun Li Those 2 headers files are not required now. Signed-off-by: Jun Li Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index e81de9ca8729..1ef2373c229e 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -7,10 +7,8 @@ #include #include -#include #include #include -#include #include #include #include From patchwork Wed Feb 27 06:51:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 10831285 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2F91F1669 for ; Wed, 27 Feb 2019 06:51:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A4252CFA3 for ; Wed, 27 Feb 2019 06:51:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0BD072CFB3; Wed, 27 Feb 2019 06:51:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76AE72CFAF for ; Wed, 27 Feb 2019 06:51:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729264AbfB0Gvt (ORCPT ); Wed, 27 Feb 2019 01:51:49 -0500 Received: from mail-eopbgr70081.outbound.protection.outlook.com ([40.107.7.81]:60384 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726889AbfB0Gvt (ORCPT ); Wed, 27 Feb 2019 01:51:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r92WbFk/WuPJb9b+OwtAA+Cw7XRpg2GglhOTMje8F8Y=; b=WuQK7YmVr4l4v/k1jz1mzw4sUiKpsBJhSwNBAvuYpQIIIHKP+R8h2ZtdqbV0mc+wsgbN3P4GLiqPGnSEvTNlSWDSUj3HSD1BabraHOXqoyp7/dp7iufe4Cwro5wD1IyFDHqJDxR9itlUxJw+rjaJ5rbOJX08yEkfafGfKpZhLdU= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.52.16) by VI1PR04MB6271.eurprd04.prod.outlook.com (20.179.26.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Wed, 27 Feb 2019 06:51:32 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2%3]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 06:51:32 +0000 From: Peter Chen To: "gregkh@linuxfoundation.org" CC: "linux-usb@vger.kernel.org" , Philipp Puschmann , Peter Chen Subject: [PATCH 2/5] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high Thread-Topic: [PATCH 2/5] dt-bindings: usb: ci-hdrc-usb2: add property power-active-high Thread-Index: AQHUzmjfFgx74ZNvXku7sXW9/JckOg== Date: Wed, 27 Feb 2019 06:51:31 +0000 Message-ID: <20190227064908.17731-3-peter.chen@nxp.com> References: <20190227064908.17731-1-peter.chen@nxp.com> In-Reply-To: <20190227064908.17731-1-peter.chen@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.14.1 x-clientproxiedby: HK0PR03CA0034.apcprd03.prod.outlook.com (2603:1096:203:2f::22) To VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:60::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b91c3cf1-e0e2-4142-a263-08d69c80017f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB6271; x-ms-traffictypediagnostic: VI1PR04MB6271: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB6271=3B23=3AID?= =?iso-8859-1?q?JrKhAiUBgiY4XuEed9XPaXECRwKPAyrOVp/7Rh0yuahwsIPTMIXnwqwbj65m?= =?iso-8859-1?q?ETEUOfzuh3BCp/b03pYiDiRaRxrs8KrVJ39w5MiMdgjEYx7oZFEow/tTrjNg?= =?iso-8859-1?q?JzlwDj68+syg2yj9//zmKB1GXw6f3JcwmRWMmxzEscOD+vucyW8k7UxXVEAw?= =?iso-8859-1?q?j3r0v7xfLzZLjTgZIvFn51WM+QMJlcku3aRVVpT3szV1b0Okb2eXCUcd3XIT?= =?iso-8859-1?q?tjlg2Wenla/gFKc2gMd73iCTBNvdCs+P9XACvE6hLy2hz9FwQUUSst0SbqeM?= =?iso-8859-1?q?3ZesyeQYWmyoIvPEIW4il75Q9QNJweOqX/bSLWPo+CNfumCrn6BE5OycDZH0?= =?iso-8859-1?q?Bq3j7cV1kPdLnvWXYwvbxVQKBVd6KwBbeYyzdr6crmyjIdvR93Z8GAghwQX2?= =?iso-8859-1?q?IbFwnpmCtgXEBC7JkL2gNQyNaWLPE+xyve/jymG35A/yXA/QyAveLalbJo1b?= =?iso-8859-1?q?2NyezVbTGgspb5LgcTEbA6LixAzvGTNqu/cJiMsZtk4XoBy+Sxl1AuJlsDxG?= =?iso-8859-1?q?hk7aY0n3fa7lY41PUaKjgSb3py8EZSM/4ffCM2aRGYBXg8/7bwhReoEiCTDz?= =?iso-8859-1?q?x8gfk2DRPBOfIUmDpzfH7zDgUBAzsD4YWo9uSLpeo6QyNe3PXylCmP3o1K4Z?= =?iso-8859-1?q?V+hND1Ntx1+cse1P2I5eVk5ffzshE10rH6rFHLBAavuekkcbdqfIdi3x/Zp5?= =?iso-8859-1?q?TEGxMDVbPntrJ44yGQWON2yAsEpA2/o0n8hxQracJAiHzHFhQ8uDzgWaO4G8?= =?iso-8859-1?q?taplhoeRwI61kQu/4gvnXOQQvUZYKs3IOewMwwPJBmoimITajkpp/kVjR9FF?= =?iso-8859-1?q?oNx/Q8smThclaR7Q4zzqPMpAaqZ4MgK2ZgXYHiPFL659bCu4n9hBM1iNAdDd?= =?iso-8859-1?q?5R3gOrxg2xHVHTaaKsOkz0Sizyqqb6+0xQ09ckWwnKiKuyB356mMP1wVIN0n?= =?iso-8859-1?q?kW4fTqndfZ55uhjsW+7yhK9eiqFI22L8pWl2X1o70a5t3CgnRoTda8WetbTm?= =?iso-8859-1?q?oUhca3ldlYDWQNiXr8H79wRVgRiOmDpbKE0a7w4wAcwASqtF37xH3LtOrbye?= =?iso-8859-1?q?BLT+0d19HryfgG3WmYbkcrRgUdfHrp58WngUQH/vN7ScT9SXueLmChqw4aXN?= =?iso-8859-1?q?YHKHur8rjELn3gbBHuJujukYVlyHUOLVrMxI9Cg105nqUgEr5g1vLmJK5yzu?= =?iso-8859-1?q?MVh9tef7NqIt+j3kFSR06nnazzdfZrzUpcPz1RvzUyfTvGfBo7EvCcUTMN3z?= =?iso-8859-1?q?9c15vMIoq+N1e1ChcBI6vGVSjPi3npwl+kN+fWvi6qSI7nu7Er7Ot/sU9kP0?= =?iso-8859-1?q?WRf3TxCInPahV5zgulT1Sh0oS34aVMqbdtep3Z2dKnjZ5NJ3Y+VJBYVpAko2?= =?iso-8859-1?q?YUGeXAVrdLQQDQ38dyGvf9aI+91N7xi7WVvajw1TrdWCFEQg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(136003)(376002)(396003)(366004)(346002)(39860400002)(189003)(199004)(446003)(6486002)(6916009)(478600001)(1076003)(5660300002)(36756003)(2351001)(26005)(6512007)(106356001)(386003)(186003)(6506007)(68736007)(486006)(102836004)(5640700003)(6436002)(44832011)(105586002)(81166006)(81156014)(1730700003)(97736004)(8676002)(14454004)(54906003)(76176011)(53936002)(71200400001)(66066001)(6116002)(71190400001)(3846002)(8936002)(2501003)(2906002)(50226002)(316002)(476003)(2616005)(99286004)(25786009)(256004)(52116002)(11346002)(7736002)(86362001)(305945005)(4326008)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB6271;H:VI1PR04MB5327.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xtFhwS3l5ai5WKwi4cIaGaLDaj13d5Tjmgs5GQshdWPjYPc01jJpLcawBKOm85YfIHyYpPGE7jQ44ofICf3NtSDMVM6iFNYlipQ9KQl9uZsR8MzleTp01LRYKHJypO55nkiANxzGnJAYMkMCeDEnxWs0SMoF3pld+nlFnq2ruDpbPN2OwhT4o6FKpKG8sghuIMtkuQj5QQaWq6i2WIYutrDoBCBsobDBI/nxnqXrZ2KSkXw/EbvZhoDf0fPO+Q8cZY+L/+MWmFv07g1otkwCmNK43YRFCWju9lTbA8AY5rmrIntI//OiGfenIn0Z8aqDr/RKTXuVRGiBliJ9T/GUFGByiTrzYZocTic+NqKyIP8FTIoicji6+oB6JtF0X2WzIelUe9IbRTqsEJbeZb/d73YWz3epszWI13rjTwjeNzU= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b91c3cf1-e0e2-4142-a263-08d69c80017f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:51:29.7601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6271 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Philipp Puschmann The i.MX USB controller may drive the usb power line directly, but the polarity depends on the board. Reset state of the polarity is low-active so add this property to allow it to be high-active. Signed-off-by: Philipp Puschmann Reviewed-by: Rob Herring Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt index adae82385dd6..a254386a91ad 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt @@ -93,6 +93,7 @@ i.mx specific properties - over-current-active-low: over current signal polarity is active low. - over-current-active-high: over current signal polarity is active high. It's recommended to specify the over current polarity. +- power-active-high: power signal polarity is active high - external-vbus-divider: enables off-chip resistor divider for Vbus Example: From patchwork Wed Feb 27 06:51:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 10831287 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DD2A515AC for ; Wed, 27 Feb 2019 06:51:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C74222CFA3 for ; Wed, 27 Feb 2019 06:51:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BBA772CFB3; Wed, 27 Feb 2019 06:51:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 467892CFA3 for ; Wed, 27 Feb 2019 06:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729246AbfB0Gvw (ORCPT ); Wed, 27 Feb 2019 01:51:52 -0500 Received: from mail-eopbgr70081.outbound.protection.outlook.com ([40.107.7.81]:60384 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729345AbfB0Gvw (ORCPT ); Wed, 27 Feb 2019 01:51:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J68CMK0TSok8eCQHHdaDOanoULQjyQB96bE5YF8tPsI=; b=DL637nuTPwU7OmDukhHdasuD8DJ/O0VshYIRQchAFlKYxQ8VQddYDwAKuoD18q0c65LcnXcZu4lr47O+FmTl5G0xBUTjqDKC2TuC5qRjPr9KBeOK8tV6USn3MFK5Udopww1THrvIFpE3RlgF6gXM0vXWWSQjnCFJK8UHkZIkgCs= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.52.16) by VI1PR04MB6271.eurprd04.prod.outlook.com (20.179.26.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Wed, 27 Feb 2019 06:51:34 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2%3]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 06:51:34 +0000 From: Peter Chen To: "gregkh@linuxfoundation.org" CC: "linux-usb@vger.kernel.org" , Philipp Puschmann , Peter Chen Subject: [PATCH 3/5] usb: chipidea: imx: set power polarity Thread-Topic: [PATCH 3/5] usb: chipidea: imx: set power polarity Thread-Index: AQHUzmjgD6u7eEJzSUGThWNyBs30tg== Date: Wed, 27 Feb 2019 06:51:34 +0000 Message-ID: <20190227064908.17731-4-peter.chen@nxp.com> References: <20190227064908.17731-1-peter.chen@nxp.com> In-Reply-To: <20190227064908.17731-1-peter.chen@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.14.1 x-clientproxiedby: HK0PR03CA0034.apcprd03.prod.outlook.com (2603:1096:203:2f::22) To VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:60::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2fa717e4-a516-4929-7c7f-08d69c8002ed x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB6271; x-ms-traffictypediagnostic: VI1PR04MB6271: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB6271=3B23=3AUW?= =?iso-8859-1?q?w9KASZHBjh0/2p5LKxcEwzxvwSLF1B/WJx7JyHKaG9vdWW1hL4+8GdAUMonE?= =?iso-8859-1?q?cVZs3G+oc/cn7D5RfTKNi76gc75PQJBHFDc/toSo4Kcz7pmlhAclqj0w9nU8?= =?iso-8859-1?q?LouPAwZOYI1Dze97vkZiLUUezGPQ2FMP9YD9OLaXd1I8GEHZRL0TfTIdDwqZ?= =?iso-8859-1?q?9UrfWZFBvtMzOzxWiB0Y1RVCt/P9JBFvac5NB5o8xitVEGcn56/sxPho9W57?= =?iso-8859-1?q?XU4zgyA46JsWuz5zEdaQW05ayGVTJuBQVIjdFn79Tuc59F4omTCe2H3uIF8G?= =?iso-8859-1?q?W0DnpV61Mb9ZRVH7c5bgGFvmEorcp+Cb55VVwec2HOAPlK9mWfPbdm6JPfqV?= =?iso-8859-1?q?5Jrh6NcYKvJVrD5H/bcOy+oWo0bxMdzg7uABKYGJVO6b5+9fExdbmZoRctcR?= =?iso-8859-1?q?Xxh/f7f4fCCmx1paqXxq7F26Kz5kIUQ4H25pPnQ4bn5nh3NMpF4NZLEgoLhf?= =?iso-8859-1?q?fIRvMBTTH909G5VIYkyZIVgN3s84J5XgGgPlWHbgDrKynBxum0AYF4RlV+Sx?= =?iso-8859-1?q?MTdYskuQvQ7Fj/KSrtnVCXTWzx8SLibVqnB2z83XklUOv77sTb/b7J/4l9U9?= =?iso-8859-1?q?toYa0fU/HoUtTRLNLwp9htkxDP/q73uAppDbOc6XZri02MmSuMsOMyeB7psx?= =?iso-8859-1?q?xqv5ACpila9k4v6pmohDsQMxsF8TsnwrDfhKOW2zZf88l3W30G26il3k8520?= =?iso-8859-1?q?9zz3V9eAC4v7jDiEToFo8X0TIe2+Zx6FADPw4jgh19aLXB1UExzEkA7fJha0?= =?iso-8859-1?q?Z7HnEWEm5TtsiUs5isnpznwYSfyuTuzVybuiJf7B1FvoUTxQ7gpS2M2uCaDV?= =?iso-8859-1?q?jn5zyzD/jyaFz06RSwEw6XAo+FNIYLqJemGBgyXd/KQkr40jvT7KDTN61zna?= =?iso-8859-1?q?e20/4AsCGKDyXSP1x9PfrQfnug126hY0MIk7ICmwDBCOJO+mxnRDSg2S79lu?= =?iso-8859-1?q?JYOk5P9Dlt1peQL6wsJnJXjcaTcyLuV8jBE2KVYWklojY/GFwDdwdP7pcWf2?= =?iso-8859-1?q?sk/iLMyveKaPxwL4zK36RDRqAFQ1VedWVLQi/+qj/M857GV7/qYej9RT0vKc?= =?iso-8859-1?q?Tw9xyajr+BOsf6QEdnOuZjsfZqX6KSQlNez/hA4S7torhR6eZ7ZfGu+W8zUN?= =?iso-8859-1?q?ednf219oSbYu5NDwsj9q5wEyKKsHiZaL4r8GwaIkG7KNXQIJvPPCX3XDQ5LC?= =?iso-8859-1?q?7ZmmHBudXwE/V3ElGASj55UfUv37kL25G9gWTQBIg4rB3hUEI+tikeeNPPFV?= =?iso-8859-1?q?e2kMHBaRpW2RPdeBc25DbkjddtyB8GY7jyBBqa6REDPTfdp7l50epM6Vb0GC?= =?iso-8859-1?q?Y=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(376002)(396003)(366004)(346002)(39860400002)(189003)(199004)(446003)(6486002)(6916009)(478600001)(1076003)(5660300002)(36756003)(2351001)(26005)(6512007)(106356001)(386003)(186003)(6506007)(68736007)(486006)(102836004)(5640700003)(6436002)(44832011)(105586002)(81166006)(81156014)(1730700003)(97736004)(8676002)(14454004)(54906003)(76176011)(53936002)(71200400001)(66066001)(6116002)(71190400001)(3846002)(8936002)(2501003)(2906002)(50226002)(316002)(476003)(2616005)(99286004)(25786009)(256004)(52116002)(11346002)(7736002)(86362001)(305945005)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB6271;H:VI1PR04MB5327.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3K5wPi/F15AAAzMA24oPoGk0c8BsIA08ImEIlpHndVbIz+21Jg9rT1HZGof5bv3u5sUWTesJqTkMkh4H3AV5LGyaAi5afzLmYCx4M0HHG7Zsn26KI82Q9SlU/5R6pu2iJYlC0sGbiO5fwEGm+yTwhkvBsX8aAKA1FLA0x45qQMPeyFqFaMp8KJivtuZJVewRrXYl4irFt66zA2Y+coerk6PbH6xW0r8sMXfwIZX9NzIPCSjkGygvR5dF+Wf2wiLqHRVBAUr0i412Qq8EzftltFVmgFqHmmP/A5FcMQjY82Uag/BO+jhMH14kM5vbEbWUxqeXhHWR+dkt5qQcyIKGuwypkBZmcK7AEyPJFp4YShHDYwXPQhZWcpAPMhbvF66pvkx0Y/YjZVuc9+EPKjeBmqeOqLopuAM1vScySZSWVHI= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa717e4-a516-4929-7c7f-08d69c8002ed X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:51:32.1837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6271 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Philipp Puschmann This patch adds support to set the power line polarity for i.MX SoCs. To let the USB controller control the power it may be necessary to configure the polarity of the power line. So far the polarity was configured by Bootloader or alternatively the power line was muxed as gpio and driven by a regulator. Also make use of of_property_read_bool. Signed-off-by: Philipp Puschmann Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 4 ++-- drivers/usb/chipidea/ci_hdrc_imx.h | 1 + drivers/usb/chipidea/usbmisc_imx.c | 7 +++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 1ef2373c229e..d516198fcb2b 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -150,8 +150,8 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev) dev_warn(dev, "No over current polarity defined\n"); } - if (of_find_property(np, "external-vbus-divider", NULL)) - data->evdo = 1; + data->pwr_pol = of_property_read_bool(np, "power-active-high"); + data->evdo = of_property_read_bool(np, "external-vbus-divider"); if (of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) data->ulpi = 1; diff --git a/drivers/usb/chipidea/ci_hdrc_imx.h b/drivers/usb/chipidea/ci_hdrc_imx.h index 7cc53e2ce564..c842e03f8767 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.h +++ b/drivers/usb/chipidea/ci_hdrc_imx.h @@ -18,6 +18,7 @@ struct imx_usbmisc_data { /* true if dt specifies polarity */ unsigned int oc_pol_configured:1; + unsigned int pwr_pol:1; /* power polarity */ unsigned int evdo:1; /* set external vbus divider option */ unsigned int ulpi:1; /* connected to an ULPI phy */ unsigned int hsic:1; /* HSIC controlller */ diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index 097ffbca0bd9..d8b67e150b12 100644 --- a/drivers/usb/chipidea/usbmisc_imx.c +++ b/drivers/usb/chipidea/usbmisc_imx.c @@ -63,6 +63,7 @@ #define MX6_BM_NON_BURST_SETTING BIT(1) #define MX6_BM_OVER_CUR_DIS BIT(7) #define MX6_BM_OVER_CUR_POLARITY BIT(8) +#define MX6_BM_PWR_POLARITY BIT(9) #define MX6_BM_WAKEUP_ENABLE BIT(10) #define MX6_BM_UTMI_ON_CLOCK BIT(13) #define MX6_BM_ID_WAKEUP BIT(16) @@ -383,6 +384,9 @@ static int usbmisc_imx6q_init(struct imx_usbmisc_data *data) else if (data->oc_pol_configured) reg &= ~MX6_BM_OVER_CUR_POLARITY; } + /* If the polarity is not set keep it as setup by the bootlader */ + if (data->pwr_pol == 1) + reg |= MX6_BM_PWR_POLARITY; writel(reg, usbmisc->base + data->index * 4); /* SoC non-burst setting */ @@ -585,6 +589,9 @@ static int usbmisc_imx7d_init(struct imx_usbmisc_data *data) else if (data->oc_pol_configured) reg &= ~MX6_BM_OVER_CUR_POLARITY; } + /* If the polarity is not set keep it as setup by the bootlader */ + if (data->pwr_pol == 1) + reg |= MX6_BM_PWR_POLARITY; writel(reg, usbmisc->base); reg = readl(usbmisc->base + MX7D_USBNC_USB_CTRL2); From patchwork Wed Feb 27 06:51:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 10831289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C71715AC for ; Wed, 27 Feb 2019 06:51:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7662A2CFA3 for ; Wed, 27 Feb 2019 06:51:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6AC262CFBB; Wed, 27 Feb 2019 06:51:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C48B2CFA3 for ; Wed, 27 Feb 2019 06:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729446AbfB0Gv4 (ORCPT ); Wed, 27 Feb 2019 01:51:56 -0500 Received: from mail-eopbgr70081.outbound.protection.outlook.com ([40.107.7.81]:60384 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729412AbfB0Gv4 (ORCPT ); Wed, 27 Feb 2019 01:51:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yiUZKMUz1Spk6zagFdbMY9OCtu6VMqEJToNJ27Pu8SI=; b=POzL5aLbduoiKX3jLsM7t9VM4pf3QgqAbPRmrwRlZMlLJmoctO5lgJgLsHoCGyBRrqj7/IzE6TZWKnNPdHUj02Hn3An9YoWjNbvSKzQ40U9frlGvqzJdtX46a8WoXCCc9w5meMaptt63QkyoMb6scU3QZC8KnS0y80Hyc5VjwxU= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.52.16) by VI1PR04MB6271.eurprd04.prod.outlook.com (20.179.26.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Wed, 27 Feb 2019 06:51:36 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2%3]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 06:51:36 +0000 From: Peter Chen To: "gregkh@linuxfoundation.org" CC: "linux-usb@vger.kernel.org" , Paul Kocialkowski , Peter Chen Subject: [PATCH 4/5] usb: chipidea: Grab the (legacy) USB PHY by phandle first Thread-Topic: [PATCH 4/5] usb: chipidea: Grab the (legacy) USB PHY by phandle first Thread-Index: AQHUzmjhRDnCBITnMUSYbLO4wbcMhA== Date: Wed, 27 Feb 2019 06:51:36 +0000 Message-ID: <20190227064908.17731-5-peter.chen@nxp.com> References: <20190227064908.17731-1-peter.chen@nxp.com> In-Reply-To: <20190227064908.17731-1-peter.chen@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.14.1 x-clientproxiedby: HK0PR03CA0034.apcprd03.prod.outlook.com (2603:1096:203:2f::22) To VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:60::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82a377a0-4439-411c-a97c-08d69c80043a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB6271; x-ms-traffictypediagnostic: VI1PR04MB6271: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB6271=3B23=3ApJ?= =?iso-8859-1?q?PVlXJDGwqfOOmRAIKR9g18oI/EX5b+T0rsr31tFgdLTsMSVmgnSq38I2P9E/?= =?iso-8859-1?q?eaki0wMLvs5X0X3hKHIf6ySTx2FNGkn5w8/HeiPK97r6b1vPFBL9a/pwF5pw?= =?iso-8859-1?q?Ri5nYLRIS+M3Cv1CR3h4+JeRANZ18SoWamS8Ul6Cap+/DxNL1zbvpqNMh55a?= =?iso-8859-1?q?or24dhoRgkO3FNRBMlyKgp+K2/oZzKB/sQEUNfbPuQ+Msb94/DuJ23honIYH?= =?iso-8859-1?q?4cfzIPo0SKCQ9aQWzzEKT3VR1BBY91/V73irwBkoOuflorwflw+fq8Dmkj+M?= =?iso-8859-1?q?YDvNmFWz2Vc7feTEjEoyxQ/VsjvLOcBciLrdd7IGAROWiRplxrZPPplgVOhC?= =?iso-8859-1?q?4Il4IwrAkmJIfMxYZcwn71WI/zDyK0zGY5L8ZZ5+DHw3ijOcqcsSH8S/qjAY?= =?iso-8859-1?q?ekwhsw3uRmzRLx6RMjtDLXyEE6kMYPE71eoOoCTgadWmcp9UyVrtgJa0DBSz?= =?iso-8859-1?q?lLitYVUon7P1rxplV8Zm/WNquf3KHfsjwlHTz30z6zKskuSyU7etp9dRx+JO?= =?iso-8859-1?q?sMJMC9dxq2JFik+ioiDazaxDbbZMKzT3jWBip1Nq/Mmx2f4JE6RV2HZWJ79R?= =?iso-8859-1?q?bTKC8Tu13KL/9ToXpIKf/MfB7IAGTma2amdrGh+PvcWbu2f4iWFc7nGZicHC?= =?iso-8859-1?q?4pjGwNVg9/FYVR982fbFssjvpqSua2uEOG13v2ZqtH+Bi3wwSuW0HjosakFt?= =?iso-8859-1?q?Wgz+7XftGhXVtwBwvVPBDCRmnKVKpYXWwWk7z3Klq5sqp5S5gOOe2FKD32+d?= =?iso-8859-1?q?tQInjOvCehD4w68MQgQXJdkOJ0R3mkcX30ihkvSiw448S3VOGJutpLUKOzUB?= =?iso-8859-1?q?wAMtznJQUMxobLX4UWCAXe3EWt1+dPcAZmzlBkgBGbJhfl27sjDslEdZjks8?= =?iso-8859-1?q?Hy/Ui0GzlRDUWZBIq7i2Eu0asH1k3H38cA955XLyxBMy3ngaZXPFKtFwZdqO?= =?iso-8859-1?q?GkZESmfw3nZphxsipa3T80zYfIpPYsJqjTWbF3QilL3hClKBgSxUe7s5DzOz?= =?iso-8859-1?q?PZqSPhSd0ZoRlmoADQ6hMGc2w65pDl5uZS8gE+UkFm/FbqECx0Mp0mYu1d8C?= =?iso-8859-1?q?MntCVQuwsrvUkHwhqlDkx67Ewm1qAK0/TXl0YgxsMsneZLSY8PizzBcsK5EX?= =?iso-8859-1?q?05bpNDR4mBJITUWiHVlW8uQnxIYflawgQrENFhFTUVbCkaazwdm4mTCJ/YX4?= =?iso-8859-1?q?9DM2QzYP+D1jn5BNFbltvaDu3G/j7KRVAe0SY5gQaRh+D5UZmIXHREQ1jyVz?= =?iso-8859-1?q?NkP0SOgfywS1dUqcTwKip/M2VmEZ/U9g+sOa6q3IluUGaC6bSQb1X/9QQzvI?= =?iso-8859-1?q?N6LlxGFOHDUY8W6WI1xDoZ?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(376002)(396003)(366004)(346002)(39860400002)(189003)(199004)(446003)(6486002)(6916009)(478600001)(1076003)(5660300002)(36756003)(2351001)(26005)(6512007)(106356001)(386003)(186003)(6506007)(68736007)(486006)(102836004)(5640700003)(6436002)(44832011)(105586002)(81166006)(81156014)(1730700003)(97736004)(8676002)(14454004)(54906003)(76176011)(53936002)(71200400001)(66066001)(6116002)(71190400001)(3846002)(8936002)(2501003)(2906002)(50226002)(316002)(476003)(2616005)(99286004)(25786009)(256004)(14444005)(52116002)(11346002)(7736002)(86362001)(305945005)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB6271;H:VI1PR04MB5327.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5SGtULq9ZP/LtWM4hSzQU/sWBvXzFB2d8U7Ofv5F5iS8RcL5i6oJrkZ/p64oePW3DVI4HYeX4h4i0T48tqY9ain/iutRdHvXbga6Lx/VHssNQVOkWBi6LscXEjsnEL2q8E9rTpBIKkwKaLjvE3D161yYWmbFTAYZ+tAjsQuJKt18p45QAaF6vkoGJpek3HScSomCYUNB0XNjjfUep1T1DxuDgcHtRjoE9MImgo0F0jRhH/H/xtYfuJoi0tSOrUKg+YQS8b4ROia7ysgIwyvV7V6clrmgsXyNS2NN8RCUtTYauVtTGTKxrsZhqaUAv6RkZdU9bT0BGdSeA7ea57wlm37RnXpluQuWkUyAVEUcz5u4vLQS636uAhGfEGBxfNRuh8zL+poGepsQqQLLNb0z+zRYsyOoTNeU7bEEVPhLhDQ= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82a377a0-4439-411c-a97c-08d69c80043a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:51:34.3722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6271 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paul Kocialkowski According to the chipidea driver bindings, the USB PHY is specified via the "phys" phandle node. However, this only takes effect for USB PHYs that use the common PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY type is done instead. This does not play out well when more than one USB PHY is registered, since the first registered PHY matching the type will always be returned regardless of what the driver was bound to. Fix this by looking up the PHY based on the "phys" phandle node. Although generic PHYs are rather matched by their "phys-name" and not the "phys" phandle directly, there is no helper for similar lookup on legacy PHYs and it's probably not worth the effort to add it. When no legacy USB PHY is found by phandle, fallback to grabbing any registered USB2 PHY. This ensures backward compatibility if some users were actually relying on this mechanism. Signed-off-by: Paul Kocialkowski Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 7bfcbb23c2a4..016e4004fe9d 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -954,8 +954,15 @@ static int ci_hdrc_probe(struct platform_device *pdev) } else if (ci->platdata->usb_phy) { ci->usb_phy = ci->platdata->usb_phy; } else { + ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, "phys", + 0); ci->phy = devm_phy_get(dev->parent, "usb-phy"); - ci->usb_phy = devm_usb_get_phy(dev->parent, USB_PHY_TYPE_USB2); + + /* Fallback to grabbing any registered USB2 PHY */ + if (IS_ERR(ci->usb_phy) && + PTR_ERR(ci->usb_phy) != -EPROBE_DEFER) + ci->usb_phy = devm_usb_get_phy(dev->parent, + USB_PHY_TYPE_USB2); /* if both generic PHY and USB PHY layers aren't enabled */ if (PTR_ERR(ci->phy) == -ENOSYS && From patchwork Wed Feb 27 06:51:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 10831291 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 21E2B1669 for ; Wed, 27 Feb 2019 06:52:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0CF9D2CFA3 for ; Wed, 27 Feb 2019 06:52:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 016B12CFBB; Wed, 27 Feb 2019 06:51:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8690A2CFA3 for ; Wed, 27 Feb 2019 06:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729479AbfB0Gv7 (ORCPT ); Wed, 27 Feb 2019 01:51:59 -0500 Received: from mail-eopbgr70081.outbound.protection.outlook.com ([40.107.7.81]:60384 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729412AbfB0Gv6 (ORCPT ); Wed, 27 Feb 2019 01:51:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrU4P4IhfdnErOn4BTFdrftuImsGA/1Jse5vhxE0PWI=; b=PEdBQ4TWvozvbOstqQBTYDuoHukMHXeZS5qMquUvC1lSWw3dQgwRfVWX1IQYplKS6qR+MLkNJREVkSdLibqFqzLiHGfZ9Wta3qtseiHKK2vtLybUcBa2Tc/C/L3GL3lbiqsS8+qlswSkxXkV2D09ylPhjh+4EPVoCMKWHyHR5Ck= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.52.16) by VI1PR04MB6271.eurprd04.prod.outlook.com (20.179.26.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.15; Wed, 27 Feb 2019 06:51:38 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::790f:a219:bcbd:6fd2%3]) with mapi id 15.20.1643.022; Wed, 27 Feb 2019 06:51:38 +0000 From: Peter Chen To: "gregkh@linuxfoundation.org" CC: "linux-usb@vger.kernel.org" , Paul Kocialkowski , Peter Chen Subject: [PATCH 5/5] usb: chipidea: Refactor USB PHY selection and keep a single PHY Thread-Topic: [PATCH 5/5] usb: chipidea: Refactor USB PHY selection and keep a single PHY Thread-Index: AQHUzmjjrb8FaVuwv0q25WsLU8rI+A== Date: Wed, 27 Feb 2019 06:51:38 +0000 Message-ID: <20190227064908.17731-6-peter.chen@nxp.com> References: <20190227064908.17731-1-peter.chen@nxp.com> In-Reply-To: <20190227064908.17731-1-peter.chen@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.14.1 x-clientproxiedby: HK0PR03CA0034.apcprd03.prod.outlook.com (2603:1096:203:2f::22) To VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:60::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4f281da-bba3-424d-3df1-08d69c800585 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB6271; x-ms-traffictypediagnostic: VI1PR04MB6271: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB6271=3B23=3AQA?= =?iso-8859-1?q?lwqk4NrXvgev6W2mfm1j3fDPGBrW6cvwLUQw8qw1UScOzyFWkFciL3JGtC9c?= =?iso-8859-1?q?SjY7vqLEJSTKAH7TH3YoMJ8To9nxdRiwoaxeVOKlppjsXXiA4ovh7AjvH4HH?= =?iso-8859-1?q?P5hOfDN+P2waGcjdEsuYeLbdh1xO0J421TAdAM+T70UBQJhfvKNZlBhLI4Sj?= =?iso-8859-1?q?va4uFx0iXmm4ycAZpcUWMdryC5dUh8/6Qe1CGSH91ojBe8txFnXRO3tSbv/6?= =?iso-8859-1?q?6+Sv9flmGH15tYXLEnrWqotEi+yUO30Zlr7+INTFlWlcqJfUof4SsUNPHV7V?= =?iso-8859-1?q?vH0KgVKZS1OAPo/l36jYCIU0bD1tNr/USbNMOurvyHU0KdtpyxYjdJyBDSdU?= =?iso-8859-1?q?PdZ8SYntk2ZsU8zD2rSxb+yBOVMlzkijK9yXJ27g0mAo87fs+lxI0txR7Dbs?= =?iso-8859-1?q?huWLeykitOx370dtpZJXphxtxVgXM05mVLHINTSrgP2GHtSNXFGDeh0NGX1u?= =?iso-8859-1?q?QsC9oFe8WieIwJDBYThjULm1QUpIauuXBbYeudDr06l2CoIXx2iECnqZtC7G?= =?iso-8859-1?q?HQ/QBQMPSr0bB+oSOTn7idiVOdnh/yjLbauR+o9LnXbzi1vO0KH8koEAGSUG?= =?iso-8859-1?q?iZyAAdbN9MpyxW9gdWrsBimx50a5O/nWPhmNfy67vubcdDS6jOTOV5w/XhLP?= =?iso-8859-1?q?ec2iuv5nG7rGYtr5TQgjKSUbEaxCBdP4wRaGi5pPOh0eRaB1e3pTz3w0jtAK?= =?iso-8859-1?q?YZpzHn0uysputbTlFXht/cRLXKC1FoiE6B5x938g/tyMrlpUwZ/h1HNWbLZU?= =?iso-8859-1?q?UfNU1WP+8qQgzGc0J946ZInS2BGZ0JvLuIpJfQxqj5UjvZvuKJa7EzfHg81p?= =?iso-8859-1?q?sNy7YAytF2w6m0KMqvvC3swFcINZ1MfbDh8S3A0Ez+X539gafNJDQeaCrgW/?= =?iso-8859-1?q?04Lrd5LBR2qU0rVQzMoOAjHYpIXm6Q9RNQX3EQcPVmB7EKgT29d2o4fmbreR?= =?iso-8859-1?q?NMpzNrgRQaMkHwgDCeh28JuyTq2CAf18zcLIyFMJTHsj0mns+MIaZZt5dkHf?= =?iso-8859-1?q?ewwEP1k7xSR4fdklQ4Gosaz6YBbgg1zud7dyYN0zJExs1Yo7vz5/m9virt13?= =?iso-8859-1?q?wseuGwvjvsnt0nSrOA92s7pLEgj6L3x0FfW8V7A0cPJ/UM+rXOmZBA2LNMLM?= =?iso-8859-1?q?ZUZcixt9Gvn8r+xGMN/3aupXMMXw2W29Ae9YgCwpjFoH9nfVVpKkVRv+Q3Kv?= =?iso-8859-1?q?eLVyCczD+szgR9roaEBwH1/IvrO+/nmuFqS7uJqi1USCu5rL7XV6b1PObq6I?= =?iso-8859-1?q?y2DJgN+91bS1kp4D1DcD6W0oOj9sfaRAB6UEq+2hLtIGraLnA2zQkTmPbyvm?= =?iso-8859-1?q?M=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(376002)(396003)(366004)(346002)(39860400002)(189003)(199004)(446003)(6486002)(6916009)(478600001)(1076003)(5660300002)(36756003)(2351001)(26005)(6512007)(106356001)(386003)(186003)(6506007)(68736007)(486006)(102836004)(5640700003)(6436002)(44832011)(105586002)(81166006)(81156014)(1730700003)(97736004)(8676002)(14454004)(54906003)(76176011)(53936002)(71200400001)(66066001)(6116002)(71190400001)(3846002)(8936002)(2501003)(2906002)(50226002)(316002)(476003)(2616005)(99286004)(25786009)(256004)(52116002)(11346002)(7736002)(86362001)(305945005)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB6271;H:VI1PR04MB5327.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Xs6MUO0FQ1CkGJxYzpId2yuhi47Ods25V9M28TwVutCXvVORgLfm0XYTdWxKdy5Rfk9FX5abPfrDIFIUh/zM0vLDVwBwIoM1+x9qy+xbWGcRkUls1E+JPgiqw+Ip4Flz4+e5J3KYxGO9cdB87pMWjsbqZJMXaGWecNBUieqxPcnwxXOdrIWYfmCU6ejkYqcbATXQuEwK2s/432MSpuyjHf589K/SVPfl5JY8f1o7S2/bSqR6aHqE920BdmI5NS/3s1E/kPGgvq2rVkqx2/jcrNoMfPprFwNH7h6KN0jM4MrbdKMtcC4MdZjXRgzMrivSP3cKUlG5QayoHLcG385JrC4n0kEMtHew0QDWFWKEQfe0LO48V24LH1LOLq4zxkL59gVtir2Y+DHT4/RQeWJOJd1V9BRhO5OuAo/r0SEuIHc= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4f281da-bba3-424d-3df1-08d69c800585 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 06:51:36.5317 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6271 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paul Kocialkowski Refactor the code in charge of looking up the USB PHY when no platdata is provided. Attempt to get a generic USB PHY first, then look for a legacy USB PHY through device-tree and finally get any registered PHY with the correct type. This way, only a single USB PHY is obtained and the flow is easier to understand and follow. All error pointers (except for EPROBE_DEFER) are considered as PHY not found. Signed-off-by: Paul Kocialkowski Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 49 +++++++++++++++++++++++++++++---------------- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 016e4004fe9d..27749ace2d93 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -954,32 +954,47 @@ static int ci_hdrc_probe(struct platform_device *pdev) } else if (ci->platdata->usb_phy) { ci->usb_phy = ci->platdata->usb_phy; } else { - ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, "phys", - 0); + /* Look for a generic PHY first */ ci->phy = devm_phy_get(dev->parent, "usb-phy"); - /* Fallback to grabbing any registered USB2 PHY */ - if (IS_ERR(ci->usb_phy) && - PTR_ERR(ci->usb_phy) != -EPROBE_DEFER) + if (PTR_ERR(ci->phy) == -EPROBE_DEFER) { + ret = -EPROBE_DEFER; + goto ulpi_exit; + } else if (IS_ERR(ci->phy)) { + ci->phy = NULL; + } + + /* Look for a legacy USB PHY from device-tree next */ + if (!ci->phy) { + ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, + "phys", 0); + + if (PTR_ERR(ci->usb_phy) == -EPROBE_DEFER) { + ret = -EPROBE_DEFER; + goto ulpi_exit; + } else if (IS_ERR(ci->usb_phy)) { + ci->usb_phy = NULL; + } + } + + /* Look for any registered legacy USB PHY as last resort */ + if (!ci->phy && !ci->usb_phy) { ci->usb_phy = devm_usb_get_phy(dev->parent, USB_PHY_TYPE_USB2); - /* if both generic PHY and USB PHY layers aren't enabled */ - if (PTR_ERR(ci->phy) == -ENOSYS && - PTR_ERR(ci->usb_phy) == -ENXIO) { - ret = -ENXIO; - goto ulpi_exit; + if (PTR_ERR(ci->usb_phy) == -EPROBE_DEFER) { + ret = -EPROBE_DEFER; + goto ulpi_exit; + } else if (IS_ERR(ci->usb_phy)) { + ci->usb_phy = NULL; + } } - if (IS_ERR(ci->phy) && IS_ERR(ci->usb_phy)) { - ret = -EPROBE_DEFER; + /* No USB PHY was found in the end */ + if (!ci->phy && !ci->usb_phy) { + ret = -ENXIO; goto ulpi_exit; } - - if (IS_ERR(ci->phy)) - ci->phy = NULL; - else if (IS_ERR(ci->usb_phy)) - ci->usb_phy = NULL; } ret = ci_usb_phy_init(ci);