From patchwork Mon May 27 04:45:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13674567 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FECC25B74 for ; Mon, 27 May 2024 04:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB09E6B0085; Mon, 27 May 2024 00:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E60376B0088; Mon, 27 May 2024 00:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27586B0089; Mon, 27 May 2024 00:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B3B496B0085 for ; Mon, 27 May 2024 00:45:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3338514124D for ; Mon, 27 May 2024 04:45:32 +0000 (UTC) X-FDA: 82162937304.18.B4E36A2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 05247140009 for ; Mon, 27 May 2024 04:45:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gPTRxz2P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bxxPY0R+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gPTRxz2P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bxxPY0R+; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716785130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=oHKis1I+pOLkw8HJby/EOpRamivMlzj/kg+HseG/UBU=; b=xccp0qn/J0wQCZQBPOVF8TEoQVI3ok6HUuaDhHhyaxOMBTT4v7+Nip7/C96I6WTE/iVd9i gu48RKcQugQ3b7qtvT6TV0g3KDfsx4WlaXHMTjIjs8ZBhNeAS2PkfjVJeepus+yND7RRJW cdh+fTRAGcX4PZWKGFTqz/ij4OohNgM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716785130; a=rsa-sha256; cv=none; b=HFDryxhLV2OvsHhvBbefFnEJ6GIvmvJ2V1ufpWCI+f8PhZqTiAH4EPUdm0Samjl542Tlmy VBtxxUl3OP43AvK19SvgI8sEk/bGS6EFg0IL30U2RLRzmTZlSiTXz4m2rK/oIgsfYiypDE sZK6ASaEbZ4udluQU0wvEj3I+QSDcMo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gPTRxz2P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bxxPY0R+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gPTRxz2P; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bxxPY0R+; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5091821C1F; Mon, 27 May 2024 04:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oHKis1I+pOLkw8HJby/EOpRamivMlzj/kg+HseG/UBU=; b=gPTRxz2P1cvBtmYcISxLv90rBSx3eg7xf6Q6e8Ne/Tfj7nXS76Fjso7cuhVUtMwfrU4RnA gU0/lKD3rJuI24MQn1LtOPqjLGl8bLdQapZ2VzOVMuLFcsb2JSD6rQoaSVLqGtzvz3aKDx sz0Tn61BUi9pAhhWVVN8x+yoV41HlWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oHKis1I+pOLkw8HJby/EOpRamivMlzj/kg+HseG/UBU=; b=bxxPY0R+FYw57tSbnus1M4y/dKtMOYwZVxJjS9186MtJq3Hs7+kHx4JfEOtATQJ+douKwR kcZE3+aooqjGCvAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716785128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oHKis1I+pOLkw8HJby/EOpRamivMlzj/kg+HseG/UBU=; b=gPTRxz2P1cvBtmYcISxLv90rBSx3eg7xf6Q6e8Ne/Tfj7nXS76Fjso7cuhVUtMwfrU4RnA gU0/lKD3rJuI24MQn1LtOPqjLGl8bLdQapZ2VzOVMuLFcsb2JSD6rQoaSVLqGtzvz3aKDx sz0Tn61BUi9pAhhWVVN8x+yoV41HlWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716785128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oHKis1I+pOLkw8HJby/EOpRamivMlzj/kg+HseG/UBU=; b=bxxPY0R+FYw57tSbnus1M4y/dKtMOYwZVxJjS9186MtJq3Hs7+kHx4JfEOtATQJ+douKwR kcZE3+aooqjGCvAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D5B1913A6B; Mon, 27 May 2024 04:45:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JZ3/MOcPVGYLMQAAD6G6ig (envelope-from ); Mon, 27 May 2024 04:45:27 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Dave Hansen , Oscar Salvador Subject: [PATCH] arch/x86: Do not explicitly clear Reserved flag in free_pagetable Date: Mon, 27 May 2024 06:45:23 +0200 Message-ID: <20240527044523.29207-1-osalvador@suse.de> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 05247140009 X-Rspam-User: X-Stat-Signature: yrf5dn9we4ig5ays5kyxhxabpuqpon7q X-HE-Tag: 1716785129-402101 X-HE-Meta: U2FsdGVkX1+uVC73tX0CkOYiRBFr29fHTs/e8uRwIMsfw9tD6LaBR1ujSyWZPBZJM05CAeK4BXDRFeKa5ytQnAutDu4PEw3Ir+Ks356RwLkG2TlAVc1Bd73cVGaAr4Gan1p19GBBZ69r+SQsYtnH3ZjiOm9d/Qbyqu8McU7FHvdnGs5cA/IqoC2ZteY7XFYhaB0hRKyu573eQfvHhv4nXJ4qnAPGcQWxkttno+YI/+IjRruTqGMHAu3H8Jn7wp96J2TccRFzbDJqgHS6q2qyrYxd8rBZnYSOIbZy/bSsNmDO2OF7k4f+LAC9llVGUxihUMmLMNQ2DXKGnvm2+bvfbB4BnlAukKXOteNYfrKHtDiIqpyg3UMoO75/qB6p42/2n8uFXOkdF10o6+iLcnt79xaw/ZL1PhAU8xWuTah99SNxTePerwMqpUeeFj7vg2tOYuMzcjeib0AwBhb1ibYyTmm9lO+qZ5EQNSz26dMnVwHRW+8D+G/DQ9xuMpAFCmE81ipkFphsutAfqVVrm3cktGUHCZFos29eTOR1Hy0KQ9W9m66jZCFw2bjnNVa0Sj4KXidbI9DuByLVrs+aVpPrslc0zqsrnWC2aCfnkHmIY2KqrSyHL7wuTufDo3eacslsyqXb6ixBSe1IbNyUZYISqRv1rZ3k/LKfJhutp9gdYwUXmXc2i5Vyvq6wfJfTekYcD5CuHAMcoY8iNTpVEmK0Rfq8rMyBxTBfod3usfQwmoXcl/RWt+Yy5cTLJQDrH4o5TFQT85ERODRGmrKusDXRN7Kqnh316gD/alI0nB+yxUtnOvMdmuhgYsyfCFSDosYJ3rAxxTp2IW7+8R7rxWFiWCbcNqrsfWhhGMax0GcR3O1ZtAM1cc8WZ0xr4O4eR0F77ILe83Pxh9sS4vJMLZERC2vnfFBb5HXkzpkLCuJUT0FPhE6SZ5q7vQ3gOjva0pAWy8ByycHykhGBfV6vKxS ohwzSdFo jflT66/4am+Lmqkymqw+FH8edQAlqtZdxtYVDLOHLrOia+wU9gXqHb8/J0Pj6IM8quSle5du6nbF2umKGu44CO8yjx5XKvaae7vvir9QmJe16DjSJXeks67+VmihtXdc0dU0jT/Rdc9x7X5U7LMfqqWLHNhfmtibCnVCeyjWvEF6n41qTsQ468E1vW2G/glCLzKfecliPVnzQDpS/XrMj3UbgKuAhT+EvZPLPVMj5L8eHU/q6QJIwhnrjGePyWBcYra2B91BnyawnGlqBw6CLKGUyUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In free_pagetable() we use the non-atomic version for clearing the PageReserved bit from the page. free_pagetable() will either call free_reserved_page() or put_page_bootmem(), which will eventually end up calling free_serverd_page(), and in there we already clear the PageReserved flag. Signed-off-by: Oscar Salvador Acked-by: David Hildenbrand --- This has been like this since commit ae9aae9eda2d ("memory-hotplug: common APIs to support page tables hot-remove"), so I might be missing something obvious, but I cannot explain why we would need that __ClearPageReserved upfront, when free_reserved_pages() already does that for us. --- arch/x86/mm/init_64.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 7e177856ee4f..9f4778c2cf9f 100644 --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -980,8 +980,6 @@ static void __meminit free_pagetable(struct page *page, int order) /* bootmem page has reserved flag */ if (PageReserved(page)) { - __ClearPageReserved(page); - magic = page->index; if (magic == SECTION_INFO || magic == MIX_SECTION_INFO) { while (nr_pages--)