From patchwork Mon May 27 15:48:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 13675544 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039DEC25B74 for ; Mon, 27 May 2024 15:49:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D1AF6B0089; Mon, 27 May 2024 11:49:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75A0B6B008A; Mon, 27 May 2024 11:49:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FA876B008C; Mon, 27 May 2024 11:49:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 385456B0089 for ; Mon, 27 May 2024 11:49:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B49681A07BF for ; Mon, 27 May 2024 15:49:03 +0000 (UTC) X-FDA: 82164609366.25.5FCADFF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id A89AB40003 for ; Mon, 27 May 2024 15:49:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hHCT+3Pn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716824941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=yAicwoPMKSSb7qAx+AbzoJUYT/07gUTt/oLzI/9bm7M=; b=w84F/KJsDPhme48AK+SbNSgdNoyw4TZ/tg32HuPejWGpu9B4UX3g/u6YmqxIIv8SBDWP2r Ow59DdNlmWbbiFwEmqv4O5N3FxAIKfp0i8F580iQPQV8bN5//bscytBUP2hh/seBu1d3WU H0THrCbqIAQnkhsCr5PulcyQaysOpAE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hHCT+3Pn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716824941; a=rsa-sha256; cv=none; b=zJWNKqpSRHNEd3FELV++RJ3LXFk1jHb2aJz6niycLwfSsWSrR+b68M0OPgsH5vgqZjoMlT /yXj72v+LIL1arDTgVUJJ/9lNGGmohg5I5Cj3O1ed/PVSObe5jBt1MmuyIT2CRzzk0P2jy hs6mTsVUlqFcG4WChkBBqclTbyoqI5U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716824941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yAicwoPMKSSb7qAx+AbzoJUYT/07gUTt/oLzI/9bm7M=; b=hHCT+3Pn4hcSWM8fnELZcHR6F0nYDkHks2qnh8Y/9NA/bagZBhB2Za8fLOId1k9sOIDz3Y vjGq8+Etr6itG/a3dtF6qWbN0C6eZES3a2u3sRdAdZX4FQup8DthcTWvgsFbRkFSk6T8fS XOdmxdVG58tUqF2vEHSd2KHeim7o/8I= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-jUS0HywHMVaYg_I7msrRvA-1; Mon, 27 May 2024 11:48:59 -0400 X-MC-Unique: jUS0HywHMVaYg_I7msrRvA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6ab894d8211so97336d6.0 for ; Mon, 27 May 2024 08:48:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716824939; x=1717429739; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yAicwoPMKSSb7qAx+AbzoJUYT/07gUTt/oLzI/9bm7M=; b=wLCPKmp8aLNzn2F89HsTpfyRw1UmGFZ8DDq2qJvi1iawUgZxrmVUIMYac/lLMk8BzB AMOrxeZNwW/jOXRA5R2srHrL+X0VJs7ruIJ20Y2wSYKT3FJKPpc0LDtBDQkg7EUqgekW dlcHfuJ3d99AMRzgGzyjdvNkhnSx7w3WBAXi7qQntjceyJ9wdxhqRyvzj2hkeE6xe/mb ov00ml7r7ZfXxDU+KQJOwD7aUFEz8n0coTDtEfwlboDlhTD86D/Wi8fBiH0kUTRw4pGH TzsWc4q7Hp3bOoSXDrolFeiaBXhwcQDFFbOGq3xFGHJ0RElMk88SIG+36vB6nKxFEwO1 hAQw== X-Forwarded-Encrypted: i=1; AJvYcCXnzSxs7/cBwM7X6T30oHJyDS5mw1lljVAXucciYz0tHw09o0uTcrWralmRFPrmWcqoD6pqn1sDfT5xslNAy+X/hXc= X-Gm-Message-State: AOJu0Yx2nkUx/qvVL++rng4kA/Je2oILcdvmSG2LuJw0rJL8ZMqIprly nZ0nU2AFIi4FrXf51OP13lXY+05KuTINcHVZegn/uqcRJL6uqea28Z23RSiCY3kX8k7t/wYwD/Q FXlGv/L6is5gOJ1o1OD/JvEGcBERv/Idwndqt3iXKEEIIQcru X-Received: by 2002:a05:620a:46a0:b0:793:17f:18ae with SMTP id af79cd13be357-794ab110986mr1258495785a.3.1716824938237; Mon, 27 May 2024 08:48:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmqHDczcrltkmD4V6I6X9MZqEa2VhwAwSvr2qZNwDgwFTlINj7zzFZvIGFpxd0Ohz0I8RPyw== X-Received: by 2002:a05:620a:46a0:b0:793:17f:18ae with SMTP id af79cd13be357-794ab110986mr1258491285a.3.1716824937466; Mon, 27 May 2024 08:48:57 -0700 (PDT) Received: from x1n.redhat.com (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-794abca63desm305917785a.5.2024.05.27.08.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 08:48:57 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: peterx@redhat.com, Andrew Morton , Jason Gunthorpe , Christophe Leroy Subject: [PATCH] mm: Drop leftover comment references to pxx_huge() Date: Mon, 27 May 2024 11:48:55 -0400 Message-ID: <20240527154855.528816-1-peterx@redhat.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Rspamd-Queue-Id: A89AB40003 X-Stat-Signature: 4ao9doqj849nrw5uncrfix6ydgup9r7g X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716824941-751771 X-HE-Meta: U2FsdGVkX1+94Wq01ytli/yeNqCWEvhzxXEx1iIV1ObGD7YCjJB868JzEtIVtRCEFRpjYsBOfXD9I09gJbT3lMkExpruTKEiOee2EgWiI0U6vZjuIRjInVDhyYUZ+K7E+vnOxJcdG8oniqCLY+5tURgffuw6VJK+a0dlv9vig7z0hQ4QPm5KfKBbJWpYXm5MesBzeJK38swTocss+utTYX9ZjDr8wSZgdwZlCJeuuUAxc6OATpXOjMUy3sy9i+4Msio0EMcLOscveOR67xGB3fLNT5bzyOC4BkldQMOcZKiUsPna5MDPGXF3C73jmm91+HpCJopUKmyU5+9X1uPx1kGhKUgyEIIR8xxocEQx4vpm4d7EGrsOncviei7jCBC7e1CfEfJPncVYAMTAHQyxTtuE4GZAMxIgXS4VeCGFmH7Ishh8arJi8WLqhhNYV/ZkbvcijGJ78kybkUzDLQkH4+j/i9Xf3DtRniXSayxHKL9Z4ti9sCkEiuz0EncZkIKSqpMXt7NbrNTh9mQuDJifYcPS8WnSCsWFxEajr4r1sai7SqfmRHWYepWFdsOlCD6X4uIKdxWqUkWe/GTjA8UhkOibOyxnB9sY/VllYSGJIDxgdLDqkobNk2RMFbzCMzt58tHnnbd+0Ju9LBJGQhiVdBsx/sUVrqcR/+jLjm+j7OgSR6MpQgrYkp6Qc4szGuPeUDGpF18EATRCkvN10cLWLg/oT4UOc3gvaWmJA37D47IjAL5bfeh8iEkga1t58X1G5TWnBzbwD5TUE9LrwTUITyPxeRA1tmEspcegNot/TRKwK3qbNrw156eFKG6Utvo1lXFpngKDYgkgouhRzYoCktXZcG2l0H3Dn/m55WFXCIww/ichRu6qBdhYQmYW6C58SLl/NtMZ/kpJJkjWKBtaT+7pqN9fEjK3JJUVr9LKz3UZOMvh5q40XwX6vgsr0JcvDE8VwR9QpQIx6VSkh/y 5zk6LLgv dFGFxt8peLF1ITHraz056Wd9iqOS19DNQvFxqJoDYw66STvKuTwrK4F+Wxmu7pwsCNm/3ks/3LFzAIvz1LHt/nbL/v393ppZbyr2yZKL2qkp0OItj0EoHz/CV02IzJTm9YgtGH3Hu9QuTp2Kk0Xf9sUqWeiT4fP0sD+o1GDBotpfbaa/5ZSjnHrp7c3dp2enyW2l5Ra6N4FRZHPNvd+7dQH/fHAhobfwtoyIHxCW5GmW5T6K5AjXx6bwSB0n/ifAzUt1/+UGP8vdof6bZt+II4pZ+u4uvLJvIutKhPGn69sdPA3PdiWdIpXUXZ0M/FpUf5k/ZT0lOcg9sg96VGlpwtKORYq7J0SWYbquoLSnV7xcHadL6QyYLGWjpm6Sg+C87R3hqAB3BKOowUR972OiY4y9NIU/KFBMkdF4XfQ10YYuzbzb1bZdOLNAHFyDFbCaXPRS4xAIwyTGPfSGx7w7C22X529E7JRsUkDGpyxaSxV5JA4E4wx8234GBX3XgcXEM3oNTbxT7vKRvCZ8QsN557QKXXkXe86DUbF5x5xn3dnga4lUKcTJEK9dSxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: pxx_huge() has been removed in recent commit 9636f055dae1 ("mm/treewide: remove pXd_huge()"), however there are still three comments referencing the API that got overlooked. Remove them. Cc: Jason Gunthorpe Reported-by: Christophe Leroy Signed-off-by: Peter Xu --- Documentation/mm/arch_pgtable_helpers.rst | 4 ---- arch/x86/mm/pat/set_memory.c | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Documentation/mm/arch_pgtable_helpers.rst b/Documentation/mm/arch_pgtable_helpers.rst index ad50ca6f495e..af245161d8e7 100644 --- a/Documentation/mm/arch_pgtable_helpers.rst +++ b/Documentation/mm/arch_pgtable_helpers.rst @@ -90,8 +90,6 @@ PMD Page Table Helpers +---------------------------+--------------------------------------------------+ | pmd_leaf | Tests a leaf mapped PMD | +---------------------------+--------------------------------------------------+ -| pmd_huge | Tests a HugeTLB mapped PMD | -+---------------------------+--------------------------------------------------+ | pmd_trans_huge | Tests a Transparent Huge Page (THP) at PMD | +---------------------------+--------------------------------------------------+ | pmd_present | Tests whether pmd_page() points to valid memory | @@ -169,8 +167,6 @@ PUD Page Table Helpers +---------------------------+--------------------------------------------------+ | pud_leaf | Tests a leaf mapped PUD | +---------------------------+--------------------------------------------------+ -| pud_huge | Tests a HugeTLB mapped PUD | -+---------------------------+--------------------------------------------------+ | pud_trans_huge | Tests a Transparent Huge Page (THP) at PUD | +---------------------------+--------------------------------------------------+ | pud_present | Tests a valid mapped PUD | diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index 19fdfbb171ed..8b2164509b4d 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -1120,8 +1120,8 @@ __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address, lpinc = PMD_SIZE; /* * Clear the PSE flags if the PRESENT flag is not set - * otherwise pmd_present/pmd_huge will return true - * even on a non present pmd. + * otherwise pmd_present() will return true even on a non + * present pmd. */ if (!(pgprot_val(ref_prot) & _PAGE_PRESENT)) pgprot_val(ref_prot) &= ~_PAGE_PSE;