From patchwork Tue May 28 03:31:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuangyi Chiang X-Patchwork-Id: 13676053 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C0611401B; Tue, 28 May 2024 03:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716867162; cv=none; b=s2nNyXzM/ENXAKZQ+jF2qG6T8cQTctBkM1upWiN0KdEotcVzwIbC+OGE+S8vqc7muAHwm1LSgRIaGEv16/0WUZn1T1uBqYQ/dLBj6nsrsLqqPc5/fzMlghfJGcGNdnT53chCGGCzURroWbYhQJL5R7KoYglIwswGCa3AtYs+iCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716867162; c=relaxed/simple; bh=SleKNQwalY1X1sWZ99eNvJW3+I467p59CunL4Lgmfks=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QJ1tKbnibIMB4o5tWO4Cfd/G34GT/pWZlP1bUvLpR+es8ZUD6HJgs7IgCYqv10sD2fPbnPfFtxUqTkkcWAXYL5UXgyx9EV3c+YKuKyHsyGBqNVmNljFlz79u+8xFzYYjq4LUiptdSX0dcTMPNV2MZnAuIIpCG2zpLmi4PmHeO/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XD6l51WU; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XD6l51WU" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2bda88e2b23so71566a91.1; Mon, 27 May 2024 20:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716867160; x=1717471960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jLJbSBSqoq/Zyb8WJpUER3T2Y8k8wG3x9WsdChjQWJg=; b=XD6l51WUm9sSn1Yla2Pd2bhoHIoJkeXG1s1NfUzt9p79H3cWpMz0vHNQ9OOR1W0uYs 5QDWBOIkhr87ybiuohlQ5JJHSUp7d+/x7phKf1iGPySd6gCcSnPvbeTS3QxIkRMtLAwN mtec126NS/mXXP5s+Mk1rDmer2ZqiwDWh1vqeP3+hrnPWLYSPK/0vI+lijITpKhXlK0E pb3dddfsayFK84oOm+MIPCFMq8Pgpv8FZ1cFufojQ5Z2W4UvVKA6txUNtBC/mHK1rf80 23Rh3GtfrkzsZXZpceMmuMzuTW4OK7h0XRg6GR2AHqa2LJq9MzuD9Me1k8lSiI7JwGms IzPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716867160; x=1717471960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jLJbSBSqoq/Zyb8WJpUER3T2Y8k8wG3x9WsdChjQWJg=; b=NTX3vWZFlXC1k6FX7t11YBGSIagrX8H67TtnfmWClGf1/aQbIgOf6UQxJorrqFuQ91 /cIDzT29vAqq6IgNI7WgMjYS9i5ohkjfBVek6eFk2ABzAGFOyoqWkcHVJn7vHfztOExr pR4MeRMD6HRYF+TeELHiQnBHLgjQ9jmRHtRjCOIs4OOCIfWtzSuDE9BPdWHE1QvZ9TOR OHDxGwxmyEPNM9R6PAzaeKS01Pc74lodNRNtw5HJdgugu44eGTqEAF9iEThGDr0pfT8m sRvKCI3fBLfrfJs3vQ9HmWJUAmGf9e8PWFLB6VkAKPuR7r6Uxh0Oxp09Z9EzcjVFMU1X vcEg== X-Forwarded-Encrypted: i=1; AJvYcCWQm90b2L8Ev4kqBwOzhINB2IHeRc0TL5LNi1PMVGb6Qss5JiZEQgg9QHpBGAd3FMUFwvmeIuftTm/IpEQzAA/r8qzL80i5NHytZITS57qibVaEIH93ElbhYlbdTn8+zZeQNFGt X-Gm-Message-State: AOJu0YwAhfVLrWyl1uPxV/zOy1cNZYUjIylm55U58Nz4Y1fxiP/8YOtk hXwRv7Z5PCfcQ0Udg1SDiVoEubNYRjCCqh6tstLp6jQ37gyW62hmaElBD1yC X-Google-Smtp-Source: AGHT+IGvqs9EvS9l7fq4AM0aII/4Cp9J/Kxzr2kPMQsY+M6noSmTXGcunoA7KtbZwmrClItXIiBfEw== X-Received: by 2002:a05:6a20:dd86:b0:1af:dbe4:b34e with SMTP id adf61e73a8af0-1b212e726a1mr11500416637.4.1716867160520; Mon, 27 May 2024 20:32:40 -0700 (PDT) Received: from localhost.localdomain (122-117-151-175.hinet-ip.hinet.net. [122.117.151.175]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fcbec62fsm5909651b3a.133.2024.05.27.20.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 20:32:40 -0700 (PDT) From: Kuangyi Chiang To: mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ki.chiang65@gmail.com, stable@vger.kernel.org Subject: [PATCH v2 1/2] xhci: Apply reset resume quirk to Etron EJ188 xHCI host Date: Tue, 28 May 2024 11:31:36 +0800 Message-Id: <20240528033136.14102-2-ki.chiang65@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240528033136.14102-1-ki.chiang65@gmail.com> References: <20240528033136.14102-1-ki.chiang65@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in commit c877b3b2ad5c ("xhci: Add reset on resume quirk for asrock p67 host"), EJ188 have the same issue as EJ168, where completely dies on resume. So apply XHCI_RESET_ON_RESUME quirk to EJ188 as well. Cc: Signed-off-by: Kuangyi Chiang --- Changes in v2: - Porting to latest release drivers/usb/host/xhci-pci.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index c040d816e626..b47d57d80b96 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -36,6 +36,7 @@ #define PCI_VENDOR_ID_ETRON 0x1b6f #define PCI_DEVICE_ID_EJ168 0x7023 +#define PCI_DEVICE_ID_EJ188 0x7052 #define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI 0x8c31 #define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI 0x9c31 @@ -395,6 +396,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) xhci->quirks |= XHCI_RESET_ON_RESUME; xhci->quirks |= XHCI_BROKEN_STREAMS; } + if (pdev->vendor == PCI_VENDOR_ID_ETRON && + pdev->device == PCI_DEVICE_ID_EJ188) { + xhci->quirks |= XHCI_RESET_ON_RESUME; + } if (pdev->vendor == PCI_VENDOR_ID_RENESAS && pdev->device == 0x0014) { xhci->quirks |= XHCI_ZERO_64B_REGS; From patchwork Tue May 28 03:31:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuangyi Chiang X-Patchwork-Id: 13676052 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 122632563; Tue, 28 May 2024 03:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716867143; cv=none; b=MiknGawno85JSsbdO1KanYalcuO92O/I/rlXoQC0y+EwfIDdFo5E3TUo4sqW2pJH1evRsL6hrkYS1tIvMog8QjyIuMVdfk3aKaaO5ZWEgLtuSlYw/ZSAk0DAs/wlLzbdgMX7jD6TwRMupP2R/+lZydYFKR9ApNonhFnrqTOK+yM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716867143; c=relaxed/simple; bh=ny8m4xCBhnV/0UIeJvOKqCsXclSGkQHmtW+lTaQqHV8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GmsT7trDr9xa1+/GCDuvsZf/ihnwXXedu58xLvEJoUgbKOq7GfIjBFqs+xqOvIQrCV/mZIot0WBUgKP0sXwENbV7KAfuVw/K21FEwNOWqewwRtLehD9hyR6dy/Pmxc2MP7xEGNouvqRuucfk07sMORnJu1/R5PBBJTsTRIOVdCo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z2nQCujp; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z2nQCujp" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6fbd713a4a1so5815b3a.1; Mon, 27 May 2024 20:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716867141; x=1717471941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IdqVzW0uYQzAgGRGuUdCNdfOkC+1NS25yKoubiH4Tn0=; b=Z2nQCujp2wTqltCY7sHV4JJuz8YhlWZj4qXZBe6POKXuDdq9mMIPTPh7/ks3MaYND5 p90GSWyxjiP5qDAvXR6GDhthD+/jBl5+YDxcAOKo/31GpfCtYhp6JQxesU+KtElJih2W STMrXoPNGyFGg1jP7AM5/YQ2lHOhbNzXLxxdTWbnAYZxYtXcqADxrW7s3lV9YUgglVS+ qch51sTmcZmHv20HX4lbHA3yk4aM4ozSxOBbDepq9m+Voqwa9BrkzZmWliw7S0aDsYW4 LsrvYblgEtmlYrODr+7kv0f1y2Igela0PKlD2OkvzlXeugwhnFg6oU1Tuks8DMFGn7Pk 8GuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716867141; x=1717471941; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IdqVzW0uYQzAgGRGuUdCNdfOkC+1NS25yKoubiH4Tn0=; b=n2Yvq6u2/9r+9SOVA7X1U5x8BMqeDc4EixHu6gHiZW9yOZhGOKcabQK/qslvrFE/q6 SbSGbTX+k3PwX/Jg9J8dKW6qACXLqM3UCgRcLe2JK6K1MTM0rWvgLQaUsxIa0i6N6vdC h7ErwH8tvMesjCqk1zCuIoDyHf/WfKJaCgGfwvl7GVZVtDgKAZwDU6LbsEcg/cbhTAAP PWtf19OZ5VUrmRsyMvULsa4PNty/p2lWvPKnCWR+A3vFej1w9Kx0VblnXCrifnRpkoFy tH0f21Yv1N0gY3SqGN96FXHAeYbpyF6hbI+z0Lz9JTMdBJLTLEs3KYGEC85mx+HzVQGd o8pg== X-Forwarded-Encrypted: i=1; AJvYcCWMn4gC0MTwka2qZbrtJu9b03IcgfCpZsATPAQAlLbf2a8DMMZ8Y5SZM0nXJP8IbZlwH8/yqstF7G5Iu4Qni/37uccsol05Z+gZP5wwIhMJjQ98Fs6a8pG2x8EnS/M+J/14Xb9g X-Gm-Message-State: AOJu0YxdmURmWNowNlG8ZL9mpFd/fqXtzAC9RyGTLmwowY7OPD8kKFQk 19C+V0h7exLF4EsuRIuDKF/cqIyzgek14/+QD8pFxNA2ludVJIIq X-Google-Smtp-Source: AGHT+IHrcNbVZgElQpq35gSfeTumdbcaSXxticMkDbkmuD8NrdmPjwtGDqQ1qdz2uJUgC3TvjUkgaA== X-Received: by 2002:a05:6a00:4a10:b0:6f3:e9c0:a197 with SMTP id d2e1a72fcca58-6f8f184be18mr11713794b3a.0.1716867141321; Mon, 27 May 2024 20:32:21 -0700 (PDT) Received: from localhost.localdomain (122-117-151-175.hinet-ip.hinet.net. [122.117.151.175]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fcbec62fsm5909651b3a.133.2024.05.27.20.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 20:32:20 -0700 (PDT) From: Kuangyi Chiang To: mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ki.chiang65@gmail.com, stable@vger.kernel.org Subject: [PATCH v2 2/2] xhci: Apply broken streams quirk to Etron EJ188 xHCI host Date: Tue, 28 May 2024 11:31:35 +0800 Message-Id: <20240528033136.14102-1-ki.chiang65@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As described in commit 8f873c1ff4ca ("xhci: Blacklist using streams on the Etron EJ168 controller"), EJ188 have the same issue as EJ168, where Streams do not work reliable on EJ188. So apply XHCI_BROKEN_STREAMS quirk to EJ188 as well. Cc: Signed-off-by: Kuangyi Chiang --- Changes in v2: - Porting to latest release drivers/usb/host/xhci-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index b47d57d80b96..effeec5cf1fa 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -399,6 +399,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) if (pdev->vendor == PCI_VENDOR_ID_ETRON && pdev->device == PCI_DEVICE_ID_EJ188) { xhci->quirks |= XHCI_RESET_ON_RESUME; + xhci->quirks |= XHCI_BROKEN_STREAMS; } if (pdev->vendor == PCI_VENDOR_ID_RENESAS && pdev->device == 0x0014) {