From patchwork Wed May 29 05:13:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 13677816 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8585C25B75 for ; Wed, 29 May 2024 05:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g1irK9hXrrmuf907V9wzniQAhrm/a+QetRk10070N0A=; b=Fw8zWFxVb9Bz/5 h2C6GPAQD28sAs4PQJjmDX4IFune3vkBVOTcs1cV3YQ1TtsF7/YrT/tdZciMVVsk0ZGN08oMKx1ah xQ9WX3nImLAh/OJcONn7/xtrc6Rhili3iVhR+QLh2XYrRB8WDkK/SoHjKLDRnlOoPZqbFi/RGU9uY sT4lau/OxKqF15PHS5EfTCIFNPK6Th2bC6Lui3e62aLoQGDwjeupiOLmC+qGMGcqdx03LIHSN5747 m+acmNkvA9/9cja3Q2QLvEpzIuRBYFeUSZr/H9pqt15UjsVcula57aBpqrJAtI0BJ8rCeVbCPuSWn 9C+k0/XgLEfRAbJdiiBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdU-00000002qkH-3tgt; Wed, 29 May 2024 05:14:04 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdR-00000002qhg-2c1g for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 05:14:03 +0000 Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id D9B9720174; Wed, 29 May 2024 13:13:47 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959628; bh=/kCC/N3bNiMS05Tj8Fe/ikNvI4lWNncOVV0tIccEmmc=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=QYa0XjOALWVq7z6GhWeIteNJfE3k+PxHwl7GYBfn2DJ1mBhwZ+ulIvcY7QNOu3fHP t3unjjg5ZFdfppIdD+oTS8knouKCNlgCyu+VSH8WOaxMqw5Ea5EMTT4WiYXK/+u8cz 3IAXc/3WDOD5Wl59RK/KNbnLmLlj5tzkKdr9h29WFThQsoPfO4GAmkLC5Pyi296jTf hRIs7zNGKoIofzuFkSJi6ISt+gSjbcxH395uW+NM0rdNcoQUXk4+2y2kCJbSWAPS1v BIUubirGDBSFCV9e7Il+Cic5NRdHKARn7dgxpE9vrFoukJMQl7DsLvy+mjvWI/sVYr LqWMjLPWjqEgQ== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:20 +0930 Subject: [PATCH 1/4] dt-bindings: gpio: aspeed,sgpio: Order properties by DTS style MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-1-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_221401_937078_99C2E839 X-CRM114-Status: UNSURE ( 9.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tidy up the list of required properties and the example node by ordering the properties in terms of the DTS coding style. Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index 46bb121360dc..6b15a3a3fb66 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -51,12 +51,12 @@ properties: required: - compatible - reg - - gpio-controller - - '#gpio-cells' + - clocks - interrupts - interrupt-controller + - gpio-controller + - '#gpio-cells' - ngpios - - clocks - bus-frequency additionalProperties: false @@ -65,13 +65,13 @@ examples: - | #include sgpio: sgpio@1e780200 { - #gpio-cells = <2>; compatible = "aspeed,ast2500-sgpio"; - gpio-controller; - interrupts = <40>; reg = <0x1e780200 0x0100>; clocks = <&syscon ASPEED_CLK_APB>; + interrupts = <40>; interrupt-controller; + gpio-controller; + #gpio-cells = <2>; ngpios = <80>; bus-frequency = <12000000>; }; From patchwork Wed May 29 05:13:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 13677818 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70007C25B7E for ; Wed, 29 May 2024 05:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2nZVAq5hOJvK+eyKE1MzOmLxdBdzo5brn0pzbXhP9mI=; b=VZF5aW9WPWtFVp y+X80KM5ap3GuqwBTMqrduZQpkwhWHi4TqWqICeQgQAKFGP8K7btjHQt5zp47iMscRHDfys44TE/X L7K3LstabDPu8TJG1cguF/Mz3BDIpECX5aTUR7HPIc/wLPO+Rx/SyRs+0Ud4iREhhY8enPfuTXH8W FlDpGu6vF8jxdo0t+ZR4BL2w9pef0dky9facSg0lz2EsNqFeLOifE3NdzBmHffqNdPUxGynp+zGxd xQ6wy9WCzM388NmoY1TbFjRGiRA5xskrWVY9LS1mA3OtlWo/yFqEU4WrXBlaLpipZeBk5Q/Q+8qQ9 mdG4A6Mo5ZzQyPZM85Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdk-00000002qqQ-3j98; Wed, 29 May 2024 05:14:20 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdR-00000002qhh-2efS for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 05:14:04 +0000 Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 8CF14201FE; Wed, 29 May 2024 13:13:48 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959629; bh=mtqAhcAvlJCMsRl1w/jbIXT3+Kk1ZJpyaGl5JGCYoAo=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=N1gvTI6CubZtn04shoegCi+x6OuiM4Basj1czUY0afacOBp2IlU7b2uazfXHbNGs0 VXy76WROR+zEEy+mcp6LSDZJ59sb2UJASKlyesXDs5jpQZNNW5e0asVfnVgltD/p7Z pUGcVdv1pK+xROxyuVlkNlcLNZosTnOHH/OaUwLhNKfn2FlPPMMQD28FjF9Y8UANPK QyeWS6EzueZLeogFKWi4CJpsQdu2/4eMF0CbyycF6KTxajs86wfu3OLbPaRABEHhdE icKiimKaMqu8U9TC03uGxIMBHMZ/iIRwjjSnXpAD82zk0gA0+6yWI8gm0spjzH+Adq A2sp6NsUAN3Gg== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:21 +0930 Subject: [PATCH 2/4] dt-bindings: gpio: aspeed,sgpio: Specify gpio-line-names MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-2-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_221401_956393_D1CB49F3 X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Some devicetrees specify gpio-line-names in the sgpio node despite it not being defined by the binding. It's a reasonable thing to do, so define the property to squash warnings such as: ``` arch/arm/boot/dts/aspeed/aspeed-bmc-vegman-rx20.dtb: sgpio@1e780200: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' ``` Signed-off-by: Andrew Jeffery Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index 6b15a3a3fb66..fe27b5d01e80 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -33,6 +33,11 @@ properties: gpio-controller: true + # Each SGPIO is represented as a pair of input and output GPIOs + gpio-line-names: + minItems: 160 + maxItems: 256 + '#gpio-cells': const: 2 From patchwork Wed May 29 05:13:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 13677820 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A2F8C25B7C for ; Wed, 29 May 2024 05:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MmD4DaF+VFnwZxhtXRZ7xxrZJ2lu/uMMctBUGlHBn9g=; b=xzoAfC0GPMp1iV c/J5ElOOoEymblJz/pAfue9QhXyTA8JwUmdc1EHTZSgwqnf1I7khhOWrzFBlt0KPk+7zcc+3jUAqd +3ycjDvHPpzdLyhZpzo5oWgQSjPWK8amhJQRKYCZyBYUbOhM98eI1lAtV+UTNkH8NN9xcbRnxbkTx Arf5gmpilV0vwuE2qt2TxZj4A7UlEM/8MZkv8xBNC9ytbWA8onzZQYzMEP4k5fJMG1lLwL6PHJM76 MGrIm4q9TuzNQEPYktTSAqB/yiPHCeYozNq5NYcNPppBO300C33Sm6yeMHOeQtZOopYDG4uu3B69M 7uvSrccZ42xNoVIx1JhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdm-00000002qr8-0dDG; Wed, 29 May 2024 05:14:22 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdR-00000002qhi-2bjL for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 05:14:04 +0000 Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 43F322024D; Wed, 29 May 2024 13:13:49 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959629; bh=RM0WLi2RJAK84kDk7oeF/Th0CqQkfxxrTkSFxmoFxho=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=T5l8q/JkQhlJqQvasahZe8N9NJFmSYLuQ0yU3G9i4C5vTUCBKyMD7XHhRpPFfaIpM Ts5bK7T26S0UExzICplw4oGdsJS6tlHY+dJnNPlMKpUlZdC6IrtQSaFBpyTZZvtkCR aDIFiQqPBcRsGLsJqmC27MMCw2XO/6jSyeOyldx84q4IipV53vuytBBgqwE1sjFPRG YVxszLFo6dYlDUmpXt+Lp0N3z90kQ3AhH+3/YqXhWBY8vVXdmguaX/KKhtDNDrHMHj Jt9p+1+z8nc5vytFxAwoqp1AYpXglN59qW28cBWwFusHhQY+PB1CN9hQU6Ju+8us31 IL2hqk104VfAg== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:22 +0930 Subject: [PATCH 3/4] dt-bindings: gpio: aspeed,sgpio: Specify #interrupt-cells MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-3-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_221401_944564_ABDD1AC6 X-CRM114-Status: UNSURE ( 8.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Squash warnings such as: ``` /home/andrew/src/kernel.org/linux/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-ast2500-evb.dtb: sgpio@1e780200: '#interrupt-cells' does not match any of the regexes: 'pinctrl-[0-9]+' ``` Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index fe27b5d01e80..02c02ef97565 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -46,6 +46,9 @@ properties: interrupt-controller: true + '#interrupt-cells': + const: 2 + clocks: maxItems: 1 @@ -75,6 +78,7 @@ examples: clocks = <&syscon ASPEED_CLK_APB>; interrupts = <40>; interrupt-controller; + #interrupt-cells = <2>; gpio-controller; #gpio-cells = <2>; ngpios = <80>; From patchwork Wed May 29 05:13:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 13677819 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCCA7C25B7C for ; Wed, 29 May 2024 05:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+uS0pqDG3DKtyy6AUbeMnKve6eDkmfHwRGPRYjfC5ms=; b=v6SSm58lmcQyvd vdZ4pmPQgsxnLppUatRTYdlWJGIPEuoztga664VA3WMFH3BOGpIUmL5Qs3WLGxpuIt5Ozf9dyxlE7 5rZ4OldeEw0IMZueCreiuK/TGvaGfn6IY23vElHO7Q3qJdHTgVEXz++VRznVB6PN3bkZ8Sj3ZUIwU Gda48DdrgWk5m/SPs06LAkbUBJuxuTU9p00R5EioJhLr6JQtfViEkAjQX+y20tj+TPc3ApvLXhnkj 5CWIVYaOrXX5jT/EIvryaZI4+3zN9VVhPFxQyKXLZWlfCttns7g1G2kd2kMTf3dQYYYGXk8z/VO9b BbwtF6o4kHbjA9ycASzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdk-00000002qq1-0oAU; Wed, 29 May 2024 05:14:20 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCBdR-00000002qhj-2bp4 for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 05:14:04 +0000 Received: from [127.0.1.1] (ppp118-210-171-248.adl-adc-lon-bras34.tpg.internode.on.net [118.210.171.248]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 00E64202C8; Wed, 29 May 2024 13:13:49 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1716959630; bh=P8gBf6jRS53rX70PCjwXjULQnqD4pYqLyrNQvX02Huk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Ogf7jb0rwfeRUAkEBHkEOilwFfPZtc+QdoNrArChblbzGnE7CDo46q1yyT0DH/Ynf z5n9pmVMBzEXkzjtkjG0izFzI1kSxebGxNUXFvTbPHoicrexeNxg/g2BRg0reUlBvr TzUfLfF++c7HdZb/Um7ygIBpum0TyF4Gh7CMdLmoTEP3Y1kOs5WtG47/HNteyXEK5H ITUSb0lRKidY9pqHKZI/VT6P9Qdqpra5M+UyYMdvnRevOX/5pGpBuMnwizSsfbMjfm APUQrzWs2NCjULoUy++v+NaqFRZH51JSWxkfwvQcu4ML1TRmqoHKqmceMl9OI+XEcD CtDR8KeQQ1P6g== From: Andrew Jeffery Date: Wed, 29 May 2024 14:43:23 +0930 Subject: [PATCH 4/4] dt-bindings: gpio: aspeed,sgpio: Require #interrupt-cells MIME-Version: 1.0 Message-Id: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-4-91c42976833b@codeconstruct.com.au> References: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au> To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_221401_940154_2622C448 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It shouldn't have been the case that it wasn't required. The kernel devicetrees already specified it where compatible nodes were defined, and u-boot pulls in the kernel devicetrees, so this should have minimal practical impact. Signed-off-by: Andrew Jeffery --- Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml index 02c02ef97565..433b50bd5484 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml @@ -62,6 +62,7 @@ required: - clocks - interrupts - interrupt-controller + - '#interrupt-cells' - gpio-controller - '#gpio-cells' - ngpios