From patchwork Wed May 29 10:19:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thorsten Blum X-Patchwork-Id: 13678632 X-Patchwork-Delegate: bpf@iogearbox.net Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A4A16DEB1 for ; Wed, 29 May 2024 10:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716977978; cv=none; b=Rt8zRtjaOuHGL2IaU+tgtt27GFlxCN5Bo/9I1yfFh3DH6z2FxvlahmPdrs5f1nlB6Sky25m7v4q2V5hXRsAkoEc9TOq4A3cCk8mV/OrreHvCgVKETSUva7pPux12sqAjnEurAITa6Q++mXdquDJX0u4FhMZz6gEtOApZ73GuaE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716977978; c=relaxed/simple; bh=UK3IBWgP4aQut5nyGcl+mgkoY3ppthy12X9kSy1W/kw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mESjAu2EMiXY/Rw4MHWXtluIMJY/+AMxN40krx7cDUbObP0I5dSOvy3X7ul2bRNvw1sXPJg1mHABEHsKIoWeD2wy879SDV18fejkKAMPBiikBeVwVPpWjxE+LiIAcF6bcvBGblwxhwLVOP+n+NqnhC0wA+dlEYqRuEQFWy6h7lU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toblux.com; spf=none smtp.mailfrom=toblux.com; dkim=pass (2048-bit key) header.d=toblux-com.20230601.gappssmtp.com header.i=@toblux-com.20230601.gappssmtp.com header.b=leAHGD3J; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toblux.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toblux.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toblux-com.20230601.gappssmtp.com header.i=@toblux-com.20230601.gappssmtp.com header.b="leAHGD3J" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-57a1059dc4fso199788a12.0 for ; Wed, 29 May 2024 03:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toblux-com.20230601.gappssmtp.com; s=20230601; t=1716977975; x=1717582775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8QfgQefVXbA+Nmlke8cGsJdkI8B0w6erXtSR6K4yuWA=; b=leAHGD3J2ffsVnETP2jMnNnAsUp4+h66cTnHzQ8upW8uyeekgzZYl7a6QfZJzWo36d C8X4+h761OT7z+gG5kgovbPgSs4g3dVgHoxxvEWM0G14YFVWTJRBN8X2VLNPvhR46FDX xSbaz14Brr1RtHP/3IndGVqujpazAJZwadi1lQx1u9ip355fww06t455PfTmyEqMOwwA 8CB6FS/Qp5Aatuz7yN8PBz3GCg4LBA1xislVPluzU3qW1/ufm9yM9WmdTpoEXh2A/umO YlMD09t1nU5banTLqs1EL2PBIPG6cZaugliHQrjuAFKhntVWHmEid4KNgpdT+1X3MNiJ S8MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716977975; x=1717582775; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8QfgQefVXbA+Nmlke8cGsJdkI8B0w6erXtSR6K4yuWA=; b=B0q6uQdemDXVAmjSmWMgoYPYlRaI9jVciYnM41BA/TgiiANs3xkPFmrv/TWJKGCObv za7WLjlD5apcnWikSq05ogFWhX2iwHzP0ZE/oBUkmoKb0Jx7lIPUY66WhEiZDFEGhBsp hL0ZXRDiz7SMZRK6ck+gaNOBJ/IYZgRRO9G1qosXwqJAd9fAcptwmQ15j0jAAubR5T/U BAthnwH13o9XxgcQnDkBpaNOTuRDVB/aeBHKdCPcYGSmFjnDJI2DJ5Y8m4YYZafNEbHy wTiLhQRuk6UD8DM9yis7XorJ5QC+5/AtfQdxlQOAQgYB4eBd0V76OHYPh5zCPggxlEzT mgPw== X-Forwarded-Encrypted: i=1; AJvYcCVRcb878z94NM8WpR39CkATmusAK1xXDsBrsbiT/dRixgB1OWPDnG9nOOSBCGDRnLLBdQ4ThbpLkvbXjzCwWztjfXf/ X-Gm-Message-State: AOJu0YznY3njuij07Egu8T1ADeH6Skq+4jBcYtfjB2A+ZVrqf2ik8H5B +i21hUE8De+Dk/zyTA3vJWmDWjXtbtrBYBnKZtRkH4pQdNSeZTSAVeNbsy2rTW8= X-Google-Smtp-Source: AGHT+IHTppS7GVqORdfCZgJPtNDbp7gwaigLxndDJLWwl+V+qkGGDgRrVx+0AZsfnrb5FacpPck1+w== X-Received: by 2002:a50:8712:0:b0:578:69db:b46c with SMTP id 4fb4d7f45d1cf-57869dbb549mr7847997a12.8.1716977974558; Wed, 29 May 2024 03:19:34 -0700 (PDT) Received: from fedora.fritz.box (aftr-62-216-208-100.dynamic.mnet-online.de. [62.216.208.100]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5785249921dsm8198526a12.62.2024.05.29.03.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 03:19:34 -0700 (PDT) From: Thorsten Blum To: Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: [PATCH] bpf, devmap: Remove unnecessary if check in for loop Date: Wed, 29 May 2024 12:19:01 +0200 Message-ID: <20240529101900.103913-2-thorsten.blum@toblux.com> X-Mailer: git-send-email 2.45.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: bpf@iogearbox.net The iterator variable dst cannot be NULL and the if check can be removed. Remove it and fix the following Coccinelle/coccicheck warning reported by itnull.cocci: ERROR: iterator variable bound on line 762 cannot be NULL Signed-off-by: Thorsten Blum Acked-by: Jiri Olsa Reviewed-by: Toke Høiland-Jørgensen --- kernel/bpf/devmap.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c index 4e2cdbb5629f..7f3b34452243 100644 --- a/kernel/bpf/devmap.c +++ b/kernel/bpf/devmap.c @@ -760,9 +760,6 @@ int dev_map_redirect_multi(struct net_device *dev, struct sk_buff *skb, for (i = 0; i < dtab->n_buckets; i++) { head = dev_map_index_hash(dtab, i); hlist_for_each_entry_safe(dst, next, head, index_hlist) { - if (!dst) - continue; - if (is_ifindex_excluded(excluded_devices, num_excluded, dst->dev->ifindex)) continue;