From patchwork Thu May 30 09:31:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hailong liu X-Patchwork-Id: 13680039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E974C25B74 for ; Thu, 30 May 2024 09:31:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B91266B009D; Thu, 30 May 2024 05:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B42486B009E; Thu, 30 May 2024 05:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BC9E6B009F; Thu, 30 May 2024 05:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7ED1C6B009D for ; Thu, 30 May 2024 05:31:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2F6C31A130E for ; Thu, 30 May 2024 09:31:22 +0000 (UTC) X-FDA: 82174544004.30.35AB324 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2073.outbound.protection.outlook.com [40.107.255.73]) by imf13.hostedemail.com (Postfix) with ESMTP id D17742000D for ; Thu, 30 May 2024 09:31:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b="hQZsw/Rf"; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.73 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717061479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=J01VLTYJ7T3MjtXkj0Aav2CAvpBH8log1cEjdPHE2uI=; b=SBjhltz3YgIqi1vRcnmpLZLO19FYakpacu1/Zia4498ZKchitCwM+HMv4pSMWnluqwUMB/ dzOympTSajuwywSlegu735K4Jp+th9c+NSKFYQYslKzzOUqL+jhPEjVXezZPi+AeBLb8yK T1cxUbdv1nncWkCPVVS11W9fQ19G5qk= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b="hQZsw/Rf"; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of hailong.liu@oppo.com designates 40.107.255.73 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717061479; a=rsa-sha256; cv=pass; b=CVQeCI9ZbwbryzC+DkWgRyTvFCqjGFqYK9egCO/f5ze9Vnp7h61u1IPCPUdVy96Yx3uAM+ +6fsunm0jhRrr0VKK0mkdK3ctnd1ui699oh7nh5ZeB3ZBohsta+XqQgmgGfY9yGgH2Czzh 2F2kMIJTtqTknQY9rOibRMfqwSPvF+c= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I51ZoBM9+rEMjm37D3Gv9lAso1V7ON8WZUuZhu4k/OzVkhkXM3nvp3+5Y1Gwr6bJmsECSi2EL2DP4tIaLmBt5jeBpoiKGNazis2FTHh6mPb1c2pOPQcetQ9xuoZvY6Q6R0lZaTYNgw5EYiLW4KvJe29MUZaozq6I7N/oSdKBblnE28TxRk/Q1u4gUTi945vY/HstkFxT2QVzy0rzleL8vl3zbBN1AMwT1MOO9w7NFXSqIbybocuy+7mf5RaJmxjqIC7IRowng/mZs0rfEFwdPexVpwq5kj2cMEw7QjXw5MsvnBIxM9RQps5N2DCvpK+yXx/IeeoyIoevOKjOV2XJNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J01VLTYJ7T3MjtXkj0Aav2CAvpBH8log1cEjdPHE2uI=; b=gDBuF1QoX/1wX/vYFMGZqk4iahDHDT/O9cbnfNCAviacG2XCqjvWH6Fk+CeJdXuZQ+H667WHZbQ2aq97OloPZTdRRrnrn55jboGZqWtpLKHhf5DiN5mr7CHM3kyKxekrME/GMUYYGcx7ofNlWnbxYGSGGUM2MqaDpi7t5u7IO4pgaJfzk4vzTcHGEfqD66Ec5a6RPUaA3CRKXnguPu+pnG9CTTilUq2vZTpGNL2/31HBpN2+LMcANMc/+W+EP794rN+jw+byjTiEgDGPSTx9vsxe2epF8TscpdUaGJnI00lyHKYl0Er7mjJYphxmu8RqtrO2evSxMQjUGtdDveNfXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J01VLTYJ7T3MjtXkj0Aav2CAvpBH8log1cEjdPHE2uI=; b=hQZsw/RfEHrGufuhvs4V/zzfqghhdKcsfpg0aYPNPfPR8h6muxvcu5efK/MsQbyJvwDfiKYFZlaxdbgCZx14WcxJvkrSY5qTuP/xr8hVTvy1ZnNHKEn0NRxHViuV4Uiey/SYyTctjAXT1PtdyNcYfw08QbCqwTEMMupzZbMgOXo= Received: from SG2P153CA0032.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::19) by SEYPR02MB6842.apcprd02.prod.outlook.com (2603:1096:101:1b2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.21; Thu, 30 May 2024 09:31:13 +0000 Received: from SG1PEPF000082E4.apcprd02.prod.outlook.com (2603:1096:4:c7:cafe::a0) by SG2P153CA0032.outlook.office365.com (2603:1096:4:c7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7656.7 via Frontend Transport; Thu, 30 May 2024 09:31:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by SG1PEPF000082E4.mail.protection.outlook.com (10.167.240.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7633.15 via Frontend Transport; Thu, 30 May 2024 09:31:13 +0000 Received: from PH80250894.adc.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 30 May 2024 17:31:12 +0800 From: To: CC: , , , <21cnbao@gmail.com>, , , , , , hailong.liu , "Hailong . Liu" Subject: [RFC PATCH] mm/vmalloc: fix vbq->free breakage Date: Thu, 30 May 2024 17:31:08 +0800 Message-ID: <20240530093108.4512-1-hailong.liu@oppo.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw31.adc.com (172.16.56.198) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG1PEPF000082E4:EE_|SEYPR02MB6842:EE_ X-MS-Office365-Filtering-Correlation-Id: ecaaec90-7d55-48ed-38d9-08dc808b3f8c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|82310400017|7416005|1800799015|376005|36860700004; X-Microsoft-Antispam-Message-Info: rwPOCWi//p8MTZGZaFPImBXKwVDrUhzJX9k6wSjU8aDw/x/SDSgI86w/WpaMlF64tOcZXuSHcT4M8QYo2Qj0kRzjahQBKDOhFQJKaSfKx+lfGavOu/D372YX3yl/Q32uNoSJ4iee23gm0RzNrAJ6wZdIOABS/briQrZvFhXzTO8o11XNuLQ8qnGYSpRyG2L/wO2oJV5AE8ERFPaq7D/JV9KjTD+D3IxIbJkoyrXjzdftVEj2qnfiGJMIg21Vy8gjbsxIHmgPGNLbbUCiY5zUK5tUTZkxNXfUH5e3m1IbpmFidEjyZhWQsCF99uSpk6GPOsp3yOjUah33qNvNOqg3K/gBfd3cbsKjyZ0MH2sqtPTdJiCKaNkhC3/JecBIpvQmBb6p3teVFcAb2r4ZIVTf4cLX+kV/ouaeGmxMil/nD249X9TzNTUK3TnM7NFPTrumU/xWkl3JqzNbG7Lsy3ZB+MaFsxTVQYUdhApiVhJJUp5pLZ4m+MQ/CITilKvysFPUghzv4XzO+sg39gT62ypoL5Vp609rUr/qA+E7t50TTXP+iVhJswlkRlF8X/18u9kqlRgA+zOmgXM1hS33m2AaAMA+F41+6PGshhyU/wRkZeGUXMboXTxoOBjCLdsgEsX/R/62M4Nug6UW9ySKraRE39YFr6d8bFv+OVZaDpMMARXKton5+kmFT3Sn66y4xTYMAjrJ2g9KHUkdG8CMigov9DBF5Q2w25qtH58ckdpDpP6YHjl181cg73R7paEPfNpqQjMTd3mWWzo/CZdr/nAia/ZmvU0n6iM7AlLevxGf3BM1awLmdcwPyvE6dX8WfQHD3L/y5R4mGVEfDHeV2LwoOMNBqUJoMMCaJ9z2SLgocslltnbTcqJ6kQxkehdA4ZYKHrwm83LzBa+pheYp1M+tZ+j0YlEWSIlq5pKQxQH3M63gGyLZ6e5Hqyf2EoD6UfmIDVhC6SXbSKCPB+qRDDH6ihTXqZF/TVquiGoh3Jkiqep1oBrwK250T/TVk4rR66XVylaGl7191BKryWuWrmHgl79WYj8egbQpcVO/rHE9BlHS7INGhbsZkIc6HY1V/+a6EarTsdQUu4c8WMl4MSas4D020QPxRq9SFyRZg+fNc/FihFlfcexxKUFlUBSQMy2yDt6XbALbm0dAiY/MyztRumKgcAtcNqh7wTt/gZqloxMOwq3l8xOCkeFO+cvnCycbPv8gqNLeJhh0X8vHAk88eSV0ynm3vKYff8k0eNHXdrLJ2d21pdPvDb63eQ/JQr9nml50svH3bnw+lAdZyWBa4hHdfX/yUbAe5V8ouEsQIjSfsXWmpFahqQj3251KYxNQ X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400017)(7416005)(1800799015)(376005)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 09:31:13.3637 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecaaec90-7d55-48ed-38d9-08dc808b3f8c X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: SG1PEPF000082E4.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR02MB6842 X-Rspamd-Queue-Id: D17742000D X-Stat-Signature: wzy9qhb8abieyn3cn6tetf55hb7uskti X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717061478-672814 X-HE-Meta: U2FsdGVkX1+x0UY8OzbGOiuyblKC2oQD3wODOm09NogIoOLEwSkpMU0qZWv0OUXDY2gOHlmXaiUrgHYfjt3jkDWquLe/t9Vo9Km2CS+uM5Pv47BWpbAFa52RJ6SLYLfZzPvvanKGiDyXhnJdRaEuwG97Z1oSMvzEpQpPwYytmVRYuXL8AmEaWHkDuc/V1os0eus0/62PfpfhYvEF2eFwO2rBER5LRBsSAMVknYIcI4Z3sXYKYBmrvT7l4x5jJwMt7yXdjrQGspQsG+6cPiJHspSBeknxaeXS/C2uj2LHYOs2Hl8JEQtiywOLk2wUfiME819aKzKNWefg8OdDRU/9ArIKqIgeSWeb27jB+TRSA9IeiNo39jZt+ve/ebHK0ONMQF0dKuTOB2ypL/JV1JCLU8PDVlY5av6T09wjVQ9oMEXDUXKTMoN3D9Ydg2x4BOwmsOxuw0Je6Zc+3pPso5KcAK7roKF5Vq7O0vU8r2ASgzH2d5zuXqLy6KVzs9fBaIEZ+81l8G439mNO1hGGOR1IwTmmbuNM8tJoNhnF6wIiPdociWdElWjaMyUNZppHCY24wL4oxTIacD9p+i8pcBNv4VvD3zFS4B/ppn5J29VVBnSQE2wgdWxGdSu42iHt5k5vYz9yxWs7+0R4SsxIXjVmj63Jl1d+hIGx3Omr2rEyYQ2x7m5oCf+RL0oJcQL705sXPRLoGsneYPPID+26h34MRrDvbfFHBZmQz+ln/x82hB88P5vcBlknbAe+szpwOr8MH14k3iE1np8QV+VjGZ9YD6RxBbiR6fqlZDHmjCrac3v4UHvZzLldN5KqpGyhcMcpw2f7YOVrHa/fWxfOsjHGEwCJPG593bKDtzj6JuUdIb6fN8+V14THWzN/58rf3dgTN5WnFDDzrU+PZrNm28MXBPNhp6yJFONUl6PnDFjBLFqzL2xhnu1vloKq1y/pkB44DkEcYI5Dw3ziAMtyW+A AgTRqxQz XUCoD1Y191FKTW/xrq6h15srv6TyOkkRZEzLDBKaLap6O+pQyi+ywVZ5t4A+edIMY1Udzph4lMFvaGYVu+WdBMAtDwYZBqn/yve3xAGam+/im9JhODX2PWtPIxFvPHC9Ky87BAGVHgAQv3cLrDkTirEDEzY82sjoF47v8sIzSvfzP5xSAkDe58J8lhFtqT7IPGZgRvUTK8aro+NKo+jT3s+Vn08sJUl/8++/EE1FIrpldzTZNTJE4jJWEbHtSlHpddBwuoem6QlbEr03QfTgkXNkFECe2HNNW6Sxr5ExvFaTj90fNZIRfbL8Pk06fo072+XIMwlyIRaEuBL0cVZhE4XfmFw1DCw4mkM9w1AQvsDbHpGgnZslxds2FjnOVCB9xMXalEec+KIUvVjTqbI9w8y3fbJ9hluFp8FVmeNJHTvNiQWjGL20gtQSA6GgDYPdJrtZlGPx0DlcioMM39DIjc9AI0mIHPn3AMWqYsiOmnxiSKQydyARkYnEZaBjLaF0ScXnQl0H0hc6wGwFyS4AWKVoRNIy/6OazmR5O6q2IpYCNmUE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "hailong.liu" The function xa_for_each() in _vm_unmap_aliases() loops through all vbs. However, since commit 062eacf57ad9 ("mm: vmalloc: remove a global vmap_blocks xarray") the vb from xarray may not be on the corresponding CPU vmap_block_queue. Consequently, purge_fragmented_block() might use the wrong vbq->lock to protect the free list, leading to vbq->free breakage. Signed-off-by: Hailong.Liu Reported-by: Guangye Yang --- mm/vmalloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- https://lore.kernel.org/all/20240530025144.1570865-1-zhaoyang.huang@unisoc.com/ BTW, zhangyang also encounter the same issue, maybe revert commit not a better solution. we need a map to get vbq from vb. -- 2.30.0 diff --git a/mm/vmalloc.c b/mm/vmalloc.c index d12a17fc0c17..869e7788a7d5 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2269,10 +2269,9 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush) for_each_possible_cpu(cpu) { struct vmap_block_queue *vbq = &per_cpu(vmap_block_queue, cpu); struct vmap_block *vb; - unsigned long idx; rcu_read_lock(); - xa_for_each(&vbq->vmap_blocks, idx, vb) { + list_for_each_entry_rcu(vb, &vbq->free, free_list) { spin_lock(&vb->lock); /*