From patchwork Sun Jun 2 12:25:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 13682824 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A897C38394 for ; Sun, 2 Jun 2024 12:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331174; cv=none; b=oiK7fIXw/V9FQHn6fEmxTjOa/4zX8UJOnTyrCIWQQ/3Il8JJdzrw1vtGI2c/6wqZbhNYgCXnCtY79xnxPUmnEnCmhOjAHYNO/uHEMDsnaUeUiCTN4mfEJo4HbsiaM5XIxRXhja2Uqqw7DO/08NwfOLC9zAq4ax6Juke+7sTJrvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331174; c=relaxed/simple; bh=lFOCyger+Cvum4USeOZwnOs5mMMmHZ6zekex9/cU82c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fnQ1WOrSPTEkFQ/D56alcWxkqicRkpjJyHVqTSTxBVn7SeOHGxtmv4el5Thhhhl69sCjnDvKscPVQ83y5dKfKyPQu0QIwc1S02WXqXvugHoo6BXAxbt6Gfoc73gwwmOGUQfj7ZRJLOQ7uTauMuXmsyF/fvaxvTjZJ7FN4pDobDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L1Oqg/tp; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L1Oqg/tp" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1f44b4404dfso30961535ad.0 for ; Sun, 02 Jun 2024 05:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717331173; x=1717935973; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J0+Rqr5O31VyBP3nYRYAZ1XPI1Uu1EEL5+3UerSfcLk=; b=L1Oqg/tpvFWHcoauuZw+ma3Agf5h2uJexOks9PG3SOwE05SCMFzOXp7z3Yxt6BLhIF LKrWKRE2Ggs07s3j3+GH18O5oLDY46DJpxYAlvvvFfCBIrCfFlAbl3Q0Ep2s/9/1ki4o Jf2HKILPtlcJR9m+WmtCTQXsBiZeASaRbm/25s85RArQ+gHuBaBNCJyt8LRfv6LkS/sO xv5awJp21RKx3QY5GVypBRTDI9FDMkAR7tRBa2svBal37GDp0XUY2rZkbnfWZDp87WcP P6RPGJFnaua2SLOIZ1qJZsCGBNN7gRF0CISnjXEjRahBfUzZeV/HeoPARrDQ3XgYd/SV nudw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717331173; x=1717935973; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J0+Rqr5O31VyBP3nYRYAZ1XPI1Uu1EEL5+3UerSfcLk=; b=qwyGGLMbdt2cL5cDGaS2Qw/OosTtwnsjsu8LZJM1YY4HWlTvvB5nWea5ueUoJEZYN8 kXbV8TDHdWDsa3rEeR+1enM+xsR0sDBReC59xs6GkMX7cFlSnHNbis4sQvCKmNomsROc y/9EOl8a8akwO86pAiJlELggt34CfiW+n61DkRDm21HRFcfCo1e6uLaJbKZhoDyGdMVq FEeYsd0bP514OByZzhzu7sGhL+ywSsO6VZPyn6cUbTCfG9b2k3DVuXmwFEc31IDE3uiP ZQCAA6DVUhYxU/m9ugIlhvez0r0BAybPqgacfBcn9UZUEoWWIDQKToJMn+BSnCrw2ada LWUQ== X-Forwarded-Encrypted: i=1; AJvYcCW/aLmcbq2vbAcriyKYkF0w7ec2cz6sNfMMpIRfGKFgiEW+gJwgq6R1Dty6PBalueQZK0L6TTA7GJP8/ELy/kJUWvmc X-Gm-Message-State: AOJu0YyYCFjFeHyOQA6VGCDGID9185s9ZXH3xYZ3FFz8iakk7vyu0UBi yGf3nHpFo0cWHdER25+lFtEZwXeQkd5DzWrTewu8/QJqYxDbpc4X X-Google-Smtp-Source: AGHT+IHIciwb566nl0u55CKEkBnjZ9tl7Rifm+VvXDKA5BRrgV7+AfpURO1apfagzPrJSssT2em99w== X-Received: by 2002:a17:902:f94d:b0:1ec:e3c2:790e with SMTP id d9443c01a7336-1f63700392amr57225025ad.19.1717331172769; Sun, 02 Jun 2024 05:26:12 -0700 (PDT) Received: from wheely.local0.net (110-175-65-7.tpgi.com.au. [110.175.65.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6703f7673sm7834145ad.210.2024.06.02.05.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 05:26:12 -0700 (PDT) From: Nicholas Piggin To: Thomas Huth Cc: Nicholas Piggin , Andrew Jones , kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 1/4] powerpc/sprs: Fix report_kfail call Date: Sun, 2 Jun 2024 22:25:55 +1000 Message-ID: <20240602122559.118345-2-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240602122559.118345-1-npiggin@gmail.com> References: <20240602122559.118345-1-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Parameters to report_kfail are wrong. String to bool conversion is not warned by gcc, and printf format did not catch it due to string variable being passed at the format location. Fixes: 8f6290f0e6 ("powerpc/sprs: Specify SPRs with data rather than code") Signed-off-by: Nicholas Piggin Reviewed-by: Thomas Huth --- powerpc/sprs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/powerpc/sprs.c b/powerpc/sprs.c index de9e87a21..33872136d 100644 --- a/powerpc/sprs.c +++ b/powerpc/sprs.c @@ -590,7 +590,7 @@ int main(int argc, char **argv) if (sprs[i].width == 32 && !(before[i] >> 32) && !(after[i] >> 32)) { /* known failure KVM migration of CTRL */ - report_kfail(true && i == 136, + report_kfail(i == 136, pass, "%-10s(%4d):\t 0x%08lx <==> 0x%08lx", sprs[i].name, i, before[i], after[i]); From patchwork Sun Jun 2 12:25:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 13682825 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD39C38394 for ; Sun, 2 Jun 2024 12:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331178; cv=none; b=e9sLT6uNw20W7E5YgTcNlk4HjerGFTtr4kFgocUXVXEhdOE4pishRlRsB4C/RoUEao8e20A/C3HPDb/vfg8YIUY0pAiZxusf7leSzDJx5ujcCJ2P0XZxtTEg4ubN3rNmgMVhAnaF5VSUi2REtvC++yGHnbxtdgQ3jN8sTxh7EEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331178; c=relaxed/simple; bh=gsRT5t6+jA3o4L8RD/m+uIC3dRPDQ4MjOCQHSZzZJrc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OuNCHfQOBgjmA6cZkibRwIy0nXljvKo4RcfKpsBjU7oJnRHt79dBU7I8zR0/SBkOFouU3Beuvh1081CD27xUGqCqYa0mguL3yr27AVp6ePsivZffMKQZuaHOBOSahHUsSZ3lcd8cK/OWGdrSq/NpDdTm6MVHVmadImAkoyT9BGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q3mDTNkc; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q3mDTNkc" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f6134df05fso31919805ad.1 for ; Sun, 02 Jun 2024 05:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717331176; x=1717935976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OXZgf1pKFq5fGU1GpMr45jMdo+zCiLBYYxUQq93K0No=; b=Q3mDTNkcSVmBzFYZhrhDmqS63P2eOMdN+tiljH6wabJaY6gkyGarcOwlijzfUrsXFK sAYm2oSKP5LDap7cR65wo8o//T8wpJJuDUyI7p6Mpn5oxl9R5gWs3sLYkhJZouAEs6MV 8VTCEOd7wQMfVezfeAyotvnntW81bGDoEBxrS/tlh+zkVP/xXdrhTNA5F5bI6OB2mcxp W2fJ/hQMH3z22dAugLHU1AdvM8CnJ3Jve9i0hYFioVS8s1Ssg2s6gs4t2q22bPrBBHzj 1IG3WC3fpzueGZMcR6ZzKIFbChhjtd8S59WFTuLXpu6eX6LGOWiGNBZd60/BgG9ml644 /xPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717331176; x=1717935976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OXZgf1pKFq5fGU1GpMr45jMdo+zCiLBYYxUQq93K0No=; b=aKPjBUtveJJprRtzWjNymkHUbfIKUU8Sff0sEnEopH6e8s8+JK8Yeb7RHuhAwP59CH yzZ54rjp869Fj4mltPjlwrjL6G9A792mu332U9cK326Cai1Ohrb0QpYZeTgzS0ugAlTS ZyJwwO2eG2bGe/rxe1w84i97j7wE1PKVxiXQfKPlOq/Tb1djYN7Bn2o3TptlFxi5Vv8+ VS5veu1R2lw8UkfekCE5AqeKm0ILD2gUl8oPAQt341UnXFrg1UAQa7TDRxLsrbKwMKoe 1utW3zxrCAJYcANQvIBzoZS9VNO/IUfGWDHzYYEoBr1GZr9bsdoOKgBfZUdkM0nVvZjh kk5A== X-Forwarded-Encrypted: i=1; AJvYcCU1BiV3CXJ5YMWP+Vv7yFnzUvDEjQ2j8XbXhcfr7lp1IlATCIZaTWDyP2YSk5y/NclJLDM3GUPsMXWQeG6wavBe18M/ X-Gm-Message-State: AOJu0YySrMP8amLQ+Bnw1ZxP+jh+A5P/RYZGRKi1NnbFkBex7koJey4i /NLGMITI/QWPH3jS8OkApSmrQOwMRANGo7A1jVuT2v3pepRblAei X-Google-Smtp-Source: AGHT+IFvYFv9tbJkpHAqUs/opvGz2POXfgYsghTc/L4heNtyJvJSpAwxIqzhp+UUZnVwtn4gqCN8DA== X-Received: by 2002:a17:902:e84e:b0:1f6:6ad1:fdf9 with SMTP id d9443c01a7336-1f66ad21fb6mr15906425ad.57.1717331175907; Sun, 02 Jun 2024 05:26:15 -0700 (PDT) Received: from wheely.local0.net (110-175-65-7.tpgi.com.au. [110.175.65.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6703f7673sm7834145ad.210.2024.06.02.05.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 05:26:15 -0700 (PDT) From: Nicholas Piggin To: Thomas Huth Cc: Nicholas Piggin , Andrew Jones , kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 2/4] doc: update unittests doc Date: Sun, 2 Jun 2024 22:25:56 +1000 Message-ID: <20240602122559.118345-3-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240602122559.118345-1-npiggin@gmail.com> References: <20240602122559.118345-1-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Document the special groups, check path restrictions, and a small fix for check option syntax. Signed-off-by: Nicholas Piggin Reviewed-by: Thomas Huth Reviewed-by: Andrew Jones --- docs/unittests.txt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/docs/unittests.txt b/docs/unittests.txt index 6ff9872cf..509c529d7 100644 --- a/docs/unittests.txt +++ b/docs/unittests.txt @@ -69,8 +69,11 @@ groups groups = ... Used to group the test cases for the `run_tests.sh -g ...` run group -option. Adding a test to the nodefault group will cause it to not be -run by default. +option. The group name is arbitrary, except for these special groups: +- Tests in the "nodefault" group are not run by default (with no -g option). +- Tests in the "migration" group are run with the migration harness and + expects the test to make migrate_*() calls. +- Tests in the "panic" group expect QEMU to enter the GUEST_PANICKED state. accel ----- @@ -89,8 +92,10 @@ Optional timeout in seconds, after which the test will be killed and fail. check ----- -check = =< +check = = Check a file for a particular value before running a test. The check line can contain multiple files to check separated by a space, but each check parameter needs to be of the form = + +The path and value can not contain space, =, or shell wildcard characters. From patchwork Sun Jun 2 12:25:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 13682826 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E34238394 for ; Sun, 2 Jun 2024 12:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331181; cv=none; b=pVbUZHJSC3fd7SRzisFobUV6K5h30xj4uRZrEhCfkWReIlk0NuF3+TavcKY0aHy418RJBDGsbZE78vQkh+k6rqOz7hUO5D17HGuyAZIag90GsHdxDh0lanmFshiSkstUiReTqI75nRpHssdeBRV10Ua+45vKEjJNZivGv9WcZQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331181; c=relaxed/simple; bh=qURXh813MSuEBp/XtJ53Wo6vpZIosba6kX2yz1Y7SJY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ncXAb9mpQ6U//uqqNwHhq2sr6yVyQf3L1c5/iifypZD4XIdtTPRI247dcA7LQutyu7GH5xzAwi5tsOQ9m0EfnVE5BBmL+iDakeR0BLO9h8Y1PlugIlXrH7t6NC/4mN6RQjt78390kDMTY3EDXK+ZUfzxqDbpyBAPaofHV5AIxEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b8ZepK7h; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b8ZepK7h" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1f63642ab8aso16604135ad.3 for ; Sun, 02 Jun 2024 05:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717331179; x=1717935979; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hiyKAfB2OU/NwrNnJ5dy03JAEMCwXVvnhLc/exyt8Iw=; b=b8ZepK7hd6WFwKsq00v6Mufd2Y6o1Vl9oYed8OAwEodh22m8qtf9mhrzbcOldG4hjf 8uZxiAYR2Lxon08eK8sXz3QdBshirXLvfVBMEAXCnZGJlccs2nXfTr5YrRfOr0qXn1kZ Iy34EYkTKfAhQflngLiW1t005JTkXBojulqxGTTHytphBjYNw9vaxwuR7AXO3/P9uhwe mBpxq9dh4dWKJWLSBCrk4IJTSZyAey2ddqGcA/1heKYePDI8HAEjHOSZnoQC6nOY0yx8 +79XQxuOW9MqUxanQUXVJJFF44rYGx08ZGz8XSGSF3kWGPajpvxBwQgPpO8F3IWTYttW KMQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717331179; x=1717935979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hiyKAfB2OU/NwrNnJ5dy03JAEMCwXVvnhLc/exyt8Iw=; b=OeeKDHHR/9BmL1QqrnZiG2tCwyu7fXDuuWTdV0IUV7KxIojTLItunWbIY26P/ELCfA yRxF7zAHejEtqtJ58lFZIoIiK2lmG3ZsZod7BQgrJw9/bnCXmjpluMTKCK63KucJGY26 cEpihy8qafkVNCQOU4Ff5dRXMZutaWda0mPK8/76PFaTPUzsMvwblqbiWxdRBZxDr/o5 lJF4JEO1iuTAk5IxJ/Gqxq1PZfr87tz6k1EKUZsWo8pldX4zOGQp8vvEs+1KwMEMUG9l lWYpGyV/950B+HnMo9C1Fj2gIxVTU6Y2HbSVmydcXjll3yHszBXO3t2bU7AFw4CcSups JlGA== X-Forwarded-Encrypted: i=1; AJvYcCXE7mYFIsjQ/WFxdnZEJQ6chTaJOYSscOt2ifTnKAfEu/gq3Sjlv/GG/bZ5KZfmytQQsggp5eFI0AETjF6pkQPZk2St X-Gm-Message-State: AOJu0YxEMHv8JosnY2/5yNQEE+HuZ/rYJU++rjKmCMKzNEa82wcBMXjq cCCwwTh5Pqi99tQyyz1kCfBYVCIQMYZR6+4uocLk6n8kfHMN3cpZ X-Google-Smtp-Source: AGHT+IF1f6TILcJ1kTQ+3f6Mh/mgA9FBUgr8fy3ZI3PhzPZjFejlVpYAXsMzKAEl2nJgnwTnRo4S2w== X-Received: by 2002:a17:903:11c5:b0:1f2:f090:b2c1 with SMTP id d9443c01a7336-1f636ff5266mr66782755ad.14.1717331179218; Sun, 02 Jun 2024 05:26:19 -0700 (PDT) Received: from wheely.local0.net (110-175-65-7.tpgi.com.au. [110.175.65.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6703f7673sm7834145ad.210.2024.06.02.05.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 05:26:18 -0700 (PDT) From: Nicholas Piggin To: Thomas Huth Cc: Nicholas Piggin , Andrew Jones , kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 3/4] build: Make build output pretty Date: Sun, 2 Jun 2024 22:25:57 +1000 Message-ID: <20240602122559.118345-4-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240602122559.118345-1-npiggin@gmail.com> References: <20240602122559.118345-1-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Unless make V=1 is specified, silence make recipe echoing and print an abbreviated line for major build steps. Signed-off-by: Nicholas Piggin Reviewed-by: Andrew Jones --- Makefile | 14 ++++++++++++++ arm/Makefile.common | 7 +++++++ powerpc/Makefile.common | 11 +++++++---- riscv/Makefile | 5 +++++ s390x/Makefile | 18 +++++++++++++++++- scripts/mkstandalone.sh | 2 +- x86/Makefile.common | 5 +++++ 7 files changed, 56 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 5b7998b79..cbb2fdbf1 100644 --- a/Makefile +++ b/Makefile @@ -9,6 +9,11 @@ include config.mak # Set search path for all sources VPATH = $(SRCDIR) +V=0 +ifeq ($V, 0) +.SILENT: +endif + libdirs-get = $(shell [ -d "lib/$(1)" ] && echo "lib/$(1) lib/$(1)/asm") ARCH_LIBDIRS := $(call libdirs-get,$(ARCH_LIBDIR)) $(call libdirs-get,$(TEST_DIR)) OBJDIRS := $(ARCH_LIBDIRS) @@ -95,11 +100,13 @@ autodepend-flags = -MMD -MP -MF $(dir $*).$(notdir $*).d LDFLAGS += -nostdlib $(no_pie) -z noexecstack $(libcflat): $(cflatobjs) + @echo " [AR] $@" $(AR) rcs $@ $^ include $(LIBFDT_srcdir)/Makefile.libfdt $(LIBFDT_archive): CFLAGS += -ffreestanding -I $(SRCDIR)/lib -I $(SRCDIR)/lib/libfdt -Wno-sign-compare $(LIBFDT_archive): $(addprefix $(LIBFDT_objdir)/,$(LIBFDT_OBJS)) + @echo " [AR] $@" $(AR) rcs $@ $^ libfdt_clean: VECHO = echo " " @@ -112,7 +119,12 @@ libfdt_clean: SHAREDLIB_EXT = so directories: @mkdir -p $(OBJDIRS) +%.o: %.c + @echo " [CC] $@" + $(CC) $(CFLAGS) -c -nostdlib -o $@ $< + %.o: %.S + @echo " [AS] $@" $(CC) $(CFLAGS) -c -nostdlib -o $@ $< -include */.*.d */*/.*.d @@ -123,6 +135,7 @@ standalone: all @scripts/mkstandalone.sh install: standalone + @echo " [INSTALL] tests -> $(DESTDIR)" mkdir -p $(DESTDIR) install tests/* $(DESTDIR) @@ -136,6 +149,7 @@ distclean: clean cscope: cscope_dirs = lib lib/libfdt lib/linux $(TEST_DIR) $(ARCH_LIBDIRS) lib/asm-generic cscope: + @echo " [CSCOPE]" $(RM) ./cscope.* find -L $(cscope_dirs) -maxdepth 1 \ -name '*.[chsS]' -exec realpath --relative-base=$(CURDIR) {} \; | sort -u > ./cscope.files diff --git a/arm/Makefile.common b/arm/Makefile.common index f828dbe01..9d6b31239 100644 --- a/arm/Makefile.common +++ b/arm/Makefile.common @@ -73,15 +73,18 @@ FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libeabi) ifeq ($(CONFIG_EFI),y) %.aux.o: $(SRCDIR)/lib/auxinfo.c + @echo " [CC] $@" $(CC) $(CFLAGS) -c -o $@ $< \ -DPROGNAME=\"$(@:.aux.o=.efi)\" -DAUXFLAGS=$(AUXFLAGS) %.so: EFI_LDFLAGS += -defsym=EFI_SUBSYSTEM=0xa --no-undefined %.so: %.o $(FLATLIBS) $(SRCDIR)/arm/efi/elf_aarch64_efi.lds $(cstart.o) %.aux.o + @echo " [LD] $@" $(LD) $(EFI_LDFLAGS) -o $@ -T $(SRCDIR)/arm/efi/elf_aarch64_efi.lds \ $(filter %.o, $^) $(FLATLIBS) $(EFI_LIBS) %.efi: %.so + @echo " [OBJCOPY] $@" $(call arch_elf_check, $^) $(OBJCOPY) --only-keep-debug $^ $@.debug $(OBJCOPY) --strip-debug $^ @@ -93,22 +96,26 @@ ifeq ($(CONFIG_EFI),y) -O binary $^ $@ else %.aux.o: $(SRCDIR)/lib/auxinfo.c + @echo " [CC] $@" $(CC) $(CFLAGS) -c -o $@ $< \ -DPROGNAME=\"$(@:.aux.o=.flat)\" -DAUXFLAGS=$(AUXFLAGS) %.elf: LDFLAGS += $(arch_LDFLAGS) %.elf: %.o $(FLATLIBS) $(SRCDIR)/arm/flat.lds $(cstart.o) %.aux.o + @echo " [LD] $@" $(LD) $(LDFLAGS) -o $@ -T $(SRCDIR)/arm/flat.lds \ $(filter %.o, $^) $(FLATLIBS) @chmod a-x $@ %.flat: %.elf + @echo " [OBJCOPY] $@" $(call arch_elf_check, $^) $(OBJCOPY) -O binary $^ $@ @chmod a-x $@ endif $(libeabi): $(eabiobjs) + @echo " [AR] $@" $(AR) rcs $@ $^ arm_clean: asm_offsets_clean diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common index 68165fc25..b0af9fc00 100644 --- a/powerpc/Makefile.common +++ b/powerpc/Makefile.common @@ -51,31 +51,34 @@ cflatobjs += lib/powerpc/smp.o OBJDIRS += lib/powerpc %.aux.o: $(SRCDIR)/lib/auxinfo.c + @echo " [LD] $@" $(CC) $(CFLAGS) -c -o $@ $< -DPROGNAME=\"$(@:.aux.o=.elf)\" FLATLIBS = $(libcflat) $(LIBFDT_archive) %.elf: CFLAGS += $(arch_CFLAGS) %.elf: LDFLAGS += $(arch_LDFLAGS) -pie -n %.elf: %.o $(FLATLIBS) $(SRCDIR)/powerpc/flat.lds $(cstart.o) $(reloc.o) %.aux.o + @echo " [LD] $@" $(LD) $(LDFLAGS) -o $@ \ -T $(SRCDIR)/powerpc/flat.lds --build-id=none \ $(filter %.o, $^) $(FLATLIBS) @chmod a-x $@ - @echo -n Checking $@ for unsupported reloc types... @if $(OBJDUMP) -R $@ | grep R_ | grep -v R_PPC64_RELATIVE; then \ + @echo "Unsupported reloc types in $@" \ false; \ - else \ - echo " looks good."; \ fi $(TEST_DIR)/boot_rom.bin: $(TEST_DIR)/boot_rom.elf - dd if=/dev/zero of=$@ bs=256 count=1 + @echo " [DD] $@" + dd if=/dev/zero of=$@ bs=256 count=1 status=none + @echo " [OBJCOPY] $@" $(OBJCOPY) -O binary $^ $@.tmp cat $@.tmp >> $@ $(RM) $@.tmp $(TEST_DIR)/boot_rom.elf: CFLAGS = -mbig-endian $(TEST_DIR)/boot_rom.elf: $(TEST_DIR)/boot_rom.o + @echo " [LD] $@" $(LD) -EB -nostdlib -Ttext=0x100 --entry=start --build-id=none -o $@ $< @chmod a-x $@ diff --git a/riscv/Makefile b/riscv/Makefile index 919a3ebb5..ca33d4960 100644 --- a/riscv/Makefile +++ b/riscv/Makefile @@ -82,6 +82,7 @@ asm-offsets = lib/riscv/asm-offsets.h include $(SRCDIR)/scripts/asm-offsets.mak %.aux.o: $(SRCDIR)/lib/auxinfo.c + @echo " [CC] $@" $(CC) $(CFLAGS) -c -o $@ $< \ -DPROGNAME=\"$(notdir $(@:.aux.o=.$(exe)))\" -DAUXFLAGS=$(AUXFLAGS) @@ -96,10 +97,12 @@ cflatobjs += lib/efi.o %.so: EFI_LDFLAGS += -defsym=EFI_SUBSYSTEM=0xa --no-undefined %.so: %.o $(FLATLIBS) $(SRCDIR)/riscv/efi/elf_riscv64_efi.lds $(cstart.o) %.aux.o + @echo " [LD] $@" $(LD) $(EFI_LDFLAGS) -o $@ -T $(SRCDIR)/riscv/efi/elf_riscv64_efi.lds \ $(filter %.o, $^) $(FLATLIBS) $(EFI_LIBS) %.efi: %.so + @echo " [OBJCOPY] $@" $(call arch_elf_check, $^) $(OBJCOPY) --only-keep-debug $^ $@.debug $(OBJCOPY) --strip-debug $^ @@ -112,11 +115,13 @@ cflatobjs += lib/efi.o else %.elf: LDFLAGS += -pie -n -z notext %.elf: %.o $(FLATLIBS) $(SRCDIR)/riscv/flat.lds $(cstart.o) %.aux.o + @echo " [LD] $@" $(LD) $(LDFLAGS) -o $@ -T $(SRCDIR)/riscv/flat.lds \ $(filter %.o, $^) $(FLATLIBS) @chmod a-x $@ %.flat: %.elf + @echo " [OBJCOPY] $@" $(call arch_elf_check, $^) $(OBJCOPY) -O binary $^ $@ @chmod a-x $@ diff --git a/s390x/Makefile b/s390x/Makefile index 8603a523c..19c41a2ec 100644 --- a/s390x/Makefile +++ b/s390x/Makefile @@ -148,42 +148,54 @@ endif # the asm/c snippets %.o have additional generated files as dependencies $(SNIPPET_DIR)/asm/%.o: $(SNIPPET_DIR)/asm/%.S $(asm-offsets) + @echo " [CC] $@" $(CC) $(CFLAGS) -c -nostdlib -o $@ $< $(SNIPPET_DIR)/c/%.o: $(SNIPPET_DIR)/c/%.c $(asm-offsets) + @echo " [CC] $@" $(CC) $(CFLAGS) -c -nostdlib -o $@ $< $(SNIPPET_DIR)/asm/%.gbin: $(SNIPPET_DIR)/asm/%.o $(SNIPPET_DIR)/asm/flat.lds + @echo " [LD] $@" $(CC) $(LDFLAGS) -o $@ -T $(SNIPPET_DIR)/asm/flat.lds $< + @echo " [OBJCOPY] $@" $(OBJCOPY) -O binary -j ".rodata" -j ".lowcore" -j ".text" -j ".data" -j ".bss" --set-section-flags .bss=alloc,load,contents $@ $@ truncate -s '%4096' $@ $(SNIPPET_DIR)/c/%.gbin: $(SNIPPET_DIR)/c/%.o $(snippet_lib) $(FLATLIBS) $(SNIPPET_DIR)/c/flat.lds + @echo " [LD] $@" $(CC) $(LDFLAGS) -o $@ -T $(SNIPPET_DIR)/c/flat.lds $< $(snippet_lib) $(FLATLIBS) + @echo " [OBJCOPY] $@" $(OBJCOPY) -O binary -j ".rodata" -j ".lowcore" -j ".text" -j ".data" -j ".bss" --set-section-flags .bss=alloc,load,contents $@ $@ truncate -s '%4096' $@ %.hdr: %.gbin $(HOST_KEY_DOCUMENT) + @echo " [SEHDR ] $@" $(GEN_SE_HEADER) -k $(HOST_KEY_DOCUMENT) -c $<,0x0,0x00000000000000420000000000000000 --psw-addr 0x4000 -o $@ .SECONDARY: %.gobj: %.gbin + @echo " [OBJCOPY] $@" $(OBJCOPY) -I binary -O elf64-s390 -B "s390:64-bit" $< $@ .SECONDARY: %.hdr.obj: %.hdr + @echo " [OBJCOPY] $@" $(OBJCOPY) -I binary -O elf64-s390 -B "s390:64-bit" $< $@ lds-autodepend-flags = -MMD -MF $(dir $*).$(notdir $*).d -MT $@ %.lds: %.lds.S $(asm-offsets) + @echo " [CPP] $@" $(CPP) $(lds-autodepend-flags) $(CPPFLAGS) -P -C -o $@ $< %.aux.o: $(SRCDIR)/lib/auxinfo.c + @echo " [CC] $@" $(CC) $(CFLAGS) -c -o $@ $< -DPROGNAME=\"$(@:.aux.o=.elf)\" .SECONDEXPANSION: %.elf: $(FLATLIBS) $(asmlib) $(SRCDIR)/s390x/flat.lds $$(snippets-obj) $$(snippet-hdr-obj) %.o %.aux.o - @$(CC) $(LDFLAGS) -o $@ -T $(SRCDIR)/s390x/flat.lds \ + @echo " [CC] $@" + $(CC) $(LDFLAGS) -o $@ -T $(SRCDIR)/s390x/flat.lds \ $(filter %.o, $^) $(FLATLIBS) $(snippets-obj) $(snippet-hdr-obj) || \ { echo "Failure probably caused by missing definition of gen-se-header executable"; exit 1; } @chmod a-x $@ @@ -192,9 +204,11 @@ lds-autodepend-flags = -MMD -MF $(dir $*).$(notdir $*).d -MT $@ # 32 bytes of key material, uses existing one if available comm-key = $(TEST_DIR)/comm.key $(comm-key): + @echo " [DD] $@" dd if=/dev/urandom of=$@ bs=32 count=1 status=none %.bin: %.elf + @echo " [OBJCOPY] $@" $(OBJCOPY) -O binary $< $@ # The genprotimg arguments for the cck changed over time so we need to @@ -216,10 +230,12 @@ endif $(patsubst %.parmfile,%.pv.bin,$(wildcard s390x/*.parmfile)): %.pv.bin: %.parmfile %.pv.bin: %.bin $(HOST_KEY_DOCUMENT) $(comm-key) + @echo " [GENPROT] $@" $(eval parmfile_args = $(if $(filter %.parmfile,$^),--parmfile $(filter %.parmfile,$^),)) $(GENPROTIMG) --host-key-document $(HOST_KEY_DOCUMENT) --no-verify $(GENPROTIMG_COMM_OPTION) $(comm-key) --x-pcf $(GENPROTIMG_PCF) $(parmfile_args) --image $(filter %.bin,$^) -o $@ $(snippet_asmlib): $$(patsubst %.o,%.S,$$@) $(asm-offsets) + @echo " [CC] $@" $(CC) $(CFLAGS) -c -nostdlib -o $@ $< diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh index 2318a85f0..3307c25b1 100755 --- a/scripts/mkstandalone.sh +++ b/scripts/mkstandalone.sh @@ -94,7 +94,7 @@ function mkstandalone() generate_test "$@" > $standalone chmod +x $standalone - echo Written $standalone. + echo " [WRITE] $standalone" } if [ "$ENVIRON_DEFAULT" = "yes" ] && [ "$ERRATATXT" ] && [ ! -f "$ERRATATXT" ]; then diff --git a/x86/Makefile.common b/x86/Makefile.common index 4ae9a5579..96fb0660c 100644 --- a/x86/Makefile.common +++ b/x86/Makefile.common @@ -49,11 +49,13 @@ ifeq ($(CONFIG_EFI),y) .PRECIOUS: %.efi %.so %.so: %.o $(FLATLIBS) $(SRCDIR)/x86/efi/elf_x86_64_efi.lds $(cstart.o) + @echo " [LD] $@" $(LD) -T $(SRCDIR)/x86/efi/elf_x86_64_efi.lds $(EFI_LDFLAGS) -o $@ \ $(filter %.o, $^) $(FLATLIBS) @chmod a-x $@ %.efi: %.so + @echo " [OBJCOPY] $@" $(OBJCOPY) --only-keep-debug $^ $@.debug $(OBJCOPY) --strip-debug $^ $(OBJCOPY) --add-gnu-debuglink=$@.debug $^ @@ -67,11 +69,13 @@ else %.elf: LDFLAGS += $(arch_LDFLAGS) %.elf: %.o $(FLATLIBS) $(SRCDIR)/x86/flat.lds $(cstart.o) + @echo " [LD] $@" $(LD) $(LDFLAGS) -T $(SRCDIR)/x86/flat.lds -o $@ \ $(filter %.o, $^) $(FLATLIBS) @chmod a-x $@ %.flat: %.elf + @echo " [OBJCOPY] $@" $(OBJCOPY) -O elf32-i386 $^ $@ @chmod a-x $@ endif @@ -104,6 +108,7 @@ test_cases: $(tests-common) $(tests) $(TEST_DIR)/%.o: CFLAGS += -std=gnu99 -ffreestanding -I $(SRCDIR)/lib -I $(SRCDIR)/lib/x86 -I lib $(TEST_DIR)/realmode.elf: $(TEST_DIR)/realmode.o + @echo " [LD] $@" $(LD) -m elf_i386 -nostdlib -o $@ \ -T $(SRCDIR)/$(TEST_DIR)/realmode.lds $^ From patchwork Sun Jun 2 12:25:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 13682827 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 185773BBF1 for ; Sun, 2 Jun 2024 12:26:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331184; cv=none; b=uYvSs4o+ORc2zviHamaW88rAPx7jcC8ZnS7xwDiTpS4RxgQQrpr44GfmAk+DJ+IXLFJLO2pI7hu1cpnNAS1XgGcztDPgahe3sm9vmMREjyScWUD6JXe83n0nwVzE/uTa+k5rIa3Qkjhio0ntpe4yuhlrJiAXKvqZLVaF76OHvg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717331184; c=relaxed/simple; bh=twgV4D8fcFPyldpVqsWOheV5XcPjZqxLc6kivXVKvCI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f2VsdoAZbUmHNOTDq5PoKXVdlIP0MVLiz29nxbaZq6Cj4KqvvSdBeWpOghHdPRO7O4/D6xdLDdk8ycAIz93+TX5Vwx4t6a1nehT8WBdc6WS/W+ixO+5ffeMbtkxrT3pO4oLxDfobI/oPMbNDBDpnhsSHoe2zC9/4/PrwcnMi/88= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L0bn7OOo; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L0bn7OOo" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-681ad081695so2433301a12.3 for ; Sun, 02 Jun 2024 05:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717331182; x=1717935982; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oTUSs4lOqKqsTcBc/80zqv5xqWnxY0ATi5ZuSQV9qm4=; b=L0bn7OOoWsjF3LvxJRD5PTuVCbBqesJyRNPVfZrTALlFCKZDbPX4IZcCsafGI5yV4V 02X76jUvyb0Ui0F2DE391qGAuMCf+IcjoWs8HuGK3iEwzV7edre6Z0TxQ2655+FSS7vt qJZ96n+i1LoHgEOKjfKS5/YV/f2Vodogz8u8+ZW1kJdjPY8tY3xoW41vGtpNV1xa6GcU 2xJqw1jqeSR67qxp9iwXXLkcH2vK5XNK5rx75JlxokEXtCv4waUyZiKNus7q3Ac859YY iw18KR70n6ETc2eQJuORwY2c8pq72/n72r9XjVQbaQWWujisUXQIYdaFZ94FQl0RsS13 uuSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717331182; x=1717935982; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oTUSs4lOqKqsTcBc/80zqv5xqWnxY0ATi5ZuSQV9qm4=; b=eTGXdmNpvP+HrUFUB7IPEKzDpGufzVWLqTGiF8cRRZsbx8u7SlvrXg/I1NRlpTBcYn UEFEMtsbGkM4QbZS27arzzQPT7ivnLKmYeAl2Vy7VMxwSfFEVs0hWzcKM+xpuU/pn4Sx RW7t9O8PCZY2vclZiAolsuWgF6/4JVTeMrF5n3f8lSF+TmC4eXOC5VT1Xe0iR+cHqA7o 3miDdwghSUcrrwIKR38HpOaCgH1fzdY4wdVo7cHA/uCzA7ezHoMJ86toJWlYN+L2mpWD 1W1zREZPnlVScJoz+WhbyrnD4+1WvZpDcN1Rho1znw2/M8HzRa/KXuuPx/TpfJxmLkDL OZkg== X-Forwarded-Encrypted: i=1; AJvYcCWeD+MNNqR+3n3o6gTgzRPSb0qVowrOFT6PGo8I4uPnbTYs/oaiGzH6txJgUJ7tx7/Hrh4PXL9EUrZjFAeOarYTFVrW X-Gm-Message-State: AOJu0YzrZiU5XMpRwwebxM0u+dNNSe9p47Kl9FdypKVGUhdYNpjyESaO HKFQw1jc9YBmBXjHRUuo2c231gD0F7eDY3a4i4+x75t8id3GKGZh X-Google-Smtp-Source: AGHT+IGBd/TXYqfXRbsJw/MakgwRG+zCUog/ZxdmHLRVg9xF1CKnV6jnv8JLXjGuLsdfHgzU8sYZrQ== X-Received: by 2002:a17:903:32cf:b0:1f3:33b:ff18 with SMTP id d9443c01a7336-1f636ff51d9mr75607115ad.11.1717331182266; Sun, 02 Jun 2024 05:26:22 -0700 (PDT) Received: from wheely.local0.net (110-175-65-7.tpgi.com.au. [110.175.65.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6703f7673sm7834145ad.210.2024.06.02.05.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 05:26:21 -0700 (PDT) From: Nicholas Piggin To: Thomas Huth Cc: Nicholas Piggin , Andrew Jones , kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 4/4] gitlab-ci: Always save artifacts Date: Sun, 2 Jun 2024 22:25:58 +1000 Message-ID: <20240602122559.118345-5-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240602122559.118345-1-npiggin@gmail.com> References: <20240602122559.118345-1-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The unit test logs are important to have when a test fails so mark these as always save. Signed-off-by: Nicholas Piggin Reviewed-by: Thomas Huth --- .gitlab-ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 23bb69e24..c58dcc46c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -4,14 +4,19 @@ before_script: - dnf update -y - dnf install -y make python +# Always save logs even for build failure, because the tests are actually +# run as part of the test step (because there is little need for an +# additional build step. .intree_template: artifacts: + when: always expire_in: 2 days paths: - logs .outoftree_template: artifacts: + when: always expire_in: 2 days paths: - build/logs