From patchwork Thu Feb 28 07:35:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10832601 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6CE31139A for ; Thu, 28 Feb 2019 07:35:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57AC226222 for ; Thu, 28 Feb 2019 07:35:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4ABEF285D5; Thu, 28 Feb 2019 07:35:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1A6B26222 for ; Thu, 28 Feb 2019 07:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726002AbfB1HfW (ORCPT ); Thu, 28 Feb 2019 02:35:22 -0500 Received: from mail-eopbgr20062.outbound.protection.outlook.com ([40.107.2.62]:3931 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725958AbfB1HfW (ORCPT ); Thu, 28 Feb 2019 02:35:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xzghQ45LM7IR8X+O/Hdbedq0zbq2Th6sW1GuuUa5Ups=; b=FiG4EA94+csoPswyHeonv4Ss3dss12DAFw22d3htpKZ3wjYXS2QOpf5pwmMMrY8IDZBUaow73Z2Y4rmirbmtifOD93fdwpRQf/ymfXor2dqhWTzqqoaC6jqctM7ZGvFLxA2moAkOv6VVFtlN9UFDS1CdPM4OIhLfplJ+JlCn3J8= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB4717.eurprd04.prod.outlook.com (20.177.48.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Thu, 28 Feb 2019 07:35:18 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%4]) with mapi id 15.20.1643.022; Thu, 28 Feb 2019 07:35:18 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v2 1/6] mmc: sdhci-of-esdhc: add erratum eSDHC5 support Thread-Topic: [PATCH v2 1/6] mmc: sdhci-of-esdhc: add erratum eSDHC5 support Thread-Index: AQHUzzgn6PjJzgcAbE2as5PoMQujsA== Date: Thu, 28 Feb 2019 07:35:18 +0000 Message-ID: <20190228073618.16061-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 294d792e-e2bb-4018-4c67-08d69d4f4955 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB4717; x-ms-traffictypediagnostic: VI1PR04MB4717: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB4717=3B23=3AwC?= =?iso-8859-1?q?YYe/yepizfMWdzoGJ1MwOch31IQRCoNren40D6bdZHxR1GwFQ1zJRke+i2EG?= =?iso-8859-1?q?iuS0gy2gt8Ux61buJ+OPCu5O6m49Nwl1BOPUZ9uxiU4OLwM84AcDLkHwalkx?= =?iso-8859-1?q?tBs4I6gHY2JuroWyptD3iCJSZVpo6yxe7IWZKpa7bV4Wf/fl/UaKWLBarG7g?= =?iso-8859-1?q?Ap+Figyfp4+rUTEsDNApqS3rMargxRDBnjWjOAaRvaoxVl/483Ugg+LJ9AIk?= =?iso-8859-1?q?0nMQuD4AvjH0eaMMMgf14L1dA2k8KpW9NFUpfNNERsYvvvJQKCBV1MQD6N9r?= =?iso-8859-1?q?gza7I2bYCuSyhTrnAK4gkqj3F2aL2GRWOLN6jVHuE1NR1G77OItJuUh/auQe?= =?iso-8859-1?q?96UF89PUPf0eIQaiXllVq+tY7tDWPM7QYZbDdKS1Qle3SrZ+0JkhM8O3f+io?= =?iso-8859-1?q?8WRDGBpeYr7kO8tSBp50c2RJVAg9HGpZdmBCZNnGld1SiWYPpWgq8kzTtWQi?= =?iso-8859-1?q?w+VqCjn5gjfsHZU//gDkDPg/Vene5gbbWsP3U6MhpEZrzCTActijpCdX0Ht+?= =?iso-8859-1?q?jUoHo51qAm4EJuk2nlb6PZq338er1h8w88iJLduFeE5w3Fs9m6Tq3CUAKY1Y?= =?iso-8859-1?q?LSOsBU71o0JQJY7KYLho+MDuDu/+PIUKRCZP3Z7ALemO5l5xWhyjH1z5v+an?= =?iso-8859-1?q?mNOIN4W1MbexMGxlkE45rIXav6ze/oN1wrhCl4y5nUHS/x6Qdr0JGXtm19CD?= =?iso-8859-1?q?mdVPgVnpS2SmKCLUuytxJC57KLrz3eM6sogSwADj3m0oV/4/VB0nDaGtU54W?= =?iso-8859-1?q?6DFuDKb8GU0eg3CINMzDegIL0RgTxGD0U23DlrrU1dgc+hRuzrGvNh7+NVEv?= =?iso-8859-1?q?GR+Ez4e41Pcs0W7vr4m+exyxHHFc+GLVoHzc38XUtWzyXaIArNbnvTAKXXgZ?= =?iso-8859-1?q?yDB326esnqeuxS7ykyd9rWJ2JJXWpIcMftj14gPOH3Kmh7NG06t0xJMoy0Ws?= =?iso-8859-1?q?ke2Q2d0s2IDH6U4xpv6JEcrEgzCxRZ6RWXo7h4Cayx4gSV7QvTe4HbeXq7hw?= =?iso-8859-1?q?KAAqdGFCBc1ee9HKAgB3c0z6/iR2B6f1Zufu5tNuAvzjcJAEGR3TX/rjYe0H?= =?iso-8859-1?q?YmGoN9cxL/wPAX++UfuhCLv+Gdoo0YC7PW0+0g9PzKBATNUPgpZKN0gm4XWF?= =?iso-8859-1?q?z9G5F+iE4ELxNLwy6+znaXCyWITKtoi1B0Mlns40bkZ2HhuCeuLEGKKSyo2b?= =?iso-8859-1?q?ZhdNTn4VPsfQlR?= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(346002)(366004)(39860400002)(396003)(199004)(189003)(71190400001)(71200400001)(6436002)(1076003)(36756003)(44832011)(256004)(14454004)(97736004)(2616005)(486006)(99286004)(81166006)(26005)(3846002)(8676002)(106356001)(68736007)(81156014)(305945005)(7736002)(386003)(6116002)(14444005)(52116002)(6506007)(476003)(102836004)(186003)(8936002)(53936002)(105586002)(50226002)(5660300002)(86362001)(54906003)(110136005)(4326008)(2906002)(2501003)(66066001)(25786009)(6486002)(316002)(478600001)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4717;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yJzbtKbwlUrOmXkUrEDSY8EySYKmeRQPTQ4oWnvdlMbyQy/t+08tYrTwZTVusJ9grjCk3zPSzRh33t7Cv2rTxMRNKbCPA2T2YFW+jd494jcfiIgh5iupIaoNlsDKV2Z+aDZWLhzztGShx+L4Uuj3Su/s4O4malBMxnfsr56nT4RPNEmbWp1OtcZp9+KkZB7PiYuddgmYtlCscY5JUvS7PTBaTPrH0duAdxouTxua+wrtbzBbkgOG4dpJcdDnTNFMHJ9U7l8QRP13EMyEm+Xyc3VP1jd2jJIjMsDVhYLwDSWJwf2rdnOCb0blGje86m1ASykV5WMN9YzqJ/Q/IGTcFZKKBpCPPqbrcoTJZMK9t5tIBt2LlknoacgtKsQiteGQFOKPjuYgvQ5VwnXnfr9binF6Yif/qxYkCXEanSyp02w= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 294d792e-e2bb-4018-4c67-08d69d4f4955 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 07:35:14.9548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4717 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu Software writing to the Transfer Type configuration register (system clock domain) can cause a setup/hold violation in the CRC flops (card clock domain), which can cause write accesses to be sent with corrupt CRC values. This issue occurs only for write preceded by read. this erratum is to fix this issue. Signed-off-by: Yinbo Zhu --- drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 4e669b4..9da53e5 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -1074,6 +1074,9 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (esdhc->vendor_ver > VENDOR_V_22) host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST; + if (of_device_is_compatible(np, "fsl,p5040-esdhc") || of_device_is_compatible(np, "fsl,p5020-esdhc") || of_device_is_compatible(np, "fsl,p4080-esdhc") || From patchwork Thu Feb 28 07:35:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10832607 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 69C801880 for ; Thu, 28 Feb 2019 07:36:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 572FE287B1 for ; Thu, 28 Feb 2019 07:36:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A1922891F; Thu, 28 Feb 2019 07:36:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E49CC28A09 for ; Thu, 28 Feb 2019 07:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730865AbfB1HgG (ORCPT ); Thu, 28 Feb 2019 02:36:06 -0500 Received: from mail-eopbgr150083.outbound.protection.outlook.com ([40.107.15.83]:13014 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725958AbfB1HgG (ORCPT ); Thu, 28 Feb 2019 02:36:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DqCBYN/AjsXgTa22hFT6wV7K0XlozzOunnDb2D1MpFc=; b=rdt5Cs7AhIWUovBKOi5pbPOliXScYG+DRByeMcsOsSsDCmz1ETgfXQWhfOIZ7xQaWNbK0J7LSusEVNkQsLc4fafyp8s3GDgnUBO7fC1Qb8Ib36REDreSZOfTuD2EPCk/AjIB6jeeKnBZnJWU6VOLq/bzvC6es2l03lxMLl+54uc= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB4717.eurprd04.prod.outlook.com (20.177.48.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Thu, 28 Feb 2019 07:35:23 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%4]) with mapi id 15.20.1643.022; Thu, 28 Feb 2019 07:35:23 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v2 2/6] mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support Thread-Topic: [PATCH v2 2/6] mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support Thread-Index: AQHUzzgqOdwuwEXb8EKOXOVovyFM1A== Date: Thu, 28 Feb 2019 07:35:23 +0000 Message-ID: <20190228073618.16061-2-yinbo.zhu@nxp.com> References: <20190228073618.16061-1-yinbo.zhu@nxp.com> In-Reply-To: <20190228073618.16061-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6142e720-771b-47f1-345f-08d69d4f4c55 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB4717; x-ms-traffictypediagnostic: VI1PR04MB4717: x-microsoft-exchange-diagnostics: =?utf-8?q?1=3BVI1PR04MB4717=3B23=3AxWndpoE?= =?utf-8?q?t1s+WsQpcrQFtnKXMM5R3KgAIdbmYF3ZnlS5Ddd3AcIgpVCwfMK0MeHs1h65x8Wby?= =?utf-8?q?fXWomEO6QJUHU1fkftfU2fwRnlHQ6WYKlFoRQ0EHAt7/OBOoRBlXYqy5siEszFo/e?= =?utf-8?q?lY6UfPzj/NU38I+VRo7VVL++eq/fmlS34eFZcwU+kD5xpxVOz0DMsytZvn0iG4SW4?= =?utf-8?q?W1x9cZn25rx/JdFo5tuSRJiM7/GMrej6dRqpJMufHorjRgcI2xhaY+tfdzxe8ANGi?= =?utf-8?q?HG78Yc6DJFiWEyyashX8Bc/qKTK1uok6WuinhMXix/+jEcbPAZ9DLMzJI9ne2mFtS?= =?utf-8?q?bsHDb/HcwrhlMPVbo+zosJIApPDxJbBRqbzorX4nrAe6demXT75FhZZr94ebZ75+n?= =?utf-8?q?BQMFezzwEd3wPSvEl8uoSIJfmsWWQqsd/ZkD1fakWJV4ziEzqZDLVp65OWF8iv8fD?= =?utf-8?q?wLARbK9q8X5/5w0VldRLByfoHivnudGO/zgPRHGlwTp0zXGxXkhoaU+lpANEh2JjE?= =?utf-8?q?FdWFz//r1NSIQOW01k1dETS9skuFMY7FbNOc/lDNK3BTBEasIi0fVZ9x1goXBguqx?= =?utf-8?q?N/o5EA0v/PGxcX5syMKanYu2JMOh6FrbFBffJ3pq+oAUMZ+b4ak42nHUDTLl5xEg1?= =?utf-8?q?+6lAHIragd34GINLINXKgueEYdN8IXYzljhPDaOboa1dpYWTchkWCJjawAVlxhNjl?= =?utf-8?q?5xRhqg1gh1u5xlLPVlED77kq4FFXjcM7vjkXg9bVq6IvgKuuCtoWFBERRasV8X6UH?= =?utf-8?q?NhAiTvWmeaJ3NkgYulZdqrTG/PZK17WytKpw3YHod7fHbzuSH5NWwgXYwXOtxxuXE?= =?utf-8?q?ANFJeYHwx4pWYtxV+D07PJJUEPh6t+ciehnPmgMDRb6ywUWwJP1obHYXmPRmu0r9m?= =?utf-8?q?/ZdYDiYAYMWoKZaoghKh7NfEStOKEzl1DeH+iV8iO06tRIcMjbvDZCTUdhyCrYdJU?= =?utf-8?q?/O3evRS+6ui/LMir7rok3nbNjxHo4TvnQIm5uihjVTVhqDh2orQEUK8uAj7Hwyxed?= =?utf-8?q?bG1hzwfHTzjVmqE666nTuDZ3yFn3lNre+8xhuMWPKtcNGIkZ+y/pq120rcUFtb4mh?= =?utf-8?q?CBK7OJ2I50AFwtd3TwKjAo7huCCFvSrw1/S/uGtXmUbakRUoKna0i22jvAd51y4kQ?= =?utf-8?q?nIIg6VGwJS4eeNotHCy6zuEplHpyqsGYMMckKJ5rNwB3EZoGED1oErvm3Ug0EJYyD?= =?utf-8?q?FldmIwn+0Zm7DaXIcU0S6HNQUVcvizifvNIK/r?= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(346002)(366004)(39860400002)(396003)(199004)(189003)(71190400001)(71200400001)(6436002)(1076003)(36756003)(446003)(44832011)(256004)(14454004)(11346002)(97736004)(2616005)(486006)(99286004)(81166006)(26005)(3846002)(8676002)(106356001)(68736007)(81156014)(305945005)(7736002)(386003)(6116002)(14444005)(52116002)(6506007)(476003)(102836004)(76176011)(186003)(8936002)(53936002)(105586002)(50226002)(5660300002)(86362001)(54906003)(110136005)(4326008)(2906002)(2501003)(66066001)(25786009)(6486002)(316002)(478600001)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4717;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: e0oK1gnX2nbLkkEOZuW6gwOqkBhAVFQOmUzpU3tGAWDbGGY13sfhVkSzEQycr7vdWxBgDH+numQqJxGc4TSTWeOzBeF3EsSXPP5TpucvqntU1Z+fOEpxskMRQWqFKgoPsC2kPLywTqkdhW3olLjx7PPxeRVz+j/YYoZGhwgxb1uYfWmkdnY+RgOp6WeMbQtvLla8qPNxAZ19BZC2cJ13zSbqBU5qX6ZVgvA3LOl13EDt71jH/q6ml5RJ9SIbk/0gZI/eueASUJ5GICCW0xiNpIt0NWwWovBiZJvFWD20IU3EdQfbSZWhEBwuTJAcPn9bnJPlhOLYDZPzR8rp8UMp7pL1WYcigfrzAq9DVzaxNgKg8FFyEjWA0KT1A5ZhKyzvVtQDvScQpVTf7vuYr75FZurm7RF9KMMUCJ37y7S9p/s= Content-ID: <82EF242D1AF8DC47948E697F63DFDE11@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6142e720-771b-47f1-345f-08d69d4f4c55 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 07:35:18.6163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4717 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu eSDHC-A001: The data timeout counter (SYSCTL[DTOCV]) is not reliable for DTOCV values 0x4(2^17 SD clock), 0x8(2^21 SD clock), and 0xC(2^25 SD clock). The data timeout counter can count from 2^13–2^27, but for values 2^17, 2^21, and 2^25, the timeout counter counts for only 2^13 SD clocks. A-008358: The data timeout counter value loaded into the timeout counter is less than expected and can result into early timeout error in case of eSDHC data transactions. The table below shows the expected vs actual timeout period for different values of SYSCTL[DTOCV]: these two erratum has the same quirk to control it, and set SDHCI_QUIRK_RESET_AFTER_REQUEST to fix above issue. Signed-off-by: Yinbo Zhu --- drivers/mmc/host/sdhci-of-esdhc.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 9da53e5..1ac1133 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -1074,8 +1074,10 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) if (esdhc->vendor_ver > VENDOR_V_22) host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; - if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) { host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST; + host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; + } if (of_device_is_compatible(np, "fsl,p5040-esdhc") || of_device_is_compatible(np, "fsl,p5020-esdhc") || From patchwork Thu Feb 28 07:35:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10832603 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 057FB139A for ; Thu, 28 Feb 2019 07:36:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5581287B1 for ; Thu, 28 Feb 2019 07:36:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D7E4228A09; Thu, 28 Feb 2019 07:36:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A363287B1 for ; Thu, 28 Feb 2019 07:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730834AbfB1HgD (ORCPT ); Thu, 28 Feb 2019 02:36:03 -0500 Received: from mail-eopbgr150084.outbound.protection.outlook.com ([40.107.15.84]:46037 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730749AbfB1HgD (ORCPT ); Thu, 28 Feb 2019 02:36:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ILtP1bVf7lLRWLduH1cFUf4JfTVXo9QOT3E7TWNkrWI=; b=M8GdbBKOzpEchfOgRbeN3Dl8XDeKzNz+Cb34tCTucddzTvVZr2/sqao+rjpL+EOcMUdO3sSQy/emAjsUzKYyz5F593uXDnhMNmqbAnVT4QptYRDltQ5aR9H4ExCkl8uQghbNcdWAg3zby7GXrccl2N3l03+rWrWDE2CJA5q4BbY= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB4717.eurprd04.prod.outlook.com (20.177.48.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Thu, 28 Feb 2019 07:35:26 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%4]) with mapi id 15.20.1643.022; Thu, 28 Feb 2019 07:35:26 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v2 3/6] mmc: sdhci-of-esdhc: add erratum A-009204 support Thread-Topic: [PATCH v2 3/6] mmc: sdhci-of-esdhc: add erratum A-009204 support Thread-Index: AQHUzzgs6e4MC9yiKk+PxQ4eTOuLZg== Date: Thu, 28 Feb 2019 07:35:26 +0000 Message-ID: <20190228073618.16061-3-yinbo.zhu@nxp.com> References: <20190228073618.16061-1-yinbo.zhu@nxp.com> In-Reply-To: <20190228073618.16061-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c6fe3e09-b0c5-476c-3f22-08d69d4f4e58 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB4717; x-ms-traffictypediagnostic: VI1PR04MB4717: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB4717=3B23=3Al1?= =?iso-8859-1?q?CxwkPBqHqxCZ5IiniLhf7SZsaXuVA3eUABFnOkkRENyqOmnl6C6UMbCp3Met?= =?iso-8859-1?q?igAwdTAF0Ye9iKURFsMhpR+eBtRtibv6m5OGFaIFNpEmfW7BuSmYQvPkAI4L?= =?iso-8859-1?q?p6NDiGKgscZFt+MXAWmoXovsjCsC+13z9GDKSoLbIVrq3tjMtPBeRX/zZWEv?= =?iso-8859-1?q?ErLYjBycY4Jo9KRLsCTTcW4DH71mv4QssROQlfWcp8rgQaAgwj+Z2xEZgf50?= =?iso-8859-1?q?g5ZOnVNhYfywrAo9yQr1n4apI2fgoFHuXHuQl/1kdXK3xCxSL7MU1XkWMpB0?= =?iso-8859-1?q?Ew1g/SvHCIR8amETJQTJEuDXEuew8+Qfx1iJC2NKaAi/imnLJClwsG/kuqU/?= =?iso-8859-1?q?PwZqSH6QEL8ZUdLM2dRIeHhxqlJcmgy5ld1iP/WcbO7+/mPMThUacOZBgiud?= =?iso-8859-1?q?NVx0pqY2E3yMnjFBwxxRDAhdBkfDeQQIEwmlq1t4i580RMRvqRB6mroj38gS?= =?iso-8859-1?q?sIHhVKEfPEXmSbDILdLtwFpB2WZKe31vEsESVdg0jovAiX84fqlpdtr0H8V/?= =?iso-8859-1?q?UZLVNalizaeWccTQfE4K9ygPLFS7MZAk7nVu0f3Q0fB2wfiuL0JlCzO+KlxN?= =?iso-8859-1?q?L3eAJHwAfD/rAHKFoBcZhwKGUnAaQuwV1E+jqc0sq1ycDn631HtIvUY1P7Bb?= =?iso-8859-1?q?hiPgUwylOvQT2csg7FK5giSrp6Kh3WZErp18Tfow2c0LeMd9bPADVg7Do+4i?= =?iso-8859-1?q?vlD1gZkWzRkjhmD5sRCGj/lwCTuBPZ1VznByOVMKZazUtiuyeRZ0WtwyWZPf?= =?iso-8859-1?q?3ZDEhPUedaXT2IHAfpBYPeUCfOXT/X9Glhvy0UH7PX+qs6kQMF9x3MbJfYyI?= =?iso-8859-1?q?WYPpP9hbHXO5AsMeAWA67/RUIIq067qewwf+gVEUno0G13gf1jM+W9lfxcr7?= =?iso-8859-1?q?KG6Zd0f8Rk/CaUBJahHx29YEvc14oVfNnpa0GXxgbEjl67Wcuyiv87wCQ4DC?= =?iso-8859-1?q?e4pO0gwNr+PO5C5IqjXwEyl0Cq3Y0W2C6sQXJdlzPfmewcjWXIzbgs0x+QgT?= =?iso-8859-1?q?KEJ0HdZyn7+CatZlXc8CwMLFO+juAxeTMzrCutLYkZp83asu2atk8f5+mznm?= =?iso-8859-1?q?ItecspH7jBLLkwU+CIeqracENoX0OA6B5rigPcyukW35WiYf2Xij06b+7Ten?= =?iso-8859-1?q?y5Pwm0iulCX7HsTIxNjQda6yGXZAh8N24bAYyI56XXtKXryxvbpPYC4kJ6xn?= =?iso-8859-1?q?/zCMURxmlLLhQ6kFaXrciyQb4vSWAa4PUYvFnJrbONMu3gqKEAErZjihr2Rz?= =?iso-8859-1?q?LY+919YdwhUq8LeEM8?= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(346002)(366004)(39860400002)(396003)(199004)(189003)(71190400001)(71200400001)(6436002)(1076003)(36756003)(446003)(44832011)(256004)(14454004)(11346002)(97736004)(2616005)(486006)(99286004)(81166006)(26005)(3846002)(8676002)(106356001)(68736007)(81156014)(305945005)(7736002)(386003)(6116002)(14444005)(52116002)(6506007)(476003)(102836004)(76176011)(186003)(8936002)(53936002)(105586002)(50226002)(5660300002)(86362001)(54906003)(110136005)(4326008)(2906002)(2501003)(66066001)(25786009)(6486002)(316002)(478600001)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4717;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AgCjTJP1t5GM/qxlMpH4nHPTouEc4bHOQQ1Re5rkNsLbHdZFqnmLR21yrG//uocx9iTBFiQdv1gEC5Kya8NLONqBmZg+GYMHWRzoGL/Yl+PV/NIingxlUfOUOP/iWFDWM99YPZ1tBOS8XKTlSwIBy7lr/hitzwUsu0YLVwyCmfZ+TxiLk+6qPcchILlluMUMGHkOltD41FYrEgiROu0P/EGk37gJJzgT+jdVmFEcpN779027fAhcVwg5bPaR8yU/34G/PQ0sBXy9rC/vnE5Sdm+5zgCtZSgCBv6xlA0Q3fHhsSZvrF+xbIpwwpUyvUgZGqklCtwwP2eixLvg0wwIk/SXzjGTxmQXOLrI5hb0svkNQxywaUfXxnUcfm1+RnejQZYXDGKqEzLdZqj3UIthfPMcFWYSgD7vwXKcVKFsfac= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6fe3e09-b0c5-476c-3f22-08d69d4f4e58 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 07:35:23.3747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4717 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu In the event of that any data error (like, IRQSTAT[DCE]) occurs during an eSDHC data transaction where DMA is used for data transfer to/from the system memory, setting the SYSCTL[RSTD] register may cause a system hang. If software sets the register SYSCTL[RSTD] to 1 for error recovery while DMA transferring is not complete, eSDHC may hang the system bus. This happens because the software register SYSCTL[RSTD] resets the DMA engine without waiting for the completion of pending system transactions. This erratum is to fix this issue. Signed-off-by: Yinbo Zhu --- Change in v2: Do that within the driver's ->reset() fn. drivers/mmc/host/sdhci-of-esdhc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 1ac1133..7e0eae8 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -694,6 +694,9 @@ static void esdhc_reset(struct sdhci_host *host, u8 mask) sdhci_writel(host, host->ier, SDHCI_INT_ENABLE); sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE); + if (of_find_compatible_node(NULL, NULL, "fsl,p2020-esdhc")) + mdelay(5); + if (mask & SDHCI_RESET_ALL) { val = sdhci_readl(host, ESDHC_TBCTL); val &= ~ESDHC_TB_EN; From patchwork Thu Feb 28 07:35:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10832605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F449139A for ; Thu, 28 Feb 2019 07:36:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E478287B1 for ; Thu, 28 Feb 2019 07:36:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 02AD328A33; Thu, 28 Feb 2019 07:36:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CFDD287B1 for ; Thu, 28 Feb 2019 07:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730734AbfB1HgG (ORCPT ); Thu, 28 Feb 2019 02:36:06 -0500 Received: from mail-eopbgr150084.outbound.protection.outlook.com ([40.107.15.84]:46037 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730825AbfB1HgF (ORCPT ); Thu, 28 Feb 2019 02:36:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBW30CfquRyEAd3eZ4iHX7TilBOsVbCeUoFYdVFhifo=; b=lM0+oZAI/uVkrl6UDMH/8eizVEr16bO5VN8mCGdxJMY68cEZTbMQvvrcG0wi7q0FOzOGT13f4LtwMB1xLmtvxzr7Tjo1S2Zrttfboo9/jv/71z8ahfsrdAOHXcsWiMJKYizQQyibnNpVDVm1AVgnDYhdoAOOZpcklvXdP7V2IYc= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB4717.eurprd04.prod.outlook.com (20.177.48.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Thu, 28 Feb 2019 07:35:30 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%4]) with mapi id 15.20.1643.022; Thu, 28 Feb 2019 07:35:30 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v2 4/6] mmc: sdhci-of-esdhc: add erratum eSDHC7 support Thread-Topic: [PATCH v2 4/6] mmc: sdhci-of-esdhc: add erratum eSDHC7 support Thread-Index: AQHUzzguQngNtdmz9UCBBydhG8KdRg== Date: Thu, 28 Feb 2019 07:35:30 +0000 Message-ID: <20190228073618.16061-4-yinbo.zhu@nxp.com> References: <20190228073618.16061-1-yinbo.zhu@nxp.com> In-Reply-To: <20190228073618.16061-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe870555-5bf5-461e-68a6-08d69d4f507e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB4717; x-ms-traffictypediagnostic: VI1PR04MB4717: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB4717=3B23=3Ad4?= =?iso-8859-1?q?CPvRQuFA5fE/zS8nF5X9hC4qcFEKveQ93PPEZ3vQhIMf0RZwJ04/6fZ1AitC?= =?iso-8859-1?q?bLrhCVfHOnWUSP7WBhCxQXW48EqswCjdieSwRxoF6trkakj+phZ2q7gpH5Tv?= =?iso-8859-1?q?tQ3wMBprRvrYBSD9z9JyAI70palEXYbU01lDG1c1+HI73Yw4S/vkDHnKzs1z?= =?iso-8859-1?q?6D0WehszF2YhlDQRK6riv3NKbwPFAPDB5hPkodpDemDaebZybRVOY3o2LBOd?= =?iso-8859-1?q?YZG/UWqlwDYbpMJw1nPhQzKdvvabFJypH3/kIMxwRCjIQRMBt5Jue/8ZYQim?= =?iso-8859-1?q?Zn2jKs106GLKx+5JvAnAwlpiuAwQjCaYpZ01HtQBBRuIgRBzi52B86MDWe7P?= =?iso-8859-1?q?wdEZLITj8Oi5GDQR/WH9+iYEdjLKsRfPxVVnav4Zupy1HSh3ouS6Bm6L1soo?= =?iso-8859-1?q?j+DTnrqpFnU2ffGe9LJTzrtG86KBLroe3XPkPIiBo1EuW1S/Bt9IKReNrIPD?= =?iso-8859-1?q?5CFV2dgsmVpqCTTnCNiFFmPud3BzhTdrLNB7Xb0zi2c7JZwG47/MryRDtLg8?= =?iso-8859-1?q?gQkI/F/hjrGtIkFrKgMLQcEJFEHXy/+x+8yPMKQkKhmN46RciGT6sZeDFJ6C?= =?iso-8859-1?q?E7Wjlpd+UpBXjbYkiSnOTJdSbBRfd3Qjy6kNzt0ST0uOebLaX3Sf8vW5kCGX?= =?iso-8859-1?q?oFM76uKuWKIcMTH4KVuQh9jJcoOqWWk+pWWKugfHtJcARY/TAi9Umlg9uPCM?= =?iso-8859-1?q?N919chS/QtQmpGXrPBb9Ka+T6Bw0O5nenlXXy6BdzZUifD1pr7cuHq61+1CV?= =?iso-8859-1?q?IxzW8Skc4pOgPJX4/bug4SFyNm5i/WAMJ8zIpWkF7+vOoMyuucQsM9z8rJ7Q?= =?iso-8859-1?q?0inRDe63opa4Eq1nBiOzNdGoB3r6Dh/bAYMLm9sXfZnBOn034jGQEh4BvZRr?= =?iso-8859-1?q?Y9OdnwJTjXmXH6N7p8ZvocHHTGxKy5z0CVKs+HiJFvAIgNmT6mBclZ4Bz7CZ?= =?iso-8859-1?q?pexM/JKZ/xg+respVaDJF8SoyLPWgRw0WZZ27uSUhZbbpjXCuC1LUO1Kfr1S?= =?iso-8859-1?q?Nra7/icfXHfkP1brgN1i/qvvd2RI2Fjg85q/9ZaMfAfoIghoy2PyAs0qS8kX?= =?iso-8859-1?q?wavZh2T0GEkzXOW0ytOmNZaaSxWXCwXs6Y/cJgqY8d4kgxnXlIxrbu9eUQPR?= =?iso-8859-1?q?S5nZzoCKmX+F4ESOxf1A/bCvEsB0XGfIZgIhTF/JW5B1PRQqk/s2R58wIVOJ?= =?iso-8859-1?q?mQFcPsx+lvZSeioRzXAejDNyWo6uopk1+gYFIpBNyEwn7a8O39nI4FR/Q=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(346002)(366004)(39860400002)(396003)(199004)(189003)(71190400001)(71200400001)(6436002)(1076003)(36756003)(446003)(44832011)(256004)(14454004)(11346002)(97736004)(2616005)(486006)(99286004)(81166006)(26005)(3846002)(8676002)(106356001)(68736007)(81156014)(305945005)(7736002)(386003)(6116002)(52116002)(6506007)(476003)(102836004)(76176011)(186003)(8936002)(53936002)(105586002)(50226002)(5660300002)(86362001)(54906003)(110136005)(4326008)(2906002)(2501003)(66066001)(25786009)(6486002)(316002)(478600001)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4717;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: sSuhDOt0yq68zyKz6aQwNw0JGbSIRo8ENzPsDUqBx5oecb+BRkW9cdP1ryyBUB6Ax4W3VuPv02BsiYvnEP+0U+XIpOIUnezUabOf7JzcRuiG0VR9eGGqCr0M8P8vFLknsu64p/S/jvKgi3W3FnbmXLbmdWJ+b5CX6/6kfkJFjf+wLp1fJI/rqPX88lcYEWVYPE3LsBGWYC6ow32ZFL6hfr/j+4GXI8s0KD0ra4T/HRQtt2ZWTs0EG6ChYCgRqTiK4sNp1QKCmStxJSdaYABzt/HBYQjQY9XpG+a8XBB0cPr7/AghBZLAkOk8cI7NPFzRDQlXn5KjwnmJOAy/xcw5vXh4wC6gaFtV6OpFaJmzidY3LRq3zRvb/wBwe9d0pjG5iog4PxI+LIF2r/AD+Op8X18w15A2QgJRbmUJs4IcOGc= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe870555-5bf5-461e-68a6-08d69d4f507e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 07:35:26.9362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4717 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yinbo Zhu Invalid Transfer Complete (IRQSTAT[TC]) bit could be set during multi-write operation even when the BLK_CNT in BLKATTR register has not reached zero. Therefore, Transfer Complete might be reported twice due to this erratum since a valid Transfer Complete occurs when BLK_CNT reaches zero. This erratum is to fix this issue Signed-off-by: Yinbo Zhu --- drivers/mmc/host/sdhci.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 39bbbd7..2140762 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2985,6 +2985,15 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask) } if (intmask & SDHCI_INT_DATA_END) { + if (of_find_compatible_node(NULL, NULL, + "fsl,p2020-esdhc")) { + command = SDHCI_GET_CMD(sdhci_readw(host, + SDHCI_COMMAND)); + if (command == MMC_WRITE_MULTIPLE_BLOCK && + sdhci_readw(host, SDHCI_BLOCK_COUNT) + != 0) + return; + } if (host->cmd == host->data_cmd) { /* * Data managed to finish before the From patchwork Thu Feb 28 07:35:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10832609 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CEC5D139A for ; Thu, 28 Feb 2019 07:36:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB621287B1 for ; Thu, 28 Feb 2019 07:36:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF6AA28A09; Thu, 28 Feb 2019 07:36:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 522C6287B1 for ; Thu, 28 Feb 2019 07:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725958AbfB1HgH (ORCPT ); Thu, 28 Feb 2019 02:36:07 -0500 Received: from mail-eopbgr150084.outbound.protection.outlook.com ([40.107.15.84]:46037 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730749AbfB1HgH (ORCPT ); Thu, 28 Feb 2019 02:36:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+jBoTIjXLAxeP9/8Babx1X1S+fb/h6dSD9cixVjdXxI=; b=eo5WiGo3UX9DmEpIEOsE4fk743Kl6dfwMumNgi/D7CfqgrYdD9gJQkjN2jzr5qUNBgszS49Zab3gLgCkOVqatHA/ywOHPvrgvkrN6fP5SllrzXh3r+d9niNqnBDJWcvmUnWFD3EVeWEDLr8h6K6p9t2GD1xYikCiB/vFTUc/6qQ= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB4717.eurprd04.prod.outlook.com (20.177.48.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Thu, 28 Feb 2019 07:35:34 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%4]) with mapi id 15.20.1643.022; Thu, 28 Feb 2019 07:35:34 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v2 5/6] mmc: sdhci: add quirk to ignore command inhibit for data Thread-Topic: [PATCH v2 5/6] mmc: sdhci: add quirk to ignore command inhibit for data Thread-Index: AQHUzzgwf/VRot5GikuPaOkfxpBr0A== Date: Thu, 28 Feb 2019 07:35:34 +0000 Message-ID: <20190228073618.16061-5-yinbo.zhu@nxp.com> References: <20190228073618.16061-1-yinbo.zhu@nxp.com> In-Reply-To: <20190228073618.16061-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0ac5a330-c3e8-4f7a-ea83-08d69d4f530f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB4717; x-ms-traffictypediagnostic: VI1PR04MB4717: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB4717=3B23=3Amh?= =?iso-8859-1?q?L/j4IBgD7zB3A+bqARGTi56XaOiLx+bIfIf3m7CoouQqA69mT02hi3aRpcfP?= =?iso-8859-1?q?KqpAHTreGefqu5Et86jFS4U3gPI2ijQnMOZ8jX4q65Di23ZhtVD16wB9OIm+?= =?iso-8859-1?q?HkRAz6oezPzwduMHOdq+mJJgfj+rWoCj7sS6pvdqa59jeyRdniJtWokpIXSK?= =?iso-8859-1?q?7djQGmCDHibMZtF9yrVoXAU5P8BeQUUBDb3W/DatJjGvrQPjQk1UV3JO1Moo?= =?iso-8859-1?q?jZLxLMWnzzSQBbjg4KN0cIzmP7/o3zJmferp74Ki7VLc/2i5ajv0GytDgwUp?= =?iso-8859-1?q?C25p/WE/YU3dt4Tg3m9oVZQHQGs5Os/ur9cxioefKBQEKuJMc3qxbdsVyxDc?= =?iso-8859-1?q?wPNIb6Ty5avw1jIh45cHI7LEBm82RR2oC/8H8yJ/6yH+tlFZgHgf9U8n6Bfk?= =?iso-8859-1?q?bLQhMXDRMSDqe/N91c2M/InA1EWWKDF2MwugqgySDqtvUuotRMNrRKDob9Ip?= =?iso-8859-1?q?2sGCvwnCxLcmWxDw9Dcgn/R8ERN+LZJC+UtlOdJeIic4vclfn3+qfAhkCVXt?= =?iso-8859-1?q?bAQTb7qMRv08I+8Op2kRU5cyEmxETYccXO2pHpNy2NivuGre1ZEddvSCqsl1?= =?iso-8859-1?q?cO8hMhKXahP6O97x2gfvbDcN3A/7kT//DzRHxvRwhEymf4nekwYzIGuPpl3E?= =?iso-8859-1?q?jNVxyQczqBwmxexe9XemgPhBMhKYhTVnbu9uLhMon6LCrEO8fqEarJoK+Lvz?= =?iso-8859-1?q?eJrF3MWi3mCjQVJ9X3ccnlXWrvlxg02pStDZnvh4crtU7LeThoxfiQh2SnDs?= =?iso-8859-1?q?ru+RniLYry/Y56saxP8Uk6yXR0LgqCI4nLj4jgo/WllPLf3eZ65iDf8rFWTw?= =?iso-8859-1?q?km9waMa2miHDLKi60Dj0+c5bUgqYNQ9Cv9obf1r8zoTNDvHSpmLwvujq/7Pk?= =?iso-8859-1?q?8xlAW7zYC3SgM+ZoGr4y2NKo6TBwSo2NLdOZLnIeJKHgmXQ48Qg9kdv+m3F/?= =?iso-8859-1?q?71CuXsbHaweuKUz0ixo9O7qmser6fDLY4dVVGalX47uWTofJJun7tU53xCTM?= =?iso-8859-1?q?U0xAOrWPb5Gx6w1KRpSDYCYTde1iHU0Jk2jAWrLB1c+YvYYOUp+X7U7vZsNN?= =?iso-8859-1?q?HpdtfDXOxU8Ku1I79D8e9C3SBuZUAGbroJyFNUesQE2+T2Uzcq9Z1kJd/tiq?= =?iso-8859-1?q?3qlJ/zTxePO+xuZB7T0HtCw0ufdHpRcUkHiB1TzwqXC7F2gT84mu39MVW5q4?= =?iso-8859-1?q?hqkNRWK+0RDMwO6NhYhHN36/tlWF+nzKtL7dtsahAeDZu2IRzB72sPABQ=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(346002)(366004)(39860400002)(396003)(199004)(189003)(71190400001)(71200400001)(6436002)(1076003)(36756003)(446003)(44832011)(256004)(14454004)(11346002)(97736004)(2616005)(486006)(99286004)(81166006)(26005)(3846002)(8676002)(106356001)(68736007)(81156014)(305945005)(7736002)(386003)(6116002)(52116002)(6506007)(476003)(102836004)(76176011)(186003)(8936002)(53936002)(105586002)(50226002)(5660300002)(86362001)(54906003)(110136005)(4326008)(2906002)(2501003)(66066001)(25786009)(6486002)(316002)(478600001)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4717;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: CCT3STqeb0mZX7mnQ50CdPnkcAyW66O4H7SktV0OO9CuGpnen1SA6OLUiF2iRuLbkXNtA3LSEgCZJ6gFN2Y3ymrieMRLR2mYQDQuamENL8QsVF4q2iw58oJXB/X44/2OTf3D3EaFDV0BvrK2yFRw4JABX97btiLmmWuRTMvxAxcLOBtH+SNl/YgS/3whLmrVwm7zyLWK0yoTNS7svU/yb8Qo3xRP9y7kVpwF778JRlR64hNZbYB6X489hvpuebpZ3UVCMCSbcOsnh8IMES+1BzOLJ34yYsXEFJAgkTzMMnxwvBG5skcPmkVoKpBKYgMKtFKQ6HVy2d2K5whohPOCo5Dxsms2tkiA8zlCNT26nEMyOr7cQOeHm0Tv66NmXdWIEsmdfxjEhEZM3EmlAzDyz5m5WyrE8+M4VwH9Mvt354A= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ac5a330-c3e8-4f7a-ea83-08d69d4f530f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 07:35:31.2352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4717 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yangbo Lu For some controllers, in Present State Register, Data Line Active bit is not reliable for commands (such as CMD6, CMD7, CMD12, CMD28, CMD29, or CMD38) with busy signal. DLA affects Command with Data Inhibit bit. Therefore, software driver may not know the busy status in DLA/CDIHB. Futunately MMC core driver has already polled card status with CMD13 after sending any command with busy signal. So we can just ignore CDIHB never released issue for such controllers. This patch is to add a quirk to handle this. Signed-off-by: Yangbo Lu Signed-off-by: Yinbo Zhu --- Change in v2: Instead masking the bit in esdhc_readl_fixup() drivers/mmc/host/sdhci-of-esdhc.c | 13 +++++++++++++ drivers/mmc/host/sdhci.h | 2 +- 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 7e0eae8..8c78ad8 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c @@ -147,6 +147,19 @@ static u32 esdhc_readl_fixup(struct sdhci_host *host, return ret; } + /* + * Some controllers have unreliable Data Line Active + * bit for commands with busy signal. This affects + * Command Inhibit (data) bit. Just ignore it since + * MMC core driver has already polled card status + * with CMD13 after any command with busy siganl. + */ + if ((spec_reg == SDHCI_PRESENT_STATE) && + (host->quirks2 & SDHCI_QUIRK2_IGNORE_DATA_INHIBIT)) { + ret = value & ~SDHCI_DATA_INHIBIT; + return ret; + } + ret = value; return ret; } diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 01002cb..65075b8 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -485,7 +485,7 @@ struct sdhci_host { * block count. */ #define SDHCI_QUIRK2_USE_32BIT_BLK_CNT (1<<18) - +#define SDHCI_QUIRK2_IGNORE_DATA_INHIBIT (1<<19) int irq; /* Device IRQ */ void __iomem *ioaddr; /* Mapped address */ char *bounce_buffer; /* For packing SDMA reads/writes */ From patchwork Thu Feb 28 07:35:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinbo Zhu X-Patchwork-Id: 10832611 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 975BE139A for ; Thu, 28 Feb 2019 07:36:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8553B287B1 for ; Thu, 28 Feb 2019 07:36:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7997D28A09; Thu, 28 Feb 2019 07:36:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B683287B1 for ; Thu, 28 Feb 2019 07:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730749AbfB1HgJ (ORCPT ); Thu, 28 Feb 2019 02:36:09 -0500 Received: from mail-eopbgr150083.outbound.protection.outlook.com ([40.107.15.83]:13014 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730825AbfB1HgJ (ORCPT ); Thu, 28 Feb 2019 02:36:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgiOz2wBeEEghRViA5gUaM3kaDuFfdvVVpEAaNz3xXU=; b=Z0PSGEjULLZBwQg1iKgATpvaU/DjLnNpfjanXzZORgVckjdcjCHCUXZVjyxQwOuyC8Q/9z2Kzad8MjYZjfKARdE1SKJz1B4KdrcHc922Y4cq2NY0BvMPN3UzPXqaueMO1wOiUCjZGfCi8gRBu44daSpV895BZ+Mtu5lD4T/BPnQ= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB4717.eurprd04.prod.outlook.com (20.177.48.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Thu, 28 Feb 2019 07:35:38 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::3d6a:1448:117f:5b06%4]) with mapi id 15.20.1643.022; Thu, 28 Feb 2019 07:35:38 +0000 From: Yinbo Zhu To: "linux-mmc@vger.kernel.org" , Adrian Hunter , "ulf.hansson@linaro.org" CC: Yinbo Zhu , "Y.b. Lu" , Xiaobo Xie , Leo Li , Jimmy Zhao Subject: [PATCH v2 6/6] mmc: sdhci-pltfm: add quirk for P2020 to ignore data inhibit Thread-Topic: [PATCH v2 6/6] mmc: sdhci-pltfm: add quirk for P2020 to ignore data inhibit Thread-Index: AQHUzzgyidU/dBT5g0iU6Hl212CiQw== Date: Thu, 28 Feb 2019 07:35:38 +0000 Message-ID: <20190228073618.16061-6-yinbo.zhu@nxp.com> References: <20190228073618.16061-1-yinbo.zhu@nxp.com> In-Reply-To: <20190228073618.16061-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8df88c47-1543-4cbe-cb5a-08d69d4f5528 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB4717; x-ms-traffictypediagnostic: VI1PR04MB4717: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BVI1PR04MB4717=3B23=3AhD?= =?iso-8859-1?q?QfqxTNLa1JmR+yswdy6cV5RsZ8dwEQ2r7sQc1PHaqxFrVL5k1u2OKpbU7lG7?= =?iso-8859-1?q?j+WWNLvE/CzW8ic/JEPJZ1rKCYgjJLB0wvjCZO3lIYkOLRXaRe2dl4QANh8L?= =?iso-8859-1?q?/NsHzJPP6+2hRSAd0zq7U2mpVXF/r5pWQodOn79DECSrzzkGyEVkF+xXTsM6?= =?iso-8859-1?q?x5lDqQwwegOYSCz818a8xCE3ATSNhV27fzM5OKP5BGRBDGhFO/tTEkfTpgoU?= =?iso-8859-1?q?3YXp7PV05iHdrTU1X7lX29XzZT6/g87v9QHOrNeMEnlCHk9k3mp0qf+EGKn9?= =?iso-8859-1?q?8gx4lCcJC83fMGHJO1mGQrA1ZPQYsm4RJyPrZsfWDIvFB31rzucyxNuu2sHl?= =?iso-8859-1?q?LZOuZvtQ1EXsPwfcak5ME13nK12qNUgrunBAioEbKn2dJYNEUSIpHGpTtZGr?= =?iso-8859-1?q?ebCNxr7PhEBvpstz0UETdpfBcpXrZOX7mT3/amCVp8Yq2rR0Z1b1wmpofiI6?= =?iso-8859-1?q?if99+sXTOXcnMucZnw533ngNvawwEMhlXBDyUqcsSYvONpomcdKYPsBFco2G?= =?iso-8859-1?q?UYJwhSwF0CtoXC0ZS3Vz/c+jpYAWF/ymyyqUdrw0mkrtNFYOpPJ1MYPCXVZ5?= =?iso-8859-1?q?81T+taBSHkSH7zhmIkhehlqly7ELXV9OEdakkYtfirCaWJSWTK/Y43LG7mB9?= =?iso-8859-1?q?e+9hOjeIB4lfiNVMG6vr/CRRB2FjJRtjJhYfEfIznEqpv1TZ5sbJViY9dCuI?= =?iso-8859-1?q?8B9tvWsrrygmjj81Ebu9bbAFRnodKqOfIfjYn0+OXT68x0PZolGLhyUxDhxL?= =?iso-8859-1?q?CrZ5QMwdZeQirnpF7pVXIObVARVHsCAPpBUngWQcRyJJfoZg9rDQKl5zdSS3?= =?iso-8859-1?q?tHk03JCgFbBJm3u8jwsMXmM/zpbX45LucF5GBCOqOhQ3vOMsuKZDqe7pcAf7?= =?iso-8859-1?q?hAf/V1mcHphbmlNE0E7cj7KcAomCho8u8w/MIumO+lWfg5gHW+a6/Z4Ia13w?= =?iso-8859-1?q?LDUTshBFpLH9SZGACXMgP6g/XMC1Vj89btp0DAnnCUlkFklwaRugLDDJdh+Z?= =?iso-8859-1?q?ZHbtTTMhvxwAzuzhK0/HvO82JSTobq0bn+WOPrFaEwPOjd3/hjonCBc5tPu5?= =?iso-8859-1?q?LxJIao9eY4AbEhL2B16iBtfYeor8Nv54tarziYgKFYT+SCZL0Q/mjjEpgd86?= =?iso-8859-1?q?H/T1MxZdgtACZoTLhKpRzCVltzCbfJPDpyMrYtUhCIr0V5Xz3vhRDOS6+PpF?= =?iso-8859-1?q?aBJ4RS8nhLYJgmPWWnyUkWFuXgfpLbgfBH+1IX6tbYrrYyexqIa6pysYeXmd?= =?iso-8859-1?q?v32ga8oUc/I6iq4tiP?= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(136003)(346002)(366004)(39860400002)(396003)(199004)(189003)(71190400001)(71200400001)(6436002)(1076003)(36756003)(446003)(44832011)(256004)(14454004)(11346002)(97736004)(2616005)(486006)(99286004)(81166006)(26005)(3846002)(8676002)(106356001)(68736007)(81156014)(305945005)(7736002)(386003)(6116002)(52116002)(6506007)(476003)(102836004)(76176011)(186003)(8936002)(53936002)(4744005)(105586002)(50226002)(5660300002)(86362001)(54906003)(110136005)(4326008)(2906002)(2501003)(66066001)(25786009)(6486002)(316002)(478600001)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB4717;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zL0cr/xmUQdEncIYZsYE7cM6unJqLZrDjw+5i/GtcVpslrH0YDyLCgqHDkT1mhsGVytg+Nfa3A86DU/NbQrnqKey6YTGoItF4oOBeEI9GgbD3qBqfxhMlnNc5SS2NjNtHpEIaD91EdFBpxcT8BNQNFGcmFWhcNKlOV86aDciYY6SW6p75n9pjCJkqh67u+ZmcLH38bGpBwihiWcG0ByLYB+QxPFMuZyq7IEWvtiNXM3T2BSRupLcsXG5dZKD4NKMYazbu4JCwNwksTH6ibZ9o/D8mBLJBnU+Mz17CK2lsigriYzWrbr/8TDIYnyRndkMOcdBRumhbWz3LxmqMFlLS6xFKXIbbjhbd6X9n+x4E2talZkr4NjqCwvP+kHVt0QehiPlgWGlm/EYQf/h0G1a6HJSoTjV5Ylg0UZmgmc0T/A= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8df88c47-1543-4cbe-cb5a-08d69d4f5528 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 07:35:34.6877 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4717 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yangbo Lu This patch is to add quirk for P2020 to ignore data inhibit. Signed-off-by: Yangbo Lu --- drivers/mmc/host/sdhci-pltfm.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index b231c9a..c26b3df 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -83,6 +83,9 @@ static void sdhci_get_compatibility(struct platform_device *pdev) of_device_is_compatible(np, "fsl,t4240-esdhc") || of_device_is_compatible(np, "fsl,mpc8536-esdhc")) host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; + + if (of_device_is_compatible(np, "fsl,p2020-esdhc")) + host->quirks2 |= SDHCI_QUIRK2_IGNORE_DATA_INHIBIT; } #else void sdhci_get_compatibility(struct platform_device *pdev) {}