From patchwork Wed Jun 5 16:00:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13687074 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA8282A1DF for ; Wed, 5 Jun 2024 16:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603238; cv=none; b=EH9Y7yE5l1o/+YRWaiz/B/eEj8hBH9MPVYHI3v79Jyt0W9HrkGTFtvoPNQ6zfAAYwfZxMYeLp53qahW9yNGMJo9zS0/mmAxIuAFhOz0kj93FtcTsI0mRh/bp7XZU4BNowvmGfsPKfEm9pnhRA8JPnIFe+4aUQlffDUrgk7to0Ko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603238; c=relaxed/simple; bh=OkPU434HzNDB9Zy2Ni7fqW6kRWxa+k2mi0HjkFDCNDE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cLiE7w24YtKbo6UXGWTev5TxUWShmqvwS8VVWPKQt2G1/Ytktd0uhSZZkqPhtHc4EVi5giYswFSno8H8EMKzBmB78xc4ozzBLQe3drGC+KN5/p6XD/FCx2ahmTkOB1orJ3kKSE0A6EwiJ7YKlgOe7zhXgMGnC6WsbMHKkmcd7T0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Re92zsZA; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Re92zsZA" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-35dc36b107fso5797903f8f.1 for ; Wed, 05 Jun 2024 09:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717603235; x=1718208035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=50R7nvxQHynUojAseHkwFUtQ6Y11lIc3pU4/cZlSRlU=; b=Re92zsZA+ZacZRkqP48MLQUV4m/+BluWE9wvQCU9ReVP6FdqVgKyF6bs5TEoHt2rLO WxbgSXHI7UrviGdn5dtN186hAgI42ZlX2EVr9CQOr2O/kuHyfvR0YmBthRBfD2qynbZ2 TadQDmwQY/XUCwX7fNtodIWh+tChcEB4hkyYGE7WJScDYKyLxdYHwtAjlFDjA5KbU1jE ctHfGxj6hvjUdwRqCJKzDtgvT1opouu1PDm1mQDNNNcYbcei7RduU59/rfWs77h0J0Bk F2f2TwedxYxL40qmT8Iw5ZsI0sBYjAkZFlVilYeGcQ3+vAylWcj5vx7ThgtIK07YC8Eq zIjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717603235; x=1718208035; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=50R7nvxQHynUojAseHkwFUtQ6Y11lIc3pU4/cZlSRlU=; b=k7l6g9xSKsfNgnpR3/yoQZhdwG28PhgUirsBDW3BGK02+vCBK7ctr/ERm3et+/zwYS OpGx4ghdLhXwfK4XFMOa3bwDQq3cY2pgQw7bp4SlQ8iZeDEDhnWFtd9vfmqGVHfmezlP qItOfyxiNm/0s1GCttg+EzxUu6cha1iWFSlrhjREsJFBt25X/+ci+WZwoqMkXhC3xVSm S4e0ozB+xj2mIlY5+qSXINbrgd+rGdtnwLJlA3zVkBVDG4LBiYqFal2jQvDbtMaE6jm/ nQzkjbxCO4U6maygIDz3nF9mV1ZXJXp03bFu+mbN0Wn5rn3Z145ODCAGhix2+XqMd3Se wkHw== X-Forwarded-Encrypted: i=1; AJvYcCU4H8XqPmLAflZ3nO/q5o0CZXHRcHwknth5zCLNStbRgerxNinb1Fi8FZcxNQ6xtp+NKBwl5ceNMukx//qsxWrXmF81/StoD5O4JJwN8A== X-Gm-Message-State: AOJu0Yw3Ts3ktN6mBIz88BsoZuN2yQGVieDh0FJ+EOglbzPRnCaV1AIH nRQGxzHKvN8TUMZErhc1nuN0ENYjv15/+6cV3zkpCRISNP2pTaEU/WlGygyhPhzVwNV2WQtrzed 6cIQ= X-Google-Smtp-Source: AGHT+IHRPeQqL0o1tDhRPns//LIK3Qj9qE56wtDCYLQoQAn7bt3M2TI9iVXx5am/KB0iHE9ARvPEdg== X-Received: by 2002:adf:e9ce:0:b0:35d:cf2b:9106 with SMTP id ffacd0b85a97d-35e84070ea5mr2075681f8f.26.1717603234938; Wed, 05 Jun 2024 09:00:34 -0700 (PDT) Received: from krzk-bin.. ([110.93.11.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158149008sm26288975e9.29.2024.06.05.09.00.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 09:00:34 -0700 (PDT) From: Krzysztof Kozlowski To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags Date: Wed, 5 Jun 2024 18:00:29 +0200 Message-ID: <20240605160032.150587-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Interrupt flags 0x2008 looks like some downstream copy-paste, because generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to pass just 0x8, so IRQ_TYPE_LEVEL_LOW. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts index 88ee04973a2f..bf23033a294e 100644 --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts @@ -293,7 +293,7 @@ touchscreen@48 { compatible = "samsung,s6sy761"; reg = <0x48>; interrupt-parent = <&tlmm>; - interrupts = <22 0x2008>; + interrupts = <22 IRQ_TYPE_LEVEL_LOW>; vdd-supply = <&pm6350_l11>; avdd-supply = <&touch_en_vreg>; From patchwork Wed Jun 5 16:00:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13687075 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 183C014D2BA for ; Wed, 5 Jun 2024 16:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603239; cv=none; b=EqKItvIPOPyJZvw6sCCMSjbYC2YB/auonw4SIVPAxJfednPTMtJ7G+AyY0pMmgEItR9NRdoSOuPJJagwxdK/GkglZ3YYqCzAsoOCBTMHvgLYX53yzSiA4aTkD0gFZ2SpweaTxNV3oidosocdRMBPP0iGeTKUJ+EbhMTKnFxG6Ps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603239; c=relaxed/simple; bh=12bFuyfQmZkG2+ABZgn1M3sWSqD4zUCpfiSL6irZiP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kqoKkJjI/xBg07p/qlTw8nxyMIlCrHuHZTFresdnycsbfnxl8D9qVJqN8TySlrAdExSIE4VCquZgrWKhS+C8Jm3N5dKCohXTiddXkFN14vw/2gNr0WLWtBMBMsfBSgR7gGDFrcn2LvXl8PG5lAI80TeAe8mgGpRjXIxbkE7MNXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R4+8aFlk; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R4+8aFlk" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2eaafda3b90so45104881fa.0 for ; Wed, 05 Jun 2024 09:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717603236; x=1718208036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YltyCfpqGq9K4vgpOoXiIRu9gocX/A/8INFDzAUTBvE=; b=R4+8aFlkmcotYa6C50IGVR1B/Qc/nedDya31sneKaKzlmPR63CCez9QkXlKThrP4qG S5bgBUBR3VthQfEDvMLeFxWQOuAEx0EdJ9I+5dSEkzxlQJAV2GO7unpAKA3b1vjf5MZW GmPqMxjmCZm1SRnl00vujiRNnHgSUgxS3fsuOnN2bRCxrc8rFTmPXg98DnW/j857+peG ZEtcpWTL3Ei7L7WBt6uWQEnahe5Kopp5VHRlyvlt1hRjGBWBrb1EOTXq8aYRVVcsjBOX rf6f9fwwXt43UmHUYx7rWBWx3XewYx6p85V9aijXc/DXyKHP3/RKnZxKaFVfPrLSdcS3 i/iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717603236; x=1718208036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YltyCfpqGq9K4vgpOoXiIRu9gocX/A/8INFDzAUTBvE=; b=P05+Pxgf0EB3lHyCcNGw928Ycdtg4Qo4cJ4qgTaH2Y1noU7K/gLWwfOxexoUlD/eoJ Xb+LAc8pjUZtvJbxVOoTec1TDBrjNT+hqZ+Mz1wK588jRXDW+EhDjnW0XQ+e0mxkfhoT LqcsVd6dL9SE4ivrJk6SzWzkWSBpm5QlNrQH/Iv6erSkysjAgU2s2YMiyTpvP1+8DIdV qP3k63pRCwx1gh1z1yEIk6tdMPmzeLNXyo/VbhUvNTppQAtCKBr03QJLP10xKFJ0KKRF 48q1/0gGjg7kHtJcH1ulONT/6QRLC1xJDtjaOzwAsv+R5YHPMtaSTTAdS2mHu6QmBUIh F2Dg== X-Forwarded-Encrypted: i=1; AJvYcCV2Q1VNi0bKWg5XhIp8yfy976MaV5EB4qeuiJSmMdXMVJKqFJHD7RmXxoj/1L4q/6AoVmzxDBllTMu24Uq4rlcvppV+RmG99YJNxB0SvQ== X-Gm-Message-State: AOJu0YwICzXtBQrMuX9W3D5FNZpzUnGqFseKk3kxNy/tSNKEH1OIMmkg u8xOPA1MdkjLSXHcLRfANeGpM9FMjdyfMvne0Nf0f6B5/3HiHTqIN7E8qwuM2kg= X-Google-Smtp-Source: AGHT+IG5Lq9r/oAx2U0p6tuN3FiovhSi08tfRV/kQ2k0CM090ddtl0UB3GCSew47eTZVVo9U0UHFQg== X-Received: by 2002:a2e:9ac6:0:b0:2de:74b1:6007 with SMTP id 38308e7fff4ca-2eac7a72de1mr19292741fa.36.1717603236164; Wed, 05 Jun 2024 09:00:36 -0700 (PDT) Received: from krzk-bin.. ([110.93.11.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158149008sm26288975e9.29.2024.06.05.09.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 09:00:35 -0700 (PDT) From: Krzysztof Kozlowski To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 2/4] arm64: dts: qcom: sm6375-pdx225: correct touchscreen interrupt flags Date: Wed, 5 Jun 2024 18:00:30 +0200 Message-ID: <20240605160032.150587-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240605160032.150587-1-krzysztof.kozlowski@linaro.org> References: <20240605160032.150587-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Interrupt flags 0x2008 looks like some downstream copy-paste, because generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to pass just 0x8, so IRQ_TYPE_LEVEL_LOW. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts index cca2c2eb88ad..e04a3b8f81c5 100644 --- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts +++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts @@ -142,7 +142,7 @@ touchscreen@48 { compatible = "samsung,s6sy761"; reg = <0x48>; interrupt-parent = <&tlmm>; - interrupts = <22 0x2008>; + interrupts = <22 IRQ_TYPE_LEVEL_LOW>; vdd-supply = <&pm6125_l13>; avdd-supply = <&touch_avdd>; From patchwork Wed Jun 5 16:00:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13687076 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F52154457 for ; Wed, 5 Jun 2024 16:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603240; cv=none; b=PgSuqnkt75cucbtG6KtV39uN/WsiqU40ZotksUaSGe2+H6ETrSxJqo5DU7MBrVYZecNeT1Fat84+MMI7J/uPGNkF9QHSnsrCEZeciTFwsWe2LEeTE+5xtrc7Ft7kIyhg+2uTwJ8q+Pz7tSGsqI3N3M9GvXMKWV40z9BYvEH2hdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603240; c=relaxed/simple; bh=c/2SKyVNxmDDEy4jtRH3u8SNLIlWuUpwBcMP/asBnSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vcy7SJ5MigfGC0sdo31g1swu8qz/tAaBYzvfm3W8+Fl8Us+7EsFTytiUqhBfuZSlc2w2NlAP/Qr0Kc6opj3ySu1RXxnfGIDxzwZqRC4xRp+tBmn+U147Ft3wEjNKqw8fdErlFMCZGj6YJyX+DRb0F+c6yrOOczENydHklieazm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g1bsUUuq; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g1bsUUuq" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2eab0bc74cdso673291fa.3 for ; Wed, 05 Jun 2024 09:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717603237; x=1718208037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IS6pzXJDK9QslMNjlWCKMW5GnNTj+YYAKSrFzSpQVwY=; b=g1bsUUuqpOhBWPzE30Jlh8lVWsdDyfdJY9Zy/kdq7kxcJGyIEvui0SkornbDUdFHuU v860oTepOZF+3k66EHZkN1kjyjMBD3OHAFzzNMcvguX2xk2FvGP8snzs7dwC/qBUq+oB QAMihJOTASDfELqPsMz1KbL+H3aXVosYUOyiz9VrmZeMj/CxdtctSP9qQ6Bc4XRPXGFa jes4uM/hQQKYXmW0k23usyfCmwUTcMl2aSuHqsk7d05FG7Khp5pci+nm3zsMaga+r6yo rhl4cbpa3yWm7wbFOxFGkyV8jKSx9M5MJUYTJzblb0gFLIL7lpCWJIoILZ4r/n75iwI8 wAZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717603237; x=1718208037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IS6pzXJDK9QslMNjlWCKMW5GnNTj+YYAKSrFzSpQVwY=; b=FRn1oZDbZtnakA/MK79I0yTU4fTYpxBrtTLa6/7k6dExVVDEedq/lLlxKHZM+w/SEC 8JiF0mWfZ4weC4fqhAgkEq+9xJE83UKFR6HkwILzBMM29LPQRnYjZ7p0NcraTgQt2/v/ 6cB6+kvZrK09XIwK8/baaWy3sx/Gb1wKqK1r1/zpXHBEY/sWvDSVu8Ezrs5a69wSFZzJ TyG6a2RYwgKD+YseI4secyW0nKT/xhujAMi14CGdHw/s+WfeFYszVfBWpN5RvgVnefu2 zlMXhcj1PUpNmVyFqZIVKGEGeXZkPtBLnDXv0D1tTTNEdXB9av3BcsEoYXEipNQuYMwJ 3aOA== X-Forwarded-Encrypted: i=1; AJvYcCVr/Cn+tne4TQJIp8X4CQ34rz1hbLRp0Wl8GocQ4d8onXVEuoH+JXiM5THjJ+31wVl+2SeTBviayzYbvv6NGDzv/KltRp+G9jaB++SwwA== X-Gm-Message-State: AOJu0Yz0eU3IcwBwY9JKeCrqSt32MB7p057s/D5GMcX5NHb9FAAtkk3C 6BW+U7g59SxlI/w9+HRT4l+FtVYNVvJgec3oSGJ14O+MKcnQO6S6revYB39ezZU= X-Google-Smtp-Source: AGHT+IFVQ6EuFCOacFNDp/dYjlatng7UYWk7LSo2A1ZJyk2RuDDqs7BYNK1FQL5VNFszGvVvaRqBWQ== X-Received: by 2002:a05:651c:119a:b0:2e9:6265:9926 with SMTP id 38308e7fff4ca-2eac7a9a366mr14411021fa.49.1717603237432; Wed, 05 Jun 2024 09:00:37 -0700 (PDT) Received: from krzk-bin.. ([110.93.11.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158149008sm26288975e9.29.2024.06.05.09.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 09:00:36 -0700 (PDT) From: Krzysztof Kozlowski To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 3/4] arm64: dts: qcom: sm8250-sony-xperia: correct touchscreen interrupt flags Date: Wed, 5 Jun 2024 18:00:31 +0200 Message-ID: <20240605160032.150587-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240605160032.150587-1-krzysztof.kozlowski@linaro.org> References: <20240605160032.150587-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Interrupt flags 0x2008 looks like some downstream copy-paste, because generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to pass just 0x8, so IRQ_TYPE_LEVEL_LOW. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi index e07d0311ecb5..f6870d3f2886 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi @@ -520,7 +520,7 @@ touchscreen@48 { compatible = "samsung,s6sy761"; reg = <0x48>; interrupt-parent = <&tlmm>; - interrupts = <39 0x2008>; + interrupts = <39 IRQ_TYPE_LEVEL_LOW>; /* It's "vddio" downstream but it works anyway! */ vdd-supply = <&vreg_l1c_1p8>; avdd-supply = <&vreg_l10c_3p3>; From patchwork Wed Jun 5 16:00:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13687077 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3736D15EFDC for ; Wed, 5 Jun 2024 16:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603241; cv=none; b=B8k/VtDa9B9ajWtK76NogURCI+wjk+5s26T0gaCAJzs3Ewuqb+0ZV4M7atsWqglb8CghyEIJCkcxAT8luS7TUejiypDjoVASr18cQRPIyfxBUn92W9xehTwtB/DvouvheDzuwoG+BwYzSfttg0NV7Sy2yQNA7EBDe3ArlaJiH6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603241; c=relaxed/simple; bh=Z3V5mVxSUuFg+9G2PnTNBZMP9LTIe4c+pzhdPjpkFDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WMPiCX8VaUu75QfCqTaQ5f2PDfe9SHRZpTBywkG+GABfEqQ1NwBpJkddY0hmAJp/Zyfrb+nirU6A5/jjtGRKqUzcJf5WdpvVZ3NL/bzWqcBnhWYQsUH2GEWg5xLmlp3cMmEuacEsQX2cM5M3Oc/QNKj5iQqnp18QLVtvFc/ZiVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PAAL3aNw; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PAAL3aNw" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-35e83828738so165296f8f.1 for ; Wed, 05 Jun 2024 09:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717603238; x=1718208038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b6JpAglsaN0d79pvWFu/cyEHqqzh04VnENEg9cgtePs=; b=PAAL3aNwKJA3V9dDknjtUGtMAtC5yRRzuwwVbQSyqtftJlf1o0MQcLgjo1o0slDB/7 dI5xnqkeXrgob2Yp/tsXZa0C73UsvLin1YmKAHBelwKEBIfsK4MWg01gY5RKbfGJMjyI KfdqlHQmD7tegaqgWUCekwFQdlKZqeDHKh8VBiJgFNtNQsyIVd6IFAlMAOksnTEgpJY/ D1hDb3LK92CcZ43D7iGsKImPem9r5fOhSQ2mWVHGEbmODH7cB0RNEcejSNSk1NfO2mQo YtK6oWv/ugS1kkUZkLFHMGse7sy/chrUC9dvW98Daesk4f5wgBytj4VBCjIQUdM3AJAk hvgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717603238; x=1718208038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b6JpAglsaN0d79pvWFu/cyEHqqzh04VnENEg9cgtePs=; b=CcZbiZebLBs7qU4eRYcimc8PgGCtXYSxlKa5fXZuA/G+706S0LRDvxhrpo9CAvHi+H oA7T3ZREBPo1/DxrYnkY0x97h9x5Pw52KInon++oZRXMzSWYxdWLTOr5rOIl8zyhxSAB sdMgBkECjm7Huy4M+JxztwmImAXcgFqRQ+tc2YXsyR8nGjjUH4hMtAJXnPB83hWTV0Wk fzph4SzBsWW3nnRj9sKYsMItTcF0gvcpnooGoJzheyBRs+rT9FRd6gsvnbaRMP7ZTIYg IbfzoEk67pIzBD++vYsvETO8YDMIaGsiERcUqqk93ABVeTjcx79WTvBFr5WmqwLxcEmr Tyfw== X-Forwarded-Encrypted: i=1; AJvYcCUrQiJynEd2G4Da7JmjteDU3AzVN55Ez0BpuDIDULzmIsgpbRnQRH+ZI8J+98dvK/2iI32vDlsH9lScSrWepoKIc7Y72pIA/jFw1KIiCw== X-Gm-Message-State: AOJu0Yyqs/roXAuQNA8/9OwUGQbMMg7MEv9FixxTo45J3Nz8guFZTkZc GDSCRGoEKAkAAjQEgZM6OVFZkW3hal7zRqMpcKASqh5tYWJcPE6MkIJ/07FtGmI= X-Google-Smtp-Source: AGHT+IEdlXjBLFrGlceUU70bhxiydsRr4mkLa/WCqSg9ALFtiEoD+j/ZCMSrb7yCq/alxDLwLjn5yw== X-Received: by 2002:adf:ab18:0:b0:35e:7ddf:768a with SMTP id ffacd0b85a97d-35e8833a1b2mr1973579f8f.36.1717603238620; Wed, 05 Jun 2024 09:00:38 -0700 (PDT) Received: from krzk-bin.. ([110.93.11.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158149008sm26288975e9.29.2024.06.05.09.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 09:00:38 -0700 (PDT) From: Krzysztof Kozlowski To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH RFT 4/4] arm64: dts: qcom: sm8450-sony-xperia: correct touchscreen interrupt flags Date: Wed, 5 Jun 2024 18:00:32 +0200 Message-ID: <20240605160032.150587-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240605160032.150587-1-krzysztof.kozlowski@linaro.org> References: <20240605160032.150587-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Interrupt flags 0x2008 looks like some downstream copy-paste, because generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to pass just 0x8, so IRQ_TYPE_LEVEL_LOW. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio Tested-by: Konrad Dybcio # SM8450 PDX223 --- arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi index 8b29fcf483a3..17dbb67868ae 100644 --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi @@ -488,7 +488,7 @@ touchscreen@48 { compatible = "samsung,s6sy761"; reg = <0x48>; interrupt-parent = <&tlmm>; - interrupts = <21 0x2008>; + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; vdd-supply = <&pm8350c_l2>; avdd-supply = <&pm8350c_l3>;