From patchwork Thu Jun 6 13:10:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 13688453 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FEB113A86B for ; Thu, 6 Jun 2024 13:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679431; cv=none; b=l6jHe/H2IQg22yfbp6zS14pFGsA9T/eD4QaBGZve3MKDxQqwZvlsT/gJotOCMYMsySs4+RR6BNQnvpHdbNuCDU2T6dFU8jsl9P2ULWN1Lz+URSMLyIhh7mWzas3ieNsYk+uNv5QIkosSDdJLFg8oXcJgpVqRB+O+gPMT9HjBgG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717679431; c=relaxed/simple; bh=zT88eZfNNd+RiyI4o59iAJCPJIAf8oivhPTjWxX35MQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=jOs3U3gPItnU0CMfoK8gAtAOw9F3pTxeCuFw4yRGDmAtL+QqOmhX/jVK8ckkZ6Ok5c01ULabvrwFAuUDSEl41IofCg5prZiSwARA88FnUPAh6OPgffINWLGoL5FhoWejda2G3YGT4OXAzfm08Fu2PfSWIrpv//LYNgXizbhv4hI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fDx1Lh6r; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fDx1Lh6r" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a68ca4d6545so173154366b.0 for ; Thu, 06 Jun 2024 06:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717679428; x=1718284228; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=LLTo6IN//CUfT633Q+EgtwxBk4Zhgr8yvAaTHaRrJKc=; b=fDx1Lh6rX1LDP8w/JsHdvLHz6V6cyvu0Vc8B/sXq4YtcwW1DmqkH+afCojavFduOcZ W/iz5jps5OsEzdRzyqWum3X1ZH2mcBRUS8rhCi2WXEb3qhKOvY2hcu3JIXz0pEEJ8Wpa IFT3ASthAA3NgddTEw5N+hLmRycL/jwcPCoKTzD2JjR9HdXMEmBywKEV2WC2kNrMeMUJ kqCUS3sxhg0mG+dkjghTfr51mJdZuN8a5YmSxnqkyZnTSYfIy7Ybs6XQWmSmTQ3be1Dl Iz/l2+dm/W2xjGTI/gWFY9djaSSlciEJ2JGHp0rCK5mDJfJwAeqSoOPGOPePQKsx7330 yAKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679428; x=1718284228; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LLTo6IN//CUfT633Q+EgtwxBk4Zhgr8yvAaTHaRrJKc=; b=tdrZ2/WB5brEekYpyzORfl4lavmXSc1Fd/xIzNh5yf62Z7peGln+j16Wb8RJ9QwQO9 Ts3lqHpLZ1/AajSduaI7YCwTtWRCOniGjc5VLr0wCW1EdD62gb21HejmwAIHpmwmBQVV ovtVIv8Q24w83HXjdWBj1tCFKTXrNoF8Tt57DxTpDPxudxaCcMTDqYAhHFE947LPQX5i Kors9SlPK41rST4LLXplQQl1vIy+j0GAyo2Nw1Y/nSa3FeK6EzY380UPskT0xXLish3v b/tpH/Cm9L6wkb/AAP+9FFbcVUFwT1Oaw+kK64sVLhlgIvKfE20kKGqT7yPy5MLydIEo JLfw== X-Forwarded-Encrypted: i=1; AJvYcCUvZv0M0lW7mtFNJcLKSTEZsnJpLZMLhzTPrC4u64KCirmrVeU+qk5Q2tMEbmkFVbK+6HlkwfEfWNU1K5p3UegkwMIGTgl6kckK3nU= X-Gm-Message-State: AOJu0YwtY/7c8lcBtI0/q7F/am0FTqyeIQNWU0jv8KvTGN4Ryb2DtMIj DsInQeeczHozabVq23/qW7T4E6Pd9mlXS3mzOvn4/+ERbGvtz1XvZszRcWxNzEw= X-Google-Smtp-Source: AGHT+IE/O3Z7xTXrhanwtiiAy00RvXG9RUOoWD1wIob6c3DU4S0+HjI1sOf6DL7JHERx+RQuhoT5dg== X-Received: by 2002:a17:906:e218:b0:a68:a476:6957 with SMTP id a640c23a62f3a-a6c7650a2ffmr216652566b.24.1717679428406; Thu, 06 Jun 2024 06:10:28 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c8070e82esm94963466b.161.2024.06.06.06.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 06:10:27 -0700 (PDT) Date: Thu, 6 Jun 2024 16:10:23 +0300 From: Dan Carpenter To: Patrick Gansterer Cc: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] backlight: lm3509_bl: Fix NULL vs IS_ERR() check in register() function Message-ID: <187b5bc5-a010-46c2-8ead-980df9efae79@moroto.mountain> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding The devm_backlight_device_register() doesn't return NULL, it returns error pointers. Update the error checking to match. Fixes: b72755f5b577 ("backlight: Add new lm3509 backlight driver") Signed-off-by: Dan Carpenter Reviewed-by: Daniel Thompson --- drivers/video/backlight/lm3509_bl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/lm3509_bl.c b/drivers/video/backlight/lm3509_bl.c index ab57f79ffe23..c93cdedff5ad 100644 --- a/drivers/video/backlight/lm3509_bl.c +++ b/drivers/video/backlight/lm3509_bl.c @@ -114,9 +114,10 @@ lm3509_backlight_register(struct device *dev, const char *name_suffix, } bd = devm_backlight_device_register(dev, label, dev, data, ops, &props); - if (bd) - backlight_update_status(bd); + if (IS_ERR(bd)) + return bd; + backlight_update_status(bd); return bd; }