From patchwork Thu Jun 13 00:34:36 2024
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Steven Rostedt <rostedt@goodmis.org>
X-Patchwork-Id: 13695707
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 55E86C27C53
	for <linux-mm@archiver.kernel.org>; Thu, 13 Jun 2024 00:35:02 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id CFD4F6B009B; Wed, 12 Jun 2024 20:35:01 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id C5F666B009D; Wed, 12 Jun 2024 20:35:01 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id B00126B009E; Wed, 12 Jun 2024 20:35:01 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com
 [216.40.44.16])
	by kanga.kvack.org (Postfix) with ESMTP id 9293A6B009B
	for <linux-mm@kvack.org>; Wed, 12 Jun 2024 20:35:01 -0400 (EDT)
Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1])
	by unirelay10.hostedemail.com (Postfix) with ESMTP id 376D6C046B
	for <linux-mm@kvack.org>; Thu, 13 Jun 2024 00:35:01 +0000 (UTC)
X-FDA: 82223995602.19.9F888CB
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
	by imf27.hostedemail.com (Postfix) with ESMTP id 03A5640011
	for <linux-mm@kvack.org>; Thu, 13 Jun 2024 00:34:58 +0000 (UTC)
Authentication-Results: imf27.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=pass (imf27.hostedemail.com: domain of
 "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as
 permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org"
ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718238898; a=rsa-sha256;
	cv=none;
	b=yZtArjUNSeZ+9HWY7qNpCrsq6B18wL+A0uW+aRjEwtAbThiIl2hJ2FiyXUBEE0QAvkZ/cY
	1rWEoyN1jdF2JLVFbOrLbKJ3iEx8bq8PKgGBvUBPTjKerhQDh1eI0ubmuKAZp2cOXdUKvV
	vkJ2ur9NRsAOzBQJqcCU6KCS4wTllJs=
ARC-Authentication-Results: i=1;
	imf27.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=pass (imf27.hostedemail.com: domain of
 "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as
 permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
 d=hostedemail.com;
	s=arc-20220608; t=1718238898;
	h=from:from:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:content-transfer-encoding:in-reply-to:
	 references:references; bh=QzN3YGRkVyxpLqEbfzy/POyX0V7EbVZAm324ZBlI6DY=;
	b=GE2M+EtKsKKHgkUVIcvGcdvd+tbQIYZL9rhujocAtMHX3A4+9oP32dyjZpo3jjudWPL+QA
	J7stff+vZpelItU9V5dV52Flu+QCYPcZK8jmypadADKOevNfn/GpfqH0tP4vGNLmovuf1F
	Aok0M8CPlT8RtvEogevAKLdMT4WvQXQ=
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
	by sin.source.kernel.org (Postfix) with ESMTP id EA36CCE2408;
	Thu, 13 Jun 2024 00:34:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95BCCC32786;
	Thu, 13 Jun 2024 00:34:52 +0000 (UTC)
Received: from rostedt by gandalf with local (Exim 4.97)
	(envelope-from <rostedt@goodmis.org>)
	id 1sHYQm-00000001eN3-3lZi;
	Wed, 12 Jun 2024 20:35:08 -0400
Message-ID: <20240613003508.752963299@goodmis.org>
User-Agent: quilt/0.68
Date: Wed, 12 Jun 2024 20:34:36 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "Liam R. Howlett" <Liam.Howlett@oracle.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 Lorenzo Stoakes <lstoakes@gmail.com>,
 linux-mm@kvack.org,
 Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org,
 "H. Peter Anvin" <hpa@zytor.com>,
 Peter Zijlstra <peterz@infradead.org>,
 Kees Cook <keescook@chromium.org>,
 Tony Luck <tony.luck@intel.com>,
 "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
 linux-hardening@vger.kernel.org,
 Guenter Roeck <linux@roeck-us.net>,
 Ross Zwisler <zwisler@google.com>,
 wklin@google.com,
 Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
 Joel Fernandes <joel@joelfernandes.org>,
 Suleiman Souhlal <suleiman@google.com>,
 Linus Torvalds <torvalds@linuxfoundation.org>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>,
 Ard Biesheuvel <ardb@kernel.org>,
 Mike Rapoport <rppt@kernel.org>
Subject: [PATCH v5 1/2] mm/memblock: Add "reserve_mem" to reserved named
 memory at boot up
References: <20240613003435.401549779@goodmis.org>
MIME-Version: 1.0
X-Rspamd-Queue-Id: 03A5640011
X-Rspam-User: 
X-Rspamd-Server: rspam05
X-Stat-Signature: ksub1eijexba9n4skqomsgkd54rnah6p
X-HE-Tag: 1718238898-628184
X-HE-Meta: 
 U2FsdGVkX19j0HosC2Z45M7BSh5d8B6gw6r99D+4GqvFs9WMoPU3jSObFb+t3j7x9I2X9Ujk9nAXIGcbpYe9JREb1c0nt8x8fjzqKgj1QGna23Hd5F4B2jK1VvZGI9MnCjqh4uSHCzG4TWNDLUF/WvTCA778agiuyJEUFOdSoYcS/FWeHO/QkavfTrjtLdH7ncsuavOERT9veS2IBNhTQmhuzFEsPXOF38neTTejGOv+TLq5Zh/Sp8lfc1CwT6bq/8aYHkpfporvXFXxrJyQ5vW+s6HurJbrQAZlf2ZZhNKpTsQBKu8ticab1LW75+fBIUd6Uiz2Asnskn0nmVUxPWmbGqfIRabgCqEKv6FObQV8pa+f3GxkaLOfGgtKaR4ZvivPDG4Eh1cujU35/AOTadR02RLXlliOPt1fT3wwJzJyNgq+skO9ZxIfsfCINOxpkC5cFEVoZt9l3IX2hi18+g7CAwlPPY5uFzsib6YeZDKXRrdXfJ9N8ERo4sAmzPtX3/qDsnTUlYS4b4vSQ8+u+CLQe57pSFxyLCBTUwJnsJw8UZy5rr29lJdwKcgM6ilio/lMqDm0ieDHzNzm865atdWMd6qMSSFVqfXPXLut0HSoavaQ5w6ae1TVe/FseAAx76EgAApAAYvEIUc3DTVoPa4flrCR2NGqPYpqQVEI69dRygeLVUUp6tmPl5H+1DhSIqKamfxsmLlylQPXXBd5FZriX+P0FIufQsZpf3dtsBB0O9dkTAopOcOkGY8YP1evhGVfmY79eFKtPuYJX/NX1ItXlQOY55+E9bMcr9Z9rxpgBy1OO+ZC8vQlQTnGnUxlPHPt4jlVL1QG5TgPbEuN4jM5ldnK3QUb1XFVkZ3XpK7CfAm1dPFVlBCNcqfgOm5kyKSt1lg8J4Vul0HuAyh240sk4zX14dksnQ3IeCPtdC5dqIJLkl8gtRZmfLugIDRCOLhJGte4yUt/tcA4Dq7
 M/97rfJN
 vwvtSBNzb+zmDK6CEJ8w6ebhegW2GYQdP3gKbA9/xuxJKCa5QUogPsg72jfGQXy7RPfeXzBe+watvZwm5jWj0HkwOXPObJBeK3Lvy3goC/EYgqC+SrNQqcVvRKCIbJm0jxJfN8Lu6lXBydNLVyduOZM2UBx8V66GdOtdtQMXOVU11hLKTBVL2pB788NiW121XnY7AOz+vwwGAVWewwIR27uFh86+VbSrtxrU/CQaCEafYSaQ3vnnX5ktB0qzB7vv59WyHh8J0WeBgPyx9/vBf4ehEYfOUpOMALoraKsgHV+9OWg52/FpgyjrwHAiA6x96profTjd5ZkfoSDpf6UUQf3rDvXsor8g3pugpWfae8zZEO+cdYhF0D5XzGTWv5UW5hddk4UY9apjRjv9cJnZu45KlcQ77p3A8eQPQWGSl78itWbicNq+FJS/C9zJiUIjgWe48sSU3dqPfQVemFN0TjZ4ApfylwRZP08CXUnRPdhDFgk+7z9wqN3Jth5UyxWVGjjS5P2kEST+gUJ0=
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>
List-Subscribe: <mailto:majordomo@kvack.org>
List-Unsubscribe: <mailto:majordomo@kvack.org>

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

In order to allow for requesting a memory region that can be used for
things like pstore on multiple machines where the memory layout is not the
same, add a new option to the kernel command line called "reserve_mem".

The format is:  reserve_mem=nn:align:name

Where it will find nn amount of memory at the given alignment of align.
The name field is to allow another subsystem to retrieve where the memory
was found. For example:

  reserve_mem=12M:4096:oops ramoops.mem_name=oops

Where ramoops.mem_name will tell ramoops that memory was reserved for it
via the reserve_mem option and it can find it by calling:

  if (reserve_mem_find_by_name("oops", &start, &size)) {
	// start holds the start address and size holds the size given

This is typically used for systems that do not wipe the RAM, and this
command line will try to reserve the same physical memory on soft reboots.
Note, it is not guaranteed to be the same location. For example, if KASLR
places the kernel at the location of where the RAM reservation was from a
previous boot, the new reservation will be at a different location.  Any
subsystem using this feature must add a way to verify that the contents of
the physical memory is from a previous boot, as there may be cases where
the memory will not be located at the same location.

Not all systems may work either. There could be bit flips if the reboot
goes through the BIOS. Using kexec to reboot the machine is likely to
have better results in such cases.

Link: https://lore.kernel.org/all/ZjJVnZUX3NZiGW6q@kernel.org/

Suggested-by: Mike Rapoport <rppt@kernel.org>
Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Changes since v4: https://lore.kernel.org/linux-trace-kernel/20240611215801.443593152@goodmis.org

- Add all checks about reserve_mem before allocation.
  This means reserved_mem_add() is now a void function.

- Check for name duplications.

- Fix compare of align to SMP_CACHE_BYTES ("<" instead of "<=")

 .../admin-guide/kernel-parameters.txt         |  20 +++
 include/linux/mm.h                            |   2 +
 mm/memblock.c                                 | 117 ++++++++++++++++++
 3 files changed, 139 insertions(+)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index b600df82669d..ce7de8136f2f 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -5710,6 +5710,26 @@
 			them.  If <base> is less than 0x10000, the region
 			is assumed to be I/O ports; otherwise it is memory.
 
+	reserve_mem=	[RAM]
+			Format: nn[KNG]:<align>:<label>
+			Reserve physical memory and label it with a name that
+			other subsystems can use to access it. This is typically
+			used for systems that do not wipe the RAM, and this command
+			line will try to reserve the same physical memory on
+			soft reboots. Note, it is not guaranteed to be the same
+			location. For example, if KASLR places the kernel at the
+			location of where the RAM reservation was from a previous
+			boot, the new reservation will be at a different location.
+			Any subsystem using this feature must add a way to verify
+			that the contents of the physical memory is from a previous
+			boot, as there may be cases where the memory will not be
+			located at the same location.
+
+			The format is size:align:label for example, to request
+			12 megabytes of 4096 alignment for ramoops:
+
+			reserve_mem=12M:4096:oops ramoops.mem_name=oops
+
 	reservetop=	[X86-32,EARLY]
 			Format: nn[KMG]
 			Reserves a hole at the top of the kernel virtual
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 9849dfda44d4..077fb589b88a 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -4263,4 +4263,6 @@ static inline bool pfn_is_unaccepted_memory(unsigned long pfn)
 void vma_pgtable_walk_begin(struct vm_area_struct *vma);
 void vma_pgtable_walk_end(struct vm_area_struct *vma);
 
+int reserve_mem_find_by_name(const char *name, phys_addr_t *start, phys_addr_t *size);
+
 #endif /* _LINUX_MM_H */
diff --git a/mm/memblock.c b/mm/memblock.c
index d09136e040d3..739d106a9165 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -2244,6 +2244,123 @@ void __init memblock_free_all(void)
 	totalram_pages_add(pages);
 }
 
+/* Keep a table to reserve named memory */
+#define RESERVE_MEM_MAX_ENTRIES		8
+#define RESERVE_MEM_NAME_SIZE		16
+struct reserve_mem_table {
+	char			name[RESERVE_MEM_NAME_SIZE];
+	phys_addr_t		start;
+	phys_addr_t		size;
+};
+static struct reserve_mem_table reserved_mem_table[RESERVE_MEM_MAX_ENTRIES];
+static int reserved_mem_count;
+
+/* Add wildcard region with a lookup name */
+static void __init reserved_mem_add(phys_addr_t start, phys_addr_t size,
+				   const char *name)
+{
+	struct reserve_mem_table *map;
+
+	map = &reserved_mem_table[reserved_mem_count++];
+	map->start = start;
+	map->size = size;
+	strscpy(map->name, name);
+}
+
+/**
+ * reserve_mem_find_by_name - Find reserved memory region with a given name
+ * @name: The name that is attached to a reserved memory region
+ * @start: If found, holds the start address
+ * @size: If found, holds the size of the address.
+ *
+ * @start and @size are only updated if @name is found.
+ *
+ * Returns: 1 if found or 0 if not found.
+ */
+int reserve_mem_find_by_name(const char *name, phys_addr_t *start, phys_addr_t *size)
+{
+	struct reserve_mem_table *map;
+	int i;
+
+	for (i = 0; i < reserved_mem_count; i++) {
+		map = &reserved_mem_table[i];
+		if (!map->size)
+			continue;
+		if (strcmp(name, map->name) == 0) {
+			*start = map->start;
+			*size = map->size;
+			return 1;
+		}
+	}
+	return 0;
+}
+EXPORT_SYMBOL_GPL(reserve_mem_find_by_name);
+
+/*
+ * Parse reserve_mem=nn:align:name
+ */
+static int __init reserve_mem(char *p)
+{
+	phys_addr_t start, size, align;
+	char *name;
+	char *oldp;
+	int len;
+
+	if (!p)
+		return -EINVAL;
+
+	/* Check if there's room for more reserved memory */
+	if (reserved_mem_count >= RESERVE_MEM_MAX_ENTRIES)
+		return -EBUSY;
+
+	oldp = p;
+	size = memparse(p, &p);
+	if (!size || p == oldp)
+		return -EINVAL;
+
+	if (*p != ':')
+		return -EINVAL;
+
+	align = memparse(p+1, &p);
+	if (*p != ':')
+		return -EINVAL;
+
+	/*
+	 * memblock_phys_alloc() doesn't like a zero size align,
+	 * but it is OK for this command to have it.
+	 */
+	if (align < SMP_CACHE_BYTES)
+		align = SMP_CACHE_BYTES;
+
+	name = p + 1;
+	len = strlen(name);
+
+	/* name needs to have length but not too big */
+	if (!len || len >= RESERVE_MEM_NAME_SIZE)
+		return -EINVAL;
+
+	/* Make sure that name has text */
+	for (p = name; *p; p++) {
+		if (!isspace(*p))
+			break;
+	}
+	if (!*p)
+		return -EINVAL;
+
+	/* Make sure the name is not already used (size is only updated if found) */
+	if (reserve_mem_find_by_name(name, &start, &size))
+		return -EBUSY;
+
+	start = memblock_phys_alloc(size, align);
+	if (!start)
+		return -ENOMEM;
+
+	reserved_mem_add(start, size, name);
+
+	return 0;
+}
+__setup("reserve_mem=", reserve_mem);
+
 #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_ARCH_KEEP_MEMBLOCK)
 static const char * const flagname[] = {
 	[ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG",

From patchwork Thu Jun 13 00:34:37 2024
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Steven Rostedt <rostedt@goodmis.org>
X-Patchwork-Id: 13695706
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BBD29C27C77
	for <linux-mm@archiver.kernel.org>; Thu, 13 Jun 2024 00:34:58 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id 72F8D6B0099; Wed, 12 Jun 2024 20:34:57 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 7069A6B009B; Wed, 12 Jun 2024 20:34:57 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 5CE8E6B009D; Wed, 12 Jun 2024 20:34:57 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com
 [216.40.44.15])
	by kanga.kvack.org (Postfix) with ESMTP id 426006B0099
	for <linux-mm@kvack.org>; Wed, 12 Jun 2024 20:34:57 -0400 (EDT)
Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1])
	by unirelay04.hostedemail.com (Postfix) with ESMTP id E45621A01BF
	for <linux-mm@kvack.org>; Thu, 13 Jun 2024 00:34:56 +0000 (UTC)
X-FDA: 82223995392.12.D4564BE
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
	by imf13.hostedemail.com (Postfix) with ESMTP id 5A62A20004
	for <linux-mm@kvack.org>; Thu, 13 Jun 2024 00:34:54 +0000 (UTC)
Authentication-Results: imf13.hostedemail.com;
	dkim=none;
	spf=pass (imf13.hostedemail.com: domain of
 "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as
 permitted sender)
 smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org";
	dmarc=none
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
 d=hostedemail.com;
	s=arc-20220608; t=1718238894;
	h=from:from:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:content-transfer-encoding:in-reply-to:
	 references:references; bh=IF7gnmwzCbL09N/BnrgDnto0pWPyks122xl7Egbstng=;
	b=pnCUW46SQ9JdQs6n6Mr9s8+bn/vA2GYAyZQJYLULxTcmlXXVnnLCRS9Ko/1Fxk9VR97RfY
	1ZJpXAtahGBsWLVTxuNFivYdNsPRLhF7mKcF1/0l40EwRzBVJ0F1/rgGb9Vz5PLG7Xp3Af
	RyDTiSZuuyATaw3T1CNcgTvwupalKos=
ARC-Authentication-Results: i=1;
	imf13.hostedemail.com;
	dkim=none;
	spf=pass (imf13.hostedemail.com: domain of
 "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as
 permitted sender)
 smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org";
	dmarc=none
ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718238894; a=rsa-sha256;
	cv=none;
	b=v2JTTttn0QrTiOmyViI6zv8bIr8fxHubUB4ydKuNeEe7PKipAa79QdPKQdOvmbx8pa6mCN
	dlZn8ctsqnIkrx1UVEIuHU66xBaZqD/A/VUmJa0Tw1i/ScW/V0sEMzj74HW2RJAcusnh5U
	hcm0z329+tsRiwZmVVpc6IWbj8ga3RI=
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
	by dfw.source.kernel.org (Postfix) with ESMTP id 0A03F614FE;
	Thu, 13 Jun 2024 00:34:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99BC8C4AF1C;
	Thu, 13 Jun 2024 00:34:52 +0000 (UTC)
Received: from rostedt by gandalf with local (Exim 4.97)
	(envelope-from <rostedt@goodmis.org>)
	id 1sHYQn-00000001eNW-0G6T;
	Wed, 12 Jun 2024 20:35:09 -0400
Message-ID: <20240613003508.918902349@goodmis.org>
User-Agent: quilt/0.68
Date: Wed, 12 Jun 2024 20:34:37 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "Liam R. Howlett" <Liam.Howlett@oracle.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 Lorenzo Stoakes <lstoakes@gmail.com>,
 linux-mm@kvack.org,
 Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org,
 "H. Peter Anvin" <hpa@zytor.com>,
 Peter Zijlstra <peterz@infradead.org>,
 Kees Cook <keescook@chromium.org>,
 Tony Luck <tony.luck@intel.com>,
 "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
 linux-hardening@vger.kernel.org,
 Guenter Roeck <linux@roeck-us.net>,
 Ross Zwisler <zwisler@google.com>,
 wklin@google.com,
 Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
 Joel Fernandes <joel@joelfernandes.org>,
 Suleiman Souhlal <suleiman@google.com>,
 Linus Torvalds <torvalds@linuxfoundation.org>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>,
 Ard Biesheuvel <ardb@kernel.org>,
 Mike Rapoport <rppt@kernel.org>
Subject: [PATCH v5 2/2] pstore/ramoops: Add ramoops.mem_name= command line
 option
References: <20240613003435.401549779@goodmis.org>
MIME-Version: 1.0
X-Rspamd-Server: rspam03
X-Rspam-User: 
X-Rspamd-Queue-Id: 5A62A20004
X-Stat-Signature: 35no9ruiz8jya8kz3oknzbd49axfmk9y
X-HE-Tag: 1718238894-517661
X-HE-Meta: 
 U2FsdGVkX1+V65fGXm4tOUPQNB0j3oNiPdFuUAokS0LI3I7NLSvR/H/bf2TighXgjVa7snWhjktFCO8PQxdZzeR/PsTewbLKsIDVxHiqMq4OXk9KtGKntho9yKBc0bh+28vx3aFo/Th+lXNkA1gxxAfeVw7TAEeRxJdwf5EesNtNOwR1pghDz6oGhMyhhuFHpa35sEBOMiUscam4b6Lf0HokhewBmlORNARi9nLYNVX+WXgRhe7rVRwuaTVGvF/l2bibPnI98Yc/fT6F4T677Q8ike0VIJTt56UUvpzV2gryNZQW+g/LL4NbVIijcYofZ4SWJ8MkcYW+sRv0+N5KOUVGa3sAt/opW79wX0ZNuFucvIrA90j4VNaIDKQ2Kf9eP2ij21x2NsydFmSku/EGXXSoSSeG4iYn2QaHsnzehp/8P7mKGoEW/75BlqaeV3CO5zO0MRpKEBhWxvnkgv1iSuJ/+ER79IAh11OYJduoppDJ7t2OScfWQQzIfzN/KSugVClkjmXRyL5NLkq6ob7H0IQ+HDeer7iYxUkb+hHi8Jp2cruMN7fYu9TG+F4NlCZ0KNLQ9J8LSdU3gIelM0KDwV+2wFzlKWwr8v8yewwCe++tj23Lix4mOE4wuaFeRKTtiCyi9HHg/ODmWqQxfQ2Mty2S0407DnzF5YRt5q0wyPbAGhdE2kxeoi9R2CqFSp4xRTiE6up10WqS7uS+wPMRqaFCUmTFmvfiRPpI+TUfbN54WkJFQ0NN8NOzFRpaXW4gK5+YSsTYOLpfp1U0eU2s2lZspTcXfH96vwdArL1eWQZdfT/51IDYULY1iUQjrQQ/6oqylFUVZUVVMMl364X/dQnk75+AXal5jNJp0qE7KjFq+uZ/899CR4pqNKreUgXCeI0lEN3Dwwxawe2Az9vlvltFYxsbFKFOJmcNRpc+HKCRErZqLxpudXtaj17rAxL7REbRwny/NiGYIzOHm5k
 E7vL7BRg
 3GT6bcQV8baWoh8UWlm+jNba7VHMJO4ySXe7z/tSik4AJAC13q53erQxsdKZxURhTXt280EmtgP4cHB1lI9q/DQS2m/JrWix/bmEd3BJ61XYDY0fasOGrfzwxxY+iC1AB8tf4802NK6auE1GQtMZb3nOCYNFDwl8CwlwtvgR3q7OMnGrdySVXfq0SkA33PKaQ58xlIguD3D4FRfCQpisanKwcn3WY0+Mo63mUkFJBPqyHB/SH1cy3tXXqT7Fd45Mpnt4L04Gnc2ppwNdYGLiJMt4p4pbtOxBdJPmgcaIIQR8wOF/KOPpNLBH5OgUHNyPAxfzP2WWWHKmS05cYQ6ye9ZKGtb8by7joOFkQbxi0hwk51vYWMFCR8tGvnGtmiWGBlbNu+0W7QBmXXzKVwzPV3kzhsSIn2ZFqwdXrOi4Nylsg/K0vWWX8hBMtqusdha15RR5cp+GrpTB5KBo=
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>
List-Subscribe: <mailto:majordomo@kvack.org>
List-Unsubscribe: <mailto:majordomo@kvack.org>

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

Add a method to find a region specified by reserve_mem=nn:align:name for
ramoops. Adding a kernel command line parameter:

  reserve_mem=12M:4096:oops ramoops.mem_name=oops

Will use the size and location defined by the memmap parameter where it
finds the memory and labels it "oops". The "oops" in the ramoops option
is used to search for it.

This allows for arbitrary RAM to be used for ramoops if it is known that
the memory is not cleared on kernel crashes or soft reboots.

Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 fs/pstore/ram.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index b1a455f42e93..4311fcbc84f2 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -50,6 +50,10 @@ module_param_hw(mem_address, ullong, other, 0400);
 MODULE_PARM_DESC(mem_address,
 		"start of reserved RAM used to store oops/panic logs");
 
+static char *mem_name;
+module_param_named(mem_name, mem_name, charp, 0400);
+MODULE_PARM_DESC(mem_name, "name of kernel param that holds addr");
+
 static ulong mem_size;
 module_param(mem_size, ulong, 0400);
 MODULE_PARM_DESC(mem_size,
@@ -914,6 +918,16 @@ static void __init ramoops_register_dummy(void)
 {
 	struct ramoops_platform_data pdata;
 
+	if (mem_name) {
+		phys_addr_t start;
+		phys_addr_t size;
+
+		if (reserve_mem_find_by_name(mem_name, &start, &size)) {
+			mem_address = start;
+			mem_size = size;
+		}
+	}
+
 	/*
 	 * Prepare a dummy platform data structure to carry the module
 	 * parameters. If mem_size isn't set, then there are no module