From patchwork Thu Jun 13 02:30:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A85DC27C53 for ; Thu, 13 Jun 2024 02:31:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D1346B009B; Wed, 12 Jun 2024 22:31:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 981466B009D; Wed, 12 Jun 2024 22:31:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8225D6B009E; Wed, 12 Jun 2024 22:31:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 61F566B009B for ; Wed, 12 Jun 2024 22:31:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 18B841C2DF7 for ; Thu, 13 Jun 2024 02:31:14 +0000 (UTC) X-FDA: 82224288468.12.30BCD66 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf16.hostedemail.com (Postfix) with ESMTP id 415DF180002 for ; Thu, 13 Jun 2024 02:31:12 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L0DY5MrU; spf=pass (imf16.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zt6Zo0BQwE9mYz3Q0zCJOWUGA/XKEFxfC7Idotg6GZ4=; b=By5oteG2vYKNiXXwbcojQ0i5z1H7WpE2IA1E0X7Qrhm7JPh750n544xESTdmaqXO11kpam mHaJHW0xkzyLPOdgJPZPBpCsKTJS1SAGJE4Cz90vS7GQT/ODUuOntAlCIVbFUfl1cUMbA6 NuybAPNcKiZ7zt+r00eCPhHVaUyD1dk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=L0DY5MrU; spf=pass (imf16.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245871; a=rsa-sha256; cv=none; b=pUAc0LZ+9tMMDTHUlVJpySFY6W0vkb0GbcxfC/wQwxrRmwApB3STptSS3tVflGnoywC/Cy nfuT+2/8HcqQi88hu8Ou5JGDOUClReJky1JKPsYsi+yB+C7v2Gskd6SNEQTlCVyt6u9nVp BM/m5eOtlIkgFIfv6OK54ukJmP97VqA= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f44b5b9de6so4604295ad.3 for ; Wed, 12 Jun 2024 19:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245871; x=1718850671; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zt6Zo0BQwE9mYz3Q0zCJOWUGA/XKEFxfC7Idotg6GZ4=; b=L0DY5MrU9z3Wag7NqA6NVfzixe8rQeCVEmPRG59qihT5d9cSIh9MEvwwTESkccjEVS rmUkc8T5Xn6vtz3oBE7bRd8Kg0x7JPIq6ymViUs2f89q8hyKyNpixWTj9z7ff4yMkbIb dEedt3qS97wn3ijRfU+8q+6rUavX9Y09zZhVW42Llq5RwvmluoCsKXqN7/6EMvu37uG3 AGHOnYW/i6FMtcLbA83Jk0jXjGd/Mj48v0whq28VxqjXv+ForYFKlbfVfIqZ6Qy5jWAN buou2xWU6FkYcyVdseVRrpLpXHP3/Re6J1JGzweqB9FhdgP8EaZy35yQMC3Tytk75GAD qWyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245871; x=1718850671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zt6Zo0BQwE9mYz3Q0zCJOWUGA/XKEFxfC7Idotg6GZ4=; b=A2savAgI75I1r/hz8cZYIJeAA/bxA7FKfDBiJDpbzbhIt+kvA5hBv/MQqYMbfK6eDa W0A72c0aD4jtQHcXYa8rD5qsUGuyUYOyFRr6yhL1RSb30gdcHZf/ETn8+6XRCXY7nkuH 4wm0ooAyZYrKSpGxGV63fB+7wpVYSL7rLL6xPJz8LF03hwlmUoarlbFoKE1w+Xs04QyI eiiWolXyXZ8iQrxi9sX1q075H7kZnmyseB7+jyD0clejf2b6+Gdph9Y6wHoRWvaIiaQC VaTxxdSJjJgXuhlWZQF4Gih3O6YkPYXuCRhsFlqrnNeV77q4PN3SmlcZ15AVWKkvgHrT jHMA== X-Forwarded-Encrypted: i=1; AJvYcCVXDdo2VzUfjaUibawcS4v4DXr37N6+PO150fJ0hFjGd/fVMM6BrUnfkfPHKw2Mj8pZTca67SMRA9QDa21WimU/ODA= X-Gm-Message-State: AOJu0Yyn9CyZC3JK7YfJT0GqRfh/AFgySQhmaSXZlmB1AvlmiHdlnE2R 0I5L4eGL0KUHI8cB81ga/dP2HkflJkxU2VIwcC5e1+YV1VQ0pGXdUs/bQVLW8X8= X-Google-Smtp-Source: AGHT+IGepHvi+lKqMo1GYaife0L6fUJVRPiktMyHkXeHwR+7tr6qOJAeLHRN5Lin69VRxAqus5DeJQ== X-Received: by 2002:a17:902:ecc1:b0:1f6:6ef0:dae4 with SMTP id d9443c01a7336-1f83b5f3fffmr43616545ad.32.1718245871101; Wed, 12 Jun 2024 19:31:11 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:10 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Matus Jokay Subject: [PATCH v2 01/10] fs/exec: Drop task_lock() inside __get_task_comm() Date: Thu, 13 Jun 2024 10:30:35 +0800 Message-Id: <20240613023044.45873-2-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 415DF180002 X-Stat-Signature: frmkb3h9z3zhrzsmfojpfa8u4fejq3ip X-Rspam-User: X-HE-Tag: 1718245872-57740 X-HE-Meta: U2FsdGVkX194RrxsQ/bIHI8kLlxXkp6uba0uAj2SAUtfausn3ZKLSPmiJXJeZEdNGPawrBDaqzwbTTIlwUE1O7rEDCdBvD4vHsQYf11dS0AjRS+Moo8V5dRWIn55Jwzhbdib5d1adH3t2/o2kCsrWK35hcFmMgF1Ypu6UQwnt5ZH0O8iqNLZNUpUKdd30HsjgubXxjefMBwzRD4hKpLUU45iq2J+fqCJC72OLHwsKrpZ5lOUXYmkjvzyLGWcQ+sH9UtHb2PBFAY77UV3sgi5sK11svgja0WaelqDo7izuWb4E+qlPoz5JXfxEk9j+2WN/KmuAsx4pgyThnnD9+02CLhQL0jETkL7iS1efEkThcp6lpS5kC/3lWjaBMRdaU03Mj9WMfE1EX3Pr+7TvBsE5iD8fhfeNtnZDRWMsMZP6nXdIAZglVDKtIDR2Ix2pOTtLCdj9DTwdxArcGJ6TqhI8OAv05txjb7NzF2A9IxAD2D4l0ECW3H52MqK2bOzi1/q81QlDLrDcfyt7x1SfgrKkLMPDK66UdoQpx5d4KKMerQGInnOYjK+T5RnUiADlr1yvXLLwuYR6lNWHt74vs/eQRD492b0b1ibOE6+Ppf1VZKza5oDpXMvhXMqI3Z4JQ22Ji9V4HhwWI7UD6JCxAAv1dyb7fyO5hR8bij/j5Z6dL9Nw66vOLa4WYAT5wZgufC/Betxf43Q7CLywnHES6tgj1eitZmb7WcabTNkeWP1k5iHIFWv9pPizg63cN/SdQo/80jSwAKr9PgdJlSQIZTbyh0RSxSpUK0YNeTxihT0gR6Q7lIrLvuBuKs0U9e04G93vw401wOuL2jRk2vbTDpKu75TK+48IqIddguf+niBYlKkDSUC5sUoe0AX+W5QW4BFsrcFLqCzEyhIgs/9P5WpH7PVdFi/rdDp3u1EiWXL2pR/8hFpX0cCE0xGr3XcuXFirCteuZtGLGLBxoHcAVe ckQjjGgX gyazTLT4adw6xUe+cIT7fCmAZsRxcaowEkGVGlshIFRHZHrpqwT7ozxX70wISw7FyAGRSXpF5RtfoDpc9t34G6fRO9wKTEZQQ7wo91demDAQA1COuATjuuhPxrwSgUUhL2CFwlNl+4OQjnBTE0V2tXs0e8NSHocX5tSe07Jdy4t0/SHhVWxOaeYizW4INtjEs6HwIRzGEJ3bP45OpRQws6KEYLfrDWcj9vB3jgJ6ocEdtMJ2jeNv/KDsmFnw7m9Uo6U+w80x6PXyJA5AD5lqrnVzQAiqt7qD2aUIuySY19jH9o52BWiLAyU5CgYolE0nr2NDxRHOI7vARUheAwMU72MxjNVxiEpMqNvDqed/o8hhtWFVufv6ybEdRfGVoVcQWBXMtPwW8HPC75/cwYHIQIHSnDqraLQ7M7vOqXrrxMCxkpAKV2nsWSbT3xOT35DmVU8RM0KnKer2+g65XE0txehbpgxGPueCCWbGamT0hQPYHJLcuqk8qKkUrqzy8/Z4IQ1pyEHM7rPm5CVN5Jrf+GMBY0C/ak0PNFvmXn9R531bU9vULZL9RViNm+LXPI9O3vPRqlkXgtwLB/SD0lRyCwRKuqE9OcrUNFkF5YPBBoRKyhwM6YF8tcHTZsS7t0s4AU5P64N2v+lTru5fdDTHj65VA+0hvuQRKKQM4scWJB4dQim+mVOkMfjUmYyWTfcRryQqyPpk6TCQu1UJiOEVd2y7hB/qTU06T3IMqpmPw9rkzObk0KYKQqhXIDp/CEc/qetsltS9+gF07f1YvLiUHXfenNETZTHij47uVnN6KJaLsreM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Quoted from Linus [0]: Since user space can randomly change their names anyway, using locking was always wrong for readers (for writers it probably does make sense to have some lock - although practically speaking nobody cares there either, but at least for a writer some kind of race could have long-term mixed results Suggested-by: Linus Torvalds Link: https://lore.kernel.org/all/CAHk-=wivfrF0_zvf+oj6==Sh=-npJooP8chLPEfaFV0oNYTTBA@mail.gmail.com [0] Signed-off-by: Yafang Shao Cc: Alexander Viro Cc: Christian Brauner Cc: Jan Kara Cc: Eric Biederman Cc: Kees Cook Cc: Alexei Starovoitov Cc: Matus Jokay --- fs/exec.c | 10 ++++++++-- include/linux/sched.h | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index 40073142288f..fa6b61c79df8 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1238,12 +1238,18 @@ static int unshare_sighand(struct task_struct *me) return 0; } +/* + * User space can randomly change their names anyway, so locking for readers + * doesn't make sense. For writers, locking is probably necessary, as a race + * condition could lead to long-term mixed results. + * The strscpy_pad() in __set_task_comm() can ensure that the task comm is + * always NUL-terminated. Therefore the race condition between reader and writer + * is not an issue. + */ char *__get_task_comm(char *buf, size_t buf_size, struct task_struct *tsk) { - task_lock(tsk); /* Always NUL terminated and zero-padded */ strscpy_pad(buf, tsk->comm, buf_size); - task_unlock(tsk); return buf; } EXPORT_SYMBOL_GPL(__get_task_comm); diff --git a/include/linux/sched.h b/include/linux/sched.h index 61591ac6eab6..95888d1da49e 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1086,9 +1086,9 @@ struct task_struct { /* * executable name, excluding path. * - * - normally initialized setup_new_exec() + * - normally initialized begin_new_exec() * - access it with [gs]et_task_comm() - * - lock it with task_lock() + * - lock it with task_lock() for writing */ char comm[TASK_COMM_LEN]; From patchwork Thu Jun 13 02:30:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695898 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488C3C27C6E for ; Thu, 13 Jun 2024 02:31:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA1AF6B009E; Wed, 12 Jun 2024 22:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D52156B009F; Wed, 12 Jun 2024 22:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF23E6B00A0; Wed, 12 Jun 2024 22:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C0986B009E for ; Wed, 12 Jun 2024 22:31:22 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2BC6DA3A5D for ; Thu, 13 Jun 2024 02:31:22 +0000 (UTC) X-FDA: 82224288804.28.089AFDA Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf17.hostedemail.com (Postfix) with ESMTP id 55FA14000A for ; Thu, 13 Jun 2024 02:31:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iIq6HEcG; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j1cpGZH9ekrwOk4ggaybwp6iXeGg5lCIICWIGBwiSB0=; b=VftyL1uO+bA2siohZL5rOPjnSHCX/GTx70K2mJl0g2eu9vSNBMBTkmBT8dgQv/8630T+go XIO2i/SRi4Umu0U3Lcd1GSINtc3L06Y2X0IPUxAboaSsFOhmw6WSA/hhK7l/wGW+7QnnOK d6zzggEZLY7/i//dQnASxL9ap4vbKi8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245878; a=rsa-sha256; cv=none; b=bV4KCUn3SMRINhGL1lWfILdHlFas1lE7FtdqgrFpxQCgTojrO7HC9jCt3Rhy+2VGIaeGfR NePOTxKhlToGI5diXGqpUJm/wuCVql40yThQPfFRW7hr6eddakuBGr8UgEzoVA8CT4pGaB N2Z3GdIgNIQq41jxEVqDkM7C3ZWUzGc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iIq6HEcG; spf=pass (imf17.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7041a7d4beeso460265b3a.2 for ; Wed, 12 Jun 2024 19:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245878; x=1718850678; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j1cpGZH9ekrwOk4ggaybwp6iXeGg5lCIICWIGBwiSB0=; b=iIq6HEcG3BGfrgyhOOZ7yY3x00ICiuGxfdMYnFzBDOUePYqX+Lwe4NnrsyrVJ+DnPH nMnbVAH3PlOYs6phJfe9o1z9GY/mIx4yvedSngu5612UNP9OLmES4wcM/CD+H/udquSc vQOLhnqAOh0MCjIrgkqr6ZlLENpBVKHxyMxAut/8oa/8GQtZWhL0YDeysFo8nlPsmwN0 LxeiJLKhjMGsPTNAZ7UekqFC3P7iLhiRfdBd8P5Ys8tWagru2Iwy19QVoaSzfivoqzQ1 Rapgj+3RTJsiDZ1ij8rSakvxiXWHAIotZD8HF7SjaM53pMYZXmeleZy0NHMs/96H9F34 U28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245878; x=1718850678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j1cpGZH9ekrwOk4ggaybwp6iXeGg5lCIICWIGBwiSB0=; b=f79oBAyQRYLfsig05TVhF1U61spO7judJcH19MqEQ7zt63/HGTxdbVYvBGg/ZHprGk USVumy/xW3PE3Gk1MFQc7v5Pi0014voAQ6YKuQMVTi1KeQSMMFRi357S6E9MD49HChx2 2kdMnQYGaNF1NwvN3a0A770KCNbnnIpa1xorn8r65ndjLCnGuodSMhW/SDP2flQGsP5d g7e9nybYiNxBEfOGiLYF/SB84lhFZBcxhbLvxR8mAkLr3qXJPaD6xK1t8ZTn4lke785B XBnQF9mm+epkJzAqy9jX/HV0lZBRPdsF4bxr83ZOqokgaAsPdD2QPYqicHe3k1+3BP9G mnvg== X-Forwarded-Encrypted: i=1; AJvYcCUkuFcyPHSYr6SKxnT86vYSCFiq7pU5tEo+0Z8UgCx8ToWzIrSm6EYuPmISDk1pVqD+XslQAC8nYHX1sbG0p/kx7Wk= X-Gm-Message-State: AOJu0YxfvljcfZO2BEY/WaYBihQZpcDWqNyAWm6Utdml9GDZGzM29Ld3 DRWBVcdTNiDEsQPTh/yoQ9LRH/KkHn2qpM7gVYDiK/H6z7zfKa7u X-Google-Smtp-Source: AGHT+IHxE49dVlqeBIraoeODhxKMszGj4KYKBCDFAoiQKvyi2cHrcHMBy4aCqKmXdfgNqTCtDPqmtg== X-Received: by 2002:a05:6a20:3948:b0:1af:8fa8:3126 with SMTP id adf61e73a8af0-1b8a9b773c5mr4249289637.6.1718245878051; Wed, 12 Jun 2024 19:31:18 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:17 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Paul Moore , Eric Paris Subject: [PATCH v2 02/10] auditsc: Replace memcpy() with __get_task_comm() Date: Thu, 13 Jun 2024 10:30:36 +0800 Message-Id: <20240613023044.45873-3-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 55FA14000A X-Stat-Signature: 93eoc6auucun1y9946kzbekufbqoz8zh X-HE-Tag: 1718245879-723912 X-HE-Meta: U2FsdGVkX1/P6YCfThKWYOKolbIXYHKU40yTOHWLXo8bx7lPz6+CtlOph+AbKvUrcA2sFqj168q2ItKgguODSjlN1t9FRlFOmNQHRYbOZwc/c+206jJmznFScne7TYBU5j9fuAQlpZio2jx8agQmxjmYDL2YMbrfJWGYAFHlwZ25YirLobz/lkee00rejsujK/Bp01SdXsHu+U2oDOyqZ+5oM7ttaLZym3ozZ7qJW0VsH1yD+3Zo3gnkEApwCVyl7jsDlyPx8RPhenudzNsy6wXSUOXe5b6eWBt7en1p7JK321h8J2lVQ5fk/yWt3hRz5aDDjx0uts3M4Gn8eRWlatI/eA/OStPbnnbE6e4dDS/myhATS3j7ptJyIiuDqG2APxmU3tIHPLqPW+536Db4JlYXY/c72rOHo3t8TeJZ94GtwuRz5HfxniRYGH4OhdTO+idZaF5ZV8+DHUWvcnArXkhAgoCXjpKQ8GnQCxlRRjHxs7TCrXZx4SbPujPTYz94cIGoFbFnpXSUWsPlCS3yVZDeMNvElRFPZKXkopVu5RzTPeijClZATHKtQT3ciqp361CJmu5nTYbCFZtsTo6m65+esjxETMpk/QZgPT9Fj04PYka+I1sWe649kMmY5VlIeKDM0OWKsRIC5zQgmVepFrDAxjdhVCHOM7J6dXAhPEGyzhYc5otWQ8vUhiYHYOAEDmihAAwE4jPFLEI1UV24OTiZXjaMuHUcQYrT84oCZ0zYV2tGvD/3whzOAL/m0uIZG+zEkZnroPO+wcFHS/e/GgEBbXlqJ/y/aU0WhTD7aCn+VKgxXUtVnHGMj3ZYyClM/JzoLcdVFilx24Xbz1yqTsqWBLeIBEbZimakWCpCbNLNGJLXYGAcGUa76wBkdKAlbZgNuobSclaxscIT34zzd18mu18eEplCoAbqHwJs0Zm7xQD32u0exjkGiBOJCyajuHUTOmC2X/gr2YI45FC bKd0a1g+ Sovo9h0OpD/cdDD+VjjcYeuv1r92WKnnWGbQuOlcOHoi+tCXXVQneIqIMQXhufUT15CWOHkTSwfC0pv8NFyS/ondkvSo0HOvmD8RI2NH3CUs+Jk6lpOhDcZ9T/Mkn1Y7j7qAb4iqnoVqdUIhfObvM7w0wQARrDMnhyUw+4LWESagU+DYoaU82bRT4v99xbvVw2+2a9lSJTKnCVH20kF1U87Op9ikiawxmZfZxamdWDpuJ8uAXV1/3WLJgDcgY1kGTmAkgT3NuHy2yNV/tW6BCeCf9Mv0DZLoopv2WVM4zXPyUi0QfEfF9X8h2od70R1jIRdIPPuJvihvy77vfhzdFahC8i6etzQEabGoZduderQpaLHtQZjGe8UZRqdH7S2624CVDC8udcaSxAEBAmOYyHrDshhBYMoPGJI3Juo5tXA+Jsg9ZwLaWZhvai5DwB7qzaD3BbloVY76f/+aivjy8h3IYJJSxwoQdeRzYs79AEFka0auqCeEF1XGxXYZN8t0f6ZGf2IhQlZem5MoJ9AA+iC14eXLZA4hkV2XmdxGm+XbumpfiQ3TO6bcIN0hhwldk4YoMzV7jffe8kE8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Acked-by: Paul Moore Cc: Eric Paris --- kernel/auditsc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 6f0d6fb6523f..0459a141dc86 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -2730,7 +2730,7 @@ void __audit_ptrace(struct task_struct *t) context->target_uid = task_uid(t); context->target_sessionid = audit_get_sessionid(t); security_task_getsecid_obj(t, &context->target_sid); - memcpy(context->target_comm, t->comm, TASK_COMM_LEN); + __get_task_comm(context->target_comm, TASK_COMM_LEN, t); } /** @@ -2757,7 +2757,7 @@ int audit_signal_info_syscall(struct task_struct *t) ctx->target_uid = t_uid; ctx->target_sessionid = audit_get_sessionid(t); security_task_getsecid_obj(t, &ctx->target_sid); - memcpy(ctx->target_comm, t->comm, TASK_COMM_LEN); + __get_task_comm(ctx->target_comm, TASK_COMM_LEN, t); return 0; } @@ -2778,7 +2778,7 @@ int audit_signal_info_syscall(struct task_struct *t) axp->target_uid[axp->pid_count] = t_uid; axp->target_sessionid[axp->pid_count] = audit_get_sessionid(t); security_task_getsecid_obj(t, &axp->target_sid[axp->pid_count]); - memcpy(axp->target_comm[axp->pid_count], t->comm, TASK_COMM_LEN); + __get_task_comm(axp->target_comm[axp->pid_count], TASK_COMM_LEN, t); axp->pid_count++; return 0; From patchwork Thu Jun 13 02:30:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790FDC27C53 for ; Thu, 13 Jun 2024 02:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BB1B6B00A0; Wed, 12 Jun 2024 22:31:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16B946B00A1; Wed, 12 Jun 2024 22:31:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00BD06B00A2; Wed, 12 Jun 2024 22:31:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D65C36B00A0 for ; Wed, 12 Jun 2024 22:31:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 979A0120437 for ; Thu, 13 Jun 2024 02:31:29 +0000 (UTC) X-FDA: 82224289098.11.34918B0 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf16.hostedemail.com (Postfix) with ESMTP id C1B26180004 for ; Thu, 13 Jun 2024 02:31:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TLfMV+4c; spf=pass (imf16.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nQwUpm7TadSQyuNlGOfh8JWtJNghSVDBcHtu3NLgdvg=; b=ge2Zl6HCu7b033/pICuy9Z/JzsEkNbaeLhgeDOgBPvBFNWEopVZYAKn/IqCEB+GE5wlZ42 b5c9GGmlurRSk4/d2qgqPqk/uoqDNZgx8sjIKTrGGfWpur1wInls9XDKM/4RPDVxwe8Ns8 xHNeRMoZWP8W68sXuSjG8FpTtJ6VWOE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245886; a=rsa-sha256; cv=none; b=uwHjG2Jo+aqMTH6Vhyyx5E8IPAdgMkqehexp4qFqbEhTg7DPdIhqoFx+nW7yEjYOgKkpsT ro3Z66foIJRF49XCcMMv2PG1shWwkwdYTeQbbl8l1ijPxhGqI6WZTVOQiM3m640d49snJa 26yqleUR4JMq90AdZCFIE9b6k6HLSa4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TLfMV+4c; spf=pass (imf16.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1f6f1677b26so3884605ad.0 for ; Wed, 12 Jun 2024 19:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245886; x=1718850686; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQwUpm7TadSQyuNlGOfh8JWtJNghSVDBcHtu3NLgdvg=; b=TLfMV+4cT+VICBk87YLXBnXENPVUQlnetEOwS2vXdMsOz9wVsB4YWOZcjClu56Ynzd VmJIrfpNH+p8AHSHI1UjU2b9bq1XsryECCLIMZloOBCpTyPzmsxaCt8Pyw0jd100lCyK GlrCTAJr65BCXH47YT1eOgIGfErLN4cEzkl7CcTcMmObDFHAJVJtDLyJjnz6QJpoGx3d 210ds4NvI1tB5oEKp07/TDJQGD2fmAdJYdPp6PK+f1EmNYe2vEXjT77BbPK5iyNUtx8z N3ys1E6MyglR5AusXNPd5SEuqGJJTBeBA/2RazpB3crV0kNhrzm8CKooN6HTxhCJ6aj2 G1jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245886; x=1718850686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQwUpm7TadSQyuNlGOfh8JWtJNghSVDBcHtu3NLgdvg=; b=SbuQdKJHpC55wFFaI7OFiaPmPXXo+vb4sdBM9yAU3JgvAtNoQ4H9iu06Rgwb1+CzL2 F1tA+RaJfsE54BzBBg2vgMhFzEBP4lC5d+mML1ioOy6rvUEeDgZUKHg4lkYHWHvcjQd4 NnTncBxRMgXRZz4qawbzQGh6WUI1fQKBMrUCOf9fUysPZlFjtHhHrxPtjlM0Vpi47eDh Ej4bcAg8r5aCnIP0UDDesE/IXC3Phjqgdu3nux513iPU6+1sZRzRGURM3FmH3NOmhSKH EHvA0jDhtuCqTSlh+bi4o1QkIkssYVSjX8K0psTpHqSHUnXRJk7dagmcy1dKQEs7KPYN gRuw== X-Forwarded-Encrypted: i=1; AJvYcCXFDaxsJreqod3NbKJ0ihcTUbYRiNjXwtRT6+bOrayXRZaS1lQsf0NqVMnXFUSwIYp4ShLZWMwQkE7fVVHdWhixzBM= X-Gm-Message-State: AOJu0Yzprx9qM6NaHHw6KgzetQzcCilsWbxuhgn7RBs9h4QfvwiWCfiK hZkLo2STU4CktMtjSl0Txmi8o4+tC1aIXOAj27Yje0hI+ExQSSHh X-Google-Smtp-Source: AGHT+IGMO7B1LQEga8czanZyIFvbKD26XnoiSA9hTxuO951zhYSmXnFwAhLQKN8VIXez5ya7Dmvfhw== X-Received: by 2002:a17:903:40d2:b0:1f6:ed6d:7890 with SMTP id d9443c01a7336-1f84e2cc0b3mr21158875ad.16.1718245885659; Wed, 12 Jun 2024 19:31:25 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:25 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Ondrej Mosnacek Subject: [PATCH v2 03/10] security: Replace memcpy() with __get_task_comm() Date: Thu, 13 Jun 2024 10:30:37 +0800 Message-Id: <20240613023044.45873-4-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: C1B26180004 X-Stat-Signature: w11p1scgshz77o1cia3d7m9jm7jufjsr X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718245886-57829 X-HE-Meta: U2FsdGVkX1+wPHTCVRrmmSV19AZP59603HE4e0HnBXrXiCcn+dxqiPjvmLf5qONn62MT4sYm3clde0ZPOeHBtgHdQf7pt+2rrO9tNhXz0pNbAjTvRrwYFaiX48biGEt4b/4coSN2MKzeKPBWpWLFQeYn6aa7oJOerpyxt90Bd9H9FpgqnnQwBa9DZpOgz1i3xU/gb5+UcoALOHIHw2QzQpoLwrISTezylUwb1pOk7a417eJA1Nh5tHphbPngSiy88P0YGV1GR2/o1Js77tMDVzv9SOP2vLztKpLwjXvyFiHVjI1m3rP69nLZNx1WFHs7+pTIVrmxRJSo3e7uvG5O1YIHPgOjb0N54EZNwL+Gwo9pdyAg5jKNkkNZzTi+gZezOpeodCWopRuxC++e+bsdQhp7M7101QVlxzvzVXa2z/zR3hZ+FPgHuYziBZOCIylxgSgOAdeHaJcZ97oXFtI+MIRRK15nUp/+JJYkivnPfvKp7t/SXvIjHiDdkkOM2BHjuRaTpdIIGizHT2ltlau8dvUzAjasSrrSNxI26PA2CBWseLk5TZ2rHaaIvS2mHAFJVomip7P9hFG1LGZtDLZjoC2/G/Ad8Zqu8CvZm7cfl8qKjKBzEmHMx6sSa7Y86Tf+OF0KkBxeOhSxYRLoWQQPwngGXW5T5RbU6SzQou/mK0CDxSQo+n2WfqHlyVsbtFRdJCkdanzZEQco4OuoVfYUvEXA0xleyvtyfAICKZBp2C7R69VaSR6AL4YyrEp1qzC/fXdABVaCZsxen8x0t//TkFEXPaAWgCo3pweJ2cruHmC78U5C3TkGwbEDLx/A+udkc2A/4pZXxsD7T1LVX3z/atReq0qzDBybnjsZ2qf3EqBog+MBNCS+yjyUGGCv/rh9d1d3SvFyBdFDN9dgpqlkc5aYSpLiXsb0UUfPR5oAjq4Etgm0ZqgL2MQcJL9QONHZR8MI9BlTxeaEJ5GyiB7 VAqHVl4e yjlxuUxSrCofNFm58TrEiWj6EzkqZJf0umT4f8dJzgstteVwB7ABqXWm6AqFDEXC8sxAriOkCCc9jk/3836BT0IjExSBcYma36OUxe+92V6zqsMiXo0TVs2Exl2Jw/J126Q/D4PnAzb3fAI35EPmhzWPjHtTQJpDeiJLis37MToxlSSMnJkLMnprCNrIVxE01DcB6saDUt1m14isgF0WyFJNAEkA/BgCsm/DOpXOyHVrd37mF4i6yFJO/k6NVtMIm+dBkHl0ZnC6tR6EopGCBPxlSB24OrGAgAEHt3lHaEHlFbFT8VWi3jPCzkAIF9cknAZtol2SfYOsZt9dWAsuNnWRLRWuskrWtG/wgJlN3mPzZrjffMX4PbuvFSXxL9wZ4gTjS1UsqXDMfT+i7ln+eR2SDmCs4dYo/Y1kYSPVDj2aUi2XgN+YwHa3HH6Selc/jrqEI1WdmPDkt9MABpl8xMA49aHQh1nHRu0OOHzVb0X/bmO3UPi+PeGBQY1Zif8UhqeNl/YFK4kbxyYpLlnrK2yDtD4ldWCc2pqep5v4XomaP/r3I5tqkwdD1D6JTBGt0bqNDJCwU+jYNAiP0l2fcFw9CadKPOSngNmSyx9zuMnrvSLmESg9TFlv2o2GzH7iHkFwBEKlxuPG4EALoj7DORnwVkjwG1/5rhq72B0tNQvtlpnUnpVrrcc3GCWbGRjlxsn/qY2cdTj31siSfeY7fVDEALymuK7sJJJlUXay7g4VS73xkViqzVGqD9vwD8jNpxjD8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Quoted from Linus [0]: selinux never wanted a lock, and never wanted any kind of *consistent* result, it just wanted a *stable* result. Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao LINK: https://lore.kernel.org/all/CAHk-=wivfrF0_zvf+oj6==Sh=-npJooP8chLPEfaFV0oNYTTBA@mail.gmail.com/ [0] Acked-by: Paul Moore Cc: James Morris Cc: "Serge E. Hallyn" Cc: Stephen Smalley Cc: Ondrej Mosnacek --- security/lsm_audit.c | 4 ++-- security/selinux/selinuxfs.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/security/lsm_audit.c b/security/lsm_audit.c index 849e832719e2..a922e4339dd5 100644 --- a/security/lsm_audit.c +++ b/security/lsm_audit.c @@ -207,7 +207,7 @@ static void dump_common_audit_data(struct audit_buffer *ab, BUILD_BUG_ON(sizeof(a->u) > sizeof(void *)*2); audit_log_format(ab, " pid=%d comm=", task_tgid_nr(current)); - audit_log_untrustedstring(ab, memcpy(comm, current->comm, sizeof(comm))); + audit_log_untrustedstring(ab, __get_task_comm(comm, sizeof(comm), current)); switch (a->type) { case LSM_AUDIT_DATA_NONE: @@ -302,7 +302,7 @@ static void dump_common_audit_data(struct audit_buffer *ab, char comm[sizeof(tsk->comm)]; audit_log_format(ab, " opid=%d ocomm=", pid); audit_log_untrustedstring(ab, - memcpy(comm, tsk->comm, sizeof(comm))); + __get_task_comm(comm, sizeof(comm), tsk)); } } break; diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index e172f182b65c..a8a2ec742576 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c @@ -708,7 +708,7 @@ static ssize_t sel_write_checkreqprot(struct file *file, const char __user *buf, if (new_value) { char comm[sizeof(current->comm)]; - memcpy(comm, current->comm, sizeof(comm)); + __get_task_comm(comm, sizeof(comm), current); pr_err("SELinux: %s (%d) set checkreqprot to 1. This is no longer supported.\n", comm, current->pid); } From patchwork Thu Jun 13 02:30:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695926 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C41C27C6E for ; Thu, 13 Jun 2024 02:31:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B58306B00A2; Wed, 12 Jun 2024 22:31:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B089B6B00A3; Wed, 12 Jun 2024 22:31:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 981E66B00A4; Wed, 12 Jun 2024 22:31:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7612D6B00A2 for ; Wed, 12 Jun 2024 22:31:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DB928C04EC for ; Thu, 13 Jun 2024 02:31:37 +0000 (UTC) X-FDA: 82224289434.26.90723C3 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 0BE9F20007 for ; Thu, 13 Jun 2024 02:31:35 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ROPaub8Q; spf=pass (imf03.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c7QH8g7nY2INvVrL4NU75ftNhN6FL7HL04IiCAjwJmE=; b=GOk8HNrIKE8MI5kvzVsG6Mota5WZiUjUbH0gz9EVHaI5dSTFiklIr9W/RJ2a3MeZOLjPf4 80XYPzr4adMnIvGHLromVwH5wNvy+DVYZ2Y9kcOmzgV01TeRupaIIT93DeuLF4WpjK817a rdXQuBEYJ46H1ZxBMDjKinV0EW3JYJA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ROPaub8Q; spf=pass (imf03.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245895; a=rsa-sha256; cv=none; b=kvvAxKuGoSGUumPyU8u8OGSVKk4ITGc5ZeXAwXpwH1iwDNsZbzirlv1h8O4AOjzQzahq3w 3tjX4Svvz1HkFrjI2JS6/YQgeRDiJpeFhOlKdoZxVKHZC0UV0JayfNsfI/VpYPeqQo9vm6 9NmS5+QtXKCdjXHoZzJIfxFI4l3zD6k= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f32a3b9491so5300035ad.0 for ; Wed, 12 Jun 2024 19:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245895; x=1718850695; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c7QH8g7nY2INvVrL4NU75ftNhN6FL7HL04IiCAjwJmE=; b=ROPaub8QEtC1bbmt/a48HM6qVXpl1qEDkq0zhUa+Wa3OjWmVCwD7XLqwpsPBPBhT/E fZ6XeIV2RCy96qsJAAYo9NvCP1zIXrx6gEUfGftPnIQN9FAx1L96WwE+/hemwceQBKFu ncRQiJEbQOKaJajN6dW+2qrrybyu8RShRDbGGBYVLP2aDP9bQK6cNJKnRv6Bi94W2zPA wwXlQVhO9PtJqVOWM1+bAW/m+ZzINJZssrVU+Ijh8SirdBxTHKgcKHqAAT6sS5Mv9Kin swae368qgZxROZgX1sfuIRCqhTuwcUV2Sb9zn1xJuv5xufRawUPcoVNvg0SnX83ppu1G YNQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245895; x=1718850695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c7QH8g7nY2INvVrL4NU75ftNhN6FL7HL04IiCAjwJmE=; b=Jk94+OtIjlnN3bOgDK5phIhwBWXEETLBzzaFWWxT0ohlC1AXAy4LDm1vhm+8sZi4Az Jm1ZeTvRe7wXjAITKHTKXRVJoJKoRjULTyMfIgzDk4AS/fCxmOnGZXeY0K4Phad1yq8C t3kboODXvN6ZADpopY3yw9T3UaXvPQGkbtrh0y1zv3AeTl6r4lk+iOEpy66EjeJLUSdv cH+lNbI7QOOEhpr70Bc8K8SpKQM1T4Fslek602m7A/4Ik7nOq3bN3WPruvIExIqQwkBY VZjcnr6T4gRg0a8YCfRAFX5V+NvhSsubb0WwULnduBWtNKzoK3lywxKiZUuxvSbCYiga 3K4w== X-Forwarded-Encrypted: i=1; AJvYcCXQrXPTLRr7WDUNrdaYBK5Aiw11Ul30za/J/mh2p/uwu+jKEubJIyt6QG4CmWAG6a5k/4vt7dTMsR0f2A6t0nlsZVg= X-Gm-Message-State: AOJu0YwhwsoZbGqVLBYsWYDme45edK5XMFEf5hjA51roxBcI1HkYKdxd xmgwhmEEiLl5C0KnxextuOhoK72x+5YCjf8NwCC625PWfbolD/GB X-Google-Smtp-Source: AGHT+IFO0RiQEuS+ZZx5NhUKFkro4pSWALq4fQpBCAuUBHe6UDJpEGOEOlucSptFPDnQxh/E7HkfRA== X-Received: by 2002:a17:903:2283:b0:1f7:2051:18ba with SMTP id d9443c01a7336-1f83b565dbbmr48444305ad.14.1718245894762; Wed, 12 Jun 2024 19:31:34 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:34 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Quentin Monnet Subject: [PATCH v2 04/10] bpftool: Ensure task comm is always NUL-terminated Date: Thu, 13 Jun 2024 10:30:38 +0800 Message-Id: <20240613023044.45873-5-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Stat-Signature: mde6x31cpaz6da7e7cej7powt8r5z8n3 X-Rspam-User: X-Rspamd-Queue-Id: 0BE9F20007 X-Rspamd-Server: rspam02 X-HE-Tag: 1718245895-165668 X-HE-Meta: U2FsdGVkX19UCBzmBbzXaZcyFhnm+DCeZrFoHhZWRrikT5xR3D7Jj4mDRJ10rEdks19yW2q+q6lezWk70xckFmyLZMJW1Jex38iFLFCGsBEhfyf6t6w5qcbGGibye5bn3cBol/QdLPfhNJkBRIhh4thRN2nSIqG8XkJ1QHDNMIxKT6dwmGi2jqGiqQfODH5XfhGL2ViccwvkIp2BXBMr5pOTG3heh40Vi81fdTIH+FCZ8KrAN0eO0UXYA3VlqhDdZ5luYGLHtbUkzcNQ+KaM3kTPQsEfkA3yit9Xge2CjnnGQkzPHyBCiC3XtC7tepQeq2edoQAKEHWva4w6rcxPXdbbqsCIiMVtGkqKe5jslA8mvpu1vkLxn2QNKdfugLsExNZW8K+HqG6mjuJ2CP+vOA55BY+gPC3iD4I08YrUFLMmcdV/xWltkei8O82UBEWArneTa+Qyt/I+0QCsx1P21HfNVF5dOUgBkhnp0dJlX8HmyEp69xMLeO5zgcqbRncSrWN8xuniKfzGkG/wD3FnhT+cwBCAFSyC92ON1GxeyHIurHbO59A4eTOlViWGdTRy428mSaf8iqLMs0t2Q0qeupDIhw60Kohv/PCFUl5m0Iyp9yK1IQYBGoRuTizq/qL62i/Vr9kRmzDcmpCn5WnXpuVQZbcbWi3MTYPX28YiA6bwy81ZKVsADIwh3T1yvnVVeatkvzzM1MApnwFri+raPqPdbqzxwyZZp6UXyprbyVdbgxrrEvLedEjmAXt0GHnmZO2WNIxV+YBwj5za1OY2EmwUWqfJC+nCBh4BUFYZMqxLRgc+JKO8DYPP3P0H8ooHmKzvjENR2wCM8uWuef9Q5j0WyL2UVDk3BkmPoq0Y3NmE2LuJ4AQh/FPncoGTseeEt0K2tOxmuvLE38cumAMsTwhig5y2q4WaoeHa/FiV1c+gL+TTAnFF83hrf2i3zVi9+ptswtjMX+O/epGYHU/ ++eN1rhh MC9dlOgRtz/ylgkfojqARkgDVJklS/qHg3H8gDdsZ1KNnlWdUVjIyMN7omr2qBzA+yqjJoyTAu8jcSDWIPC3aEGAgIaQSjUd9OKjTHbrdMe+aDOpljNOG03d7WtD5sxdb7BfECmdgOtDMnk1o2m+V44a+Ky9/z4jI9eVGJD5fdtHs9prq9voGBIcPtHEpFYNBPHpOaBcV8pvJolAQnXhWgAorAgsulMO2BwwIinRTnn3l/gtALskxu/EXFgwzDy+3p/dxSGgDLJtdbsexLbrMc8EBGsUeKWp86ccAVXNe1rhOZjixOQjM8EU5kASrYbvMAKcL5baXQ6vnM3VyLn2PvOK3v4c1FuwntwnbJnQzTFbtjT+XeOMOlzOpN5oXq47JsPQ1qD7akjCUfClHKeTze+ni/35kQMiI4rQ+R4YFx2yQawmsFO1Fq2ce5sskicms2PoYdIB7JcK261lVSL20oAXNbw/tjUgJa8qKJI4qkxEnxKGNu9T10iblljBthGoP5stuZhgalKWXbOU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's explicitly ensure the destination string is NUL-terminated. This way, it won't be affected by changes to the source string. Signed-off-by: Yafang Shao Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/pids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c index 9b898571b49e..23f488cf1740 100644 --- a/tools/bpf/bpftool/pids.c +++ b/tools/bpf/bpftool/pids.c @@ -54,6 +54,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e) ref = &refs->refs[refs->ref_cnt]; ref->pid = e->pid; memcpy(ref->comm, e->comm, sizeof(ref->comm)); + ref->comm[sizeof(ref->comm) - 1] = '\0'; refs->ref_cnt++; return; @@ -77,6 +78,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e) ref = &refs->refs[0]; ref->pid = e->pid; memcpy(ref->comm, e->comm, sizeof(ref->comm)); + ref->comm[sizeof(ref->comm) - 1] = '\0'; refs->ref_cnt = 1; refs->has_bpf_cookie = e->has_bpf_cookie; refs->bpf_cookie = e->bpf_cookie; From patchwork Thu Jun 13 02:30:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695927 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7EAC27C53 for ; Thu, 13 Jun 2024 02:31:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B8216B00A4; Wed, 12 Jun 2024 22:31:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3672A6B00A5; Wed, 12 Jun 2024 22:31:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E1536B00A6; Wed, 12 Jun 2024 22:31:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F03BE6B00A4 for ; Wed, 12 Jun 2024 22:31:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A52C3C0553 for ; Thu, 13 Jun 2024 02:31:44 +0000 (UTC) X-FDA: 82224289728.20.2A60C3E Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf12.hostedemail.com (Postfix) with ESMTP id D658D40004 for ; Thu, 13 Jun 2024 02:31:42 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HjAUXZAq; spf=pass (imf12.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245902; a=rsa-sha256; cv=none; b=aUwwcO5XFnae1t9UE29neDbjg3T93fr7YTIqkUReFacN4KV8aPurcg2PKlRzHBo9By5UUF 8SWK/vb7V0skEAy/SjGf7d89eUNHCs9dslFHVaTAkdBxvryhCbeWp3w23VCz7aPv3mtQQr EpKaplEpzf6FMAwezz95E4/8q7tyIlM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HjAUXZAq; spf=pass (imf12.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ei/8xwKAZ1rE7ZNdSGJjlup34y97vbtFvnVfEPyjJ8Q=; b=LBayF2tjcQy3+UiCbXwF6zcth8yRSG1bBMw4Z455eFXBKq4bijuHLoSgLFnJ7yUyQz2P7m z93qztFEaQbi5X64HY6utkjb7jUKDDyUFwLVeiqBiRuSzz0UVaV7AkZeFMoTWm+tcemr/i 3D2XELBqwxOeM7U2dSIGhcUCwjIX7+c= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1f4a5344ec7so3677495ad.1 for ; Wed, 12 Jun 2024 19:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245902; x=1718850702; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ei/8xwKAZ1rE7ZNdSGJjlup34y97vbtFvnVfEPyjJ8Q=; b=HjAUXZAqgiSyWk9jioQRt7b9avy0EYGxEyx2yZbioABYqgeSnvLOovqxS9u+VXyYyu 4PUBa1QYa9/K2iRHxnFDAxnIn1cGL5x+pbK+zYzD3AN3JOpdp1fPPXfGlF+e03QzJWIa MOcVzLIJO9SwHr+oPfipFxVJhJSEHbdy7jovaMWqdTI6N7saZkacXW+o9k1pQja6tnQR O7t5rTKkAFlpON9o6NQPtclsIEM2pJujFSx0W8+KkN2sQKZqSTNqQx40f/3AwAQilmG1 6b58asp3JY4hXf4LTAdZpGPHBfFwaU5Hkjyw75ykg9tRXjtQUhbJ0fHsa2mjXdKG0Sj4 suiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245902; x=1718850702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ei/8xwKAZ1rE7ZNdSGJjlup34y97vbtFvnVfEPyjJ8Q=; b=SniazR4HXmKb4sRSSlDc5OwhVJjw6sZdD2KSZgcobHFeTW7VZ3xHSHgKjVHAi1EdFq ufpaNLWUIrkJ8e9okLFqc37JzJdHVFqf5sDQ51bcV893SNQKKiVSJkGBUl5PwFJxtb1z ubIsdDd9iyBlQi0Ouedm0N6D1qPZHE0z/s4sIIeNVxA2Aqv3b4M7oFwk/7VwvwW3cGSo V6S8IQffLPPCnTp2qy9R+etfrZKc9U1iElRgRelNM5EdqqH+MBmUO28uWUVWVIA42Ib1 UvzvDPQB0C2IZNmVubE7BkQSt7sRJkDE6tfcYjxTcFZugqKvFO6+sMmudXHSF1/IyxX3 zdCQ== X-Forwarded-Encrypted: i=1; AJvYcCUohY9CGoTvQCfQnGcq6J3Z022jbTaw2w1SVLKBLRc7z6T5J0wBrlC5ezaDeIBdWS+4eOob9ge07wpIjmg1JvdSywU= X-Gm-Message-State: AOJu0YwEPBYXdVtY7SfwUM5QDCr8jMsVW2WeAo1SUtycOtlfOkbFW+2W WWdTsolmBspMUEsmeuMIcWUROu5IChveWwJOtM4dKowTx7NW/go0 X-Google-Smtp-Source: AGHT+IFIaVarDVsj1gEbMfPNFvaRxIMZj6V1FUrejF3TL24xnCXwEw+tDOS2CgmUK4jtVsLBUQ40Ug== X-Received: by 2002:a17:902:db11:b0:1f7:1d71:25aa with SMTP id d9443c01a7336-1f84dfbb4cfmr20547645ad.6.1718245901789; Wed, 12 Jun 2024 19:31:41 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:41 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Andrew Morton Subject: [PATCH v2 05/10] mm/util: Fix possible race condition in kstrdup() Date: Thu, 13 Jun 2024 10:30:39 +0800 Message-Id: <20240613023044.45873-6-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Stat-Signature: mih3woekreda7b8dtpsrzuosuw9q4hip X-Rspamd-Queue-Id: D658D40004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718245902-293409 X-HE-Meta: U2FsdGVkX19KcG9gc2Cvhk1wCJqz1W3WZxZSK3ImSN3nOgG7O/4eva4r6IuJfnY17KY4XaVyTuu3X48+9m/5Klh4zp5xyPe7jVN+TY5OiQnvvupBnGKoVpYH65VHkqQ8SVmWu+CxJNEFJBYgSjMhG2hf/lkR8Dnh2uhrCJpIpfmE2yl+f15gctSg/GbxxXjZbZBdwoe9dh00vaCwNXse+LUKYwI86e0fi9+XQpcZ2nBaBfrm3KnhrefYIyPMqym4ZQBLQZzMp/Zg53t3ZE1tJYGqE7kCj0DfT3nTP/GLuFkVyoCcruTqfeeioi5XrlLHEX6JyfBDbCdrNiqVxghx8Lx8uYfKq1aHfsvKWq/6f/AVUaYHwW/FLtiPoPk40bxAhTfy417YGC6lCmdqAXDyLBwCHOTENl3yHhe+iyvd6Pjp+a8Lf3BQoOkl/695ovzugjn+wajLlePm0veTRbXR44L0qlqGhtD3H8WRuO6/k6t7u2Vl5DxDlCmkr6X6nAfI5xVnq5sCo9/ZH17haU8cPJ22lXhlzhpW5TTzwGSmTRtZjj7maASx57038YHXhFcGZizegPnGSWEDPge0nyeSFlmDlB7DeIE7ORWLqUjCvbxS6Gcb628m7zaVOrp15DXjoN0o2icfAilK5XwYZvFJRSaJMV0gf8pAjaC0Uvx/w9oezuYPpNy2UwM5TdKD9O7pvmMMrRylJH62y52DYFKTZsecuiHo1TwK5DtGlr2AP66Z+bLLZtvI69dZTVsnBSApARtf/yGR8w9TobhveaMn7KhZQ99OE4bwj7gascDboGzlA0YVvzCparwevQTaf8pd3YJVUCkglJZHMX4udQhS5adXp0/5iJ0BhVKBE9WwDQBg0jxPZnTG1gLEc4YmGvsi/PQA0XyekkRZILS9+YaeXeaMSV/qMy9ra1ZhYPERSLZthO6xKtqE5VEKzjEQUf4ils2DglPpqwfoUvYuCaK 5ZQzjxS+ 7YiGQCaykNf4t3HPqADWwkJT2EUrCtJVginRGeW1df/qvk9VMEAKILPd00Hg6/OXiJ5C+fcIxjAabQCwazUsHQTWF+o0iJvVAOn1MLWPoTKFJu5G0O62ce4uSbj8Gr4yjRi5MPnpAqpK5WU4EOYXxDnWWUBeD9VdHt5tgJfSqATr+T9bAzmGiny0DYxDrmmxtYromkw/S+rN4xppUz2/b8HQxgG36nm0S9YEOY8e+GUaxC5eQEenmGBaDkH2DK6JxL3KiUcfqgh2LHyNYB3cG0dNzFGyHQp4EIcCFkO1GSPhNQkPtA5tgkdhdsuFLWb6ywMlYC75vqnoIVTA64Q+KPtYhUzsCwnwXDn5YzwVyNsXjC2YL45jXfmQDMT4xhV61Ife3flH4K7e7wMvJpTRgLM19F0jurHmA+z1POPMfN1nv02lEfvEiLVk0pN0Cl9OzimdMaz8K5tXfEMTDQL4oO5P/yf0jLB8PMW18TobnyXM7pmRVPrYAVC9lOoRm11QxSJkAZPT/WA326DM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In kstrdup(), it is critical to ensure that the dest string is always NUL-terminated. However, potential race condidtion can occur between a writer and a reader. Consider the following scenario involving task->comm: reader writer len = strlen(s) + 1; strlcpy(tsk->comm, buf, sizeof(tsk->comm)); memcpy(buf, s, len); In this case, there is a race condition between the reader and the writer. The reader calculate the length of the string `s` based on the old value of task->comm. However, during the memcpy(), the string `s` might be updated by the writer to a new value of task->comm. If the new task->comm is larger than the old one, the `buf` might not be NUL-terminated. This can lead to undefined behavior and potential security vulnerabilities. Let's fix it by explicitly adding a NUL-terminator. Signed-off-by: Yafang Shao Cc: Andrew Morton --- mm/util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/util.c b/mm/util.c index c9e519e6811f..3b383f790208 100644 --- a/mm/util.c +++ b/mm/util.c @@ -60,8 +60,10 @@ char *kstrdup(const char *s, gfp_t gfp) len = strlen(s) + 1; buf = kmalloc_track_caller(len, gfp); - if (buf) + if (buf) { memcpy(buf, s, len); + buf[len - 1] = '\0'; + } return buf; } EXPORT_SYMBOL(kstrdup); From patchwork Thu Jun 13 02:30:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695928 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B96C27C6E for ; Thu, 13 Jun 2024 02:31:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C59A6B0089; Wed, 12 Jun 2024 22:31:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 674FF6B00A6; Wed, 12 Jun 2024 22:31:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53C8A6B00A7; Wed, 12 Jun 2024 22:31:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 362426B00A6 for ; Wed, 12 Jun 2024 22:31:53 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB480160577 for ; Thu, 13 Jun 2024 02:31:52 +0000 (UTC) X-FDA: 82224290064.03.6607D60 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf09.hostedemail.com (Postfix) with ESMTP id 1834F140008 for ; Thu, 13 Jun 2024 02:31:50 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WY+v7k3c; spf=pass (imf09.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rI/qiwYumUf9WdznWs8PjjNV1aSEYVRYeuHEKQmKc7Y=; b=wjyw+TdY+gCnFmsaAsCudwZl4lzwOsnWuT59R+v1o+Uh/TDLQP4SjFkG8CVN5qlEVt9A1s PoRYfwvFrdKuoVX4+AfTnCXFNOYpWmwtKEiOibXJyos/kVNkCQvw4/lWPd4FjhdMv+lZMB YRjhuhJG/GbzsrK9lstvk3MzjPY2Hxc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245910; a=rsa-sha256; cv=none; b=uwOSS+/4BrTgMgntxWxM0o4wuQEtpWIEAIrO7lljRliuFShKBs6rYENgSivsTLRGisdTPR VE1A0hwkplmmkb+XGmK7MwLMBm8ZATcYAyvOazoeA98e6+1Telmq5cIL7eQ4fmTsi6WnR1 sSamAzyws1E3pP68Pw3aPr3Biej+aBU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WY+v7k3c; spf=pass (imf09.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1f480624d10so4675695ad.1 for ; Wed, 12 Jun 2024 19:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245910; x=1718850710; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rI/qiwYumUf9WdznWs8PjjNV1aSEYVRYeuHEKQmKc7Y=; b=WY+v7k3cLuKMpzbaUs4CWSwqE7SUO8OhvH+cpgmMOZS2P1zeO0S7mUJsKr91UOXujV RYJVLpfinACUs0lmJYdMhJ0oAY9bahJF76NKQuCVhumhLg8QlSoyl4SntnjZq16/JXCj 9CjSu6WNfDZoD3K6sKmTHfyBRxiylha6I6v+pGVFkIT0Y74WtpSpZ813xYOvN04Ox6E8 q/EW0R5dCKvn9DLXgddekMZILGJfpOoeBZ/8iyhHrHjXYq9sQQGgN6fvrmb37wN7j4wp M93S0vpE2xZB3hfElJlbkp1OvN3kXH/ljUwFgoGdrCGnEPlXrwXdnVEGJqfPR9XUjzRO 66uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245910; x=1718850710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rI/qiwYumUf9WdznWs8PjjNV1aSEYVRYeuHEKQmKc7Y=; b=U2Ae7M+ImwnAeLuBmMm81sZOZK0obTOrd15T5B0JlEj3kALOLaKvgPBAgIj6qaJCRm i/KqvUVphbLT7cfBAA+eE3eJzzqbGA8AZ+G6OpyoP5rMVPbhFkp2ERAd5KA1Bkmu7UuT 95w3SxAbt30+jWNHwTisbqbuuj3ybWWAnBTwwX5G7F2m20l0fL8wxXpyXq+/kBbCUIPp JkyYHDwgVu9KGag2KuWeIYQkLji+yZOmtEp7dceEwAQ/jVCyosrQMwqe9A+DehdRMzNw gzW0aZNGCjskhOBiECBDqCNJGp/iyOlYBslvgsmYvJRsXHVylrYnMLAnffw8+nMOROoD GMjw== X-Forwarded-Encrypted: i=1; AJvYcCWAqEjPcHpBr8mJD9SaM4+F/HGAg3RVzorDi3DvI8dyP/B2VkSCEb5fDYTzqBMKL7gNRfabwIRAZt77nwPoQORbbsA= X-Gm-Message-State: AOJu0Ywi8ip3UP7V58jnmr16luNK6iIzz4Ex/js/p3Cyl5lX6GO6ONdC 2/LaLQiOrBA8chQVM6OsaKgHKenktMifveqLimc7TTin98cARXtA X-Google-Smtp-Source: AGHT+IEHZPxKX/RP4SBm4cAnIghTfWMy7FOuVWWLSjXVUtL6OKmdClkmrYCnnZGc6EFhsF+GbPMHHg== X-Received: by 2002:a17:902:d2c9:b0:1f7:22bf:57f4 with SMTP id d9443c01a7336-1f83b730b3dmr43536295ad.55.1718245910002; Wed, 12 Jun 2024 19:31:50 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:49 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Catalin Marinas , Andrew Morton Subject: [PATCH v2 06/10] mm/kmemleak: Replace strncpy() with __get_task_comm() Date: Thu, 13 Jun 2024 10:30:40 +0800 Message-Id: <20240613023044.45873-7-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 1834F140008 X-Stat-Signature: zg7x1ip4sk4o35eggfy9re1s9durpfqx X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718245910-512165 X-HE-Meta: U2FsdGVkX1/lcKGYaoXFl/t1+0T/ip05YdSgQhtAjSvpLfxE6I/+uUbQf3wa1PMznlKe0rj7jgrtziBOyKTvpIfwXDvNaCz/LhBq0b6r6i6xCH5UMLhFoiYJ1F8wFlJT4Jqf1Gu5RyIAGLCadmFXOczBJRNNj5wxBZN0wiSOdeRj+yai7DGB4PDCfkgjuYTRA8uXISLVkK33JNcGvmt7N4jMfNSOUgZs6QpYtTROAmgvJ7tuDDWtIiQctRgt1l5mc445lqx8SL2VSl28rXBEnuig8XZSsyzmOgqzJQYpakn7agMKkL81X1NywllVTQIU+BSgNC02ldIRXywRMzcEnV3HZpwzkB32oJEgbfIvmnU/3mCJq2pcbWQn6wViPM6+auclr46lKg3WoIZyGDDyllnMrIhHB+OecYGxIjLcXx/avpi7IaS00sAZ/b1SNrr0HGrVz/9U0AtXIpbaYv3RM9ZzvSIeXtVBoRyFTqbJlBYPbVgNslTa26LM8M+5BB2mo3RXsmWB5eSOJi14Wi9hMN4fTI1OegNBudymksrBr6RLHTzZtvVqyJ0cQZFKgTc25P8MtGJJ/kIo7E1b/YCmMiemAGdy015J9FsoDCxc7TcaRgT9q0OXKsVoMR/PFNZgyZR1U8VH0PquE1i69RjLJRXphKe5/WyPubGLZcIpY1C8R1kH6A7z4paQt6EDhJYPyDq7e+G83K/aAc+5tNBbWSvSE+5uRwi94OtOtCIl6gOaiYIM8OhfWX5kqzU1EMFqJ429iKeLioI9uH9FxPdEs5b7jNhGZJ5tqBoL7hcBZ6giJCjO5ml7/QZFOnHxMc5pOj1dYf/KcxrPUaojeR9jBUN6VuJmzUHWsW/jwThEVFWfqZZyhWaxV0VhWDEtOwUJVxy0nA1uRE0bnD2dubhYqlnyadJbS7+VVilkJa7gMOQUpTPvUajvQt+LUdXB3/f4ETIRmlfSFU+fZKbY1KG ZkCexX7K g72ye7z2AZOt65KV9R0JBLI5gmRfJQPKa24/x9olR8/oG7Shxi0a0jI5HLr9xcQEW9tfYmM2j8UD3vptNQF3PfL8SiPckvgM3Ob7aKf4XWg7d425BmYtHBa161V4DSbBzbUGSREAJMPQZZjanbx2hzDIX2j+olDAgtjTjqWrmYvT/iB2RZEEuWen0BKAZaTuF4Yux0uv4zGH1AS2yxEPZExfeK8ALWTkx3wYLkBN6hb9BkUdXNIfiTepJHtXfegF2UbtDS9bcU3x3nB3remo0nNhmhJGx1iqeCqo6aYvprr0e3SDrluaHPupOI+4or+CCqHqnwEGiqNizaDO68nn9FzJK1/c42Dx7rjQEhlJZcyo0GSn54nGenCayTEtmcelvGUAMfRSbeGlDPEHfe7j1ro4mxOA/Y2O5550CtUPbvYO6ARTTFFSP5DwqySfMiUmu9WBeFRqeoN1eLUkkC1VsKFbvRJaS1IKrm2eN6LEPf+ZYXaQdMGm9Ey9E94lpwTIwy96jVHYpuQXrxYEcozG4XhLwxCaXhl2QKuh/eYisCfeXd6nUaqXrXL5tLa/T8Wt5ZEiisFcmi0dx1Uj6l4eTV7tocLB4qBfcTs9x5vd62ocd/9QH2zYntSRhwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: Catalin Marinas Cc: Andrew Morton Acked-by: Catalin Marinas --- mm/kmemleak.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index d5b6fba44fc9..ef29aaab88a0 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -663,13 +663,7 @@ static struct kmemleak_object *__alloc_object(gfp_t gfp) strncpy(object->comm, "softirq", sizeof(object->comm)); } else { object->pid = current->pid; - /* - * There is a small chance of a race with set_task_comm(), - * however using get_task_comm() here may cause locking - * dependency issues with current->alloc_lock. In the worst - * case, the command line is not correct. - */ - strncpy(object->comm, current->comm, sizeof(object->comm)); + __get_task_comm(object->comm, sizeof(object->comm), current); } /* kernel backtrace */ From patchwork Thu Jun 13 02:30:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695929 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6618FC27C53 for ; Thu, 13 Jun 2024 02:32:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D31726B00A8; Wed, 12 Jun 2024 22:32:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDD876B00A9; Wed, 12 Jun 2024 22:32:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7E4E6B00AA; Wed, 12 Jun 2024 22:32:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 96FCB6B00A8 for ; Wed, 12 Jun 2024 22:32:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 20206161818 for ; Thu, 13 Jun 2024 02:32:01 +0000 (UTC) X-FDA: 82224290442.22.304F2C7 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf11.hostedemail.com (Postfix) with ESMTP id 44BA34000A for ; Thu, 13 Jun 2024 02:31:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fXNGYZLt; spf=pass (imf11.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MqSWr/pfZwtTIRxMBQN6sYuDk2R2VvioPDgEPjsCPow=; b=K7yIcC0/jDow98mLC9Wr1fYsJwSOYiLRisxIUe3Bi3U6Z0P+Wmjf32NxgVDbJLEJdvu2dB yeQHUolhSBRDA21MY3EkCxeXm+vE3iS5eouWdxta/rmoc5YFjTsJCwC270ssoBOrV0qzdR EFwMv2yKFE98yhnahb6uS8BkMOY3ESI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245919; a=rsa-sha256; cv=none; b=yV4YCCE6JKfP0j5nBA9TJKFOu5pKWSYykzaBIMWcYu0xLDI3wmVXLHp/l3yo8yQ06SaR2z PaHQUDuk6zDnTMT16GjKocHfsUtif0rx4T0gPeo5u6AsoaaOBc4VPGIB9wRO2Evr0SIKBw aVTfvQdq9gT8Dl6ccuammUOcRvToeEE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fXNGYZLt; spf=pass (imf11.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1f6b0a40721so4016595ad.2 for ; Wed, 12 Jun 2024 19:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245918; x=1718850718; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MqSWr/pfZwtTIRxMBQN6sYuDk2R2VvioPDgEPjsCPow=; b=fXNGYZLtmfkwg6ZFzwrXkcGNwbyTaPBPYKOQx1hjN6SOZAq56HEB3yVWeFeY6oKFLM EWxh3ww2Ey0s0mszA67bLMQz3QE627q3jls7m2Ej292d0gTrrwtV0F8rF+D8iFzQkGve bAAVTJgNyKKP7esJPsJEwtxkyeSb/L+YVhLNk5Lw7gfbKtHT2xfZEm8Dp8dUfaZ3cmCY g9I/QsD7GuyUafe+Xm+ijqw0+hYXk3xRdH3qQ6+CAMqorAPHAJwzxDPtdI8PIOClVcHS ncIypKki9T9AKzaku+VvLArGRcc6clVR6tfmz8ouHkPz+Gp7wTmLTVRCZ/9I1mj4tb9G TWiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245918; x=1718850718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MqSWr/pfZwtTIRxMBQN6sYuDk2R2VvioPDgEPjsCPow=; b=dkmZGKOvt+EG1h9YGQ/i5VJPdIjwNK4cIBoy8bA+4hmTSyoa06EUYy5YY1A/VXGr4j zlacKASQyG6b+ROUvumFQwPdLOsGYFCYGB3YJESvYo0/Qf3l8N9pRVz7fWumS43puvJL B+k4tuNT+SR6R1Itr/1mUzkjwA2yZ0kISeI9iMPnENJRNRuUBzG2J2nAdCk1V3MffXQm Vc8hBF0FPQTWn2ah6DVtdR9rxb+xhW8tJsGO29Y+TleF+vr+SDRUkIHlhPZd4KjfI9FJ R+2Dd5hAhcQIBROrP2fegju8wGoZpoWp20Dct1YbmiWjtulE7KRi0ocw6Sobw/Dle7Of /ZJQ== X-Forwarded-Encrypted: i=1; AJvYcCVsGz7tmZAyPpK08R5g1W/34A9pI55ZgIPb3vatyYz2/exObWLXRZFtmcL68FaOwDkiv1z5bklzpjpRap1Gz6rtI0Q= X-Gm-Message-State: AOJu0Yw16qEr0Nyn8+vcviZLyvXbTSVhyWIBFAfz3kmfovnr20iWA/kU kvJS/81W3GHbjX/W3iWQ5OYsNkXu2jIBl+NgU13MVYPMLoj+KzB9 X-Google-Smtp-Source: AGHT+IF+JYjBn0OjZmgrQWU2wgsy8ofTmlVYqxM2KmLwEfyu1c8K7LtQBzzKH0FH1zCzrNJ76ASDQQ== X-Received: by 2002:a17:902:d4c6:b0:1f7:1893:2587 with SMTP id d9443c01a7336-1f83b55b817mr42002945ad.14.1718245918153; Wed, 12 Jun 2024 19:31:58 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:31:57 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao Subject: [PATCH v2 07/10] tsacct: Replace strncpy() with __get_task_comm() Date: Thu, 13 Jun 2024 10:30:41 +0800 Message-Id: <20240613023044.45873-8-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 44BA34000A X-Stat-Signature: iejoo74sio6xk9uhrzope19q35jmbn5o X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718245919-999372 X-HE-Meta: U2FsdGVkX1+fiPpXn8t95qBVzp/Se218t6WLAsJy3B1srwv1Rs+2EcawNJE9dDDHee5WqlVHjlmBztfbbQNOehHpus9eEDri60OqnsGoo/tmtwwFNC8HewouVXx4hVpaS4HyrQZC8dqytUpmoOjEcFw3w/+o7GVQ8pc8aXB7vZMlqwnbWNAXtsUt0mGEAglr2DM+Du2pAtoZswg+V9EEWIXaKAeeO4vPW7hK4N6kOddwj0+d/G3VL9hsioNBAxROpAvzZkapa+S5PmFO1mZlEczNBEoHKUUHwgdnV2GBr1Oi4DCbSPcsTghVchbJ2Z/QRNglmji2RbQAutV/Icebpv0phykLm5cuZqm1jMVqQcvWkIAjiTMGVY7iclWk5hGm/Cjrq/Uhui9r9i+XSka6mruKi+Os9kCZrBhs6dHHM/2xu3t85W3Gvdzl7142FkKH3awmyIOvbHFSGdDNh+P76AbtnKM9iXuafKRCUeCIubXt+lBJcHnQQNqKa+EwnciWUJAIb1IDV8+lLcFgnozNvqnKkIUfSyvNMor9gYO0z+scyDIU+r5lNpJpNxInj4lG2SloCycEnzTdY7vEEujHTBd84/yA3OiuoAqViRhzRSMwYYJrN4p75rJlk7dH8tykeGRfSnNBF4acYRwSUVJZJAWkXparYBcOJ/epkRnBMyebZZNf4H9I3atDSMIkJGp36inPx0qEIAi0A7tv3Y5eiGcoI/fA6Vsovk8LisPKYieAfOh3VaboHCalr+K8+XlR32g2MFJCYh657Swqmuopc+2R/kezFPGHrZ9V3bjYZDL6RDtlhX5NsIJHC0IxILSxit4MesQ9vYW2vwlG4eISnDzeeCza4xDYbrNysuqET5ySO+SLekIvwPmOah6B8IGTe03s/Ta5Hj6PKoSL9TG66hkwRMjMEVcgPpXysMC6FomG7W3WtCGMy+XbXxrDqMCA/JDkm0kp5g6jVsO+6K/ hXEXoOMp A13xk74odJiQ1bMgPu3HDLRw2UX+dIK9jR3/+n6JGOZIl/x1cCROkEaW1sVaxaQnVln8R8CogAuoH5ZBS7Out/iD2vmXxr+b8suX+sExXFCCwvQGm5zFA9A+cssxxCn471n7WahDI3EOceSMmGSrzxMHm3ZXH5yo9P+tBXVa4gm+jC1bUUBFpvdg8/QyvvHphUfVAjuSLWh0tIt0xuLfzk3Zxs5j/L0RagAFHU15EoUA2F19Qc06iY0mE5ttnHmo3tcyBE+MzLwCdSBDrmXWNK82aGzC0ZPEaajej0zoBr6CcpXzvrB1MlUhM14DaOlMrG37DrxOesLEvAHQvbbuqbbMm8Jb9pc95uLJ4Nj6wOtYRZ+FQub0P49wUxwo9cg8kVRFRwtZOaOt/MevYki+zFOdEEoMSNxVtSUVuToQ3BzTkgC7HtQ5q/AQKODX2riNdBuvSq2k4tX2roY6nVCRLkQkMDI2qDuQ1yrXNZ6gXORj3ZjuUzu8Mw0WXFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao --- kernel/tsacct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/tsacct.c b/kernel/tsacct.c index 4252f0645b9e..6b094d5d9135 100644 --- a/kernel/tsacct.c +++ b/kernel/tsacct.c @@ -76,7 +76,7 @@ void bacct_add_tsk(struct user_namespace *user_ns, stats->ac_minflt = tsk->min_flt; stats->ac_majflt = tsk->maj_flt; - strncpy(stats->ac_comm, tsk->comm, sizeof(stats->ac_comm)); + __get_task_comm(stats->ac_comm, sizeof(stats->ac_comm), tsk); } From patchwork Thu Jun 13 02:30:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695930 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA50C27C53 for ; Thu, 13 Jun 2024 02:32:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D1096B00AA; Wed, 12 Jun 2024 22:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 082566B00AB; Wed, 12 Jun 2024 22:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3D216B00AC; Wed, 12 Jun 2024 22:32:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C5B0C6B00AA for ; Wed, 12 Jun 2024 22:32:08 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 86F6A1A0236 for ; Thu, 13 Jun 2024 02:32:08 +0000 (UTC) X-FDA: 82224290736.23.CBF6F24 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf02.hostedemail.com (Postfix) with ESMTP id B67B080002 for ; Thu, 13 Jun 2024 02:32:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ne3hgYwh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245926; a=rsa-sha256; cv=none; b=q85dmEWD58vfg5i6GKc0YmJdejEjizLBZq38bXcEAy6cgI2sfnY9VbfE8eU4PXYbV2ZpFi JML9cQsNOgNrsFLLO/He+eU2kv74Z+1u/2nl372aEzb0K3gGevNwW1aHofJViSQO265Jf9 4exGigGFTqEfdOTTJfytyUhiq0cCR2c= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ne3hgYwh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HQT31JSkonb7Xmqn+k1uqrjgngeoHr6IFKrX/+KN6Ok=; b=wRYslaYL7wchOjCE3EtN2CpKBn/VTGjeZp5qlIfvk8asylzi2u/9GUT1BY4KsIQI2+g60l KYenmGSbBFYsjVas/1nLGmu/zqp+XIAj1rvpxQYMRoraphueUyq/mtvYBUUa8xSvj+V5dU 31WxF2Zazyq6zFBFBluwQz+kx46fECc= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f44b5b9de6so4608865ad.3 for ; Wed, 12 Jun 2024 19:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245925; x=1718850725; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HQT31JSkonb7Xmqn+k1uqrjgngeoHr6IFKrX/+KN6Ok=; b=ne3hgYwh1PtmofVFFA8ZcUFURtp9y0lqiawewTKpz7BdUd1yK+8PvpEdEwP1mWXhoB SdCZerH5CnpQczvMOpJduHCU1tnfLnAPMCkIsANcpVS3xjCyrT97Gn3Y6y1FfWdM++2g aQ3lQjscjTAa3m86IaXH3nK4fuxa2Mo7ANAtu2EpvJ/Tu8Rp++Bku75iyyCWfz57/Ytq UlWZkcuRD6SQF24/IWxIO9qM58YgcfcIiFYFsvRw+gRucyAEGNMQIGAIdiSN+rU4NXiz XEuGwXN+jpLPN+p3or7Ft6ZRkBmkvg9uoOvbbwgPqYFQ74qXur1VnCq1PRmmt4iWI72n q+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245925; x=1718850725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HQT31JSkonb7Xmqn+k1uqrjgngeoHr6IFKrX/+KN6Ok=; b=UOM+NFHGwPACEvqUdIu/axpeN3KvY/ioVKweBYCF6rQWBJJELqG8epuhVQUJCW/VZT X/gPN9V0K/e7I8hjMyg7A8mO+uWZi31rcyfNkZppoMYScVwni6VqhrrXu8bxbX1veqn3 TsFyGI81Clr8nAUUwireG3kDT3xaYaWoNWncjh/ZZIozBer18GlCPfWPF2BngUmNJgvP PMVPIAhk6lq7xcsKff526RzXVfcNnZrIOgRnQdlOgvXPlU+BiAAyi+hhxKDBoORh+Xol OQi+ZILTlLyYujgstQRN9EXpED33vNSLHrYqDfJQzTwP6XeZkLUVKxVnFA+J6+oGBmlR 1dXw== X-Forwarded-Encrypted: i=1; AJvYcCVwq/bdSDv8D3B+zPbe4lKWmvuHmd+/mNNFAZUrEzZv1TrMUadLEKMf0xhQYd+u4vIkYwkBd1mGv5DzVHccuTwUI4s= X-Gm-Message-State: AOJu0Yw0eepXCauuY3XtlgYTKGhS2Q/8bBW4HKeIUnHGtzYwotuXE1yK IMDpEntiSSvqLEaIyJyFmWsNIol+dnUr9hH7UdVf3uM/0mUSojxV X-Google-Smtp-Source: AGHT+IE/Thj9zy8OzNEgltY85A2YMlP/9PBe6RK31xV6C4QSBrLzPw+agMFJyhDUlBI6xydC6ujXaw== X-Received: by 2002:a17:903:1c2:b0:1f6:89b1:a419 with SMTP id d9443c01a7336-1f83b5583a6mr41814045ad.17.1718245925584; Wed, 12 Jun 2024 19:32:05 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.31.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:32:05 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Masami Hiramatsu , Mathieu Desnoyers Subject: [PATCH v2 08/10] tracing: Replace strncpy() with __get_task_comm() Date: Thu, 13 Jun 2024 10:30:42 +0800 Message-Id: <20240613023044.45873-9-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B67B080002 X-Stat-Signature: 6e9mkmftr4wsni7hqumbekaodjfxhhsp X-Rspam-User: X-HE-Tag: 1718245926-903744 X-HE-Meta: U2FsdGVkX19Yt4OKkx38jE6EpGMh5EOf3NfARZLv75CP/QEWmYFstkkX2XNdkAFZ6BjroUYLJwFdn9KPzHGwzY1kAM7vy9rO/DX8QnYW4d9MN8Uyte2+dFaDYLkry86+LBhj+quaRktz9zd25UVK1M7R2XzWpq4DLB8Xv4OnztRfk1CQAfO1OZu2kSRtpavYsYdiqUm5Mb9J/rscWOk8BHEQSMWKxERCaTnlBWCSD+Djuhcd71p3X6fdw89N5wzhU6l1BbuCEOVsmBtZkCZVWNhanWmTpfse2ur9HKTm++AzBe99Yys4J8OE+HpMqSWfDTXbY+1AEojyw2HqiYMmZX3hrGyht0bYmZSGPj+ThPMbKUfUHSJd/DA7j1bcSNXQhsfnjsm8rdDuI/BdsefKkNd1jYP+VRLb+53Z6RVvVE0Cas1ZFjAGZvnW1S9Z4oBHqM49VmdM5cY4OB/Nn165rpFMxDuu6Tbjl9cYJC+NPzW3KeshqYas2NQ/9Cw3oGjveuGOt4NhH7hIUkDX2Pa7qYZV4HqlLwIAyt8fRN9RnF0GbOimhDWqWmWo9YdITOfi9sAIqzwnTFEN5J4V0HLc1sryvDX7czxcJCZaX+7++RnQ7XUIQOA1efKx3mKLhqIBNd1dmH8j3qR/KQMQmVoI9kTmd6kxUlkwqMc1YPQ0/jo2qMtDXAyk+YP/p59eHRH1/RcTgAQ7Pz0Y+NUa4JGLI/OZrM3TfoCMKJETp2eYxHDQA3dnq5WdPSMAcPj9fO6ypi7Rs7TePJpvo640/6UFdHYSUczb1ZNBYyki+OVFBa4kRVEoTojckpStGSPg8FVFJRbCw1muWuGRQqaByWptELDZICO+GpA10fV6zv05GHHQmALNSAcrl/gCAe58rhggHLqqid5sDInAw1qrmRPvYy0gxWXdcEEq9hREV32YNTVQRHTWioq/9WLyfkR4jYKj6bvBiUxu77aP6n8giwL WRn+LGh8 +x3KGwK0PXHo6Yn352WOGJ0fU0/bPnxKFNm12nuf4JeElEN7KxilYwaUv2KyrZxmwiZb3tsX+RAPgooBGnXgwUt7WKwu1V5cHPs7MHm+Cix1YOltyBLCuepw4DaTObFpBs/g7mvojbQzJXewuKQ+nc1hWtwHlBK7wpqTzrLZa+n4uGOqSM2fQ4nDc4B+1x/LWp5XPUKHISShgmo5yBTnd+QpMUIuuXRACf0mFoTgCaPSj43Mt42oX3TEWxYhTDpj56QxusHizQUnQf1GxKYunRHe0f1eVz/z0Ws5ZLsTcI+1iNpMN/XIxYLbD9jERvHhywUVbTS6wVyD4Sas9bi6k6nTItqjEt3NGmdEgF9i4JW149+Nx/ApVEwEFb9bP8F6+UKpmcPtk6OMv63Bq36tchir9tqs7XehnUYZNilkaC38Rll6Qz4c8BaWBjA9gqKsfg/VytZWnDNxlFZURC3Xv/jBp05MTZh9mrkdlDYtoIC16sYKEmli226XCRfNamPgRRSmwzi5vBbSawY/fafp/1vgdDPCFEUelK71ueuSCK8zzxiQUvzeCeAamLbon2ch5QmF9zjaU2kh7LhRyTHdJvox2S8u+Z53oKwBa2BSP9qi6Jg4RBcYqOq5PGyULh8XyKt5f0jMJTY+ozMkps+uCaBmzTn1yJEI7a5750pC64gete64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000845, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Mathieu Desnoyers --- kernel/trace/trace.c | 2 +- kernel/trace/trace_events_hist.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 578a49ff5c32..ce94a86154a2 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -1907,7 +1907,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu) max_data->critical_start = data->critical_start; max_data->critical_end = data->critical_end; - strncpy(max_data->comm, tsk->comm, TASK_COMM_LEN); + __get_task_comm(max_data->comm, TASK_COMM_LEN, tsk); max_data->pid = tsk->pid; /* * If tsk == current, then use current_uid(), as that does not use diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 6ece1308d36a..721d4758a79f 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1599,7 +1599,7 @@ static inline void save_comm(char *comm, struct task_struct *task) return; } - strncpy(comm, task->comm, TASK_COMM_LEN); + __get_task_comm(comm, TASK_COMM_LEN, task); } static void hist_elt_data_free(struct hist_elt_data *elt_data) From patchwork Thu Jun 13 02:30:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D75FC27C53 for ; Thu, 13 Jun 2024 02:32:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E3416B00AC; Wed, 12 Jun 2024 22:32:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BA386B00AD; Wed, 12 Jun 2024 22:32:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0207F6B00AF; Wed, 12 Jun 2024 22:32:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DA6496B00AC for ; Wed, 12 Jun 2024 22:32:18 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8B2EB40281 for ; Thu, 13 Jun 2024 02:32:18 +0000 (UTC) X-FDA: 82224291156.21.EB4848B Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf04.hostedemail.com (Postfix) with ESMTP id BEB4D40002 for ; Thu, 13 Jun 2024 02:32:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iNYvOdXv; spf=pass (imf04.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wLV4tdtvKwjUMxvLd3MjEerWvvi0S3KYqORy/5kgs/I=; b=zYNefCzM8IzG6jrCKD74Sb+3ZnMl/55hMooTl/2Apn1XVQH/pW3rkHEs67QMc7RFUOS5Z8 B7z91y0BzaEe4Bt7VRF+if8Nw21hIQTTbbH0RjFclsvNlSOZ6WRr5tiOqiMSxqrn/19LUU vz0dbP+UKojQ0NOHrwyG3pk6K9kELBo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iNYvOdXv; spf=pass (imf04.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245936; a=rsa-sha256; cv=none; b=PN67tGB9G09Fr+P97v5vwQYRj/sn9iZUDx3I8ib1wWaG0Lhl0Rs2ea1hm134nIvzWsHgAT /oBXMEXTB5dbSSLLFhoKAuPgkPHmnnKVQ7uAykXbMCTFAY+BY1c/pkIm4dvTyep/j6uawN GTOfedPD/t3KrRLWLtRxKu6TyT+hbbA= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1f6559668e1so4960665ad.3 for ; Wed, 12 Jun 2024 19:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245935; x=1718850735; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wLV4tdtvKwjUMxvLd3MjEerWvvi0S3KYqORy/5kgs/I=; b=iNYvOdXvEtg0CpOK/9HQpPK+g3oCSAJk02Oa0T5nhMvhfpqgK5nGGynU6D7281ywZg BjhYzSBiyFFVKJviNidS+TiAzDcTziB5TXPtnwZgWIdMNTTjJ/AajTwJyUBb3lunHK4c 4RnYdHIbjSnz9UdXKW9HLVrONok8rlat+6cmZNO5kQrhmOQO7I0OwZx5KGagTtaJ4hWe 4KmwjgJbJun2Xnu74iMmu5g2Hixn4DdUAGYFEVEG1y/76+x5V7YgrTk7bSwf25E2+JWF XvfnKg3REtcoRqk/N9cUMM4iqXAzaWHw7iVMRA8VGeML6XjqEgXMczrIxSq0ETnwU3d7 iW6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245935; x=1718850735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wLV4tdtvKwjUMxvLd3MjEerWvvi0S3KYqORy/5kgs/I=; b=aMp+ApCcEQGPr2lieQKx4MbdB9zRhrDZmoPNeHpWkU7kJc9LdyAN5URLeIVRKrcmY+ xp+W0sShQ3hHqs7QRHM1vgGqPnvKxFOEIegqx6CPg/bogj+lRtO19Fc5sRRr4faQyugo igr6HFQkR8Vg02btiTVnRxG5ExzJF2HFkIVczXi62HxKWaGFtGB5U+Zr4G3J86WXa2kz Delp3pv42NBsjSBSd4u1t8Mz9Mr5RbLdptwFO423rf4EbE/pL1mn0y+8o2dqerv39TJs 5jS9hPYmEnaDCuuRxPrJpo7FOyCt2Orxd7ZfMYh1eXGRvReK23cQYb+53haI4xE2in7F M0iw== X-Forwarded-Encrypted: i=1; AJvYcCWe7Mgd9gjQTJpdcBMuN9yFj6HbiNhjWLBCItnRZeCoV9CiV+3TTPBWWXdRxuSN2Tm4UdyJD0dINjdEi4jMv9dLVMQ= X-Gm-Message-State: AOJu0YxdoBuxzKue+MEPYwnmTYYHVDoz+wnRe6xE0qW7HXQXvght1Ips j7dDOPVlFJ1UhGkyxuOYVNcpPb/o9bAMd77rtWB8CEYaB10G++X6 X-Google-Smtp-Source: AGHT+IHU8nljO/XpjX7VaEB7PAOC5fyOplOexRJH9EcW/3foBQqPSTf9j2DyRFgOTFj3wqtthRwoDg== X-Received: by 2002:a17:902:d4cb:b0:1f7:3763:5ffb with SMTP id d9443c01a7336-1f83b74d134mr37873815ad.59.1718245935611; Wed, 12 Jun 2024 19:32:15 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.32.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:32:15 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH v2 09/10] net: Replace strcpy() with __get_task_comm() Date: Thu, 13 Jun 2024 10:30:43 +0800 Message-Id: <20240613023044.45873-10-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Stat-Signature: 34gxznkg8p978im676qow461x6mzxi1t X-Rspam-User: X-Rspamd-Queue-Id: BEB4D40002 X-Rspamd-Server: rspam02 X-HE-Tag: 1718245936-389347 X-HE-Meta: U2FsdGVkX18c9My2m5qGugVRhqkzXexsvrD4KMaDs/ufGoheove7EtBrEJksETRS5KkBiQ+fX/4s4oLD4Jn0Nk8U2T7kfgwa5rWrJ+zPcKLcw9ynST4ZbFmyVANP3beenb7a8sGUDR0YMBrW/ukARPHuFJ9OozcNhQepWzVSiOv885Z2Zu3PLn42qHWRIbeRBx5NgDxfz6Hj3MiwocPzlO+DoXAB3ibsxFw3hJtazsy8sffvqKfJMh5NdvTWw50Whpk66+rS4PRVc0hveTYxgfkGhpWTpVhfANgQ+RNjkYSvCngtafVxQFwO2zeQEhYXTnZKoDX00ONwpuB6fPFD0kxjfQFW8pwqPGBusi1nQ4psSwEUGbVzDTQHAWk6LhEw39VvANwY5ISR2zUqswCcbV4je+FPEsB6P0AuMBTkzzMPcTb2lNQ4mbUXI3GcIm55gTN/rMNFMj7xXjKIVelmrJH98BjAinBg6eYtBfS+jars4qK76qHzrwXgQiy47wqccZLYxVlr4IyK7mV5E3Ix/tw+yMtUad5+lJhD+rmrupkCcbFCtp0QOZqSc3E/64qOn/CIpCln6vyOobL5z0wPL9nEElqwLlD3W8EjRMhV8ZtbcyIPuBKYBanx8LgsHzrN54LCOquLWjA0RnGKNWdJloiHkczL9RYs2C3wNnWxnI/NtHNF40Mco0z8+JfOyvh9ecutdv2dZY/q6pWjGfVac17p7/86GRAPaQZL7Y9fRZaWc2bN1LtSBeQwgJoIvLVeoQfTWPp1Wvtj0m6Fhoq+NX83tiA/w58o488rZHrJJJM2pYuIxlKr0GPMa8AUxc378QrMIXBcXcAdtM4npAVsOUbYDjn16mVTmir+in/JhXWnds7K8dENbZbmnvzEhRQr5/uQGsMuevU17ZBKI1EXvRX9kF6+H9jrOrHmIUCF0WOq7FFoO+LZjGo3/DH69uw2rh+o8uX7eN6tGidLzAI YzS1BSgq 1wN4umq9K3lPNeCywjmwBrlGQIdc4ARbCtI8Kt6GCEg8om0UbItn/aEPt+/03PDhpLm+KT1pnAez21glp621AH0jxTp3iYtYdyc3W8ZSqdX6O/hUdPoyrI4F0WWPIB/kWA3+AFTm0ON9BtzqXqvxTrbhddjm5NPoUj+L370cF0FjSVLPd9YSvGABumpRoE9lidjHhuPIJC2LROki47zg3G9oXEpHr90S9ImUgEpmX0MNiwTOvlUKu7j3q0IJe3r6Zxpmbu4PrpAxduRAiqL6y7McCIOvjbulfjl/7oWgfdS4YWKkUxaR046zsLRJ3kHVXmTB7WkIkGip8bqymCxeUYsgX5zjFWzZMvXR+8eK2ZvkeeDyTfqh9GYM/Q7eakW/SsrnPF6FsDStYtKfW0F3rJOQYhtn3QTH6FMJ/OUcCEkCURtpR6W/ZZHy/wW4Xje5NBusKTWl1EP99OOQemDWhew4XevR37G/8zgnyaAL1mujFrYVmj5rOGAQx8IwyV+U953iWLOg39Ig7wG51kWacR01zD56sEs6DVUinXb8TzPxWsEi4nXdnimlzUjcZvWNXUX1lOI+o6fSOAfxsBT/ZNPLPTw6S8iAPPDdEJKxWAJ3PdygBJCgp2jvFbvAnMUijDNGBgmxlt3ElXB6m5JPzXVWXOi4XGeQsg/SC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To prevent errors from occurring when the src string is longer than the dst string in strcpy(), we should use __get_task_comm() instead. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: "David S. Miller" Cc: David Ahern Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni --- net/ipv6/ndisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d914b23256ce..37fa3b69df45 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -1942,7 +1942,7 @@ static void ndisc_warn_deprecated_sysctl(struct ctl_table *ctl, static char warncomm[TASK_COMM_LEN]; static int warned; if (strcmp(warncomm, current->comm) && warned < 5) { - strcpy(warncomm, current->comm); + __get_task_comm(warncomm, TASK_COMM_LEN, current); pr_warn("process `%s' is using deprecated sysctl (%s) net.ipv6.neigh.%s.%s - use net.ipv6.neigh.%s.%s_ms instead\n", warncomm, func, dev_name, ctl->procname, From patchwork Thu Jun 13 02:30:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13695932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49B3C27C6E for ; Thu, 13 Jun 2024 02:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C9B16B0082; Wed, 12 Jun 2024 22:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 479726B00AF; Wed, 12 Jun 2024 22:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A186B0095; Wed, 12 Jun 2024 22:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 125C76B00AF for ; Wed, 12 Jun 2024 22:32:28 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C8C1A1C2DF4 for ; Thu, 13 Jun 2024 02:32:27 +0000 (UTC) X-FDA: 82224291534.08.5EA0642 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf13.hostedemail.com (Postfix) with ESMTP id 030072000F for ; Thu, 13 Jun 2024 02:32:25 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LogUCoCz; spf=pass (imf13.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718245945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ByPZqEdQZBBtzQ6Ut5Ro8SR1Vw4SYts83oZvgSR+UR8=; b=DMbRUUNM3GHvX0o40Hy/XlzijvFqfCYVkn2xG2ebrZE4OfZhYO59601N8ugOZD3M5SfHAc 69dOhPcTpjVqKJmKfW+Cx7T/S5inGwlKiiimMnsT6ZGibeFrbLYYXXDZh+UsrjJOl75Mgz p6A9P2MNGuo7Uzr3l3mKlL9sOpbJsg4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718245945; a=rsa-sha256; cv=none; b=3RHZiczPKVp8+KasQg+Yk/qEjgxsPbKPEYbE1S/91r8vaRbyQzgv4/v2/zNfb5ED1U/wEv ud8UwYGWg8WMlg/pxyYOMGvTCGKs/NbFpnNUvOnSA7vofTfqFVBjO8+av3sdUeKgykJ0BM eikAWBqUSjFHXiFqkFKiLYviFvJyINw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LogUCoCz; spf=pass (imf13.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-70413de08c7so347970b3a.0 for ; Wed, 12 Jun 2024 19:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718245945; x=1718850745; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ByPZqEdQZBBtzQ6Ut5Ro8SR1Vw4SYts83oZvgSR+UR8=; b=LogUCoCz2U9U4bpIjRGrktc+Luc4gyqtNSRq5CedQhNLPwG6UQK3K37M8tcHcXFL3a q7h2CpRdmMkqsqwpKQRHtjznxGf1uRuj5F2z+IQYmIKdxVYjEchWf+1blJkB8PkbCOHJ Bj6EKXDhOLgv33bJJ2JpsZkhS3Kt7eQ8JzVvRQJPuxyBfYfcT5KdZ7hvDNDQaLPCGNML rw2I4sS/kf+avZOEBCGuR+DZs7wJvcOqhSiwyUJpfWQCQWXA21uRERE8FjDHGX31cCLI Vwmuoi7psuSPzOCvDmk0RcNcNfsvleyiPSMs2EVrR1XQkVndCj7wKpfq3aAXywv83aqt KUbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718245945; x=1718850745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ByPZqEdQZBBtzQ6Ut5Ro8SR1Vw4SYts83oZvgSR+UR8=; b=Nnpduve28xLQeJZhk2BADB5AJX1PpDPZTdUQ6r9AMWiqljrlZIIAye4g5bzoMIjLaB K9VRDCa1mMQzXjzeWcPqkk/BvOt1QbtkWV377fUFaLDedWOTgFxDqkluwL3h7l9fZRpJ v6EH3/ibi5fr6quNmzMtaAA53nsxT0gtmYOhPxM3AmQZOVVzQRDa8N0ORsEmI9HB65Xx hIPXBGhe6Th60Nh1sHAe3HVIuM9TNT3Jrarv1kCODiDiYRS6J/DmHxlit+fVLXMAhVs4 A+VSz5jkTM4miY7kjzbnazgPVeLbYVv7hNhAKv8hKhdrk0zAcY0o/6iJ7Rx5yUZ17kZg u1tw== X-Forwarded-Encrypted: i=1; AJvYcCUJsUwJ/L3zg0RyEQfiFqsjPBHcnYYyrR8X+zsoPVXV0m3DkhHhbnrQo9MfGsTlxP704cNC5ORyPmrVV4MlEMmumoA= X-Gm-Message-State: AOJu0YxV8aPe5af7xa4ftY2kg/ArrhBFODhoqPlcM/NRkbrXv57naoXo 4QwB/d9J70VrrOq1LYcSFLYOoyDPTx/SBnoDIafV11p1KJcMX0VX X-Google-Smtp-Source: AGHT+IE+I63Tcz7mU3dbe4p80REUOFhGXlU1vxQyrrx4b613sOPf+IM/heFPON96TqCsfc2pgVpt6g== X-Received: by 2002:a05:6a20:840c:b0:1b6:c527:7e42 with SMTP id adf61e73a8af0-1b8a9b1eb09mr4050153637.3.1718245944827; Wed, 12 Jun 2024 19:32:24 -0700 (PDT) Received: from localhost.localdomain ([39.144.105.92]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f4d159sm1755695ad.289.2024.06.12.19.32.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2024 19:32:24 -0700 (PDT) From: Yafang Shao To: torvalds@linux-foundation.org Cc: ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: [PATCH v2 10/10] drm: Replace strcpy() with __get_task_comm() Date: Thu, 13 Jun 2024 10:30:44 +0800 Message-Id: <20240613023044.45873-11-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240613023044.45873-1-laoar.shao@gmail.com> References: <20240613023044.45873-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 030072000F X-Stat-Signature: fcexyteu4unmbgeomb16xib61tgr5ie6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718245945-51171 X-HE-Meta: U2FsdGVkX1/klxz71Kgakwc8YGcE/wCtsiJY+T9o/tj0VBxdl9BsC9Tib+RysLwNI2zbPfzZhl7HWp+AN2wiaIxW5Hkg+xRrYuWz0e9KdMzx3k2Ua5dciSth8X5Pdtn68mdHuy8Qm7plJv7eZFzUAREz6c6JecwNatvIxIiOzbUQMiy3/Y1LbxCvE/JWxlClpPNWCUybgS1ujBxQ3g3tc1P+xNTvW5+lu9lC9KMBhWjT9OOoVZAHYLwOtoBGgCKfFV3MTKLQP7SNhesgZla8yzuN5V1Dn7UroUiRclkqYvyLX/uKYZQUdMtyXIfuhIyIu4/+uSuL/4mEZAivAAkyL4DjyzAfQxxhML+qGCnE32tJ9AmAslp1En6MGUGYDgtAPUXK5ukqsuVLXOMHZS+en5rVh3WD1cuUJmC1irvKeESUIEAJx5/PABQ6lXQXds5OCKSJg9GleHTEhtVnG25Vy0v/1+RScKNLlQMqMobFtzShcnABJk4DHhyNab0VYtuyCzmrUHpu/5bwXrBE8B98YC/8e7D1MEI9OdoOEitXHKLiaaa8ID6okpLtTU1L3HANMjXCcVIE22TxuvwugC6DsMRQ5SzroCP9dGNMkoAYiuRivi7mWvVGwbCqsRyDfCMPhy4LGJK9z0eFsWWV81SwwzeTMCeDlu6JB2T6P8bdLVbqy9iVa2nI67dJT9CNI9+Y0oVe8Lc5LV4cyphVm6uMgF3c+kJFWIg5SJZwEzJng4i6yLE7uB/OVqQvFq8UUkWdeUCHLsiO96Ym0llSVlzjodwIxeQ2TxYiy1nzgQm3lnAs4ejxk3iaaOKDZ2qG68Mw9sBfaTXFyW2K36l9UY7NOhb4iYvu8S4d+MTv57goEeVLitgzp0+7HgHGpitLQ7Mm14RufluWQ4E+nmD0xWqjGDpneQBG/zzCAGX+HQbBMZ3qaYKDWJ/k72c4HnrgCtW0fB6YF5SWSSqo3xH/qOU Q39AFRGp HlITjSkWiFTk7ucGtcfBx1QsFBBCq0zSfycUL5lfcGO+IRkgiruuKBCdoV7WqkGUo5kDGoz8yJ93g2kV7JphKMy6ekq4FU6eeq/dBDJQWaGFcGgiw81jJHiuQUhALq3E2wEphHaZPZIyQytMCX5IEhuMqdBxRSRSRM3cdDjrnD7YUc9+HSaKwcLxk6TvGVwB5AUv2DIDrteRJIj5IXsPJG/e9DVpsewyToQIg5xnzqGGvq9KFCfM/fx0NsO6/sNmCooiEfvzB2L+twqz2zP94NwZG5hceVXhh+ghyjhpz0b+s6xzlEHsuNxnoafSe4vqx+N86h/9j2Ow5G5HfbodkfNoqcT78PLM3nzRxon2Mtb2bc3++5f1PeqmXaAUjJFmRJw2n9u6E61EVU/Z71G25upTRJaOlR6LW/s9wKPOcNikihLeEPuSIn2TbG8imG4pGQAV18oB/H2fDtX8n88Wc4SFg6Qd7seo5wx/qpiYVP6HFBzJ7lQ6URfh9I2CbVk0r4zo/2bcA30kN85mbPc9wu39hCr26k41yfztsfvarWRG/VrOlwDvx/vhE6BCUbq8rGLqmZ1sByDnQVwE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To prevent erros from occurring when the src string is longer than the dst string in strcpy(), we should use __get_task_comm() instead. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index 888aadb6a4ac..25262b07ffaf 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, INIT_LIST_HEAD(&fb->filp_head); fb->funcs = funcs; - strcpy(fb->comm, current->comm); + __get_task_comm(fb->comm, sizeof(fb->comm), current); ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB, false, drm_framebuffer_free); diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 625b3c024540..b2c16a53bd24 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -1411,7 +1411,7 @@ static bool record_context(struct i915_gem_context_coredump *e, rcu_read_lock(); task = pid_task(ctx->pid, PIDTYPE_PID); if (task) { - strcpy(e->comm, task->comm); + __get_task_comm(e->comm, sizeof(e->comm), task); e->pid = task->pid; } rcu_read_unlock();