From patchwork Thu Jun 13 18:07:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697251 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA3101482E9 for ; Thu, 13 Jun 2024 18:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302687; cv=none; b=Ly8+ZmfCb0+nShULR/PeIXYxtJiTpjQKvJw3l8v6LANxAZ+vvkmXDgR75MEUTAqmz5TZbdc6yn06KrTdo3urgohROJ7Fu7o8XEK4EOXzbgpsdKoIl9qAsqfLDQSv43pFmsPUqQTWMHNiS0XMj3/W8waCDQ6Y5YPCvfxWSPnFduM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302687; c=relaxed/simple; bh=bOUOYj1yJWVfslyu9pCNZsN+CqdeAchG298E4ENLkPY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NtzNnqzhWZcRmVvwLKPHXrAgZvuU65q54AW8iMqHznCK+PG84tRTvbdoBb9o8GMHlaEaU8AjqfOIgvHCkfqBfE1hhRJhndl/B4TSFHeZeXKjyfZJMgbwYX4XFYv8gGWE39uEhzs5E4KSmu/Y64x7Raimkmr1Z0cKlHEZCX6f7jY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hfqe0bCR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hfqe0bCR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718302684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jk9BFaIBdnRuur/DRp9Mi6o2SQFE0p2XyV62LiyPpE4=; b=hfqe0bCRhpK/y9nkN+eI8EalESJAOp4cfMi7oMQiod96bnroSQSrDc05T3GHoahLgln/KV l+5k+aQLqudZOElP/xLaWXuw82JJwbe+WsNA6t0wiQ1DwJGXdIEKvN6Gs8mQiJQ+cExbAy BNlIOu280CFbQovY/gGOBX4f3DG9Jb4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-8903I-Z0OEq1qFyeVYyEOA-1; Thu, 13 Jun 2024 14:18:03 -0400 X-MC-Unique: 8903I-Z0OEq1qFyeVYyEOA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ADA4C19560AF for ; Thu, 13 Jun 2024 18:18:02 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8B4D71956056; Thu, 13 Jun 2024 18:18:01 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH 1/4] mkfs.xfs: avoid potential overflowing expression in xfs_mkfs.c Date: Thu, 13 Jun 2024 13:07:05 -0500 Message-ID: <20240613181745.1052423-2-bodonnel@redhat.com> In-Reply-To: <20240613181745.1052423-1-bodonnel@redhat.com> References: <20240613181745.1052423-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Cast max_tx_bytes to uint64_t to avoid overflowing expression in calc_concurrency_logblocks(). Coverity-id: 1596603 Signed-off-by: Bill O'Donnell Reviewed-by: Christoph Hellwig --- mkfs/xfs_mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index f4a9bf20..2f801dd4 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -3678,7 +3678,7 @@ calc_concurrency_logblocks( * without blocking for space. Increase the figure by 50% so that * background threads can also run. */ - log_bytes = max_tx_bytes * 3 * cli->log_concurrency / 2; + log_bytes = (uint64_t)max_tx_bytes * 3 * cli->log_concurrency / 2; new_logblocks = min(XFS_MAX_LOG_BYTES >> cfg->blocklog, log_bytes >> cfg->blocklog); From patchwork Thu Jun 13 18:07:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697253 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 128B84C6B for ; Thu, 13 Jun 2024 18:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302694; cv=none; b=gfUcz1Yk4fCH9BzDn+Cep2ocy0rHXqqLuDY5ICQ3bH3Cax/Py8YsSWJ5C3FScB2eDZWWSJYEK6EeOJj3u1GQMpAox6HLFmL8fl+LYO1yPaLWnVGjc3eGrQDRsB+hKekwQL0zT7bn34QwCvv9k5fKTU+RWY504ZMizf2R6X26WJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302694; c=relaxed/simple; bh=4MFNKBkwOuCTKGMrWeriH18qR1ppM/8njECJL03PqGQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MFLD7SP0ZtNSgcSoSWxULTjo6RgIk5qPZ5voZ97UFpfyWJirG/DNY+w1R66RowToCx7fJuQ9UI9tVuYJ56qv42JdrmTyLlBDuvGg5gYXg/HLTirmFSvvCbh2zffFSzSHto+gDfwSgqYh+TfeQqtWmXqc9RlTWQeG4DrAe94LDJw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z/IPV1i6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z/IPV1i6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718302688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9//GnoWQOg3r7NCHZJv5fANLow1kY48WzmeTaph72lg=; b=Z/IPV1i6XidNyO0IodZGo/Xz1krtY3B6Vz13jceMd7GUIAFtcQEqhRYk2leyvxJ8YvbRIR fBFsgHGT4VpJsRmb1W/BGVuIQtnUnsAx6CXj2+XdwxXkW3ZkDkZe12oWTKwvCJJeEcKcOv owY/g7hojTmMeV9yZQugYqvg7nBnAYI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-kaPPE9_ZPBO7myTPCZ2oRw-1; Thu, 13 Jun 2024 14:18:05 -0400 X-MC-Unique: kaPPE9_ZPBO7myTPCZ2oRw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF7AF19560AD for ; Thu, 13 Jun 2024 18:18:03 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E86F61956056; Thu, 13 Jun 2024 18:18:02 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH 2/4] xfs_db: fix unitialized variable ifake->if_levels Date: Thu, 13 Jun 2024 13:07:06 -0500 Message-ID: <20240613181745.1052423-3-bodonnel@redhat.com> In-Reply-To: <20240613181745.1052423-1-bodonnel@redhat.com> References: <20240613181745.1052423-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Initialize if_levels to 0. Coverity-id: 1596600, 1596597 Signed-off-by: Bill O'Donnell --- db/bmap_inflate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/db/bmap_inflate.c b/db/bmap_inflate.c index 33b0c954..8232f486 100644 --- a/db/bmap_inflate.c +++ b/db/bmap_inflate.c @@ -351,6 +351,7 @@ build_new_datafork( /* Set up staging for the new bmbt */ ifake.if_fork = kmem_cache_zalloc(xfs_ifork_cache, 0); ifake.if_fork_size = xfs_inode_fork_size(ip, XFS_DATA_FORK); + ifake.if_levels = 0; bmap_cur = libxfs_bmbt_stage_cursor(ip->i_mount, ip, &ifake); /* @@ -404,6 +405,7 @@ estimate_size( ifake.if_fork = kmem_cache_zalloc(xfs_ifork_cache, 0); ifake.if_fork_size = xfs_inode_fork_size(ip, XFS_DATA_FORK); + ifake.if_levels = 0; bmap_cur = libxfs_bmbt_stage_cursor(ip->i_mount, ip, &ifake); error = -libxfs_btree_bload_compute_geometry(bmap_cur, &bmap_bload, From patchwork Thu Jun 13 18:07:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697252 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613CC1482E9 for ; Thu, 13 Jun 2024 18:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302689; cv=none; b=n2u68jSxQGxWCcT8ZrEm+6XGj6VEOoP6r0qD37DQm4XX9DQhVvgUbqxhBZbiwflWYJiqQecJlsLi0OqIcJyWRoyYM5PJ4PPneunLYJH0MvU6VwrlfhKkRKWnsBu3Riy4YdcTMbFRKjjAPhow0PSqJ95TKF5ZFEW86KY2vS3MqJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302689; c=relaxed/simple; bh=Psgl4jWfxo5CxhvH5p9i+VXNoKSO6EurRUXoquwBArM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mF4Te58Ncqz2xDEslmKQInan+UKt32BPpC8ETZDOFDJR8A3FuFBZKh3o89y/HZcMOVpU4LlHCzQTyrBu26egjwtxdQPGKxWFVjlmtdflGmtzm1A25NreUIWmULekF22kZIZ/X06rSTWS2vJN4MPJ93Y5k1gdyKDJ7Ji3C7c/C9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IkTLA3JA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IkTLA3JA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718302687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZIlJphp8G8/h6O5w/8tP06TqZ6erkdAGwexKEZ/9fI=; b=IkTLA3JAE/sHBFi7f6NiLm5i1pR9KOni8BonLyuZVR00QnY3X8Ra5pLVuiGMv22w2Ln3W+ OMQr3EySn5sPpQruOFnY9GdEdgE2vKOQwUmC7ta05fG5Xq5tUqhmyh6TBoaga0yAC5Preb h+HETq/wtM16J5fvYVQpFifwl51wbss= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-qdSujx6QMOSjCJbDoJiXsw-1; Thu, 13 Jun 2024 14:18:05 -0400 X-MC-Unique: qdSujx6QMOSjCJbDoJiXsw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D7E431956086 for ; Thu, 13 Jun 2024 18:18:04 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F39B61956056; Thu, 13 Jun 2024 18:18:03 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH 3/4] xfs_fsr: correct type in fsrprintf() call Date: Thu, 13 Jun 2024 13:07:07 -0500 Message-ID: <20240613181745.1052423-4-bodonnel@redhat.com> In-Reply-To: <20240613181745.1052423-1-bodonnel@redhat.com> References: <20240613181745.1052423-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Use %ld instead of %d for howlong variable. Coverity-id: 1596598 Signed-off-by: Bill O'Donnell Reviewed-by: Christoph Hellwig --- fsr/xfs_fsr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c index fdd37756..d204e3a4 100644 --- a/fsr/xfs_fsr.c +++ b/fsr/xfs_fsr.c @@ -426,7 +426,7 @@ fsrallfs(char *mtab, time_t howlong, char *leftofffile) fsdesc_t *fsp; struct stat sb, sb2; - fsrprintf("xfs_fsr -m %s -t %d -f %s ...\n", mtab, howlong, leftofffile); + fsrprintf("xfs_fsr -m %s -t %ld -f %s ...\n", mtab, howlong, leftofffile); endtime = starttime + howlong; fs = fsbase; From patchwork Thu Jun 13 18:07:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697254 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA82D14A62B for ; Thu, 13 Jun 2024 18:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302695; cv=none; b=Tyv+vySjcf38FrI+njLFa00RtcGUQdoplSL9DM1zucHH8BHtNWlFdMWE889cmTbmVa6qHzqDDX+tn6th82aFoZV/XTfQe5BWdYiPiOA504vI3LLQ2ngRhCa5epGLaz03UTjmBP3nqNLL6KdcUaIqGdqNwYqV2aIz8+71sJ8wLVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718302695; c=relaxed/simple; bh=hcgP6moRKDZpupzvJuP5HEtlh8u9Gky/DxONTuAjDWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jvys2oTyxcaOoYEVuhnyBtpGxZZnY1ueS1Lk/pD6Bx5OhwBipLGgfD71H+R7nrZTRdIsZPzpmV3w/tuiQgC8fzxv5mfU7Wiq+FLnn64aQ7OL/oOoPgY/d0MNiAF20oaalG8v369iwaYoiy9mfjEAwNwj/0w1m+E7d9PQqVHimdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SHXWanoJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SHXWanoJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718302689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=snThJpWDNgNHCNOl6uD91ooMEJ1Wr3g9bkc7QeOUZT8=; b=SHXWanoJe89s621z1gz+QGevdb5AE+lYt9UVTjyp3R0ZpKPy3Us7upHrMnmdzolwgjll1E 0iKfidO/yZLYFkcLyPvWOHrYhuaTQ9zKzsoHTOkYbRp4O/VEgWABEEjlrsIF+uCGltuHg5 kN4QsjPKHr1IzGiCSGbkVwQxnvYc7hk= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-vBcWyfq4NWKgG8Qx282JXQ-1; Thu, 13 Jun 2024 14:18:08 -0400 X-MC-Unique: vBcWyfq4NWKgG8Qx282JXQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5677C19560B9 for ; Thu, 13 Jun 2024 18:18:07 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 026531956056; Thu, 13 Jun 2024 18:18:04 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH 4/4] xfs_repair: correct type of variable global_msgs.interval to time_t Date: Thu, 13 Jun 2024 13:07:08 -0500 Message-ID: <20240613181745.1052423-5-bodonnel@redhat.com> In-Reply-To: <20240613181745.1052423-1-bodonnel@redhat.com> References: <20240613181745.1052423-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Use time_t instead of int for interval field. Coverity-id: 1596599 Signed-off-by: Bill O'Donnell Reviewed-by: Christoph Hellwig --- repair/progress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repair/progress.c b/repair/progress.c index 2ce36cef..15455a99 100644 --- a/repair/progress.c +++ b/repair/progress.c @@ -91,7 +91,7 @@ typedef struct msg_block_s { uint64_t *done; uint64_t *total; int count; - int interval; + time_t interval; } msg_block_t; static msg_block_t global_msgs;