From patchwork Mon Jun 17 00:50:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Youwan Wang X-Patchwork-Id: 13699716 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E0EDC27C53 for ; Mon, 17 Jun 2024 00:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=b1zum3WbW+BpYIEB27iLqaiS5Vb4GCkEySqS7ef+xK0=; b=FQM8zRNPnscd5NPPtq96lPgnOx KItGMtvMVPlKxYO8aTB8AYv8cnT+hVQKeAB2UMq/uutW4mZzOV+7OoEbMOP0dHTt6vYq2ZMmZFnsN Rh0xedLx/pr8z9AYm80kIcqrLRyR/Wjp/kN0nTNmT7dUFOhOjaaRYZ+FIF/id8Z+4U4o+/sJey2+7 0qcwZxMft/SEhqHfHOSBiJIRe5z4X4RreQsSlFhb1gSS24UtAuPcmeNuIAaF8WCarXUUD5ENISIVw l8MtXpf8wlRhtAsYdla+x4vz7rrRC3PEVdehkaeVjpI2eOb4aT9KXShqKm2BpQTmJxGTCvTRL1Zv7 IvSmRVVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ0aR-00000008cTB-357h; Mon, 17 Jun 2024 00:51:07 +0000 Received: from [42.101.60.195] (helo=mail.nfschina.com) by bombadil.infradead.org with smtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ0aN-00000008cSX-49uE for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 00:51:06 +0000 Received: from localhost.localdomain (unknown [103.163.180.2]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id E8D2260105B20; Mon, 17 Jun 2024 08:50:53 +0800 (CST) X-MD-Sfrom: youwan@nfschina.com X-MD-SrcIP: 103.163.180.2 From: Youwan Wang To: christophe.jaillet@wanadoo.fr Cc: guohanjun@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org, Youwan Wang Subject: [PATCH v2] ACPI /amba: Fix meaningless code for amba_register_dummy_clk() Date: Mon, 17 Jun 2024 08:50:44 +0800 Message-Id: <20240617005044.246077-1-youwan@nfschina.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240616_175104_240424_2F4CDB44 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Defining `amba_dummy_clk` as static is meaningless. The amba_register_dummy_clk() function is static and is called during initialization. I think 'amba_dummy_clk' should be NULL each time when initializing Signed-off-by: Youwan Wang Acked-by: Sudeep Holla --- drivers/acpi/arm64/amba.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/acpi/arm64/amba.c b/drivers/acpi/arm64/amba.c index 60be8ee1dbdc..ef438417cc80 100644 --- a/drivers/acpi/arm64/amba.c +++ b/drivers/acpi/arm64/amba.c @@ -35,11 +35,7 @@ static const struct acpi_device_id amba_id_list[] = { static void amba_register_dummy_clk(void) { - static struct clk *amba_dummy_clk; - - /* If clock already registered */ - if (amba_dummy_clk) - return; + struct clk *amba_dummy_clk; amba_dummy_clk = clk_register_fixed_rate(NULL, "apb_pclk", NULL, 0, 0); clk_register_clkdev(amba_dummy_clk, "apb_pclk", NULL);