From patchwork Tue Jun 18 00:10:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Gurtovoy X-Patchwork-Id: 13701557 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2075.outbound.protection.outlook.com [40.107.244.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544F71367 for ; Tue, 18 Jun 2024 00:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669463; cv=fail; b=gluyBrGzeymSuwxQvQ/pV29K1GBfP1REJtnR42whqLwuBiE4lgaTU5xWnZ7Fa0+krmtER5ivd0GNpTrJhQ5QULpd8le9NUuSXhsOipEgjb6znMDkh5FX8/0qe+cktVtlqaPHx+wY9z85fo2whOX9hJ9P4Pz158ku+1bwlmU8uEM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669463; c=relaxed/simple; bh=en+Xbof2ele3+6M7NQ435F1OuwxyVZGlvyKJ5ZiB058=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P+W3ImHZ1Ek/pxTkgp5gv7nu6zIQ2ZR8EHe/NfHAbiSt1DyrE8U0BUdxYOmFcDt8IRhn65NjUyOD0mwpJhkvSLlooOPfXT9gO+a8a08SQQcQ5N2GP32nYO6g9N15Romzw2vgXmSM4kqkRmu6GOODTP6H/yv3wKLNQ+UPeOR0Op8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Td/DSTDt; arc=fail smtp.client-ip=40.107.244.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Td/DSTDt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrXlvE3J+5ETlxgYiJu18FSg/CMhe430+EA2PqlVzlnlfnySF1pFyHe/H90j/Dgk5lQsC+fSHkKChTmGbpYHZKm97NB+Nu9ghNWBYuavT1Sm6Yru3BXQshK90c6ithUg0nuB9/oc/xpoasyTTjookjioZ2FydzTkzyLlCU0Yk7mYjYMzN8HlfOryuX/kEzuA2ImFqkdWjM8N6bEUc7CjpAmaPiRwch0sLmuRwFx9HLeFIe357S6zLNWiQ2lu8QKDUjALBTLjiSQ1w3v7Td9iWtIg8DnOJAhJrgag22GXJMzBqMwH2RQJWZ4kN4E3Ba+TkBJlXIk1jno9/a/CvGx8MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/D57k+qje9srjgeYV7+LAq3vzfnZkskwDhTuSBbfNlY=; b=MY7usu3VnMjT6ARZL9MXXxHOsZ4tYwaJRiXHz8MD+BPiKYfz3Bp/1GY56LXtylFYGoKz4TZ8up53ObFgJ1f90TVcW47nPsOancQ/hE8JGwOVEjE/t4ogq8mGPFOIQ8jcOqVV4QtXPpa/lMjOQPUIeO2U371VfBqGaiCad5lYzpthqbG5bVEMD5AQnxt3S/HpJNUy9SNDr03vp17eBuy4p9gWspqF2RqUg5NkCs0RxuJcvUR3QkgkO/Qn2wavoU1JPV9mbtps7/jTOiBU4oAlXDhaB5kSz0LCbQtfON2BnoD9hkF7rHqlLCGUiCZrAAZGI1BJoob9CAXrmBMSa3mYaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/D57k+qje9srjgeYV7+LAq3vzfnZkskwDhTuSBbfNlY=; b=Td/DSTDtjyw3xwgQNkDIaD0UkchANqbL+EPdC002D4QAgGje/qBFIeuV4WmNKrvG3OCGEjRQ/nIPj++7H1LfQMfRTD0JIVnlsugoLfg3B7EMh1z7yhkeC3EJ2R+Kb1l3R/0cb3I/8CB3TnqFzvpkdhIbRgLA/TlvQZTareDz4pj07niTN/F8C3Qhs9Vi01ng7PmZZmqYkQBITEkptIGWxNoSTeWGclt3q4n1YfEBUobsq7CxZtJz/3A/xFY2x1u9bbLhEDS0OWsrEDW2a5WsTaGb+kcADvmk0DP9wTeypykl53sGAjM4Blm+thXJyuAqOCmTVGZn4CEmgnmXmk27WQ== Received: from CH2PR16CA0009.namprd16.prod.outlook.com (2603:10b6:610:50::19) by CH3PR12MB7572.namprd12.prod.outlook.com (2603:10b6:610:144::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 00:10:58 +0000 Received: from DS2PEPF00003448.namprd04.prod.outlook.com (2603:10b6:610:50:cafe::1c) by CH2PR16CA0009.outlook.office365.com (2603:10b6:610:50::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30 via Frontend Transport; Tue, 18 Jun 2024 00:10:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003448.mail.protection.outlook.com (10.167.17.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Tue, 18 Jun 2024 00:10:56 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:43 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:42 -0700 Received: from r-arch-stor03.mtr.labs.mlnx (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 17 Jun 2024 17:10:39 -0700 From: Max Gurtovoy To: , , , , CC: , , , , , , , , Max Gurtovoy Subject: [PATCH 1/6] IB/core: add support for draining Shared receive queues Date: Tue, 18 Jun 2024 03:10:29 +0300 Message-ID: <20240618001034.22681-2-mgurtovoy@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20240618001034.22681-1-mgurtovoy@nvidia.com> References: <20240618001034.22681-1-mgurtovoy@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003448:EE_|CH3PR12MB7572:EE_ X-MS-Office365-Filtering-Correlation-Id: fac4ebb3-bb6c-4580-fef8-08dc8f2b205e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|82310400023|36860700010; X-Microsoft-Antispam-Message-Info: toPmIOlbiB1zIvr6Hs6brcqa8dO+oZtLrAh2japrbJzDMavelV4dsRg81VmkVdatHdB56Py5B/SU0Fk+NNhrdoQEIx+wLLsg9o8gsNxDqDv6ZR5wbIwPjYvbNncHHpz48wWRBIUUbZhvNZ+5H9glU0Nz5E15rnBEkSjfJpyz0JneSwbLApYTpDEfqcVVPGU/u55kSSVO3pDCi7gL2LYFU9mFkLIuRrYYtbb4eqNzdKjBigt3JE05EAencRB0adAt6fmIi9/shQwMvcNvd+4DSLk+q6FTXqk7mGn086L7PN5VoWVDZ/4MaO7ZMcJKR/NTQdzovaf5ITf1Qs7B12xx9areVgWU/Y2kHLOmol9q7igVCfHmsPoSeewXdM9XsV5/jRqr5FS2PxStP+wrBXW6aVEqQbMzb24oiS7ZN92wA4n3Ow5rq9bdBQkziClBnfvcpB5wLQwpCcZmY/vqIbODEIMXK2/zs+0ApqRdwDf7+MuJ/5ybkGl9nNshFEFHVrt2Ii8OjHdo2H6XVQZeEQncAjQUlFotGb01zigwUURHdBWbuV4rVZlleWfd3RB9gOvmcEiyhV3P3/yJXyywvY7g8NTsCmgQXwc/w01SWT8EqZnBNGaR9SMLROKVDnSRFSeaKfF3Hf4j23VcEAopiJriwFjxFqj6yFyC9/ALYR8b5ZAfre0p1XNxgRwjk79f4Epirdt6INhKo/ATVLe0IHJINnEU+zIgZz3EJb40bWkexrH0/k2/AhvYPtEYeCf7WYSwrzyjzLJ5Fi2WMJD7FQWU9DcGenLEv2t0esEOxrp0DNMWIXFJZnk37LMBVzrE6RTEKGSjO6hNgYkob8vYesz2mJvanxgkpJ7RNdZqhOxChZKDRTBIh51HUcjw64v+roNyEsXphOx4W0d/7L2R2GZs850sFAB3LbqNzv/sLoNsXp+2NPuK8IDCQfasQe/Rq74cIIe+mVcThCxCn5pwtxucTkOdwVP8lXS8/11uxaTXBpmVtJ7OZNB7h7I/8tZUBHyY506T/faD/EYSzZNNyyvubnESPZuLRl6DKX18nH3EN6xSTEvYPQhf+tUbAZ2mH9Pc3YtRgK0LhkhCwljy9GUmqrFTN6PlsKFocHS1QHDpBKn6Bh1xY06feTjk0inaFvbMFs7HX8PInA/5Lo0Ar7ytWoUyZkFuaSGWHnyFv1IUJDU1TY7oRVb79V9hNwUXfJD0KZrJO0NxEjS6xmUhxK13HDqIkbgYCESW33zuPVnnCwH0psIb8FnZAdRiZUGkisNhM+dQ0+7ih5mvdHpmEC8SEEtDChHvNF+ydKOsfbvCLmkpS7UfF5GYr/VJxUPSiMaY4Asj2fcvF6ceSnjv9cJyr0R2X94j78dB68NbtWVGFOYbx5oUYowd6juhstylOlIf9aCoE4BqzxORejnIIN3aIQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230037)(376011)(1800799021)(82310400023)(36860700010);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 00:10:56.7823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fac4ebb3-bb6c-4580-fef8-08dc8f2b205e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003448.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7572 To avoid leakage for QPs assocoated with SRQ, according to IB spec (section 10.3.1): "Note, for QPs that are associated with an SRQ, the Consumer should take the QP through the Error State before invoking a Destroy QP or a Modify QP to the Reset State. The Consumer may invoke the Destroy QP without first performing a Modify QP to the Error State and waiting for the Affiliated Asynchronous Last WQE Reached Event. However, if the Consumer does not wait for the Affiliated Asynchronous Last WQE Reached Event, then WQE and Data Segment leakage may occur. Therefore, it is good programming practice to teardown a QP that is associated with an SRQ by using the following process: - Put the QP in the Error State; - wait for the Affiliated Asynchronous Last WQE Reached Event; - either: - drain the CQ by invoking the Poll CQ verb and either wait for CQ to be empty or the number of Poll CQ operations has exceeded CQ capacity size; or - post another WR that completes on the same CQ and wait for this WR to return as a WC; - and then invoke a Destroy QP or Reset QP." Catch the Last WQE Reached Event in the core layer without involving the ULP drivers with extra logic during drain and destroy QP flows. The "Last WQE Reached" event will only be send on the errant QP, for signaling that the SRQ flushed all the WQEs that have been dequeued from the SRQ for processing by the associated QP. Signed-off-by: Max Gurtovoy --- drivers/infiniband/core/verbs.c | 83 ++++++++++++++++++++++++++++++++- include/rdma/ib_verbs.h | 2 + 2 files changed, 84 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index 94a7f3b0c71c..9e4df7d40e0c 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -1101,6 +1101,16 @@ EXPORT_SYMBOL(ib_destroy_srq_user); /* Queue pairs */ +static void __ib_qp_event_handler(struct ib_event *event, void *context) +{ + struct ib_qp *qp = event->element.qp; + + if (event->event == IB_EVENT_QP_LAST_WQE_REACHED) + complete(&qp->srq_completion); + else if (qp->registered_event_handler) + qp->registered_event_handler(event, qp->qp_context); +} + static void __ib_shared_qp_event_handler(struct ib_event *event, void *context) { struct ib_qp *qp = context; @@ -1221,7 +1231,10 @@ static struct ib_qp *create_qp(struct ib_device *dev, struct ib_pd *pd, qp->qp_type = attr->qp_type; qp->rwq_ind_tbl = attr->rwq_ind_tbl; qp->srq = attr->srq; - qp->event_handler = attr->event_handler; + if (qp->srq) + init_completion(&qp->srq_completion); + qp->event_handler = __ib_qp_event_handler; + qp->registered_event_handler = attr->event_handler; qp->port = attr->port_num; qp->qp_context = attr->qp_context; @@ -2884,6 +2897,72 @@ static void __ib_drain_rq(struct ib_qp *qp) wait_for_completion(&rdrain.done); } +/* + * __ib_drain_srq() - Block until Last WQE Reached event arrives, or timeout + * expires. + * @qp: queue pair associated with SRQ to drain + * + * Quoting 10.3.1 Queue Pair and EE Context States: + * + * Note, for QPs that are associated with an SRQ, the Consumer should take the + * QP through the Error State before invoking a Destroy QP or a Modify QP to the + * Reset State. The Consumer may invoke the Destroy QP without first performing + * a Modify QP to the Error State and waiting for the Affiliated Asynchronous + * Last WQE Reached Event. However, if the Consumer does not wait for the + * Affiliated Asynchronous Last WQE Reached Event, then WQE and Data Segment + * leakage may occur. Therefore, it is good programming practice to tear down a + * QP that is associated with an SRQ by using the following process: + * + * - Put the QP in the Error State + * - Wait for the Affiliated Asynchronous Last WQE Reached Event; + * - either: + * drain the CQ by invoking the Poll CQ verb and either wait for CQ + * to be empty or the number of Poll CQ operations has exceeded + * CQ capacity size; + * - or + * post another WR that completes on the same CQ and wait for this + * WR to return as a WC; + * - and then invoke a Destroy QP or Reset QP. + * + * We use the first option. + */ +static void __ib_drain_srq(struct ib_qp *qp) +{ + struct ib_qp_attr attr = { .qp_state = IB_QPS_ERR }; + struct ib_cq *cq; + int n, polled = 0; + int ret; + + if (!qp->srq) { + WARN_ONCE(1, "QP 0x%p is not associated with SRQ\n", qp); + return; + } + + ret = ib_modify_qp(qp, &attr, IB_QP_STATE); + if (ret) { + WARN_ONCE(ret, "failed to drain shared recv queue: %d\n", ret); + return; + } + + if (ib_srq_has_cq(qp->srq->srq_type)) { + cq = qp->srq->ext.cq; + } else if (qp->recv_cq) { + cq = qp->recv_cq; + } else { + WARN_ONCE(1, "QP 0x%p has no CQ associated with SRQ\n", qp); + return; + } + + if (wait_for_completion_timeout(&qp->srq_completion, 10 * HZ) > 0) { + while (polled != cq->cqe) { + n = ib_process_cq_direct(cq, cq->cqe - polled); + if (!n) + return; + polled += n; + } + } +} + /** * ib_drain_sq() - Block until all SQ CQEs have been consumed by the * application. @@ -2962,6 +3041,8 @@ void ib_drain_qp(struct ib_qp *qp) ib_drain_sq(qp); if (!qp->srq) ib_drain_rq(qp); + else + __ib_drain_srq(qp); } EXPORT_SYMBOL(ib_drain_qp); diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 477bf9dd5e71..5a193008f99c 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1788,6 +1788,7 @@ struct ib_qp { struct list_head rdma_mrs; struct list_head sig_mrs; struct ib_srq *srq; + struct completion srq_completion; struct ib_xrcd *xrcd; /* XRC TGT QPs only */ struct list_head xrcd_list; @@ -1797,6 +1798,7 @@ struct ib_qp { struct ib_qp *real_qp; struct ib_uqp_object *uobject; void (*event_handler)(struct ib_event *, void *); + void (*registered_event_handler)(struct ib_event *, void *); void *qp_context; /* sgid_attrs associated with the AV's */ const struct ib_gid_attr *av_sgid_attr; From patchwork Tue Jun 18 00:10:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Gurtovoy X-Patchwork-Id: 13701558 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2069.outbound.protection.outlook.com [40.107.243.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EFAB139E for ; Tue, 18 Jun 2024 00:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669465; cv=fail; b=LzL4QHSHa0qirplOEm/T+xy5AcpdUUmnVuDDIzf/yoV2SAQCrpRV3hU/9LCdE/c41Z3J4AgnKcapra89n8oZG4toSHSI7W7kGBg660cJCkrHw5aJovcsdH04U2sdf83u3Hy8CoNK7cthMAhueF09T00wiFo4Es2XfhcmXYEjtfk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669465; c=relaxed/simple; bh=chif6iVeLZUwe8ejbU06jNF/GrF41gMtwl/HRmxGxm0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JYkxKPO58/EHG0TqiTqye8y2k881NHytfq3htvmGIl01u/TZhAFplSAKfun916/fPa4oACeqQDUMiT8HMVyX4z2x+wIvgUFl6ulYNWFjM94zFthX15a4r/Z0K22j0HZen43cPZd/aWhnsbe1IYIjV1iGblrZJxAeDg7TAen366g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IJOyJzxr; arc=fail smtp.client-ip=40.107.243.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IJOyJzxr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QmdhKvGpbUb6Q5eT3/KoDws9/VB9RzwLYztadW3c+PuoIDRktBSbeUtMULMmtdD4QARVR5P3hxe6m7U+MerRzmHVDoetYbzoRIKqVMHiBvoNd9kE0Ma69eddqtG943BQW5n6unxDWDwcG72JGbZuNtp5NpG2ElvfZ6fso9OADeNivXUc0GtJqdLEovFNQBrnzVTElrdHsliXChRV3Yzz1Z0OM4yZR2LDCWBDsbjTkuVD82qfIgkz5sgdKNME2q5qADO+kq7Axep85neXk060NgTHpHmCUvqaBgh9zMLVVgcjXSnPup0eEDjmqjWcFy+hlYBxwAt0rf+E/LrasvoURA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d7ishIMx0oTwH8R8aZEU3m1gxjUxnldxqZIna8x4s2c=; b=Czhf1Hd8i8JfpLqDerOyWQclHzKOI0uebDMC9bSK+3o2YLrcGtDNaLJ/7mRoEqgKPoYJ/2GERjcB8+y/4CYFL7dRzxlATDUHwiDCjLBvqiv0h5Cz9wP5Ec2E/v4xsvM1PdimQXw3T2b3ioZBuvCCEDEhdM0f1Ek1LEtog1LxdeOjXkOKs4wB+733+eNwGnLUNs5I0D6Y/8mi9Xqq0bmoEg9nL0tdD7FU2T4Dd3Znzk1epFi6ncNzl1wOcBIlZlgiaMaXPyTTVRSzXEbMeVS06HZULFYIBi5BpXpfqp8mV60EBhPZwEwaGlHlMJbJ3mqUQLPbyxxmAfxi22bgV81s/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d7ishIMx0oTwH8R8aZEU3m1gxjUxnldxqZIna8x4s2c=; b=IJOyJzxrrPShDaaMxKbGSBAssXFj1yPzbYA8UCUMQejvIS0h8mXoIKKQx2euYit7HSKrYsuEel5QYZQ5dP3uZjuS8IygYhqS2QxtB7tjx0o3yYI7lzTOnp209S7OAcVzNOOuYAkbQj3UiycnA+dGb4uDYZmhgQY/Mq03zZAXoxSrIXQDpjZ/PBxX495fLsf/Lzr+ACWBBkn4nRwQCtbtBKjAXuIwnWzGEmi3Bzojb3e1OsN6JnL2xIWevvodJpnOIcx5Xptu5A5JBJl25sMUU5HNKDmpRays8iuKm+B3ueT0tCcS3Tx81piwBwe7YijLbxaSkQVOpE3IY+I9zbz43g== Received: from SA9P221CA0027.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::32) by DS7PR12MB5791.namprd12.prod.outlook.com (2603:10b6:8:76::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 00:11:00 +0000 Received: from SA2PEPF00003F64.namprd04.prod.outlook.com (2603:10b6:806:25:cafe::27) by SA9P221CA0027.outlook.office365.com (2603:10b6:806:25::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Tue, 18 Jun 2024 00:11:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F64.mail.protection.outlook.com (10.167.248.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Tue, 18 Jun 2024 00:11:00 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:47 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:47 -0700 Received: from r-arch-stor03.mtr.labs.mlnx (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 17 Jun 2024 17:10:43 -0700 From: Max Gurtovoy To: , , , , CC: , , , , , , , , Max Gurtovoy Subject: [PATCH 2/6] IB/isert: remove the handling of last WQE reached event Date: Tue, 18 Jun 2024 03:10:30 +0300 Message-ID: <20240618001034.22681-3-mgurtovoy@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20240618001034.22681-1-mgurtovoy@nvidia.com> References: <20240618001034.22681-1-mgurtovoy@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F64:EE_|DS7PR12MB5791:EE_ X-MS-Office365-Filtering-Correlation-Id: bc75635a-849b-49e0-29c4-08dc8f2b2257 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|36860700010|376011|82310400023|1800799021; X-Microsoft-Antispam-Message-Info: 96lKbYK3YoE/VD4cuM2RGxNAaEMeRpPUma+KjuG9Saf8T9Ox1PDwsDDN8b1pc5SL6dwbzaCtwGfoRDHNM1+ZOlLmi3CUo9QeMx/h9vpLO1UweMk9hE6zgjSJejew2I5087xi1K0Cvzhdm/6e/3NoIrIUcNRtksB9gmTjkCuwdgPFLard/JNeDs1t2WxZ0PeyJPydANqxLWD/x11nyedVc0xBQBe7Fd4hQ4Q40RMMvn+6Lwd7yT99amjJDVEcVjg2Pmc/ECKJSFrQbYTBZ6xZb5YrUHGSiu2DL0Mii4Zw5rlQyKxKIel9e7yKKa5OvPgZZFlKpQdTj4hPQEGHvV634yi9FnIjDuvtIucpfFWp5gi8963p6KFeatfAvoUmiqmI7X1QVc0AsmJpSRhxLWx9T0z+5YxyG0L/kqAXAelVVZ0TkxLoBulF28HjcWPhnSiUGJHTPIZkf8sULV38vR0CqcYkGLbuUqC/qd2AjlKde9Ccj+EKxsFcq7DIUjJAMLYsSrXsz+j/Rgz1L9dB731YqdZ/dRsa46FweLBFqHRQM2GYT0sjc71zcTfQIftxoxG64YwRfcPRCS8gj5r11iLtimP/zjQyq3KYbvboXEGJYT046VxiXg0aWnT2KkZdGITbnk4G0mylPLsNizc/RmCjjy78HBHMT6iivq4OVicQReQhiOGv/N58Wa2HUY7atAs4HYUZG0jTwGpCRe1H25Gt6Is5VKgIwXxhxbV/EqmYdGqUR+ICfEnTlpGUzbCAcpgwPKHnTXgMklidUhEQkQPT0Bd7ee4LO0wCHwrpvYHsIzeK7HX0zpmIV/yxNIFFhQXywxwpEc0HdM4ENJWOEDRON0d/Y1xY1eYH2+PaDnslQHbt+0Vdbq1vVVZo37DVdQJSHbmtAcgYp6pQ2w5edTKGCA2acD+d2vfypANaBaxcSf6aWgZairTkuUC1LA0yLd2SHyYrtxDW7qVOr/JCS/QZSqSMFvbpBnRoDFoODv4Z6DugRoF07kjxj2rYDVRwwZdZPn3pHXEustYfZg/wgC4IuwEIO4M88Y4LCgJ6GOv+9eqp7cX1gUXsApPLRn/SbOJdV5mpgtuGqEpJX2B9Cmrzj7rwZELZ37YGOihem15WMMMZvDSlokQuwlkIy36W7QAzrJL6D5HbEKqHkyHjx0TBbMEv0eVf6hfuO7bpi/eKd7bd2xvVWxBQbPvBQIv8lw2n68QBpdV4M4t19MOx0TFYSMuY+Tj4rmrz7VpKbqNuJYBfQjgcN82dw1iYd5A5d66rWxPHncV6bNJP+WS7zz/InsTBcWA9yn5AmC2nX9k0E5vb6khdTrO4KT4+qAd86bEc1W5tP+ECnQmOlaQdBLQ7itK+gwoM5EDSD2ZaPdCE/+vZRepdV+pMkfvZC2WrNbfZT60/WjDha3upitE7TTykGw== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230037)(36860700010)(376011)(82310400023)(1800799021);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 00:11:00.0708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc75635a-849b-49e0-29c4-08dc8f2b2257 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F64.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5791 This event is handled by the RDMA core layer. Signed-off-by: Max Gurtovoy --- drivers/infiniband/ulp/isert/ib_isert.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index 00a7303c8cc6..42977a5326ee 100644 --- a/drivers/infiniband/ulp/isert/ib_isert.c +++ b/drivers/infiniband/ulp/isert/ib_isert.c @@ -91,9 +91,6 @@ isert_qp_event_callback(struct ib_event *e, void *context) case IB_EVENT_COMM_EST: rdma_notify(isert_conn->cm_id, IB_EVENT_COMM_EST); break; - case IB_EVENT_QP_LAST_WQE_REACHED: - isert_warn("Reached TX IB_EVENT_QP_LAST_WQE_REACHED\n"); - break; default: break; } From patchwork Tue Jun 18 00:10:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Gurtovoy X-Patchwork-Id: 13701559 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2067.outbound.protection.outlook.com [40.107.236.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF532211C for ; Tue, 18 Jun 2024 00:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669472; cv=fail; b=oyLRnxqIsHF3DX4mzxrDFB5xVP7Hi5P+AecmnyTo8u3yNJgbMAzFoMDg37dKY4t8r9kDBvraebqqInQ/ZUj/8hhTxUK36cLpMKKqBVFEtiJhl/ZmaThonuSLCM2XnD3WENUnlpitQYwpt93r0cHaHXccMTwlmc4LLULaX9M8PtQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669472; c=relaxed/simple; bh=DSetob7ihncurvr2xmXZnFwcWzUk3F6+2QM/oCbX1cU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Fh6wWaJtCdYnM+gyr8zMsqGsi4akn728/Yv/Y7RmfJ0OLcMmw8U0vbzwseRd6cjCPYqvVEjZo3PpRXqLEVMI6hTaQVeN8VtPHo0jD1I7JS2YsrgpiiLwWRE3REwTeVVOcp4CUigcfJZ8GPCky5FeSk8jkp3Jj+g8O0lw9271RfA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cxHAtv6R; arc=fail smtp.client-ip=40.107.236.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cxHAtv6R" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W2jXWcaXJR5yrkB79kyH3/t+ile52x3aDtaphfDL5ZEfpFyZXVS25jlRMfvvNSssHhshUPwEgqrumVnH6gCtkEspAVuqrn8djALTxKMeknFirrFD6tOtA0gD2/K/thICAB02XThBg8r6Hggng4UcAlnph7XGwvNw18DHwjrGKbS/UaTnpzgc2k/O2JDbwsdDnT/i1sBBh1QPFPfeI8fUZ/r20Wf5AoKlU+RMphPfhfRGacfRrRK69qN+uwZDccad4e/krPUDgu4Z1OyqTceuWtFF8KjlCa5jx9TryQ46CvnmnDhHTDaV+JnuzUk5OC2NvxAu3wKWpMVamoURGh7B8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKou4U3jOBnwOi7EJmCG8lq8qDKWl++jyBmgrZRiph0=; b=MX0d5epyqJ1VXv9XAzQ2mRHCtC2kK2baipD+S4CX+vJ3p7Nqw+Qjyeqv2vLnVpoDluaRQNnT+qqATUmI/kFvTze3vY+okDsxGxvW6yxpkq1jxsqGNmLYpXU8gjsBc3fZfDhJR8gd9XdUFqkqzfIPNAA4xkB0pqFLqtdu4BphcvG3tod6VHXaRDwDZJSAkkrMtgo1b7XPRhEe0O1Jb6zzpHbP5WTNUrK+SD8VNHjVNVLiAk/jBCwenbDHlbkS3iftu2nOz+9hggNNP1XQ1IRpqB/y95sAsI2eMKkR8FBmouMVBQi8U8C96l0cVpXxQDs/DNq69qrN/FTiwZdGRhP4Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKou4U3jOBnwOi7EJmCG8lq8qDKWl++jyBmgrZRiph0=; b=cxHAtv6RWPwiC1p70SB/47Eh7hg6ERZGMd1OpUg3k119zUAyGvYENnLjaXBQLpZ1bRsPc584iMC43mBDruP4eWHPFZzD2tEZ5i15o7mWITlDCWiZCoX6QUSwa0lddHuJCdFrNi+3mao394N29GXtFJwGBI26jcC4msDqe83/iqH4a2+BOg0f/qichhpnige+ZI+uSP+L6ap7mBxewem6JG1OGTgwiJT23c1IxXDFwj2QNQoRVKxNSKtKX6sLYyLRa6W+3ekgxtoDOHOTaWu9WSYdCR+6gQ7p6Fxn5jYqvmXcCJPiP+Vgq+SBbY20KF938qq+wCOunJKYygBpoZN3kA== Received: from SA9P221CA0019.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::24) by DS0PR12MB7631.namprd12.prod.outlook.com (2603:10b6:8:11e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Tue, 18 Jun 2024 00:11:05 +0000 Received: from SA2PEPF00003F63.namprd04.prod.outlook.com (2603:10b6:806:25:cafe::46) by SA9P221CA0019.outlook.office365.com (2603:10b6:806:25::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Tue, 18 Jun 2024 00:11:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F63.mail.protection.outlook.com (10.167.248.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Tue, 18 Jun 2024 00:11:04 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:51 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:51 -0700 Received: from r-arch-stor03.mtr.labs.mlnx (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 17 Jun 2024 17:10:47 -0700 From: Max Gurtovoy To: , , , , CC: , , , , , , , , Max Gurtovoy Subject: [PATCH 3/6] RDMA/srpt: remove the handling of last WQE reached event Date: Tue, 18 Jun 2024 03:10:31 +0300 Message-ID: <20240618001034.22681-4-mgurtovoy@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20240618001034.22681-1-mgurtovoy@nvidia.com> References: <20240618001034.22681-1-mgurtovoy@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F63:EE_|DS0PR12MB7631:EE_ X-MS-Office365-Filtering-Correlation-Id: e4b63f65-c3c1-4063-8d76-08dc8f2b2538 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|82310400023|1800799021|36860700010; X-Microsoft-Antispam-Message-Info: Pg3JMNxTxmFco00lFAIND2VWjNBN12z/KHj/+cdnx2Gpfq73wdEKLHa/XPJnIVWPZ3ap5edwzvIMVmHF21SzOF/tnUWeEewaQFZdoJuSovdmbK7rOz8qo4enNp0Qo2A2JggqvSdk/z7Yt5Ak5K7B8K0/y1H0/idpFghLHLS0zXnPf2TD60F4bqPPDePYRxKVwSEgKWTUJWrFpjUYz4nEs0QoQ4YJ/QVcalHK0bDYybcpu0w2bKZt2khN9kB1sJzzsQWQUigM3PMaO0QXrsZ/zFBI189T+fjCUOOljkBAkhRbtt9luyqYZ5ApGMYUZS55/VjUOh/WmsjtWn4+9rOpaaf+uRi71n+4ODTpI6ej7nrdLyi14TLJFRGPF+600HqzCDqoXqs3WWBk/dItGS8yEHK1HEH4N7RxDRxQ8zbUkcNUfTybJfdGcyTvaARZg91+odHD/NgMo0ObufU7rgiGFin7inWok7prwUDbu8TN1m9ZTCpQQgFZ9zvNo6bhZR1gcNFctY4O7ndbJdyNKpopHOXiDZw7yUaRhX1cJdj3z2/lCOI6Tzpwzf08ZfsLbkU5JP2ChnJcROtJJc3l3moGFEQqfRjzztBlOZVOP/fS6XMMpfrYdVLTMFpDiPc5e7EB5k4anNWAxI+KL89j5dMAcH4h0ueaH3QBHifB0DrJY4OXhw9x4B0dD/rVo/6y8ehCNGYK05zedsoHrzi+v9kPfPDZs936LOI1A5uHwTZIA2rqYARBY6rVl0gvjSyz+5XQj24D2oPjHBWOrXg6VP2QXNa5CrlfG9Xl6tDwd3qEMBk/DogU7gskvHCp97qLnXveb2kVpFPo8iiVYmM9Y+iL0zE5n8k0o1JjKrAtLR7L5FwJNY3P+cpquMOF7khCIyc2CaDTce9vZbr9/HXeu1yfwsrb2cvZUZsvAAMuwAXoX9dcvPrJQLcKDN+dF2NWPNlSrq0qj1AEPDUEegQzsfIPYOhZNQ+roaZzVAJr7jtmMzStNBpf82qBq6I9VLVoZgIc/PLoylXzBiCK/5uX6YKfZX0NznEaeOw4ClewldjlZVyVs1ddknB8b2JSTWYVaOQrFl9Ojpl6OjzxfwCR6mZ6bwRwVroXQSrA3Zka4DfMO2BG5IcuVxrZcdeARVMpw43L89ecDLwyqiTwFxW+6dqX9ghg+VpW0kDz3FrDTfNFs/d/Ur9qrNPTwM5Yw1qhmKgtt7A77qNZZx2D3zHD94/n2rc8YshTldNZDKknpNdo7zrPDrqHvtOeIKSN5HJHymXHVxTo8V3uEDFTqog0DuAfRp+EP+Eorum9MIM1L64pl61m/3tqFw5ksROOpR/WrBRvevpr4ClYpty9SorhVmkbr9VFJihQ/nODR4sXiqUFuq9IiULoJRQqt1nRvHNNJc/ORqtiXMLf3TSnec6jqdcjag== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230037)(376011)(82310400023)(1800799021)(36860700010);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 00:11:04.8877 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4b63f65-c3c1-4063-8d76-08dc8f2b2538 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F63.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7631 This event is handled by the RDMA core layer. Signed-off-by: Max Gurtovoy Acked-by: Bart Van Assche --- drivers/infiniband/ulp/srpt/ib_srpt.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 9632afbd727b..8503f56b5202 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -231,11 +231,6 @@ static void srpt_qp_event(struct ib_event *event, void *ptr) else ib_cm_notify(ch->ib_cm.cm_id, event->event); break; - case IB_EVENT_QP_LAST_WQE_REACHED: - pr_debug("%s-%d, state %s: received Last WQE event.\n", - ch->sess_name, ch->qp->qp_num, - get_ch_state_name(ch->state)); - break; default: pr_err("received unrecognized IB QP event %d\n", event->event); break; From patchwork Tue Jun 18 00:10:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Gurtovoy X-Patchwork-Id: 13701560 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2070.outbound.protection.outlook.com [40.107.237.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEEB536B for ; Tue, 18 Jun 2024 00:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669474; cv=fail; b=ZAcjF0wc8yCufTBxM0zDMlrC5ehoE8WyG1NfYcPZDyS6SdmMqe0scwDCH3khd+ga17tF13dkI4zhj6AZxttyMDhQWbcbBLiZNSdoZOS8EoLVfVfQz6NKDBlXnCJZ5F8fZJObWgdP/I0Orc3bTftF00YATZ724IL2M6Al8MaCY7A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669474; c=relaxed/simple; bh=As4Mxyebd02U4xGlbA3u32cun0UP9PGnpK59Nwsa4VE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ExGqmAbFLGmEJzDSTPYQxqE8x5vV2RJ1qtxMSJH98cmb71QXMgwzh+Hr/hlu/6soosbJxOpZJkrMfMS45K4fsZkVxdb26sVjCBtwrjkNRyqHqANomLKc6jUoZXXubPfaBg24cb9cXfJ/Utsx5lC5bXoeLdxVx/JJHYWEJwWbNb8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lJSemR8+; arc=fail smtp.client-ip=40.107.237.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lJSemR8+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bdo84dFAKyGKUJc6sqXci4Ui66mENjln8uaRdkwwJO4Zmyr+4/yaXTFMensgTkAruBGgVTGYpV/Y2mzc10Nw5BDA63E7WeuHTGqSCXi8YjfHiNv+8wbWyiJcy/igJBzO9ZvbUSRtOPrIvXTcSI7XLi6MyIvIMT9BsI4USg2jA/qfItQJ0D4yArcKmdIyCvYND2UhquvQdhQvOxJeKSa8Tao47j8LFBnH9KwVU19N8a4s1XqVrzaFuprukreIMgZY2WoS0xxET2Ltdtj/V20y5ggY8vE/XpBSJWB71XUqC61FbjWy2PLRV5gU/1jJ8sL3nBXdWf5q8f65uZTRCUhurg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6v16HIsu7G2TKXjFNWypGO5HhqXcqXt9uhuIv9dz3RY=; b=ZAbrRqYzCeBz3vRYK/27D2/TS7YAyCF+ENaGA8/JSDYxHP1vx5ZS4lUjBzrbcvvRVwY0CEMEZ9nMltM/HCnBb2y9yYPHlRM6rz/GRwJxau0B+WrULHxFp1NRjAqiWCS9wJB6icQSzHYCkg7vT2IHV4RuzdDzp7N9+wQxhTukGlfXOxDghcwD825I+jARVv12fZoVDyr1V8KruVbaouk0bKXgylm9ZG6uL77yunwRamunnM2epsoGM5lgSBDzav41GGj/YIowb5ztvXUzUlLX4nQ4x+YuP4nKgrJDxUib5oRIhacDeYxtrc19Vqz6iOlIV0mTrvFbHqFw1dGf77d1qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6v16HIsu7G2TKXjFNWypGO5HhqXcqXt9uhuIv9dz3RY=; b=lJSemR8++lMZfYWjyklZBYPLbofVjcjqpKfZwiXsyZrQWFwjHz1NsEQ7GuOb0c5Uj+EwGOS1camm9GfgNdfH2nB74zcVRwpsg1c7T80vABgvD0Y/J5H4TE94CtBt2PQ2qd5sra1mvPM/wYyOLK7W6hBAPhUTIISE0fK3Z5O0LNDws82NF+k8MWvNFMq48ZZs3Ru+Pad28yJeSisbADXIjrXl+XSpE48yZprbiXLurVZJCJN2pd/CAChgySyeYxc77CV7yPp2hd9u6spbeCgRhsJ4ETj+MwqUnteSowjiuNkFbbXq6iBe9wETMGhuIR3uoJfQVN+tQI76dSepKB01bA== Received: from DS7PR03CA0163.namprd03.prod.outlook.com (2603:10b6:5:3b2::18) by SA1PR12MB7342.namprd12.prod.outlook.com (2603:10b6:806:2b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 00:11:09 +0000 Received: from DS2PEPF00003447.namprd04.prod.outlook.com (2603:10b6:5:3b2:cafe::84) by DS7PR03CA0163.outlook.office365.com (2603:10b6:5:3b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Tue, 18 Jun 2024 00:11:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003447.mail.protection.outlook.com (10.167.17.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Tue, 18 Jun 2024 00:11:08 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:55 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:55 -0700 Received: from r-arch-stor03.mtr.labs.mlnx (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 17 Jun 2024 17:10:51 -0700 From: Max Gurtovoy To: , , , , CC: , , , , , , , , Max Gurtovoy Subject: [PATCH 4/6] nvmet-rdma: remove the handling of last WQE reached event Date: Tue, 18 Jun 2024 03:10:32 +0300 Message-ID: <20240618001034.22681-5-mgurtovoy@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20240618001034.22681-1-mgurtovoy@nvidia.com> References: <20240618001034.22681-1-mgurtovoy@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003447:EE_|SA1PR12MB7342:EE_ X-MS-Office365-Filtering-Correlation-Id: 71b52e57-e779-4407-a911-08dc8f2b278c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|82310400023|36860700010; X-Microsoft-Antispam-Message-Info: 6jVr5gbCP1KtLGVB5SMdhkc4gsVTYqoV5OthWDjA8kmclqqfH8bwSo4jcUrTaZ+AJ8PA7t11PMsMJf4sIXOcS12xPHhwWko/8jbBMDmkSJqUV7a345az4hOr5QsBHDZAQJTO+evfsbQ/W8Vaeck7mAo1Zr0fuUGg+jhh1BOsozjsmJGK3IqDbX66dNpCbFlH48Ss74/l9O/zJGWKb/2AgRbbErmnjSIsVCJpH2SIboxWY4eF2FU/NnbaZelOKdr/rEiJdY9eOcoHTk+RBO1qg6MVCifCD4+jr+A+406xksIExXWgLxoZzW9rtCvJLUxEEDlC+a3+ZqDYgyyqrtcizaYlXMwK17VMzmyJsss6yfoAOTgoj41Fb7BZcO75q8/+iXr08+d39Wr1Tom5awwpfg6j5vMQGSQK4ZdGRNhuKuoeYd3z/2gXy2Eb1nLxT16tUBiktLDLhh5H2TKC6/iWPmk3CP1wdgDCO/IrpebRS12tymNdOcZ4oQvlkLDI6zbF5+fv5u9Ak7hH9/CqA7ZgKs7ugRw6u0+MrJ6D3IneblWZvtNtGjfQRVQeFAVwyADJlV5o63YoW2TmuEpNz4sFsltvm5BPdvBL/OB9A/VgESkoTZsby+SJRAs/N9873isJ9KGZD4SG9sdW2kJR6SLStAr9Mgoj2uZHBeslagY8VbdmjLdUHjn7EITTq15fj8zI8BHntqi72+UsE9QpBH+I1PW37UQEbZsQpptXNAVEgIwSCBMPynAGASKxjCL6z52OyYM2CrZMHjxcvPZJOT/X+K66cRDTDhVBRENt45k18hHmtAn8xBURAY1fcgles8Qsr8A+oklegMOYCR6MHolQiwA+NZ+SQLMcbSddV/BlnKloD8HJ3S+eBLQOQ8Jg8fELAd7S6UDDWIkjfLPfOL23FFJ7h0xcEq9p/+euf64Z3Ok8eAwxd8m8HWwuv3fpVODYwuskCpp47AXqGvNcfM/+JIxomLOx43nb9odl3FBu4cH9AD3N4q1cf/jw/mA7GoNS3jOD+QM9nue2BN4EU/iCRbwcZAp0BuIZfiF/PsW1xdqGvHJRCK2PHfa+h2U33eq4Qdq56vP9l4z76/eAkpMFGpcHP4EibRN1xhX2AJvEhJKX+eP2thQCUl0Ajgsl9dYj5vSKMTeweRbZUpDgOpwIfdc/rDlTSyXvwiKCloFMFHdIOLDrdEY3vMNvS6fJ2UB/pl4MDGnVJDZZ9+NOYw6PNtfsyvimE16uk0BhdwjWMN/JDzSqN2RiIX2a6+oHK/iRkfMNY0+g/Ua3m+szW/j3xyLlRYIL5iIf8m8q2i7nqWxyB4A0+ap5ClbZZriygChjTQ7OArUnhcLIG7PlUjDcl71q8N2XuaXQ3EqafFAy2KBIVGh2H8GDzmxlruGAj6BD85UeDZGbWREWhiT7JXGwGQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230037)(376011)(1800799021)(82310400023)(36860700010);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 00:11:08.8569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71b52e57-e779-4407-a911-08dc8f2b278c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003447.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7342 This event is handled by the RDMA core layer. Signed-off-by: Max Gurtovoy --- drivers/nvme/target/rdma.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 689bb5d3cfdc..29860acdb335 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -1520,10 +1520,6 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv) case IB_EVENT_COMM_EST: rdma_notify(queue->cm_id, event->event); break; - case IB_EVENT_QP_LAST_WQE_REACHED: - pr_debug("received last WQE reached event for queue=0x%p\n", - queue); - break; default: pr_err("received IB QP event: %s (%d)\n", ib_event_msg(event->event), event->event); From patchwork Tue Jun 18 00:10:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Gurtovoy X-Patchwork-Id: 13701561 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2043.outbound.protection.outlook.com [40.107.92.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4274217F8 for ; Tue, 18 Jun 2024 00:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669479; cv=fail; b=LsdZZVIFSLT5axptdpyjR9ItjlUkWurRZwdu92Id4cD8MwQ2jWSaBrSPB26YfRpdZlCXcCDv8WPZlkss0zV8++HvyS42eZEA3dHXY/RIq66unR+mCwDYck9Gzm9l7Ktfoweay8t/7IZuSx3RvCCv1jbf7yWRMvsW7xIjGhD9UGM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669479; c=relaxed/simple; bh=OY4T3ExSiPTe6A7goU1liTz/xG1uo2f3YORBLM30ynw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d42nm9BnFZBnFUZXX6Zw3KXDgiJVyyV1H88u2/xuWcdxIdBTusbuOl1vZM6ZGi9c1gq9CsYSIMsMqDlvyA6t7fGzcv4p2U1txETNVpVIzmhY5WwvqZY9fsg7Ie5+RCmLjPakNDyGjlfV/JmOoYOgJAHgw+iYdJK4ZmdTiJmBpXc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HrIPvIpj; arc=fail smtp.client-ip=40.107.92.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HrIPvIpj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgTyQfy7Ep8hG+5DfLhlJPkDrUUhw58MF9JcPEB/CMP/rvA0nr2ODHignF+0e7yXNtOBCL+1en7kvNct1jak3Y19/SANCHwnvkQLmT3CwynP8b9b7R4sRnSUjjGpUu4poyrwNKbQkj1CneMGoX7WxthDAFaSJgBCYAHkYgIfTp7nDBzIm9xIRwqG3ddStX87BR3cDSKnUFEF+63eDXdB7CR4Xj4gCLps/cLj8TNpZ9MURyBcRem3yVR7o29M/Xl0vhRRGikq3KouS8sB95jyjT+N6ffU039zYgJnfcBtBEr2YoxX12n741l181Y8uSRHQAndpKDWs3vDEcDmKVhyhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BuHzdaejW+5/5z4bCGKOnLS08iIq08U0+dDHF5Hjmo8=; b=LR6gtcIV/NzQq4UeVP/vASuLQ6n/kSD7GLa1Q4Wsw4112wu8Cx5yDPKdBZJoincctqjX8484odJiahF8zVVLaYZVpEuasXNYrfEPNJLW+92vCUZoYj7ihp22qJjW2e8wB3RZSi4r8+IGk3Vclq2Npz39h+pyiIxogic57srF1/1SZHAtuBs8lNpW23A79NLunYBRXQZLVdTnbLz6EL4Kbw1AbaftDLlJ3fQGKPqRItz0Bp2j1+cNjzx2NhKLzJRDkvyaG6lkPLYGnUR1h07+lOlNR/f8WH3FIA9DxKD6pYlsd3awHInXv08xFgiIiwoFKMBYPo43VlJb7yrGaZ3MvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BuHzdaejW+5/5z4bCGKOnLS08iIq08U0+dDHF5Hjmo8=; b=HrIPvIpjTYaN+3vYEQYRYxp13UdpcIx79Noh6xU5D1YzCmqNmeEaO57m2TBx1lm6xkX/IHgDtY/hBwlSDJvnGrYYcZ5gykGvZdWcKtlrlO04dv7Esfvj0NHgx3phzD1MjbRwBxWfegyKQoBYSsmyvBvqqfve3vjqyDLvraFuIT3LXlGHo5hdtixcNMrBz5HO7kP8TOQN0huvOR3zomhRY8OEWc8sHMwIrse3pjoD/mvpocngUpEBxZOpVKwe6o+y4Jw1MvOBdtRVCmj2Eo7moP17EwWR1wAGbPE7r/Gn042dJGBXVh/dG1Z0sDd9um/pE2MWnhiDEibbPDSz+f+1Qw== Received: from SA1PR04CA0014.namprd04.prod.outlook.com (2603:10b6:806:2ce::20) by SN7PR12MB8436.namprd12.prod.outlook.com (2603:10b6:806:2e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.24; Tue, 18 Jun 2024 00:11:15 +0000 Received: from SA2PEPF00003F61.namprd04.prod.outlook.com (2603:10b6:806:2ce:cafe::ac) by SA1PR04CA0014.outlook.office365.com (2603:10b6:806:2ce::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30 via Frontend Transport; Tue, 18 Jun 2024 00:11:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F61.mail.protection.outlook.com (10.167.248.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Tue, 18 Jun 2024 00:11:15 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:11:00 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:10:59 -0700 Received: from r-arch-stor03.mtr.labs.mlnx (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 17 Jun 2024 17:10:56 -0700 From: Max Gurtovoy To: , , , , CC: , , , , , , , , Max Gurtovoy Subject: [PATCH 5/6] svcrdma: remove the handling of last WQE reached event Date: Tue, 18 Jun 2024 03:10:33 +0300 Message-ID: <20240618001034.22681-6-mgurtovoy@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20240618001034.22681-1-mgurtovoy@nvidia.com> References: <20240618001034.22681-1-mgurtovoy@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F61:EE_|SN7PR12MB8436:EE_ X-MS-Office365-Filtering-Correlation-Id: 82353845-5ed5-4a9d-a30f-08dc8f2b2b7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|36860700010|1800799021|82310400023; X-Microsoft-Antispam-Message-Info: hQam8QpImz7ubivw2pUn4eU+RH5b9GXtk8IaH/aEFnxAhxoke+fKC7n1Qitb72GN4DC0LqCoC0W7QFBnI+BPWS+1T1z4v6ARKZhJ+09W3t/FWAmRuKCHN5bqzobYSedeDRbRHqTQqswFkog45UDv232u+vlojRRjV1NCNGcXLebgfaRmuD1Nu3GaMZi7kcM7qXg+4duz2IQlU59W38COTC4IDj8MnkoSY7aBQRwzMQPyIt7yUW8yz8OntBwYdmlxMjrIbWkjmEBOLuB0VJGgUMi3hJ7V1KcmfX/9u2oWv8p5enzPEhzAj6vOY3KiweYaLUpso08tfqFNbhLhD0EFQqVAeOumpRTBbuIG1eneHeGOHi12rjCs8QaUaOA1/C2DBkNh4fENr2j0Zvy6AeSVrxopR+g3kPaI25794/yD4wbCtg/u2e3TQNMvETkubAgPXhOfTH+kr7Ntj1yFofy5jKVxkdebbdocRONnP3+gQyiXAZrahsD1GGRl4+mBdL/ojucmvT2p2M1biYgK9L6atauXqw1oCxbaKBFH66HFNeoYCuakaE5Qdbn2w5AY+ZQiF9LgK8LriPFGZ2RzbDS0lz0ua4i3t5fK10FcwD7Lx3SUIOVYaxxy+nul0COnCA7wF2jPXuqGxKMug1PjuKY0eiAz/hTYq+5EOhSyCERke4K5GEwA1K2d+b8oJQu9neGrIoTuN+H0EBtWFtTECJu2dB+SG5TSdWZ+onUSUnZub1hoOyTBCWHi37+PfUNNMOYo4Or014Ca9uUTusqa9qlOXxHFUOcCxogIblPTGHx9Tg7nfCAn0hhReaXtAx5jXEE/GyXFZ8Dk4/BDTOHa4jp3QKzWZMQykowf4ZULUI0md5NxV4PU/tYr1Bi6HRus+BLBKNIJvCbSSitUxo6lTBA5ets/SmjN+fBi4IlJeUrThMwJqfAhZVM9fu7CiYGaFYYIIc/fNMOLCjSBmCIzTPeVRCLP45Luah0BrmHvn76PEJeklSFP6MEKF6Sb4PbZ16o//pimA/4BLBJSvS285D0OpilEVwz3Z9fo/3knMHspi6AfTMF0Yv4kIirWXUyfUZ1vGmKlqK/CtN9yxMDnEqLPIHnOQ9g92gkQQ5JQTTAgpqjSvjQ2MrpaL26fnomwPsN1cf6bDW8lj5hKvhV8gb+pU3NwZzFeg4DPAiRQO8jOrzGSb8uOdgebxowe442IpUQ0VOIXPF3FUrcT/ICUHdcBPg3jRGuASfM1eoDOCEg9XE1/Y70BKkWslTb1CRs884cA47aFhkslekkLIZ/sIuTu/tWczFtTSvz6WUaosZCLlv8Zlq8c/nHmbmF16c3lje8W62W34H88F6ykdFJot0H5OrTYi8UueAZiUnh5DhSfDbtVkc5GS+q/ie/iNE+R8jX0k2HT/qArfxExWN92zSnw1g== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230037)(376011)(36860700010)(1800799021)(82310400023);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 00:11:15.3872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 82353845-5ed5-4a9d-a30f-08dc8f2b2b7a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F61.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8436 This event is handled by the RDMA core layer. Signed-off-by: Max Gurtovoy Acked-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 2b1c16b9547d..4bb94b02c34c 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -107,7 +107,6 @@ static void qp_event_handler(struct ib_event *event, void *context) case IB_EVENT_PATH_MIG: case IB_EVENT_COMM_EST: case IB_EVENT_SQ_DRAINED: - case IB_EVENT_QP_LAST_WQE_REACHED: break; /* These are considered fatal events */ From patchwork Tue Jun 18 00:10:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Gurtovoy X-Patchwork-Id: 13701562 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CC3BEC0 for ; Tue, 18 Jun 2024 00:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669490; cv=fail; b=TrYpRvGShTcbNSTlI2KNSO9/gg9Au6rCCPzSd28sodBzoR0KylGv0Hc6crMbaVr+mwx+5r70axtmJzKakNqWBgiXxBNoJ6QGx/BV8JqvPi4z86POiieZB9oYMjMAGBZGZdzZjpsPeOMXohelCp/8BRGnCdOKY/1QF8Dv7ZcwfaI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718669490; c=relaxed/simple; bh=jEA3DL6kOho/Apceyp4mIIeXVaoVFCysgsfHsvx5mM4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h22wOQCEo0KQPBpx9xruWduI7ADgM8M88Ci8GW+TJkGVgYgiOMkdYgThINOUCUMOW8z4nSdlgrDJ5flU1pofDDbyV4nYcbvqAHQgdfMUMsXNLdSh6JYSWGOCzAoxP+Xxj6k+kKIX69asF3EdJyQdsRGIgPtOBQFVlX8c2pLfMvU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=iORyRVYl; arc=fail smtp.client-ip=40.107.223.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="iORyRVYl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyM7so9qpkKVVBIjADmntjRhTkv6ciSwPdwbxcKg+mTWEOuNHqs3B7kqaqIyLmdH9FaBYVEYvyDtZwquiVvJ3Pk6iuMzo9HZcQL3zlOaLL7eYUvRWvghXC/97hM8X3GLKVmuVRYtHSis1iUTW/lJUS4QXiJPBlfwi5GNdYRtTo1zi8nwITE/iVgABAcV5tJR2QQFNZvC8nuMAvkdno8r2EHeNa1sPLplidNRLTKCBYnST2w1PUkARgYXnbH0um66CnKE70Q3we84BTHwCpehsWiiqPqscny2QKdN56hPg5XeKZjONClZQLacxH/gtNqOVXIAkCAjbORSsIVXiPQUag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tk3CkK/FLqpzgGWwd0+Htl86hXqhHKAXdjbwIrb839k=; b=eQgKb3RV4Vs9EyA7JOJHLUakkTLGZXxVHeBlfql8arbJDCOAA4ActQTIemU88WZxI/6Im9GSyD5QX5aDORuBndvhi2rvarTP/zzWSe0SBtCvbVqMMSlX2J8i4KDQPfQR18dKgIcl9HFQpyKrRsDAL8mQiIiwN3zhi5rivbKMPL1/L4Eqkp6FNTd1AogQOIb3ZeDeZBIPNWYK7fpBlI3LnuUiJ1FWKpOpokca4aEnnHfyuOKczTh3numwEQwLwxj40cOrS1umU0gb3QMVJzeNr1Z5r0OkeJ4g+pcqRZoxkfoIND/Lf7tGlgAVPWJ0EzSZJTGlnUS3Ti3B9UkjcmseDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tk3CkK/FLqpzgGWwd0+Htl86hXqhHKAXdjbwIrb839k=; b=iORyRVYlbJjycZMfa5ZzlfKhGLYZA2Y+ic5IsUEVimv4opwkKThlPjQ3Ql46InkbP08up9oY4cmuxkU0XOHQGcFnxcevNDDEpB4lWXjZs1WosUWAHG3IHv3gR050+5HuupcTJzmj1f711HwMvT+Wh47yW7dl7WcTcowKy0huEtFGZugrpPtkRFQb2sbLkLKXuCDkiXGJNLEuAsaAdqw1/mBMTmIKaZA4gkhdThiCVvVw5amodFX5ncaicgQdk8kfcxjMGx2X4H/dQB0Q9KVl2XyCOnYBxCajRN1jsHgXlB2cP4tSfg+lYImRhpx/Ie51YE8YGxrIYJ6H7JrDYVP9ag== Received: from SA9P221CA0001.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::6) by PH7PR12MB6612.namprd12.prod.outlook.com (2603:10b6:510:210::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 00:11:22 +0000 Received: from SA2PEPF00003F63.namprd04.prod.outlook.com (2603:10b6:806:25:cafe::2) by SA9P221CA0001.outlook.office365.com (2603:10b6:806:25::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Tue, 18 Jun 2024 00:11:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F63.mail.protection.outlook.com (10.167.248.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Tue, 18 Jun 2024 00:11:22 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:11:04 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 17:11:03 -0700 Received: from r-arch-stor03.mtr.labs.mlnx (10.127.8.14) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 17 Jun 2024 17:11:00 -0700 From: Max Gurtovoy To: , , , , CC: , , , , , , , , Max Gurtovoy Subject: [PATCH 6/6] RDMA/IPoIB: remove the handling of last WQE reached event Date: Tue, 18 Jun 2024 03:10:34 +0300 Message-ID: <20240618001034.22681-7-mgurtovoy@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20240618001034.22681-1-mgurtovoy@nvidia.com> References: <20240618001034.22681-1-mgurtovoy@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F63:EE_|PH7PR12MB6612:EE_ X-MS-Office365-Filtering-Correlation-Id: c9514193-e4e1-46ba-8c96-08dc8f2b2f79 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|36860700010|1800799021|82310400023; X-Microsoft-Antispam-Message-Info: X7IGNXOHsWSX+OXHSwxku5dy9VewbJhvw8S+QfteVjixs17N1jMcL44zSm/PqyFqa4bhyiV5NuFymAFb64PEKeG1vb80RMsM+2z1zFUlGPLBK2fW5Gt5iSc8iVB25J1SGM3HNR+pYiQetUlgRknHHOreMT30+ryjVRQT7NbdKYQqr9p7r8IFBQMO631sDPW5xMZk/XAiiwI3PLvuw5LqQHL+Ved3K/KsjXy5udyanos66htCwjSKw+fuJS3bmhxuhF+48qURzvvrXZvG2eRTXULtjpHjZTdfgweKQTteXA+SAeK98Zi++NHEBsSN0PmmigBmvjLuuQWDAqkLAYuExRB3Uaq4DArXcvuR8h9yjDn+yG5pdk4r5VPSGZsT+wOS9gTouKEPPVrdFzFpOEL6Q0h8a2ariTBI1BYkOssuZOFXb6U7d4L1vOLYodxdK9lNB9tNV+RXB65MDqrB0LwFJfSsKCN027N80gr21K9RcN4KEMmfnkKTBMx0DAl9bMdB7ERKOm1hCuqArgsk+Ury2pI0ZbV7opLDq8NS5Wltp4Y/3hL1vt0cwy+3GZDiylXuNYh9rcJRlIBT7wxNkoDqSv2Bo9PKJpvBxFSLpJ25NMZxocvu2kvHUHdURRqv4UleRgsxpFibow4DK8unKJcl2h218Av8fvlaAbl8FMcIBXHC8C8V6W4vxgx5WWFGF5NMUthL2v0+rGj21LNYT0eeD5pe94nvFDnFY4bo4EB2uSgJO2vSOBYPeUGfYDBdy3zt+XBM20VECcw/lpc9fKfmKYZWZuWJ0Y5z+xb51PHMX1Y4MGijbgvO0OFWU3WmhxZwdR6eECdHhVh7HGiyPDTdeVJS2f79eHraGlz0/5+HOxJNpEPPLBE3X0LKbyBinG2kAWqiWK0tkW5ToeMBkK1gPsvD7tmnfbcHbD7dgQUVuZ3Xy9hqZwTItOm2TvSK67cofAIVRxgrqihdiaoLdVL7TYYXGWqseaczNcvTklrWoDhyRB74PpRWGBXHFV7Xnap4iqhyuC1fiPDpSMZU7LtzWEp1yRZQBMvuNjd+UmJBCR5AhLMZwVpbhMEwjF+9dy7oBdHCLNrLzpg0VoMhVEYhHg6tlTx5Qf9Fw73xzNqHpGLAv3/EtetQZmY90jJJG27x0nDil9z0mhYQgRsYYj61lH2Mv+pprH4IYYz9wlgmZMvP2+CfB8HQZfohZKfRy/NuuuWcpPFvgC48oFlCgifcA8lrmJetKwhNlDzDvF/hOfix8eNVuzBoJ8PYswH+IV0chl5ldxqMmyC7P6e0anVxsAko5OGJjjOg99gQjDDGxRfEU6FfQEAbXpSbRNpACg2BpLC22SqRLElyaS4LEIEptVxVTEo1fN6w+VfN9d5GJFfD3RCBtqn9GHFCjR4WRYTZD64hchVtIptR9fmZz/MTVw== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230037)(376011)(36860700010)(1800799021)(82310400023);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 00:11:22.0909 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9514193-e4e1-46ba-8c96-08dc8f2b2f79 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F63.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6612 This event is handled by the RDMA core layer. Signed-off-by: Max Gurtovoy --- drivers/infiniband/ulp/ipoib/ipoib.h | 33 +----------- drivers/infiniband/ulp/ipoib/ipoib_cm.c | 71 +++---------------------- 2 files changed, 8 insertions(+), 96 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h index 963e936da5e3..0f1e4b431af4 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib.h +++ b/drivers/infiniband/ulp/ipoib/ipoib.h @@ -198,37 +198,10 @@ struct ipoib_cm_data { __be32 mtu; }; -/* - * Quoting 10.3.1 Queue Pair and EE Context States: - * - * Note, for QPs that are associated with an SRQ, the Consumer should take the - * QP through the Error State before invoking a Destroy QP or a Modify QP to the - * Reset State. The Consumer may invoke the Destroy QP without first performing - * a Modify QP to the Error State and waiting for the Affiliated Asynchronous - * Last WQE Reached Event. However, if the Consumer does not wait for the - * Affiliated Asynchronous Last WQE Reached Event, then WQE and Data Segment - * leakage may occur. Therefore, it is good programming practice to tear down a - * QP that is associated with an SRQ by using the following process: - * - * - Put the QP in the Error State - * - Wait for the Affiliated Asynchronous Last WQE Reached Event; - * - either: - * drain the CQ by invoking the Poll CQ verb and either wait for CQ - * to be empty or the number of Poll CQ operations has exceeded - * CQ capacity size; - * - or - * post another WR that completes on the same CQ and wait for this - * WR to return as a WC; - * - and then invoke a Destroy QP or Reset QP. - * - * We use the second option and wait for a completion on the - * same CQ before destroying QPs attached to our SRQ. - */ - enum ipoib_cm_state { IPOIB_CM_RX_LIVE, IPOIB_CM_RX_ERROR, /* Ignored by stale task */ - IPOIB_CM_RX_FLUSH /* Last WQE Reached event observed */ + IPOIB_CM_RX_FLUSH }; struct ipoib_cm_rx { @@ -267,9 +240,7 @@ struct ipoib_cm_dev_priv { struct ib_cm_id *id; struct list_head passive_ids; /* state: LIVE */ struct list_head rx_error_list; /* state: ERROR */ - struct list_head rx_flush_list; /* state: FLUSH, drain not started */ - struct list_head rx_drain_list; /* state: FLUSH, drain started */ - struct list_head rx_reap_list; /* state: FLUSH, drain done */ + struct list_head rx_reap_list; /* state: FLUSH */ struct work_struct start_task; struct work_struct reap_task; struct work_struct skb_task; diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c index b610d36295bb..18ead80b5756 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c @@ -71,12 +71,6 @@ static struct ib_qp_attr ipoib_cm_err_attr = { .qp_state = IB_QPS_ERR }; -#define IPOIB_CM_RX_DRAIN_WRID 0xffffffff - -static struct ib_send_wr ipoib_cm_rx_drain_wr = { - .opcode = IB_WR_SEND, -}; - static int ipoib_cm_tx_handler(struct ib_cm_id *cm_id, const struct ib_cm_event *event); @@ -208,50 +202,11 @@ static void ipoib_cm_free_rx_ring(struct net_device *dev, vfree(rx_ring); } -static void ipoib_cm_start_rx_drain(struct ipoib_dev_priv *priv) -{ - struct ipoib_cm_rx *p; - - /* We only reserved 1 extra slot in CQ for drain WRs, so - * make sure we have at most 1 outstanding WR. */ - if (list_empty(&priv->cm.rx_flush_list) || - !list_empty(&priv->cm.rx_drain_list)) - return; - - /* - * QPs on flush list are error state. This way, a "flush - * error" WC will be immediately generated for each WR we post. - */ - p = list_entry(priv->cm.rx_flush_list.next, typeof(*p), list); - ipoib_cm_rx_drain_wr.wr_id = IPOIB_CM_RX_DRAIN_WRID; - if (ib_post_send(p->qp, &ipoib_cm_rx_drain_wr, NULL)) - ipoib_warn(priv, "failed to post drain wr\n"); - - list_splice_init(&priv->cm.rx_flush_list, &priv->cm.rx_drain_list); -} - -static void ipoib_cm_rx_event_handler(struct ib_event *event, void *ctx) -{ - struct ipoib_cm_rx *p = ctx; - struct ipoib_dev_priv *priv = ipoib_priv(p->dev); - unsigned long flags; - - if (event->event != IB_EVENT_QP_LAST_WQE_REACHED) - return; - - spin_lock_irqsave(&priv->lock, flags); - list_move(&p->list, &priv->cm.rx_flush_list); - p->state = IPOIB_CM_RX_FLUSH; - ipoib_cm_start_rx_drain(priv); - spin_unlock_irqrestore(&priv->lock, flags); -} - static struct ib_qp *ipoib_cm_create_rx_qp(struct net_device *dev, struct ipoib_cm_rx *p) { struct ipoib_dev_priv *priv = ipoib_priv(dev); struct ib_qp_init_attr attr = { - .event_handler = ipoib_cm_rx_event_handler, .send_cq = priv->recv_cq, /* For drain WR */ .recv_cq = priv->recv_cq, .srq = priv->cm.srq, @@ -479,8 +434,7 @@ static int ipoib_cm_req_handler(struct ib_cm_id *cm_id, spin_lock_irq(&priv->lock); queue_delayed_work(priv->wq, &priv->cm.stale_task, IPOIB_CM_RX_DELAY); - /* Add this entry to passive ids list head, but do not re-add it - * if IB_EVENT_QP_LAST_WQE_REACHED has moved it to flush list. */ + /* Add this entry to passive ids list head. */ p->jiffies = jiffies; if (p->state == IPOIB_CM_RX_LIVE) list_move(&p->list, &priv->cm.passive_ids); @@ -574,15 +528,8 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc) wr_id, wc->status); if (unlikely(wr_id >= ipoib_recvq_size)) { - if (wr_id == (IPOIB_CM_RX_DRAIN_WRID & ~(IPOIB_OP_CM | IPOIB_OP_RECV))) { - spin_lock_irqsave(&priv->lock, flags); - list_splice_init(&priv->cm.rx_drain_list, &priv->cm.rx_reap_list); - ipoib_cm_start_rx_drain(priv); - queue_work(priv->wq, &priv->cm.rx_reap_task); - spin_unlock_irqrestore(&priv->lock, flags); - } else - ipoib_warn(priv, "cm recv completion event with wrid %d (> %d)\n", - wr_id, ipoib_recvq_size); + ipoib_warn(priv, "cm recv completion event with wrid %d (> %d)\n", + wr_id, ipoib_recvq_size); return; } @@ -603,6 +550,7 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc) else { if (!--p->recv_count) { spin_lock_irqsave(&priv->lock, flags); + p->state = IPOIB_CM_RX_FLUSH; list_move(&p->list, &priv->cm.rx_reap_list); spin_unlock_irqrestore(&priv->lock, flags); queue_work(priv->wq, &priv->cm.rx_reap_task); @@ -912,6 +860,7 @@ static void ipoib_cm_free_rx_reap_list(struct net_device *dev) spin_unlock_irq(&priv->lock); list_for_each_entry_safe(rx, n, &list, list) { + ib_drain_qp(rx->qp); ib_destroy_cm_id(rx->id); ib_destroy_qp(rx->qp); if (!ipoib_cm_has_srq(dev)) { @@ -952,21 +901,15 @@ void ipoib_cm_dev_stop(struct net_device *dev) /* Wait for all RX to be drained */ begin = jiffies; - while (!list_empty(&priv->cm.rx_error_list) || - !list_empty(&priv->cm.rx_flush_list) || - !list_empty(&priv->cm.rx_drain_list)) { + while (!list_empty(&priv->cm.rx_error_list)) { if (time_after(jiffies, begin + 5 * HZ)) { ipoib_warn(priv, "RX drain timing out\n"); /* * assume the HW is wedged and just free up everything. */ - list_splice_init(&priv->cm.rx_flush_list, - &priv->cm.rx_reap_list); list_splice_init(&priv->cm.rx_error_list, &priv->cm.rx_reap_list); - list_splice_init(&priv->cm.rx_drain_list, - &priv->cm.rx_reap_list); break; } spin_unlock_irq(&priv->lock); @@ -1589,8 +1532,6 @@ int ipoib_cm_dev_init(struct net_device *dev) INIT_LIST_HEAD(&priv->cm.reap_list); INIT_LIST_HEAD(&priv->cm.start_list); INIT_LIST_HEAD(&priv->cm.rx_error_list); - INIT_LIST_HEAD(&priv->cm.rx_flush_list); - INIT_LIST_HEAD(&priv->cm.rx_drain_list); INIT_LIST_HEAD(&priv->cm.rx_reap_list); INIT_WORK(&priv->cm.start_task, ipoib_cm_tx_start); INIT_WORK(&priv->cm.reap_task, ipoib_cm_tx_reap);