From patchwork Thu Jun 20 08:05:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Zhaoxiong Lv X-Patchwork-Id: 13704931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6CB0C27C79 for ; Thu, 20 Jun 2024 08:05:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 113C110E2DB; Thu, 20 Jun 2024 08:05:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b="QbHhfFyP"; dkim-atps=neutral Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB06210E84C for ; Thu, 20 Jun 2024 08:05:26 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-705fff50de2so439528b3a.1 for ; Thu, 20 Jun 2024 01:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=huaqin-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1718870726; x=1719475526; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dakUGhqrnLzB9mnNo0IKnWBzyZqbbKSfGuNLa4v3K1U=; b=QbHhfFyPpYq0d+612pHCDpSIZdUZJZmYjlfcFQ2TqEqPt2lBJDpatkNBxoNKql0tg3 KeMiHXtw52MuCFVjsP8ck5+ldRIJreVWbDPgIvbNaIpxW/hmcsNn4qtV4qaJ3oiECC8c 7Vj2tUNigDEiUinhGlVxafbA9IBcRXI/YONSMg44qjlG8JScGih8hKR2zBUipvSIFYjX JGGKhyDL+N/DZtPRE9N9SU6FusbU9ExZDlDoos5LwaY/2uCdeK9TP7bj6rOXVFsAo9NZ 6SyuS5o6+90/3eUGC86R31R0Vi6AcZTDvjbydNLaXnPEhcb2ZrFBMcq0b3NsMASfS/sA IhHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718870726; x=1719475526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dakUGhqrnLzB9mnNo0IKnWBzyZqbbKSfGuNLa4v3K1U=; b=u1NykPjAYoe4QIxbBHaRlyPl+pIOm9FiCCb9dSHC1lj9yOoFDZVfz0EMqPjIWbWmbU 5LTAmM/W4SQOaM8NrnHcRhdSxJBNjxmU2/3k+QH92LCRzx5KOaWdFiRK0HfZ+Je6Lhd1 HRd/lS9435zYlqNMDH/GDC12mzX+4zlzLAH1CF+Q2ILIi5lfQEn+2uiWeDAI3xTHdffI +RtYqMeTu1jpsH5VRWSanHeA1H+A83PkJQPJEXrd2yG52OBGHLvo2JDFTwQwaR/QfM5P fKu02tEr8XCkDAXBYvbSIlPkuDdHBOygg71KDcnoQfJ3bk4ww4LU1VkeQzpNPy+AqmMB yq6g== X-Gm-Message-State: AOJu0YwqfIBEUTaEd5Ogrjm0zZnSfetflI+6KatbDWwroL0iU5sXOYv2 Mzgzj5TJywWdv7A2sXiUSSftOeWDGEORxBqwhMjx3+1YqGvXLv/9OhR0AXghAaQ= X-Google-Smtp-Source: AGHT+IGIgwZB7KgN6IuNTo5vHCsjNBlcvHNhq8+jPn9RYvIJI4rtbggqu0AMU3iWTk7RGtK7PqiiHQ== X-Received: by 2002:a05:6a00:8993:b0:6ed:825b:30c0 with SMTP id d2e1a72fcca58-7061ac2e955mr9532567b3a.15.1718870726368; Thu, 20 Jun 2024 01:05:26 -0700 (PDT) Received: from lvzhaoxiong-KLVC-WXX9.huaqin.com ([116.66.212.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc96c8c5sm11805889b3a.58.2024.06.20.01.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:05:25 -0700 (PDT) From: Zhaoxiong Lv To: dmitry.torokhov@gmail.com, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jikos@kernel.org, benjamin.tissoires@redhat.co, dianders@google.com, hsinyi@google.com Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiong Lv Subject: [PATCH v4 1/4] drm/panel: jd9365da: Modify the method of sending commands Date: Thu, 20 Jun 2024 16:05:06 +0800 Message-Id: <20240620080509.18504-2-lvzhaoxiong@huaqin.corp-partner.google.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> References: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Currently, the init_code of the jd9365da driver is placed in the enable() function and sent, but this seems to take a long time. It takes 17ms to send each instruction (an init code consists of about 200 instructions), so it takes about 3.5s to send the init_code. So we moved the sending of the inti_code to the prepare() function, and each instruction seemed to take only 25μs. We checked the DSI host and found that the difference in command sending time is caused by the different modes of the DSI host in prepare() and enable() functions. Our DSI Host only supports sending cmd in LP mode, The prepare() function can directly send init_code (LP->cmd) in LP mode, but the enable() function is in HS mode and needs to switch to LP mode before sending init code (HS->LP->cmd->HS). Therefore, it takes longer to send the command. Signed-off-by: Zhaoxiong Lv --- Changes between V4 and V3: - 1. Only move mipi_dsi_dcs_write_buffer from enable() function to prepare() function, - and no longer use mipi_dsi_dcs_write_seq_multi. V3:https://lore.kernel.org/all/20240614145510.22965-2-lvzhaoxiong@huaqin.corp-partner.google.com/ --- .../gpu/drm/panel/panel-jadard-jd9365da-h3.c | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c index 4879835fe101..a9c483a7b3fa 100644 --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c @@ -52,21 +52,9 @@ static int jadard_enable(struct drm_panel *panel) { struct device *dev = panel->dev; struct jadard *jadard = panel_to_jadard(panel); - const struct jadard_panel_desc *desc = jadard->desc; struct mipi_dsi_device *dsi = jadard->dsi; - unsigned int i; int err; - msleep(10); - - for (i = 0; i < desc->num_init_cmds; i++) { - const struct jadard_init_cmd *cmd = &desc->init_cmds[i]; - - err = mipi_dsi_dcs_write_buffer(dsi, cmd->data, JD9365DA_INIT_CMD_LEN); - if (err < 0) - return err; - } - msleep(120); err = mipi_dsi_dcs_exit_sleep_mode(dsi); @@ -100,6 +88,8 @@ static int jadard_disable(struct drm_panel *panel) static int jadard_prepare(struct drm_panel *panel) { struct jadard *jadard = panel_to_jadard(panel); + const struct jadard_panel_desc *desc = jadard->desc; + unsigned int i; int ret; ret = regulator_enable(jadard->vccio); @@ -117,7 +107,15 @@ static int jadard_prepare(struct drm_panel *panel) msleep(10); gpiod_set_value(jadard->reset, 1); - msleep(120); + msleep(130); + + for (i = 0; i < desc->num_init_cmds; i++) { + const struct jadard_init_cmd *cmd = &desc->init_cmds[i]; + + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, JD9365DA_INIT_CMD_LEN); + if (ret < 0) + return ret; + } return 0; } From patchwork Thu Jun 20 08:05:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhaoxiong Lv X-Patchwork-Id: 13704932 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6190EC27C79 for ; Thu, 20 Jun 2024 08:05:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9952010E84C; Thu, 20 Jun 2024 08:05:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b="nEGOZi78"; dkim-atps=neutral Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 132B010E84C for ; Thu, 20 Jun 2024 08:05:36 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-70635466708so587117b3a.1 for ; Thu, 20 Jun 2024 01:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=huaqin-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1718870736; x=1719475536; darn=lists.freedesktop.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=/Y8D7obmprqKPMpE+xyGcQQXo6scFeZnMh+CrPUj1ro=; b=nEGOZi7864jXhW/D0WGTvWXymGXSgEWs05h9FJlIjzHFxF4jSituiVtXQYGDonwxBp vljAdwqZSWOidrGleNKrvtMmqkfORrAJTe+cDtjEEylp9yJiINr4nCLYtzCo0VSEAj00 nLef87/71W9pw6YR51nGGvMRmDnIad5/SgbHNNKxZrhOH/Pkjlj4UOeYzPEJlropqrv8 QGcC8p+oSniS6DSm2JVpZD2rPOGuu80+A5fC5BnCRL1MTtev7r+fapfVBlRXN/NqGqni IPHBq4Kl45VZGpexmjDkFWWlwFb54SL7RcXFv6C89fYbdinuMZeVGzI+RaCMLdKV8arB y+1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718870736; x=1719475536; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Y8D7obmprqKPMpE+xyGcQQXo6scFeZnMh+CrPUj1ro=; b=i2R0skQ0ooBYeo+yGvz9XN2hI58KbY/nbqMrbhrUbkzsIZjIAhxXmlUA9uR2mg3kWr gY0wBfU/1q492sQuJq8KTYFrmQ9RxJnqHJzLecoDu2m85/Q5lY1uDRFny71nEXSVTPhr /eRyX1u1NvJIr6tc6HQOf/GYRPlcEbM9hBxW0s2VgFc6h92bxzeoPFbROioBqgVx8XJ+ dzwki+6miAEYkPk1L/UfS/gpZrpz+QYayvOO9UlTxtgwZppP3kEUybb6bZ9UQ0aRNXuF WiqJtUfsqP51OchEAoIxruOVkEmFEclmmAHxo0J5ogWbm0lFrQIG3nMZ5hRJC3H5tUo6 a7aA== X-Gm-Message-State: AOJu0Yz30TBf+9bCNJw96EImQZjC4PAjajP7cF62WmoIOuwjWTQyJ3N0 pIWazzLlrWAoJFnI6N5+lq5dKcQG63x7CxbHBguxCQUMwJurRyOm5AuSoSn6YEU= X-Google-Smtp-Source: AGHT+IEWX7tMPhLCy+EIc3J3GNxEI9rtrbsuhv+fhFcIU85LqU78MlejcJmdCThiVyNmkHK565rXEg== X-Received: by 2002:aa7:9e8f:0:b0:706:3405:fef7 with SMTP id d2e1a72fcca58-7063406032fmr4114904b3a.24.1718870736448; Thu, 20 Jun 2024 01:05:36 -0700 (PDT) Received: from lvzhaoxiong-KLVC-WXX9.huaqin.com ([116.66.212.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc96c8c5sm11805889b3a.58.2024.06.20.01.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:05:36 -0700 (PDT) From: Zhaoxiong Lv To: dmitry.torokhov@gmail.com, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jikos@kernel.org, benjamin.tissoires@redhat.co, dianders@google.com, hsinyi@google.com Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiong Lv Subject: [PATCH v4 2/4] dt-bindings: display: panel: Add compatible for kingdisplay-kd101ne3 Date: Thu, 20 Jun 2024 16:05:07 +0800 Message-Id: <20240620080509.18504-3-lvzhaoxiong@huaqin.corp-partner.google.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> References: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The kingdisplay-kd101ne3 is a 10.1" WXGA TFT-LCD panel with jadard-jd9365da controller. Hence, we add a new compatible with panel specific config. Signed-off-by: Zhaoxiong Lv Acked-by: Conor Dooley --- Changes between V4 and V3: - 1. Move positions to keep the list sorted. V2:https://lore.kernel.org/all/20240614145510.22965-3-lvzhaoxiong@huaqin.corp-partner.google.com/ Changes between V3 and V2: - 1. Abandon the V2 patch and add kingdisplay kd101ne3-40ti binding to - jadard,jd9365da-h3.yaml again. V2:https://lore.kernel.org/all/20240601084528.22502-2-lvzhaoxiong@huaqin.corp-partner.google.com/ Changes between V2 and V1: - Drop some properties that have already been defined in panel-common. - The header file 'dt-bindings/gpio/gpio.h' is not used, delete it V1: https://lore.kernel.org/all/20240418081548.12160-2-lvzhaoxiong@huaqin.corp-partner.google.com/ --- .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml index 41eb7fbf7715..2b977292dc48 100644 --- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml +++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml @@ -17,6 +17,7 @@ properties: items: - enum: - chongzhou,cz101b4001 + - kingdisplay,kd101ne3-40ti - radxa,display-10hd-ad001 - radxa,display-8hd-ad002 - const: jadard,jd9365da-h3 From patchwork Thu Jun 20 08:05:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhaoxiong Lv X-Patchwork-Id: 13704933 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5522BC2BA18 for ; Thu, 20 Jun 2024 08:05:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FBF310E84D; Thu, 20 Jun 2024 08:05:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b="q2yi4IfJ"; dkim-atps=neutral Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id 701BB10E84B for ; Thu, 20 Jun 2024 08:05:44 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7062bf6d9a1so490353b3a.1 for ; Thu, 20 Jun 2024 01:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=huaqin-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1718870744; x=1719475544; darn=lists.freedesktop.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=dn6UDOWgnuz6zvbbDETQvZyfl1lcf55ZCdpjJoB45yY=; b=q2yi4IfJEwLbsCehYVcL/ufFlFSEUGQJcB61L0059cdKCM5pyDQyim0OEpZfy6QDCX 1aGNmgJkt23yU7MTPdWexL75e74qeNACLZSWfdEAkz4JF5t3IyHtEX/6E7BNaqaSKFF3 yA/1auXsX1BENIlpG3SXu5obIocZ+kPrcO7mvX6u0y6RS2oo99KtreRY6DNAPRdZecN6 IPAf3icIcTghwXQ+Se+ffl9g12seYhc+NOyOmsNQJWZk9s7gJC8wdaPDWY5oDQq+0HAO o81grBQh9hfx3tREQUvn/RNrd50WtNAy9EE5uZQOvyB6v2GTbagoBl/yIQ4UgWbC07LJ F88Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718870744; x=1719475544; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dn6UDOWgnuz6zvbbDETQvZyfl1lcf55ZCdpjJoB45yY=; b=xC3yDll+YqSGO804joKfbELSNaYALtCDZabNaoCZSB8jjxROvZjBI7jmuNApFldQ1Q oM2m+BVtz0nHcM1ETi8oG8IeDEN6HsMnmNhvUA3vOCVz7A/iYXJZJYlEf+yu0WUjXeWp rpIkj4JK1Mu1MST8QLMYgVaKXUZHX02Rb2Dg/qxivchSqVjCAQslbswNQXf4Zj9FHnBh nNNf5/mxWog/81OACqGvrzNc/tq80crAOrJQTSG/M3ZZ2fct+ZdtRpLP1vFLreSVhnQx blktEJThg66Be16q7Rd2YspugS6HOKYXwNZ9/a0oe4eOXGx34uyCIjAJLW8hRPAGT8jm 9p4w== X-Gm-Message-State: AOJu0YwjEtAskWE7TEue7+Sp2wYDUkgjpYDjplSw0D7kpCzTHOUVoKF0 2aDJbadGoOX75AxYLUeobgNNQXbmPSOlRvKXA8bWxAZB6TfrbOEwFTgWv6KfLzA= X-Google-Smtp-Source: AGHT+IH7aptmL+hAyUU+tYWarKvY+9M8pPlEn2+s7yno1xEevBphQAGRhy8UUiknVqGeUsA3SinrnQ== X-Received: by 2002:a05:6a20:c11a:b0:1b5:4c70:d688 with SMTP id adf61e73a8af0-1bcbb3dcb94mr4562958637.3.1718870743750; Thu, 20 Jun 2024 01:05:43 -0700 (PDT) Received: from lvzhaoxiong-KLVC-WXX9.huaqin.com ([116.66.212.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc96c8c5sm11805889b3a.58.2024.06.20.01.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:05:43 -0700 (PDT) From: Zhaoxiong Lv To: dmitry.torokhov@gmail.com, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jikos@kernel.org, benjamin.tissoires@redhat.co, dianders@google.com, hsinyi@google.com Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiong Lv Subject: [PATCH v4 3/4] drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel. Date: Thu, 20 Jun 2024 16:05:08 +0800 Message-Id: <20240620080509.18504-4-lvzhaoxiong@huaqin.corp-partner.google.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> References: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The K&d kd101ne3-40ti is a 10.1" WXGA TFT-LCD panel, use jd9365da controller,which fits in nicely with the existing panel-jadard-jd9365da-h3 driver.Hence,we add a new compatible with panel specific config. Although they have the same control IC, the two panels are different, and the timing will be slightly different, so we added some variables in struct jadard_panel_desc to control the timing Signed-off-by: Zhaoxiong Lv --- Changes between V4 and V3: - 1. Use mipi_dsi_msleep. - 2. Adjust the ".clock" assignment format. - 3. Adjust "compatible" positions to keep the list sorted. V3:https://lore.kernel.org/all/20240614145510.22965-4-lvzhaoxiong@huaqin.corp-partner.google.com/ Changes between V3 and V2: - 1. Give up creating a new driver and re-add K&d kd101ne3-40ti - configuration to the panel-jadard-jd9365da-h3.c driver. V2:https://lore.kernel.org/all/20240601084528.22502-3-lvzhaoxiong@huaqin.corp-partner.google.com/ Changes between V2 and V1: - 1. Use the new mipi_dsi_dcs_write_seq_multi() function. - 2. Modify Move mipi_dsi_dcs_set_display_off() and mipi_dsi_dcs_enter_sleep_mode() to disable(), - and drop kingdisplay_panel_enter_sleep_mode(). - 3. If prepare fails, disable GPIO before regulators. - 4. This function drm_connector_set_panel_orientation() is no longer used. Delete it. - 5. Drop ".shutdown = kingdisplay_panel_shutdown". --- .../gpu/drm/panel/panel-jadard-jd9365da-h3.c | 281 +++++++++++++++++- 1 file changed, 279 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c index a9c483a7b3fa..632bffa035ee 100644 --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c @@ -31,6 +31,15 @@ struct jadard_panel_desc { enum mipi_dsi_pixel_format format; const struct jadard_init_cmd *init_cmds; u32 num_init_cmds; + bool lp11_before_reset; + bool reset_before_power_off_vcioo; + unsigned int vcioo_to_lp11_delay; + unsigned int lp11_to_reset_delay; + unsigned int exit_sleep_to_display_on_delay; + unsigned int display_on_delay; + unsigned int backlight_off_to_display_off_delay; + unsigned int display_off_to_enter_sleep_delay; + unsigned int enter_sleep_to_reset_down_delay; }; struct jadard { @@ -53,6 +62,7 @@ static int jadard_enable(struct drm_panel *panel) struct device *dev = panel->dev; struct jadard *jadard = panel_to_jadard(panel); struct mipi_dsi_device *dsi = jadard->dsi; + struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi }; int err; msleep(120); @@ -61,10 +71,16 @@ static int jadard_enable(struct drm_panel *panel) if (err < 0) DRM_DEV_ERROR(dev, "failed to exit sleep mode ret = %d\n", err); + if (jadard->desc->exit_sleep_to_display_on_delay) + mipi_dsi_msleep(dsi_ctx, jadard->desc->exit_sleep_to_display_on_delay); + err = mipi_dsi_dcs_set_display_on(dsi); if (err < 0) DRM_DEV_ERROR(dev, "failed to set display on ret = %d\n", err); + if (jadard->desc->display_on_delay) + mipi_dsi_msleep(dsi_ctx, jadard->desc->display_on_delay); + return 0; } @@ -72,16 +88,26 @@ static int jadard_disable(struct drm_panel *panel) { struct device *dev = panel->dev; struct jadard *jadard = panel_to_jadard(panel); + struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi }; int ret; + if (jadard->desc->backlight_off_to_display_off_delay) + mipi_dsi_msleep(dsi_ctx, jadard->desc->backlight_off_to_display_off_delay); + ret = mipi_dsi_dcs_set_display_off(jadard->dsi); if (ret < 0) DRM_DEV_ERROR(dev, "failed to set display off: %d\n", ret); + if (jadard->desc->display_off_to_enter_sleep_delay) + mipi_dsi_msleep(dsi_ctx, jadard->desc->display_off_to_enter_sleep_delay); + ret = mipi_dsi_dcs_enter_sleep_mode(jadard->dsi); if (ret < 0) DRM_DEV_ERROR(dev, "failed to enter sleep mode: %d\n", ret); + if (jadard->desc->enter_sleep_to_reset_down_delay) + mipi_dsi_msleep(dsi_ctx, jadard->desc->enter_sleep_to_reset_down_delay); + return 0; } @@ -89,6 +115,7 @@ static int jadard_prepare(struct drm_panel *panel) { struct jadard *jadard = panel_to_jadard(panel); const struct jadard_panel_desc *desc = jadard->desc; + struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi }; unsigned int i; int ret; @@ -100,6 +127,20 @@ static int jadard_prepare(struct drm_panel *panel) if (ret) return ret; + if (jadard->desc->vcioo_to_lp11_delay) + mipi_dsi_msleep(dsi_ctx, jadard->desc->vcioo_to_lp11_delay); + + if (jadard->desc->lp11_before_reset) { + ret = mipi_dsi_dcs_nop(jadard->dsi); + if (ret) + return ret; + + usleep_range(1000, 2000); + } + + if (jadard->desc->lp11_to_reset_delay) + mipi_dsi_msleep(dsi_ctx, jadard->desc->lp11_to_reset_delay); + gpiod_set_value(jadard->reset, 1); msleep(5); @@ -111,8 +152,7 @@ static int jadard_prepare(struct drm_panel *panel) for (i = 0; i < desc->num_init_cmds; i++) { const struct jadard_init_cmd *cmd = &desc->init_cmds[i]; - - ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, JD9365DA_INIT_CMD_LEN); + ret = mipi_dsi_dcs_write_buffer(jadard->dsi, cmd->data, JD9365DA_INIT_CMD_LEN); if (ret < 0) return ret; } @@ -127,6 +167,12 @@ static int jadard_unprepare(struct drm_panel *panel) gpiod_set_value(jadard->reset, 1); msleep(120); + if (jadard->desc->reset_before_power_off_vcioo) { + gpiod_set_value(jadard->reset, 0); + + usleep_range(1000, 2000); + } + regulator_disable(jadard->vdd); regulator_disable(jadard->vccio); @@ -582,6 +628,233 @@ static const struct jadard_panel_desc cz101b4001_desc = { .num_init_cmds = ARRAY_SIZE(cz101b4001_init_cmds), }; +static const struct jadard_init_cmd kingdisplay_kd101ne3_init_cmds[] = { + { .data = { 0xe0, 0x00 } }, + { .data = { 0xe1, 0x93 } }, + { .data = { 0xe2, 0x65 } }, + { .data = { 0xe3, 0xf8 } }, + { .data = { 0x80, 0x03 } }, + { .data = { 0xe0, 0x01 } }, + { .data = { 0x0c, 0x74 } }, + { .data = { 0x17, 0x00 } }, + { .data = { 0x18, 0xc7 } }, + { .data = { 0x19, 0x01 } }, + { .data = { 0x1a, 0x00 } }, + { .data = { 0x1b, 0xc7 } }, + { .data = { 0x1c, 0x01 } }, + { .data = { 0x24, 0xfe } }, + { .data = { 0x37, 0x19 } }, + { .data = { 0x35, 0x28 } }, + { .data = { 0x38, 0x05 } }, + { .data = { 0x39, 0x08 } }, + { .data = { 0x3a, 0x12 } }, + { .data = { 0x3c, 0x7e } }, + { .data = { 0x3d, 0xff } }, + { .data = { 0x3e, 0xff } }, + { .data = { 0x3f, 0x7f } }, + { .data = { 0x40, 0x06 } }, + { .data = { 0x41, 0xa0 } }, + { .data = { 0x43, 0x1e } }, + { .data = { 0x44, 0x0b } }, + { .data = { 0x55, 0x02 } }, + { .data = { 0x57, 0x6a } }, + { .data = { 0x59, 0x0a } }, + { .data = { 0x5a, 0x2e } }, + { .data = { 0x5b, 0x1a } }, + { .data = { 0x5c, 0x15 } }, + { .data = { 0x5d, 0x7f } }, + { .data = { 0x5e, 0x61 } }, + { .data = { 0x5f, 0x50 } }, + { .data = { 0x60, 0x43 } }, + { .data = { 0x61, 0x3f } }, + { .data = { 0x62, 0x32 } }, + { .data = { 0x63, 0x35 } }, + { .data = { 0x64, 0x1f } }, + { .data = { 0x65, 0x38 } }, + { .data = { 0x66, 0x36 } }, + { .data = { 0x67, 0x36 } }, + { .data = { 0x68, 0x54 } }, + { .data = { 0x69, 0x42 } }, + { .data = { 0x6a, 0x48 } }, + { .data = { 0x6b, 0x39 } }, + { .data = { 0x6c, 0x34 } }, + { .data = { 0x6d, 0x26 } }, + { .data = { 0x6e, 0x14 } }, + { .data = { 0x6f, 0x02 } }, + { .data = { 0x70, 0x7f } }, + { .data = { 0x71, 0x61 } }, + { .data = { 0x72, 0x50 } }, + { .data = { 0x73, 0x43 } }, + { .data = { 0x74, 0x3f } }, + { .data = { 0x75, 0x32 } }, + { .data = { 0x76, 0x35 } }, + { .data = { 0x77, 0x1f } }, + { .data = { 0x78, 0x38 } }, + { .data = { 0x79, 0x36 } }, + { .data = { 0x7a, 0x36 } }, + { .data = { 0x7b, 0x54 } }, + { .data = { 0x7c, 0x42 } }, + { .data = { 0x7d, 0x48 } }, + { .data = { 0x7e, 0x39 } }, + { .data = { 0x7f, 0x34 } }, + { .data = { 0x80, 0x26 } }, + { .data = { 0x81, 0x14 } }, + { .data = { 0x82, 0x02 } }, + { .data = { 0xe0, 0x02 } }, + { .data = { 0x00, 0x52 } }, + { .data = { 0x01, 0x5f } }, + { .data = { 0x02, 0x5f } }, + { .data = { 0x03, 0x50 } }, + { .data = { 0x04, 0x77 } }, + { .data = { 0x05, 0x57 } }, + { .data = { 0x06, 0x5f } }, + { .data = { 0x07, 0x4e } }, + { .data = { 0x08, 0x4c } }, + { .data = { 0x09, 0x5f } }, + { .data = { 0x0a, 0x4a } }, + { .data = { 0x0b, 0x48 } }, + { .data = { 0x0c, 0x5f } }, + { .data = { 0x0d, 0x46 } }, + { .data = { 0x0e, 0x44 } }, + { .data = { 0x0f, 0x40 } }, + { .data = { 0x10, 0x5f } }, + { .data = { 0x11, 0x5f } }, + { .data = { 0x12, 0x5f } }, + { .data = { 0x13, 0x5f } }, + { .data = { 0x14, 0x5f } }, + { .data = { 0x15, 0x5f } }, + { .data = { 0x16, 0x53 } }, + { .data = { 0x17, 0x5f } }, + { .data = { 0x18, 0x5f } }, + { .data = { 0x19, 0x51 } }, + { .data = { 0x1a, 0x77 } }, + { .data = { 0x1b, 0x57 } }, + { .data = { 0x1c, 0x5f } }, + { .data = { 0x1d, 0x4f } }, + { .data = { 0x1e, 0x4d } }, + { .data = { 0x1f, 0x5f } }, + { .data = { 0x20, 0x4b } }, + { .data = { 0x21, 0x49 } }, + { .data = { 0x22, 0x5f } }, + { .data = { 0x23, 0x47 } }, + { .data = { 0x24, 0x45 } }, + { .data = { 0x25, 0x41 } }, + { .data = { 0x26, 0x5f } }, + { .data = { 0x27, 0x5f } }, + { .data = { 0x28, 0x5f } }, + { .data = { 0x29, 0x5f } }, + { .data = { 0x2a, 0x5f } }, + { .data = { 0x2b, 0x5f } }, + { .data = { 0x2c, 0x13 } }, + { .data = { 0x2d, 0x1f } }, + { .data = { 0x2e, 0x1f } }, + { .data = { 0x2f, 0x01 } }, + { .data = { 0x30, 0x17 } }, + { .data = { 0x31, 0x17 } }, + { .data = { 0x32, 0x1f } }, + { .data = { 0x33, 0x0d } }, + { .data = { 0x34, 0x0f } }, + { .data = { 0x35, 0x1f } }, + { .data = { 0x36, 0x05 } }, + { .data = { 0x37, 0x07 } }, + { .data = { 0x38, 0x1f } }, + { .data = { 0x39, 0x09 } }, + { .data = { 0x3a, 0x0b } }, + { .data = { 0x3b, 0x11 } }, + { .data = { 0x3c, 0x1f } }, + { .data = { 0x3d, 0x1f } }, + { .data = { 0x3e, 0x1f } }, + { .data = { 0x3f, 0x1f } }, + { .data = { 0x40, 0x1f } }, + { .data = { 0x41, 0x1f } }, + { .data = { 0x42, 0x12 } }, + { .data = { 0x43, 0x1f } }, + { .data = { 0x44, 0x1f } }, + { .data = { 0x45, 0x00 } }, + { .data = { 0x46, 0x17 } }, + { .data = { 0x47, 0x17 } }, + { .data = { 0x48, 0x1f } }, + { .data = { 0x49, 0x0c } }, + { .data = { 0x4a, 0x0e } }, + { .data = { 0x4b, 0x1f } }, + { .data = { 0x4c, 0x04 } }, + { .data = { 0x4d, 0x06 } }, + { .data = { 0x4e, 0x1f } }, + { .data = { 0x4f, 0x08 } }, + { .data = { 0x50, 0x0a } }, + { .data = { 0x51, 0x10 } }, + { .data = { 0x52, 0x1f } }, + { .data = { 0x53, 0x1f } }, + { .data = { 0x54, 0x1f } }, + { .data = { 0x55, 0x1f } }, + { .data = { 0x56, 0x1f } }, + { .data = { 0x57, 0x1f } }, + { .data = { 0x58, 0x40 } }, + { .data = { 0x5b, 0x10 } }, + { .data = { 0x5c, 0x06 } }, + { .data = { 0x5d, 0x40 } }, + { .data = { 0x5e, 0x00 } }, + { .data = { 0x5f, 0x00 } }, + { .data = { 0x60, 0x40 } }, + { .data = { 0x61, 0x03 } }, + { .data = { 0x62, 0x04 } }, + { .data = { 0x63, 0x6c } }, + { .data = { 0x64, 0x6c } }, + { .data = { 0x65, 0x75 } }, + { .data = { 0x66, 0x08 } }, + { .data = { 0x67, 0xb4 } }, + { .data = { 0x68, 0x08 } }, + { .data = { 0x69, 0x6c } }, + { .data = { 0x6a, 0x6c } }, + { .data = { 0x6b, 0x0c } }, + { .data = { 0x6d, 0x00 } }, + { .data = { 0x6e, 0x00 } }, + { .data = { 0x6f, 0x88 } }, + { .data = { 0x75, 0xbb } }, + { .data = { 0x76, 0x00 } }, + { .data = { 0x77, 0x05 } }, + { .data = { 0x78, 0x2a } }, + { .data = { 0xe0, 0x04 } }, + { .data = { 0x00, 0x0e } }, + { .data = { 0x02, 0xb3 } }, + { .data = { 0x09, 0x61 } }, + { .data = { 0x0e, 0x48 } }, + { .data = { 0xe0, 0x00 } }, +}; + +static const struct jadard_panel_desc kingdisplay_kd101ne3_40ti_desc = { + .mode = { + .clock = (800 + 24 + 24 + 24) * (1280 + 30 + 4 + 8) * 60 / 1000, + + .hdisplay = 800, + .hsync_start = 800 + 24, + .hsync_end = 800 + 24 + 24, + .htotal = 800 + 24 + 24 + 24, + + .vdisplay = 1280, + .vsync_start = 1280 + 30, + .vsync_end = 1280 + 30 + 4, + .vtotal = 1280 + 30 + 4 + 8, + + .width_mm = 135, + .height_mm = 216, + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, + }, + .lanes = 4, + .format = MIPI_DSI_FMT_RGB888, + .init_cmds = kingdisplay_kd101ne3_init_cmds, + .num_init_cmds = ARRAY_SIZE(kingdisplay_kd101ne3_init_cmds), + .lp11_before_reset = true, + .reset_before_power_off_vcioo = true, + .vcioo_to_lp11_delay = 5, + .lp11_to_reset_delay = 10, + .exit_sleep_to_display_on_delay = 120, + .display_on_delay = 20, + .backlight_off_to_display_off_delay = 100, + .display_off_to_enter_sleep_delay = 50, + .enter_sleep_to_reset_down_delay = 100, +}; + static int jadard_dsi_probe(struct mipi_dsi_device *dsi) { struct device *dev = &dsi->dev; @@ -650,6 +923,10 @@ static const struct of_device_id jadard_of_match[] = { .compatible = "chongzhou,cz101b4001", .data = &cz101b4001_desc }, + { + .compatible = "kingdisplay,kd101ne3-40ti", + .data = &kingdisplay_kd101ne3_40ti_desc + }, { .compatible = "radxa,display-10hd-ad001", .data = &cz101b4001_desc From patchwork Thu Jun 20 08:05:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhaoxiong Lv X-Patchwork-Id: 13704934 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 040D7C2BB85 for ; Thu, 20 Jun 2024 08:05:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EF4B10E856; Thu, 20 Jun 2024 08:05:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b="cnCtailE"; dkim-atps=neutral Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86FEC10E84B for ; Thu, 20 Jun 2024 08:05:50 +0000 (UTC) Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-25c4d8ae511so326681fac.2 for ; Thu, 20 Jun 2024 01:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=huaqin-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1718870749; x=1719475549; darn=lists.freedesktop.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=AMOoGP2LakwJmw2FH71ZMogJWrdUzY8/qHEtPyyBbV4=; b=cnCtailEqC7NN7Rj2Jc9ETu833R5cQY6n6SfYH/FBORXDhsjBmoXbMa9shKT8uZatg kz1rlGkEvJBLvV7E+TD+25x64lo7yZ0ozwQki3ufXbUc2/c/vQDZguMYZNmpjCDF5WVA cZts38Beatq022pQ56vBX6KPzf9EAitFVLqM2l0J9RqEf4RxlrDrn/S/jvw4wOAq9qxW +6kOcY5wT4p4/WodJBjTqHr/dk72eacsb/ET1sWnQUcRWOJhjBfrfeb0dvr6afa1NUUK yhKP9DKXUvGZoW7qmNaehgP37vkIE5H0s/608EjcpvhlUuF1XH9EkH/FvaX4PEKZ7REW GEwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718870749; x=1719475549; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AMOoGP2LakwJmw2FH71ZMogJWrdUzY8/qHEtPyyBbV4=; b=a3DY1OWiTW24/UAsW6NxhqKiYNuxnXzCWjPg/9zudV0PdT1IdzvqM0yqRYOxM0aGGd 7s1Vhw1/jQnYCH5+TuqPVBFv/KBNcVBeAQUmLbG3Gxqqiqm1mZAiE1tgAIxAkKUI2xio vpXwon7zAS8o0tAU6rrye5qZzWqpJV4sRLjOLivl93uaiS2VLSYd+cSEJqAsmagbTHET lgEa8hk/Qgq5AkVu/haYxAr011ZpO3jUHchMAsnEbXIUlbmrVRPQpzalGu5VCanurAx/ ZsLiy0Cl1RvHI6sCMx2jZuUKmfhcGsOV2jvQOjTeTJkJHfRo4YNNLhd6fdWivHiTwQ0m d/mA== X-Gm-Message-State: AOJu0YzbkZY+dqkBDzlgbCYLgCpzIvmNdhw77DpRQQrC8r85e+Z29K/O GhqCbOP5T24/VVQ/QtF+B7dNaYzQxuZowoQQkpbCQ0SdKc1jR4h3a9pr6pcwo6Y= X-Google-Smtp-Source: AGHT+IEbQAMEJgVsRzS0P1rsWA85d/j/lSoDKbJ+GhYfS/LOyoubfsealP8TGQ73YDuxPIYvuL2izg== X-Received: by 2002:a05:6870:b50f:b0:255:1819:b458 with SMTP id 586e51a60fabf-25c948f70cfmr4660143fac.8.1718870749476; Thu, 20 Jun 2024 01:05:49 -0700 (PDT) Received: from lvzhaoxiong-KLVC-WXX9.huaqin.com ([116.66.212.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc96c8c5sm11805889b3a.58.2024.06.20.01.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:05:49 -0700 (PDT) From: Zhaoxiong Lv To: dmitry.torokhov@gmail.com, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jikos@kernel.org, benjamin.tissoires@redhat.co, dianders@google.com, hsinyi@google.com Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiong Lv Subject: [PATCH v4 4/4] drm/panel: jd9365da: Add the function of adjusting orientation Date: Thu, 20 Jun 2024 16:05:09 +0800 Message-Id: <20240620080509.18504-5-lvzhaoxiong@huaqin.corp-partner.google.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> References: <20240620080509.18504-1-lvzhaoxiong@huaqin.corp-partner.google.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This driver does not have the function to adjust the orientation, so this function is added. Signed-off-by: Zhaoxiong Lv --- Changes between V4 and V3: - No changes. --- drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c index 632bffa035ee..2545e22a5c85 100644 --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c @@ -46,7 +46,7 @@ struct jadard { struct drm_panel panel; struct mipi_dsi_device *dsi; const struct jadard_panel_desc *desc; - + enum drm_panel_orientation orientation; struct regulator *vdd; struct regulator *vccio; struct gpio_desc *reset; @@ -203,12 +203,20 @@ static int jadard_get_modes(struct drm_panel *panel, return 1; } +static enum drm_panel_orientation jadard_panel_get_orientation(struct drm_panel *panel) +{ + struct jadard *jadard = panel_to_jadard(panel); + + return jadard->orientation; +} + static const struct drm_panel_funcs jadard_funcs = { .disable = jadard_disable, .unprepare = jadard_unprepare, .prepare = jadard_prepare, .enable = jadard_enable, .get_modes = jadard_get_modes, + .get_orientation = jadard_panel_get_orientation, }; static const struct jadard_init_cmd radxa_display_8hd_ad002_init_cmds[] = { @@ -893,6 +901,12 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi) drm_panel_init(&jadard->panel, dev, &jadard_funcs, DRM_MODE_CONNECTOR_DSI); + ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation); + if (ret < 0) { + dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, ret); + return ret; + } + ret = drm_panel_of_backlight(&jadard->panel); if (ret) return ret;