From patchwork Fri Jun 21 06:54:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13706922 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ADAFC27C4F for ; Fri, 21 Jun 2024 06:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=eTkDcANmcuZleL0PmBZXzJ8dQlOYVbwGmUQGEpaTcvk=; b=bdmcOCXlbfXZusWNsWMbC7XoAr MPGvLjSXYpUW74aDrK2SaL6QjzdwUEYtm+X/ax4IlblB53lbGe4ue2WbqqxwLfm2kitkHMPo+dcod +z/FgEBtP307OBtOQ2fOcBzEMer/qjPALKYvgSKawsf5KjDGdEmqKgg2ZTPP4iAkNfgvB6m2QjOjK GIFPWwY7LdsRPs6lS0UQey+6NCExG9WEhl3T0i9dmtx1BdrOVbpdEbxsZY1Bg5hHZxx8utX4klqGm 57nrD0OUevGtiToC4jVYJCwuTK1M+BUhTaNkLnSplcP+KRcSqBiEt+JiqSY2GWJkOICL8DajrX72P kQgQD4fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKYAb-000000083A6-1RVS; Fri, 21 Jun 2024 06:54:49 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKYAP-00000008395-2rQr for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 06:54:47 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-57d280e2d5dso1021939a12.1 for ; Thu, 20 Jun 2024 23:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1718952876; x=1719557676; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eTkDcANmcuZleL0PmBZXzJ8dQlOYVbwGmUQGEpaTcvk=; b=sH6j57PBaItGRumbHRozajkCVOoHnSQnU0WTVCahI23ZHTxPF/Y2ou9PQG/MrrLWhM cgPtUeXcBhmnHUH6V0f/0/hb2nszs0N2uhlLk/4YN83YnOZUCUxgcDfsnmklW7dmHNAw +p1TxD7zj8KgBese038fD1Q11C1UWfy74o2MPhoJTDrho3C5I0lpXvCEC+UG3fZXTlf6 E5zhH8wbpgXZg6s4JKPubn6bwI2ZMCXxhLo8mhTAekRUvxU9LKPvhoZ6jvobYXYYr1mM pY6lBwBXsxkQn3uJsQ0scavdN3mzJquDlbW6W0zrQugK5I+k0WaON44pzPFPLHC8MgUM XwTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718952876; x=1719557676; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eTkDcANmcuZleL0PmBZXzJ8dQlOYVbwGmUQGEpaTcvk=; b=UHAPBLk4+rfGC8mLhYBsKInVHcwTR3d6PXnd8vrvEh7YJDOmC07O6QUPILzbFu85qS 0SCOHYTpEgisH9nNd95eW6s9nda+yOyun7DxLnY/qFaQc3p8UlB7l3A5GqNcMYgcBTnc M03jKU6oy5X1P7craPidXngX9jZntkhNOKARqWKdf0TsJQ3p9JH2Vl3V5illkmlMV8ts PJkEyo6aQhOqL1fisfJdge6GdedV6HtXHes/nv5Xk/lc6G2335VsUPsO6vsFX2kh+qO0 B9OOO8XFFgeqUQkQQdZ8WSoHKfNHsHOiIvz5KCcxqWdxbJWrLvRHXtQMDfgCMMKTJa+0 aCJw== X-Forwarded-Encrypted: i=1; AJvYcCU7wWIFMtgvt2MUKOxXnfWPawbOqVjocl1n8BKG5mT+EHA6NSot438zH3iakNzMLkzD0O1mnDO1Ozky8Afa4vsqNWbcj+3k0faLTlegmNo75r+kJIQ= X-Gm-Message-State: AOJu0YzMKep1e1dXqy2YoXWF4r9dY4N0fLaOu+HfIcv2nOVKDH4fWBA6 3MDELbPX2RzcDH/4m7M8vZpOJXUTW62aMJAUHU2QSY6pa2oWZ/4hgVHVO8cSQro= X-Google-Smtp-Source: AGHT+IGLODE/V4p7R0sIIFSMmoxTGUJxgRGk7dfcAmBtIMl5OqgZ3hMha7NpDNa9+6zqYk6YZBDHJA== X-Received: by 2002:a50:9e67:0:b0:57d:57c:ce99 with SMTP id 4fb4d7f45d1cf-57d07e68e29mr3936219a12.2.1718952876161; Thu, 20 Jun 2024 23:54:36 -0700 (PDT) Received: from localhost (p509153eb.dip0.t-ipconnect.de. [80.145.83.235]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d305351dbsm505883a12.77.2024.06.20.23.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 23:54:35 -0700 (PDT) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue Cc: linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH] pwm: stm32: Fix error message to not describe the previous error path Date: Fri, 21 Jun 2024 08:54:17 +0200 Message-ID: <20240621065418.2760898-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1500; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=MXCWIEHjZagT0uCOJ+g+R76lwVk/kK6hKx6erlJbECU=; b=owGbwMvMwMXY3/A7olbonx/jabUkhrRS5VkZv/vvcYVeZVioJNofXpqyzyvx0aLf/HEbjYSFk 4oFcyd1MhqzMDByMciKKbLYN67JtKqSi+xc++8yzCBWJpApDFycAjCRwmvsf8U/hJ0+0+pcp5Uy JyauT9m0xWb3D1+LVr7k3g3df/OzTvMZ3u70vb05oqni++uKclH3Ni32GrEdT2M1lJ5cfHCoQ+H SCu9LcZlNR+XmN9x2PL55l6rP+u+61hcexK9L0vSVmbDl97Pf8xY09b42nX58aqobY6qX0EXWnx uqarZsmLfBqrZP9vhmGcGTj9W2vchstLyy7uFPv+3sncVuCwT73gdPKW7hzzRi+y6769j/qXyWm iz9fzX75vX0zjyl+14+v+PpneVLOvY0vLvLyvYwrUfPQLxwlxKf7wFpjgnuLQ5R2y6n3uAM5ba3 ldQt54lO6V/XmyDQ5bOu8lDxg90sX59O2pl+I8jfeEEiAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_235437_969564_152516A8 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "Failed to lock the clock" is an appropriate error message for clk_rate_exclusive_get() failing, but not for the clock running too fast for the driver's calculations. Adapt the error message accordingly. Fixes: d44d635635a7 ("pwm: stm32: Fix for settings using period > UINT32_MAX") Signed-off-by: Uwe Kleine-König --- Hello, I just found this issue while preparing a PR including the two pwm-stm32 fixes available at https://lore.kernel.org/all/cover.1718788826.git.u.kleine-koenig@baylibre.com/ . This patch being trivial and useful I'll send it along with the other two. So when you notice this patch it's probably already to late to send a review :-) d44d635635a7 was only included in v6.10-rc1, so no stable tag necessary. Best regards Uwe drivers/pwm/pwm-stm32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index a2f231d13a9f..cd7245183360 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -673,7 +673,8 @@ static int stm32_pwm_probe(struct platform_device *pdev) * .apply() won't overflow. */ if (clk_get_rate(priv->clk) > 1000000000) - return dev_err_probe(dev, -EINVAL, "Failed to lock clock\n"); + return dev_err_probe(dev, -EINVAL, "Clock freq too high (%lu)\n", + clk_get_rate(priv->clk)); chip->ops = &stm32pwm_ops;