From patchwork Fri Jun 21 16:50:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707853 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2047.outbound.protection.outlook.com [40.107.93.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4B57167DB5; Fri, 21 Jun 2024 16:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988688; cv=fail; b=CvW7UomLBVHVnRbLc/lUGyLtnS8jZfC3FDt61b7ujnXHEbYB8aopfZ9o+F6K901ZyUlwKrzZH1ZLEa7llj9oPcl3QU38l7GnMADMimiw62A+P9NBDSJbe0SoIJOxlPt1WmaTVvNCqoffVhKnuzW6/tKZAHn29ACL5v2fnzLYx/g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988688; c=relaxed/simple; bh=PkYLlZjxfECQNAtTpwSLNaDDoS6fj9PfSinZeOrh2Ng=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CrHlThOXt2ou6QjlrG02l7xcDGZiMdUif/j1myiYCwT60DS3bOhrA9tBMfnpVYhq5Hor+1K+E+0m732jMbAMGzoUeCmUdgocPvLlxpKUNCGZvic3TP2kJjlW2HWA+w9hmCcM2SyvtzYbEUPlhiiX2tXzovEyfkKUlH+dZqJBu+A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=3h34POZr; arc=fail smtp.client-ip=40.107.93.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="3h34POZr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KgtQ8A4M69UnBa8s4G6jy9iOHPSz3fp9MmFE/S+z1ljwFXALDxKmNvinnV90EbSFW892Mj04CQQ+ljgRTfPbk8qpmVtSJna4AzFhBuk3sszjrFHKX1smAJehCcDOtaElU3P5Oa4ct9QitCRzjsp5wNPIGLOyrKGLofcLz7GlfTDq/ATZ0kNTZgDE9ZH6F7jgn07jHZIYnVWBmkC8rGM+oo0pifKTvSeH61OxthZqEUwD9Q1wUkLgULQUpLuuatCfSdFLj74s+MgkWQAGRZu1DSOUZp0WjDpP/zXSYa/q8PQKd+pKktmJv64OWRULaL16gty+/LmuzY2q8jqMN8Pv0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RQRULbL83Wq7yBUahvTIeQJ17zPzxLeAflkvrXSzwkM=; b=fWFU3nHCoCFj04jYzNzU0wPJI9GCA2EuEQICcdryqxcoEWIkLH4u9l9Rfl4zVxg3+sryJ0DnklvU9T9en9S2xrIfiOGs3MWc/Pmo/oYTxC1AlQnnihFNURlmhpFpuidl0w6xlcwax7cVxrq0jjkVUTpodU4+smMBr7Rti1SaqmYVWOi5tl7uMymLRBsg1a4PcSvwR6DSLx/s64bOsJjE48jIzbK/9Xj+LXChw8rYBHRcFVU2c8hxqvv1RFiwECQmnLJhMTQ7Gp0fg3bIf9PTQ2XjM0Vm6/8Jz5yUMll6Ls+JHuyZrRElCesfRPEX4yirZK4w8ChnyECKNUh71MCQyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQRULbL83Wq7yBUahvTIeQJ17zPzxLeAflkvrXSzwkM=; b=3h34POZrUKY9UhJJqsPITxbTnkcaxI5PmpuE1P5G04CFIkH1FM7OscZ5HaIZcBYq2VjvxHc6awscqCzSGPFMEZ5NggZHihoLc8+pMMQUy6jzrd3sc8fk1XpbR7UMWyl13lACxUBlXvmYXWUaO8KIdoIcV45Dn5FUJppXYMmfjhI= Received: from SJ0PR03CA0270.namprd03.prod.outlook.com (2603:10b6:a03:3a0::35) by SJ0PR12MB6734.namprd12.prod.outlook.com (2603:10b6:a03:478::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Fri, 21 Jun 2024 16:51:23 +0000 Received: from SJ5PEPF000001F6.namprd05.prod.outlook.com (2603:10b6:a03:3a0:cafe::8) by SJ0PR03CA0270.outlook.office365.com (2603:10b6:a03:3a0::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.37 via Frontend Transport; Fri, 21 Jun 2024 16:51:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F6.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:23 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:19 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 1/9] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Date: Sat, 22 Jun 2024 00:50:56 +0800 Message-ID: <78b6c75e6cffddce3e950dd543af6ae9f8eeccc3.1718988436.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F6:EE_|SJ0PR12MB6734:EE_ X-MS-Office365-Filtering-Correlation-Id: 05dacc13-d042-46c5-dc1e-08dc9212627d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|82310400023|1800799021|36860700010|376011; X-Microsoft-Antispam-Message-Info: h8qU1EcbQFqnBOh1v67ts0P1LerlWFvQHkIR0V3u5i2jUp+q/L5UU0wvqwp4DL7MVoZ1G6ZmX9ZXSHfmWwiVMIu8ClJ9SzGG5w6OA5JJMkDpbq9PVnovCiGXaVK3c5n1IrnVa8ygQ74xvaDWPOFhCCivgr/YcJbuG2VPJ35pZWrFKHxvmfU0vaA32HeKCRRaFP/F0ykIeektngRCnOpcQP5KbrfQq5aRZTJjtsPjQAvM2aYx1IMmMH6dJBEw9lE6tnbe/raMBOL+az0AMc6JUi6PRYhp67OKv9VyKnMErcEAxSNe9eMqbXxcHeMj12tHaoFhOL1yp0o/7f9tdcA/eOR/gOKICy03WI2EmbVSvX08NbNykezaOpOYp7boCr5Ia5xsikj3ampSuPDhqQrNHnGGG+XOZszFVQWs7daXVHe5R/HGzGBuKHpLbD3IoZNb7V+VPtQwbmc3rgCQwrU9nIhhG1N8k24Ld0I2XsnVei4ETROVdoZdYv82LCBQj2BypypMXANVoddIy5FRnffRLp+1NDRHhyU9kB3WXZBvLjmikEVe6LezfCmI9EXgjhpP/SlvK/eoDrkV2iqX1fqoDoPyE8kq7mHqqpRiTVD8NlAX7GSKLUiyOPeyDWUv4oW7UlEU7nBfflLnMZmD/44tR+gVI2yJZUmE1fKIx8qIZtkLxbgTmQpsVCamH5awJp0OwCm+IPYhu/vKzIzWv8cR5+55PV+6LX3hqRBP+DOLaC1jlh4jjW5m+8v6Xw63SyZgX3ruQZu1zpFlzjX7x3fmQHu0v/XqimC0So/8wihmvSkoytGWMLyLnFanRv09oKIUdh98gEMHhPDQltInjltmUl+juNSyPaz+zoLSYzbx2ygItzz8K+RA8XtFv7kMPybZEbzMjJcinNRjKd9jcDYzFUX9I9+v30dp3+dlIVjYTbYeLS/HuM7iNOgXmE04xRLyByvDz9Dm5ZF++zxsoqzrQBs9MRb/96WcPZMkRIwdE4RDqgLLlPZpKsH036C5s7Y5dGxlcREf4cPYKyvkm91oAdjliJ+xO1iRf/PUwrO6gOm3Sv9uJHURH0Rfkl8gaQhJ9sKIO7W7wkK+fbUcA8tNT2Xdk+v5KfmBCP3UzBzMgmNrTllXoCCbEvXQhywxi2KxK44UL865xfdUr1sIbDVxMzPVlcUpPpuEkTa9NHu9m1KWOf4II37ZTTM9YHz9f87sDvBZa+zQSM8rvvmEh1LAlsVLYWLBlMtVGi+H/SP0lcQXdkEYCWRGcYkswqQK05VSDYB+jOZ3IZwyMr9xbIRnuaa67J4rtv+3neIa70yDDeU9CmlARy/lLjLfUMdpw9kB3Hml66M0OxGH94qyuxsq1FCrDnhFdR/8u1ZG59tNUSxbP42FTuR5f8TMXYxGmqe6pMSWIdF7fgBxbq/J1qJuHg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(82310400023)(1800799021)(36860700010)(376011);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:23.7843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05dacc13-d042-46c5-dc1e-08dc9212627d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6734 There are some other drivers also need to use the MSR_K7_HWCR_CPB_DIS_BIT for CPB control bit, so it makes sense to move the definition to a common header file to allow other driver to use it. No intentional functional impact. Suggested-by: Gautham Ranjal Shenoy Signed-off-by: Perry Yuan Acked-by: Rafael J. Wysocki Acked-by: Huang Rui --- arch/x86/include/asm/msr-index.h | 2 ++ drivers/cpufreq/acpi-cpufreq.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index e022e6eb766c..384739d592af 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -781,6 +781,8 @@ #define MSR_K7_HWCR_IRPERF_EN BIT_ULL(MSR_K7_HWCR_IRPERF_EN_BIT) #define MSR_K7_FID_VID_CTL 0xc0010041 #define MSR_K7_FID_VID_STATUS 0xc0010042 +#define MSR_K7_HWCR_CPB_DIS_BIT 25 +#define MSR_K7_HWCR_CPB_DIS BIT_ULL(MSR_K7_HWCR_CPB_DIS_BIT) /* K6 MSRs */ #define MSR_K6_WHCR 0xc0000082 diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index 37f1cdf46d29..2fc82831bddd 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -50,8 +50,6 @@ enum { #define AMD_MSR_RANGE (0x7) #define HYGON_MSR_RANGE (0x7) -#define MSR_K7_HWCR_CPB_DIS (1ULL << 25) - struct acpi_cpufreq_data { unsigned int resume; unsigned int cpu_feature; From patchwork Fri Jun 21 16:50:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707855 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2083.outbound.protection.outlook.com [40.107.92.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 867F71684A6; Fri, 21 Jun 2024 16:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988691; cv=fail; b=YMtSF7nMV0/0vDzb+taVPG887tQcPRpyRKhxCqhLxwnGi9bgUepAYKvVY1CJEYw+boUYtNzYI8Hny4FZsrjfm6n/M+WP80fNSVXFJ+wTpTmY99rEZpmOTq/snxbM6N5+SeuquRzL6jtlV81AIM9crHWtg5tORhEGu6z5XB+82zc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988691; c=relaxed/simple; bh=392AWBzKdKzSSrwj0pG0J1sJJzAKNXFtDdvuZBD4r48=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N5lrpMAwC+ICvGdFIesre2aCp0P1EgMLQcsckJUd+Sys9ACsxfsR3JIEzvNusIvMeHKHCulVa5jHkcaOV/ixB6PZQzIq65uEbv2D4D1havPsORpcwkqt82H665tSMSt/ZbHX3QqFx9jC7BepvIlUMNG3P/NbtcyHEvsK5fqFNRg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ydiBHtpK; arc=fail smtp.client-ip=40.107.92.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ydiBHtpK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n3b8xwookryXfdrkJOOGQS1YXXgYhpDg08J/3kuo45WW5yASeGqbFzHDpmxYDUt19K9ePMCoUuLaU/I4E6R6uxZtkipf9tUg7HCv29Y9sFRwWIm0hCVGsDb3xbNgUX0Jb2eRrD9DEDfT4AETh9rXw+ZqdYwwpyKvWUfz9oKhlM6qwG0x/qeC2maprL0GOfVdtQdNUiB8bgMn8IhFXsgKiWPButazSx03ZE+8N1jOSH/X/+upVnt18Zxp0KsuUFTscT3YMKwXLf88OUOSoT71kLOosGsmF7Uc1Pmp4bLOKTK44u8/27se3V/wOJ9UNOfcJvmS1Vo2LUK976ciaMLdKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=roSRh6JqXml/3zhWAIUWh9W5ezQqGUp+mvuN7ooDMtU=; b=j93pKqcHptSAIJKCcsy1ztKWwm2NTZBvTu79U8IEVuRjFbnHya+3RHIj43f6igxF6OHZ0pg88eRABc5HBl9Xhi5j5sl2MukrgJXv+1hUaHTGkNx93qkmOclv4wgrzu+W1M+qEPAG+2JNcyuGUsbZXvVgVmFYeHISKYCTBjk1GC7PfTCrPqrGFLG7sTmQ/FfBxE6Mz2VLdDIU5NXzhz0rmc1PBw7eXd+kZo1AdEWNwfktjLOV6vHQZZagyUdcLRxlMX4gPpKMQmQy9BY4o+zfyAsUqdHwZKsvRfnWqQ5Zq52Km/miB5d2RoT/BbolwvdJ/vtgnKwN+aHMj0eMUy6agQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=roSRh6JqXml/3zhWAIUWh9W5ezQqGUp+mvuN7ooDMtU=; b=ydiBHtpK0AvRDb7dAHR/xdR5ZGWDM6GCHbl68nq/8mHQCto1h24At/tEH7synd9GfGvtQfboGT2NWWcYydejmQ5M9fN3n4Np9tqQpz084MWFBtkDh0XoZ5OVp9jS6V/niSGm+nmIgpq+dySAcS8uiNMADKkjJ3PwsHzdaVy5tZQ= Received: from SJ0PR13CA0120.namprd13.prod.outlook.com (2603:10b6:a03:2c5::35) by SJ2PR12MB8883.namprd12.prod.outlook.com (2603:10b6:a03:538::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Fri, 21 Jun 2024 16:51:26 +0000 Received: from SJ5PEPF000001F1.namprd05.prod.outlook.com (2603:10b6:a03:2c5:cafe::f6) by SJ0PR13CA0120.outlook.office365.com (2603:10b6:a03:2c5::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.33 via Frontend Transport; Fri, 21 Jun 2024 16:51:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F1.mail.protection.outlook.com (10.167.242.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:25 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:21 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 2/9] cpufreq: simplify boolean parsing with kstrtobool in store function Date: Sat, 22 Jun 2024 00:50:57 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F1:EE_|SJ2PR12MB8883:EE_ X-MS-Office365-Filtering-Correlation-Id: f8b8d5ca-2623-4a3b-d7b6-08dc921263c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|36860700010|376011|82310400023|1800799021; X-Microsoft-Antispam-Message-Info: 5m/KGho38JbHUAVD+x2lKl3n6XNpm71qXnSGRewBWFXyzqvqZQ2BD1Utb7mBYbWkKYSQyuRVo3jutVy6WQG2pmL2tld8PE/iSywA/XMvnQon4Iuw0wL/mqEJQvoFNXB2H2uJCSc2ZiRhzBXWdNuFP9leeCwrWNAEPyaB5+9UbpwtAjicatXawvFm5blk6niSAQArsEOiQBCD9WYo01FzWpy47Qrbjhedpjz7mDTKa3O66/mwBqOeWkruRXEbUOEozw1CfSUBww0SZckM+Y8IdCbR9Aj/uqpRJUayaqW3ObMisHTefi+HMOkN8JcHVWjRRdapENRI8y8vkLoB9CoSfr/bhzvJ2Tfnyca4sBgMYOqt9J4PLqZBlyw0ZNSQRdChvKkmaM/xLbJv526En8FXkxVfqdgZcpuwkhaZk6qRMfeCTi3a5WcLfCKALlKLiaCAajthaaMufYxtZVvBTfl/kjnaz2RcSB6uuJ32vju18+Znla2fLsXUOSEann2WCrgD4gvfXRJh3SvLcLyruE3TDHe+ojWum3nzggXhf1a8jdNub+0BZfnxd/A0eVzMTwOzGPXKZhZoQMkH/nUUBR+1geN8pnTjBhNDFn91+N2B4VzeoDn+NBsxsuT9WqKXaqZf2ukcFnnK5t7az7swiuNTtvccNVgGxjcycBRN7+jvIb28UyX6yCPdc/exUPTpcyWj2AjVdzQBpKAX1dyYceRtLLHVNM2U/NvhpwSBdLfeBW2p2PdLr3Kz9hzoEV6Ou9ksyAUNGbJgf5ieEr4i3onlzbZK6k2utmiJFNOBKTlVt8plWN252fqkuh6hxAoA9p5RsUhgvoIdbWVpTNxIG37Z+nK+JnEcPhcSzhwoeXEK0VH0acuxmQZ+7yjb+Oc52DC1061ypHbJCoxa1p/lq+n7DEwl0jVQd9ztHPguYgJGm38P4rF9VNEPj72Av4r7ihuT+lNrqCq/Y7tBoWqKHQaDzCuhz6WSXGuW+EsOhBb2kQp3K380sfl0GfjB+ULSNs+7jzsPXXEmokXPUHuTYUJkqUDD5MEslyl7W5FfoVFqV4JQf5qH3v1jW2bdAcuZvA/rQyD8RFW2I0OtDEm2oW3GdVLPjkwuv8iAOm73l7BMC2C5JAk2oiNLJLjH/JuISE9gYTlfTrTK/W/YAjD7NJzAdbens5T0NUOouo4KLRVQMHRQwtgtnsz4wuCfA3Jkk8A7AB+7mvSOIzuCTQin5ufdMmvdRwmUeRF7PBRS/5xiDPAJvFnBRZ18xgujeHXgMm5yvF2J0RJBzUcWE4/zdJmvnNv+9MX2PrpmltU1WmqOaRaBFlzYLri0YWUX9Wb/mx7NxbVVSpeMlNC9BONS2zUQc97NBPPBbFa3u8eiqJJCzu608S/al+r9Slhk2dl3kwIqwD2X3VJ9hUwR6UhVRCk6Gg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(36860700010)(376011)(82310400023)(1800799021);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:25.9207 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8b8d5ca-2623-4a3b-d7b6-08dc921263c3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8883 Update the cpufreq store function to use kstrtobool for parsing boolean values. This simplifies the code and improves readability by using a standard kernel function for boolean string conversion. Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/cpufreq.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index a45aac17c20f..1fdabb660231 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -614,10 +614,9 @@ static ssize_t show_boost(struct kobject *kobj, static ssize_t store_boost(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { - int ret, enable; + bool enable; - ret = sscanf(buf, "%d", &enable); - if (ret != 1 || enable < 0 || enable > 1) + if (kstrtobool(buf, &enable)) return -EINVAL; if (cpufreq_boost_trigger_state(enable)) { @@ -641,10 +640,10 @@ static ssize_t show_local_boost(struct cpufreq_policy *policy, char *buf) static ssize_t store_local_boost(struct cpufreq_policy *policy, const char *buf, size_t count) { - int ret, enable; + int ret; + bool enable; - ret = kstrtoint(buf, 10, &enable); - if (ret || enable < 0 || enable > 1) + if (kstrtobool(buf, &enable)) return -EINVAL; if (!cpufreq_driver->boost_enabled) From patchwork Fri Jun 21 16:50:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707856 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D27316ABF3; Fri, 21 Jun 2024 16:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988693; cv=fail; b=Jso9792aDKtiXIdgOCzmUNhGPFdQ89gwVuousjSHEsgzyRZzPtrHwKvSoz9JzG1Uta/hUjDcm4Ify8n4WrGJtR3AY2yhRkafCF09aePOzjS3rfUiXzbV2CQ5VLNnN2Y6Q/Q/yNTFbmJPHoHaWr/z8z/eq91BJQR7OxSIgYvIIZE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988693; c=relaxed/simple; bh=VPnkaK6QQZKyd0qyGfloYPwag1g/W8qHeGJbJPcnjN4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mDWziIdRISbY2uplpPdrIORFMgdSlNVY4wCa0UYeDbjsiLehxgVsLOEKvYtJipTNd6YmFhrZ20G62NVV9OtDImN48ne9VanKcp3Tcq5ArWzOGfitFBgBSsmUfX0vN2Y8gTmv6XUDwzN8bfWssgmroBVr93M73jk90JN+ODMoCoY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=oPGrUMVa; arc=fail smtp.client-ip=40.107.244.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="oPGrUMVa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bcGCZ/7FTSHsnCapcKnPN7N28FZjPTKsTlO/W4zc6sCPhVfNEWIMCrDYJYXeJzKwgqOM112WGznhM6pj0yf92KTx9PBKEgUmZW5chgVs9AMBpUrzU+b+tqRvrPMLpciBYlLgyxZALD/gpB23AiiHdwew8mvcERBGlbko852oKoKlngh9rMcpu7RkpIc556ksexCQ6ZCZyfvnNYkotUcFkS/tuVaBq8THLRtU85eFV3HUbZ2Vtpt0qNBO4P/gruW2nxt9Dy7IYF6jUWtPwQG/Gf1tdMZBP3OpV24cjKdeRfteA8+92jtGBxUTZNvn5CTeQyRKH0mA2k34h4+vG0qf8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UkBgW1FoEz+y4K0wWUhOkxzqKaui0JxO5sx0rMNUGyg=; b=LLH3RoGlDT9yOwzhskE4w+7Z3RRh2/Kss9bmRSO3tArYBwlSkeXoDKYqJxcPKfgNXW0cFTHSuGrsLaJVjmD49P7WRgN6udzE9ESRyWg9VAwbQfFnxr2xx4ydYNWemZBIlYRiNL15ySL2bsjWhCJ+7aKnB/rk4mCi+ikuOyuorgQcg4GArb1aLoq53yYpB6o+QoKpo7rmTlfTMKQnaRuME930vdTgp6TAEWPaAy/cHpq2RCJ94bW4qf0YDjIo7NqjxE3no5wf1TWF9xeqQhrZkXBvPRuF1dRs3xzASGThoi4HhzrwjFjhtJ1W6gG9XHy15ZX4oWIrp1bhXig1KjwDAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UkBgW1FoEz+y4K0wWUhOkxzqKaui0JxO5sx0rMNUGyg=; b=oPGrUMVaOzbPDiWZqkKBFApLkl+jLnd7Dm+Z5A/Bjqh4hIe5YtnRF39Ig6Fl/FtfAPekIBni/TJL4fbxlyfGM47cRPFxs+m30gYbDb0TFZvsTT9taR+IqEiH8wz0x/b8aokqHtINJbPYFCtYZ8UTHHe+B37xVsTSrVtj5l98pvk= Received: from SJ0PR05CA0191.namprd05.prod.outlook.com (2603:10b6:a03:330::16) by CY5PR12MB6647.namprd12.prod.outlook.com (2603:10b6:930:40::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.21; Fri, 21 Jun 2024 16:51:28 +0000 Received: from SJ5PEPF000001F0.namprd05.prod.outlook.com (2603:10b6:a03:330:cafe::37) by SJ0PR05CA0191.outlook.office365.com (2603:10b6:a03:330::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.32 via Frontend Transport; Fri, 21 Jun 2024 16:51:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F0.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:28 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:24 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 3/9] cpufreq: introduce init_boost callback to initialize boost state for pstate drivers Date: Sat, 22 Jun 2024 00:50:58 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F0:EE_|CY5PR12MB6647:EE_ X-MS-Office365-Filtering-Correlation-Id: 01172b1b-ef7e-42aa-97cf-08dc9212652f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|36860700010|1800799021|376011|82310400023; X-Microsoft-Antispam-Message-Info: Ysg90GrcWHcvU4nzuULA+osMXUyXhDo07bJ/Y5YmFfD0OXH7z8eIRAfLYisEBAMHkV0We/4QO/n81WY6L7kHkRI2bvUQ+/JCvQUdkL1WVS5QonlwqEvqBupGbRj44VPCVAnEyAAz5Hdx7C5LB0g1Ry4kN1+YnuWxY068aJEQTkm0yaZmGpcGVQo75awWcc0ndnwloDbwiV5DMzOYoci7ok64gh7KsC6QexXLRSnwNfjcTdECkpFGG4HgDN8xjr+xL2iAyT17WuBBByi8Aluvdm/icxklRqdZKOYOUYnFQdClfPyh3i8K4JDHeZw4AWoVoajAKbyNC/2c1cgjhjS6J0n/pq4oD3vaEa1PsAAqpv2lNRBH9pBlhbXeewcs6AwSqhoDLFLGJxlANoAgHFO4P19xqWuLdGueHpbNbLu7OkCfMEpFnwTE0gRQTwb+Yw7AeaQ+ai3mxM77vpmlnRXlyAcdr1eUt2teF4JftWeVrE5RrRjuikZjeNfc1EgUWZQXDszneHR1zmWdXQK/WmBO5QWtrb+WBdsVMRkjNYE6aEWC9lt6Y4bl3ZkqgijLey07+bQ36wCyeziuk2zVGZ94O5iM+80G0FzVK9saKujsqOlE/IIniDOsRbqVeXMamb3sSAdDszAWXCUWxfQtYUUtjkSvd8TKets9XbvnN8NUju9t3pmmD+ckkUCWRVNSRFI7Lr8QkXTbzo9E2Buvagko0haEernNQiy8VTK4D9K81W8c1wmp0LIL4rduX8o1t9khn/+Lbo6EhUZsQNmPeYMSlufX/IkMBxAUwKh+onNKSAfNeU0WYCqzaaGHeeRRuGJQCUWfUyH1vuyBCj6G82KsOJjSzx8NlOTD7ixwDu+CXMBsw4YS6Iehm+mzIXYgM/3f9+gcLPi7xDYAgzCkCEWZxFfSSS7SQgpj8TshCZRldRoFjphstiHor5+wTgSbcjlDOCAhru/4JSpXfmSu71KzErz1qRqXLDfCFuer2SR11+u9/okK8SJi1nXf2tIC1tSS+I5aQ756w1fVUnjiCpxOYOjyp1xNrWBbXsUktoS6NWTQEZfi1tKIdLFLv4dKSCOft3V7apCE/CEiv+Tqb/HBn55olJGh8Ez5ilwQNovc4zXFCPvqItp+0WFEAf462Rs2USnepnR6FWrq5tL5nIlqID42IzZQ79uMMsN+YCZ9WsLM5OPsCQpDVS+y7VhjX76FhcvIwwGr/T4QGfegbgsk4JLyGz0rs2UZLYaZ8tsswgylasGIx6flL2ygpeVqXtDo/LjNCTfX/gxAPxKkEWjeUFqZmuZvOt8BVNVxrThY+GDM3shaDRAU2O7C27YZY9P+QJ8gWZ/Le2X9tP/vWEBEExTkR3sVIBbCsNki6nH7jasr5rhg/qMdg+MCm/JKFkkXXzjUjlZIF1UhFpaLlPxbUw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(36860700010)(1800799021)(376011)(82310400023);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:28.3046 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01172b1b-ef7e-42aa-97cf-08dc9212652f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6647 Introduce a new init_boost callback in cpufreq to initialize the boost state for specific pstate drivers. This initialization is required before calling the set_boost interface for each CPU. The init_boost callback will set up and synchronize each CPU's current boost state before invoking the set_boost function. Without this step, the boost state may be inconsistent across CPUs. Signed-off-by: Perry Yuan --- drivers/cpufreq/cpufreq.c | 14 ++++++++++++-- include/linux/cpufreq.h | 2 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 1fdabb660231..0c99d2dfdb53 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1429,8 +1429,18 @@ static int cpufreq_online(unsigned int cpu) goto out_free_policy; } - /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */ - policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy); + /* init boost state to prepare set_boost callback for each CPU */ + if (cpufreq_driver->init_boost) { + ret = cpufreq_driver->init_boost(policy); + if (ret) { + pr_debug("%s: %d: boost initialization failed\n", __func__, + __LINE__); + goto out_offline_policy; + } + } else { + /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */ + policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy); + } /* * The initialization has succeeded and the policy is online. diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 20f7e98ee8af..0698c0292d8f 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -409,6 +409,8 @@ struct cpufreq_driver { bool boost_enabled; int (*set_boost)(struct cpufreq_policy *policy, int state); + /* initialize boost state to be consistent before calling set_boost */ + int (*init_boost)(struct cpufreq_policy *policy); /* * Set by drivers that want to register with the energy model after the * policy is properly initialized, but before the governor is started. From patchwork Fri Jun 21 16:50:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707857 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2064.outbound.protection.outlook.com [40.107.92.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C10D16DEA2; Fri, 21 Jun 2024 16:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988696; cv=fail; b=JEmW8GbmSFMORU+lUNdXU6t9XZHWdJe1c8FZkH7eMONTKgGvLbYLE8jjBx+OT1EO3lUJH4J94zB2kaPav6UWYzVwup5pVA8fvdP2GmAa5Nl54V8NwATP/w7icYFludDF5IvOBEJl7h76d3DTSGAws0rZqeE18aLDCz1YJnhmcIQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988696; c=relaxed/simple; bh=NzCglbdGTbU7ySY804JLTHjW4bW7tLKrFy8ccfZ1ND4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qQMErzfIVrWrdcWE6aBHu+3jgjoOHvnP197T0rf5nIa1uNUHWhcvoYPH4uyPrLKji8HtHIpXRmNqr4SdQiDoEGNsmnKUbYGnUtwXETQS9glI6uvM/JtNcbu/gFmrtAkBbT4cRUJibC0FP+UL5JX6J29qj0Wd0HAAuASzQ2SJvrs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=B5O3zLdk; arc=fail smtp.client-ip=40.107.92.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="B5O3zLdk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DnY6mCwTw3CetsNciICwLdoGjFmLcB+VKonXjbguqttCqk68maqPfzQBzlRUXjRS3ooedn/cZehymookxDbdiq3s/lf4mfY5FsI/gmQ2hP4oBYrR4TKVwnTIvLLbmqnuMTq9BCX39wZ/ktewFN2KYvR8ycg34KeNWMiF3XPr7sN0sRlsijqRXJXEJyWTRGcXsHBratKi0rpy25C9OZEiEzYL9xkE4w7hh3BdNXl6clUI1xzOm63H2lrrpzAtbaWQacXc0OxeYeTX7w86ulsDK9ifUeaHoodt9sU5rVF1RZcGjsZbPFE2MDUnh9Pdw/tQuEu/wPEjphQbozgiH9A+vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Te7udhJfKaN+1a2lI9KhZnB53WgS0CXp1xN1/UDB3ys=; b=Dr2ZuZH5fy9UTWpBl0EdH49+9tvmxyEUoAI4qjI6HFnALVWaeBdPMWgaII9b/WUqoCf9SrZhpD3fMJI/iqSS3o2qof6vEbhQtdk/OqP63AmvO3M+jbpmQp+eWMj59AblpBfwVqxZOK4nKRJukpwYrEL/TyRcryUoTzOzchlG/HNuXvVCZ1m7gmbFa9n2kkpmqJPRVNAYyUQVOVetatHv7cITJxFyMrVjnCskm9usX6pkZ08f3hYGwjCuDcvjV3ah1CX7rXQcJsQm3wPrPBlo2i2Vn9XkuUDXvnNF83qLkSPINHAMuHND7I6t3ARKYQpEuzG8xUSdEafm+pm9lgo9ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Te7udhJfKaN+1a2lI9KhZnB53WgS0CXp1xN1/UDB3ys=; b=B5O3zLdkeKR1/ur53OjYHmRW9Kb73Jc5mMIE5XfY3a/7CK6tvX1aYOAQgrxY0zhjM2tCPR9lrwUxEMSSuR6fZjlG6cR7zwaQ5TxJWwlrKlWrpGYLDsLUKsbzWpqs6s4ysuZE5M6xg2IjPHJ3E1jbxCctuHDhW+5hmD+uvNSEjCM= Received: from SJ0PR03CA0262.namprd03.prod.outlook.com (2603:10b6:a03:3a0::27) by PH8PR12MB7206.namprd12.prod.outlook.com (2603:10b6:510:226::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Fri, 21 Jun 2024 16:51:31 +0000 Received: from SJ5PEPF000001F6.namprd05.prod.outlook.com (2603:10b6:a03:3a0:cafe::8c) by SJ0PR03CA0262.outlook.office365.com (2603:10b6:a03:3a0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.37 via Frontend Transport; Fri, 21 Jun 2024 16:51:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F6.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:31 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:27 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 4/9] cpufreq: amd-pstate: initialize new core precision boost state Date: Sat, 22 Jun 2024 00:50:59 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F6:EE_|PH8PR12MB7206:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c8b2807-b595-4afa-e1a4-08dc921266d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|36860700010|82310400023|376011; X-Microsoft-Antispam-Message-Info: iZ7pX73xtuG0SfPtgQ64fkNAYkVhEZjsfkhqdz8E2ZiCcT0kRRgJW4luGbCt5uzd2CURU74zfRG+31rXW7tAlcEvnN1YgjpcSsK0f19cMPv9VbdWU3YWc7UV4ZwS8JvJSM2Po/mCj7XyXlLKAMWjBxf7ZxGirx1OSNToBk0Azn1GeLKNPXIAtHDNWDx/XiLwpQbBkFCnB/3Os9DBOGqJ6bgLng89MLSlfwc+ZIi9v2C6GXJezv7f9/pCT0R0/oI8CXCNydxr0Vq2kFOeP5TLowtr5HFoWELlh6ZmnlEkwZHIa8wJZEbfEzys15CTrtDprI38D/AQAJSGWuQUzCudEG7cauuJGmpWt1mlbSy22oJUk/yHbqQ+CP8WJFrwR2D8qLGQ+cSmElSvuaK8LWJY9sSjUTGAfE2je9miq6zKf2DDhDl/hnPM/S58mV1TUkS/8MB4XD+1Q7vHWcM1rzKe79JyTfbd0mMWNsixOQWwNcQDZhgVYzN1AH3bpz53zdAwJvTs2tiJ5DhNU5nuQ8eGopS3RfHEOH6gnLiCG4+UDUuDio4dK4Cc8BTGBu6bdnVfRxg2OSVLfFubqRsSrCZibjnHEMCKxEYMicbW9/+4qk3pEe9xS7POnlCjFg40HHC4JbErUsfpExkrRZZQKTlz9ZmM4SOQl6g2JUkdtMtPUu2DWNXweEnLH0esKXt2aTpLSYi/M6UBcb36nWlytFVCEGZiyRWc7ne2lQS+Rm+EPs7bDHZrYc/exSH8jrP3XGUiSyBingE/JinycbISzcv5nW9NCgsgDsNeTzIJZgbx60oR7itJscjJu9MPbd1PoeC7YiJ+fsNUUvl1vvfV78G04/1uojrBA3M7Ipz9qYSN5q44oo58nHxRzyIXgy+ww4xDayknhi5H5uI2Wosp/dTD4xBHsvHGZIASLE345ZCjTiwA65ownD4wYMK3V6qSTFyAu8ND75kJGPEn5+nCzcroCzNYgSpGaU6O14j9oli5vNTMlve8b6gWRej3bXYFPXFvgeKW4/1rpKqVOuchrRAaG8yBMZ6N+b/TOz+GF0IWfIDyymKmfnvtIhR9QsO+pq+a6I7KSJQrS8zrDsUidKIgKOB2w57HM+8mjnKjEVB/vUsxF4pW3bRNyn6zKhN6wFbN3kfqasYM2rTFnNff39m2H/15WryOX/q3HGtx7UFUfwhqHa+h+BjpmkOGzpboOFAdMC52L4/SPl639qxpEGTfbiCXob5K4JiWN4T4G8rZyZwW7TgKOJTERJ709hXg8PpVwiscygrW8TQ/o4EaPMlKtIp6JzEIbuU95BbzsWCvXgrVEGWwsCPP//DEhfDubBtoW4BlJMFWj/YuX5mccoo489WpPTdnngBsFhM9PVxIpyk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(1800799021)(36860700010)(82310400023)(376011);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:31.0657 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c8b2807-b595-4afa-e1a4-08dc921266d4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7206 From: Perry Yuan The "Core Performance Boost (CPB) feature, when enabled in the BIOS, allows the OS to control the highest performance for each individual core. The active, passive and the guided modes of the amd-pstate driver do support controlling the core frequency boost when this BIOS feature is enabled. Additionally, the amd-pstate driver provides a sysfs interface allowing the user to activate/deactive this core performance boost featur at runtime. Add an amd_pstate_global_params object to record whether CPB is enabled in the BIOS, and if it has been activated by the user. Reported-by: Artem S. Tashkinov" Cc: Oleksandr Natalenko Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217931 Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 65 ++++++++++++++++++++++++++++++------ drivers/cpufreq/amd-pstate.h | 13 ++++++++ 2 files changed, 67 insertions(+), 11 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index c418f2bb5ced..d3e7f9cfa5c8 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -94,6 +94,10 @@ static bool cppc_enabled; static bool amd_pstate_prefcore = true; static struct quirk_entry *quirks; +/* export the amd_pstate_global_params for unit test */ +struct amd_pstate_global_params amd_pstate_global_params; +EXPORT_SYMBOL_GPL(amd_pstate_global_params); + /* * AMD Energy Preference Performance (EPP) * The EPP is used in the CCLK DPM controller to drive @@ -686,7 +690,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) if (!cpudata->boost_supported) { pr_err("Boost mode is not supported by this processor or SBIOS\n"); - return -EINVAL; + return -ENOTSUPP; } if (state) @@ -704,18 +708,42 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) return 0; } -static void amd_pstate_boost_init(struct amd_cpudata *cpudata) +static int amd_pstate_init_boost_support(struct amd_cpudata *cpudata) { - u32 highest_perf, nominal_perf; + u64 boost_val; + int ret = -1; - highest_perf = READ_ONCE(cpudata->highest_perf); - nominal_perf = READ_ONCE(cpudata->nominal_perf); + /* + * If platform has no CPB support or disble it, initialize current driver + * boost_enabled state to be false, it is not an error for cpufreq core to handle. + */ + if (!cpu_feature_enabled(X86_FEATURE_CPB)) { + pr_debug_once("Boost CPB capabilities not present in the processor\n"); + ret = 0; + goto exit_err; + } - if (highest_perf <= nominal_perf) - return; + ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val); + if (ret) { + pr_err_once("failed to read initial CPU boost state!\n"); + ret = -EIO; + goto exit_err; + } + + amd_pstate_global_params.cpb_supported = !(boost_val & MSR_K7_HWCR_CPB_DIS); + if (amd_pstate_global_params.cpb_supported) { + current_pstate_driver->boost_enabled = true; + cpudata->boost_supported = true; + } + + amd_pstate_global_params.cpb_boost = amd_pstate_global_params.cpb_supported; + return 0; - cpudata->boost_supported = true; - current_pstate_driver->boost_enabled = true; +exit_err: + cpudata->boost_supported = false; + current_pstate_driver->boost_enabled = false; + amd_pstate_global_params.cpb_boost = false; + return ret; } static void amd_perf_ctl_reset(unsigned int cpu) @@ -1005,7 +1033,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) policy->driver_data = cpudata; - amd_pstate_boost_init(cpudata); if (!current_pstate_driver->adjust_perf) current_pstate_driver->adjust_perf = amd_pstate_adjust_perf; @@ -1387,6 +1414,21 @@ static bool amd_pstate_acpi_pm_profile_undefined(void) return false; } +static int amd_pstate_init_boost(struct cpufreq_policy *policy) +{ + struct amd_cpudata *cpudata = policy->driver_data; + int ret; + + /* initialize cpu cores boot state */ + ret = amd_pstate_init_boost_support(cpudata); + if (ret) + return ret; + + policy->boost_enabled = READ_ONCE(cpudata->boost_supported); + + return 0; +} + static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) { int min_freq, max_freq, ret; @@ -1456,7 +1498,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) return ret; WRITE_ONCE(cpudata->cppc_cap1_cached, value); } - amd_pstate_boost_init(cpudata); return 0; @@ -1701,6 +1742,7 @@ static struct cpufreq_driver amd_pstate_driver = { .exit = amd_pstate_cpu_exit, .suspend = amd_pstate_cpu_suspend, .resume = amd_pstate_cpu_resume, + .init_boost = amd_pstate_init_boost, .set_boost = amd_pstate_set_boost, .update_limits = amd_pstate_update_limits, .name = "amd-pstate", @@ -1718,6 +1760,7 @@ static struct cpufreq_driver amd_pstate_epp_driver = { .suspend = amd_pstate_epp_suspend, .resume = amd_pstate_epp_resume, .update_limits = amd_pstate_update_limits, + .init_boost = amd_pstate_init_boost, .name = "amd-pstate-epp", .attr = amd_pstate_epp_attr, }; diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h index f80b33fa5d43..133042370a8f 100644 --- a/drivers/cpufreq/amd-pstate.h +++ b/drivers/cpufreq/amd-pstate.h @@ -102,4 +102,17 @@ struct amd_cpudata { s16 epp_default; }; +/** + * struct amd_pstate_global_params - Global parameters, mostly tunable via sysfs. + * @cpb_boost: Whether or not to use boost CPU P-states. + * @cpb_supported: Whether or not CPU boost P-states are available + * based on the MSR_K7_HWCR bit[25] state + */ +struct amd_pstate_global_params { + bool cpb_boost; + bool cpb_supported; +}; + +extern struct amd_pstate_global_params amd_pstate_global_params; + #endif /* _LINUX_AMD_PSTATE_H */ From patchwork Fri Jun 21 16:51:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707858 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9678D172BDD; Fri, 21 Jun 2024 16:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988699; cv=fail; b=smrP1bgFjEN9X49XaSysKfud/zXgPCZ1BCEDdqq8WRCys89v5cL91BAMShKJUA2VYJxQDCs6npAfmvP3dkwdVG48KEko2BWjMIvnhgkJ/emEAJn3Bml748YFRYDy1GQysO59F2NRf2SpfUS+nZKVcbhffrYScmG6Ph16sr6wkdU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988699; c=relaxed/simple; bh=b4YvyB5U2ifL/jf+cXL/h1xFxLzyhZVZZ0JR9bYCFw8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PxTIPZJMeVLEUux8+ood2sxlpvp3BbywVtVYoxIZ2W7JoUWiYOV/DsIqb1GvUvMPDQXQ4s4vX9xPaUkOhTmcrpAJa+FP9AJBMSARzYiJl5yiGjJNylZxsLF4hnElKlYe3PPxL7aTvc3r/dSnKHwdQHwfQvU4NNzz97NZaXUUK0g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=lbsMPAo0; arc=fail smtp.client-ip=40.107.237.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="lbsMPAo0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWmTfVUq0EUKdmjXwWK789PPNAnSZH0cSIDTpbvxKivyZi7U68UJ/74zOqF5Xe1o4hgR1zQuE/9sSW8e0d7wJrr7d/I1dund0eCdqoYR1C+Sw5JcyQgxHE3+Nom+7At+LPs+zk5csn09iL6NCdahuBTavzZHaHuDa/ge+8VIw8ef6zDoLsZgbTqe9KBe4ScfLJQv4XVDsmOkh7auxsNQqTyzPb/YKGQnQPnMn5I47ci72EjCww+NWD7ls4QiGZxQ4DyFZ2uNK4La8WXnotPeeGtxr7pxT9y6PnVjc3yqmFoZePUTRlxBY1nbKMxpig/evD1RQ/FJj5aYvVPjQApmcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TiWftcHYi6AJT6z+rfIJDltwWR5mmUSojG7fJAnbZHs=; b=BhF1sa45NGb7aP+0CSjQBRdsBT+5iK+RxymM1uIGSyOA8thsPyuxAXX7GUhyK3SKgzNTcZLSgHj41Z4UuDxXpRKkA0ghaMk7RV4u2hbkhOPLgYSsytOjF+7z0OsDt+5jAcnf2lBf9MQmtPImYupTdqmUd22v4N4hGyEUKuwyd+6K1vrJPfSkDXG4y7qD8XQZ1njdXtRzIeEBM2Wo9u4JVgDIm7ct1/jwXglwZixCJVNDBRW9Rgx5Ht7MfFmfZhIm0JtC/uoYtE7e0PGkoM504q1xRp2MLPZfJ99DeBUfF//lL9XioCwljlUHsUzvtbI1S2EBDo216nrWxt1bYIMSkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TiWftcHYi6AJT6z+rfIJDltwWR5mmUSojG7fJAnbZHs=; b=lbsMPAo0cM8tiiGF+B4qR4rzph8O65syYJWhbxKEDEm1lCQl5ymV+BNBqa/mlntjAOZgt6HYRMfqIhN6hWl8jEFgPGaj+AVRn2qWgMzkYp69SBoPlX0WKBc925H+y0me1N99FWr6H3Uipm6CpSFknjzep0BnvDIZAhpik1aZ2QI= Received: from SJ0PR03CA0247.namprd03.prod.outlook.com (2603:10b6:a03:3a0::12) by MW6PR12MB8663.namprd12.prod.outlook.com (2603:10b6:303:240::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Fri, 21 Jun 2024 16:51:34 +0000 Received: from SJ5PEPF000001F6.namprd05.prod.outlook.com (2603:10b6:a03:3a0:cafe::60) by SJ0PR03CA0247.outlook.office365.com (2603:10b6:a03:3a0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.37 via Frontend Transport; Fri, 21 Jun 2024 16:51:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F6.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:33 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:30 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 5/9] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Date: Sat, 22 Jun 2024 00:51:00 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F6:EE_|MW6PR12MB8663:EE_ X-MS-Office365-Filtering-Correlation-Id: ce25c3fe-b93c-4d3c-f3b0-08dc9212688d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|82310400023|36860700010|376011; X-Microsoft-Antispam-Message-Info: eyRITpS9lq/aXFmSbokGNIWxKKaOxLMDWHWImzbwZmYJLykbFk6kx+mncdIkxULXHnpzC8cVMlImh3j4hSDuG1w/AuhcyXWSn52JD2s58W6NjaF+JscjrL4d4gBt+piqy7hT9micOSE2HRJ2WlwqA9HMUrI6v4Ykus8bwGlRGjPseedNJksB92ngm1Xxw+zUaAc2JwpFCbrrKhOO/i2PX8ujD6s2CzhcPDqnfm9a0VGeyMM9L3J3iFplvFt/pYww8kdGgMK59I12aEvNx9CrCUs0C9DNDXc3xzOW1egHrTmpL0NRdqqLYTcm+UXloDBgZjRMTyEzrEan0q8zWAtwx+errgL2zIDow1eizIeD4RdQqevK+1REIUvV5wLahOF0QX60b3JP+QYmzO3jZtNcG7m1HfundQbltCWaCpxKlgA+lX5iuqltUcmpNv1sfOj/50YcWr2eIhzXudVBHV7VHv+R2G6oF/yRpvIc0Na9Vt6ngUW3YR1pLbsQ71zJG51hbsrRgq3sFfKZCstSjqR1s3Bh9GtVt+4YOdMzOEvk+728Wbq7CbNToOEnNgcMLgfsdunNAJgTRLT0sgZxpHjNdJXQSdD6Ins3GPX8DHyM3vqqTwFmiorio8XNxy8RaR12sub/svRkG++0le+r2BoTKF31OjcVVC6sbISFWziTfZv13Pm8mgXWtNXCGhs6JdI6HTGBaGaA1s9naaocgrZaE/khM74UKu64nTv9W3ASisjyRYTX9r/FqIR1NSP1VW1HhXs/9TM4gMwPIIBhog0hxDmxuWUI7ZIpHPhLwtU4NP5WtxIwRLGiPn8XvT3HMWS+3/UskWHiCAdjTMSR6vdw/du4KIzqbqIDejHiAEbCk40rwiT7t/HECIBMohjtOHl+pdQ+xJqFg4X7GUlW4CbErUPy1n1p6KPJ9GB7/JMwn3qFGFT9RW1W6GvTE65lrhpKEgBqbthoWUNA7eUjZ2pro8XlRP9IiLyZEyc4H1r6CZEajoDsw4wFjnkkgVIKqbDlVkRt4PeJhIRclTbyMyE0jkQ4ps1u/vkhs0hm/aAhHiFrFQIeJq7SaZ1NXR5fSEPUtoul+acXnx6QjIZj8YlJAtrz6v77QHY64KI8ocOqy0jlZsvqQ/B5/VXTdaEkp0+xQBvvPbnywCV6GW2jetbzY08sNBvL9i/8ZJV0f78+sjjFHtAVl4wmAjjB7yj4i/Wm2KJIbBfiZuB8YaWJPUCZ++HbU+mh7fJHH9+mIrFDTXP3bDxyKszMSnQI+Tmcba3Cc7XY0oPbjFnBAn9/CVm5WUGZlKT9g1bBT9nnahzjXKU1X2wb+8ULhMUp/4fQdcx5SO9ddUJjctc2cTE5n3TN+vuZK2Ii91srxfeuIGrHlx8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(1800799021)(82310400023)(36860700010)(376011);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:33.9561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce25c3fe-b93c-4d3c-f3b0-08dc9212688d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8663 From: Perry Yuan With this new sysfs entry `cpb_boost` created, user can change CPU boost state dynamically under `active`, `guided` and `passive` modes. And the highest perf and frequency will also be updated as the boost state changes. Check current boost state: $ cat /sys/devices/system/cpu/amd_pstate/cpb_boost enabled or $ cat /sys/devices/system/cpu/amd_pstate/cpb_boost disabled Disable CPU boost sudo bash -c "echo "disabled" > /sys/devices/system/cpu/amd_pstate/cpb_boost" Enable CPU boost sudo bash -c "echo "enabled" > /sys/devices/system/cpu/amd_pstate/cpb_boost" Link: https://bugzilla.kernel.org/show_bug.cgi?id=217931 Link: https://bugzilla.kernel.org/show_bug.cgi?id=217618 Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate-ut.c | 2 +- drivers/cpufreq/amd-pstate.c | 129 +++++++++++++++++++++++++++++++- drivers/cpufreq/amd-pstate.h | 1 + 3 files changed, 130 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c index fc275d41d51e..b528f198f4c3 100644 --- a/drivers/cpufreq/amd-pstate-ut.c +++ b/drivers/cpufreq/amd-pstate-ut.c @@ -227,7 +227,7 @@ static void amd_pstate_ut_check_freq(u32 index) goto skip_test; } - if (cpudata->boost_supported) { + if (amd_pstate_global_params.cpb_boost) { if ((policy->max == cpudata->max_freq) || (policy->max == cpudata->nominal_freq)) amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS; diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index d3e7f9cfa5c8..6710b3c28cda 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -97,6 +97,7 @@ static struct quirk_entry *quirks; /* export the amd_pstate_global_params for unit test */ struct amd_pstate_global_params amd_pstate_global_params; EXPORT_SYMBOL_GPL(amd_pstate_global_params); +static int amd_pstate_cpu_boost(int cpu, bool state); /* * AMD Energy Preference Performance (EPP) @@ -139,6 +140,16 @@ static unsigned int epp_values[] = { [EPP_INDEX_POWERSAVE] = AMD_CPPC_EPP_POWERSAVE, }; +enum CPB_STATE_INDEX { + CPB_STATE_DISABLED = 0, + CPB_STATE_ENABLED = 1, +}; + +static const char * const cpb_state[] = { + [CPB_STATE_DISABLED] = "disabled", + [CPB_STATE_ENABLED] = "enabled", +}; + typedef int (*cppc_mode_transition_fn)(int); static struct quirk_entry quirk_amd_7k62 = { @@ -734,6 +745,7 @@ static int amd_pstate_init_boost_support(struct amd_cpudata *cpudata) if (amd_pstate_global_params.cpb_supported) { current_pstate_driver->boost_enabled = true; cpudata->boost_supported = true; + cpudata->boost_state = true; } amd_pstate_global_params.cpb_boost = amd_pstate_global_params.cpb_supported; @@ -741,6 +753,7 @@ static int amd_pstate_init_boost_support(struct amd_cpudata *cpudata) exit_err: cpudata->boost_supported = false; + cpudata->boost_state = false; current_pstate_driver->boost_enabled = false; amd_pstate_global_params.cpb_boost = false; return ret; @@ -1352,6 +1365,118 @@ static ssize_t prefcore_show(struct device *dev, return sysfs_emit(buf, "%s\n", str_enabled_disabled(amd_pstate_prefcore)); } +static int amd_pstate_cpu_boost_update(struct cpufreq_policy *policy, bool on) +{ + struct amd_cpudata *cpudata = policy->driver_data; + struct cppc_perf_ctrls perf_ctrls; + u32 highest_perf, nominal_perf, nominal_freq, max_freq; + int ret; + + highest_perf = READ_ONCE(cpudata->highest_perf); + nominal_perf = READ_ONCE(cpudata->nominal_perf); + nominal_freq = READ_ONCE(cpudata->nominal_freq); + max_freq = READ_ONCE(cpudata->max_freq); + + if (boot_cpu_has(X86_FEATURE_CPPC)) { + u64 value = READ_ONCE(cpudata->cppc_req_cached); + + value &= ~GENMASK_ULL(7, 0); + value |= on ? highest_perf : nominal_perf; + WRITE_ONCE(cpudata->cppc_req_cached, value); + + wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); + } else { + perf_ctrls.max_perf = on ? highest_perf : nominal_perf; + ret = cppc_set_perf(cpudata->cpu, &perf_ctrls); + if (ret) { + cpufreq_cpu_release(policy); + pr_debug("Failed to set max perf on CPU:%d. ret:%d\n", + cpudata->cpu, ret); + return ret; + } + } + + if (on) + policy->cpuinfo.max_freq = max_freq; + else + policy->cpuinfo.max_freq = nominal_freq * 1000; + + policy->max = policy->cpuinfo.max_freq; + + if (cppc_state == AMD_PSTATE_PASSIVE) { + ret = freq_qos_update_request(&cpudata->req[1], policy->cpuinfo.max_freq); + if (ret < 0) + pr_debug("Failed to update freq constraint: CPU%d\n", cpudata->cpu); + } + + return ret < 0 ? ret : 0; +} + +static int amd_pstate_cpu_boost(int cpu, bool state) +{ + int ret; + struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); + struct amd_cpudata *cpudata = policy->driver_data; + + if (!policy) { + pr_err("policy is NULL\n"); + ret = -ENODATA; + goto err_exit; + } + + ret = amd_pstate_cpu_boost_update(policy, state); + refresh_frequency_limits(policy); + WRITE_ONCE(cpudata->boost_state, state); + policy->boost_enabled = state; + +err_exit: + cpufreq_cpu_put(policy); + return ret < 0 ? ret : 0; +} + +static ssize_t cpb_boost_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + bool cpb_idx; + + cpb_idx = amd_pstate_global_params.cpb_boost; + + return sysfs_emit(buf, "%s\n", cpb_state[cpb_idx]); +} + +static ssize_t cpb_boost_store(struct device *dev, struct device_attribute *b, + const char *buf, size_t count) +{ + bool new_state; + ssize_t ret; + int cpu, cpb_idx; + + if (!amd_pstate_global_params.cpb_supported) { + pr_err("Boost mode is not supported by this processor or SBIOS\n"); + return -EINVAL; + } + + cpb_idx = sysfs_match_string(cpb_state, buf); + if (cpb_idx < 0) + return -EINVAL; + + new_state = cpb_idx; + + mutex_lock(&amd_pstate_driver_lock); + for_each_present_cpu(cpu) { + ret = amd_pstate_cpu_boost(cpu, new_state); + if (ret < 0) { + pr_warn("failed to update cpu boost for CPU%d (%zd)\n", cpu, ret); + goto err_exit; + } + } + amd_pstate_global_params.cpb_boost = !!new_state; + +err_exit: + mutex_unlock(&amd_pstate_driver_lock); + return ret < 0 ? ret : count; +} + cpufreq_freq_attr_ro(amd_pstate_max_freq); cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq); @@ -1362,6 +1487,7 @@ cpufreq_freq_attr_rw(energy_performance_preference); cpufreq_freq_attr_ro(energy_performance_available_preferences); static DEVICE_ATTR_RW(status); static DEVICE_ATTR_RO(prefcore); +static DEVICE_ATTR_RW(cpb_boost); static struct freq_attr *amd_pstate_attr[] = { &amd_pstate_max_freq, @@ -1386,6 +1512,7 @@ static struct freq_attr *amd_pstate_epp_attr[] = { static struct attribute *pstate_global_attributes[] = { &dev_attr_status.attr, &dev_attr_prefcore.attr, + &dev_attr_cpb_boost.attr, NULL }; @@ -1424,7 +1551,7 @@ static int amd_pstate_init_boost(struct cpufreq_policy *policy) if (ret) return ret; - policy->boost_enabled = READ_ONCE(cpudata->boost_supported); + policy->boost_enabled = READ_ONCE(cpudata->boost_state); return 0; } diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h index 133042370a8f..fb240a870289 100644 --- a/drivers/cpufreq/amd-pstate.h +++ b/drivers/cpufreq/amd-pstate.h @@ -100,6 +100,7 @@ struct amd_cpudata { u64 cppc_cap1_cached; bool suspended; s16 epp_default; + bool boost_state; }; /** From patchwork Fri Jun 21 16:51:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707859 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062.outbound.protection.outlook.com [40.107.237.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4428D174EC6; Fri, 21 Jun 2024 16:51:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988701; cv=fail; b=H9y2K4J5i0iNx14QgYk/PQJUyokwhNfMZBpg4ZlOOZcQEOygIidRLi+7nISSYHarX9JPQEbmvvrEvhvd1DvRRU38x78ugXvqzfnZcNa7A1oTJNtlcZAaV/tjKzUrF6AlMYkzlQ0L3zMFANvUMo6yAOt6bDmiOeakNXojZFDqarQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988701; c=relaxed/simple; bh=bBepyORGw0e2z7dKCGcvEnkJnI0hv7HvL9sf7FuXG5c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PEILTIO8xVlzw859Bxe5rW/b0aytUIrI+Lq3NklqOOrX1il+BIbvB8qcsYFStmg0jUi1y1dJ7cX60gR8HDVIAbJ7EeQYLbbRFQAgX1pNWLlCCn2jeQIGEBUCQnSLh6YvgjOM3NZrfnOGoQVswOfC8xzZZSSGVGKnIlV3LgyPUeo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kUW0zzG7; arc=fail smtp.client-ip=40.107.237.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kUW0zzG7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxSlMmVHS7wMZ4A+2vKQGufHAF0oTVvI2dgClGu5PZaslk6BD1W7wL1vzrcv5xf2AMEwCnXzqOyRJmnq7r2iBiU/10L1iAgCCc/l9XHhAykD7taJrFOysjJ0piAS8u8FrDNEdHNTkEmg4+G35MLloVBziM+iXdcrlxH5z40YNiHyM+Nb10X9dwCx/NjPRXZH/6iZZVJRtCtrai1FD3+ZYBE6RJ+yABnAqscb9Gjor+9JbMrGSHOjk59ZHcWjbRYCrqGQKKKURY29BUq3yET2dhF/TqnTmGyW+mDhtyO3gNwyU7oCq+XYoqQQa7Wuc4LOCSRqFAGowB/rxey0vxg8Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EZudm9BAzo7Gu5Tqw/92zAUky1ExBkLzjnPVJ2P+1h8=; b=GDnqwTD5AZNKE+IlwI27VO8JuLME/aOCUDlWPdg24efl3bHjX21qckWLQp2QcsyElNrIoTGv+IBQMxZO1xS9lyU9Ylq2CE1CdJJ1t4biCQiPaMrB3y7oIJSzaSBJdTyqgM2tEhkXwNsguNuHY8X8cpOn9dB90UGSOULel9me8M9N8kCSgimXPxLdif2K96M2C1MlQwZ5nFGLRd2HtgzltChRsdJkah/uVNtiC+T7lqrAxee11sol2RB7hOh4bgpcVgvJ1n0bxJCk1GzxpuJrebJHBcb6n/9Ho6f0Pt08AH/zgj2JmnBLR0sah2uRpxek/rKgm1rOhQfjGsq5Ak435g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EZudm9BAzo7Gu5Tqw/92zAUky1ExBkLzjnPVJ2P+1h8=; b=kUW0zzG76ncy7oD7K0r7/1gmftZX3A0+PP+sOTuc5p3huqxTED7sZA+QV6os+7hUpWN7EkSKeZjjO94Da2WXeeSGBfFqEgqA+smnQGMFZdswsGa/f/SLPA7IypLtHcl0cid8ZDKTw0m8LLCwTy0G0G48glMnhzC0WPlrGfZa6HI= Received: from SJ0PR03CA0179.namprd03.prod.outlook.com (2603:10b6:a03:338::34) by IA1PR12MB6532.namprd12.prod.outlook.com (2603:10b6:208:3a3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.22; Fri, 21 Jun 2024 16:51:37 +0000 Received: from SJ5PEPF000001F5.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::b8) by SJ0PR03CA0179.outlook.office365.com (2603:10b6:a03:338::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Fri, 21 Jun 2024 16:51:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F5.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:36 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:33 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 6/9] cpufreq: amd-pstate: Add set_boost callback for active mode Date: Sat, 22 Jun 2024 00:51:01 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F5:EE_|IA1PR12MB6532:EE_ X-MS-Office365-Filtering-Correlation-Id: e12fb8d9-9d81-46df-ec5d-08dc92126a3c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|82310400023|1800799021|376011|36860700010; X-Microsoft-Antispam-Message-Info: pRocTqHtyS84QwvxOi4WNka16phuUU2xR+eRNb5IgNMUnnD2mhDel7y1qpWYgSRrN50gAY/P3dpTEtHKql4o46dgoLIAHbXYBsA4fdo4bYvA0qpu1/OOb1qAu7XRETD5PpALN+eVFDw43gfSdAkPsZPbdEDkZCYCzFR6jeiok8k0uFi5v+eZp7AnpCIOBnrNGi2aF6RigyJ/ZD5il46p72lW1khSXOC/f+wZwJuRHb8ZdXqYw8mCwYYx3/QU5x8Pi88iAVmlhyQKS04jrh8OwGbtuhjIYrnI9e5OupPyFI0TO3vaFD9+oxTYGGQaKS5CfUWeAZBzhyN8k6xxm9+rFi6kjLOwDY/sk+R5VJPzdcamg/fwJ6QN4tMEWmEkgekh89D/IT0JjdtO8uD8Dkg3gw00C2AiHOOoqCr66WMnYTCIlKaAMjkCcdrRnnE88Cx9sFzMrLhTQfQWYGyAIixalb8QYdMuVSAUPbbHg02t0fJgPJsGCD8T+kZ0XNdkaP68kDsTzEWAkNOAkiPZe8Z2VslGP5ik4C6pitd7hxGXExzd3o1s62ffKuygwrewCAPF+wiIjQ8CTTAihemy0KOQ6r8cnUO5W4uxBPVOu14s1aBe/LKvC1mcMtZ8VPyhJgFMVKIUOQujCprLRoYGRY51XvEVJBCrQDDzedznNSOlrKNgldRVWf1ECyFDV5LF4Yw7dzMuHLrHguURbMp/EdFWCKx5FUGaUMw1cgbpMwor49VzWndKHkmt87tlMHTvLGoK7es4oKevxxDEOVA3PM6eCG75X67oDOjZegRpKTRdqx1AOzBOdxjaBAqkMXJF9Lg8M+RaU0J1OZZTDoC9wFMW29oG86yTI6WhOrBGaIq9iJnXyNUVLElS5Fd/IxNlqQlFj39ECE/fg49NPZhBUQk0wF7/nXGpCFbM7bvvHraQ9imz0Uum35iuRAr2WxqNlMPlXIeKNS2CYtPKLZ5+Ft28yzLnKYkPPFPDUJPW5UXw9LAIwe4gYTZUz02339vaH4/UU/aLDRfqhkU2SLXJDOah+oyH42m758AjSUzOmMnso6juOPVfFwdm9ZZ49/GoH+NxvOS0GE3YEByxnuvqvh+PFrbyE4QMb3plW68BoM5nfgdByNzVDFF/Dh/VtgbcxSXzoKKeQdYP0D5h0FhefGobtnVxxdOP30kA77kahupoA5+9r5eYaeT1ZGCUtb9pfPLhU2BAtztxXP8wYl04DK2P6BDUCDeBqb/cp8Mi14wrN9MgA8E5J5ecn2JvRvLSxVnbF8hLXea4W2aDp5rxVXUjc8xBNIGoO5WUBLo/xx+E1EeUXXDGu5d5gLBkvYWLDaVoXy7ZW0Rck1CpsVB7dZmJo2fSyAk5MvwfPbV7ml3arrnDTLfM0Kg+axBGQwY8jn+uvlBi8gX++TBY8WVWZe2CpQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(82310400023)(1800799021)(376011)(36860700010);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:36.7805 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e12fb8d9-9d81-46df-ec5d-08dc92126a3c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6532 Add support for the set_boost callback in the active mode driver to enable boost control via the cpufreq core. This ensures a consistent boost control interface across all pstate modes, including passive mode, guided mode, and active mode. With this addition, all three pstate modes can support the same boost control interface with unique interface and global CPB control. Each CPU also supports individual boost control, allowing global CPB to change all cores' boost states simultaneously. Specific CPUs can update their boost states separately, ensuring all cores' boost states are synchronized. Reviewed-by: Mario Limonciello Signed-off-by: Perry Yuan Acked-by: Gautham R. Shenoy --- drivers/cpufreq/amd-pstate.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 6710b3c28cda..02767230524e 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -703,20 +703,11 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) pr_err("Boost mode is not supported by this processor or SBIOS\n"); return -ENOTSUPP; } + mutex_lock(&amd_pstate_driver_lock); + ret = amd_pstate_cpu_boost(policy->cpu, state); + mutex_unlock(&amd_pstate_driver_lock); - if (state) - policy->cpuinfo.max_freq = cpudata->max_freq; - else - policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000; - - policy->max = policy->cpuinfo.max_freq; - - ret = freq_qos_update_request(&cpudata->req[1], - policy->cpuinfo.max_freq); - if (ret < 0) - return ret; - - return 0; + return ret < 0 ? ret : 0; } static int amd_pstate_init_boost_support(struct amd_cpudata *cpudata) @@ -1888,6 +1879,7 @@ static struct cpufreq_driver amd_pstate_epp_driver = { .resume = amd_pstate_epp_resume, .update_limits = amd_pstate_update_limits, .init_boost = amd_pstate_init_boost, + .set_boost = amd_pstate_set_boost, .name = "amd-pstate-epp", .attr = amd_pstate_epp_attr, }; From patchwork Fri Jun 21 16:51:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707860 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2040.outbound.protection.outlook.com [40.107.212.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38319168483; Fri, 21 Jun 2024 16:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988708; cv=fail; b=Man4VfXcgCCcVZUCb+ug0RppOahCTPvhgxANItv274Tgex5YSnJOlkMA594iiixNU4N8lqIHDEOMk6MOjP2t0lRTtrDA/3GxfAjaotWrGbZ0ddmpyqMTaq/9vUS8kbuswyJTqUbUyuJBCVmJO2rBC1NljaoV/fOXLg55qGEuyRs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988708; c=relaxed/simple; bh=dyz/A7b8bt6YXHT3er8fK2/6IKJLoZGiReFbziqknaU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dSyoerD+wkAqgCXndl61i/x4CFKlwyMfkqov1wB+7LaZhf5z+CNLI/vU4bACBmAX/D9c2nvx0P4akIU/6TCntsrOPNHqxE5Gb0TN5MB4AOwSATYr4OrQ4EKu/WuJrnt0vzWoAI/LbyjY4/sAiCr/7F0cRSbEd/4c6l0vE4f7QLc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kLaQicnq; arc=fail smtp.client-ip=40.107.212.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kLaQicnq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tq/MQ87V5SeRYPFLlZZZA2WryW5HXLzwfIktomqqmGjVxF/IKkSkSZ4PiG7QLhbI7knQb7apUaU+SC4g9/D1oovQ5Nhbw+9tGiANwtDi8nrcrESx+UYv3646PtgapmW9chsGEAfa2Amqbr55Qdqlb8kn2nGPPahIiia8CVyLbJNOadUAcZ77UBmCKVbYdrGSNkq8nuIUShZxWGk/oV4lEG/6YYtzJOdHiiUOgRxyauYFw02uhoPINNnTyxyOQnIH5xi/sEj5M2SH4Vcfbcf6VwtKDsV7Y8apD/Q/SCy28iwgb6eOxdk3vTWFG9n2LAd68rMkdkIMSBAXFQH2fFm4RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DnE2l2SmN1ZHN0lvVbSWR9bGHmsB9izVA1/npTkmmD0=; b=edrQyfJwDtsH7DPf8xkIWwCw9l3GXaeyBC5qpSD1ShFsaEZx9ApY4we3zBMKnX24STGnqZrjs6PwlA7lBBLwXba+AdyArXh9DRPkIieapG2yw4aXGq4oylExoGbkAhEJ1rAjW30OjeUQt1oLUVMUvdWd8ObHD8lyRZcrNecVwCR0PzcHIioNy+MJEta0mip56jjkyS880bZYI17DeVn33qZqFF90+Ia0w4ebHJstbs1pn6yM0j/iuSdZs+uZKgWP5byMEZz2J8KGyQOkJKyCOO5iKoapKShNGJAVbuSm2bCEcyZur5lzO9rGG0pD9q9AsyxLPo9wGyChkWxh4Ri83Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnE2l2SmN1ZHN0lvVbSWR9bGHmsB9izVA1/npTkmmD0=; b=kLaQicnqa/yEnIP/R71FxFQmFw/0eDMqu4e6Qv/TRFLOaqY/GBPgHxdntrOBl7JxcGE0V3BETIF1o3NqzOP2xI0Zz2V9W5sEA5MOi48yHq4h4EQZ+P7yKl+BBe/sJGFPVP6z/iFJ3AR/2+ZbHu+6gbgjQX+bcZPa6/phLdYrAHg= Received: from SJ0PR03CA0171.namprd03.prod.outlook.com (2603:10b6:a03:338::26) by DS0PR12MB8317.namprd12.prod.outlook.com (2603:10b6:8:f4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Fri, 21 Jun 2024 16:51:43 +0000 Received: from SJ5PEPF000001F5.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::21) by SJ0PR03CA0171.outlook.office365.com (2603:10b6:a03:338::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Fri, 21 Jun 2024 16:51:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F5.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:42 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:36 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 7/9] cpufreq:amd-pstate: Cap the CPPC.max_perf to nominal_perf if CPB is off Date: Sat, 22 Jun 2024 00:51:02 +0800 Message-ID: <66f55232be01092c423f0523f68b82b80c293943.1718988436.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F5:EE_|DS0PR12MB8317:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a887171-5d66-45c2-c1c6-08dc92126dde X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|376011|36860700010|82310400023; X-Microsoft-Antispam-Message-Info: h5gM06GNdDerso3vbcappaNi7wklf/WkvDaWXmZ+uR/zeJzsRaWDv2XinvQTLRS0KCf/lI1coQGdX8yp6snSnOgtCEWOBJ04UxkloU6ngekLrTP0Ou2il5IfdbaM75hiW3cANUwf7gl3G5E7idkacMP31bghFXTqhNSu6+6nytTGfmqDHMQXyKlafNmBqlLMrCTdgzVuA+uuyEawxd/xYBpGw2qlQGHKuFqsRvuPt3npT62n91Djr8UFke51ZhAr19XdJ3WrvZjSvS0UFJXCC8EoW4MOQcvCUZjX2paj9ndjHZPcMuq69jMtZ66IEd5cfa0BUSsY/Sv7kAoDaY0APdSwgcLF3wsytvSeTF2ymVmM3k/e/gXsJ1GcaQ25yhyVJ87N2thqaQVnFbN/5gMbfw8S9X0RDBmdjaLOtPiD6OIheK1C6myBuIv/R3qWOb92U/SY2oDiy2tF4AumYyg1HRn5+QcnMB1J/QJjn7DGSJ+JCj3IvRG3D6psRirWe//9jt8gv6ObcL3ke5FMiFKj6aLQh5pDufgEW7QXpubdQa8SgunCgjEqMK0UawewTyJqZkRMINjMy5OCj1+3PQ8HQhNTl3SfUOFEPJNVlcH3KgfdNJPTu0wV/B/5ZZTx1tHfNgqdv387nHmNIh4TiPVRcV90wPgae4aKffuSI2wwKBPIv6G5QOC4U8Umu49O0ecsVwRW6xDZN2+5OjTKiEIhiaX1D/45eXMNuRD9CVa71zP0rlj5lN4u02ZQLUDEHgUb8Le/OJRrV8VYymVWCxgihUbwzuHysM7mqQW6DNFf8OXf1YwG4XMU2U/Eo2UMWQgk0nEIZ6daL2tRIon1d/fOmrX42TqNGBRK+ZSxGxOcQs5Zh8gkcYTK9N10817yaWwaxR3B++9NOr4L6pzmB6NNItvAbeO/BH9voiygvy9igQ0+KZOHyOWPly1RKNpvz75F8l79ppvLrmzJ6Z6OOZnOES24K935q0vN3wuSH+S9ICvSyycmi/T3sVg3DBhdcvJxRKVv22N9V0fQob5v2JwDG9yyyG9tpnvsbrURZ/fyk/jEXxFTfWy8UdNDusnlg1MyJXeiCLTdydCwYOK/FCmQ7wnNrdtUNp4Z1GI2k/BKUNbqloVN9cS4J1dazEAPmLsSECDipMmaF708gIkareicrlm4RoUmjpDZun/bmLgjRw02/4SD/7a/JDFvtd1oeKqtIDHy3AcI3y4CnRln6bHMFP49r/hbfnG9uRFiCn857xTdDgM7okp0WWVv3QWxwnk2HesVsEbvYKzB7ngRcCFcZVh+60mxZ6IMgGTsf6aMB0z7LKrDHDn71kSPdpNT9T/meN6893jmPYE819QiqrcMhl+Pv6lhvH+HLZo4OhOz/SAYy9GKXT74Lgh0NcJxYhHoUc3leGKOzNJoQUL1txQjHA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(1800799021)(376011)(36860700010)(82310400023);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:42.8587 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a887171-5d66-45c2-c1c6-08dc92126dde X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8317 From: Perry Yuan When Core Performance Boost is disabled by the user, the CPPC_REQ.max_perf should not exceed the nominal_perf since by definition the frequencies between nominal_perf and the highest_perf are in the boost range. Fix this in amd_pstate_update() Acked-by: Huang Rui Reviewed-by: Mario Limonciello Reviewed-by: Gautham R. Shenoy Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 02767230524e..05e80d2f8803 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -529,6 +529,7 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, unsigned long max_freq; struct cpufreq_policy *policy = cpufreq_cpu_get(cpudata->cpu); u64 prev = READ_ONCE(cpudata->cppc_req_cached); + u32 nominal_perf = READ_ONCE(cpudata->nominal_perf); u64 value = prev; min_perf = clamp_t(unsigned long, min_perf, cpudata->min_limit_perf, @@ -551,6 +552,10 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, value &= ~AMD_CPPC_DES_PERF(~0L); value |= AMD_CPPC_DES_PERF(des_perf); + /* limit the max perf when core performance boost feature is disabled */ + if (!amd_pstate_global_params.cpb_boost) + max_perf = min_t(unsigned long, nominal_perf, max_perf); + value &= ~AMD_CPPC_MAX_PERF(~0L); value |= AMD_CPPC_MAX_PERF(max_perf); From patchwork Fri Jun 21 16:51:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707862 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2089.outbound.protection.outlook.com [40.107.243.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037A6168494; Fri, 21 Jun 2024 16:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.89 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988714; cv=fail; b=VQwYvnVlXLn2PJomEy/MRwVkmhiqEYA4xuyqqybdUjOEJun+Mouzdtqxsd/VlwT+KPaOHzwqctnKjKCp+7RJfLbXxu9sFDDxUwRTYau/Kup6tFGOgJewT4gAhnKfKtbQcsPnLBvbGp8i9/VtuinGqNBrYwy8dT4CgKdO+kt54d4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988714; c=relaxed/simple; bh=PtWSKaQ+YAJZ+jOMXMgvwreqsjUys380ni0tSAVv0TU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GAyNbQm1C/mGebHzlOfKdZlTnXqdZrMNOhBf026PllVoEp0J/wzS/8X6sARMmvPSI5r+qWKBD9zm26iuQVjVOJ4scHD17NqHCySgzhOHzAFhVqB8nLcgX+jh+piwGqXLn6q+9VPNz8pdJRnTmU4mx/k3mUNZv6j3totB8+RBEQ0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=aFAPcynC; arc=fail smtp.client-ip=40.107.243.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="aFAPcynC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9oTcG7zJXCcehADHI2eqWIRNen0hNb5zx3fTP0BeDuM2JcbqGFtoF/m5orbqXEvpYMZuQHWzJIi3D85SI51B+AaRIbrcZ829znVakMabZXk9qMeCF3Udfbm7zMC22NPC7GxBVdtbEbJfZ03ThamXgnGiCa01KFJW99jngmq2D2j5yZL2+Rxgz5akNQLwIsCmCxfuMZTglPhQ15MWdo4FHgZPqiLyZ2mf/B/TnDYyKxDtBOrl3QFe89/pHb3lByH7JbzbVN3cPaTfwnAbjgCb/Gd50mwCVrZ7mHui4vu4kOsB0Vbo/dZI4DmTp1o1fOQkbYeyspwvv3lEXVG9urpqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CC0+hEGpnovTRjFQWdyN+1MUH1HsOnyJcd/zaZAUyM8=; b=Lh6rm5AuDe0d+YapDsEnYSfdSEzHDfK/+pw2K6hLFgd/InG98mZamK9E9uq6cW4Z5WHsZwZJy6dp1i17AlnZt4gK4e9qrTSmPWmwglxpvDnD9NdiCbWWGOHW/ktRZI0ou9m27OFNRDDbsYGW9EC8x9Vg+vlyqS3OVdG07bBBA8iIWUkjcPTTVeCUxHQLeW1DJ+Veez6t1HSTW0yLZdJ5WE19GevrL6TD5ZJrlf9vbMy/3By02pyQPtQsqzv4p18YvEUoPMspU1ecz4MEo7WsJ81/FhUmHZRg0ASKC8qGpdGjPfpuzWH+1gL0zFX1wh4Rc3ghu7BNMfAiqHzryKPk+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CC0+hEGpnovTRjFQWdyN+1MUH1HsOnyJcd/zaZAUyM8=; b=aFAPcynCgW1xFTyV+NdUf7OMLH33vq1X4XTmZfQ+AF5QPbZIKk5oYYNjl0r0v1ksiYHECX8aZFBX4N2rbBMpaKWiPe1AWmycwvGJ4LDXucm5K7S8ECqxmAOOjBxMEdQwclLu9JJCizvDZvnm8njpDfrPGmpUYlJ4WTPKaZRPI2Q= Received: from SJ0PR03CA0152.namprd03.prod.outlook.com (2603:10b6:a03:338::7) by PH7PR12MB7356.namprd12.prod.outlook.com (2603:10b6:510:20f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.20; Fri, 21 Jun 2024 16:51:43 +0000 Received: from SJ5PEPF000001F5.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::cd) by SJ0PR03CA0152.outlook.office365.com (2603:10b6:a03:338::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.37 via Frontend Transport; Fri, 21 Jun 2024 16:51:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F5.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:43 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:39 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 8/9] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Date: Sat, 22 Jun 2024 00:51:03 +0800 Message-ID: <9725dfcbb8848d68ce5c8c099cd3c6805bebf20b.1718988436.git.perry.yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F5:EE_|PH7PR12MB7356:EE_ X-MS-Office365-Filtering-Correlation-Id: f9ff4a14-cbfe-42ae-809d-08dc92126e5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|82310400023|1800799021|36860700010|376011; X-Microsoft-Antispam-Message-Info: WSjWHyqDPGrAhMm0ejNPPXfTeMTiXn/Wbdcm112fNMKlt2+Ft9AUNszSbf0w8OcNqsgxV+iSxgEnEcRSCo3STvhzeo3rDsshyFYzd+KC1VcbOAix6tl2rJ8b9dOLdUeUn8pF4blOzSMQNbC1HnRBCEHPSwUhYRvFExYCifR8wkbrb9AKs/zNSKQPMnEAev+21BG9bMklPcw3ySyvIUWEYGqyO6H6zJZz04tgRNl+r0nGzeSw23YeuIlj3HXftJ2F7sfGa4b8e2WlzKKXGE7+N+I0NSdd4aiESmUuaj6CvHLNTkV5DFIsrgxpn9r66dV4PeVbOTFGo+XYQdrFNNAIE483oHhzKpVQ4JBqF/UnsKN4ZdszBCiXdV5rZEIKdDnuUFfo3LIF2Nt1fOu7c3y1E+2zKV9X/zKKKQo6bJA5VvKH2Jx3ABlCskFcSmu7UnY9fqxrHmSrBCLV32ErQrVI4m/YPQ9ilJjmCbod4oTJtBaCCSgRio1vEB5sqATTDQN4OQjmk4S9GwBx/eXOAdeZ2g8FOh68TR8IEdDuQ01afyT8nShX+XBw4ZCDniuBlxzVFpgi+waXP+35Die8WcytMQO4sT9KmnYbK3uI2+2Lq47Kz24n1DlbOdIR6c0o4tzuHanffbOyG/KJDRnTkz+y4ntvSEl4YWVVPrwfnPP1PFeYTHU8y5hh1bpQ90qGxBEixipoAzMKyzYni3LrH3ihRzzMogB6HfVW6fB4oIm6xTwIezeNW7/KJ6+YgSIWi+tg+5cGt2ZqZcMej+eqsjcJCE5+iBJMJhQffexgwEBg+gK7hxe5O+AyL7itBRQNUQD1URbUA/sHtarQUJ6gvdo+VEOpVymZv7M1jQvkYhjNjT7wBFgRl80ICogyFUTW7uOPbikK2xYvIiddvnHati9DFKF9hk9u+fJsl/ZJpxqopnwHKzovNV+5rQttA+QmOG91sGdwZ8p0ZuPMvB2rxknRdiUq2AINehc3LOLcvOg3d9x5jQ88GWRtYAa7nU8hggZKckY7IP+iY4XAVS/mpx6T00jm9VKjjaRKDbjOBZ1mThnpU0Tx39P4dHfacze8pQ2riM09MCdVGL5vn7cRhE3mqby0qnefRX3Our0ipDWSWkvOJUTuqwJMi2qWn0OhZavWDGtHT0FWZ0wscH9LKCB716bNfrk/fgljZft9zS/ZGsGXQ2yB7rkbOTo61dqAbdDT9yi1r/obzecqEk5qIamyRu3NF1/dXpEPJ/1zwXUMyHgXqNziPxauAzuaKfU2mTl8u0H9ULu8OJ8mRE8SFNzY+VgcosAocTHtho6yVa97MVgu8hG1VzG9kohpQmoXCBUuR80sOSATRKKj5w8srPjEGWbK7A04ubZNywsWFOvIr3MvKZk7PU0m5OxRA/MsSjSYNN79TJ1ySWp5BqIts711xQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(82310400023)(1800799021)(36860700010)(376011);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:43.7024 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9ff4a14-cbfe-42ae-809d-08dc92126e5f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7356 From: Perry Yuan Introduce AMD CPU frequency boosting control sysfs entry which used for switching boost on and boost off. If core performance boost is disabled while a core is in a boosted P-state, the core automatically transitions to the highest performance non-boosted P-state The highest perf and frequency will be limited by the setting value. Signed-off-by: Perry Yuan Reviewed-by: Mario Limonciello --- Documentation/admin-guide/pm/amd-pstate.rst | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index f5ee81419a93..dc1b10d7dd09 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -440,6 +440,23 @@ control its functionality at the system level. They are located in the This attribute is read-only to check the state of preferred core set by the kernel parameter. +``cpb_boost`` + Specifies whether core performance boost is requested to be enabled or disabled + If core performance boost is disabled while a core is in a boosted P-state, the + core automatically transitions to the highest performance non-boosted P-state. + AMD Core Performance Boost(CPB) is controlled by this attribute file which allows + user to change all cores frequency boosting state. It supports all amd-pstate modes. + + States of the driver "/sys/devices/system/cpu/amd_pstate/cpb_boost" + "disabled" Core Performance Boosting Disabled. + "enabled" Core Performance Boosting Enabled. + + To enable core performance boost: + # echo "enabled" > /sys/devices/system/cpu/amd_pstate/cpb_boost + + To disable core performance boost: + # echo "disabled" > /sys/devices/system/cpu/amd_pstate/cpb_boost + ``cpupower`` tool support for ``amd-pstate`` =============================================== From patchwork Fri Jun 21 16:51:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 13707861 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2058.outbound.protection.outlook.com [40.107.244.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F25FD168491; Fri, 21 Jun 2024 16:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988709; cv=fail; b=QzNr2li9/7B14a1F/FXqFViO7l7wGqGfxmyq/Q1lFXZdEQiXCk/7xVtXoGJbjh36iregqPnIh8j/KK9IqClAzr71h/w8lZM5JnCRFhjTospaEEuhYr3q3WgK0w0A2vHUCXKm2gtCNRvobnh6qVUYpIsCQLC/DZugZexLCMF/Do0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718988709; c=relaxed/simple; bh=pMBC6gxUeoOjPn4k+KS51ROO1oYl4S4hlfOolztnRO8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fsDw6k+WfUWNDx8F+OwkQ4n+5lzV10V7mwKYPgGH6dHDtusu2T1dhK8p9Nex8ZiOQ5SXgahpMtHd8bxpXIpR6dAhfdRaSaojn9/OYQ9gOsfrgF0lmrBbUVWLMcsvavQayrZPKYhirKdo6d7tm3MudH+nJAkq5zC52gRHk8faFWg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=S0uL4Pcv; arc=fail smtp.client-ip=40.107.244.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="S0uL4Pcv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dO1Zu7P6Pm1HEjMyeYKLkR1HD74ckZ38bA6XrEFYQTlAeqwAYJqYh9nHa2w8PuI2lL/suJ+f20qlZZkGLan+9lvm/nlf+dpMP9JMOQ/plLiVe9dc7PGXG5FjZ8D71SFC1FuiY2GV3DxnHXBU1npncFmTGU4uxzjO9ybiDaEtO+fMF16Rg0h3jjyOPZyIotQN1IZX0DVgaqJaZqA9cA5hGwhUU9FBjce1VhDY8RdvQKAEkGLQN0rNWfLi8jhf6Fx/dVes8f12LEvPrlYwy/L/3DtrR97Cf1s+C2+IxLm+BtzqiKjYixK5ah4P09XO/Fg1CsZ+0ewW2GIbeYbxe/MytA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ovj6wbQK5jpoaNgpuE5BxXhP7O8BSr/ouZVyWoC8UOE=; b=fBMg6Kf7tNcos/4y34ItJTV0d4Hldn7EKXG4vIAa8U+vT/NrQOejnSjxPjx26HOyFT8/CtPYUN9J03RtXVex1RifybRy66gXiycceE/FQQhDkgmCvnfNm+wG+vrD+0mdjpea/eoPSgwqGgkp9mGOotYI+S0VyGRc0kLSge4hr+MB9mCVLcl2G92QLBQ14CHcMd2abgwX0pvHZQVcLO1Beb0lIeRbk5cegm1lSlIC2y+PnBddbkGDacn9iC+Vatbb937bADfCuqc6MWm1ktr4bsTLY4RSRUCFxGmibe3MZRrmAOM4nBE1uySBfmpI/oNSVmeldXrbUgEnf2LPn+emlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ovj6wbQK5jpoaNgpuE5BxXhP7O8BSr/ouZVyWoC8UOE=; b=S0uL4Pcv+OAaGzj4Tv5U7IxA1rdS9DFovfbEjLhJaiRMmoRBDySXgX/uQ4sZMfCeO/l14gEIJVCsPes0mNbQZw7WZOX7lGxJhqnKharzy6Rcb9KfcIBRvrNLFD3trS1Hhy+q5kX5MkC/QkomPA6X1/Wl6pnVykw6TyhIKpIJstw= Received: from SJ0PR03CA0165.namprd03.prod.outlook.com (2603:10b6:a03:338::20) by PH8PR12MB6889.namprd12.prod.outlook.com (2603:10b6:510:1c9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.21; Fri, 21 Jun 2024 16:51:45 +0000 Received: from SJ5PEPF000001F5.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::4b) by SJ0PR03CA0165.outlook.office365.com (2603:10b6:a03:338::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.32 via Frontend Transport; Fri, 21 Jun 2024 16:51:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F5.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Fri, 21 Jun 2024 16:51:45 +0000 Received: from pyuan-Chachani-VN.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 11:51:42 -0500 From: Perry Yuan To: , , , CC: , , , , , Subject: [PATCH v13 9/9] Documentation: cpufreq: amd-pstate: update doc for Per CPU boost control method Date: Sat, 22 Jun 2024 00:51:04 +0800 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F5:EE_|PH8PR12MB6889:EE_ X-MS-Office365-Filtering-Correlation-Id: a4858824-2278-4999-af2d-08dc92126f71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|82310400023|376011|36860700010; X-Microsoft-Antispam-Message-Info: QlGbI/e+NAqndc3EGidBpxmRsoJX7zNVfRIuYxhVkPKIBehGIWjcX3gGU99m9s+sFAZLW6RknWFpr+Cq03G3Jc6nrTIyq9TkqLNPtzslYM1+Do1/54Nm0ryAukj9Icc1iPbF5UZNnqTUus/pY8UvBxKiU1jwRAGuF0t92hQ9DzYf3ODlVT4/N8NQkbAxMQRgigadAuDyp0WPZodzsq3Ma0uF1ZSSdzgSBEfNrjqpsADU6NBpPeAMRHzxgpQlvt0wn0LNRv2W0omXKPlw+aWA1KznXJcX+7bhytDW6N/e/uwzXfcipM+hZKlTR2nS1WO0/rp+MfZyotfDSq05qYsMDbldbvKi38EX2RT7RtGXkKJ+9aXRKPiGUUOcor0TnjbwYC5HBxvvKPsoGdul9yXtF3QV3SKEyKE4b+xcPwfWt4JR6JGtFdY1kQ8v7UGhv3ngg4QKpMguaKOP7UMUgwkpIU3XwGH42b2BXu+y+VZO+LmtIbSwcK36Iry+91ktl9TS/0J4KWTRzuWzRNrAfUePFwEkqzyYyeCXPWJO77IBGjcqC5AM3aywa+62F9I9VEXqqv2QFZ3o8oK7SFXiKd8azawQZ79l19n+Rcslrtb/qLbST+vGx27Q4LJJQ7gguSk3nHTGasBeO5L7pK+lUnXrJWH8pNNwH162HfrkFMUxVmBM6MTxAMQUD5gK8A1awjARH1TyBe0X2TaEbJXu9vcWZUwVxDDX1XjLdq4ynpWcmryoUJS0vpucbEx/w557XIb3daEva4yk9ITuK6L7EGdKOQJ27C4D6AX31pgULlRb4sLRMVWBwcoMj38qp93xYjEjovdd/Kbjddg11FB/zkemj03nvT2JlpWAcdU9AODP/SllJdaqGnUzpTRtrslFnp7kBzzAjm4JQSe5iCszU7oJVGbY76c18UYHWhZ0UNINrpON9OR873G81CgpUqRBTsVtt9TSjUMsLyeUbyILSuJ183BzVXVT6YGD+bR74w+ciNFnVAspv89toFcJT1N6Fxeg4Sx4othoa+MvMV1cw5kXA5l/8VK5E7OfNTw+YcuRQg0ZWD+3nhWLynWpljk6staVDbj2zEPIMOO8OQkZIRURT8P8waWUY3GM9d6kB/Hu+sgA7puEjIOfcGcoXw2xNSTLtmVJCzJrp5qh6iMNBem0BwShLPk1Z6mIVXkkyzfitPx4qt5XfaooomF2FIXOH7qi3dadElMcZUXFNS3oLuHhnOEM2QrwTyUCd2mYOwd1ImnIQKMHxU3Afnre5TWuUwWeq+wK3EhXxJJ3ktI9O4n8ECs2OES7lqsRE8V0CeKTtru3DzZLbJsSGovSPz3g74/1t1a1+49KD0K5v1UgoXserHkDLhKik4bDXujCSyM/+tcsls5sc+rzm1a+LbuBPUvr/auqBsGnPXOeNvi+LWN0ag== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(1800799021)(82310400023)(376011)(36860700010);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 16:51:45.4993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4858824-2278-4999-af2d-08dc92126f71 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6889 Updates the documentation in `amd-pstate.rst` to include information about the per CPU boost control feature. Users can now enable or disable the Core Performance Boost (CPB) feature on individual CPUs using the `boost` sysfs attribute. Signed-off-by: Perry Yuan Reviewed-by: Mario Limonciello --- Documentation/admin-guide/pm/amd-pstate.rst | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index dc1b10d7dd09..57995f54f0c8 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -281,6 +281,27 @@ integer values defined between 0 to 255 when EPP feature is enabled by platform firmware, if EPP feature is disabled, driver will ignore the written value This attribute is read-write. +``boost`` +The `boost` sysfs attribute provides control over the CPU core +performance boost, allowing users to manage the maximum frequency limitation +of the CPU. This attribute can be used to enable or disable the boost feature +on individual CPUs. + +When the boost feature is enabled, the CPU can dynamically increase its frequency +beyond the base frequency, providing enhanced performance for demanding workloads. +On the other hand, disabling the boost feature restricts the CPU to operate at the +base frequency, which may be desirable in certain scenarios to prioritize power +efficiency or manage temperature. + +To manipulate the `boost` attribute, users can write a value of `0` to disable the +boost or `1` to enable it, for the respective CPU using the sysfs path +`/sys/devices/system/cpu/cpuX/cpufreq/boost`, where `X` represents the CPU number. + +It is important to note that modifying the global variable +`/sys/devices/system/cpu/amd_pstate/cpb_boost` will override the individual CPU +settings. + + Other performance and frequency values can be read back from ``/sys/devices/system/cpu/cpuX/acpi_cppc/``, see :ref:`cppc_sysfs`.