From patchwork Mon Jun 24 05:58:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13708993 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2072.outbound.protection.outlook.com [40.107.236.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B26D2564; Mon, 24 Jun 2024 06:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.72 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208825; cv=fail; b=Ts2ByaLESiEmaEVVih9icXO64uQz5BvIi5X2sX+hN3gZsn6eNge9za4EomRU+jNHw/4l6ysl0kSkFrHXuTomHd0Irn4tqb6zTRlx69KfHydrvBK5TzF55yNrtpCZWDx3ORNx45vTKgX7LaClnuG2KvK9EXKwO/fZGwpedablq+c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208825; c=relaxed/simple; bh=trjQ08VS9nqaEk4bElC0BEHF4z+L0KraXrOCGGgynmY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=emx+R/eyqmiJqOv6icd3szsQhHpMCC+b3+u2BOK43iuziFS76VG87DfxvBj2drSzt4N8Yunj29T5TAFAUMCxb2rJ57mZtQoE2I+qvoIb0bRL3e3LAmpBakXFdf4ZSaTKCLexcT/BvTXhXQiOROK3VvjhzJ3vgjLsw6jqA86fZI8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=BcSBpC3r; arc=fail smtp.client-ip=40.107.236.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="BcSBpC3r" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpButckLIkYdmBXhLdGOPJPxU6wEg05fQnn3UmNMDMPzuElfq3rmnSgGjjiuZNS/6vPxDirDnxxWnj9KM4A3cChl8p/S3yyyQZkqidPbC4OSSItDm4vQcp2C0cfgkYYe/1mboW2G8rSzc6wBGb1TmLLgNbqhyVbH2EwnTcubizxb+j6mARq1zOfXiwuTRPcuMnFTap56WwKeqUGgo0uaHr4BKlPZ8mSwEMRq3u4AAEv2CFiNOfIU3zYMRzNvNujiLGG8gZ8VdWJ4u4z9FM+V/oXV1qImh6tJoAGMUq9fpo6lDy1k0WknFXXW7qWTdetJR3Xe94WFTrQl38SHdhjOaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nig0DHr8BLxwu+43onKPqrDar4BGIuSM21jlS50W734=; b=JtacrWEbMYimqUG+3jSBio+IWyVvyxVBePuXnnsR4hXGRe84/4EInIm7ODt2POVkNHa4VA4bSr6Hxwd22ccNvG0zaNbD9QrV8ueJG2/pV1nzEbe6CTfwYOoyJzZC6Y+O1yF2JbqlKL5SpQwODKX2mpJaE2IEkJ9LEtkRa/pn58JT+eTLD6gflehXXRpLye4sqKUktIcSgxqGUhbHd6uB8jB+ts3IbS0wTljP+YP4JEkz1IVTisOg5pe+z0pU8ZNbTEDHeN23X25mGGXojJMkdJ93sMBwSZIgrdlQpTAtTeW7YuGX7kPEf3wX7Bh639+3TT6pIZCsUAPbzQBX5qSDKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nig0DHr8BLxwu+43onKPqrDar4BGIuSM21jlS50W734=; b=BcSBpC3rijFstV41o5mM+yLfzZjnKEgnaCUNRUxl0BJeIpnhyvEw/j4jocIIsDX/ibmruNSuF4qTT+JxVezAODEAqnzO87sjOi4sooSOzqyghohPhywd/YZ6idXv0aJIjRp/EAa59X6uZB2Sn9o8JhxXGJ6WxfL3xHx2ESkNM9o= Received: from BL1PR13CA0384.namprd13.prod.outlook.com (2603:10b6:208:2c0::29) by CY5PR12MB6057.namprd12.prod.outlook.com (2603:10b6:930:2e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.25; Mon, 24 Jun 2024 06:00:20 +0000 Received: from BN2PEPF000055E1.namprd21.prod.outlook.com (2603:10b6:208:2c0:cafe::c4) by BL1PR13CA0384.outlook.office365.com (2603:10b6:208:2c0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.18 via Frontend Transport; Mon, 24 Jun 2024 06:00:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055E1.mail.protection.outlook.com (10.167.245.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:00:19 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:00:11 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 01/10] x86/topology: Introduce topology_logical_core_id() Date: Mon, 24 Jun 2024 05:58:58 +0000 Message-ID: <20240624055907.7720-2-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055E1:EE_|CY5PR12MB6057:EE_ X-MS-Office365-Filtering-Correlation-Id: dcbcc1c6-c167-43f0-bca6-08dc9412ed89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|7416011|376011|36860700010|1800799021|82310400023|921017; X-Microsoft-Antispam-Message-Info: HyZjlKT9HI3b+fT1Sg2lXAN6RQyS8j8LWyZ6GdPsl8V6kBSleT3sQCVzFjlgqAItNohOj8u+Vwz0/1Qdl83QyJj2PCSTDEwNjdKatp9dsDuNQ01jPn6oBqf1k1GJpBnKVu9VqAtovmIbVcsJUexFCVVdiRQFwoW8r3KqQvME1hyW3fycz+RjewY6utaJsoe2Sffcqm70mTKYQWNHgrWCFyywJmS49/z5NoQWiXpwqc1VPUAgq8f1JAEvxk4j28r5K7kJZw2OQhm5J1tGWoFiEjld52jV/2e3AFjRc04ucwDbiGtXcPyQZp5CcoO1sPr0Ic3bSfxBPO7BXMZGWp8+BymLmQUovzigwwKFzvQQyZi7vn9rlw28M+9GmT5c8dOApp0HzL7QIQxQCPA8GGoKaTQEWFo0IjuTtfcVIHYLwLlKHw5dOEzlisCCCGlUUkWT27PHUuOF/5SOr+ngzJ/f7l/xZ8TtCFPZvaJQvkyLIfK5QquxB3/6MZR3d9dbogwklPDgDi/vOWv4VPxpYT/XNOiNeMbSs4YxHSQJTlJ7YTcFRGKBvSYkCYmsCMEwRuHhq8GiwRbpXVtTaYIakeuoAO7u7e6kqrvQ2RumtbafIRFHZ0aQVqINX9fX+Rp9NMJIW/WJfOEImTRsAJBMZhPhW+z5odvaBScaCasFA7LwjowJpU+2yOuLH67Eq0Ta52UfZ3FyFpK6gdzdoC11e24PeAxiHAm1TzYOUNqGfgyBgKdZp41xfdSXOwiZPUJfpzVpMAlAVRqtnl3iYJRzmS5qUZNOIBMIjxY3+2MygG7v2yNyfwUKmO3IOIWTgoM4DJONb/A9j8ikqGshFxVThbhIkoz9G77Hl5WbSUlACSld91IPy01D31j3HfW1GNg6I2dL1NakHScl25XM1ZH/guRIh7fo5do2N6ZCnuJdaX8XY/vWhszcaHGwMv0SVvNiS5neuIt+uf0cHq2XEOjhv8Xo9wJCrVsoKbFP+IrQiOQMznM7NT3C9kilh1EnWPLz9nF/DcTx/9rhjDOU5gPe1FfH3RD2QRwRAWOs+FuFTxKuQ48sAiI62ZKJKg133mR3j6op+fHV0hcF4dpfksKkG2I/8eeA89mijs/8abj2GFwdN2kg1PI9TqiXk49+amEDSKT3nypDUQrsFMc1QgtNMI6J+mSuhxvKqUJKT27vORAH4haby5KfqPHCW2tDQvoxtIL3/jeOtKSeAakXDI6utKO3kNXT13W/relrKzxMwNML9KQQIKytqeH5QApOt0U1+JklNVIWAzPch1D5WmIVR1B5VljXoFeHFp6E3xYu1XcbUP4/alzT3ZCMLIh6R3lhGSU5raDvyZvedkM53v/uwahzuUZvyuMVrJRGr4iwEHtZz5aGDWa08MZC/AdbMx2wMCRzyJ7HAlwiolvfW0CkiNoQ3XGHEZYFQEazMggxguMOHWg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(7416011)(376011)(36860700010)(1800799021)(82310400023)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:00:19.4691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dcbcc1c6-c167-43f0-bca6-08dc9412ed89 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055E1.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6057 From: K Prateek Nayak On x86, topology_core_id() returns a unique core ID within the PKG domain. Looking at match_smt() suggests that a core ID just needs to be unique within a LLC domain. For use cases such as the per-core RAPL PMU, there exists a need for a unique core ID across the entire system with multiple PKG domains. Introduce topology_logical_core_id() to derive a unique core ID across the system. Signed-off-by: K Prateek Nayak Signed-off-by: Dhananjay Ugwekar Reviewed-by: Zhang Rui --- Documentation/arch/x86/topology.rst | 4 ++++ arch/x86/include/asm/processor.h | 1 + arch/x86/include/asm/topology.h | 1 + arch/x86/kernel/cpu/debugfs.c | 1 + arch/x86/kernel/cpu/topology_common.c | 1 + 5 files changed, 8 insertions(+) diff --git a/Documentation/arch/x86/topology.rst b/Documentation/arch/x86/topology.rst index 7352ab89a55a..c12837e61bda 100644 --- a/Documentation/arch/x86/topology.rst +++ b/Documentation/arch/x86/topology.rst @@ -135,6 +135,10 @@ Thread-related topology information in the kernel: The ID of the core to which a thread belongs. It is also printed in /proc/cpuinfo "core_id." + - topology_logical_core_id(); + + The logical core ID to which a thread belongs. + System topology examples diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index 4fd3364dbc73..e1eeb42edeaf 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -98,6 +98,7 @@ struct cpuinfo_topology { // Logical ID mappings u32 logical_pkg_id; u32 logical_die_id; + u32 logical_core_id; // AMD Node ID and Nodes per Package info u32 amd_node_id; diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h index abe3a8f22cbd..2a6dbf965d92 100644 --- a/arch/x86/include/asm/topology.h +++ b/arch/x86/include/asm/topology.h @@ -137,6 +137,7 @@ extern const struct cpumask *cpu_clustergroup_mask(int cpu); #define topology_logical_package_id(cpu) (cpu_data(cpu).topo.logical_pkg_id) #define topology_physical_package_id(cpu) (cpu_data(cpu).topo.pkg_id) #define topology_logical_die_id(cpu) (cpu_data(cpu).topo.logical_die_id) +#define topology_logical_core_id(cpu) (cpu_data(cpu).topo.logical_core_id) #define topology_die_id(cpu) (cpu_data(cpu).topo.die_id) #define topology_core_id(cpu) (cpu_data(cpu).topo.core_id) #define topology_ppin(cpu) (cpu_data(cpu).ppin) diff --git a/arch/x86/kernel/cpu/debugfs.c b/arch/x86/kernel/cpu/debugfs.c index 3baf3e435834..b1eb6d7828db 100644 --- a/arch/x86/kernel/cpu/debugfs.c +++ b/arch/x86/kernel/cpu/debugfs.c @@ -24,6 +24,7 @@ static int cpu_debug_show(struct seq_file *m, void *p) seq_printf(m, "core_id: %u\n", c->topo.core_id); seq_printf(m, "logical_pkg_id: %u\n", c->topo.logical_pkg_id); seq_printf(m, "logical_die_id: %u\n", c->topo.logical_die_id); + seq_printf(m, "logical_core_id: %u\n", c->topo.logical_core_id); seq_printf(m, "llc_id: %u\n", c->topo.llc_id); seq_printf(m, "l2c_id: %u\n", c->topo.l2c_id); seq_printf(m, "amd_node_id: %u\n", c->topo.amd_node_id); diff --git a/arch/x86/kernel/cpu/topology_common.c b/arch/x86/kernel/cpu/topology_common.c index 9a6069e7133c..23722aa21e2f 100644 --- a/arch/x86/kernel/cpu/topology_common.c +++ b/arch/x86/kernel/cpu/topology_common.c @@ -151,6 +151,7 @@ static void topo_set_ids(struct topo_scan *tscan, bool early) if (!early) { c->topo.logical_pkg_id = topology_get_logical_id(apicid, TOPO_PKG_DOMAIN); c->topo.logical_die_id = topology_get_logical_id(apicid, TOPO_DIE_DOMAIN); + c->topo.logical_core_id = topology_get_logical_id(apicid, TOPO_CORE_DOMAIN); } /* Package relative core ID */ From patchwork Mon Jun 24 05:58:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13708994 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2082.outbound.protection.outlook.com [40.107.223.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 841F01B28D; Mon, 24 Jun 2024 06:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208862; cv=fail; b=hNJ6zrm/Ygko228cvgZPsbM5aMNo81O3C2n4awrBHxHIAdRRXcuQZ2doFdrDjQCIDQ1YFLImNwlIHXLF+x/cvVySXcUZ+q8fvx5nLNjDiXPDT/GAtQViAJfF8gQ3ECNyg4GpUH52fI4JWs/9k4OAHu2XG4hGpJskT88kOSch7o4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208862; c=relaxed/simple; bh=8ayQTd/qimBdn61F5QCpbR4M/6gGUQSWoz9lIWUkteY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lNk0zkxRCe4LgrEsEF18AMAqVEyqZsCQjTggPYOqHM1dN6WTxQ2Lj5eYOW5JXS9kqE985eR4qaOnKkBiRIvWHVDwWdH1Jv+mAiNyrLZHZDUWjjGLS0h2xcUr6NPWsz1mXHxFphblK2Ht3W1cL4wrvyhRjRQvSpnpz5jXUC4ymYk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ZsglOjwx; arc=fail smtp.client-ip=40.107.223.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ZsglOjwx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ajU2Vim2x2ThuclCG9VzT+qPaJjAZMf2ewl+I52RoQK+lkG82tvFqNoqR+ZOTEbpLeCz5XVQayyGiv9/PJogwuRylMrGEW81GgTBBMK9Fvyptg3uvqQxaVSc4glMBvuPKMp+F8wv9GXTWOtxn4NA91roMW/HoKYxrMWYdm0BI93XZZBVfTMN6f4IxS7ZZMPXSKEc/JpD+axRARVlNz9rNaylsURFFSAny6UzW/dRiT30uLn430PkB2YVhYLQujJLDfK7KriTj0tcwDhS9VXCEowKxM6+9Zl9aZVRkTx0jZ44m6fH5jMt4QUSMoO7S91MP3IYnj0yHY6uUIyIbg4W8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z1A1PMXRxwmFPpA2Kipxu5AUpAjeD2dSCqTpe8xo/ZU=; b=ccEcr8/cg+Y4sqwBeGO9RJNItf95MSW4OmD9KJwRFpQ8u6QdSN6SVnDHSsz5vdE6LeT+M0OCxivbMT8M30FNOb3k6hyMcSUHAAeYcZu7sr7hD+D92tg+uxpvyMn6MB7C1xjTARNBEQDokVqquTR9Cf/h91ldPA1A3SQS2NEGag7wgZMyWzzSVADmt+8ZuH49mhRJlo0xlLqDIL8QxCg4buo6HwVT4jOiz5c5VPrbHOK04RChNgHupnPvjjwIrNv3mUr9qUBcaQD4WjLNVmYz7mD5an8Ssw9hIpcNipzDDbJRsRFxYp6uS1eZksTLzK/Dgqfq+b2mj+FafmjrgXiLPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z1A1PMXRxwmFPpA2Kipxu5AUpAjeD2dSCqTpe8xo/ZU=; b=ZsglOjwxw0v+moRWRv9Zf6QbYbpWLpsiVqxzlotTqza5pk/G1UZgfIsjjYeuhYpMMxPmsOX6VkRjno/CFmCg6hmLoOwjQQcAp5gE8rtdwNXLKjexwBcYqMXznYKXgX3OymO1z1eazxQiMRSVa2OpOAAO+v3D2WmVSSzk1Gl2j/o= Received: from BL0PR0102CA0045.prod.exchangelabs.com (2603:10b6:208:25::22) by DM4PR12MB6183.namprd12.prod.outlook.com (2603:10b6:8:a7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.26; Mon, 24 Jun 2024 06:00:58 +0000 Received: from BN2PEPF000055DC.namprd21.prod.outlook.com (2603:10b6:208:25:cafe::23) by BL0PR0102CA0045.outlook.office365.com (2603:10b6:208:25::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:00:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DC.mail.protection.outlook.com (10.167.245.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:00:57 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:00:50 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 02/10] perf/x86/rapl: Fix the energy-pkg event for AMD CPUs Date: Mon, 24 Jun 2024 05:58:59 +0000 Message-ID: <20240624055907.7720-3-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DC:EE_|DM4PR12MB6183:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d0aaa06-6bb6-494d-50f9-08dc9413044a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|82310400023|36860700010|7416011|921017; X-Microsoft-Antispam-Message-Info: FyYSYCqwQC0SPgmER4WsgO88JVW8aXCytDRZftMOMjiQ9P/y/IjWruipFYk3HnOuouii0WIR3hy4ovlappRoaayEO1lVA4Jg6kdihKaPZVXkki1/MclW/qmleT2iJrgKLxt8FfrtMhr5SBUi0lzCV0chuAr3AG/xHMo+Lmpy+MJ4L3nVY0pHyhJBNqdyWJlf2jqYs87rGZB8KLluxFgLhF54mLggo0sMzk8dg3YQHU74u1lUpZNJFgvzo66XKeXaiPx6oZoE1VdyASJuIzidlMhMnrDCU0oiyMq9BlSfyeusqyHQUZmhIMAtg+iPznDEkEY1esWeXBlX1dtRFAEOmCOAEZ6yM0qHXLb5kLmUESYRey8HnhQdRCtShXLYc8njm0ZvlXwYGy35C9nMCPMxY/qkF1gSrSen+mNqghBSb0IvTpge93ipnHfPoiymEGjFyUIohSLYo5ajuKnF+ot1wLktKOrF/4dHUznfN5bsmyf8Bsn2vzTJhepwUIj78xjjOovJHwYKWNEQYffhfmAh3pDMfpqXEo1y1dmZyLNYljpnUkLiHdwvnxMbbR9EwlGMuoGEamC+QaCsQgQ8UTpjc/NqQhCt2mj3p6U0p93DDd3fCpcRwgP20dWTYXQu4Jb/i2lfM4x16EIDh8J6ShXWxkt0+MW4hhsoiaGgM4RCT0znwuz6/WXqaBZSj4OhgwJ1y86ahUfFtMnuOeDSMf0jIWMKOuLBNSrRQNIF+oQCbD+qRH4wiFtrV/BnTUAB+6D3V9004JDtlE8D+5Rlmns9VEvPhyPHKF2GPgJfEwcUqCtbPm/XHq6aL46Nd3YNm1mUVcLFhfVaCOjkJVgDI+IFgJG0zk7HzDYXV+eaxJmkDLRENAC1YIAWbp4uJRT2rE66M8jO+agYOODsWN8YJAFdsrBkxv9ZaqFaH7LBMM6bAZXb3JFRWDYCUDdx7fxIRlJ4k/nOzDIGcDK2jNWE2sE1Do5ko4szpg6OdeEeRbMBeymgnea3wmu7o1o3d5T8x6Rs8mxKc40OzG37U2I2SERIzqR9ipHrMKFlX6ijyJUcnKCROYkr59fXsO0dIPGMt794oxXq5vXLOOuegfTjH5sxYegefSF1QDc7Pjhaso50GYQQTOrcxRYFlw/I7E9QzDQPEAZrhw/Qf6oQq9BmaoubZ7W2V0OrJ0K4CRL5e2lQoMqYYOcDdXlx7fokf4GB0na80nBwRl/6JAA0gpKdPxqw0ODVhiVEjXmiCZ1PVVBOKnZGEjBr9fdNCMGg0sWuO//GlYH8dWmCBCEXQemALmqhZFZjImPCgDSzW2QBJdY9uSp4Q/BzmEC9pGydCLxnDH9bO3dUO60lrd+uL8R/hHiNB5b2JlKrlCnSv0ESFsySExjKU6MZfp3JtQSvL7ZF416s7FDcU9bxoY1zYYI4TOVGjosuH0XQVhTr2wDyOcGWg6w= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(376011)(1800799021)(82310400023)(36860700010)(7416011)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:00:57.6255 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d0aaa06-6bb6-494d-50f9-08dc9413044a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DC.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6183 After commit ("x86/cpu/topology: Add support for the AMD 0x80000026 leaf"), on AMD processors that support extended CPUID leaf 0x80000026, the topology_die_cpumask() and topology_logical_die_id() macros, no longer return the package cpumask and package id, instead they return the CCD (Core Complex Die) mask and id respectively. This leads to the energy-pkg event scope to be modified to CCD instead of package. Replacing these macros with their package counterparts fixes the energy-pkg event for AMD CPUs. However due to the difference between the scope of energy-pkg event for Intel and AMD CPUs, we have to replace these macros conditionally only for AMD CPUs. On a 12 CCD 1 Package AMD Zen4 Genoa machine: Before: $ cat /sys/devices/power/cpumask 0,8,16,24,32,40,48,56,64,72,80,88. The expected cpumask here is supposed to be just "0", as it is a package scope event, only one CPU will be collecting the event for all the CPUs in the package. After: $ cat /sys/devices/power/cpumask 0 Signed-off-by: Dhananjay Ugwekar Fixes: 63edbaa48a57 ("x86/cpu/topology: Add support for the AMD 0x80000026 leaf") --- arch/x86/events/rapl.c | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index b985ca79cf97..73be25e1f4b4 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -103,6 +103,10 @@ static struct perf_pmu_events_attr event_attr_##v = { \ .event_str = str, \ }; +#define rapl_pmu_is_pkg_scope() \ + (boot_cpu_data.x86_vendor == X86_VENDOR_AMD || \ + boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) + struct rapl_pmu { raw_spinlock_t lock; int n_active; @@ -140,9 +144,21 @@ static unsigned int rapl_cntr_mask; static u64 rapl_timer_ms; static struct perf_msr *rapl_msrs; +static inline unsigned int get_rapl_pmu_idx(int cpu) +{ + return rapl_pmu_is_pkg_scope() ? topology_logical_package_id(cpu) : + topology_logical_die_id(cpu); +} + +static inline const struct cpumask *get_rapl_pmu_cpumask(int cpu) +{ + return rapl_pmu_is_pkg_scope() ? topology_core_cpumask(cpu) : + topology_die_cpumask(cpu); +} + static inline struct rapl_pmu *cpu_to_rapl_pmu(unsigned int cpu) { - unsigned int rapl_pmu_idx = topology_logical_die_id(cpu); + unsigned int rapl_pmu_idx = get_rapl_pmu_idx(cpu); /* * The unsigned check also catches the '-1' return value for non @@ -543,6 +559,7 @@ static struct perf_msr amd_rapl_msrs[] = { static int rapl_cpu_offline(unsigned int cpu) { + const struct cpumask *rapl_pmu_cpumask = get_rapl_pmu_cpumask(cpu); struct rapl_pmu *pmu = cpu_to_rapl_pmu(cpu); int target; @@ -552,7 +569,7 @@ static int rapl_cpu_offline(unsigned int cpu) pmu->cpu = -1; /* Find a new cpu to collect rapl events */ - target = cpumask_any_but(topology_die_cpumask(cpu), cpu); + target = cpumask_any_but(rapl_pmu_cpumask, cpu); /* Migrate rapl events to the new target */ if (target < nr_cpu_ids) { @@ -565,6 +582,8 @@ static int rapl_cpu_offline(unsigned int cpu) static int rapl_cpu_online(unsigned int cpu) { + unsigned int rapl_pmu_idx = get_rapl_pmu_idx(cpu); + const struct cpumask *rapl_pmu_cpumask = get_rapl_pmu_cpumask(cpu); struct rapl_pmu *pmu = cpu_to_rapl_pmu(cpu); int target; @@ -579,14 +598,14 @@ static int rapl_cpu_online(unsigned int cpu) pmu->timer_interval = ms_to_ktime(rapl_timer_ms); rapl_hrtimer_init(pmu); - rapl_pmus->pmus[topology_logical_die_id(cpu)] = pmu; + rapl_pmus->pmus[rapl_pmu_idx] = pmu; } /* * Check if there is an online cpu in the package which collects rapl * events already. */ - target = cpumask_any_and(&rapl_cpu_mask, topology_die_cpumask(cpu)); + target = cpumask_any_and(&rapl_cpu_mask, rapl_pmu_cpumask); if (target < nr_cpu_ids) return 0; @@ -677,6 +696,9 @@ static int __init init_rapl_pmus(void) { int nr_rapl_pmu = topology_max_packages() * topology_max_dies_per_package(); + if (rapl_pmu_is_pkg_scope()) + nr_rapl_pmu = topology_max_packages(); + rapl_pmus = kzalloc(struct_size(rapl_pmus, pmus, nr_rapl_pmu), GFP_KERNEL); if (!rapl_pmus) return -ENOMEM; From patchwork Mon Jun 24 05:59:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13708995 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB342564; Mon, 24 Jun 2024 06:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208883; cv=fail; b=MRDiZVBYHZ0K6jI7EvxcZJtdXG+P+Pr8cg8liu6uOKajektBU488ozs/lFHUzXgVVCkMWaF6GOqIyVmQBULn5ZIsWfPFk7mAnRKUv8Lidf9vfCiRdk6pB/iEwpbBSVJet3ygpgXZvsrdiwrT00fYE/bKL3tqDdgDmTtvzr1hlyY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208883; c=relaxed/simple; bh=bdHqtKQgt7guqR41b+qTLiClw9pcS6FtJ1Uis4RlDfw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Aq4MHLnO/pd+jxD66NAJ41mvxicLLATAvWgNdGsxTjerj23urJ3aFLSxdw+hi+r9CHFWr2Xznv4HfHVJ3W+e7LugHHJsMqEhgvwWMMT5sGnKty4/rDRTDzibhlRIiDQbnLwHDbCnEK+1q0i2TkzWH8HQ59ChMMJlO9UivfNa/sI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=SV5h/ffx; arc=fail smtp.client-ip=40.107.220.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="SV5h/ffx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N6rj1EOU2plF/Yjx/iGdWsnsbDq5UOtSyaOr9SOlc2gfnmCfDXVN6b9ZnHpuYBWGrf6YGNp5Nu58kIWPnDsTJoFf4+XdXS2JJ6kKp7RweS5Bblh8nBo0/GlXKjoIHvOCpUS2FsZs7bspsRp+rQAEybdYBMgn4EeGQTgcNlsQzpZTokKJznEwYOOB1KWsl940qeQDYKnCNcsk7DuMdzgc1VbbEWT2xWJ7lPIEMoaiLTW5f3l5gMd53HAdlbSIzr5h3ZWBObmuVrgnKB41j3Vhj7Nv9WNb+uH1J7N7pC48hB2QR+q6bYiWfBAk8/tjcZara4CTBpkof76gmvnKyT+5jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8NbjBZFGLCOQPKlMZfmrhLpqA0S8CIGooxpyooHDAQo=; b=XnOMQCxf+Mp6u16chhh1NApl+43C9alP458YEwAVbwaYD5X3xZTwdpd8RS7lSzxsZrZ9qaXIyYsDfapbgu11+OlSY9QRwPj3kmWAcCTmAzrL9v0U0SZWARxEr1w6sgre7o1PDhyxXFLD5seZZSA6/ybag14Lxkvt4ao7VYAGgAQqS2CPQ0+cfdoUmjydzt5Wh6FgtYAJJcIXM7rtIk7FZD5SH1Mr/1loOZ1T8mMqUDGve4YG/haqzG5ByDOIfooCdSACjZeWF4xw7EQnvoDTztcAVcjrB9bXC7pEK8Vkxx9Co2cdY3+C/DO6VBr0DY8sGe+lSfdAq11stukn0f+9QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8NbjBZFGLCOQPKlMZfmrhLpqA0S8CIGooxpyooHDAQo=; b=SV5h/ffx1iK4Ll+/aVqudI3Ma8Kw0pVcgSEQribCUFD6Yi/41jyrOeO8J+nBJuiWj3/TVUWhKzMDYE2bm7CoxAkP5BjZcHnXQ/IQYes3kPrXH64Qym4RGHRrqM3xddb0us5TZuYSr+YRtVViO7pQpawChqcF/7tlQFa4698yvj4= Received: from CH2PR15CA0030.namprd15.prod.outlook.com (2603:10b6:610:51::40) by MN0PR12MB6200.namprd12.prod.outlook.com (2603:10b6:208:3c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.26; Mon, 24 Jun 2024 06:01:18 +0000 Received: from CH3PEPF0000000B.namprd04.prod.outlook.com (2603:10b6:610:51:cafe::19) by CH2PR15CA0030.outlook.office365.com (2603:10b6:610:51::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:01:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF0000000B.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Mon, 24 Jun 2024 06:01:18 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:01:10 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 03/10] perf/x86/rapl: Rename rapl_pmu variables Date: Mon, 24 Jun 2024 05:59:00 +0000 Message-ID: <20240624055907.7720-4-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000B:EE_|MN0PR12MB6200:EE_ X-MS-Office365-Filtering-Correlation-Id: b37d6e51-21d0-4470-dab6-08dc9413107e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|36860700010|376011|7416011|82310400023|1800799021|921017; X-Microsoft-Antispam-Message-Info: 2QWBAiabiSrmGg+H09U76gb+F6TqNKwJqUccVc10bONbaPETT4lUz+r0Qt+vIBSmThdjAZ3QmSBPPu+secxdzHekMKXOT24ibEA3ms6tmfJsEP1dz7//yBeMBF8rO9IwRlJqxxFBc5xYl956qn9pnrq/DSEyxwlSr1FfGgghHoHPqf5d3Ho1H734jYP0x7DQsVaydFFirUBAPNnmAQIiLIN0xkE2A/a4+R2McRTEjbgAuQXJ7+UvzuXOElQmNmCQQz0qKV02Kwdd5NVR0wYlNiYfWwN98qs4gElzDxUTqTsiCzraNwlNriTm9en/2wwt+tfGSlVwbz2/8uy44BweKHMGdLBePXdRGfwWPypl7gbLrnOaQJFFCg8Xtc4fCkzb1E0CxKXmHOsUJWfL1VaggUFTQCi7p9/IuuDV3C4SKWHVET0ON/5mQiz0+d1c/zGaUk7vOxq9QlDAiorqITZYmbghV+wok4aN0XwNgAF4RuRL9gIQpKjgUvZ2uFC33viDil6SCTlBlpgb2EOuvRqLG9LMybEt8WheccRFEXPk53pQZKH9OTwsr+REaotviY4OM+WXtZwR6EuxjA4kYxCnvjr6ljqnr8L2jChUbBFTWn0HiUrNJ55x6DAWTK+quGCcSKlE9iWwzajagrUsx1FBcOmwtuZEe/jfYWNCETQJv1QUAvY4g2i7P6G7MZYXveVD2ewEEwHcoj7lXa1LBf9eJHO3l4tlDpAkULe+j73jP8MpLvpUEgHXoLxcX8BPEsmWnAjYYs+VnyreKXbof58QR8KlHTxtqxibav/O/Nh6E/rZnAUyZcy4nt0JVZACE19Si+BgcBf1jegTlkVllANFo5hNsHOssh4tB1eTsk50mAASP+gFIx/UQzFgLhleOJXLPZ/gQubBDnkwVL3gE6GX2scz+xIS9FVUzZYhQoPiRGWnlqmvaycbHAWMq/7j5NGw7NIAd4mrmuTjF5eaPE2xWutxs/rCr23W+8tth86o9F/kbFVq4VB4Ks7YV1oMjDWx2xAcDkfYMLQh8CBi5Rl7WoICKdPEw6Gsg5jGe2Gr4X90z/JiXli4PlUw3zmI3jr43lxxE6ws+/mAcLRJcLF42RffOlhb2Si2PY0ifuTtLjmXRXFDLLzT9NcFZUcGhWKYCYIUhwVE12GqZk+SURXqqr3mUvo+qAi/XowsohU0GMqXm9brCGFXcewSmh88evTpuCvAZRrPFETaIKNNTCJ8SEIbSPr6rkLHMq/cFOu1xk3nwZQjiRTttqGDL+cgV1YNYzWdysHKCM8JTWpVEoGhHNXKhTxTVhiO3vqd1vaFj46GHfs5gkAadgFVmJlFBWdLllGX/We4efIxS+EXkKXAEe257oc7ZpzUwGAECugBLhuPafQNIWJnKDtEqTAi0P5unl0Hn0dUy4xDM2EQK38lDe33flzwunJuI4cMWmUpTAw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(36860700010)(376011)(7416011)(82310400023)(1800799021)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:01:18.1024 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b37d6e51-21d0-4470-dab6-08dc9413107e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6200 Rename struct rapl_pmu variables from "pmu" to "rapl_pmu", to avoid any confusion between the variables of two different structs pmu and rapl_pmu. As rapl_pmu also contains a pointer to struct pmu, which leads to situations in code like pmu->pmu, which is needlessly confusing. Above scenario is replaced with much more readable rapl_pmu->pmu with this change. Also rename "pmus" member in rapl_pmus struct, for same reason. No functional change. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 104 ++++++++++++++++++++--------------------- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index 73be25e1f4b4..b4e2073a178e 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -120,7 +120,7 @@ struct rapl_pmu { struct rapl_pmus { struct pmu pmu; unsigned int nr_rapl_pmu; - struct rapl_pmu *pmus[] __counted_by(nr_rapl_pmu); + struct rapl_pmu *rapl_pmu[] __counted_by(nr_rapl_pmu); }; enum rapl_unit_quirk { @@ -164,7 +164,7 @@ static inline struct rapl_pmu *cpu_to_rapl_pmu(unsigned int cpu) * The unsigned check also catches the '-1' return value for non * existent mappings in the topology map. */ - return rapl_pmu_idx < rapl_pmus->nr_rapl_pmu ? rapl_pmus->pmus[rapl_pmu_idx] : NULL; + return rapl_pmu_idx < rapl_pmus->nr_rapl_pmu ? rapl_pmus->rapl_pmu[rapl_pmu_idx] : NULL; } static inline u64 rapl_read_counter(struct perf_event *event) @@ -228,34 +228,34 @@ static void rapl_start_hrtimer(struct rapl_pmu *pmu) static enum hrtimer_restart rapl_hrtimer_handle(struct hrtimer *hrtimer) { - struct rapl_pmu *pmu = container_of(hrtimer, struct rapl_pmu, hrtimer); + struct rapl_pmu *rapl_pmu = container_of(hrtimer, struct rapl_pmu, hrtimer); struct perf_event *event; unsigned long flags; - if (!pmu->n_active) + if (!rapl_pmu->n_active) return HRTIMER_NORESTART; - raw_spin_lock_irqsave(&pmu->lock, flags); + raw_spin_lock_irqsave(&rapl_pmu->lock, flags); - list_for_each_entry(event, &pmu->active_list, active_entry) + list_for_each_entry(event, &rapl_pmu->active_list, active_entry) rapl_event_update(event); - raw_spin_unlock_irqrestore(&pmu->lock, flags); + raw_spin_unlock_irqrestore(&rapl_pmu->lock, flags); - hrtimer_forward_now(hrtimer, pmu->timer_interval); + hrtimer_forward_now(hrtimer, rapl_pmu->timer_interval); return HRTIMER_RESTART; } -static void rapl_hrtimer_init(struct rapl_pmu *pmu) +static void rapl_hrtimer_init(struct rapl_pmu *rapl_pmu) { - struct hrtimer *hr = &pmu->hrtimer; + struct hrtimer *hr = &rapl_pmu->hrtimer; hrtimer_init(hr, CLOCK_MONOTONIC, HRTIMER_MODE_REL); hr->function = rapl_hrtimer_handle; } -static void __rapl_pmu_event_start(struct rapl_pmu *pmu, +static void __rapl_pmu_event_start(struct rapl_pmu *rapl_pmu, struct perf_event *event) { if (WARN_ON_ONCE(!(event->hw.state & PERF_HES_STOPPED))) @@ -263,39 +263,39 @@ static void __rapl_pmu_event_start(struct rapl_pmu *pmu, event->hw.state = 0; - list_add_tail(&event->active_entry, &pmu->active_list); + list_add_tail(&event->active_entry, &rapl_pmu->active_list); local64_set(&event->hw.prev_count, rapl_read_counter(event)); - pmu->n_active++; - if (pmu->n_active == 1) - rapl_start_hrtimer(pmu); + rapl_pmu->n_active++; + if (rapl_pmu->n_active == 1) + rapl_start_hrtimer(rapl_pmu); } static void rapl_pmu_event_start(struct perf_event *event, int mode) { - struct rapl_pmu *pmu = event->pmu_private; + struct rapl_pmu *rapl_pmu = event->pmu_private; unsigned long flags; - raw_spin_lock_irqsave(&pmu->lock, flags); - __rapl_pmu_event_start(pmu, event); - raw_spin_unlock_irqrestore(&pmu->lock, flags); + raw_spin_lock_irqsave(&rapl_pmu->lock, flags); + __rapl_pmu_event_start(rapl_pmu, event); + raw_spin_unlock_irqrestore(&rapl_pmu->lock, flags); } static void rapl_pmu_event_stop(struct perf_event *event, int mode) { - struct rapl_pmu *pmu = event->pmu_private; + struct rapl_pmu *rapl_pmu = event->pmu_private; struct hw_perf_event *hwc = &event->hw; unsigned long flags; - raw_spin_lock_irqsave(&pmu->lock, flags); + raw_spin_lock_irqsave(&rapl_pmu->lock, flags); /* mark event as deactivated and stopped */ if (!(hwc->state & PERF_HES_STOPPED)) { - WARN_ON_ONCE(pmu->n_active <= 0); - pmu->n_active--; - if (pmu->n_active == 0) - hrtimer_cancel(&pmu->hrtimer); + WARN_ON_ONCE(rapl_pmu->n_active <= 0); + rapl_pmu->n_active--; + if (rapl_pmu->n_active == 0) + hrtimer_cancel(&rapl_pmu->hrtimer); list_del(&event->active_entry); @@ -313,23 +313,23 @@ static void rapl_pmu_event_stop(struct perf_event *event, int mode) hwc->state |= PERF_HES_UPTODATE; } - raw_spin_unlock_irqrestore(&pmu->lock, flags); + raw_spin_unlock_irqrestore(&rapl_pmu->lock, flags); } static int rapl_pmu_event_add(struct perf_event *event, int mode) { - struct rapl_pmu *pmu = event->pmu_private; + struct rapl_pmu *rapl_pmu = event->pmu_private; struct hw_perf_event *hwc = &event->hw; unsigned long flags; - raw_spin_lock_irqsave(&pmu->lock, flags); + raw_spin_lock_irqsave(&rapl_pmu->lock, flags); hwc->state = PERF_HES_UPTODATE | PERF_HES_STOPPED; if (mode & PERF_EF_START) - __rapl_pmu_event_start(pmu, event); + __rapl_pmu_event_start(rapl_pmu, event); - raw_spin_unlock_irqrestore(&pmu->lock, flags); + raw_spin_unlock_irqrestore(&rapl_pmu->lock, flags); return 0; } @@ -343,7 +343,7 @@ static int rapl_pmu_event_init(struct perf_event *event) { u64 cfg = event->attr.config & RAPL_EVENT_MASK; int bit, ret = 0; - struct rapl_pmu *pmu; + struct rapl_pmu *rapl_pmu; /* only look at RAPL events */ if (event->attr.type != rapl_pmus->pmu.type) @@ -373,11 +373,11 @@ static int rapl_pmu_event_init(struct perf_event *event) return -EINVAL; /* must be done before validate_group */ - pmu = cpu_to_rapl_pmu(event->cpu); - if (!pmu) + rapl_pmu = cpu_to_rapl_pmu(event->cpu); + if (!rapl_pmu) return -EINVAL; - event->cpu = pmu->cpu; - event->pmu_private = pmu; + event->cpu = rapl_pmu->cpu; + event->pmu_private = rapl_pmu; event->hw.event_base = rapl_msrs[bit].msr; event->hw.config = cfg; event->hw.idx = bit; @@ -560,22 +560,22 @@ static struct perf_msr amd_rapl_msrs[] = { static int rapl_cpu_offline(unsigned int cpu) { const struct cpumask *rapl_pmu_cpumask = get_rapl_pmu_cpumask(cpu); - struct rapl_pmu *pmu = cpu_to_rapl_pmu(cpu); + struct rapl_pmu *rapl_pmu = cpu_to_rapl_pmu(cpu); int target; /* Check if exiting cpu is used for collecting rapl events */ if (!cpumask_test_and_clear_cpu(cpu, &rapl_cpu_mask)) return 0; - pmu->cpu = -1; + rapl_pmu->cpu = -1; /* Find a new cpu to collect rapl events */ target = cpumask_any_but(rapl_pmu_cpumask, cpu); /* Migrate rapl events to the new target */ if (target < nr_cpu_ids) { cpumask_set_cpu(target, &rapl_cpu_mask); - pmu->cpu = target; - perf_pmu_migrate_context(pmu->pmu, cpu, target); + rapl_pmu->cpu = target; + perf_pmu_migrate_context(rapl_pmu->pmu, cpu, target); } return 0; } @@ -584,21 +584,21 @@ static int rapl_cpu_online(unsigned int cpu) { unsigned int rapl_pmu_idx = get_rapl_pmu_idx(cpu); const struct cpumask *rapl_pmu_cpumask = get_rapl_pmu_cpumask(cpu); - struct rapl_pmu *pmu = cpu_to_rapl_pmu(cpu); + struct rapl_pmu *rapl_pmu = cpu_to_rapl_pmu(cpu); int target; - if (!pmu) { - pmu = kzalloc_node(sizeof(*pmu), GFP_KERNEL, cpu_to_node(cpu)); - if (!pmu) + if (!rapl_pmu) { + rapl_pmu = kzalloc_node(sizeof(*rapl_pmu), GFP_KERNEL, cpu_to_node(cpu)); + if (!rapl_pmu) return -ENOMEM; - raw_spin_lock_init(&pmu->lock); - INIT_LIST_HEAD(&pmu->active_list); - pmu->pmu = &rapl_pmus->pmu; - pmu->timer_interval = ms_to_ktime(rapl_timer_ms); - rapl_hrtimer_init(pmu); + raw_spin_lock_init(&rapl_pmu->lock); + INIT_LIST_HEAD(&rapl_pmu->active_list); + rapl_pmu->pmu = &rapl_pmus->pmu; + rapl_pmu->timer_interval = ms_to_ktime(rapl_timer_ms); + rapl_hrtimer_init(rapl_pmu); - rapl_pmus->pmus[rapl_pmu_idx] = pmu; + rapl_pmus->rapl_pmu[rapl_pmu_idx] = rapl_pmu; } /* @@ -610,7 +610,7 @@ static int rapl_cpu_online(unsigned int cpu) return 0; cpumask_set_cpu(cpu, &rapl_cpu_mask); - pmu->cpu = cpu; + rapl_pmu->cpu = cpu; return 0; } @@ -679,7 +679,7 @@ static void cleanup_rapl_pmus(void) int i; for (i = 0; i < rapl_pmus->nr_rapl_pmu; i++) - kfree(rapl_pmus->pmus[i]); + kfree(rapl_pmus->rapl_pmu[i]); kfree(rapl_pmus); } @@ -699,7 +699,7 @@ static int __init init_rapl_pmus(void) if (rapl_pmu_is_pkg_scope()) nr_rapl_pmu = topology_max_packages(); - rapl_pmus = kzalloc(struct_size(rapl_pmus, pmus, nr_rapl_pmu), GFP_KERNEL); + rapl_pmus = kzalloc(struct_size(rapl_pmus, rapl_pmu, nr_rapl_pmu), GFP_KERNEL); if (!rapl_pmus) return -ENOMEM; From patchwork Mon Jun 24 05:59:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13709005 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2041.outbound.protection.outlook.com [40.107.95.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24FBB1CD25; Mon, 24 Jun 2024 06:01:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.95.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208901; cv=fail; b=Q5pWf/zk9/qg4rpH3xFbPjv2dNHOYYyKn4f8lrajhzgiSo9cUObXcELIvyuKK/xoZd34a8IpO4ErRDWwCzJtRcp4GrIrppl/s1GHXwjqPPOX5sF/45E/Ggc58LwznuyplbcHnavHPPMYJ2Io/EtchWYQwvWrFYIqx7IbPcAOKyw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208901; c=relaxed/simple; bh=Gk0eDrWkM4+6BcmWgg9Zn5wMFoL1/BiV+SJ4lOA/JBg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N4qPMF3feDUiIew9TUHJx4f42UpToReRGyndHA6YPxIwZX2LZRxY7uhoCLWWvVYuYpiSk3aT9+B56ldzDS3Whlzes6xYOZHQAm5BplNvrG+3Q9lWoy5b92yjhKuyzzbDmLN8n6OOIhcrTV9a1rb8CKDFGjFOodRB6cnbAVmcqYo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eJnXCciI; arc=fail smtp.client-ip=40.107.95.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eJnXCciI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9mPUcSSbKrF35GEWXWxjiM+8gCQBSb2MpDNTV+LrbPyTo2ks0cDNVVhNaMqPp1gA1gUR8z22v4ScfA9dqrmw2c0m4nTwEOfqKDHhdSTATHh06BleXWcwwLfRIZpMOSC4xc7MKoeSmib0FbxxGEhABtqwgavGy++GCbRWLcy7HqHztU6T5gT6wWO9HeiKAzemNzm2Vae5DgEwja/N2o0sl4nGguM0sBcG4D5a/htnYm8Oc7st9DAxF2r5bIN9Gbmzs5bB+Y+LRimdCG4wBOwugtODqiA901b3t+YbufDjZiLS53BKJ0qR+htek1FpYFHDN28V5XTtiKMZl40KxKRaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3XxBOYQHTq6+VWT/1eEZw5vU3Ql+de6j2SbkY2U/TVY=; b=FqD26qMyvtfPg8B+3JE9k/nPd9MQvi4MF4hsNBBiSa3gsZ4MnsWiPMvsR5v/Za95kaZZYghNy85DF85Qc1JBA5Btq06t/QmZvvEZyzlnlCXPGYkq3Ar0UefobmkBbzXaSnDODUzmrMMH85Qg1YxY8r7rcXtOnXDsZEgK+goaQcjtin796RFfiTSZk2SXAEf2TzuPRUeqSKsAanL9WnybY70Jk2qSxi+HsEFkYTNDCz/MAbKQCXjArd+s2Z3oE1+UKGE86eSf7pw8Kpi6OmW27fD308W6WchzQ0apdbG16x5FK8EYJEerFC5s53KrZUJjiFzSX+nGLiw49Yh1k6hcdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XxBOYQHTq6+VWT/1eEZw5vU3Ql+de6j2SbkY2U/TVY=; b=eJnXCciIkWI1YghZkUZPVmrkplg+hsdiZnk9yYCiH9eHhwbjiWYHai1Vl2EpetqrYl8FtfptfQuv6Lio/4UA1jddrZPHJiEMHHjMyKuXJRRwrVb/ulQX1DoZlO59GEvYB3X2mHsAXhQmPPqtgEH6l3G2Vba4GzVw7dXoWtYA5QU= Received: from BN0PR04CA0164.namprd04.prod.outlook.com (2603:10b6:408:eb::19) by IA0PR12MB7723.namprd12.prod.outlook.com (2603:10b6:208:431::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.28; Mon, 24 Jun 2024 06:01:37 +0000 Received: from BN2PEPF000055DF.namprd21.prod.outlook.com (2603:10b6:408:eb:cafe::c8) by BN0PR04CA0164.outlook.office365.com (2603:10b6:408:eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:01:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DF.mail.protection.outlook.com (10.167.245.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:01:37 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:01:29 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 04/10] perf/x86/rapl: Make rapl_model struct global Date: Mon, 24 Jun 2024 05:59:01 +0000 Message-ID: <20240624055907.7720-5-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DF:EE_|IA0PR12MB7723:EE_ X-MS-Office365-Filtering-Correlation-Id: 44c6fc9b-4649-423a-95b4-08dc94131bde X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|7416011|376011|1800799021|36860700010|82310400023|921017; X-Microsoft-Antispam-Message-Info: FC2VbGH4dfcGUrpBV3EwxwrcMuAp+2db16jUrA7LSmhpd3JvEqSdcpXJ3su3idyWLqq3yMAkEBvxFRuom9GZlGL73yeNSQ3S1pVozTza4hHgXUPjggfqwFanMf6K7h7aLL8+poKhrYq/ceWCHJOJF24ZEqslFHT5lsHfQActhKGWdXnTdzJU09ABwyfyLwJVCwg02fGd2OMjm1odUoE527w1OYZi1ZT5cnVy2D9o8PXz2hBPt5WX6ZWPMsaFT2c/ZH87TPPPNyNPrZAqLqof1/fkpsR+x23gjZy3riSo49IzJupDgWSRS9wK1cul7O1W7wXtMZPJZx8L9Fg9WbtKCljpo1dm/fe17cZ6Svhaj04QYQ0cPXNez4RXXwFwd4yB4zKqz4gSA1gRBuXJWXNtwawlJywTRW3Pa2fBn/FF1GOmJyxm18hGVKJXfAUez5fmJFU+TVevhwNGnvFzOrnZGcepWNXR1SpnQ7iw8AKAf+A4Xg+y2XPsMAHfoh8srZpmju2otH858w/I0svKXHDD+MCWJPJU3r3CdMpXCydGpOlnwf8de4pP+li5TbUnoPjA1eaKJyiEv9yiQRy6G3GRc7CPvJwDWPVwS0dKYjNTWed/umdmrNAEG3AV3uoiGKnDoLjMNJn2XhltDjYxhKW0YETy85C4xCAgbVlCw+hjNTN29nfZGxA3XvNizSheGoyQUvyyWCiieXjERuTh8L9+jH5NSapeVHxDb1w3DrJLemHezzfvv8Oz1pprVaiaN+lOtv7PMJqur1Dvxyr5XxO+nFMYPo0ocdesBS0ICLEs2R+0BGq6hsFx4qWe7rJ46MUddnoKTzBcx2vh6C76u6igqQJqBtVGwgxbYfbxhjL4k+2a2UgX04QMFfXH7Ra0XtujHFJ9HySsj0Zyu1dxdxU158pf41MkPMuc/+UdVpyvrM6izs8Lovo4vBlQEYFL2j1x9uUf7TBKD42tFQIOeTrFiWD8SHN0b8pnanT+PFS6FLXuuaN7rFJ0QaFH51jEcqj62tlOGFuI5BCSVl8xnmYmmIbYt82WN592nImnLgJo/uKvZkyda/8vZvIxCf+6AfLDN3LNzJ2dL+9mTc4tG3/UAyZOzidSPV0HguzQaFq0Bnis68QddOzafumUjS9iIiEKa9NXxQIfdAVJ/MKnRhS7JyiFiHdUJ6PLLRKXNk3R5gXRNKHhk3+2ujk26acpla6w7bBkP05ITillZCvf7vfBbbwp629v/B7meeyqixgEf+VssnylXIS2V3R463KDr0GBYMCaB1bNSqhGNSezsKVKaaBeTW4XK3Cztz3P1hLaxhu7Tdc6BjDv1qZ6OSf0cpFDMsKOKWhz1GW3JK4h+qRC1U8ilMvhUQR6h+lID8nNzPOuiY5ScxdhHzA0rh42JS++MXoEbpIj24PMTQILZXldb0Oo54x7R/GflSkH3L/qFEA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(7416011)(376011)(1800799021)(36860700010)(82310400023)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:01:37.1848 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44c6fc9b-4649-423a-95b4-08dc94131bde X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DF.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7723 To support AMD's per_core RAPL counter, we will need to check per_core capability of the current rapl_model multiple times in rapl_cpu_online/offline, init_rapl_pmus functions, so cache the matched rapl model in a global variable, to avoid calling x86_match_cpu() multiple times. No functional change. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index b4e2073a178e..e5e878146542 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -143,6 +143,7 @@ static cpumask_t rapl_cpu_mask; static unsigned int rapl_cntr_mask; static u64 rapl_timer_ms; static struct perf_msr *rapl_msrs; +static struct rapl_model *rapl_model; static inline unsigned int get_rapl_pmu_idx(int cpu) { @@ -614,18 +615,18 @@ static int rapl_cpu_online(unsigned int cpu) return 0; } -static int rapl_check_hw_unit(struct rapl_model *rm) +static int rapl_check_hw_unit(void) { u64 msr_rapl_power_unit_bits; int i; /* protect rdmsrl() to handle virtualization */ - if (rdmsrl_safe(rm->msr_power_unit, &msr_rapl_power_unit_bits)) + if (rdmsrl_safe(rapl_model->msr_power_unit, &msr_rapl_power_unit_bits)) return -1; for (i = 0; i < NR_RAPL_DOMAINS; i++) rapl_hw_unit[i] = (msr_rapl_power_unit_bits >> 8) & 0x1FULL; - switch (rm->unit_quirk) { + switch (rapl_model->unit_quirk) { /* * DRAM domain on HSW server and KNL has fixed energy unit which can be * different than the unit from power unit MSR. See @@ -839,21 +840,20 @@ MODULE_DEVICE_TABLE(x86cpu, rapl_model_match); static int __init rapl_pmu_init(void) { const struct x86_cpu_id *id; - struct rapl_model *rm; int ret; id = x86_match_cpu(rapl_model_match); if (!id) return -ENODEV; - rm = (struct rapl_model *) id->driver_data; + rapl_model = (struct rapl_model *) id->driver_data; - rapl_msrs = rm->rapl_msrs; + rapl_msrs = rapl_model->rapl_msrs; rapl_cntr_mask = perf_msr_probe(rapl_msrs, PERF_RAPL_MAX, - false, (void *) &rm->events); + false, (void *) &rapl_model->events); - ret = rapl_check_hw_unit(rm); + ret = rapl_check_hw_unit(); if (ret) return ret; From patchwork Mon Jun 24 05:59:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13709006 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061.outbound.protection.outlook.com [40.107.243.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21D2A18044; Mon, 24 Jun 2024 06:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208921; cv=fail; b=SJU8CYkQhupgZb0tYOoV/EXBYpE7dI0lFBk7i/+75rGG6ZaZmv8kC7zafgIG9z6m1EARXJLODzAPo0Ec9hzRsn2Gzmx5kMB8wx67xVcuiMqGR4ft1CNPU5BU0uACUju/AcGov3K6k4Vnt8gyDT3nemqssSpGa2kTrnYof2gvzFM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208921; c=relaxed/simple; bh=FbVldJAzwBUz/OiIKlBv24FGlyQJ3s39q84DqVs7d1o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OlrBjP+0FJn+kI6FEZoOdJ5BL17rrajO4Lcm1U3a64s7HN7THSBveOKObq+i9+/YzxjDX4yjUXvB/s8KFr8z2rGqmw/NbWh8CrvZJIe7lg+pujukqT/i092aicKu4b0FbzkmN/r0uasEewpnARMCLoXbhQ9YW0pTRaBTA04unxo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Zp3HENd6; arc=fail smtp.client-ip=40.107.243.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Zp3HENd6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZiyru3BzUJYX3oCVBDZqZ1afOmqXPxrGAdEph1B36vLMVnrLl+nk+0KpcHJi0hfK7wDnPdPt21FvJ1N+hKsNFDYjXVWPMAd+nZ7A6+A316iYQuCsIA9hVC+g5Qs/FJefVwVNQxLx1i8AhtpqmSxrP9gFpDazejhp6AHEnIkPAU0MLxavo+MCR5ffOyjMfZToyIdt+RGo/lhFkO7l8X2+OFXLPxRCThFNhrgGEVlBS1wz3QRfPH3ons3iv+b+4h5328A3CUOgUP/orFs0LMFFx88Mtg1gFmSiXZ/5MlFfQ7efmBHKXnr3aVWpWAqayxi9plPVq1FuVkxaGACk+xJAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3WSqqtWS5pLK7gm63CqzM301h8Bv9ShBNsN1dNvF7Fg=; b=WcugYVsyclc3hXdjRjVYn1QII0sEs/hWnkzMzAi5XREkyPpeBgPSnrC8VP4+oAd3g0gZGQROziT1F3LcGOVH7WuO5hbYusJw1XtQnZPiiSUiYMGgys/aciD3EI6cMj+YjPFHIPdvaOoZVLZhAYBeYLOXqMyLatT1QI3xpGk5zFR+BnNLEyM2aFXrLKvAhhSfJJwxHU9Pg5nPOHnbkqZmuHsLI1dYNmJ6Nedb8d2DXN3FhWA/ZYGs37dfzG/2xPE0dSoqObhXqJm8bu8UCVtgTVVonW13QqGxEuORWIkHYPlI7AgKpfd0R/4MpDLHpd3WiodFPjzInWzK1q91Smqgeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WSqqtWS5pLK7gm63CqzM301h8Bv9ShBNsN1dNvF7Fg=; b=Zp3HENd6GwxzqXpmwtl/JXzkDIV9TnDUpGajhla6zJVVFVmbOnfF4cYpfMcQkFATOMXrHep2yeQ9qfIEt2EpU0EeW8MVXMN31uVmY6MXsrXTLXfavhUkNEw3sZtezOHswSsjicqZAxUaqc4Ek9UkoiPvdogem33iSIi5SRMW49I= Received: from BN9PR03CA0534.namprd03.prod.outlook.com (2603:10b6:408:131::29) by MN0PR12MB5763.namprd12.prod.outlook.com (2603:10b6:208:376::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.26; Mon, 24 Jun 2024 06:01:57 +0000 Received: from BN2PEPF000055DA.namprd21.prod.outlook.com (2603:10b6:408:131:cafe::96) by BN9PR03CA0534.outlook.office365.com (2603:10b6:408:131::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:01:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DA.mail.protection.outlook.com (10.167.245.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:01:56 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:01:49 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 05/10] perf/x86/rapl: Move cpumask variable to rapl_pmus struct Date: Mon, 24 Jun 2024 05:59:02 +0000 Message-ID: <20240624055907.7720-6-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DA:EE_|MN0PR12MB5763:EE_ X-MS-Office365-Filtering-Correlation-Id: fed71c6d-256d-4dd4-d5b7-08dc94132792 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|36860700010|376011|7416011|1800799021|82310400023|921017; X-Microsoft-Antispam-Message-Info: Xe9OQM1AQpoxmqln90bQLVzFQGu7H4k7P6Qs+L4MW3zDp1RwNQMQv+eZt55I72h1dHPuAzjC3aKpDRitcy+evd8PYR8p7cYRDfvzxsdI3z2XrdV5v6uRFkgnYsxrgVyQPTnKLwIBWDGPux5MePp664pxablrlHS/5lwbeqoa7c8ya4exA51DVuNucnGdLAPcoN4sCKk9QvTDdvTb6K7+920CHnNDxSb1pJ9fqE3TuTwuCkNKBDcNQYiK6prKLZLFgeymErtWtj6eh6SPO3In4uMKYzqiw8yoOIzSZ2x58svKMC63mHFBUYCfS2wou9nCz/PH0rId9iWT5XNkRkRkh8BvbCDUDep5OL6zO8xbsStm/TJgjXjx9ozOVF5jlmiXBnpRf7OI87DVhgEXguGKDbrgY79m90hm73lFsuTJyxLyBdD+1BdvDDAgmEISC4rTHNBTTahMjbJWiczI/N5BpuhkBSm0MC3FlFwt7RSIlJx+uLJAw2WHV7ytCmGkxtBAULkTaIwU3E4fGpGYADy/WIvegmvTh67/iJzlZNtq7S4/dS4TevZj6y7QR9v+gIeG7Oo+Wc4ha7VMFEdJCTLiTEwCbjMWDgjSN+rwDTx7RJHciAfNCYcqR94cYqXz8NDouRx6UPMSBzWXUWPpJHVGSuUdAmnxGQr94hMucS6AdqE8pXybK/tt97LzuMs5ZTRZQaLXG3YaUMBHTVxpt0/RolzhnYuOEVmYI91uCPbZUD2FrMPbCj17qbZVP5xAMkZmfJzOYmp/8BGnzq+CW1ULQkpxge4nEVHMSAbcSlBwtja2T5lDZrjOljO8Lslx08Cor/h+AoidxTO7iqYggNvqB4jEQkeuKy2/36rJfs2bDF7R8omDasfzQhKejB6k29Zi0ODtutEmXIrVwTOLLcfNa/Na1dDY1GyY7XHDI1evRSkjkKRTIacEQebHwBmc5fS/bGLTxS/Q3ffs0YhyBe7uDGVzqHYGne7EfvTufJXjnoyZIjYWtSmy1ptlifpQ+z+9aWjzOFJN95Uf3OS4mqp3leH9Ks4MWOG7xOOjmIxQej6GDmVAcBotw4IoC6yv7q/8gcB9/rfejhGdkEHFxu9rzVU+mEBZVpiW2lr+0CV++0vWDbSWcdD0V82ounPW08Ws2IlbfGg9Hvmqd92x7u/p6lhcZnlI0aEnZ3VbFpujXyyc+WgoC0aimSA0Vn5SVYFmysCcRwoGeE0CQxiiUYZ2YCAWFiu6rPLQZz7xmLHXk0/keNmY/IkUhvyG99Chv1IvJHUe1e8iQFhpAsm+YN4FOPu6ezlwmk7SccIdzs1Bf8ZLla3aLXW+U5SZWpxRNAaXUwWMkE/Wm2uUPOtsSfVeYrVvgVaYkxn++2hbQgf2yHYqxCjAZBW743hJHfodwfKzYrlL3cS4SbZnCSOD3Wb0R7xMeQQk7YlHXWLMk8TmLH0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(36860700010)(376011)(7416011)(1800799021)(82310400023)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:01:56.8366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fed71c6d-256d-4dd4-d5b7-08dc94132792 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DA.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5763 This patch is in preparation for addition of per-core energy counter support for AMD CPUs. Per-core energy counter PMU will need a separate cpumask. It seems like a better approach to add the cpumask inside the rapl_pmus struct, instead of creating another global cpumask variable for per-core PMU. This way, in future, if there is a need for a new PMU with a different scope (e.g. CCD), adding a new global cpumask variable won't be necessary. No functional change. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index e5e878146542..be139e9f9ee0 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -119,6 +119,7 @@ struct rapl_pmu { struct rapl_pmus { struct pmu pmu; + cpumask_t cpumask; unsigned int nr_rapl_pmu; struct rapl_pmu *rapl_pmu[] __counted_by(nr_rapl_pmu); }; @@ -139,7 +140,6 @@ struct rapl_model { /* 1/2^hw_unit Joule */ static int rapl_hw_unit[NR_RAPL_DOMAINS] __read_mostly; static struct rapl_pmus *rapl_pmus; -static cpumask_t rapl_cpu_mask; static unsigned int rapl_cntr_mask; static u64 rapl_timer_ms; static struct perf_msr *rapl_msrs; @@ -394,7 +394,7 @@ static void rapl_pmu_event_read(struct perf_event *event) static ssize_t rapl_get_attr_cpumask(struct device *dev, struct device_attribute *attr, char *buf) { - return cpumap_print_to_pagebuf(true, buf, &rapl_cpu_mask); + return cpumap_print_to_pagebuf(true, buf, &rapl_pmus->cpumask); } static DEVICE_ATTR(cpumask, S_IRUGO, rapl_get_attr_cpumask, NULL); @@ -565,7 +565,7 @@ static int rapl_cpu_offline(unsigned int cpu) int target; /* Check if exiting cpu is used for collecting rapl events */ - if (!cpumask_test_and_clear_cpu(cpu, &rapl_cpu_mask)) + if (!cpumask_test_and_clear_cpu(cpu, &rapl_pmus->cpumask)) return 0; rapl_pmu->cpu = -1; @@ -574,7 +574,7 @@ static int rapl_cpu_offline(unsigned int cpu) /* Migrate rapl events to the new target */ if (target < nr_cpu_ids) { - cpumask_set_cpu(target, &rapl_cpu_mask); + cpumask_set_cpu(target, &rapl_pmus->cpumask); rapl_pmu->cpu = target; perf_pmu_migrate_context(rapl_pmu->pmu, cpu, target); } @@ -606,11 +606,11 @@ static int rapl_cpu_online(unsigned int cpu) * Check if there is an online cpu in the package which collects rapl * events already. */ - target = cpumask_any_and(&rapl_cpu_mask, rapl_pmu_cpumask); + target = cpumask_any_and(&rapl_pmus->cpumask, rapl_pmu_cpumask); if (target < nr_cpu_ids) return 0; - cpumask_set_cpu(cpu, &rapl_cpu_mask); + cpumask_set_cpu(cpu, &rapl_pmus->cpumask); rapl_pmu->cpu = cpu; return 0; } From patchwork Mon Jun 24 05:59:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13709007 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2083.outbound.protection.outlook.com [40.107.223.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55A3F1C69A; Mon, 24 Jun 2024 06:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208942; cv=fail; b=KgANARGAhnBUoNQF5LC8xEiSBFi/+p6xY1d+xCwQEnqPbfPKqrpGjyI9GBLv5hu5kBakqVCH5Hov/IIYfmkf+l8yy2DZfKlZiS0CTMaEZDZ8Ft8r+rO5rDHHtUp8Q6U9IPROVi30rQQIyU/6f+YHCKRFbBUkwmjUB9Q1k/BqfmE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208942; c=relaxed/simple; bh=qS/Wq/wwRZfU17xl+lbRzk7z5HbMg+NLEVu+HvsuOXE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QxcWZrQDjMJYBROvyIWuOQ7ObyWSuDeXgfyi+Z4XrjMrWC2rMiQ6BGdDYbjS2pTBU9ciqWbLFeA4fS0lhvi3a5t2h6WNQ5uLdV9v1AHga1GAhKbJWnrb+dx3OL9HJ1W4Fro0tZzCRrrNnZZGeco7YoC0LcTT5RTYvn7Jf6ugD70= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=jfJUcjba; arc=fail smtp.client-ip=40.107.223.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="jfJUcjba" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GA0mxkBYHuFFQkSOGll/JOwwqEhQ8OcqVUoMutQiGtlB1hQpItJlHS7ZuSEIlOoTFUjJSA5w2uLeezI5nsnUTJ9/dE53AN42TCR2A/iASblZW7DgHbDTnkFW76eztwjlmegf5r5WAoAAMGEdpVoupYfBCg85zyDiEd4V1MuBSjaHM7ZgFB/okfTrSFc3gl2xFxYXjCiIPCMm7sG4VBTjRV7Q/ZMCmNJPC/wQSNS7T8Qwgl5aYyrBi97QHHG/w1eKy8H7Kt9hq/Vf6hk61sntr7Bk9Ziqj0If7S2o+eRoQaQwsXHikMlRZFHdjWlqKCcsoygV3sIJVFtmZTGNvG/tBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6GYhfZK2/e8rYuOISt+j+ov/9zcEqHtJ6OJpZIqp0w=; b=ebJehWXpsBj1cCjf7dNEm4c4f+t+WxWpUVI722oPFD9eMD14ZXATK0JmD8xLNVSccvhRFMNg2quypsGPU8LUG13N05dIB2YiQ4C2n+2a6JPSlTWvIMq9kaVZLLGZ3VGJ8tQKMc4s2np9eO0Sy64CsXbuLOxrnLBEDqKQ6LC5kOcAj52MOYOmf9vrUxPQqHxkNeh2MrytwK3wDj7efSwmKEFB4WMRsBMffSsbqb+LUREhDxxmWdx7MV+0maWT+jR1d/ATF6z7mrmMFfvh5z1RQNc0Lrrm2UBndc4vpzlnOZCP+Fci2RLHpueivy1qs8ITL/ubfGcPTr+H2Q1XXd1zyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6GYhfZK2/e8rYuOISt+j+ov/9zcEqHtJ6OJpZIqp0w=; b=jfJUcjbaicIAbirD2qa5rRDGggyslqjmX9LUS63cfE9H9dfgm2lNRspc6GxBIKDnvOnlRSnzB4opXfDi6yTkKq+rfHO5t3x9/UgD/NthEc4jYFvhU9XWrX8D58SzeCom/2I2gNmtFjI9wEfFAzvF/aUmpoNn7wzSulY3UoI6UIQ= Received: from BN1PR10CA0012.namprd10.prod.outlook.com (2603:10b6:408:e0::17) by PH8PR12MB6747.namprd12.prod.outlook.com (2603:10b6:510:1c3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.28; Mon, 24 Jun 2024 06:02:17 +0000 Received: from BN2PEPF000055DE.namprd21.prod.outlook.com (2603:10b6:408:e0:cafe::db) by BN1PR10CA0012.outlook.office365.com (2603:10b6:408:e0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:02:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DE.mail.protection.outlook.com (10.167.245.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:02:16 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:02:09 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 06/10] perf/x86/rapl: Add wrapper for online/offline functions Date: Mon, 24 Jun 2024 05:59:03 +0000 Message-ID: <20240624055907.7720-7-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DE:EE_|PH8PR12MB6747:EE_ X-MS-Office365-Filtering-Correlation-Id: 93ad435a-0f0c-4628-8878-08dc94133390 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|82310400023|1800799021|36860700010|376011|7416011|921017; X-Microsoft-Antispam-Message-Info: smrnxDQ6Bj2oTvhLcOqQXoeqYK5pUGJ9UW+zMetbhifFO2mCGyQ8Hw6WjNAl63gX5LpKtwNCl+bAaLzhIuSvsU0wPkrla9670KWblLOrxLSZWsMa/wpvuJxqtd3XcANzhA2qkYKBSkEZan8+OBvym6/VWaZ0yvloH10YHIsbJ07Ii5m4Y5oZpsLGtzu6KeCo5likbWEiejJeanAf/LUYoSZyz009GJxjBr73IJjanUuIDIuOiAA1PdealnVEGF2saF8MFxmXohz2oFtLvVsxeDOV+PXg5+v4nhRXUv6SiVqbwTBjTi2FeUqwrzdmLlFedzBYZ6LijfpWg+RxbhIRXbS8Ev/8Or3VgcLh1rc3ZxbOzjwCAdXmXayBP9zhKI9ED3kw6klfIPWjmzgRWa3GStOdIGWUXVMNTjDfpVpPBwBpWbtHdtRbdg6ZkQ4MxpC0IJDqRvozL6wVQroGyHTOvnFB6kiSKfbDhH3RXcXurxjlignmHlUpyH41T8Phwwxji7ETWFGMd4wzpud3/7ne7/LOuShb03My184LcU3adW8Vs2HdrAZHc3To6ouBGCZg1cjqARgPd1jgtBuVioyTonQxXURuyl/wasue+P4cS5gxWj1LeWfmU5OTaYeNjOj0++lCwIrIRsuH4QkVjc0FJutGtZqpzAATmfRHVWFiNNBcP2FK97KRDPujOH65VKGk/C3sN0Ey2nFa2xh+ZWgA3KWyHH81XY5V2QZzyHwmkQpYlKtm+JPc3jumoYT5sDdLjL1E3Lma8q1Bucaxg2wV7CMGw6PQrBGGFXCkTO1dhh5lqqW5cD2nEQ4+O2iYThpB4rtFFDfUKTiX2EHbvz+faQ9Q2KdxrPSCbIBRoPgCdhOvHjsZS0vpQCf/6PIFxCnOM/T/yicoJkfDFeesAjGqSJxzO19XTjHINpIJV5aPs+ykDWa+YOguslUbZFJ4FuBQph/hjrfSiSfyXGvUDNLxMKlq+ua8rG0Alvs6PQrR+K2iiP+dAThUeILAzNK6jxeUTEMjoTLWiY0SV+E/hpn1lHZ3EVC2M/yHhPNeBizgdETbCFs4gYD8dS6aGA0qCwf7BiqjVHvQey6zJHZedMrVd3s3S/+kUz0IB3M7FoQYIU0Xhc3SsN209HjMJihbe3QK3PVoW7Zly2iYTzViMfjhBwMbmctBJhI2ce54vyhL8y6OPjgZS8SH7bCfyeKe1Gna36JgHaha+5wJZRW0OZWw7ETKjwz5HTx9BgJz3bzYmk7pLCvacj7+OeV2PPsjTEb+4hZTUcfyiM8vEltEfl+0Wm9fjH/2sXs9xOfXEhIZsBxOl0suYJNwRWWkveLkFfZ0NnR0UUXd1PRd1FRVE4z9ezLh0r/7Cfn2UVVDUcwdaCM2B8240lFwxQ6ePLpPMdcoBQFxREWUJacHUMcV30mvowG5tEJEZ4e0ubsnh8VTbGc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(82310400023)(1800799021)(36860700010)(376011)(7416011)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:02:16.9229 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93ad435a-0f0c-4628-8878-08dc94133390 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DE.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6747 This is in preparation for the addition of per-core RAPL counter support for AMD CPUs. The CPU online and offline functions will need to handle the setting up and migration of the new per-core PMU as well. The wrapper functions added below will make it easier to pass the corresponding args for both the PMUs. No functional change. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index be139e9f9ee0..70c7b35fb4d2 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -558,10 +558,10 @@ static struct perf_msr amd_rapl_msrs[] = { [PERF_RAPL_PSYS] = { 0, &rapl_events_psys_group, NULL, false, 0 }, }; -static int rapl_cpu_offline(unsigned int cpu) +static int __rapl_cpu_offline(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu_idx, + const struct cpumask *event_cpumask, unsigned int cpu) { - const struct cpumask *rapl_pmu_cpumask = get_rapl_pmu_cpumask(cpu); - struct rapl_pmu *rapl_pmu = cpu_to_rapl_pmu(cpu); + struct rapl_pmu *rapl_pmu = rapl_pmus->rapl_pmu[rapl_pmu_idx]; int target; /* Check if exiting cpu is used for collecting rapl events */ @@ -570,7 +570,7 @@ static int rapl_cpu_offline(unsigned int cpu) rapl_pmu->cpu = -1; /* Find a new cpu to collect rapl events */ - target = cpumask_any_but(rapl_pmu_cpumask, cpu); + target = cpumask_any_but(event_cpumask, cpu); /* Migrate rapl events to the new target */ if (target < nr_cpu_ids) { @@ -581,11 +581,16 @@ static int rapl_cpu_offline(unsigned int cpu) return 0; } -static int rapl_cpu_online(unsigned int cpu) +static int rapl_cpu_offline(unsigned int cpu) { - unsigned int rapl_pmu_idx = get_rapl_pmu_idx(cpu); - const struct cpumask *rapl_pmu_cpumask = get_rapl_pmu_cpumask(cpu); - struct rapl_pmu *rapl_pmu = cpu_to_rapl_pmu(cpu); + return __rapl_cpu_offline(rapl_pmus, get_rapl_pmu_idx(cpu), + get_rapl_pmu_cpumask(cpu), cpu); +} + +static int __rapl_cpu_online(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu_idx, + const struct cpumask *event_cpumask, unsigned int cpu) +{ + struct rapl_pmu *rapl_pmu = rapl_pmus->rapl_pmu[rapl_pmu_idx]; int target; if (!rapl_pmu) { @@ -606,7 +611,7 @@ static int rapl_cpu_online(unsigned int cpu) * Check if there is an online cpu in the package which collects rapl * events already. */ - target = cpumask_any_and(&rapl_pmus->cpumask, rapl_pmu_cpumask); + target = cpumask_any_and(&rapl_pmus->cpumask, event_cpumask); if (target < nr_cpu_ids) return 0; @@ -615,6 +620,13 @@ static int rapl_cpu_online(unsigned int cpu) return 0; } +static int rapl_cpu_online(unsigned int cpu) +{ + return __rapl_cpu_online(rapl_pmus, get_rapl_pmu_idx(cpu), + get_rapl_pmu_cpumask(cpu), cpu); +} + + static int rapl_check_hw_unit(void) { u64 msr_rapl_power_unit_bits; From patchwork Mon Jun 24 05:59:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13709008 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2040.outbound.protection.outlook.com [40.107.92.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D58021C695; Mon, 24 Jun 2024 06:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208961; cv=fail; b=fwEJALt2BI1SKYfyXbp7wCMUSrSR0nY1LW2+XBLuR905Jezkii+8aj11M1/FfEX0H16YVtDJmujnbjUJRqVYgLSzpqk/C/hxNmlh1/EYhxkEo1S+gD6bO3YUlAC8IMXVOgZZzw/TnP3zWPQ3CxJcCaGnjfIMKJm+Jx9U6heYu44= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208961; c=relaxed/simple; bh=SevruLCexV627iM6Dl8XSaoopRtrEYLT3wp2+/RPnLw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nUqgCyhinf4EaZE1MXKGKVgs3DQgjjEmu4hTmvTVSGcZBjdaZONDmKe8cIEYhihg4hlBa/W32xWfipdqrhsbQwoyV1bQ1pP8y2m/vPUN5snzHdRmXipvThoHD+FsRQYWjqAxvW/S+/gvZzf1PyUsH2SiXbJ7/fCsTzmM3WzzYpA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kghfV2KW; arc=fail smtp.client-ip=40.107.92.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kghfV2KW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jbFtKq67JlJ3act7Bxowf0UK1jIN8Hbk3dqX2Jw3MK/Bg1ljO8W6qQaTLLmoeX0jU1/IU/oWT20ArGAncHAyzvLq3Jlkg435pb2xU4BusRnaBEVoNCuioTCy8bxHrVEAJ2A3tNhjlxtSZn76vej7krBMRdhzTMoWFK15LS/NGp9bKt4UT0yCvLDAGnCyYCgYDVheJtAFTZutU9dTjzDi5XTsVG+ZHUOqFz1qQdR2rzNnQu55+6jwPJjfX2t3deJWAI/UCsYO90O2mLssBrdDeYT0A8u+uTAWSA5Te4jep/fNu1A4cZRR3x14RgqAO8HV4SEKnBlvNdy3e6PPeqmrPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ecZ6mfsQyMQekhKSwNggBHbozRpNVr37hIhIwLMyQH0=; b=oAiJwpAQ6VVSAhd7qnR/hKjyMNjorlr1qgB5xG9dOWEC25WNLq8vCjhvt2H7OF+wI6Zn48DliNUaHhvv+NWNvm6mj4/D4HPRLaiWxpF6txmjU1RMyNa9rQ3jYKPtM5/pAAmmXyNAgIAvRYdDJDzlEwYpcQR6WdAHYJ2PfaXxjdg217IEo8/o1SegH2aZymtrFf1mXjC6edHR2SJe4PO2dDxJf61cLMR8VR+TH1U6na1/8Tq6mNH8cRZ0rB/q/XBVfqVqor1Ytb4OyHC/UVhIKtssSQwYyFngDv5YJNLNbDUIueXLt6mXNzUvp73wUcs34s7/vTHWeSImwU7ZaWmgSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ecZ6mfsQyMQekhKSwNggBHbozRpNVr37hIhIwLMyQH0=; b=kghfV2KWFFFuNtLGGghqyptJhsavmq1sDbWQdQIQkUvWb1ihRrt98/51u2ubNawHKtHBBxtub4CBNJynifNUGaUn5ln/jZw0NPBIJ58VWjm36Z9pIHT3ecUs+w9ePd4oOtYb7c5N1HRar7mGXWVR3uPKAJgStUXgb1jmOdNIe4E= Received: from BN1PR10CA0003.namprd10.prod.outlook.com (2603:10b6:408:e0::8) by SN7PR12MB7980.namprd12.prod.outlook.com (2603:10b6:806:341::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.28; Mon, 24 Jun 2024 06:02:37 +0000 Received: from BN2PEPF000055DE.namprd21.prod.outlook.com (2603:10b6:408:e0:cafe::a8) by BN1PR10CA0003.outlook.office365.com (2603:10b6:408:e0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:02:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DE.mail.protection.outlook.com (10.167.245.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:02:36 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:02:29 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 07/10] perf/x86/rapl: Add an argument to the cleanup and init functions Date: Mon, 24 Jun 2024 05:59:04 +0000 Message-ID: <20240624055907.7720-8-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DE:EE_|SN7PR12MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: ee6d0b4a-9821-40bf-a6de-08dc94133f6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|7416011|376011|36860700010|82310400023|1800799021|921017; X-Microsoft-Antispam-Message-Info: Cbp9syXuAZfYy3b4Dh6APwqy+yBljUBmXeR7Had6xccqhOpUNpcgS5TpFb7Z7aiUIPe8rCb5/rkUFdrtEYHc89hRx6q02hNE68AEHJKpfivRhdDwho69TMGSbnk1gy8U3Elm4lTImHXxZ3/fFjApRc78fdlEF616NrGFeXdKn8vWvpz4e+Jfczoe/aeZIr08ly6ueCw0iKAsR3GWFIH46GJ8VCUCHSPODmH3wm8kfANzzodAAhsTN+zKMonYh2w5dHjBC5CPPEctMTLz6rYFdcZrUXYBXRFgMX4wlKDtvtRoddq98tfzItpUOQJQ/f7M0o6tCMLmH92fkjxJTffn/DPVUX4ArN790ggzG9VFrZTMB6At1W3g8pMYJ0X4qD4DsavQp3T8mCdr8OhXrpsHpqB5kGVCO8dxN4hhIIB4hhnDTsNhStoifrIIrJvE98PU4+MBlNHndDZ5cOZ6cm1LpaVB3qIiUnqrqS0Frfs9Lsaa0rqIikFVTdZK4wz+SgtvN3ytTrmiihglXo02VnkkzEPkQaLjocKCbhrWuOXVzwgtqf1dTOx0iaNmmKDpx8G9TILoRtYWw+T3u9yTdsXj98xz0QlXyfL7H2ELkflXDIxviEQyHnsTBbZiHePd1bnoglDCpC5j+X/RklAggRTg+ASsVX+NT5TdcsfSKWjJRoF1Eb5zruooQelFh3K60N9pGVqL6dNTjziV2o1SVCqDgUVt/n4rwbuzcR9oMQhTJzEUxMQ+5b06E+P+FQz+Mnb6h8EuAfS13pzs/sdWofaIZ7zqSmDgMXV3ScaJQL/oPfn1qgl7fCC3S2gvonWDBXCFxuclaLcXv/ZPNejuYqqEYe0L0Y/i9LkmYdJfSlB1GLBgnrDlUwudenPnSO9ukw+c3ns3ucGU+HsRcBf+rsz12vGj0UahbqkAglr7mxNzWC1o+N/cmxlGMf1OnP23ZINYuGmoxCVy4EUho1ZTWJUV1oBa5vCHesFqj6psf7CmmNeb9+G4JHLo2t1TiY08idIVAbFx/JJ91HE+myugxZCNas2sJgD5a17jBvJGQ5oaEmH9E+sILa+QGIwN1ca8AKi5aXkHqgyxQ2KYR7LHKhJ9zriyn+65FoBCOGC3za/vffEJHGP9FEAOoZz9zLfOp+dzn7dYQNwNAJtj5uZtrRViID4iu/CpN0OUFYmggyeCDn8gpd74Zt6xfU8KHHAgKfxsh/djpeFjmeCXSqIsgeMUmh65B17EZrMbpVw3B8ZYtENcdyBD0PcBYIIk0Iu9lXzJE4rnd7SO4nQygYCrw2Uu8STfCpWz2u3P0bk5SSTgSvwO6UU3m3fvt4ri+8HDSte+ZVk8LrVoFNDUYVMYewom/rguwllqhpOxUE1JH0f76pUuKi+Sc6PdluLZ5hpSvRaIxpUKZPLTE11TuuxU7o2S2bF0wgsPA5x/pdh2v93Wfgg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(7416011)(376011)(36860700010)(82310400023)(1800799021)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:02:36.8295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee6d0b4a-9821-40bf-a6de-08dc94133f6b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DE.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7980 Prep for per-core RAPL PMU addition. No functional change. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index 70c7b35fb4d2..f815c60ec551 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -687,7 +687,7 @@ static void __init rapl_advertise(void) } } -static void cleanup_rapl_pmus(void) +static void cleanup_rapl_pmus(struct rapl_pmus *rapl_pmus) { int i; @@ -705,8 +705,10 @@ static const struct attribute_group *rapl_attr_update[] = { NULL, }; -static int __init init_rapl_pmus(void) +static int __init init_rapl_pmus(struct rapl_pmus **rapl_pmus_ptr) { + struct rapl_pmus *rapl_pmus; + int nr_rapl_pmu = topology_max_packages() * topology_max_dies_per_package(); if (rapl_pmu_is_pkg_scope()) @@ -728,6 +730,9 @@ static int __init init_rapl_pmus(void) rapl_pmus->pmu.read = rapl_pmu_event_read; rapl_pmus->pmu.module = THIS_MODULE; rapl_pmus->pmu.capabilities = PERF_PMU_CAP_NO_EXCLUDE; + + *rapl_pmus_ptr = rapl_pmus; + return 0; } @@ -869,7 +874,7 @@ static int __init rapl_pmu_init(void) if (ret) return ret; - ret = init_rapl_pmus(); + ret = init_rapl_pmus(&rapl_pmus); if (ret) return ret; @@ -893,7 +898,7 @@ static int __init rapl_pmu_init(void) cpuhp_remove_state(CPUHP_AP_PERF_X86_RAPL_ONLINE); out: pr_warn("Initialization failed (%d), disabled\n", ret); - cleanup_rapl_pmus(); + cleanup_rapl_pmus(rapl_pmus); return ret; } module_init(rapl_pmu_init); @@ -902,6 +907,6 @@ static void __exit intel_rapl_exit(void) { cpuhp_remove_state_nocalls(CPUHP_AP_PERF_X86_RAPL_ONLINE); perf_pmu_unregister(&rapl_pmus->pmu); - cleanup_rapl_pmus(); + cleanup_rapl_pmus(rapl_pmus); } module_exit(intel_rapl_exit); From patchwork Mon Jun 24 05:59:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13709009 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2041.outbound.protection.outlook.com [40.107.101.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B4A61C69A; Mon, 24 Jun 2024 06:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208981; cv=fail; b=RF8arevOjFDP4obm6pL8NPf1byfZQWUZlTtcsSoaRZPBQPKyF/aPpjfR2eD2pr3+WRPUQUilDGQ4EUoRt2A89EfbEFC/49/CUL2hA2SDPxdE5LEstGJK32gkHWpkwycqiajIvKp/tmaEW+F8N7uwI/5xRizh6Z43TJpRhZBVPVU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719208981; c=relaxed/simple; bh=f51elEAnnGY8jcyDm2clri5C8DYL0hi49mwoDWpy6C4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c/ub+tCCC+azBRy+wrBKiFF/GFfPAMVw5HnHFS6IvCfdk9enfozJP56qQAMxqV3ER27rmx/6c4MsXLax9Wml2jZzZdwh5989PnQ8eAPpB1efvHUajUa6TCy7t2PIt+ojZqhajrh7jh9LKOnATTQf4/WqiHzg/9OSFbfprnxJDCc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ETHdzuM0; arc=fail smtp.client-ip=40.107.101.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ETHdzuM0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJKcmkyjlSLKiHkcLZGOd8EpNOjmZVVgX11VIQhJB8TsmkqW4yeHeqpUF8TgNHcvnVVOTbOLQRnPIKBdsWovyextyCV7HLff77trh7xoHsC7Qaj7tvTBV7a6i7kqTDN4tlYXz0YU10WG6aDf6PavWeVNw0+dCmCdYl78h+wv7f39c4wF87UE6R+qQMrERX7CBSlmIuadfbRwii9SRkLg5DC4AWnQwz8PJc2NQuy4VjfiK48UVe1zbZvNyry2iqlWypMLGwYRe6iksHkvtWmcvaxsuuidY/MSJ596kuBHKIKu5HAJuKpRyjO4oa1jzM4Tgz9+8zpu4pAFDDn8QTIggQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8mpl5fVfYKHno4hVEKboGWqoDffB6RRgOtt9zFqYIyY=; b=bqZN8+jzRclDzm0ppRibyHxsxzErMGYuaWuFw/Ujn/NziaJoXshntRNPqg1TA/UAOU2yNCoIl1dP2Xg8bAX5iUtWidqZ7ReNs3y+wPfkaOuh20MlHW5zniXUJ9QxPIJJSvZg03AG/Uvzsr9+07ZCnYF9tsEUaQ9WrkTXed7T4qHKsu+eUDSZO3M3XIB8qKybGOUXK6A/hkSZVLonyEO6qUBscUo6Q8EV+lRG0iB/I/hoXv49XW+1hqp+n92+TzawWis5V8BLwnkwYDnPAY1X/2snYvoFvWC/51VkcziGSlqih72FwhjTzd1zgfjJtf0mdWR0p7H2islwFFlCtqSZyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8mpl5fVfYKHno4hVEKboGWqoDffB6RRgOtt9zFqYIyY=; b=ETHdzuM02zCro4yGmwagTwhRMjSfq3/E06YZb75cSjDVBNjZAbnb1pcIkogW2RAMSNbmVOg+EN4sdGoVPQ0OX+nBwxmbMXl0UGsnadcnjz2xCU1jX67xd2luZVkHilI4NWKdMegOoe6VxlEJb6uQEVMTJW+TR9R8xLf/3IkfztI= Received: from BL1PR13CA0387.namprd13.prod.outlook.com (2603:10b6:208:2c0::32) by DS0PR12MB6607.namprd12.prod.outlook.com (2603:10b6:8:d1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Mon, 24 Jun 2024 06:02:56 +0000 Received: from BN2PEPF000055E1.namprd21.prod.outlook.com (2603:10b6:208:2c0:cafe::25) by BL1PR13CA0387.outlook.office365.com (2603:10b6:208:2c0::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.37 via Frontend Transport; Mon, 24 Jun 2024 06:02:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055E1.mail.protection.outlook.com (10.167.245.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:02:56 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:02:48 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg* Date: Mon, 24 Jun 2024 05:59:05 +0000 Message-ID: <20240624055907.7720-9-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055E1:EE_|DS0PR12MB6607:EE_ X-MS-Office365-Filtering-Correlation-Id: e5d75695-0fa0-4857-3b25-08dc94134afa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|36860700010|82310400023|376011|7416011|1800799021|921017; X-Microsoft-Antispam-Message-Info: 8+NCCY3EBILmXhmOQOrPUW+qv9o528N2MselUi3sCGD6Cl194ZvFfXvK8gkRa1dk7knjPZK8xz4ocAxNdCGLzMGT/ATz9gmcarcpteG9xQ76mCrbl7ui1cBhAicBWYhWtvI1XjsBJBQXpPoNQi1ghNLAnZrMCHgQ83ZFP21QeOMosAV7cXmvdGjZ1t+4tOlIyJDvm7cCd8hYYOrp1Ne/PiwGGqhYhPJJxliw+Op0Lx8yNzlv8Sb5wPDe7da+4+x8G2guh5EjkuA9apHWf2UOJvOl5y6c2Yn5YoLAmpt8Cjfu2bpwkxYRVxk/mJCmI7sQz8h2qmcZu3VLKRuTH2xv1MQLgwNvNL6/CwauIOgcRm0/BFuKBuOohdSK2/+HWdsJAAhCs6xiMQEB1y9YzBkWnGQ+HzLB5mMwogpZms5Mk/zeiY2S+Wdg9PsO1xORwIHxHXfyzvSbec9y4T48gxfK39EcT6p768Qnme1eY5csXuK0n8FcEPvovW1FWpyeBuJFIBdt8qobueu3B6xJbzL6GHDKC1eaU6/yEKZIOjzw8UTNda16SeqeJqZOQ0KiMlaJZllQE1ObHtR+raIyTV9yfnPIk0ayCmGglcet5bdL2l8O7/DhRUH7ij4JJ9Y6+tP1lVRZWvd1VgK+M1kw3h0o1ArAmm0Mcigoz0o9uuz6m/7F+LnrGE9hYmzC9uF2du6RuBWwJ6wCk4trD/4A3vw3Rc23t6EyZJj1y12329lThyz93tj0h6E2AQBZbAJkNKCsUoo7xtOijbgg6EnOFrJ+d4RBiKEPHWuhr6L/BQwG2An0eoplurO///LqgVfTMF12MkTlR0iIc+47xkjufzjrIVldxHIqNyfnwhvLQ52L1fGT5xdiIe7PNlrgPMTZaJxb4jDWbRUubA6kjYMG4C2wdMRsk+pbI+/XNyyDeybI7LjRCD3UL1dg/1cFMKTs9XUh/y1t8U7tfvo3TRWDRo1GP0IkMBxCmNEaVLl3Pj67oWPyt5+Bzhb1xvTnSi6n7Js0gNdvMpHTtWSnmT/0r2eopSfKgTVCSaA3rwFIIGkoFBH9o4OGeX3Erpal4xws/zt1Rq+ScJFsDVCPvegURWXn7zbL9+eunEJ2vPeKPQY6L+SNPGRbzxUNJbyHL02RI0kwo+bPQ4X4CmZ01ovsYasc0ILvXW7vMqQfoejhYopO0/DgYmv2sP7YRt9hwE0jg1W8sYgobfB+OnNwvbMwpXbo65q7bCnq/Bnv2MCreifYea9swcc7wwM4s4Tr0K6vpBZ2i/mPjM8A//Eq5ZPugWzsvXNvcIvTmvMkZ1tbQOq+e0OFY6PFiIuaaUBWE1hWxreBgam8lmJ4uyjiLEcP4BMuI/l3g4LkotDaXQkzF1txQfr9bBpbcl+VuS3U/d37TrpWYoov2yp3oadCL3rvK3TrHr2ED/FzmYjoaNdHDaQxnTs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(36860700010)(82310400023)(376011)(7416011)(1800799021)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:02:56.2189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5d75695-0fa0-4857-3b25-08dc94134afa X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055E1.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6607 Prep for addition of power_per_core PMU to handle core scope energy consumption for AMD CPUs. Replace the generic names with *_pkg*, to differentiate between the scopes of the two different PMUs and their variables. No functional change. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 83 +++++++++++++++++++++--------------------- 1 file changed, 42 insertions(+), 41 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index f815c60ec551..b03b044a390f 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -70,18 +70,18 @@ MODULE_LICENSE("GPL"); /* * RAPL energy status counters */ -enum perf_rapl_events { +enum perf_rapl_pkg_events { PERF_RAPL_PP0 = 0, /* all cores */ PERF_RAPL_PKG, /* entire package */ PERF_RAPL_RAM, /* DRAM */ PERF_RAPL_PP1, /* gpu */ PERF_RAPL_PSYS, /* psys */ - PERF_RAPL_MAX, - NR_RAPL_DOMAINS = PERF_RAPL_MAX, + PERF_RAPL_PKG_EVENTS_MAX, + NR_RAPL_PKG_DOMAINS = PERF_RAPL_PKG_EVENTS_MAX, }; -static const char *const rapl_domain_names[NR_RAPL_DOMAINS] __initconst = { +static const char *const rapl_pkg_domain_names[NR_RAPL_PKG_DOMAINS] __initconst = { "pp0-core", "package", "dram", @@ -132,15 +132,15 @@ enum rapl_unit_quirk { struct rapl_model { struct perf_msr *rapl_msrs; - unsigned long events; + unsigned long pkg_events; unsigned int msr_power_unit; enum rapl_unit_quirk unit_quirk; }; /* 1/2^hw_unit Joule */ -static int rapl_hw_unit[NR_RAPL_DOMAINS] __read_mostly; -static struct rapl_pmus *rapl_pmus; -static unsigned int rapl_cntr_mask; +static int rapl_hw_unit[NR_RAPL_PKG_DOMAINS] __read_mostly; +static struct rapl_pmus *rapl_pmus_pkg; +static unsigned int rapl_pkg_cntr_mask; static u64 rapl_timer_ms; static struct perf_msr *rapl_msrs; static struct rapl_model *rapl_model; @@ -165,7 +165,8 @@ static inline struct rapl_pmu *cpu_to_rapl_pmu(unsigned int cpu) * The unsigned check also catches the '-1' return value for non * existent mappings in the topology map. */ - return rapl_pmu_idx < rapl_pmus->nr_rapl_pmu ? rapl_pmus->rapl_pmu[rapl_pmu_idx] : NULL; + return rapl_pmu_idx < rapl_pmus_pkg->nr_rapl_pmu ? + rapl_pmus_pkg->rapl_pmu[rapl_pmu_idx] : NULL; } static inline u64 rapl_read_counter(struct perf_event *event) @@ -177,7 +178,7 @@ static inline u64 rapl_read_counter(struct perf_event *event) static inline u64 rapl_scale(u64 v, int cfg) { - if (cfg > NR_RAPL_DOMAINS) { + if (cfg > NR_RAPL_PKG_DOMAINS) { pr_warn("Invalid domain %d, failed to scale data\n", cfg); return v; } @@ -347,7 +348,7 @@ static int rapl_pmu_event_init(struct perf_event *event) struct rapl_pmu *rapl_pmu; /* only look at RAPL events */ - if (event->attr.type != rapl_pmus->pmu.type) + if (event->attr.type != rapl_pmus_pkg->pmu.type) return -ENOENT; /* check only supported bits are set */ @@ -359,14 +360,14 @@ static int rapl_pmu_event_init(struct perf_event *event) event->event_caps |= PERF_EV_CAP_READ_ACTIVE_PKG; - if (!cfg || cfg >= NR_RAPL_DOMAINS + 1) + if (!cfg || cfg >= NR_RAPL_PKG_DOMAINS + 1) return -EINVAL; - cfg = array_index_nospec((long)cfg, NR_RAPL_DOMAINS + 1); + cfg = array_index_nospec((long)cfg, NR_RAPL_PKG_DOMAINS + 1); bit = cfg - 1; /* check event supported */ - if (!(rapl_cntr_mask & (1 << bit))) + if (!(rapl_pkg_cntr_mask & (1 << bit))) return -EINVAL; /* unsupported modes and filters */ @@ -394,7 +395,7 @@ static void rapl_pmu_event_read(struct perf_event *event) static ssize_t rapl_get_attr_cpumask(struct device *dev, struct device_attribute *attr, char *buf) { - return cpumap_print_to_pagebuf(true, buf, &rapl_pmus->cpumask); + return cpumap_print_to_pagebuf(true, buf, &rapl_pmus_pkg->cpumask); } static DEVICE_ATTR(cpumask, S_IRUGO, rapl_get_attr_cpumask, NULL); @@ -546,11 +547,11 @@ static struct perf_msr intel_rapl_spr_msrs[] = { }; /* - * Force to PERF_RAPL_MAX size due to: - * - perf_msr_probe(PERF_RAPL_MAX) + * Force to PERF_RAPL_PKG_EVENTS_MAX size due to: + * - perf_msr_probe(PERF_RAPL_PKG_EVENTS_MAX) * - want to use same event codes across both architectures */ -static struct perf_msr amd_rapl_msrs[] = { +static struct perf_msr amd_rapl_pkg_msrs[] = { [PERF_RAPL_PP0] = { 0, &rapl_events_cores_group, NULL, false, 0 }, [PERF_RAPL_PKG] = { MSR_AMD_PKG_ENERGY_STATUS, &rapl_events_pkg_group, test_msr, false, RAPL_MSR_MASK }, [PERF_RAPL_RAM] = { 0, &rapl_events_ram_group, NULL, false, 0 }, @@ -583,7 +584,7 @@ static int __rapl_cpu_offline(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu static int rapl_cpu_offline(unsigned int cpu) { - return __rapl_cpu_offline(rapl_pmus, get_rapl_pmu_idx(cpu), + return __rapl_cpu_offline(rapl_pmus_pkg, get_rapl_pmu_idx(cpu), get_rapl_pmu_cpumask(cpu), cpu); } @@ -622,7 +623,7 @@ static int __rapl_cpu_online(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu_ static int rapl_cpu_online(unsigned int cpu) { - return __rapl_cpu_online(rapl_pmus, get_rapl_pmu_idx(cpu), + return __rapl_cpu_online(rapl_pmus_pkg, get_rapl_pmu_idx(cpu), get_rapl_pmu_cpumask(cpu), cpu); } @@ -635,7 +636,7 @@ static int rapl_check_hw_unit(void) /* protect rdmsrl() to handle virtualization */ if (rdmsrl_safe(rapl_model->msr_power_unit, &msr_rapl_power_unit_bits)) return -1; - for (i = 0; i < NR_RAPL_DOMAINS; i++) + for (i = 0; i < NR_RAPL_PKG_DOMAINS; i++) rapl_hw_unit[i] = (msr_rapl_power_unit_bits >> 8) & 0x1FULL; switch (rapl_model->unit_quirk) { @@ -677,12 +678,12 @@ static void __init rapl_advertise(void) int i; pr_info("API unit is 2^-32 Joules, %d fixed counters, %llu ms ovfl timer\n", - hweight32(rapl_cntr_mask), rapl_timer_ms); + hweight32(rapl_pkg_cntr_mask), rapl_timer_ms); - for (i = 0; i < NR_RAPL_DOMAINS; i++) { - if (rapl_cntr_mask & (1 << i)) { + for (i = 0; i < NR_RAPL_PKG_DOMAINS; i++) { + if (rapl_pkg_cntr_mask & (1 << i)) { pr_info("hw unit of domain %s 2^-%d Joules\n", - rapl_domain_names[i], rapl_hw_unit[i]); + rapl_pkg_domain_names[i], rapl_hw_unit[i]); } } } @@ -737,7 +738,7 @@ static int __init init_rapl_pmus(struct rapl_pmus **rapl_pmus_ptr) } static struct rapl_model model_snb = { - .events = BIT(PERF_RAPL_PP0) | + .pkg_events = BIT(PERF_RAPL_PP0) | BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_PP1), .msr_power_unit = MSR_RAPL_POWER_UNIT, @@ -745,7 +746,7 @@ static struct rapl_model model_snb = { }; static struct rapl_model model_snbep = { - .events = BIT(PERF_RAPL_PP0) | + .pkg_events = BIT(PERF_RAPL_PP0) | BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_RAM), .msr_power_unit = MSR_RAPL_POWER_UNIT, @@ -753,7 +754,7 @@ static struct rapl_model model_snbep = { }; static struct rapl_model model_hsw = { - .events = BIT(PERF_RAPL_PP0) | + .pkg_events = BIT(PERF_RAPL_PP0) | BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_RAM) | BIT(PERF_RAPL_PP1), @@ -762,7 +763,7 @@ static struct rapl_model model_hsw = { }; static struct rapl_model model_hsx = { - .events = BIT(PERF_RAPL_PP0) | + .pkg_events = BIT(PERF_RAPL_PP0) | BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_RAM), .unit_quirk = RAPL_UNIT_QUIRK_INTEL_HSW, @@ -771,7 +772,7 @@ static struct rapl_model model_hsx = { }; static struct rapl_model model_knl = { - .events = BIT(PERF_RAPL_PKG) | + .pkg_events = BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_RAM), .unit_quirk = RAPL_UNIT_QUIRK_INTEL_HSW, .msr_power_unit = MSR_RAPL_POWER_UNIT, @@ -779,7 +780,7 @@ static struct rapl_model model_knl = { }; static struct rapl_model model_skl = { - .events = BIT(PERF_RAPL_PP0) | + .pkg_events = BIT(PERF_RAPL_PP0) | BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_RAM) | BIT(PERF_RAPL_PP1) | @@ -789,7 +790,7 @@ static struct rapl_model model_skl = { }; static struct rapl_model model_spr = { - .events = BIT(PERF_RAPL_PP0) | + .pkg_events = BIT(PERF_RAPL_PP0) | BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_RAM) | BIT(PERF_RAPL_PSYS), @@ -799,9 +800,9 @@ static struct rapl_model model_spr = { }; static struct rapl_model model_amd_hygon = { - .events = BIT(PERF_RAPL_PKG), + .pkg_events = BIT(PERF_RAPL_PKG), .msr_power_unit = MSR_AMD_RAPL_POWER_UNIT, - .rapl_msrs = amd_rapl_msrs, + .rapl_msrs = amd_rapl_pkg_msrs, }; static const struct x86_cpu_id rapl_model_match[] __initconst = { @@ -867,14 +868,14 @@ static int __init rapl_pmu_init(void) rapl_msrs = rapl_model->rapl_msrs; - rapl_cntr_mask = perf_msr_probe(rapl_msrs, PERF_RAPL_MAX, - false, (void *) &rapl_model->events); + rapl_pkg_cntr_mask = perf_msr_probe(rapl_msrs, PERF_RAPL_PKG_EVENTS_MAX, + false, (void *) &rapl_model->pkg_events); ret = rapl_check_hw_unit(); if (ret) return ret; - ret = init_rapl_pmus(&rapl_pmus); + ret = init_rapl_pmus(&rapl_pmus_pkg); if (ret) return ret; @@ -887,7 +888,7 @@ static int __init rapl_pmu_init(void) if (ret) goto out; - ret = perf_pmu_register(&rapl_pmus->pmu, "power", -1); + ret = perf_pmu_register(&rapl_pmus_pkg->pmu, "power", -1); if (ret) goto out1; @@ -898,7 +899,7 @@ static int __init rapl_pmu_init(void) cpuhp_remove_state(CPUHP_AP_PERF_X86_RAPL_ONLINE); out: pr_warn("Initialization failed (%d), disabled\n", ret); - cleanup_rapl_pmus(rapl_pmus); + cleanup_rapl_pmus(rapl_pmus_pkg); return ret; } module_init(rapl_pmu_init); @@ -906,7 +907,7 @@ module_init(rapl_pmu_init); static void __exit intel_rapl_exit(void) { cpuhp_remove_state_nocalls(CPUHP_AP_PERF_X86_RAPL_ONLINE); - perf_pmu_unregister(&rapl_pmus->pmu); - cleanup_rapl_pmus(rapl_pmus); + perf_pmu_unregister(&rapl_pmus_pkg->pmu); + cleanup_rapl_pmus(rapl_pmus_pkg); } module_exit(intel_rapl_exit); From patchwork Mon Jun 24 05:59:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13709010 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2049.outbound.protection.outlook.com [40.107.236.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7BB11C695; Mon, 24 Jun 2024 06:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719209001; cv=fail; b=MXIoj39+G+3unQmm0eEGI2poMOXUUy7FfY/vXoPEhMdbFuZ/L1nrLluzLYvqoY0rb1UWtuz7CXZarktFGmeTsOyD00qmsOdStmbCQ2QiflhTLke12NXhvU7c5SjOjX87cC3ECX3rfci5uYg0wmFSuyriTC63+0hwYn8kebEUPic= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719209001; c=relaxed/simple; bh=r3KZn4cY29i3ZVT8o0x7Etz+i2GyJ3TuDpeR2bPZpxY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q0dbyDMyIFIvh/k+rzZhKI/2cSFRrmp/q5HZc/yrIoXuOrAYyMmGkuKGMRCxdACfMgcX3CHoUI7jrn/AM/VC0HmulDyU9x26w0EhuJGL2Tiqu3mumWxkKRpTdUqVTx5nMqyOlxKkEJMNZUNPKICre/kXtL/NjFgs0Vieqxroxg4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=atsNQm54; arc=fail smtp.client-ip=40.107.236.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="atsNQm54" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0sGoIYjYuEx307MArEB+TTdu78FOeNWLW2gZFYMhNaRxDaN+I3n3g+Qa+y5CcL4ZL/AutNNM1vLZzUYFuSMBJ20m/n15ZRV1sWJJVETlG9wNwOPA5YrJtuglK3LidlmnHFyHG/7C4kMvdmuwY1Z8xV/lqoO5MmB3VWE72hm2xxIa9CsUq0KL1eSbhBdgjbzGAy/48TDTM9uULRtadJGtkYtJyuWOS2Q40tcXtwRYltGYpQrpwkfqlACfbaTtumQoTg/vrSlzWz4GEZL7x4Qmph8jcbc38NYzFXJMiSgJlcUuwhOxeOtW1Fneox4EwIu//ezSQVkxllOXXvsk8CSLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EJw2vpL4ySk0o0rEFGGvb5MNBmpk6BRClOy53vqQOIY=; b=fYNFrvc8QEkaCZJl+sajQrWUcGuIueqIcXv9ZMbOgZXig22X4Iej/YVbcnrmylGxuAqo4vUtg5qBBVx3f5Qz8dcrAHkyQE0aBENmitgjBMNsapjA2Y7DTKYxV8VnVLmSDc+ofX7BC0S3WrBr8XMiiWDuFmpeJ19c6VXfuWm7fvrmIaYRQGzVR56qALV0AkDZutanl4S7Bre3wl7l15Xwme2uNmHjc+IhVmm9YHpL1iHdZYJFNS/s21H6tGziDxczMeQgkQDFNcY4+RkUSyXw+eXA/l1wFxNumPUgLHXRtVO1NxpaZQKAWg5CGO3zlrqJ6EwPV35JA6UF2v+QzKtLLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EJw2vpL4ySk0o0rEFGGvb5MNBmpk6BRClOy53vqQOIY=; b=atsNQm54cRZaa9ITFxuILApOiCq9sSrwe8qxv8XX9SQ3xibgNMMtc+FDTey7GSCUVauieNaxyGuLYyPmDOrVzWhVGSgN2DV8pmtyCEXrUuDSu61w89DyjRZeDreEfM5SmGjuWxb/6oeS3x2UL7hfOp71XVxV/ID++DUzPoTSqJk= Received: from BN0PR04CA0162.namprd04.prod.outlook.com (2603:10b6:408:eb::17) by DS7PR12MB5981.namprd12.prod.outlook.com (2603:10b6:8:7c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.29; Mon, 24 Jun 2024 06:03:16 +0000 Received: from BN2PEPF000055DF.namprd21.prod.outlook.com (2603:10b6:408:eb:cafe::a6) by BN0PR04CA0162.outlook.office365.com (2603:10b6:408:eb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:03:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DF.mail.protection.outlook.com (10.167.245.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:03:16 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:03:08 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 09/10] perf/x86/rapl: Remove the global variable rapl_msrs Date: Mon, 24 Jun 2024 05:59:06 +0000 Message-ID: <20240624055907.7720-10-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DF:EE_|DS7PR12MB5981:EE_ X-MS-Office365-Filtering-Correlation-Id: 90176e88-f801-4d61-6aa0-08dc94135704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|36860700010|7416011|376011|82310400023|921017; X-Microsoft-Antispam-Message-Info: pVazGTeTPOiF/h9MpX4+vvb4mUq1wKSssS0x1vzglxxIM2JiMA2zKPlAASChu4PiIe+1p+ekHarCpgNetosJ+daK8oPcTK7Xq2g1MkYMOGKazjqWtrLbTyWEnTYTbBHdcaoRvQw7NhqOpMc736TXzQafXmRqTCOHTQEinlaLlfvQqIjOuYeleCoSja9naGB94T5DBNZ1VPxZJ4epNRexaVpFHMI6FNTl8S92AF2KV/nmKnLUqh7K1RoXpspkvjWcwiqIf95/GArJiAM8AG9GoSGOabAwy2Msmm7bcG3yyTraY0Ohh0eNNgAL7M9V7ZGVQx1gbvVUQ/uPmXsJq668K61UespsglbLanexW5D+9ALCZgUoz8BQLl4Bi161swErenPbLs2PHcATptDtLRTRUV3KxsgaydkY1SMQQBAta7L7/udOJ7M0BqesWiqvcf3pM8AqHuPfv5IynzqYsqx9CszQQpsDJaSRP4o9b51Er+JlkUZ8+I3HTPUpD0GijuUpE458kA8XTdyJPUh4ZKHjVLyhS14oc7mtb7gPWJqGPJ3Utrpxu5clxjjsnL3rDJVOfYAa2U4l62Vj5YO0O621GutdFA/Rmdur857XnUFw+Kaz4/ZNRe+JVaCW15ImVynWB6XEp0bw0MkaOxgD0BRObYaR18C0ig6dxFOSPcMG6TL88LW2ZJcnZBfFdgHl8CQlPgC8m+IhaaS5mtxMrWyX0fRtU5ePs50Hw4uNDO19y2hDclO+NAVcUjz9NlyiqhctBNQHzoC0JKDnIsrD6OrFLWIlM97tiOXKX9/3vjkM47iGAG40ypvp8tfPGyKIA054UU9DI91CQ92oxFaxI3BR+xfPnEZjXwjrMa0P40rh+nR1bun5AaKXfanuL19SxjRIsECq3C9uIIIf9I1nyyXrWNpdmPyPVE8eXT2MWdrO0NonJaiVkimFE51Pk7g7ESjAiSBCZJ6ka2hxCJdi8/ZCq8KJxjEWM79reTgSyEN0RYFOBtoVzj8GW3VRj+uMjSGJxazQ0L+UCNmHvjz81k2PGcAAVHphLb+hi65W11JTK6Lpv6CVsoFryniF5L4Sic/suK9Iw05l6sA+R35B2GPJGxCg0qgF8oN8h5MY/pwm9mXmsDJexwXm6gfu5VcQh/QS3d2VbaquBe+vN1awRxo+HC9zJkccudvjFREDo+5ERbbLafptUIHRnG8b/nrq5qoC5kDhN/6mtdpNdP/jHibRUtcSK5mv5ZgE7b0Xnm80iFa8dUioDa5Dx4gBbUsT44t4uuoxj32KNPbzeGXOLFAJlLuyVKejU3jbmVUSe+5q2595kjIblyEF7EWDi92sbgQhkEfJmPAmCWRF1xiqhmzdx/G8PBcpKhQkhP/yIA9fWHffJXcBAm4/uFDTqtpM/dhwnPPRyITbcvLAAxkmKHWPfTm64PgbRbGQ/X+GmA8mzyk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(1800799021)(36860700010)(7416011)(376011)(82310400023)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:03:16.4183 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90176e88-f801-4d61-6aa0-08dc94135704 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DF.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5981 After making the rapl_model struct global, the rapl_msrs global variable isn't needed, so remove it. Also it will be cleaner when new per-core scope PMU is added. As we will need to maintain two rapl_msrs array(one for per-core scope and one for package scope PMU), inside the rapl_model struct. Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index b03b044a390f..e962209e9e4d 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -142,7 +142,6 @@ static int rapl_hw_unit[NR_RAPL_PKG_DOMAINS] __read_mostly; static struct rapl_pmus *rapl_pmus_pkg; static unsigned int rapl_pkg_cntr_mask; static u64 rapl_timer_ms; -static struct perf_msr *rapl_msrs; static struct rapl_model *rapl_model; static inline unsigned int get_rapl_pmu_idx(int cpu) @@ -380,7 +379,7 @@ static int rapl_pmu_event_init(struct perf_event *event) return -EINVAL; event->cpu = rapl_pmu->cpu; event->pmu_private = rapl_pmu; - event->hw.event_base = rapl_msrs[bit].msr; + event->hw.event_base = rapl_model->rapl_msrs[bit].msr; event->hw.config = cfg; event->hw.idx = bit; @@ -866,9 +865,7 @@ static int __init rapl_pmu_init(void) rapl_model = (struct rapl_model *) id->driver_data; - rapl_msrs = rapl_model->rapl_msrs; - - rapl_pkg_cntr_mask = perf_msr_probe(rapl_msrs, PERF_RAPL_PKG_EVENTS_MAX, + rapl_pkg_cntr_mask = perf_msr_probe(rapl_model->rapl_msrs, PERF_RAPL_PKG_EVENTS_MAX, false, (void *) &rapl_model->pkg_events); ret = rapl_check_hw_unit(); From patchwork Mon Jun 24 05:59:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13709011 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2075.outbound.protection.outlook.com [40.107.101.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B91951CD25; Mon, 24 Jun 2024 06:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719209020; cv=fail; b=s7PU1JiCVrYyRuMmI3+kJ6NdScsPtkcr11jx108FSVALWe1BmhdU4CPk7MnfBsQmoKkItxiASnzcEZKtp7Os+UwNySMiNk194Xz/pdbiy6S2pTq9/YLl8NkCLdjj9aRVKRfFbjOUKVgib7myhYa5bGPfBQQoRqt0mtqj5BmPW8E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719209020; c=relaxed/simple; bh=w7QAf0R/ArjoM2OO2K6rpC0fXED2wJ9uM0+KWVIEDSE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kzNqo7kSFC4dPt1o+wA256okIQGD2KaCJoMcmgw6bF5LmIZH7HTiytIgSehSno71yOTbvI6axiPVXbAGa4rRIYZzEhEIrcoN7Jnfi3RFUi4xiJ6YYDaa7DYmpU8qbZDvA+WLVkfrtsg6/Qg/yPx1IpB3MTkuMLmXBgPjJVWKt44= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Y+JS9tR7; arc=fail smtp.client-ip=40.107.101.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Y+JS9tR7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aD6jKqSGdo27QEv9iGVn5OvzHPs7iGim2z572cJuHYKcuoKhnL5n2vr5mPfaOLptqIVnLyU4ovC9iG8G5Bsipwbu9lJMPaZ+0CKnMu1QkpIs2zwfzUNF1GuehGcH6/rd0P1wuuvA2mPN3Xl61cAfxKxI+yq0ZJ8/9THsN5n8Mb93t3HHN7fGMkrWyck6ayYx5yVkD//Bi3G6a+7oXooZV+NWASWTA96mDtgdVyFZjm7pf4wxW1jJhhi6kKYutAu9VwTh/pAzmd5ujqBekXSaUvNmtcJ4udt6HzHQudFPmbqVlezRosDIVJ8pwI8nU1EAEDDRSin8+gYunovbyRB9+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EbDYnja41ELeIw1KOOcJsb/qK8MeW7ve7Seu70I+hcA=; b=Su5jHbfffFAEliB/qlVV3zYJ6vlVK8IlODBIRg7MHIT+GWWKy8BCzmPvj6OQNJ+K9qoom4PQKW+1rm491fzA+MYwbo2GSOSwRhiMjvLxxxraXraD9fSRxhfH4adpw+b0Aws5/3JJvGf+TSDRdoyY7f/niDEaFDXplQd15sQs09t6DOCYE55xJ1TyISrUGKMdXeGV+I44hfKPQu1LTkqkDtsF2/1OWV5Ph+iF5A9uKMEozxLHXdbYISWZH/puyjfE8Djbh0V80pUdEPpOIIyWCZSvCt6nVnay926KKaIB1jrq8X0eT/9ESdpQFoL5JuZjRET1+b3oI7iNd2yG2SyguQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EbDYnja41ELeIw1KOOcJsb/qK8MeW7ve7Seu70I+hcA=; b=Y+JS9tR7T9HzLVNA0nvWWIX3AZ2oR3OlfOXlyvy+XtLrZyVTh3SYPsyRWzMhgZz4S+ELpZVZUfITn4bjosYXu68+bwaWVRoW7KLe8OaOKtHAkz26MhF7ikmTXgsUQyiVbJaK0Id3i6W6YPe4q6beu04zyJ4Cce7Y2jAynfbZb/g= Received: from BN9PR03CA0483.namprd03.prod.outlook.com (2603:10b6:408:130::8) by IA1PR12MB6577.namprd12.prod.outlook.com (2603:10b6:208:3a3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.25; Mon, 24 Jun 2024 06:03:36 +0000 Received: from BN2PEPF000055DE.namprd21.prod.outlook.com (2603:10b6:408:130:cafe::14) by BN9PR03CA0483.outlook.office365.com (2603:10b6:408:130::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.38 via Frontend Transport; Mon, 24 Jun 2024 06:03:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN2PEPF000055DE.mail.protection.outlook.com (10.167.245.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7741.0 via Frontend Transport; Mon, 24 Jun 2024 06:03:35 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 24 Jun 2024 01:03:28 -0500 From: Dhananjay Ugwekar To: , , , , , , , , , , , , , , , , , CC: , , , , , , , , , Dhananjay Ugwekar Subject: [PATCH v3 10/10] perf/x86/rapl: Add per-core energy counter support for AMD CPUs Date: Mon, 24 Jun 2024 05:59:07 +0000 Message-ID: <20240624055907.7720-11-Dhananjay.Ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> References: <20240624055907.7720-1-Dhananjay.Ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DE:EE_|IA1PR12MB6577:EE_ X-MS-Office365-Filtering-Correlation-Id: 71075a7a-1bd7-4f9e-419f-08dc9413629b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|82310400023|1800799021|36860700010|7416011|376011|921017; X-Microsoft-Antispam-Message-Info: M4ru6vUGHeZRVcyqwHpWheXjEIGQ6XYVLKkMEdbPQNmnun3dJbDB5aiQ8iY92uTcJmt86sw9wkEewmEJimxIKOZRZ8hChruZU9BDjMS+dcntn7HhCpVM+c2H+fAcaSKyENwTvBwOd/WDexUaLuhu6/mX8YCXwKm+432wd3S00ynpyDLY2V5nXvt/l5wjfSvYB1uNNve4rqPZXaXFdIIpch1KP3nYyTfZoFe5rHqdJGEJwFYiBVywU1qFHryvSGpEEByvwm7CDeHyFZ6c9tNKZYx+g6+ehg8JGZpMCbo/NyEJNqMNc4fwsTOtFaBZOLAheCRDHjlMhJffaIYB/onc4En6ImSxogL2ULThWOiZXH3Z0VvnLEbOQmKfskqBG1k6/t9Rc3qGEHT7sXgm+Vd11LgYmgmz71AAQijbN8Y50QqKB17E/NPUDEP1aptuGxphfJbNlqE/P6qF8Agxq+0597e/2XM88kilVgTrwjuz+7azC8kr/JpZbvneUVAhpVV8lNJYj2phKnOjXObg9EUSQ9o+GJCZ+/1tQCPPqhiKuCb7UK2pDiZ+SO3HTrnQGTaXK9vxT5Z9lx8bX6kOh4lR1A+V1FwEDsL/EFZ64wOcHIeiH+Lzv5C1dC9/W/6ehWr7UxiJNkku/zVxyDiYVhlSr/ZplJ14VNl7fTYfWi1ZsgjmglOYXs1YM/ei5ZaNMHz3efo7dpEOuF087Ft9migiYnzgXATnVvAxJrFfbZFEUfZeQem2Hl6qzdUrqaeQjhcPOWmDMkYFjFH9pUd7u2Xn3V1S4QUBMuDXfk1VSIKfS8hV+wjuHE+J19ozUjeBydd0MpqCCIEy5W56/NJPZ3X57MvYbpbdr8VXPVJV4Yiga5TRcl4soPLgMmDYOJWEQa4DPr8f4Mm9QmrIot+yGwKL25cO52KdRoYg/RtPA+2O+0t4mrvxkcJ5h6OAKIXbRa/Q/ZddaQvTUpwxXWafzcQewTQPnD/rVVe6HP2DcmxOvR5m+0RlJgpH5sfddqczzg5fLN2KuwMRGL0hs3ZMN798P7ly54GVU937hjWgw3+0VYlXDcxcH3G99/7Y6qyC1lj3gciva5SDCCk2rx0koeitz/zbA/pH7NJO2mNVw4ED4aewKjiNgomGQko4ZF/KQ7EluD/gyRH2iL6U0E7SnzU1XE+AkrZzXfObigkIBKqx7Rz3hfVZa9L29L/8mNbgJm5pdNz6oViTQqitluyRfLNBRpdHUAscJFxS6fIB4G72Z8IbGitGtKkw836ricgZxnT2RIyx3CY2RHI9wC4J6TxkfyyRvOykUisQofERvJnGiSzX7baVH26PX8ovALbjv33zAOVvBSSkLMyJXYc5SLIl7s86A39G+bxh0/JcTU9mmh5S+NwJuClZNS8c6ZJLVLLYTJwfMxR4T6OziNCANYmd810JiuZAlx55NUL45pKL+1I= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230037)(82310400023)(1800799021)(36860700010)(7416011)(376011)(921017);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 06:03:35.8774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71075a7a-1bd7-4f9e-419f-08dc9413629b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DE.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6577 Add a new "power_per_core" PMU and "energy-per-core" event for monitoring energy consumption by each core. The existing energy-cores event aggregates the energy consumption at the package level. This new event aligns with the AMD's per_core energy counters. Tested the package level and core level PMU counters with workloads pinned to different CPUs. Results with workload pinned to CPU 1 in core 1 on a AMD Zen4 Genoa machine: $ perf stat -a --per-core -e power_per_core/energy-per-core/ sleep 1 Performance counter stats for 'system wide': S0-D0-C0 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C1 1 5.72 Joules power_per_core/energy-per-core/ S0-D0-C2 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C3 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C4 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C5 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C6 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C7 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C8 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C9 1 0.02 Joules power_per_core/energy-per-core/ S0-D0-C10 1 0.02 Joules power_per_core/energy-per-core/ Signed-off-by: Dhananjay Ugwekar --- arch/x86/events/rapl.c | 189 +++++++++++++++++++++++++++++++++++------ 1 file changed, 164 insertions(+), 25 deletions(-) diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c index e962209e9e4d..8206038a01ac 100644 --- a/arch/x86/events/rapl.c +++ b/arch/x86/events/rapl.c @@ -39,6 +39,10 @@ * event: rapl_energy_psys * perf code: 0x5 * + * per_core counter: consumption of a single physical core + * event: rapl_energy_per_core (power_per_core PMU) + * perf code: 0x1 + * * We manage those counters as free running (read-only). They may be * use simultaneously by other tools, such as turbostat. * @@ -81,6 +85,13 @@ enum perf_rapl_pkg_events { NR_RAPL_PKG_DOMAINS = PERF_RAPL_PKG_EVENTS_MAX, }; +enum perf_rapl_core_events { + PERF_RAPL_PER_CORE = 0, /* per-core */ + + PERF_RAPL_CORE_EVENTS_MAX, + NR_RAPL_CORE_DOMAINS = PERF_RAPL_CORE_EVENTS_MAX, +}; + static const char *const rapl_pkg_domain_names[NR_RAPL_PKG_DOMAINS] __initconst = { "pp0-core", "package", @@ -89,6 +100,10 @@ static const char *const rapl_pkg_domain_names[NR_RAPL_PKG_DOMAINS] __initconst "psys", }; +static const char *const rapl_core_domain_names[NR_RAPL_CORE_DOMAINS] __initconst = { + "per-core", +}; + /* * event code: LSB 8 bits, passed in attr->config * any other bit is reserved @@ -131,8 +146,10 @@ enum rapl_unit_quirk { }; struct rapl_model { - struct perf_msr *rapl_msrs; + struct perf_msr *rapl_pkg_msrs; + struct perf_msr *rapl_core_msrs; unsigned long pkg_events; + unsigned long core_events; unsigned int msr_power_unit; enum rapl_unit_quirk unit_quirk; }; @@ -140,7 +157,9 @@ struct rapl_model { /* 1/2^hw_unit Joule */ static int rapl_hw_unit[NR_RAPL_PKG_DOMAINS] __read_mostly; static struct rapl_pmus *rapl_pmus_pkg; +static struct rapl_pmus *rapl_pmus_core; static unsigned int rapl_pkg_cntr_mask; +static unsigned int rapl_core_cntr_mask; static u64 rapl_timer_ms; static struct rapl_model *rapl_model; @@ -345,9 +364,13 @@ static int rapl_pmu_event_init(struct perf_event *event) u64 cfg = event->attr.config & RAPL_EVENT_MASK; int bit, ret = 0; struct rapl_pmu *rapl_pmu; + struct rapl_pmus *curr_rapl_pmus; /* only look at RAPL events */ - if (event->attr.type != rapl_pmus_pkg->pmu.type) + if (event->attr.type == rapl_pmus_pkg->pmu.type || + (rapl_pmus_core && event->attr.type == rapl_pmus_core->pmu.type)) + curr_rapl_pmus = container_of(event->pmu, struct rapl_pmus, pmu); + else return -ENOENT; /* check only supported bits are set */ @@ -357,7 +380,8 @@ static int rapl_pmu_event_init(struct perf_event *event) if (event->cpu < 0) return -EINVAL; - event->event_caps |= PERF_EV_CAP_READ_ACTIVE_PKG; + if (curr_rapl_pmus == rapl_pmus_pkg) + event->event_caps |= PERF_EV_CAP_READ_ACTIVE_PKG; if (!cfg || cfg >= NR_RAPL_PKG_DOMAINS + 1) return -EINVAL; @@ -366,7 +390,8 @@ static int rapl_pmu_event_init(struct perf_event *event) bit = cfg - 1; /* check event supported */ - if (!(rapl_pkg_cntr_mask & (1 << bit))) + if (!(rapl_pkg_cntr_mask & (1 << bit)) && + !(rapl_core_cntr_mask & (1 << bit))) return -EINVAL; /* unsupported modes and filters */ @@ -374,12 +399,18 @@ static int rapl_pmu_event_init(struct perf_event *event) return -EINVAL; /* must be done before validate_group */ - rapl_pmu = cpu_to_rapl_pmu(event->cpu); + if (curr_rapl_pmus == rapl_pmus_core) { + rapl_pmu = curr_rapl_pmus->rapl_pmu[topology_logical_core_id(event->cpu)]; + event->hw.event_base = rapl_model->rapl_core_msrs[bit].msr; + } else { + rapl_pmu = curr_rapl_pmus->rapl_pmu[get_rapl_pmu_idx(event->cpu)]; + event->hw.event_base = rapl_model->rapl_pkg_msrs[bit].msr; + } + if (!rapl_pmu) return -EINVAL; event->cpu = rapl_pmu->cpu; event->pmu_private = rapl_pmu; - event->hw.event_base = rapl_model->rapl_msrs[bit].msr; event->hw.config = cfg; event->hw.idx = bit; @@ -408,17 +439,38 @@ static struct attribute_group rapl_pmu_attr_group = { .attrs = rapl_pmu_attrs, }; +static ssize_t rapl_get_attr_per_core_cpumask(struct device *dev, + struct device_attribute *attr, char *buf) +{ + return cpumap_print_to_pagebuf(true, buf, &rapl_pmus_core->cpumask); +} + +static struct device_attribute dev_attr_per_core_cpumask = __ATTR(cpumask, 0444, + rapl_get_attr_per_core_cpumask, + NULL); + +static struct attribute *rapl_pmu_per_core_attrs[] = { + &dev_attr_per_core_cpumask.attr, + NULL, +}; + +static struct attribute_group rapl_pmu_per_core_attr_group = { + .attrs = rapl_pmu_per_core_attrs, +}; + RAPL_EVENT_ATTR_STR(energy-cores, rapl_cores, "event=0x01"); RAPL_EVENT_ATTR_STR(energy-pkg , rapl_pkg, "event=0x02"); RAPL_EVENT_ATTR_STR(energy-ram , rapl_ram, "event=0x03"); RAPL_EVENT_ATTR_STR(energy-gpu , rapl_gpu, "event=0x04"); RAPL_EVENT_ATTR_STR(energy-psys, rapl_psys, "event=0x05"); +RAPL_EVENT_ATTR_STR(energy-per-core, rapl_per_core, "event=0x01"); RAPL_EVENT_ATTR_STR(energy-cores.unit, rapl_cores_unit, "Joules"); RAPL_EVENT_ATTR_STR(energy-pkg.unit , rapl_pkg_unit, "Joules"); RAPL_EVENT_ATTR_STR(energy-ram.unit , rapl_ram_unit, "Joules"); RAPL_EVENT_ATTR_STR(energy-gpu.unit , rapl_gpu_unit, "Joules"); RAPL_EVENT_ATTR_STR(energy-psys.unit, rapl_psys_unit, "Joules"); +RAPL_EVENT_ATTR_STR(energy-per-core.unit, rapl_per_core_unit, "Joules"); /* * we compute in 0.23 nJ increments regardless of MSR @@ -428,6 +480,7 @@ RAPL_EVENT_ATTR_STR(energy-pkg.scale, rapl_pkg_scale, "2.3283064365386962890 RAPL_EVENT_ATTR_STR(energy-ram.scale, rapl_ram_scale, "2.3283064365386962890625e-10"); RAPL_EVENT_ATTR_STR(energy-gpu.scale, rapl_gpu_scale, "2.3283064365386962890625e-10"); RAPL_EVENT_ATTR_STR(energy-psys.scale, rapl_psys_scale, "2.3283064365386962890625e-10"); +RAPL_EVENT_ATTR_STR(energy-per-core.scale, rapl_per_core_scale, "2.3283064365386962890625e-10"); /* * There are no default events, but we need to create @@ -461,6 +514,13 @@ static const struct attribute_group *rapl_attr_groups[] = { NULL, }; +static const struct attribute_group *rapl_per_core_attr_groups[] = { + &rapl_pmu_per_core_attr_group, + &rapl_pmu_format_group, + &rapl_pmu_events_group, + NULL, +}; + static struct attribute *rapl_events_cores[] = { EVENT_PTR(rapl_cores), EVENT_PTR(rapl_cores_unit), @@ -521,6 +581,18 @@ static struct attribute_group rapl_events_psys_group = { .attrs = rapl_events_psys, }; +static struct attribute *rapl_events_per_core[] = { + EVENT_PTR(rapl_per_core), + EVENT_PTR(rapl_per_core_unit), + EVENT_PTR(rapl_per_core_scale), + NULL, +}; + +static struct attribute_group rapl_events_per_core_group = { + .name = "events", + .attrs = rapl_events_per_core, +}; + static bool test_msr(int idx, void *data) { return test_bit(idx, (unsigned long *) data); @@ -558,6 +630,11 @@ static struct perf_msr amd_rapl_pkg_msrs[] = { [PERF_RAPL_PSYS] = { 0, &rapl_events_psys_group, NULL, false, 0 }, }; +static struct perf_msr amd_rapl_core_msrs[] = { + [PERF_RAPL_PER_CORE] = { MSR_AMD_CORE_ENERGY_STATUS, &rapl_events_per_core_group, + test_msr, false, RAPL_MSR_MASK }, +}; + static int __rapl_cpu_offline(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu_idx, const struct cpumask *event_cpumask, unsigned int cpu) { @@ -583,8 +660,14 @@ static int __rapl_cpu_offline(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu static int rapl_cpu_offline(unsigned int cpu) { - return __rapl_cpu_offline(rapl_pmus_pkg, get_rapl_pmu_idx(cpu), + int ret = __rapl_cpu_offline(rapl_pmus_pkg, get_rapl_pmu_idx(cpu), get_rapl_pmu_cpumask(cpu), cpu); + + if (ret == 0 && rapl_model->core_events) + ret = __rapl_cpu_offline(rapl_pmus_core, topology_logical_core_id(cpu), + topology_sibling_cpumask(cpu), cpu); + + return ret; } static int __rapl_cpu_online(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu_idx, @@ -622,8 +705,14 @@ static int __rapl_cpu_online(struct rapl_pmus *rapl_pmus, unsigned int rapl_pmu_ static int rapl_cpu_online(unsigned int cpu) { - return __rapl_cpu_online(rapl_pmus_pkg, get_rapl_pmu_idx(cpu), + int ret = __rapl_cpu_online(rapl_pmus_pkg, get_rapl_pmu_idx(cpu), get_rapl_pmu_cpumask(cpu), cpu); + + if (ret == 0 && rapl_model->core_events) + ret = __rapl_cpu_online(rapl_pmus_core, topology_logical_core_id(cpu), + topology_sibling_cpumask(cpu), cpu); + + return ret; } @@ -677,7 +766,7 @@ static void __init rapl_advertise(void) int i; pr_info("API unit is 2^-32 Joules, %d fixed counters, %llu ms ovfl timer\n", - hweight32(rapl_pkg_cntr_mask), rapl_timer_ms); + hweight32(rapl_pkg_cntr_mask) + hweight32(rapl_core_cntr_mask), rapl_timer_ms); for (i = 0; i < NR_RAPL_PKG_DOMAINS; i++) { if (rapl_pkg_cntr_mask & (1 << i)) { @@ -685,6 +774,13 @@ static void __init rapl_advertise(void) rapl_pkg_domain_names[i], rapl_hw_unit[i]); } } + + for (i = 0; i < NR_RAPL_CORE_DOMAINS; i++) { + if (rapl_core_cntr_mask & (1 << i)) { + pr_info("hw unit of domain %s 2^-%d Joules\n", + rapl_core_domain_names[i], rapl_hw_unit[i]); + } + } } static void cleanup_rapl_pmus(struct rapl_pmus *rapl_pmus) @@ -705,15 +801,16 @@ static const struct attribute_group *rapl_attr_update[] = { NULL, }; -static int __init init_rapl_pmus(struct rapl_pmus **rapl_pmus_ptr) +static const struct attribute_group *rapl_per_core_attr_update[] = { + &rapl_events_per_core_group, +}; + +static int __init init_rapl_pmus(struct rapl_pmus **rapl_pmus_ptr, int nr_rapl_pmu, + const struct attribute_group **rapl_attr_groups, + const struct attribute_group **rapl_attr_update) { struct rapl_pmus *rapl_pmus; - int nr_rapl_pmu = topology_max_packages() * topology_max_dies_per_package(); - - if (rapl_pmu_is_pkg_scope()) - nr_rapl_pmu = topology_max_packages(); - rapl_pmus = kzalloc(struct_size(rapl_pmus, rapl_pmu, nr_rapl_pmu), GFP_KERNEL); if (!rapl_pmus) return -ENOMEM; @@ -741,7 +838,7 @@ static struct rapl_model model_snb = { BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_PP1), .msr_power_unit = MSR_RAPL_POWER_UNIT, - .rapl_msrs = intel_rapl_msrs, + .rapl_pkg_msrs = intel_rapl_msrs, }; static struct rapl_model model_snbep = { @@ -749,7 +846,7 @@ static struct rapl_model model_snbep = { BIT(PERF_RAPL_PKG) | BIT(PERF_RAPL_RAM), .msr_power_unit = MSR_RAPL_POWER_UNIT, - .rapl_msrs = intel_rapl_msrs, + .rapl_pkg_msrs = intel_rapl_msrs, }; static struct rapl_model model_hsw = { @@ -758,7 +855,7 @@ static struct rapl_model model_hsw = { BIT(PERF_RAPL_RAM) | BIT(PERF_RAPL_PP1), .msr_power_unit = MSR_RAPL_POWER_UNIT, - .rapl_msrs = intel_rapl_msrs, + .rapl_pkg_msrs = intel_rapl_msrs, }; static struct rapl_model model_hsx = { @@ -767,7 +864,7 @@ static struct rapl_model model_hsx = { BIT(PERF_RAPL_RAM), .unit_quirk = RAPL_UNIT_QUIRK_INTEL_HSW, .msr_power_unit = MSR_RAPL_POWER_UNIT, - .rapl_msrs = intel_rapl_msrs, + .rapl_pkg_msrs = intel_rapl_msrs, }; static struct rapl_model model_knl = { @@ -775,7 +872,7 @@ static struct rapl_model model_knl = { BIT(PERF_RAPL_RAM), .unit_quirk = RAPL_UNIT_QUIRK_INTEL_HSW, .msr_power_unit = MSR_RAPL_POWER_UNIT, - .rapl_msrs = intel_rapl_msrs, + .rapl_pkg_msrs = intel_rapl_msrs, }; static struct rapl_model model_skl = { @@ -785,7 +882,7 @@ static struct rapl_model model_skl = { BIT(PERF_RAPL_PP1) | BIT(PERF_RAPL_PSYS), .msr_power_unit = MSR_RAPL_POWER_UNIT, - .rapl_msrs = intel_rapl_msrs, + .rapl_pkg_msrs = intel_rapl_msrs, }; static struct rapl_model model_spr = { @@ -795,13 +892,15 @@ static struct rapl_model model_spr = { BIT(PERF_RAPL_PSYS), .unit_quirk = RAPL_UNIT_QUIRK_INTEL_SPR, .msr_power_unit = MSR_RAPL_POWER_UNIT, - .rapl_msrs = intel_rapl_spr_msrs, + .rapl_pkg_msrs = intel_rapl_spr_msrs, }; static struct rapl_model model_amd_hygon = { .pkg_events = BIT(PERF_RAPL_PKG), + .core_events = BIT(PERF_RAPL_PER_CORE), .msr_power_unit = MSR_AMD_RAPL_POWER_UNIT, - .rapl_msrs = amd_rapl_pkg_msrs, + .rapl_pkg_msrs = amd_rapl_pkg_msrs, + .rapl_core_msrs = amd_rapl_core_msrs, }; static const struct x86_cpu_id rapl_model_match[] __initconst = { @@ -858,6 +957,11 @@ static int __init rapl_pmu_init(void) { const struct x86_cpu_id *id; int ret; + int nr_rapl_pmu = topology_max_packages() * topology_max_dies_per_package(); + int nr_cores = topology_max_packages() * topology_num_cores_per_package(); + + if (rapl_pmu_is_pkg_scope()) + nr_rapl_pmu = topology_max_packages(); id = x86_match_cpu(rapl_model_match); if (!id) @@ -865,17 +969,34 @@ static int __init rapl_pmu_init(void) rapl_model = (struct rapl_model *) id->driver_data; - rapl_pkg_cntr_mask = perf_msr_probe(rapl_model->rapl_msrs, PERF_RAPL_PKG_EVENTS_MAX, + rapl_pkg_cntr_mask = perf_msr_probe(rapl_model->rapl_pkg_msrs, PERF_RAPL_PKG_EVENTS_MAX, false, (void *) &rapl_model->pkg_events); ret = rapl_check_hw_unit(); if (ret) return ret; - ret = init_rapl_pmus(&rapl_pmus_pkg); + ret = init_rapl_pmus(&rapl_pmus_pkg, nr_rapl_pmu, rapl_attr_groups, rapl_attr_update); if (ret) return ret; + if (rapl_model->core_events) { + rapl_core_cntr_mask = perf_msr_probe(rapl_model->rapl_core_msrs, + PERF_RAPL_CORE_EVENTS_MAX, false, + (void *) &rapl_model->core_events); + + ret = init_rapl_pmus(&rapl_pmus_core, nr_cores, + rapl_per_core_attr_groups, rapl_per_core_attr_update); + if (ret) { + /* + * If initialization of per_core PMU fails, reset per_core + * flag, and continue with power PMU initialization. + */ + pr_warn("Per-core PMU initialization failed (%d)\n", ret); + rapl_model->core_events = 0UL; + } + } + /* * Install callbacks. Core will call them for each online cpu. */ @@ -889,6 +1010,20 @@ static int __init rapl_pmu_init(void) if (ret) goto out1; + if (rapl_model->core_events) { + ret = perf_pmu_register(&rapl_pmus_core->pmu, "power_per_core", -1); + if (ret) { + /* + * If registration of per_core PMU fails, cleanup per_core PMU + * variables, reset the per_core flag and keep the + * power PMU untouched. + */ + pr_warn("Per-core PMU registration failed (%d)\n", ret); + cleanup_rapl_pmus(rapl_pmus_core); + rapl_model->core_events = 0UL; + } + } + rapl_advertise(); return 0; @@ -906,5 +1041,9 @@ static void __exit intel_rapl_exit(void) cpuhp_remove_state_nocalls(CPUHP_AP_PERF_X86_RAPL_ONLINE); perf_pmu_unregister(&rapl_pmus_pkg->pmu); cleanup_rapl_pmus(rapl_pmus_pkg); + if (rapl_model->core_events) { + perf_pmu_unregister(&rapl_pmus_core->pmu); + cleanup_rapl_pmus(rapl_pmus_core); + } } module_exit(intel_rapl_exit);