From patchwork Tue Jun 25 09:06:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 13710786 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 063C7C2BBCA for ; Tue, 25 Jun 2024 09:07:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9575F6B0139; Tue, 25 Jun 2024 05:07:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9078B6B0174; Tue, 25 Jun 2024 05:07:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A8C96B0176; Tue, 25 Jun 2024 05:07:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B02B6B0139 for ; Tue, 25 Jun 2024 05:07:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 03F5B1A0DCE for ; Tue, 25 Jun 2024 09:07:30 +0000 (UTC) X-FDA: 82268832702.29.92CEAA8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 482E64000E for ; Tue, 25 Jun 2024 09:07:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UPslzcWw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719306438; a=rsa-sha256; cv=none; b=doNt8GGA7nk7qZ8pWEET94USdDwi7m5mx95jI5iEPjZeu8P+Q7EXzk/txtSwlzWxOCU9Ty 9dql72uQhW88mzpwfr/nBT4VNbP4nVIdpvGnor3TzDmoJy881jbV3Ezvfr8qf3nZ6bQOtM e5eJhMEmybTf666vJR2bma1iN/sJONA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UPslzcWw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719306438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C5gIbstmYx7+hVakYhvJm3/I7jrdwPXMN2vBR3BGT10=; b=UIglOTKb+fRIRfDPD9YvaVWZkuqJ3nWmUwwt+MYgR/8xg1NoAnOrsYkQbFhWRqv6rFC/d5 RIwLi4to0MLXWuUIc490Xd2y2VemfC0LdAKDVpVAJEvlEFerG3RI+jUKdJTwqOZNmgTILe Q6jAS+g6gsf1wC7fvW90BALIYKwvdZ8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719306448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C5gIbstmYx7+hVakYhvJm3/I7jrdwPXMN2vBR3BGT10=; b=UPslzcWwahHMh9iR3bSJx5hxboKzIIMfWfqaBuqWAlrtOf1TxDQ5FpnjO9ErtaaT9sRU9U wgetP3G8Q4aJhaXNr2KRfd3rlojh7t6Aj8YW7VjsDkiOr/UNZc+TWxBMC9Aiu6FITa1EoT RVHcf8BS4tuCYP47psO2Qk/JlSlFSnY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-Qm534JkkMrG-56Hj37KU5w-1; Tue, 25 Jun 2024 05:07:20 -0400 X-MC-Unique: Qm534JkkMrG-56Hj37KU5w-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3A9931956050; Tue, 25 Jun 2024 09:07:18 +0000 (UTC) Received: from gshan-thinkpadx1nanogen2.remote.csb (unknown [10.67.24.180]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D5AC11954AC0; Tue, 25 Jun 2024 09:07:11 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com Subject: [PATCH 1/4] mm/filemap: Make MAX_PAGECACHE_ORDER acceptable to xarray Date: Tue, 25 Jun 2024 19:06:43 +1000 Message-ID: <20240625090646.1194644-2-gshan@redhat.com> In-Reply-To: <20240625090646.1194644-1-gshan@redhat.com> References: <20240625090646.1194644-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Queue-Id: 482E64000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: eewwsd47z6sbmsghmeufj448iiw7ztq9 X-HE-Tag: 1719306449-841132 X-HE-Meta: U2FsdGVkX19aksLlCWTb7BKB1O4K+P615jEenLvuA5Gc/4gG+6rwdS3JgNgWZ94fFN4kO8pLGGJe7q+HdhrJ3CAegZPQ/1TK9tueju/b1Iq59+uVzagZInBEwcfdt3qGZ2RqMZiWsAkwxM2f9nJFUIJj2DM4M12qh6ivbdd5Rkg+tkcBhgrr9mnhPvFLjIQ2lWbqJinnEqQrVAJZeaT6BTcswVLK75URlC4iFkn9qqlDfO89lAn//kvXLsKUeNG/7yOPlBZWRk/h5IQyA+nX+WITph1JZ82XSzB6dw1Ole2WvvRaVHoOB2+qDPJ0mu1Kctispk2f5R1kBIqKtY2EuS2c4BqRvNP0QuRyPu1mVkJqAcTdOXUvqqu0UUMZlrs06HBiakiD/mSkZCU8RRpk0bM8TgUUAbEyxL2Do/+2xFE8KkoQ7tWuJ1wVGdkBIoppoy02oNnq3k1nQwajev0kEwgM38wKIu+UoeFVwuR1VszsZw23rUGxw91iDivQP5YjOADSSP5tnIr7HtjCCYfL4enefx2sZ7WL4jqMdMoe1P3M0QXHfczCl8IbJhNE5borv5vLWQ8BbB7zzpSwmS/fghpF6WSV7TkU0ViU9937ZJCwxP81f6nTipJ+Aiko8VDVLapehICMD26a8ROM7Rn227Y1e4LrcKHXWhaxi6C8hS9CDjiJK5bn2qli2Avy/24Yj6Wovd75he4sNwed/BNDF6LClw4/fO4qHMj0n/eFsxuaIHAAy7K9PJKZPo4FEmmC/GmzkDbZX32T9C5tlqw7xAP+50CN2bpl2xtCWRedRaaFjv2NzjD8XL/e2niLuhBTZA0rwrm/jzIjmjpoDVUSozUmEn6NSvn7uTgn9c93wtTEiMgCrqVGFfhCJrjolmNJ+f1zKu1milLuXHoj5Tw1asGGCJJ11NvGGn5hz41beS2bvAZo7IwznFXyKj5PYy2+itB5cwz6nmU+/MggFxc qRJDatsw lybD8w7Z38qSRuPFaLoW2JENi7HQauYMF0sfdC/M8ugb2ki1bZ7AsBYVvST63IAKz3yhSz5eRQwgPfKK5SZVDZi4iiYy3mFM4iXCZTUaliieV4509i6wPIZQGzEyyIX0UOExBixS6p/z57tyLaohPeK9e1vzV6CQF+dQmXmRZRjrWgilrkIfxUsMdlQhgfo1srn2OfmW35GCEzAvBMLd6lGFiFZ95iXJW9/bd7tr8hZpdUNnrAW30VxaSS8OBJFUqhw5mwAomATq/cAciAyznNsDl4C46vjwXZL2AQ4R3Z6MODtmd1YWw83D0Q5D7qXLWf+UU+JHsAV6pIddTL+tmlPVGOmnol4LPeJwseJhRGbnKj9YMszMISan3RbXXcZwEB/z7kJFgjwH2KwFhGD5Q8C1NpkevmUHwo6xXXnNQhdBdIu379qHqpqMq9h7esy0qkchRojohj3SZrZCSP//wXRclr8iYXszAsLEDuASP3CilBx0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The largest page cache order can be HPAGE_PMD_ORDER (13) on ARM64 with 64KB base page size. The xarray entry with this order can't be split as the following error messages indicate. ------------[ cut here ]------------ WARNING: CPU: 35 PID: 7484 at lib/xarray.c:1025 xas_split_alloc+0xf8/0x128 Modules linked in: nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib \ nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct \ nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 \ ip_set rfkill nf_tables nfnetlink vfat fat virtio_balloon drm \ fuse xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 \ sha1_ce virtio_net net_failover virtio_console virtio_blk failover \ dimlib virtio_mmio CPU: 35 PID: 7484 Comm: test Kdump: loaded Tainted: G W 6.10.0-rc5-gavin+ #9 Hardware name: QEMU KVM Virtual Machine, BIOS edk2-20240524-1.el9 05/24/2024 pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : xas_split_alloc+0xf8/0x128 lr : split_huge_page_to_list_to_order+0x1c4/0x720 sp : ffff800087a4f6c0 x29: ffff800087a4f6c0 x28: ffff800087a4f720 x27: 000000001fffffff x26: 0000000000000c40 x25: 000000000000000d x24: ffff00010625b858 x23: ffff800087a4f720 x22: ffffffdfc0780000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffffdfc0780000 x18: 000000001ff40000 x17: 00000000ffffffff x16: 0000018000000000 x15: 51ec004000000000 x14: 0000e00000000000 x13: 0000000000002000 x12: 0000000000000020 x11: 51ec000000000000 x10: 51ece1c0ffff8000 x9 : ffffbeb961a44d28 x8 : 0000000000000003 x7 : ffffffdfc0456420 x6 : ffff0000e1aa6eb8 x5 : 20bf08b4fe778fca x4 : ffffffdfc0456420 x3 : 0000000000000c40 x2 : 000000000000000d x1 : 000000000000000c x0 : 0000000000000000 Call trace: xas_split_alloc+0xf8/0x128 split_huge_page_to_list_to_order+0x1c4/0x720 truncate_inode_partial_folio+0xdc/0x160 truncate_inode_pages_range+0x1b4/0x4a8 truncate_pagecache_range+0x84/0xa0 xfs_flush_unmap_range+0x70/0x90 [xfs] xfs_file_fallocate+0xfc/0x4d8 [xfs] vfs_fallocate+0x124/0x2e8 ksys_fallocate+0x4c/0xa0 __arm64_sys_fallocate+0x24/0x38 invoke_syscall.constprop.0+0x7c/0xd8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1d8 el0t_64_sync_handler+0x134/0x150 el0t_64_sync+0x17c/0x180 Fix it by decreasing MAX_PAGECACHE_ORDER to the largest supported order by xarray. For this specific case, MAX_PAGECACHE_ORDER is dropped from 13 to 11 when CONFIG_BASE_SMALL is disabled. Fixes: 4f6617011910 ("filemap: Allow __filemap_get_folio to allocate large folios") Cc: stable@kernel.org # v6.6+ Suggested-by: David Hildenbrand Signed-off-by: Gavin Shan Acked-by: David Hildenbrand --- include/linux/pagemap.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 59f1df0cde5a..a0a026d2d244 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -354,11 +354,18 @@ static inline void mapping_set_gfp_mask(struct address_space *m, gfp_t mask) * a good order (that's 1MB if you're using 4kB pages) */ #ifdef CONFIG_TRANSPARENT_HUGEPAGE -#define MAX_PAGECACHE_ORDER HPAGE_PMD_ORDER +#define PREFERRED_MAX_PAGECACHE_ORDER HPAGE_PMD_ORDER #else -#define MAX_PAGECACHE_ORDER 8 +#define PREFERRED_MAX_PAGECACHE_ORDER 8 #endif +/* + * xas_split_alloc() does not support arbitrary orders. This implies no + * 512MB THP on ARM64 with 64KB base page size. + */ +#define MAX_XAS_ORDER (XA_CHUNK_SHIFT * 2 - 1) +#define MAX_PAGECACHE_ORDER min(MAX_XAS_ORDER, PREFERRED_MAX_PAGECACHE_ORDER) + /** * mapping_set_large_folios() - Indicate the file supports large folios. * @mapping: The file. From patchwork Tue Jun 25 09:06:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 13710787 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073F3C2BBCA for ; Tue, 25 Jun 2024 09:07:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 930F86B02F6; Tue, 25 Jun 2024 05:07:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0A66B02F9; Tue, 25 Jun 2024 05:07:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 781626B02FA; Tue, 25 Jun 2024 05:07:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 59FBF6B02F6 for ; Tue, 25 Jun 2024 05:07:36 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 14B4BC0D4D for ; Tue, 25 Jun 2024 09:07:36 +0000 (UTC) X-FDA: 82268832912.02.3CB3EA0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 3D005180011 for ; Tue, 25 Jun 2024 09:07:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJm6pQ3z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719306442; a=rsa-sha256; cv=none; b=RZPUqYJgEEtgP4eel84/yzqv49945HnBOu1LX6IlEW0vyys+rdo57J1gTOl9vwA7UJ/yCc oEb/uDGwWz65QoaZTujJdlKrEz6Z+sDXYgfk/G0sbq+LyCD5fVIDSfR1uL/ULoWNKtdB1G yBAXDvuzLfa/jc6RF2pIYR+A/6R6Nzg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gJm6pQ3z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719306442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mpTFKwtZMDnLyGvHe5Gpx78ZwRB1TPy/HybiDm8shcc=; b=oAcFMDFtXw7OuwgDl3p9BMyeq/6dMOnaiWn9oCIObWdgztOG6el4KHYgYJXtqE5fSPlhSo aJi4zgQ/EHxl3xGQXrS66nN3znIw/ym2B8pGOidcpiL13JzzvVFLOyjScHdVEGEI5waqy0 4a/gYoTu14fzrjYnZ8tPo9NlBKfeQf0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719306453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mpTFKwtZMDnLyGvHe5Gpx78ZwRB1TPy/HybiDm8shcc=; b=gJm6pQ3zNyP0PYIhgWTr/Fs9IXdkfPO4ezj4FxXsIu7IEPEgwoLFC2XgKLFApI3NSJZLjr CueDFgY5GJTC53uCmdS6mi/jru7MeuE2Na+o2Z16B5jow+PgUtzhIslQJ+dd8x1jlmJJu0 isPrpq6CR2bZikEN5hrhtuLNnK7Z0vQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-Juu5SSqfP5-ZJJFPS-5imA-1; Tue, 25 Jun 2024 05:07:27 -0400 X-MC-Unique: Juu5SSqfP5-ZJJFPS-5imA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 719781955E80; Tue, 25 Jun 2024 09:07:25 +0000 (UTC) Received: from gshan-thinkpadx1nanogen2.remote.csb (unknown [10.67.24.180]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1EBA11954AC0; Tue, 25 Jun 2024 09:07:18 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com Subject: [PATCH 2/4] mm/filemap: Skip to allocate PMD-sized folios if needed Date: Tue, 25 Jun 2024 19:06:44 +1000 Message-ID: <20240625090646.1194644-3-gshan@redhat.com> In-Reply-To: <20240625090646.1194644-1-gshan@redhat.com> References: <20240625090646.1194644-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3D005180011 X-Stat-Signature: 1wut73apatksyqcaxzz9jxoycwinr354 X-Rspam-User: X-HE-Tag: 1719306454-590276 X-HE-Meta: U2FsdGVkX19UWYz3cxR2wvKgMnHMAp6knbckPzJ6WH1SeL4InSJWNELrNJv26VU9S3S8SDQIMJ2LPxeSj3Kpc1QNtU9HIztVVZJyKtWuQDeht0RLmkIjhA0FFrMgkKunGpHr0AD6duiLr4r1Koka/NquRJhLglkk62BfdDKuPMdOhDdfGBHV5R/WCD9McZ+urqhP8DRN+s/w/bjT2bERtYK5wLAo6VwQn/kapv9CS2cz0NlABi4QWDKpIHH/CkSLa40MyIIRvC9FcQBiR1d78BTpSW85hbUgtbFAJ4VfdeaaQaQc2b/L39CFNzwLTAFo5PjZnZuOFoo/7W4QoJsZHJX+AcVfCx8bWdNw5hOCUPBar9iReYetU/zbERnLqukhYPIYO8vErI1LKzu7lIeVk8K5Q10ZiMQdQAFtjAuSWwSQhxrorO6DrPpWfvdv/o6MMCv1rexH3r+04YV/uTAuI01beECdz7PntZSOnmFSu+D5+fzWCyp1ilduw+AlQFsmhIUr38BtY0jv1cVWvvrlDG8VsUkLnbzdDjfRHkEAd1AWjViJqUsh6Gjvk+QinGuXuTuzv9tqlF4a3RKyeUprpZ97D5sMLprGmu8NxlYRAI8z52Ma1aFbPDPNN7Mm1SnosTlZI/aGrf+0mcRbNfMQllpQcR9mE/Gpd8H9DTzw5cWqSjgLCOoHNRq/igXBLM+i8Cv1Lc4G5KWGroL6ciECQwyixuCdfXa7MDy8Iz0MYy8x8z6LcxvHUgVJTVyyWnIRxfLOyi55WDrnJqT1g1C/RQ955y9XmKgX4QJxBG2zc8oePjF68f12L2meHhjdTMI0yffJwbzPdygpycZcvM8alkB+Ca0XaXugqEeQTfj7gjHmC78hH7r5ESg+5KlOTXYWGFNdBDn22gPMG5JcuKov8W+HLMIbo1NpKaEIak+upvnrm9TF28XmL6qP+gQOBebh/eMMyycMA9bF51a7T2+ aPeJjzYQ kFiu2isKFW9qIH2rBeMr9eYYJq/ztDf997p+BXvfVSM16TAPd1xxnvhlB6qGA+MB0LhvY9EXgYahe/YQHnPj03pNK2we/iIh6v6pQ8EFcBhQKi15aE9LgUE8CkSsxgof7BHZLtlYmLWglz+xiFhfgLDTTw5PVVx4vDuRDXCYTzwklwJaZvUFVhUobKT4B7zN0YIWwXakgOepQJuuh5NeGN9C+XKaWf047oFR3KzZS6JEJ/cmCoLu1jfEKxUq+ki4T8QhlCBAV0ivlU1tAKNL9Kx+mC5HIwZ/6FnqvVCQFka9K2JHr/IszxqNh4PhD4sN0Al7B3cc1MMTWH7fWrEkLKC7sBuAI0U/3PoRc2i9FffkU92VpP53LDVxUWDt5Sl/qAeVWoTzTp5G91dY0PNgizpiRrLmuiXvUWWgBR8n1Ff2430rLSQcrNkp3+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On ARM64, HPAGE_PMD_ORDER is 13 when the base page size is 64KB. The PMD-sized page cache can't be supported by xarray as the following error messages indicate. ------------[ cut here ]------------ WARNING: CPU: 35 PID: 7484 at lib/xarray.c:1025 xas_split_alloc+0xf8/0x128 Modules linked in: nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib \ nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct \ nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 \ ip_set rfkill nf_tables nfnetlink vfat fat virtio_balloon drm \ fuse xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 \ sha1_ce virtio_net net_failover virtio_console virtio_blk failover \ dimlib virtio_mmio CPU: 35 PID: 7484 Comm: test Kdump: loaded Tainted: G W 6.10.0-rc5-gavin+ #9 Hardware name: QEMU KVM Virtual Machine, BIOS edk2-20240524-1.el9 05/24/2024 pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : xas_split_alloc+0xf8/0x128 lr : split_huge_page_to_list_to_order+0x1c4/0x720 sp : ffff800087a4f6c0 x29: ffff800087a4f6c0 x28: ffff800087a4f720 x27: 000000001fffffff x26: 0000000000000c40 x25: 000000000000000d x24: ffff00010625b858 x23: ffff800087a4f720 x22: ffffffdfc0780000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffffdfc0780000 x18: 000000001ff40000 x17: 00000000ffffffff x16: 0000018000000000 x15: 51ec004000000000 x14: 0000e00000000000 x13: 0000000000002000 x12: 0000000000000020 x11: 51ec000000000000 x10: 51ece1c0ffff8000 x9 : ffffbeb961a44d28 x8 : 0000000000000003 x7 : ffffffdfc0456420 x6 : ffff0000e1aa6eb8 x5 : 20bf08b4fe778fca x4 : ffffffdfc0456420 x3 : 0000000000000c40 x2 : 000000000000000d x1 : 000000000000000c x0 : 0000000000000000 Call trace: xas_split_alloc+0xf8/0x128 split_huge_page_to_list_to_order+0x1c4/0x720 truncate_inode_partial_folio+0xdc/0x160 truncate_inode_pages_range+0x1b4/0x4a8 truncate_pagecache_range+0x84/0xa0 xfs_flush_unmap_range+0x70/0x90 [xfs] xfs_file_fallocate+0xfc/0x4d8 [xfs] vfs_fallocate+0x124/0x2e8 ksys_fallocate+0x4c/0xa0 __arm64_sys_fallocate+0x24/0x38 invoke_syscall.constprop.0+0x7c/0xd8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1d8 el0t_64_sync_handler+0x134/0x150 el0t_64_sync+0x17c/0x180 Fix it by skipping to allocate PMD-sized page cache when its size is larger than MAX_PAGECACHE_ORDER. For this specific case, we will fall to regular path where the readahead window is determined by BDI's sysfs file (read_ahead_kb). Fixes: 4687fdbb805a ("mm/filemap: Support VM_HUGEPAGE for file mappings") Cc: stable@kernel.org # v5.18+ Suggested-by: David Hildenbrand Signed-off-by: Gavin Shan Acked-by: David Hildenbrand --- mm/filemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index 876cc64aadd7..b306861d9d36 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3124,7 +3124,7 @@ static struct file *do_sync_mmap_readahead(struct vm_fault *vmf) #ifdef CONFIG_TRANSPARENT_HUGEPAGE /* Use the readahead code, even if readahead is disabled */ - if (vm_flags & VM_HUGEPAGE) { + if ((vm_flags & VM_HUGEPAGE) && HPAGE_PMD_ORDER <= MAX_PAGECACHE_ORDER) { fpin = maybe_unlock_mmap_for_io(vmf, fpin); ractl._index &= ~((unsigned long)HPAGE_PMD_NR - 1); ra->size = HPAGE_PMD_NR; From patchwork Tue Jun 25 09:06:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 13710788 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89693C2BBCA for ; Tue, 25 Jun 2024 09:07:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DD626B02FA; Tue, 25 Jun 2024 05:07:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18E2E6B02FB; Tue, 25 Jun 2024 05:07:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 055016B02FD; Tue, 25 Jun 2024 05:07:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DBDC26B02FA for ; Tue, 25 Jun 2024 05:07:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 618A41616F9 for ; Tue, 25 Jun 2024 09:07:43 +0000 (UTC) X-FDA: 82268833206.24.C1DB8D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id A735F100008 for ; Tue, 25 Jun 2024 09:07:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EWOtKHMe; spf=pass (imf14.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719306454; a=rsa-sha256; cv=none; b=r8IbpiOPwQp1574KMH7keywgdC5oXtEj52QCoNcFLNBvRLrhsB27645gWeIAujQDKfMrCU M7sXOWjUQ1gzwxvm8hA0RNBml/5a7c3R4RnffC9dkGJTRkO7OGLOyagl1cwIfZwfur4U6L hhClc3BZRufCiIR09e2sibp6xQCdlGA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EWOtKHMe; spf=pass (imf14.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719306454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ptlUNcO5mIabfV9LABSh8DDvNkvRbhBbpL84ksizTYg=; b=ObSN2bYXiBxHeIdpGp5s/zPvm+bxqwJKSwchAxLwOJ1AnW8EnifDqUCekSEpSeVbKsPJmI o/5iFCfjGYsjQOBdT8DSkmPml+IsY+ULWl8Nn+R+rzo+d7choO/Bg3aUsov+zkBR6VcsPe L3Skg8CSd3Ap38tagTIKhs0i4HGdgy0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719306461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ptlUNcO5mIabfV9LABSh8DDvNkvRbhBbpL84ksizTYg=; b=EWOtKHMeK0G21PUNyo/389w4El6r6jDAv+5a3EwLSZXfkKLUCtJO2QIgOAhkLNFh7ujBsC kizSgV5g6dvSnEiL/wCCDplrXcVE8Mow2da2s151wqLlMUnFhCAISytzdCz5HmYd1/wPPi mmayMvs3arQDynARvribTBy52a4vb2g= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-yOuNp3xGN_WdXUTuwYLdhg-1; Tue, 25 Jun 2024 05:07:35 -0400 X-MC-Unique: yOuNp3xGN_WdXUTuwYLdhg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 397DE19560AD; Tue, 25 Jun 2024 09:07:33 +0000 (UTC) Received: from gshan-thinkpadx1nanogen2.remote.csb (unknown [10.67.24.180]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A8801956087; Tue, 25 Jun 2024 09:07:25 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com Subject: [PATCH 3/4] mm/readahead: Limit page cache size in page_cache_ra_order() Date: Tue, 25 Jun 2024 19:06:45 +1000 Message-ID: <20240625090646.1194644-4-gshan@redhat.com> In-Reply-To: <20240625090646.1194644-1-gshan@redhat.com> References: <20240625090646.1194644-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Stat-Signature: tkae6iuqoiqs95s8joozm9juxuw5aofa X-Rspamd-Queue-Id: A735F100008 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719306461-705064 X-HE-Meta: U2FsdGVkX1+adTikMDwok2FeAoU4tr2iAJubHL85Z3/hS4SiB3jtNbbOnHr012gUnpa5iWnOWB/HcTue/fOTTjuUhABy+QRT8fu4+KLhRWT41EtVHhuQbrIgcUQN5yflNsen+hIM4W4wp5yBWNPCfm16vghG8DkPAO4KjSxunvLobQW4x/wgOKUeeuFf3hm6U2ydo3qtqQ6/Px4LXkzR84FPP26OKN/NB41hJfcM+/ek8Lu712SxZHi/EXyka5huzvOqfGSmnF74MTCgIo8lnl1YgWJBDclHX3ifjEMDAtyViuvKkAvN/Sit8zxwnlnExQcKGHky6eS+MLz++wqXVNEXMrXyZ8uqpJRC9R6wI+8xZUbt7Eui6Fql3o2ye4vs3Yd8PRPz0CUpGqkyhFl0yJLhVSCBaz8mWutzpE4ftlmM5M9u6//VEVaA/4AHWOpbiyaxqD4XSQyiWXr3pXfBMUfDKVG4s16i7P6FsNRKEOVGvLB297W70uNNXFxgfMXNVXO+/M96FS5ylBfnc28dOq9bMsWlyxJ5pQaXDZ+A5zreMR4xT/d+zlS3JAiSHuXfpCgFlCObOKPZ31nCLjKdza6A6qhoxtQcq9wU9YvfrJMMUmzutErESyR3Neq4zXxPbiwV9gYeWMLd43pd1emlaOugHcqyam4OrIEGjzy3Ro/1U5zdnerOHSImdOwkSr/i9RHEUUxkSXdQ+QD6IKkE4F0DWRQVDW3w4ytXStyt8QRucZEqlntpQ2LJl64AQpq9KZj6xBi8rso0Oj4nQ8/DlFlm/DqDI1RfsnHbzcJbrnzOqvsWPfzashCG5mdPZiq0b2eOA4Jf9u5+EyBqNmMFJycS9HFs85YVE6mh0FXQ1hiQBhZ2oSrsvIAK/4G0XDNGynsGc18sIcbI2u2itY6xk8ryx2TM1/xUheHvP3GtgYwbUvr2l1FoL2VUoM9DXXpPGd8OPF6Fb7xpStq2q+q NkeJ85gr CIYKylSGbxGdqM66ExpnTjuVs79PC0pTW7R0BW9GshpzVxlg/FNEM3OxHGrPf13uk86bbFmLeLJnH2ieremokbS1HDoOvNgB2e2s4BNQcNOhpaxFO09ipQL6umglgCwiDi5HohV6m6tUfb1QsWSpMPF/p6BdrGvtjXfYWGkH21e4JZVvIAwtPg4/OA5BtHYbvm0M2deGICBpnmhbkLxnMfEBTGbCkkqvdSAdDc1xllim2cE9I5C5IuO1laxy7HtzWdLUIu7IV+ioppgpWeuIyHY9F3dbMAiUh9jsip1Jd46n8lqNA/igeDSVRFAYPMCKTC6awUJzKJa7gKBS/ihfQba90zj5mHAl9CBxb8akxndNwEeAzlHnLyXu9qvwL+ku1902JpdPh0irhMMsI1XDatlOFf0+p7j2x0OJr8eIXTcVxl+s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In page_cache_ra_order(), the maximal order of the page cache to be allocated shouldn't be larger than MAX_PAGECACHE_ORDER. Otherwise, it's possible the large page cache can't be supported by xarray when the corresponding xarray entry is split. For example, HPAGE_PMD_ORDER is 13 on ARM64 when the base page size is 64KB. The PMD-sized page cache can't be supported by xarray. Suggested-by: David Hildenbrand Signed-off-by: Gavin Shan Acked-by: David Hildenbrand --- mm/readahead.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/readahead.c b/mm/readahead.c index c1b23989d9ca..817b2a352d78 100644 --- a/mm/readahead.c +++ b/mm/readahead.c @@ -503,11 +503,11 @@ void page_cache_ra_order(struct readahead_control *ractl, limit = min(limit, index + ra->size - 1); - if (new_order < MAX_PAGECACHE_ORDER) { + if (new_order < MAX_PAGECACHE_ORDER) new_order += 2; - new_order = min_t(unsigned int, MAX_PAGECACHE_ORDER, new_order); - new_order = min_t(unsigned int, new_order, ilog2(ra->size)); - } + + new_order = min_t(unsigned int, MAX_PAGECACHE_ORDER, new_order); + new_order = min_t(unsigned int, new_order, ilog2(ra->size)); /* See comment in page_cache_ra_unbounded() */ nofs = memalloc_nofs_save(); From patchwork Tue Jun 25 09:06:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 13710789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA18AC2BBCA for ; Tue, 25 Jun 2024 09:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44DED6B0202; Tue, 25 Jun 2024 05:07:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FFBD6B0203; Tue, 25 Jun 2024 05:07:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C70F6B0204; Tue, 25 Jun 2024 05:07:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0EC276B0202 for ; Tue, 25 Jun 2024 05:07:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B5C48120889 for ; Tue, 25 Jun 2024 09:07:46 +0000 (UTC) X-FDA: 82268833332.08.4A465CA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 0689A120016 for ; Tue, 25 Jun 2024 09:07:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GV6qY0rY; spf=pass (imf29.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719306453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CGvYW01hrriXIF+o1pxrfngY25C2k8nRiGAXWHuPddk=; b=WFASLoNZ4nBFs3GxtoPa0ivc4xrIJemMLm7txgdUlllbK7bwUocA5hPOwhPWWfYouJM2Ah TVdX4JYIyonyz9rPxNl1vIDC0gzTse/ybnXreA0/BcsiWq/QiLChyTluhFQinZUornZprG 3TynlDyAIvMs99MYDgENiGmWh1eKQ6Y= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GV6qY0rY; spf=pass (imf29.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719306453; a=rsa-sha256; cv=none; b=cv5pEywy9x/W8sAoPossEqZnYZbgU/hUgs+Pl7pTgDCN4eoeGWiLPT08YX3blEMtph3bfj BntyF2eF08Qo8u/LNPcwVvO+YhJfeSDGNrRbbmWwhC7e4UevtzI7WdtJ6prE4ZKFytVUP3 PTckdn1odA+q3OSugjqrsiqgV2BjHfE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719306464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CGvYW01hrriXIF+o1pxrfngY25C2k8nRiGAXWHuPddk=; b=GV6qY0rYm+835gmBgxQZ6I9Rs+zD2iP5qZdWokWdDaUM5bAmwiSAlU9JqJKUITkQdTd9Bq FJw6cyYBVEhQNKleWJFbFmJOv5+BRl55F8dQIZWkzfWZLKOa9qXu6Ynt1EW9YFDLiCUAkT 5IRdxvggZB1v99O6yiFMg1AK6z3LhYI= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-6AGImXKrPlyqhXgDXD6VTQ-1; Tue, 25 Jun 2024 05:07:41 -0400 X-MC-Unique: 6AGImXKrPlyqhXgDXD6VTQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 36A681955DCE; Tue, 25 Jun 2024 09:07:40 +0000 (UTC) Received: from gshan-thinkpadx1nanogen2.remote.csb (unknown [10.67.24.180]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 282E41956087; Tue, 25 Jun 2024 09:07:33 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com Subject: [PATCH 4/4] mm/shmem: Disable PMD-sized page cache if needed Date: Tue, 25 Jun 2024 19:06:46 +1000 Message-ID: <20240625090646.1194644-5-gshan@redhat.com> In-Reply-To: <20240625090646.1194644-1-gshan@redhat.com> References: <20240625090646.1194644-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Stat-Signature: k8ugkq9ogtma1wsquyes9xpqg4u8ds8e X-Rspam-User: X-Rspamd-Queue-Id: 0689A120016 X-Rspamd-Server: rspam02 X-HE-Tag: 1719306464-641401 X-HE-Meta: U2FsdGVkX18Q+6MyXdWDI1lneOVsut1scJ/bPsndgw5itp1rV5UrVXX0rlca8t7wqz3LIdCS1Hn6rVapRWYZn2l+ci2ULQnr3ppx1ScWKVE/Flkg28n8G8N+FfkRGLdLRRK+nsszSXtFOkjqINa7eX63mOZWlIhmtu6h3OLIG36mY0pLFiWWZrKr+fMtJ5iZdcVmVfRVfprw6pbia34pVSb+nZ5zItlWE/ZZ+/2ii24iqJfh1LgrsFVaxWraVmJg3dpVHUN+GnxDiNgT2KOEs/Tt0X/y6rcUtmYE8ULtuJtji4RWdVSOEP5cJkZ/qfAZ5fkmnHivkr/t4SXcUP6MRAQ6JhkLKVOcO55vsNmpPbQPy8CadkqDs5n8MwN6c8e+XZma/ghjKG2ArwGA4oUMN3L75NBnsamOlaz9cvs+lDSFEfFC/wrGDhPV++BYZ6SLrK8TgD2EpVAnGsF3pCI/OzAXUKJ5RwzR0ORasW+NkSA+RBdwbBBt4kZLpS84FxkQz4NhUjGPH2ahcr3HUGzrmrqvpUsOXrjmSlLImlD4W3gqDjuzh+QFaLI9eqfhiI8TmZTQzucdgejOOgV75/g/BzFBhteJsHT+6zYJIrzGV5ZUn2DMU33QT/vRfyNTnlVxlBSoQxhMZ6u+l58uUwtW+K6+BRRgU1QSr6sCfSXh6L9b5LJRv5uEp0IReRCncQH8vg9pFPpjDxW6WTXHFSd9KRJNcWNTnD1Z40Ctww8CogE74R7Tp5J+ObaieOjdi4hCejte0++pLchppEUdTZSjLgNmdWFd83xK0QtnjRN6E5FAezzOpfTA1TGgDOeoQ4RTDhzr2zeM67lWfz6c4Hjwvyy/yq0U+8GYwkw4yTI8ZP92gm0GGhjwGobZxFDoREnDeKWrwMQeyWqBSl8zdlA4B9oUBIOW8GFFE/WFUe89rbVEymOmwZfzWWwle+dGtuNG3QmgNms8DSaGUBWrZLK g7sQzfr9 aVxwx57o2ETrcO5X+wxed4AYsDQGemkdJ6ImF8uj+kGQ3YiJWktipdKLKIQ0JJaRsXZgL/8p6kiYf8w4n+mQjJdkfjBkcvvJNiZ3of23oK0L0n9FZFVw8wOow8SwA5TlRxYuBCtar1NMvzDhWSgtaIBCsfI965cG3nwm6dTr/P5yWigOV7Y+6AJAm761xCrTcXL5eIoI4898tQHlLJDXxYdDhYCmIFs1hLgISTaSfXF6SSHbwHirTiSm3SBRYO/6A9diZeh0t1S1wKix2dwYnU4JICtgGodTG09Qul9FcQsX1JTXlta5omRGj+u4OqOxm53MFzL9JtHwHUoi7bSzunIQ8e0yiNoZSZ1bMd95k0BGpRBlEqFAVbaM9siOJQgcL6+Lt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For shmem files, it's possible that PMD-sized page cache can't be supported by xarray. For example, 512MB page cache on ARM64 when the base page size is 64KB can't be supported by xarray. It leads to errors as the following messages indicate when this sort of xarray entry is split. WARNING: CPU: 34 PID: 7578 at lib/xarray.c:1025 xas_split_alloc+0xf8/0x128 Modules linked in: binfmt_misc nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 \ nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject \ nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 \ ip_set rfkill nf_tables nfnetlink vfat fat virtio_balloon drm fuse xfs \ libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce virtio_net \ net_failover virtio_console virtio_blk failover dimlib virtio_mmio CPU: 34 PID: 7578 Comm: test Kdump: loaded Tainted: G W 6.10.0-rc5-gavin+ #9 Hardware name: QEMU KVM Virtual Machine, BIOS edk2-20240524-1.el9 05/24/2024 pstate: 83400005 (Nzcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) pc : xas_split_alloc+0xf8/0x128 lr : split_huge_page_to_list_to_order+0x1c4/0x720 sp : ffff8000882af5f0 x29: ffff8000882af5f0 x28: ffff8000882af650 x27: ffff8000882af768 x26: 0000000000000cc0 x25: 000000000000000d x24: ffff00010625b858 x23: ffff8000882af650 x22: ffffffdfc0900000 x21: 0000000000000000 x20: 0000000000000000 x19: ffffffdfc0900000 x18: 0000000000000000 x17: 0000000000000000 x16: 0000018000000000 x15: 52f8004000000000 x14: 0000e00000000000 x13: 0000000000002000 x12: 0000000000000020 x11: 52f8000000000000 x10: 52f8e1c0ffff6000 x9 : ffffbeb9619a681c x8 : 0000000000000003 x7 : 0000000000000000 x6 : ffff00010b02ddb0 x5 : ffffbeb96395e378 x4 : 0000000000000000 x3 : 0000000000000cc0 x2 : 000000000000000d x1 : 000000000000000c x0 : 0000000000000000 Call trace: xas_split_alloc+0xf8/0x128 split_huge_page_to_list_to_order+0x1c4/0x720 truncate_inode_partial_folio+0xdc/0x160 shmem_undo_range+0x2bc/0x6a8 shmem_fallocate+0x134/0x430 vfs_fallocate+0x124/0x2e8 ksys_fallocate+0x4c/0xa0 __arm64_sys_fallocate+0x24/0x38 invoke_syscall.constprop.0+0x7c/0xd8 do_el0_svc+0xb4/0xd0 el0_svc+0x44/0x1d8 el0t_64_sync_handler+0x134/0x150 el0t_64_sync+0x17c/0x180 Fix it by disabling PMD-sized page cache when HPAGE_PMD_ORDER is larger than MAX_PAGECACHE_ORDER. Suggested-by: David Hildenbrand Signed-off-by: Gavin Shan Acked-by: David Hildenbrand --- mm/shmem.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index a8b181a63402..5453875e3810 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -541,8 +541,9 @@ static bool shmem_confirm_swap(struct address_space *mapping, static int shmem_huge __read_mostly = SHMEM_HUGE_NEVER; -bool shmem_is_huge(struct inode *inode, pgoff_t index, bool shmem_huge_force, - struct mm_struct *mm, unsigned long vm_flags) +static bool __shmem_is_huge(struct inode *inode, pgoff_t index, + bool shmem_huge_force, struct mm_struct *mm, + unsigned long vm_flags) { loff_t i_size; @@ -573,6 +574,16 @@ bool shmem_is_huge(struct inode *inode, pgoff_t index, bool shmem_huge_force, } } +bool shmem_is_huge(struct inode *inode, pgoff_t index, + bool shmem_huge_force, struct mm_struct *mm, + unsigned long vm_flags) +{ + if (!__shmem_is_huge(inode, index, shmem_huge_force, mm, vm_flags)) + return false; + + return HPAGE_PMD_ORDER <= MAX_PAGECACHE_ORDER; +} + #if defined(CONFIG_SYSFS) static int shmem_parse_huge(const char *str) {