From patchwork Fri Mar 1 12:20:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 10835161 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 28C34922 for ; Fri, 1 Mar 2019 12:26:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15B592E4D4 for ; Fri, 1 Mar 2019 12:26:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 070F72E518; Fri, 1 Mar 2019 12:26:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AB68C2E4D4 for ; Fri, 1 Mar 2019 12:26:30 +0000 (UTC) Received: from localhost ([127.0.0.1]:36765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzhFF-0002sb-PP for patchwork-qemu-devel@patchwork.kernel.org; Fri, 01 Mar 2019 07:26:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzh9m-0007FM-0d for qemu-devel@nongnu.org; Fri, 01 Mar 2019 07:20:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzh9l-00009g-3I for qemu-devel@nongnu.org; Fri, 01 Mar 2019 07:20:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38820) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gzh9j-00006D-7v; Fri, 01 Mar 2019 07:20:47 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A303CF636; Fri, 1 Mar 2019 12:20:46 +0000 (UTC) Received: from thuth.com (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id B96FA619F2; Fri, 1 Mar 2019 12:20:41 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, Kevin Wolf , Max Reitz , Stefan Hajnoczi Date: Fri, 1 Mar 2019 13:20:29 +0100 Message-Id: <1551442829-32359-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 01 Mar 2019 12:20:46 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] tests/qemu-iotests/235: Allow fallback to tcg and remove it from quick group X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP iotest 235 currently only works with KVM - this is bad for systems where it is not available, e.g. CI pipelines. The test also works when using "tcg" as accelerator, so we can simply add that to the list of accelerators, too. But still, there might be the case that someone compiled their QEMU with --disable-tcg and still try to run the iotests in a CI pipeline where KVM is not available - in that case it would be best to use the "qtest" accelerator for this test. However, that currently hangs and I did not succeed to get it working with "accel=qtest" yet. Thus, as long as this is not fixed, it's likely better to remove this test from the "quick" group so that it does not fail on CI pipelines. Signed-off-by: Thomas Huth --- tests/qemu-iotests/235 | 2 +- tests/qemu-iotests/group | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235 index d6edd97..90ef785 100755 --- a/tests/qemu-iotests/235 +++ b/tests/qemu-iotests/235 @@ -49,7 +49,7 @@ qemu_img_create('-f', iotests.imgfmt, '-o', 'preallocation=metadata', disk, str(size)) vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm') +vm.add_args('-machine', 'accel=kvm:tcg') if iotests.qemu_default_machine == 's390-ccw-virtio': vm.add_args('-no-shutdown') vm.add_args('-drive', 'id=src,file=' + disk) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index b5ca63c..12ebeba 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -234,7 +234,7 @@ 232 auto quick 233 auto quick 234 auto quick migration -235 auto quick +235 auto 236 auto quick 237 rw auto quick 238 auto quick