From patchwork Thu Jun 27 07:58:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leith Bade X-Patchwork-Id: 13713912 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF207C2BD09 for ; Thu, 27 Jun 2024 08:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BkBpPkBgBA3ODAja8zGIcwpt50GSoIUtolN0QhQXZcQ=; b=AWHApiVDKGiq5QCiwFbqiZpDG9 QwNRyeXabagXBnXEg3qKWqQT+cuLJ7jcKQNLpNBtDVLltl+LDXsfWtMvSTo9bUQzGgS09jFFyu69W 5FF9vquiiBfLzndlDJOhIJtt9F3q/mo+27S1Qs0IpYhE+dVDFaaXGyhmbCBsIshaK0zeyc+jOWwDj zqSZeCZZsPkAFStrjqel0bfgxZqGjnSXKkjmi++p6GN7KejWPDqu2QvjRf9tAPZCV7+MiBvBb57qp sSsTKfiCsrGT/5bBWHxwcvZxU3QyWZJcnsb9G2vGaop7d9FtYWO2jL0MvVfPP9mVZRm54lki5hUi5 5aFgrL8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk2y-00000009eu8-2LM3; Thu, 27 Jun 2024 08:00:00 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk2f-00000009epk-1bW3 for linux-mediatek@lists.infradead.org; Thu, 27 Jun 2024 07:59:52 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-711b1512aeaso5924882a12.3 for ; Thu, 27 Jun 2024 00:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bade.nz; s=google; t=1719475180; x=1720079980; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BkBpPkBgBA3ODAja8zGIcwpt50GSoIUtolN0QhQXZcQ=; b=cSkM3OqX5+tCsQWTgXqKv9xVMv/c8Vt33Z0kkgiy+pHLLC+cgKHaqk6iQToyGG/0o2 1Uj7Hq1f44DTSt8BGl63shuMbLDJN84w/g+pe1oXKnKloz1G5JPR9Gemj6n3lL7Bsn/P YGxybvcpcKVKUpr1JraGFH35x8pRvRKLsD7gLIVmyLl0jIhgtJYUCkjlrMSnuG9+hZvz 0PyYON+ct5cmDG1lGIQwJeuSjNWkFuhj8fJxNSH0WhSyJTbS2mr95vF3u+enWIooiMjv j9VdY3FM3pnzgfBqWDK/IwiCmYGndfWQHVMh/8FYHedw6V3gggjAnOpoELm7bqAqNfEq E/vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719475180; x=1720079980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BkBpPkBgBA3ODAja8zGIcwpt50GSoIUtolN0QhQXZcQ=; b=O49WSvytWY6s1JphzOEfCbLywJw8zIexqVGzs+n2+0s3dWJUyuA5T6g7xlElpE/n0Q 145D1FeUEC3wEQZiEuLSGJOTN66ppoAPm1MgLgvohTGBKsYZ2y5/QgO7JQIz56bFUNFw W1OuwRwkRzGDP5/nUZcO4noEtw4r/zU7dhcKm1305UTv0AWM3PyLh8CP4lgkUzSnjEKj qQpw+lPFedNXA/u7flxyOuu9O9JowCwniz/c4vdF20/LJGMPWXe5Ov2wVoyO4Svtsj28 1BSihr1oTOBiCH/EtenYi6ZLvcnc7BihWoS+KQGGUOWfc3ygNZojNXsku+W1Pl+Cl4r6 U3DA== X-Forwarded-Encrypted: i=1; AJvYcCVq738WPRSA3ESilIKz5Quh/6+mLgvGGf5VGfIlOAjVHHRMYhEQLPEczqQ68Eam+FriavCD+x7xLMilWE9ayFpgiMlBBYkSjrch/Dm5lmIrBgSE X-Gm-Message-State: AOJu0YzrJsWZvf71iCxA9sVa+X2XDKAAtopEhcrGf4y1uGWoMoMBuyzk CRHlpJnP5FWQXefaMQ6mxGxo3cJA8OdGH8UyDBeFTvMRMdVVHTTFYi0WiN03Qw== X-Google-Smtp-Source: AGHT+IEXToHGxpVGoEz8ifOQW7GTguBEcp/knYddtQGBeIRtKWqgX5quU9fqgATZlNifTQih+UOzCA== X-Received: by 2002:a05:6a20:b2a9:b0:1be:c2af:5626 with SMTP id adf61e73a8af0-1bec2af566dmr2984750637.4.1719475179932; Thu, 27 Jun 2024 00:59:39 -0700 (PDT) Received: from localhost.localdomain ([2403:5816:cd6c:0:6d45:ae2f:1ead:bd58]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1faac9c4cf4sm7181895ad.290.2024.06.27.00.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 00:59:39 -0700 (PDT) From: Leith Bade To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, frank-w@public-files.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, didi.debian@cknow.org, Leith Bade Subject: [PATCH 1/4] arm64: dts: mediatek: mt7986: fix the switch reset line on BPI-R3 Date: Thu, 27 Jun 2024 17:58:53 +1000 Message-Id: <20240627075856.2314804-2-leith@bade.nz> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240627075856.2314804-1-leith@bade.nz> References: <20240627075856.2314804-1-leith@bade.nz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_005945_896811_B6AE2EB3 X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The current GPIO definition for the MT7531 switch reset line incorrectly specifies a pin GPIO_0 (GPIO5) that is connected to the boot mode selection DIP switch (SW1). In the public schematic for the BPI-R3 (titled "BPI-R3-MT7986A", revision "V1.1", sheet 4), the SPI1_CS (GPIO32) pin of the MT7986 (U1E) is connected to the GbE_RESET net. Frank Wunderlich has told me, via the Banana Pi forum, that this GbE_RESET net connects to the MT7531 reset line in the private part of the shematic he has a copy of. Signed-off-by: Leith Bade --- arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts index ed79ad1ae871..951612ea1e66 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts @@ -206,7 +206,7 @@ switch: switch@31 { interrupt-controller; #interrupt-cells = <1>; interrupts-extended = <&pio 66 IRQ_TYPE_LEVEL_HIGH>; - reset-gpios = <&pio 5 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 32 GPIO_ACTIVE_HIGH>; }; }; From patchwork Thu Jun 27 07:58:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leith Bade X-Patchwork-Id: 13713913 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FA94C30658 for ; Thu, 27 Jun 2024 08:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/OXRweFobEGV2dQzUWK018aOdtxKilWjm6XN9Kcy62E=; b=H+8dA1bOApwSGzHTcD2K1jtL1+ 4xm6KIDZLkNT857KBSVq2EWn33FPhncQjgf1f0OSUeXlW89ZCjdZd9nG/diZtHblA/lNosfiPgA+P id/FXK22SnVk4oF0FIyOXFlLU0govBr/5Lo4TJTBELo0DmtrghJuIeUk1OGIWC05XZqa0i0RTnDqZ QiewmjKWZ4vsvMYckc4vWvq2wen/C6D7Z/xMOx1YrOiPSb+BF/2mRNAo9LcwBCpFNqbSdWBHOTC5f DhQ/t7kjsFhw/fQD6sQCTggetkZMjsrF4omSzL+eCO6OETmDkoIbgFrIhsjI8QCyJ/iaULpte73Jx pxflazEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk2y-00000009euO-3vrU; Thu, 27 Jun 2024 08:00:00 +0000 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk2p-00000009eqN-3XxR for linux-mediatek@lists.infradead.org; Thu, 27 Jun 2024 07:59:54 +0000 Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-5c21a177affso1158374eaf.2 for ; Thu, 27 Jun 2024 00:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bade.nz; s=google; t=1719475186; x=1720079986; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/OXRweFobEGV2dQzUWK018aOdtxKilWjm6XN9Kcy62E=; b=G3DEitQlEvzqGiOdxaCHSUa5pruzN9wu2MnyMtTEnk+/KD6hhcKG3V7fPFpNAKbyTi n1FI+0PrmxOHgZddxH1YsEIZrmoNxrNT0vLtfpsyzcAuRIMoPZOawXIQ/0xLAZY36lbQ Qv31sWO4IZdUF2Av3ZQXtFQo8pSS3bMmAQTLf3V8UwGAAfVauvvl+OQmVEng86loCd5c 8PWaeDRAZsHH24c1IWuRcNx79kWU5FE7O+luBwmuD9LczorYLuysCoxINTrr1MwxzNHf eYN+lfvNP0npMhfNL0/ByVdiBL1je2IBu7kc8T4NcRCnbTyX8YoY1XqQt2tuPtEvR/il DBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719475186; x=1720079986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OXRweFobEGV2dQzUWK018aOdtxKilWjm6XN9Kcy62E=; b=ZgJWAeK90y+t0bHX/xOU/hzxhp+LS73FyzGwMDZYAgJExbKAoVl6A/K7f66U73iWBh QtJtYTrobQSHPU5o0e/0SeK0u5dNBhvEpbhRz2wD5n+ZLlqBrJJFWWUaDGdscJWbYqpT KxgumvlhuwBR2rZHPhdAWS1ZA36OjfMH+phvcFR5RGZokYJPalhTAjutMtFt9rlAq/5g pfkXpBbGNbcYWHsGN03E6YvP2Ru1hkASX2W2oKdMvEvdkLrIPmjfojy9270KKrj5SylC 09SWyKb8VQmDeO71ft9NSr5kIvKIFfM3VqXx5zGIoYBqAYtI0yBlpjVel3n/nChE3elr b4fA== X-Forwarded-Encrypted: i=1; AJvYcCV0ZCvPcRIyhiE33LTXT5+jQL8otYr5/BMW+kCSTGJuY1r2NLTayKJcTtb7CjOP1VTDd5eKW9yhvqCjCOPbXHnqi3j+ecRzey6E7NXCWk/hzEYn X-Gm-Message-State: AOJu0YwSxt1bcyn3yClembesiJak83mIBhZ6eVOLaHY8H9YfygZnpS3z jJ2yvXSmF8/rpWZgpgVhPTPn+v0eMCoiImegtdl5XapJclLz1lHq8MknrxPwVw== X-Google-Smtp-Source: AGHT+IHq6ql5dluNAvM3m09ay3+tSbfsSgfh7pATvqKfHdP2z7gQ8/LBSft8+sTU5UrJEuU2LPHobg== X-Received: by 2002:a05:6359:4c93:b0:1a5:bbe2:5046 with SMTP id e5c5f4694b2df-1a5bbe25a8amr372547655d.30.1719475186426; Thu, 27 Jun 2024 00:59:46 -0700 (PDT) Received: from localhost.localdomain ([2403:5816:cd6c:0:6d45:ae2f:1ead:bd58]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1faac9c4cf4sm7181895ad.290.2024.06.27.00.59.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 00:59:46 -0700 (PDT) From: Leith Bade To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, frank-w@public-files.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, didi.debian@cknow.org, Leith Bade Subject: [PATCH 2/4] arm64: dts: mediatek: mt7986: add gpio-hog for boot mode switch on BPI-R3 Date: Thu, 27 Jun 2024 17:58:54 +1000 Message-Id: <20240627075856.2314804-3-leith@bade.nz> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240627075856.2314804-1-leith@bade.nz> References: <20240627075856.2314804-1-leith@bade.nz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_005952_028590_BB194E53 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org To avoid future pin conflicts with the boot mode dip switch (SW1), add a gpio-hog to document the two GPIOs it is connected to. If another device attempts to then claim the pins a log message will get printed. The BPI-R3 has a four position DIP switch (labelled SW1), that is used to configure the boot mode. The first two positions (labelled A & B) configure two bootstrap pins on the MT7986 that select which flash chip the boot ROM will load the second stage bootloader from. The third position toggles chip select lines to select between the NOR or NAND chip on the SPI0 bus. The fourth position toggles chip select lines to select between the eMMC chip or SD card on the MMC0 bus. Only the first two positions are connected to GPIO pins on the MT7986. In the public schematic for the BPI-R3 (titled "BPI-R3-MT7986A", revision "V1.1", sheet 4), these are the MT7986 (U1E) pins GPIO_0 (GPIO5) and GPIO_1 (GPIO6). This gpio-hog configures the two boot mode pins as inputs. Signed-off-by: Leith Bade --- arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts index 951612ea1e66..2cccbec39d34 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts @@ -235,6 +235,13 @@ &pcie_phy { }; &pio { + boot_mode_hog: boot-mode-hog { + gpio-hog; + gpios = <5 GPIO_ACTIVE_HIGH>, + <6 GPIO_ACTIVE_HIGH>; + input; + }; + i2c_pins: i2c-pins { mux { function = "i2c"; From patchwork Thu Jun 27 07:58:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leith Bade X-Patchwork-Id: 13713914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29E69C2BD09 for ; Thu, 27 Jun 2024 08:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q4DjhfkRszKoe5oPh3mJCAe0ASyt5TfGg8KpZA+jjx0=; b=g22IfYF3yTkXdKIyZ0WaDR02xn Jw3e3oM8H3lGPepvdZBMc+g011toifGAnz/kenYEeEZvDlB7FtPVBnVniWludnD8Y+BAsLPF41C5t W9l3q0xuXmfqDd4IdC8EDfoqLpkyseiBKpZunCCKsCWnwoObdCBiUhdiq09oQtVZ26YannPwkurmv gWYB1oYPdWXA5frxk+J8AiwpllAY+sf2XCAgYlr275JuRFG3dp9CMrruz8lFXZWJ4fPOHJSJkL3C9 xPAzLq/jkcqhyA9Fq+AOErk+ZqXYi0yu1t7OXvatQu/ZYvMF64caq81HsgOap7oJIvUbiuEsUbe83 fk6LRa3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk3I-00000009f1X-2p5V; Thu, 27 Jun 2024 08:00:20 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk2v-00000009esh-0WSr for linux-mediatek@lists.infradead.org; Thu, 27 Jun 2024 07:59:58 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1faad2f1967so2405415ad.0 for ; Thu, 27 Jun 2024 00:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bade.nz; s=google; t=1719475195; x=1720079995; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q4DjhfkRszKoe5oPh3mJCAe0ASyt5TfGg8KpZA+jjx0=; b=dn4AEn3Q0wGWustofrNs6gtQ7uOwWO6HDc+qS0UNAGj8GjvpUwl8ngEnUKNdW6kFm7 BEnY6AU7ZMgav5oYf5pcRvSIsBXDwW2OjTgtfBgbL4REQWjYgjmLAN6ZjMGKEDJbrZCl 5zFJlYdqW51CAber9H/mUTo6uNQH4k7+kU1aBfRaEI2/ZqVT5c7rfpbA4Y8y5b15G5wb rFOjj39zu73NgOY85IZUoN8VAB4DNx4QIGBcoH6MhTnOV5IFM2wJ9Qxtx19oQVO1rZiy sdcoDFr8MePn204QIcwbyAQNShKOxKrYYWGMIWXhWXK7+zj+mPnomDWUc5uy6rneyeIY RfUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719475195; x=1720079995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q4DjhfkRszKoe5oPh3mJCAe0ASyt5TfGg8KpZA+jjx0=; b=da4ARKF1aG+TQIBH8I86k/WfgSqO5M/8jsnDlL951BJ483T09inTq6LAsJDgAs+J0K j76YoYWGm3pqixdcXYUhnhaJql1Od34cfrbv1a0oqcaKA443EuNbU6ibf0zeh3nMBSCF NVrYC0rUxPsMOvb3B7f0sDV35SuxSawflpU5d9BvIWli4pk4w2tzVThVFOGWzqcqYMoz H1IxPgi5sUw+ap838M/WU3UYBZc/ywpuQRg8dy/McEryAppIUBqsOkdQwyWNX893UEwi dWhzUluxLEueALRq+47dz22VPywcNTQBf7Eiw+GLqEj2xX0pxYoJBtYVgGd+iYnjqwTD WAPA== X-Forwarded-Encrypted: i=1; AJvYcCU7HQi/Us4GdlNfga0NK3nfLHFs/LghNfE0TfEe1JhxTTxKA9vW4vXJho6C78seNCoQNkhC0Fchg0YF6Ndy5SCLLv+elrCzoN1kKsWNWLPvCsnO X-Gm-Message-State: AOJu0YxQoaU0PsQBv/UYBaAAA/XcJKj3LWDgu3qLn8Xuy9PqP7hFihl5 /a3eLYMdYlfjAyWK9c2ajxPhjVNoO4ORYBVPjVF3t2SFqklrhmQ3bvhOf6j/2Q== X-Google-Smtp-Source: AGHT+IGFxtbZWAj2r9WPTPIPxXPYFLn109hfACu8p35/RA7zE8bhOqk7d/KHHpV8aS7hPB3fyrSIWw== X-Received: by 2002:a17:902:c945:b0:1fa:2b11:657d with SMTP id d9443c01a7336-1fa5e671d16mr135158015ad.10.1719475195391; Thu, 27 Jun 2024 00:59:55 -0700 (PDT) Received: from localhost.localdomain ([2403:5816:cd6c:0:6d45:ae2f:1ead:bd58]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1faac9c4cf4sm7181895ad.290.2024.06.27.00.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 00:59:55 -0700 (PDT) From: Leith Bade To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, frank-w@public-files.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, didi.debian@cknow.org, Leith Bade Subject: [PATCH 3/4] arm64: dts: mediatek: mt7986: add missing pin groups to BPI-R3 Date: Thu, 27 Jun 2024 17:58:55 +1000 Message-Id: <20240627075856.2314804-4-leith@bade.nz> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240627075856.2314804-1-leith@bade.nz> References: <20240627075856.2314804-1-leith@bade.nz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_005957_211508_74F3D502 X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The uart0, mdio and switch nodes are not connected to pin groups unlike most of the other nodes. Signed-off-by: Leith Bade --- .../dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts index 2cccbec39d34..54087001cc8c 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts @@ -194,6 +194,8 @@ gmac1: mac@1 { }; mdio: mdio-bus { + pinctrl-names = "default"; + pinctrl-0 = <&mdio_pins>; #address-cells = <1>; #size-cells = <0>; }; @@ -206,6 +208,8 @@ switch: switch@31 { interrupt-controller; #interrupt-cells = <1>; interrupts-extended = <&pio 66 IRQ_TYPE_LEVEL_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&switch_pins>; reset-gpios = <&pio 32 GPIO_ACTIVE_HIGH>; }; }; @@ -335,6 +339,13 @@ mux { }; }; + uart0_pins: uart0-pins { + mux { + function = "uart"; + groups = "uart0"; + }; + }; + uart1_pins: uart1-pins { mux { function = "uart"; @@ -349,6 +360,20 @@ mux { }; }; + mdio_pins: mdio-pins { + mux { + function = "eth"; + groups = "mdc_mdio"; + }; + }; + + switch_pins: switch-pins { + mux { + function = "eth"; + groups = "switch_int"; + }; + }; + wf_2g_5g_pins: wf-2g-5g-pins { mux { function = "wifi"; @@ -471,6 +496,8 @@ &trng { }; &uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pins>; status = "okay"; }; From patchwork Thu Jun 27 07:58:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leith Bade X-Patchwork-Id: 13713915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A8F2C2BD09 for ; Thu, 27 Jun 2024 08:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HLrEboALRZdxdEXYrbHRXF19aT/W7AkEgiNEUpYGTaU=; b=kGajt40BCBxb4EnWcj+9+AkkJa cOQPcW6J4/aZNr56QAofeVESsWbygiiEAeQyKpQaOazFkvA75u8jvnl3lnab2rLzVr6QVEnZ8uJri V/VLObYfJ23FijS7Y19RofscltXf/oPWLd16JeadVNMNYMGQ7qbp4Z0PWfFFCH+IdyeQ5zWdJ9P// Fqs0PP2jKkkHtu1QPW/qeDK6WhI8cw4JIir4NYKf7gb/EwZGVsMkkozQGQSY2/fBEaAcs7dLzmSYb Z0n8w5Zf1WzCXPN1ubn2pWFFP2kTXn+vwq39BKOI8wdIu0mYPfr91skxfFfvZmLSPuYMUXF9Cy9xS 5gD+hPQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk3c-00000009f76-0o2r; Thu, 27 Jun 2024 08:00:40 +0000 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMk31-00000009eug-07xB for linux-mediatek@lists.infradead.org; Thu, 27 Jun 2024 08:00:05 +0000 Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-5c2284616f7so718156eaf.1 for ; Thu, 27 Jun 2024 01:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bade.nz; s=google; t=1719475201; x=1720080001; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HLrEboALRZdxdEXYrbHRXF19aT/W7AkEgiNEUpYGTaU=; b=eBOBwy6icagkB434sAUHU4rN/u7pfHzCpYZq18jzwthz5wGjFL+lcJd6c0ya8ODrgt Ur5x3jANsZWJC5Ygc2Gc0INTyjJ+Ht/amyk9jSpgP1MFoi38guBSP32deLeJMIihcgiG GD7giowIyfUXvRrYI7SE/BOZaLuwzFajaXBBKTROoEuliMRr7TfpnCCbV0Fvmk3fkvQo lDsOmzNPe44EbC3NLfQnofkvG9t1jqqa7E1NH1VHLzbba/zYcdCd9l/RI5L0d51/ZO/A J4PWdGxBjViVtN2yzQHBwX8QiRk0fP/lfowfdUlgbe2nYDMI9bQNU0X28mOVPtsXKXdC kU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719475201; x=1720080001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HLrEboALRZdxdEXYrbHRXF19aT/W7AkEgiNEUpYGTaU=; b=TKa8tbgSzo1XAgDGRzm+V8T892eNbAR7P76KZIcG4QW0wvba2kYejogVX7wEydr4g1 RaXl7j/kfYFwVB/LLLE8QMGMOdfcPV/7m+X8BJFr0LTTi7jgwFaVDIzjm4EZdjyBlBi/ kJcS5e3Oqff3Q06f4al0TiUv5YAyNl3fT8ajTbivZda2a/Caff1t3Yps4DWDTyzu2a4E qSeqBe7+/rx0Q7rSM1VlQut7uJ1OWceuYpaE9eFq4h8gXzlI6MSloq9E/2PFy3YK8jkW OhC9xI8ZQQQ79Uhvils6hZ7kwFMhFiti4JRYydvDneAEpaWuye0A900wMWNQ7q4wZ6EU aN/Q== X-Forwarded-Encrypted: i=1; AJvYcCXloJ/yMsJUHZv0/gC+gVcUfUy+SkRdKmYspAMMqGgv3sBcap122bdwVwua+jwXJ7GhTCzoLZirtDCPSLkD0yafnEjR0gHRAjYEPDYeAqn/jMA+ X-Gm-Message-State: AOJu0YxpFG35c7zZTw9PaZ8rovfQ9gjeoIJOtZIpGPtILFVADOBzKvbx HIdsmmgxUjBW6e0RjAcUA7aDEa9+0kP6HK8GwRy48OaE8mDq1GLAND21ZpY3tQ== X-Google-Smtp-Source: AGHT+IFkN0ubSaKPqjXkvWd5Aw4rBqZo9lhwryAwfy3XDy7tr4/U2Sfjt2ekvvF7l3gOffo10mAi1w== X-Received: by 2002:a05:6358:7e47:b0:1a6:7af3:22ce with SMTP id e5c5f4694b2df-1a67af32e24mr94322855d.2.1719475200751; Thu, 27 Jun 2024 01:00:00 -0700 (PDT) Received: from localhost.localdomain ([2403:5816:cd6c:0:6d45:ae2f:1ead:bd58]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1faac9c4cf4sm7181895ad.290.2024.06.27.00.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 01:00:00 -0700 (PDT) From: Leith Bade To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, frank-w@public-files.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, didi.debian@cknow.org, Leith Bade Subject: [PATCH 4/4] arm64: dts: mediatek: mt7986: add missing UART1 CTS/RTS pins in BPI-R3 Date: Thu, 27 Jun 2024 17:58:56 +1000 Message-Id: <20240627075856.2314804-5-leith@bade.nz> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240627075856.2314804-1-leith@bade.nz> References: <20240627075856.2314804-1-leith@bade.nz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_010003_575835_F327765D X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The current definition of the uart1_pins pin group does not include the CTS and RTS pins that are available on header CON1. In the public schematic for the BPI-R3 (titled "BPI-R3-MT7986A", revision "V1.1", sheet 4), the UART1_RTS and UART1_CTS pins are connected via nets to the connector CON1 (sheet 14) UART0-RTS and UART0-CTS pins. The datasheet does not show these nets as connected to anything else. These pins can be configured for either UART1 or as a GPIO, with no other alternate usage listed in the pinctrl driver. By changing the pin group definition from uart1_rx_tx to uart1 the additional RTS and CTS pins are included. Signed-off-by: Leith Bade --- arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts index 54087001cc8c..48bd1e04963c 100644 --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts @@ -349,7 +349,7 @@ mux { uart1_pins: uart1-pins { mux { function = "uart"; - groups = "uart1_rx_tx"; + groups = "uart1"; }; };