From patchwork Thu Jun 27 12:49:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13714327 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9516017838D; Thu, 27 Jun 2024 12:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492578; cv=none; b=i7joV537qiwOxAzioBltLaRXGq8slC+i/lIzyVh0rRtyM7f6O/L1WNTE4DHn5/nwvBfxOJcrvgyWji+JlKjkW8Ny1K8oUQq5WmAa0v4KJESPDoB26spuIGtFVCH1bv64+qJzdSG4ll816sjL6dQkOREpvzQ1pLQi2xaI8XdsI+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492578; c=relaxed/simple; bh=B/Mz61kJ0gKhqTo9TQhnVEwo9B0DXR73xnWUb5qnv70=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WCVFM8xqWi1l41G8PhcWD5hLbIx67r7xLJdJxsOMFYtWJoiNQje6BzTXo96R3ehnJH9l5yoJ/U7zUBOuYedeabSXQdLNlJMaEj9UdyrOwb6Lo/fgPdlwSsidBk46iOj6UOpb1jjMTwhmPBP599BwLxjgkJHy1n5FOTVhGQl/2is= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=bK7T0t2R; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bK7T0t2R" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=7bza4BPcHCE+GDsbiJfWSek0v/JwxgMHleU7FQsIb/0=; b=bK7T0t2RFNyxDE7zjSaf907S5l 4rPnA0bh/NErNalALdph0xpA0FrgVOboKiKuz8eY3D0pEWtz2yhfn3IyGrI5zDTAmqwrZx+mIQx/Z WyAN7DC3EvpF6UFv3Dl0JhOlf25P1IqYSPfiDgxDd6z1E6wsMPxklTLWpjpUQ3RTbQ5syDJiAvq+U gQ6wCjfD4oHc5SyvJ3i/84SNcS8rus86koMyIpDrQx+1Knc6pamVGjEs7S0Z3cZNiLOiF7Db8tro1 GiZBDtYiWlx8/RgOzYFUnFPl4teGKFiTUUkBOeph5FnKbHjq46GXQZCPECUHnrdvkVdMLI0n1VSl7 KVcv1fCw==; Received: from [2001:4bb8:2dc:6d4c:6789:3c0c:a17:a2fe] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMoZB-0000000AN1C-2lkE; Thu, 27 Jun 2024 12:49:34 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Ming Lei , "Md. Haris Iqbal" , Jack Wang , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , linux-block@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH 1/5] loop: don't set QUEUE_FLAG_NOMERGES Date: Thu, 27 Jun 2024 14:49:11 +0200 Message-ID: <20240627124926.512662-2-hch@lst.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627124926.512662-1-hch@lst.de> References: <20240627124926.512662-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html QUEUE_FLAG_NOMERGES isn't really a driver interface, but a user tunable. There also isn't any good reason to set it in the loop driver. The original commit adding it (5b5e20f421c0b6d "block: loop: set QUEUE_FLAG_NOMERGES for request queue of loop") claims that "It doesn't make sense to enable merge because the I/O submitted to backing file is handled page by page." which of course isn't true for multi-page bvec now, and it never has been for direct I/O, for which commit 40326d8a33d ("block/loop: allow request merge for directio mode") alredy disabled the nomerges flag. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 86b5d956dc4e02..3a116314877109 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -211,13 +211,10 @@ static void __loop_update_dio(struct loop_device *lo, bool dio) if (lo->lo_state == Lo_bound) blk_mq_freeze_queue(lo->lo_queue); lo->use_dio = use_dio; - if (use_dio) { - blk_queue_flag_clear(QUEUE_FLAG_NOMERGES, lo->lo_queue); + if (use_dio) lo->lo_flags |= LO_FLAGS_DIRECT_IO; - } else { - blk_queue_flag_set(QUEUE_FLAG_NOMERGES, lo->lo_queue); + else lo->lo_flags &= ~LO_FLAGS_DIRECT_IO; - } if (lo->lo_state == Lo_bound) blk_mq_unfreeze_queue(lo->lo_queue); } @@ -2033,14 +2030,6 @@ static int loop_add(int i) } lo->lo_queue = lo->lo_disk->queue; - /* - * By default, we do buffer IO, so it doesn't make sense to enable - * merge because the I/O submitted to backing file is handled page by - * page. For directio mode, merge does help to dispatch bigger request - * to underlayer disk. We will enable merge once directio is enabled. - */ - blk_queue_flag_set(QUEUE_FLAG_NOMERGES, lo->lo_queue); - /* * Disable partition scanning by default. The in-kernel partition * scanning can be requested individually per-device during its From patchwork Thu Jun 27 12:49:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13714328 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A9E217BB22; Thu, 27 Jun 2024 12:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492581; cv=none; b=e2CZseKQTiQ+Yevo8xhp3qkFOGKXdYxW9I1Gg7cs4zSYRDA36pxsyDTHolZUCzSR/fAJ4gM370M6RwHNkZmr1adIo8lxxDcJBt2yFRGyJxfilu55BWpYyU3IQRm59whs7UAFjupbZG6hhmV7oqyFixAAULmQEGK/IN3MYK5hhpE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492581; c=relaxed/simple; bh=tHrxUQ2I8sjGwTxqxPyzwuLmgQ1k7GR9fKapxHZM7K0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lj4HeyefSP2pX2hUshXxM7t8wzRKM/Nyyr5XcNtJTiFxqCijmPmf6dn241LR8DrkHUPvjewnKUQE3myHhFb8zqGo7WswQM7A6h1EdYW5+7Rj4OiVxfMpU6Yuvvu2Sug67jVNXlRA9DjMZ/eFyhzyFpm/uBBY0vuJSUu1TxDgGxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=GlRiewqI; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GlRiewqI" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=W/SCrTEXd5pa0FCte55wmCajAJIS3L5i7/QR+MpuT9o=; b=GlRiewqIHGkOsYgiQIMCf6oeEE jDVSJ2IsDC4SXCidGf2a8VLw1KDnkfI77AsKCjyPDRNSt78lyFMZ0PMgfxkeu1LEJ790vPOb3QQqo 96LGp6eH6ujZjXqYkSPeDy9EF3dtSKrTWDuKyQfUvgfRYmEhjVo9h5Go9BmgpQwzd5TOc8Cwdh8Y9 b5/FzGWGKHMTT9xli6DqK0qyYF7UmTa2viQxcU6+KBUSag6PuK/L4IRQqJwjtkbMo9Ia/f8O7LJuM FjLzRjb5C1iXiCa9SXvs51H/0P36lMmqV82KOWt1Hn/aJIFrHkNj7P0Y0BTk5mGVuEj6Gq2ugmjs4 JlHyy+3w==; Received: from [2001:4bb8:2dc:6d4c:6789:3c0c:a17:a2fe] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMoZF-0000000AN21-2IQW; Thu, 27 Jun 2024 12:49:38 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Ming Lei , "Md. Haris Iqbal" , Jack Wang , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , linux-block@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH 2/5] megaraid_sas: don't set QUEUE_FLAG_NOMERGES Date: Thu, 27 Jun 2024 14:49:12 +0200 Message-ID: <20240627124926.512662-3-hch@lst.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627124926.512662-1-hch@lst.de> References: <20240627124926.512662-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Setting QUEUE_FLAG_NOMERGES was added in commit 15dd03811d99dcf ("scsi: megaraid_sas: NVME Interface detection and prop settings") without any explanation. Drivers should second guess the block layer merge decisions, so remove the flag. Signed-off-by: Christoph Hellwig --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 88acefbf9aeaba..6c79c350a4d5ba 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -1981,8 +1981,6 @@ megasas_set_nvme_device_properties(struct scsi_device *sdev, lim->max_hw_sectors = max_io_size / 512; lim->virt_boundary_mask = mr_nvme_pg_size - 1; - - blk_queue_flag_set(QUEUE_FLAG_NOMERGES, sdev->request_queue); } /* From patchwork Thu Jun 27 12:49:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13714329 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798C1178392; Thu, 27 Jun 2024 12:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492584; cv=none; b=kOAoYt9YqFwI243f7uH13uztpYmPT9uf2/9joiJJJQeHY3qYz6cXF2xjBDv/rRuHPvw0NQbvRSm16zZaU1ApdzGRc0HKal2GDLGhXUQMFwl1GbBJlRV2xNIjbsQVid80c+eDM+A3Oz096hRBhogRHmffzqnE7Ld9oIzQX4FEm/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492584; c=relaxed/simple; bh=UHFHzOb5qpOxVBL+hmh63JeGT277CvQI4Lu1JzOjC6o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GPJg+4hJQnP7/Ij6+HpoDAMH5bj1s2PX9EZzM8xMzzuw04oGuQis9cc223I8xZ/0tpVcGwitCCr9NMwEj0J5BJsGiirzuPXh/zVYCc7OXpmrnoIwIkO1n+NPzVbg7BPODe86EbhncTxPk91oEYEuJlVl+SPtm3KFrDwYCy1XwvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Ldu5v32+; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ldu5v32+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=HTutOlPUlfHJUk/Qi9Nn5kjF/ytHNXd/sRMVmjFuq10=; b=Ldu5v32+LvAimqVHMOIC+jvTgU kZzq3Cu9QVNU7pqVdBMppNi4iuVE/GU/FwpaIonDW/5j3cwaOGGLoCaXXeZcRHRqdNogwP/6zYL8I Tr9s6nElogSmgOnbFSvbZdGMd2eqowvWvSU1ea5YJUFNxl8mlUdXBXhMer3N6U+gX/89saEfRjB9z 8sy5/MfymWroZh9REKxJgOmr32nyxIoDqQQJvwnTN2ifSxnA8JGZWH4mYQqXqLjW/fx1cFgiTL2b6 vLKT3xk8rVnajATQvui/m+g6+1kSKVheeUXOP8WIsNJsdukOXNMLTW4QsXQKfLv2cnQWfKgtZvg4K j38pxpvg==; Received: from [2001:4bb8:2dc:6d4c:6789:3c0c:a17:a2fe] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMoZJ-0000000AN31-1aeW; Thu, 27 Jun 2024 12:49:41 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Ming Lei , "Md. Haris Iqbal" , Jack Wang , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , linux-block@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH 3/5] mpt3sas_scsih: don't set QUEUE_FLAG_NOMERGES Date: Thu, 27 Jun 2024 14:49:13 +0200 Message-ID: <20240627124926.512662-4-hch@lst.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627124926.512662-1-hch@lst.de> References: <20240627124926.512662-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Setting QUEUE_FLAG_NOMERGES was added in commit d1b01d14b7ba ("scsi: mpt3sas: Set NVMe device queue depth as 128") without any explanation. Drivers should second guess the block layer merge decisions, so remove the flag. Signed-off-by: Christoph Hellwig --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 12d08d8ba5382d..b050aedc9d4334 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -2680,12 +2680,6 @@ scsih_device_configure(struct scsi_device *sdev, struct queue_limits *lim) pcie_device_put(pcie_device); spin_unlock_irqrestore(&ioc->pcie_device_lock, flags); mpt3sas_scsih_change_queue_depth(sdev, qdepth); - /* Enable QUEUE_FLAG_NOMERGES flag, so that IOs won't be - ** merged and can eliminate holes created during merging - ** operation. - **/ - blk_queue_flag_set(QUEUE_FLAG_NOMERGES, - sdev->request_queue); lim->virt_boundary_mask = ioc->page_size - 1; return 0; } From patchwork Thu Jun 27 12:49:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13714330 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7AA179663; Thu, 27 Jun 2024 12:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492591; cv=none; b=cEYixX64X0X97AEcO39ROLwrID2AdKOcuK+yCY82l0VaVmXNf6+7mfhocN1t5dUZUOB+DIdUMPEY87D/JoRUscWPX8FcF5tmuot8YFCK1GXV1rM/flff1oVwF8k3Jaq7BV7ptN1G3H6WenzKBl9pwadgg3J7tLGJsn2+Q14DjR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492591; c=relaxed/simple; bh=lcHPPdliqVo3ZlGRzysnWzG/VSRBLuNUtziq4tfuk64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EglkJ68GTaN0/xnb4oGph3Zt/teSHSP6l61XiZ9vC4q9gkEEa0DhRb9Zy5V0EhNzpkn6gN19N0SRCFbmFXebXz0ex9MJh73UMqqaRPCzQxC1k+nn1Va1ZGsF63jW5vTrTc8F3XVAh5BZRN6VbCobXoqk2P43i1aNkj+bqAOzWGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=GYYiAb6x; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GYYiAb6x" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=dbpk/jWfnG14mb5+tOcVnh5G3VFRihrDhhSyb+gDW5k=; b=GYYiAb6xKy2+ss3/YkwjBjEUwk 1+4SPxRtvHkA2yqmFYQlp/yweITRyiMXyBCxVkp2LgNgi+SghtblYXif88jPqnoPwI03E3MCMANQY oShN6oUjDOId4SxIo8USCjx93IRYjLnLOqsucF6b8462l6lj+9gd8X/YX3TA4vaxsFYsFwMprAl6B bjbWNS2u97jJ7arzdxiRJPwCFsHKysja+sAwvn+e51NZPiUwlMTHHBIM5ASTWHVKa8w6djJiShM/w RNlOfGkqVtfRaHmbLSjfjj3vmlm/2w2u0Ng8NV5wpjajv5tF+3WsI6/OudI1Lium2byQo/bcQ+Y5N DsCLrLVg==; Received: from [2001:4bb8:2dc:6d4c:6789:3c0c:a17:a2fe] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMoZM-0000000AN4n-3fuw; Thu, 27 Jun 2024 12:49:47 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Ming Lei , "Md. Haris Iqbal" , Jack Wang , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , linux-block@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH 4/5] rnbd: don't set QUEUE_FLAG_SAME_COMP Date: Thu, 27 Jun 2024 14:49:14 +0200 Message-ID: <20240627124926.512662-5-hch@lst.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627124926.512662-1-hch@lst.de> References: <20240627124926.512662-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html QUEUE_FLAG_SAME_COMP is already set by default. Signed-off-by: Christoph Hellwig --- drivers/block/rnbd/rnbd-clt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c index 4918b0f68b46cd..0e3773fe479706 100644 --- a/drivers/block/rnbd/rnbd-clt.c +++ b/drivers/block/rnbd/rnbd-clt.c @@ -1397,7 +1397,6 @@ static int rnbd_client_setup_device(struct rnbd_clt_dev *dev, dev->queue = dev->gd->queue; rnbd_init_mq_hw_queues(dev); - blk_queue_flag_set(QUEUE_FLAG_SAME_COMP, dev->queue); blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue); return rnbd_clt_setup_gen_disk(dev, rsp, idx); } From patchwork Thu Jun 27 12:49:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13714331 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70706178373; Thu, 27 Jun 2024 12:50:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492603; cv=none; b=Ge/aIAiPMoz7LNGjJz/t8Fbxwe/thOZr7tja23n1L1cnVHknFXzVKg9fESeBM1PwIL555EcINYc7d5NLq94uFTFc2TkuTEGHod7vh7slSOqU8KSGovxXxmli7ewApqgb/aw3dZa0BCUMGz5g1L3sk7b3VAqWoL1zeMrauzTRcCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719492603; c=relaxed/simple; bh=KiRiCHXBO4fbh2lG1mrEJMJKYq0Qh8AHMt38HgXSDp0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rq1LnBgnRKUfrPKbvbcQ060guLUTl65Ue3BGVa/OZj0D3V6Z+QLwjv5WTz8uep8R9tEPosjVueelvcjHuvPn8uHMLaGitY0ddSFupW/obRTnkHR1Q5zhr4Ng346PG2n8Nnk2ZlD6ZSKJ/SKKlDKZ5J7tMJOu6Jj/jDrDxjZI/6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=IC8ttUCz; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="IC8ttUCz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=0FsjDylBbtdo2dKDqYsVLk+b6OxeYZvuRamj2Ya6XU4=; b=IC8ttUCzgSkN2O6buP2i3z9qk6 KOAlnfraqYzcaMFHiCvLR6Y9NGxDhVp/wCWWJsqsCNv7d97ghGzTxzuRnoRLg+ZQj+B8uN53hehba wBUdYKvEhiyhK3kxBM2FVUTAvB0mf0kgFb9hQMAf/hS9sW1vKlTuaLFMJRwUt4oawkvY9AWxUG9gU tPh6OndVka6sRZvLntn7XbHfrYLaSdLyJjxlCSB2SpZ3Zv0mAzAjHrSYhxqbIUznOzTrN8H7Ld+wU IiUVw+ol4Ao+ORonqtGafICTXfuxeA/aa/ck/e/GSEJ0cGLk5Thjb+7fvSC5h9OoybHSflj1eP36R SgvoXIoA==; Received: from [2001:4bb8:2dc:6d4c:6789:3c0c:a17:a2fe] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMoZT-0000000AN6t-0DGZ; Thu, 27 Jun 2024 12:49:53 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Ming Lei , "Md. Haris Iqbal" , Jack Wang , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , "Martin K. Petersen" , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , linux-block@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH 5/5] rnbd-cnt: don't set QUEUE_FLAG_SAME_FORCE Date: Thu, 27 Jun 2024 14:49:15 +0200 Message-ID: <20240627124926.512662-6-hch@lst.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240627124926.512662-1-hch@lst.de> References: <20240627124926.512662-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html QUEUE_FLAG_SAME_FORCE has been set by rnbd-cnt since the initial merge. There is no good reason for a driver to force exact core delivery, which is tunable for very specific workloads and not a driver setting. Signed-off-by: Christoph Hellwig Acked-by: Jack Wang --- drivers/block/rnbd/rnbd-clt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c index 0e3773fe479706..c34695d2eea7fe 100644 --- a/drivers/block/rnbd/rnbd-clt.c +++ b/drivers/block/rnbd/rnbd-clt.c @@ -1397,7 +1397,6 @@ static int rnbd_client_setup_device(struct rnbd_clt_dev *dev, dev->queue = dev->gd->queue; rnbd_init_mq_hw_queues(dev); - blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, dev->queue); return rnbd_clt_setup_gen_disk(dev, rsp, idx); }