From patchwork Fri Jun 28 03:23:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bang Li X-Patchwork-Id: 13715407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16D1C2BBCA for ; Fri, 28 Jun 2024 03:24:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C90C6B009C; Thu, 27 Jun 2024 23:24:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 277696B009D; Thu, 27 Jun 2024 23:24:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1400D6B00C3; Thu, 27 Jun 2024 23:24:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E93FD6B009C for ; Thu, 27 Jun 2024 23:24:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8D7BF1A14D8 for ; Fri, 28 Jun 2024 03:24:12 +0000 (UTC) X-FDA: 82278853944.10.E497D2B Received: from out0-196.mail.aliyun.com (out0-196.mail.aliyun.com [140.205.0.196]) by imf26.hostedemail.com (Postfix) with ESMTP id 1A627140010 for ; Fri, 28 Jun 2024 03:24:08 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=Zy26YUMO; spf=pass (imf26.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.196 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719545032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=XwOduJZ0J4vmIeZ5x8hown432z3Od2SXxlXWqlbqbkI=; b=Smg3mzCrYvBOggB8MsMHjUpfZRs96Dc+MZB3y9gaHA7DgE+b/GIVF6aO03697k8O9MwYFY tYq5q9Qxmep+6C2ELC3Uw+5q21lOVX2NAzyLCxuyA1l53SgutKRzxKI1q26qTYRaDKGOMu tLNN6/qVwnBJwTGRtnnOBVXf5UhftLA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719545032; a=rsa-sha256; cv=none; b=xJWk/w8a0kfsKkbZeP34Nlofz5MVijQd1eHfn4Vg6Jb06pBv80nD024XH07y6FRDbRfHJh HgJ81lJu2wxz804SX+zecO0Q8PoxND9kx38/w6giL6FYRq1sCM7LtUAGF/2/i7NUU8GiVK JgTHxb1U+C2FRS7sd0nsn0JkbAh7H34= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=Zy26YUMO; spf=pass (imf26.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.196 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1719545046; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=XwOduJZ0J4vmIeZ5x8hown432z3Od2SXxlXWqlbqbkI=; b=Zy26YUMOhpsz0E07H7izynN3an1JUiy9pSOPdSrfbrTHTCsDnCBfqSazFXiF9K7FVtNDxl4KMBTUfB/oGuySbTqXa10BW37xWL84ewQVqZ7ul5XpG/tf6KnbjzDnBZlAa+RiC5R64lAKezsSXasDU2VaZd/QnHOk5sPjcsFgQTw= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033023106192;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---.YC4ESwj_1719545044; Received: from localhost(mailfrom:libang.li@antgroup.com fp:SMTPD_---.YC4ESwj_1719545044) by smtp.aliyun-inc.com; Fri, 28 Jun 2024 11:24:04 +0800 From: "Bang Li" To: hughd@google.com, akpm@linux-foundation.org Cc: , , , , , "Bang Li" Subject: [PATCH] mm/shmem: Fix input and output inconsistencies Date: Fri, 28 Jun 2024 11:23:27 +0800 Message-Id: <20240628032327.16987-1-libang.li@antgroup.com> X-Mailer: git-send-email 2.19.1.6.gb485710b MIME-Version: 1.0 X-Stat-Signature: su954nsbgo1qfpzqp5wiyao433zen4ia X-Rspamd-Queue-Id: 1A627140010 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719545048-230969 X-HE-Meta: U2FsdGVkX19EiPgBOReBp7uRtyl+mB7btt41zkcgGw4UyKsgujtfm744eIYS24+AvkLFxZxcvPO4ZnUl3tZKfqujBenhBrt3f1ueYNA+p5bqBBebQiQ5w83Xd0300i1agyBNih7BbzPFA8y6vZx+gIxjauuf52H3FzM7fapx153NQsIO+NQDf/I3cneqdcXMHLzmDvXUDuOIv+3mkMU+eIb47bcrDRm9cKqYN17uCoOamMjTz447Qn2z/MEDKgxMRUUM0dE4H287helQIvKnbYWIVxmrAEb+Y1tKdAcA7ffaiSOOmAMCGriQke++GTCV0XZ+g8OPmiZziFzOCSEf704EF/4Xfsp/pDYEqZfYzTkv5clbqv9h2mGEwc0LEZjr1Jc7C+zdsb9ZQLqQPf980qWjiY3aly4f95uoC7mRSUP+U+8aL3Dl0kuzKSzcrfUmPuFEChlQqVWqvRaNRjU4FL40d9BnM1XqtgvmJq4yBAlDuOCz3y2aZNNc5ZAid3yl93JRZMzd9DH1hOIAuCU09ObalpBmykJ60p27tTYZ6VAyvyTOYz+9neDR9Etqlb7mO5J1bNaJ587JVi2JTQ/kf05y15H84S8i7rb8TErSw6DowGP6jGcB8O8Kt5CM5mZESwKh9ZQbowcuSlSnqw0yaG+FIxmA8jBUNrB5eHiCrsrTyYtSw6YLPXZR983O/ekbgb5qtUK+dCdqvmGUNf40iLTQ/FIqy0RgDBPbxs9fVnXa9alwfjkysKjcyKFhLcAghbaHS5VZx5q7xebe/r5ROOMqzDiMgcAIJvOiisvA31g7ezssuNtmQCtR7K0W72kc/+wrO4a2xeSCnoFReqfFC5qnxboaBOFKP//odp/XsBDNu+DGNL+PFNl/9++nvu9Yo6lYL/T4tpsuFSxHA0H5wwN/mkyxfiU7Nh4ueDjIHKytHQ2FAJ8beLfupD7GmDbEUUl53+D53rcfbgszILJ BhwMY+Kv D+CPmwjyNvcmkRStfsRHJFv94oE154j0mS504KDtHACshlBi0KooV4/YUE4ay8OkLyy5XuKG31G3q3jrIlQdeLgHmCRBvKkvzXcTjxRXDVCrnQ1vHX95DhU/oT/WrYHvvvZ4koZ7NVsxgntNsQPBz0v50rZW/yU5/+LRz3bIjTyxet31UH4qnx0+bgYQO8rKdxCDVSypAfHygIzu3gozFWe+v+EmqWMCfTneTa9T0jDijB0W9r5W1UoV8Ww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: After the commit 19eaf44954df ("mm: thp: support allocation of anonymous multi-size THP"), add mTHP support for anonymous shmem. We can configure different policies through the multi-size THP sysfs interface for anonymous shmem. But when we configure the "advise" policy of /sys/kernel/mm/transparent_hugepage/hugepages-xxxkB/shmem_enabled, we cannot write the "advise", but write the "madvise", which is unreasonable. We should keep the output and input values consistent, which is more convenient for users. Fixes: 61a57f1b1da9 ("mm: shmem: add multi-size THP sysfs interface for anonymous shmem") Signed-off-by: Bang Li Reviewed-by: Baolin Wang --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 13d139abe69a..d495c0701a83 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -4983,7 +4983,7 @@ static ssize_t thpsize_shmem_enabled_store(struct kobject *kobj, clear_bit(order, &huge_shmem_orders_madvise); set_bit(order, &huge_shmem_orders_within_size); spin_unlock(&huge_shmem_orders_lock); - } else if (sysfs_streq(buf, "madvise")) { + } else if (sysfs_streq(buf, "advise")) { spin_lock(&huge_shmem_orders_lock); clear_bit(order, &huge_shmem_orders_always); clear_bit(order, &huge_shmem_orders_inherit);