From patchwork Wed Jul 3 10:00:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13721675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6028C30653 for ; Wed, 3 Jul 2024 10:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mNHo4Nb6oWQND234v3Z//rfVwuUjQ+JtZjr11w8RLXU=; b=jOiM5BPHjLrOiJa9WWaXduOg5s hCJ8YYChQS6xpY172T6z/LfXhdf8EyfaLw0nT+n+ruYaV075sUr3ne+Fg/Y+7fg33SeypzIssctq4 a3dMOPFDSdEY+1e5RJL0u/9SqDXrCOEJ6gfv2vUr8onF/NAnr11C8GhXCSbOP4HcmAVnE/mENIX30 gBwOBRMoD47Px19xGraUG2+9LRa5mMxaTu5patLZ43bEQ6+mLh5JTpMaiLpriXhZayNb24m2u+7WS 0svuMSRGXJj+wFYN6HzzVjUVY/L3PjS0UR7M3H0ZRD6IpMBU8Y9S+qm9MQ3RnHEWcxnIsL1yDKWsK DrQy5hVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOwnz-00000009evB-2yUg; Wed, 03 Jul 2024 10:01:39 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOwnQ-00000009ehw-2oph for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2024 10:01:10 +0000 Received: from francesco-nb.corp.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 6D1D61F9FF; Wed, 3 Jul 2024 12:00:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1720000857; bh=mNHo4Nb6oWQND234v3Z//rfVwuUjQ+JtZjr11w8RLXU=; h=From:To:Subject; b=e4QaRo7XnAU06TO9kWTB5JUfOEv8Xu5cPBruzA0rvVJkxreS3hsh+VjBMEsV9G8UY 9KLhL9tD5u3kgK+Vk3wWGx4gNf0pBaBVBa/KQ3K35WQ2T1sVjqJRS7ZiDD/whIGGeG ljPozeODkI4q+WXENF+mv9R5jJZHxCeQQlBHILfTSF6BqgAUSMqp0Wr+n2Nir25+UE u+ZuQdv7WbmRvpT7/d2i5V4Qx1uzuizUFgs0CZDqRwdnkY9knXlV07F5uVdDBkwG5h ARGSeEzFOln0RMcMX1AtcG9ONz1AupVhjlzyOOhMGbehC4gNf/6oqILCRF0w7P0wh6 c1yYi41imHAxQ== From: Francesco Dolcini To: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Emanuele Ghidoli , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: [PATCH v1 1/2] arm64: dts: ti: Mark PCIe PERST# polarity active low in DT Date: Wed, 3 Jul 2024 12:00:35 +0200 Message-Id: <20240703100036.17896-2-francesco@dolcini.it> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240703100036.17896-1-francesco@dolcini.it> References: <20240703100036.17896-1-francesco@dolcini.it> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_030105_460096_CB3C4FE3 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Emanuele Ghidoli As the name indicates, PERST# is active low. Fix the DT description to match the HW behaviour. Signed-off-by: Emanuele Ghidoli Signed-off-by: Francesco Dolcini --- arch/arm64/boot/dts/ti/k3-am642-evm.dts | 2 +- arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts | 2 +- arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts | 2 +- arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 2 +- arch/arm64/boot/dts/ti/k3-am69-sk.dts | 6 +++--- arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 2 +- arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 2 +- arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 6 +++--- arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 4 ++-- arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts | 2 +- arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 2 +- arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 4 ++-- 12 files changed, 18 insertions(+), 18 deletions(-) diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts index 6bb1ad2e56ec..afefce706647 100644 --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts @@ -785,7 +785,7 @@ serdes0_pcie_link: phy@0 { &pcie0_rc { status = "okay"; - reset-gpios = <&exp1 5 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 5 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; num-lanes = <1>; diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts index cc619bbec181..0ea5edb830cb 100644 --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dts @@ -86,7 +86,7 @@ &pcie0_rc { num-lanes = <2>; phys = <&serdes0 PHY_TYPE_PCIE 1>, <&serdes1 PHY_TYPE_PCIE 1>; phy-names = "pcie-phy0","pcie-phy1"; - reset-gpios = <&main_gpio1 15 GPIO_ACTIVE_HIGH>; + reset-gpios = <&main_gpio1 15 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts index b829f4bcab69..0a23c7f4e1cd 100644 --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-sm.dts @@ -180,7 +180,7 @@ &pcie0_rc { num-lanes = <1>; phys = <&serdes0 PHY_TYPE_PCIE 1>; phy-names = "pcie-phy0"; - reset-gpios = <&wkup_gpio0 27 GPIO_ACTIVE_HIGH>; + reset-gpios = <&wkup_gpio0 27 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts index 90dbe31c5b81..ba7bd40f1535 100644 --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts @@ -713,7 +713,7 @@ serdes0_usb_link: phy@2 { &pcie1_rc { status = "okay"; - reset-gpios = <&exp1 10 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 10 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; num-lanes = <2>; diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts index 3f655852244e..c62ab4caf354 100644 --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts @@ -1266,14 +1266,14 @@ serdes1_pcie_link: phy@0 { &pcie0_rc { status = "okay"; - reset-gpios = <&exp1 4 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 4 GPIO_ACTIVE_LOW>; phys = <&serdes1_pcie_link>; phy-names = "pcie-phy"; }; &pcie1_rc { status = "okay"; - reset-gpios = <&exp1 5 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 5 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; num-lanes = <2>; @@ -1281,7 +1281,7 @@ &pcie1_rc { &pcie3_rc { status = "okay"; - reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 6 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; num-lanes = <1>; diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts index 6593c5da82c0..8cf336c2d5c5 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts @@ -445,7 +445,7 @@ serdes0_qsgmii_link: phy@1 { &pcie1_rc { status = "okay"; - reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; num-lanes = <2>; diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts index a2925555fe81..4c4fdda146ab 100644 --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts @@ -858,7 +858,7 @@ &pcie1_rc { phy-names = "pcie-phy"; num-lanes = <2>; max-link-speed = <3>; - reset-gpios = <&main_gpio0 22 GPIO_ACTIVE_HIGH>; + reset-gpios = <&main_gpio0 22 GPIO_ACTIVE_LOW>; }; &ufs_wrapper { diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts index 8230d53cd696..8709fb11bb6a 100644 --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts @@ -925,7 +925,7 @@ &mhdp { &pcie0_rc { status = "okay"; - reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 6 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; num-lanes = <1>; @@ -933,7 +933,7 @@ &pcie0_rc { &pcie1_rc { status = "okay"; - reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>; phys = <&serdes1_pcie_link>; phy-names = "pcie-phy"; num-lanes = <2>; @@ -941,7 +941,7 @@ &pcie1_rc { &pcie2_rc { status = "okay"; - reset-gpios = <&exp2 20 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp2 20 GPIO_ACTIVE_LOW>; phys = <&serdes2_pcie_link>; phy-names = "pcie-phy"; num-lanes = <2>; diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts index 89fbfb21e5d3..6dc9966b52a1 100644 --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts @@ -1179,7 +1179,7 @@ &pcie0_rc { status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&ekey_reset_pins_default>; - reset-gpios = <&main_gpio0 72 GPIO_ACTIVE_HIGH>; + reset-gpios = <&main_gpio0 72 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; @@ -1190,7 +1190,7 @@ &pcie1_rc { status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&mkey_reset_pins_default>; - reset-gpios = <&wkup_gpio0 11 GPIO_ACTIVE_HIGH>; + reset-gpios = <&wkup_gpio0 11 GPIO_ACTIVE_LOW>; phys = <&serdes1_pcie_link>; phy-names = "pcie-phy"; diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts index c5a0b7cbb14f..0830cba9dc61 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts @@ -474,7 +474,7 @@ flash@0 { &pcie1_rc { status = "okay"; - reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie_link>; phy-names = "pcie-phy"; num-lanes = <1>; diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts index dd3b5f7039d7..001c6fe7e95e 100644 --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts @@ -522,7 +522,7 @@ serdes1_pcie_link: phy@0 { }; &pcie0_rc { - reset-gpios = <&exp1 18 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 18 GPIO_ACTIVE_LOW>; phys = <&serdes1_pcie_link>; phy-names = "pcie-phy"; status = "okay"; diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts index 9338d987180d..e3a393740997 100644 --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts @@ -1406,7 +1406,7 @@ &serdes_wiz0 { &pcie1_rc { status = "okay"; num-lanes = <2>; - reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 2 GPIO_ACTIVE_LOW>; phys = <&serdes0_pcie1_link>; phy-names = "pcie-phy"; }; @@ -1429,7 +1429,7 @@ &serdes_wiz1 { &pcie0_rc { status = "okay"; - reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>; + reset-gpios = <&exp1 6 GPIO_ACTIVE_LOW>; phys = <&serdes1_pcie0_link>; phy-names = "pcie-phy"; }; From patchwork Wed Jul 3 10:00:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13721674 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42F9FC30653 for ; Wed, 3 Jul 2024 10:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A06Qdd51m/cTgDkR7m4qcv00PEC00drBl2l9uZqt1kc=; b=WNWQHoUWZYep6iLveRrqzNH6Du c9giFE+0jO/uiogJwX6EGL1DMEv8IkerUfBonCQkTfd0sOmXqQdPLSdsnkmlR3e+Pvctnw3BQycCX m+xXhJwBROYWHOjqM1c96qXTh5/ZUM4v4xQzMV0Eret0C6240R6R9AH0hMBpV8SdscLR41ybXrsAd NJwK4kbhnJ006uQ/+o6rWS9G6EH0CjZVmQFtdXiaRPQOG1zZhN5UX61HKXF+M30jENTrdDClAfvi6 HYYwckwk3xeQOnrBiA1+xWJAz/ZKgMaDbVOpW75KJTvebTx0yyDN2V3m2VXd2+IWlM1PEleNlTDWc CSOFpSLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOwnp-00000009eph-3Mm9; Wed, 03 Jul 2024 10:01:29 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOwnQ-00000009ehy-2ofm for linux-arm-kernel@lists.infradead.org; Wed, 03 Jul 2024 10:01:09 +0000 Received: from francesco-nb.corp.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 223F41FA41; Wed, 3 Jul 2024 12:00:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1720000858; bh=A06Qdd51m/cTgDkR7m4qcv00PEC00drBl2l9uZqt1kc=; h=From:To:Subject; b=ycccfK8WO5UKIh9tXba+0pbjvyA9JzBznHVFlq9adOI+JqwZxdg1b522/4bMuenfC yOSTw6mIrDtGzsZiHjAWPDF1mwH1WjP16CucB15dVlPPN83zJvL0FD6P9Z4EweenjU TY/9eUFJOx6IwUicuKlkFaKmhumofd/zQJIN/iVJSBAjZxnLhCP2bhr9Sru17hyhBQ icL2C/LcG8ydWLnsqiZvGeqC5ceD5tJvSlhpDDqL2q4fVIfaeP1YrYX5H7hQwQrLMn HsurcXcL2MhlLEtCvxLsufKgJvnH8aHFiZALavEG5o48e+uekc3+PYe5LTF/QN8a9n 7D4A51pofEOHA== From: Francesco Dolcini To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Bjorn Helgaas Cc: Emanuele Ghidoli , linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: [PATCH v1 2/2] PCI: j721e: Fix PERST# polarity Date: Wed, 3 Jul 2024 12:00:36 +0200 Message-Id: <20240703100036.17896-3-francesco@dolcini.it> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240703100036.17896-1-francesco@dolcini.it> References: <20240703100036.17896-1-francesco@dolcini.it> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240703_030105_457090_9FAA3A92 X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Emanuele Ghidoli Now that PERST# is properly defined as active-low in the device tree, fix the driver to correctly drive the line independently of the implied polarity. Signed-off-by: Emanuele Ghidoli Signed-off-by: Francesco Dolcini --- drivers/pci/controller/cadence/pci-j721e.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c index 85718246016b..4d7e1104de1f 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -503,7 +503,7 @@ static int j721e_pcie_probe(struct platform_device *pdev) switch (mode) { case PCI_MODE_RC: - gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); + gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(gpiod)) { ret = PTR_ERR(gpiod); if (ret != -EPROBE_DEFER) @@ -541,7 +541,7 @@ static int j721e_pcie_probe(struct platform_device *pdev) */ if (gpiod) { usleep_range(100, 200); - gpiod_set_value_cansleep(gpiod, 1); + gpiod_set_value_cansleep(gpiod, 0); } ret = cdns_pcie_host_setup(rc);