From patchwork Fri Jul 5 02:50:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengen Du X-Patchwork-Id: 13724361 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C47367 for ; Fri, 5 Jul 2024 02:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720147878; cv=none; b=lRBGKE4nEGL1BHYak5K6NzfbSlcy6ZbLq1yNfTgHMR1bPrL5fSKeO4jjg929e4RLkizfkhMi9A2I7UAw1BCii3JyeCZsG1GtAtSj9kbS/FRyBg8l4rm6ZhFJwSjplm17fA0+3UqOB09Gj4Kv++z6F3gw5l2WMy2eilflPDL9Tro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720147878; c=relaxed/simple; bh=+SqwYfC1A5+GjnJofMmf059emLsqPccapLMwF9uYPag=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PZFxspLZk445nntNk1lEeZoD2OKA618kS4JIdbJhXzbB8gjjl1nWX3EFZnATl6J6sDBR4qVha6yP51cW2Q0kFblylJmiW2Nah5GRuty2IOHZ8uSFnDbswCtRNctSEajNig7GFLpnWDloNPXk6J3UYsMITR4EsXaK4whC1DThS6Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=m5p1vOxu; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="m5p1vOxu" Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 6FA1D4132D for ; Fri, 5 Jul 2024 02:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1720147872; bh=9juZtiYe22wi4ot7/n0osuKqapdtykb5hL7YDbGZMZY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=m5p1vOxurbLMii7GU5/Yu01JV0MTOEXp8E7aaG7+ppvHBqP6jXv4s3pnNIVsKHqYw k8U4wfaXQJlfPqXzkwg/DQLX/poFTBSVxjbH/6uym5fyOygcHnlHOjw5TbtaAm8du/ c0LVCxRDO7YXyCdDEoEYPV8wsDAVU4OM6Pgz0X3BGyEg2+7PwwELlB88vI6BIUBVK/ Auht4bCGTNJgLkfh35AfMOVjxCu8gPud571GCcK3p7J3P+zhSw9KAtHNTbzB5y6gax orYfwQ+7z5CxXc+ajKMDORFw8r65w59i6atw0GFMewEmyUm6c/lWCav8bJKgZtln1W +fK9SV5jx95hQ== Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-70afe95d6d5so919475b3a.0 for ; Thu, 04 Jul 2024 19:51:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720147870; x=1720752670; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9juZtiYe22wi4ot7/n0osuKqapdtykb5hL7YDbGZMZY=; b=tt3KIkG+dHxoz96PkdNL4YIvrtiJ7HHJiI4mg1YeKviwOMglOvVrsrWBF3tnzN/3kw CvBX0nkss9oLNfkzZoyE8BldZWQdyxgz240z29aXBJXR2wjmbKgZtKMpTtepgBhlCJoH XGm/v1xwC00vYEz0cnx+YgGC38sGjgiJJ/RP7gd/6T3T+j+ZzfhNBjOWgGLILfY8r3ii 2aCmihamqFxd8JYuRsgyGscoJS2Vss9+ZAy2hvmVjp58ILK5qIWiodqL5MBTqC3Iy7K5 Scc7zoro00PWUEOqZNnqWUuQvyxCuq0RRlDB1I7Ma52dNF8650PxEuL64wcG3HMLE17l HnYw== X-Forwarded-Encrypted: i=1; AJvYcCWg/b8ucX00sgOtDfhNv0YvkBwH764LWZ1K9dTw2mVIEeA2Kis+9BXwkjpnau3bBUf8P6AF/6SSetVXvdRopBWRNYPNHRg4 X-Gm-Message-State: AOJu0Ywp2LqpnutDiWffvm8YoUmHkSlfxI361X2SuBkU60/hWWVUOcau vtlGQHbYc8Ixh2WcvJc8aIeFuQhgQbGwLkr6pyXJnF/64c/PP9Oloo3zI4axsa2K2r8MUb/aqXO K8O/rPO1s+L67W8xGr+yrOVfTWWtu4ifq428ecK758HQWGcNtcVI41qHUcluHb5ySdP7COg== X-Received: by 2002:a05:6a00:178b:b0:706:5bf1:586f with SMTP id d2e1a72fcca58-70b007eea27mr3847126b3a.0.1720147870094; Thu, 04 Jul 2024 19:51:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDMonNXypqZZHFPjZZyJ8kX9T0YMXjkP88/cDPPt/fAW4LrZB7+keFASdssrTHu8rT8jF3jA== X-Received: by 2002:a05:6a00:178b:b0:706:5bf1:586f with SMTP id d2e1a72fcca58-70b007eea27mr3847107b3a.0.1720147869696; Thu, 04 Jul 2024 19:51:09 -0700 (PDT) Received: from chengendu.. (2001-b011-381c-18de-5dc6-a962-e026-019f.dynamic-ip6.hinet.net. [2001:b011:381c:18de:5dc6:a962:e026:19f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-708029582fasm12926379b3a.88.2024.07.04.19.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 19:51:09 -0700 (PDT) From: Chengen Du To: jhs@mojatatu.com Cc: xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ozsh@nvidia.com, paulb@nvidia.com, marcelo.leitner@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chengen Du , Gerald Yang Subject: [PATCH net v2] net/sched: Fix UAF when resolving a clash Date: Fri, 5 Jul 2024 10:50:56 +0800 Message-ID: <20240705025056.12712-1-chengen.du@canonical.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org KASAN reports the following UAF: BUG: KASAN: slab-use-after-free in tcf_ct_flow_table_process_conn+0x12b/0x380 [act_ct] Read of size 1 at addr ffff888c07603600 by task handler130/6469 Call Trace: dump_stack_lvl+0x48/0x70 print_address_description.constprop.0+0x33/0x3d0 print_report+0xc0/0x2b0 kasan_report+0xd0/0x120 __asan_load1+0x6c/0x80 tcf_ct_flow_table_process_conn+0x12b/0x380 [act_ct] tcf_ct_act+0x886/0x1350 [act_ct] tcf_action_exec+0xf8/0x1f0 fl_classify+0x355/0x360 [cls_flower] __tcf_classify+0x1fd/0x330 tcf_classify+0x21c/0x3c0 sch_handle_ingress.constprop.0+0x2c5/0x500 __netif_receive_skb_core.constprop.0+0xb25/0x1510 __netif_receive_skb_list_core+0x220/0x4c0 netif_receive_skb_list_internal+0x446/0x620 napi_complete_done+0x157/0x3d0 gro_cell_poll+0xcf/0x100 __napi_poll+0x65/0x310 net_rx_action+0x30c/0x5c0 __do_softirq+0x14f/0x491 __irq_exit_rcu+0x82/0xc0 irq_exit_rcu+0xe/0x20 common_interrupt+0xa1/0xb0 asm_common_interrupt+0x27/0x40 Allocated by task 6469: kasan_save_stack+0x38/0x70 kasan_set_track+0x25/0x40 kasan_save_alloc_info+0x1e/0x40 __kasan_krealloc+0x133/0x190 krealloc+0xaa/0x130 nf_ct_ext_add+0xed/0x230 [nf_conntrack] tcf_ct_act+0x1095/0x1350 [act_ct] tcf_action_exec+0xf8/0x1f0 fl_classify+0x355/0x360 [cls_flower] __tcf_classify+0x1fd/0x330 tcf_classify+0x21c/0x3c0 sch_handle_ingress.constprop.0+0x2c5/0x500 __netif_receive_skb_core.constprop.0+0xb25/0x1510 __netif_receive_skb_list_core+0x220/0x4c0 netif_receive_skb_list_internal+0x446/0x620 napi_complete_done+0x157/0x3d0 gro_cell_poll+0xcf/0x100 __napi_poll+0x65/0x310 net_rx_action+0x30c/0x5c0 __do_softirq+0x14f/0x491 Freed by task 6469: kasan_save_stack+0x38/0x70 kasan_set_track+0x25/0x40 kasan_save_free_info+0x2b/0x60 ____kasan_slab_free+0x180/0x1f0 __kasan_slab_free+0x12/0x30 slab_free_freelist_hook+0xd2/0x1a0 __kmem_cache_free+0x1a2/0x2f0 kfree+0x78/0x120 nf_conntrack_free+0x74/0x130 [nf_conntrack] nf_ct_destroy+0xb2/0x140 [nf_conntrack] __nf_ct_resolve_clash+0x529/0x5d0 [nf_conntrack] nf_ct_resolve_clash+0xf6/0x490 [nf_conntrack] __nf_conntrack_confirm+0x2c6/0x770 [nf_conntrack] tcf_ct_act+0x12ad/0x1350 [act_ct] tcf_action_exec+0xf8/0x1f0 fl_classify+0x355/0x360 [cls_flower] __tcf_classify+0x1fd/0x330 tcf_classify+0x21c/0x3c0 sch_handle_ingress.constprop.0+0x2c5/0x500 __netif_receive_skb_core.constprop.0+0xb25/0x1510 __netif_receive_skb_list_core+0x220/0x4c0 netif_receive_skb_list_internal+0x446/0x620 napi_complete_done+0x157/0x3d0 gro_cell_poll+0xcf/0x100 __napi_poll+0x65/0x310 net_rx_action+0x30c/0x5c0 __do_softirq+0x14f/0x491 The ct may be dropped if a clash has been resolved but is still passed to the tcf_ct_flow_table_process_conn function for further usage. This issue can be fixed by retrieving ct from skb again after confirming conntrack. Fixes: 0cc254e5aa37 ("net/sched: act_ct: Offload connections with commit action") Co-developed-by: Gerald Yang Signed-off-by: Gerald Yang Signed-off-by: Chengen Du --- net/sched/act_ct.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c index 2a96d9c1db65..6f41796115e3 100644 --- a/net/sched/act_ct.c +++ b/net/sched/act_ct.c @@ -1077,6 +1077,14 @@ TC_INDIRECT_SCOPE int tcf_ct_act(struct sk_buff *skb, const struct tc_action *a, */ if (nf_conntrack_confirm(skb) != NF_ACCEPT) goto drop; + + /* The ct may be dropped if a clash has been resolved, + * so it's necessary to retrieve it from skb again to + * prevent UAF. + */ + ct = nf_ct_get(skb, &ctinfo); + if (!ct) + goto drop; } if (!skip_add)