From patchwork Mon Jul 8 16:57:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Oliveira X-Patchwork-Id: 13726874 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97818C3DA41 for ; Mon, 8 Jul 2024 16:59:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CAAA6B00AF; Mon, 8 Jul 2024 12:59:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17B5E6B00B0; Mon, 8 Jul 2024 12:59:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE95E6B00B1; Mon, 8 Jul 2024 12:59:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE3716B00AF for ; Mon, 8 Jul 2024 12:59:28 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 80617121497 for ; Mon, 8 Jul 2024 16:59:28 +0000 (UTC) X-FDA: 82317196416.11.C2A28C4 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2098.outbound.protection.outlook.com [40.107.92.98]) by imf26.hostedemail.com (Postfix) with ESMTP id B2191140025 for ; Mon, 8 Jul 2024 16:59:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b=ba9ew+05; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf26.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.92.98 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720457935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lYp/stGLWTk2gTG0FcZxnAS3NZ14yVcWXZJlVtyXPTQ=; b=GTdYHm7Q92osypqwCjAswHnmI4fIhdbnNbihUV3qYpClzIqHE6DDbLXFCYCzNl3dwvFJuH SU0y4UJ7Jm8DBDaMvLYZswB4WQvx55QWTICOFaaL9GZ1RPQeq3/+VwFJLFxoWxWTVLeRU0 gzvep4iKLnIkTQ8z3cUUBWPa2Smys1I= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720457935; a=rsa-sha256; cv=pass; b=Bx/4jre6wGnymnAx/q6X/SNrbeHr6wfD8kQ/BDrsW8FNv4e2Sqs/9GidB5KQQqkFqu+Yun hLXEc5P3YEADQqo89hrldf3gKtGddh4z49oJBg19DTJxnhk6gylLaTRIZsUFXWY5WAOOnU 0L7eo9fEfYssUkOvBlV6n6p1Uz9tlNQ= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b=ba9ew+05; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf26.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.92.98 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com; dmarc=none ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MjtVhcClUyfJw/wQMbOMh68lYH0+822o4eSifTUdYOaWOeT5725kRTDhejlww0cPEvEpWxkRIbQkVSVXUe3gR9GFpUhvkc6ghLuHIrnoSIs0sq8W25TeJ6ArUpaOd8zGi4W7a8TaiKhOX1Wbo/ZJhGsoCt4fLeSM41w7nYLHxOd9uvj98/B72mNj+Dspsz0xxVy+mwH0SO8hQgx4VTqtyO9y0gzeDCtdnfLFqzbkBfcxOEGHetW1bvFwJsUTs2aLGGe+tv/X6nS5AJzjeXlmifTwYXuV78EfCelQ7QbUF+RaJqnF6NMmckXNIcjERan+8e/CXVmrcExF/lQdECEDHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lYp/stGLWTk2gTG0FcZxnAS3NZ14yVcWXZJlVtyXPTQ=; b=NaM71RJeF40dwkG2ezAS8fkWYMmqci1F2fZ/N/MWftzMaM3y878+a8FqEOwg5b3ldzzPGyr5cgvyan4FZlSq80ojc+nmZ2tt2nX+Top/VsVsbFaep+iJwpn8CBsno2fz/a7ZdLuFg4SdWvDxImvSl3KN8goPvkz2n+kZ21Jjg1/a4XhMssQxw3t1F2ZSMzV6C4PhBL3ANF7gLu1e+wx06XR1Sk+xbQwww98aUjZ8UgPNbax7gx3bmgIJvtZn0M5yP/eXYwzaOa/4rEadQaVtVtmOlvO4836k2KPAI60GyNcdaRCnVjaQXwB5SZyAxdhWYX6T+3pQDvkPNSyOjw28pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eideticom.com; dmarc=pass action=none header.from=eideticom.com; dkim=pass header.d=eideticom.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eideticcom.onmicrosoft.com; s=selector2-eideticcom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYp/stGLWTk2gTG0FcZxnAS3NZ14yVcWXZJlVtyXPTQ=; b=ba9ew+050HVndYP3/8eDoY7TdBdglurTOcQ/uebhOyJsk9vkdH/G9Qir88aXjkW6kg2va4ZHyI+bdTMcUeyDB6xbAjNVBs86vEjNfhwU2gWWyea6KMrluMm1tMelDkUPttHBhacPFO3i2RCOZHtv2f8GmQoyL0Zw1d2LMFbwKxk= Received: from DM6PR19MB4248.namprd19.prod.outlook.com (2603:10b6:5:2b0::11) by BY3PR19MB5028.namprd19.prod.outlook.com (2603:10b6:a03:361::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 16:57:41 +0000 Received: from DM6PR19MB4248.namprd19.prod.outlook.com ([fe80::d508:c71a:eb4f:7cf4]) by DM6PR19MB4248.namprd19.prod.outlook.com ([fe80::d508:c71a:eb4f:7cf4%6]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 16:57:41 +0000 From: Martin Oliveira To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org Cc: Andrew Morton , Artemy Kovalyov , Greg Kroah-Hartman , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Martin Oliveira , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: [PATCH v4 1/3] kernfs: remove page_mkwrite() from vm_operations_struct Date: Mon, 8 Jul 2024 10:57:12 -0600 Message-Id: <20240708165714.3401377-2-martin.oliveira@eideticom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240708165714.3401377-1-martin.oliveira@eideticom.com> References: <20240708165714.3401377-1-martin.oliveira@eideticom.com> X-ClientProxiedBy: MW4PR03CA0252.namprd03.prod.outlook.com (2603:10b6:303:b4::17) To DM6PR19MB4248.namprd19.prod.outlook.com (2603:10b6:5:2b0::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR19MB4248:EE_|BY3PR19MB5028:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e92b340-5a31-4b03-27de-08dc9f6f144c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: IcWMnKsPssgtg7sMcNbp3lUM31I62TRWhcLkxEV2wkZ7WLqIOgkMV8aLSxuZprlYA4hsmT+D2v1Rn125YdTVDUgZBRoZjEjbt1CmP3DSfZSpMPhZyZtxPv17w68Tfdota9iy0YOaYvJtcYQ5KFyt6NFya+Mnzsd82xklTiZ/y0Mwp/Rqh7TrzfQks792HHzOGb3IdMa6ZWulBHJJcVugCVunH2rB7MNFu+cZ4sz2ZpZpnQmSemG7yHbjTMFPDRAhxw8qeSUX/imuLqkNyN9p3BQ5l6rqnOuC1q3N5WmSTshY0qs42HWqwgjhXGaETiuDV6tiwiyE+sbYyQTEGIyL/ozEJ2401PZ+FfRUt29+eotFYbcPaADmDnWRWG4f0wYuZj3X7FnjoISJvAFPRaSFPpngS8q+fh7Gmar9h4OAxvVyay7xvmCO/VMo5/xdE5ADCAwBQjv82WER/vbp7BwAjrA8eduHxLGR7Pp7zVbBbKpAxo4wWQokUJQ3FUF4g1bQTwXeE761SEr+JGw4FQJt15kINGT1NQdMsZdm2MRtSIOdNMS1Q/bf2u6ehwfJe8XQD9aUopGAm4lZb6fwcWqhtVEAc6fsTzFM7+vTBGf/iSxIGisw4B+p9vTmv4QUDaOdqI8KmKhGufgao1hkIiPLU6NsKWkbHrOvWl1C31CIfgT5GViOuUtFk6XUf6yRokWaAZpoahshaV2xR3++k1vYxTGLOL3v+h5y1r+ZZouyYrv20CjYTRA2KUroBLyc625MiFgO0tjAAHAthSCzH9Cj7qHjM5+DYAhAgvHkBjv4k2S/tmgBy6UD3dEUYR07Rhh60t/f7/fpaAjcQzkg0I6dFEW0pMa9kwqzbANqSs40ifNEacfR4R2T2txRfb9C79jJnOSXw9WztJKg3IKv/TgA3f6u6o/abaHdeYr4fOP31kKkHBB1yhmNyLr6Bn/sYuhxLGdsyyjMOb6N3E7S2n8wDDBKfsShU5IYIw+QILT/cq15mrKcEfXPrbgZLArdM5DL/Q6/fVP8qV46qwQDGyRUIy5IvVvWJjqPNWhpDDxhA2GLIP/oOz+sUg7L6LfJkRSEuTxyRyFPiNxy0yDLqhTenEuXQg8ua58e8AYMeKuhwjmnKk/iWaSlaAbg5ocDQXIZjdceYQOg5h4JLrACtqmn9mxQQQEdkKTFZChRiWqRWl83WuP6fgeJY1IVhY+mnsuXhTKV/5od/aGytMPqN3OYubkGCl5rEaVtWQwetMjhdARXOtrc5s5hlN1FcTdVPJQzortWiIGbF/D1MYxMWiz6eV9kXovW4u8rkLWP6X4SiL0rvXA2857i+HYdd5M99+OU533f0HTDxYfGAQ4XiFuJFt2E/PzsBPevUBpvwV1ZM3SfjGS0h6BMHK5To4u0H6RchpBx6+FqJf8qreHo6OfseA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR19MB4248.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: aYEd0Lp4zSKqOMA76BPNObq+2MjX/D1q1wDF1CQm+pY8Q7eTBC8yUa6ELcBRgJ82h2/RNQu2Huyg3iVjP/cW7srdmKJQ6GhOUyqiwz3KY8ySE+LlE79MMriZRZQGAP48t5LbVC2Pvzt8Ynll+1ewaHW4gfHZLNqFH7cDbcU2iQV2K0gd5SB8uvs05VD5K4ZWcKpA2iSqTZYQJURiMUx9bC6d4/PrOsmbjXxn7QoUP8MoMJF1jRvPX3tLX80RmqS0PksaSILlYLeX9Hw56Gq9fv5C6BZv8lPkZLRwvb3w7msE+oAHatk7S/0yrbH1D1he3ShMOwwmwlXx74BOTrATAfZa8tPZeXr6zCK8Eo9YsMdFA2FcPvJ1r3wNbV8mV39x1DuQQHt7aVR9c8dxOFBVcVC2z5N6/LGZRtHbDQhopFYiw0sUZgJT8AppHK8mUe4aQqJSNUWLb4y6oSHj4PZQ3fbzNZSUiv4AIqkUkSvQ0cBZ/flCaVVh9E/2cKmKhQKw/hqppmHJfGexKB8VWLpIIKCksSGBQqofhdsIpt6rNQoX2CQ74pBwcs3cUtMF0sg+xaIIabPVxI9PvW7HjWuSke+4YcAvmulGNioo2MU/uEU/1Fo7rstz/ZqpdDDHdjQgUBZ1mcsCs+AWal75Dy38OIbWMG7THUm5MDVyX+RbZGEaAPGXvdkG3ztee0Yh0lO51Jbhw6HMtyef3C/c9MTKsh7r/VFVI+Y4HPtdoaDzokFpv8ga68V3n3bDelOg19KPQvwNRNmA8KjcbR/RidToHj7sW6u41pfodx3ENEW4+GzTljt/Oej+FTUr5nc3Ppy0I49/auuwpBi5/fqLHzYmqCAYbj2iqpsO/yrxsulbZ4AyI32nkbjlPSLmMaGAKF0lGHHof6uOONCWSeQnE++BRZGfNu8M5WrYLkBti21yTZvdCoM8q7vHP7cTx/Zk27OcUT27QLcO6Bqu9dk0RfiYFJu+7/m9g6pDiOOX8+rtf6CilJSGNyzRcRumO9HFgFfuUWZUgDgI8wnDtmc1Xed/kA7Pv9qFMqQJO73xq0qJbF+dRDoik6xZw+g6eJDP6WmYgo0lzjNHG1jXuX2xXPyCEdhr67W7Vmj9xZYcN/zGf6Jwk0ng1IXmS4kbn6o+i5nsEISbyBAptvDOjJzzfu7EqLtDtK/2mTHedp2FtiPBbnHKE6t7IyEKlRR+2X5chyzlv0prA/dj4WCT8WXZwY5viv/adrj9svCekgTRvVSQbTBvcLnQRFrWcqwzZaF7nIfuMPxW9cdXR1crzsIBikAzV+bPACtJ92VNl2QdE+Ey4InsPHQsCoN6+wjn2BKpcaFD8TbkDr6PskCxWBoaCzRgniCxfKS6h7P+p49TUNQ3SOGTeEvVnd1aDoHtNTWy5jmx64KW+XN8O0H2BJL47nzFlbC/aqqSuXUwfdMKLEEtBN5NXMgRgkuohz6DoY5nz/qRtNu27i5B+FNziuCi6412tnd6ju0i2Ss7jZ/TguTgLfVod4knp4tjAUgDtBOQ60cu+0z0pFQFZyHYzifDGxM3onCkdMrbLTJjfAmiP0OcWhiaunnx6+qQCe+DO3vBlRGkG2FmEIQAQz8yvjyximoGnA== X-OriginatorOrg: eideticom.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e92b340-5a31-4b03-27de-08dc9f6f144c X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB4248.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 16:57:41.2017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PGdH6cDoMyEtcKqfpoB1Ble3yPwJVLhSEpDROfa6n7Nd00BXZYTlOIjmvJpEW+Y3ABNxobxSPg7W4A+ap0NAFOeil2sPrroH057X9cI8q7I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR19MB5028 X-Stat-Signature: rxrgg4a4ouobfjnnck56dkwjdktez94z X-Rspamd-Queue-Id: B2191140025 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720457965-852371 X-HE-Meta: U2FsdGVkX1817RXUUrFkQNwbg8BN7GAYQiMRgz+BDigzD3jKfE/yP1EPQmhLPHM93XmBOcjG64oN7T/RNWJBkVKXljcvat65EgcKdJFBxYrs022tJ50U552kkBiggpACqyO3ZxVf5ZrNlLuXc0IqC2sQH1+M0Y54w3LJZnQR+n2BNpfskbUIeg1HOrx+f2M+ZKHy37zoORexVKescI1S2/j9pRHFOjeLSEdNfArSIgyV6ZcN5jAYhzlTyEz2f4yYSPtQGwSy3R9GjBepGcZtoyzOXED9NBbiUtAcQ4tNu9xHjNG4z2AuW3aqPPt8i2fd7BLCJrR+QGua4eHg/fz1zt9hwuUzQzBuSdqNBzABWukWjT1FRSohJQ/IzDJSuAxMXhdN5OxamP69RTZrmWxXawNU1n+NxHRlsUMLJ+Qli8z381bVgGtkeh8vybD1QY3MytnfuMfW9gZgmW+ZXzvUjf4k4PkpTKvnxcRHsMj7YDGHE0KNGfv70iYMD0qEkpLNVIgK13agLofzK2IoDNVmcEqXssNCRXK0lc0M7cheTSQdP8lPeUJpsXV0vo2CT7R3joKkYdFijs5tmJ1Zlr8Ocr40ID1n1RpLUwu50ZIiyWAwHdU1BEvnYf1rFR72UC0T7j83WJW5Va3rIRTuLpzO8+U9lFoYL1rtDbpga26Buil02z39iCRSv5WEttmR1rYUNnLqwiRQnoRR+kqFPJVj04Ym3uiqW0tlQziC3dfOgVMT6OKFmZvnQ/IwRYKDSR0Dh6zXehYyrqS3tRiSPYsCkMhdx+wNhsLkfveJgUHjOXbBUVZitmBH/PxYfnBYOR3ehph4zEJTpYVH4YquUlwkRGgoJ6xWJf4k/tgh88bxBk0jcVjEJ27WnvUoSpk66EykS1mLR0TApvzzSHxVF2Y/Z6gMOPq83zs8EbDQntbP3RY+Je6UYlvr2r5ty5zD6W+4+Aq6T3pyFLtTzrv7qKo E0k35Zcj ZsSFZfu3gdPdte3CXg0oWwccFHtraOUgHI57IeBSre2hF00P6JpYVeP0+fQXrhyZ4oq6If6tmYLaxabb7st8YlWDejXdLzb8EI6lJQioLxEgrz0Wqb7//vohxVQsrhJCWde/kwAcRIhSN6odu4UZ05zacW0tmYIjQvMrEsknu3J8JKwzFrwps9zh4NCuK/8nxZent7nhRx0zwzBddxiaqEVRnqu3wUHSznkRY6VKBWDMjxXwDn2/TytQ3cY56G40poF3A64dBUYIN4FCGq1ytjaFIHU0MHJSG1AI2Fexubl7s+AqRfVJ9UzYzIl/hyFqdtnhZGxKedyXWg4ZSJBKhx3RTQS4mevPqrvFX8NgvA6/bk1sSH98Wb9+YwAiBdAy2irypHnKRrTdckwRU4C9DcxrSwB3Dx9RArqmouxViSjo6rSw0tn3He3YD1H2FpjpCcJj8QkLdiIxskCnoIo4yqqE+LA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The .page_mkwrite operator of kernfs just calls file_update_time(). This is the same behaviour that the fault code does if .page_mkwrite is not set. Furthermore, having the page_mkwrite() operator causes writable_file_mapping_allowed() to fail due to vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for enabling P2PDMA over RDMA. There are no users of .page_mkwrite and no known valid use cases, so just remove the .page_mkwrite from kernfs_ops and WARN if an mmap() implementation sets .page_mkwrite. Co-developed-by: Logan Gunthorpe Signed-off-by: Logan Gunthorpe Signed-off-by: Martin Oliveira Acked-by: Greg Kroah-Hartman --- fs/kernfs/file.c | 40 +++++++++++----------------------------- 1 file changed, 11 insertions(+), 29 deletions(-) diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c index 8502ef68459b..fb2b77bf0c04 100644 --- a/fs/kernfs/file.c +++ b/fs/kernfs/file.c @@ -386,28 +386,6 @@ static vm_fault_t kernfs_vma_fault(struct vm_fault *vmf) return ret; } -static vm_fault_t kernfs_vma_page_mkwrite(struct vm_fault *vmf) -{ - struct file *file = vmf->vma->vm_file; - struct kernfs_open_file *of = kernfs_of(file); - vm_fault_t ret; - - if (!of->vm_ops) - return VM_FAULT_SIGBUS; - - if (!kernfs_get_active(of->kn)) - return VM_FAULT_SIGBUS; - - ret = 0; - if (of->vm_ops->page_mkwrite) - ret = of->vm_ops->page_mkwrite(vmf); - else - file_update_time(file); - - kernfs_put_active(of->kn); - return ret; -} - static int kernfs_vma_access(struct vm_area_struct *vma, unsigned long addr, void *buf, int len, int write) { @@ -432,7 +410,6 @@ static int kernfs_vma_access(struct vm_area_struct *vma, unsigned long addr, static const struct vm_operations_struct kernfs_vm_ops = { .open = kernfs_vma_open, .fault = kernfs_vma_fault, - .page_mkwrite = kernfs_vma_page_mkwrite, .access = kernfs_vma_access, }; @@ -475,12 +452,17 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma) if (of->mmapped && of->vm_ops != vma->vm_ops) goto out_put; - /* - * It is not possible to successfully wrap close. - * So error if someone is trying to use close. - */ - if (vma->vm_ops && vma->vm_ops->close) - goto out_put; + if (vma->vm_ops) { + /* + * It is not possible to successfully wrap close. + * So error if someone is trying to use close. + */ + if (vma->vm_ops->close) + goto out_put; + + if (WARN_ON_ONCE(vma->vm_ops->page_mkwrite)) + goto out_put; + } rc = 0; if (!of->mmapped) { From patchwork Mon Jul 8 16:57:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Oliveira X-Patchwork-Id: 13726872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32C44C3271E for ; Mon, 8 Jul 2024 16:58:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACBD96B0088; Mon, 8 Jul 2024 12:58:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7A3A6B0096; Mon, 8 Jul 2024 12:58:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F4716B0098; Mon, 8 Jul 2024 12:58:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6CD046B0096 for ; Mon, 8 Jul 2024 12:58:01 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 181C8A3E0B for ; Mon, 8 Jul 2024 16:58:01 +0000 (UTC) X-FDA: 82317192762.11.311F940 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2090.outbound.protection.outlook.com [40.107.94.90]) by imf04.hostedemail.com (Postfix) with ESMTP id 512C540007 for ; Mon, 8 Jul 2024 16:57:57 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b="AisU/B4m"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf04.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.94.90 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720457848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QGCtZ5R+9+ggT5pXZCULkbLLO7rsRu7vy0kuObEqwzc=; b=7SAbF4pxbJ903IV6X1VLCHL7D+Uza5TMvildhAotw9abkJxfNfL0c4C3vxYneesLinYa8d OCeZrY8KdbSTq1Xjrn9mauHQ7/wWZ/kWNocr6bRJPvoFOOAKkvMvCFilmHsMnnYMdXYDGU o8sutS76bfDMI1UwoJDWrX9+CVMbwZQ= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720457848; a=rsa-sha256; cv=pass; b=glT8iz6qkp6iUjY2kkPUyyi/XKubhhuGGgHsCCBYCZr6mFaDyzbWCJpRzFNCNxi4uoZDqU 3FBd9nsoq/bUBjX5g62TrcZTvbamww+NPtfEEdkQjLqUBidTMFvf8JNLmLzH0uAIAiTT7o Ia+C7U2CzHNItwjH+4BClzbEdLXbQQ0= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b="AisU/B4m"; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf04.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.94.90 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com; dmarc=none ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcV9p0yKaipeMnYXL0COcO9YejgXMxzXeQ9v1XxuXRgbN/DVZbGVwOR0lyb4Hr/QkJV4dbZAmgmUcbqRGseRvXRm5bcoa6qoke9l9+oMF2UzHfeerZDi0wO/ZEp4WdXpXXOIWCvp70tzXTmvrvqnmp9CB4h0e28rm+8EWVbOBDJ/i6/ygIiy74VGu0ylyzwbpDiS1QGqHeLDfLHc/32nzWplG1NSeJaCXq9qpUq06R1RnsQwfs8hUTuzZDctVb6B7KFIwdGZrT9vk9FJlPzlmgDz/Rz3MaZKdEmnTt+Ip2NY1Uenl2NBUFgkWwSQKBH/JL8dt0UDsuuC1UP0jMZUfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QGCtZ5R+9+ggT5pXZCULkbLLO7rsRu7vy0kuObEqwzc=; b=Mff2QxXv0KtYsFlPLlbLf78RHGnmg8mypeXSoOpRTj+fJXut08X+HwSy+ELJ2Lo+tBzv+8IjH+ACFjxC46W4tYyFvR9WWNrgcjO0uRxxcahJjoQbPVLfhrwtK3r73VxKhxV0JvmtP1empVPprbONsTldwThjT9apP0r66UGVbNv7CFG5wM3xTiDVwGOQK83QCp7Frb0v7Xa8ajyb33CYAUu3eEwg4EBQ6pHqFSg19iQZgTI8wHpyO0m/rGrCTM48EgP/nQA8lFTN46uGP8f3rXFnu3UBDMfMAVDrjWILmJ6PIpbQ3JQUL+qvDdKZUGlt0xTKgBkTm7miUmtzr9mjAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eideticom.com; dmarc=pass action=none header.from=eideticom.com; dkim=pass header.d=eideticom.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eideticcom.onmicrosoft.com; s=selector2-eideticcom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QGCtZ5R+9+ggT5pXZCULkbLLO7rsRu7vy0kuObEqwzc=; b=AisU/B4mBvAE4ToJqcGvsQSfGuRX9tFJ312tXXdIG5j59iNqDHPDD2Tqbfp2TrGaypoQA08ekiPOlEHvrNeIy6uR7sa6pEoj/0thiN3eERaMr/WAKla4BmR7xZB3PvqAPpDTF5esvD6D5DYgqy6VP4TDt1UN+L4qiY07hx1Id3I= Received: from DM6PR19MB4248.namprd19.prod.outlook.com (2603:10b6:5:2b0::11) by BY3PR19MB5028.namprd19.prod.outlook.com (2603:10b6:a03:361::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 16:57:42 +0000 Received: from DM6PR19MB4248.namprd19.prod.outlook.com ([fe80::d508:c71a:eb4f:7cf4]) by DM6PR19MB4248.namprd19.prod.outlook.com ([fe80::d508:c71a:eb4f:7cf4%6]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 16:57:42 +0000 From: Martin Oliveira To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org Cc: Andrew Morton , Artemy Kovalyov , Greg Kroah-Hartman , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Martin Oliveira , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: [PATCH v4 2/3] mm/gup: allow FOLL_LONGTERM & FOLL_PCI_P2PDMA Date: Mon, 8 Jul 2024 10:57:13 -0600 Message-Id: <20240708165714.3401377-3-martin.oliveira@eideticom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240708165714.3401377-1-martin.oliveira@eideticom.com> References: <20240708165714.3401377-1-martin.oliveira@eideticom.com> X-ClientProxiedBy: MW4PR03CA0252.namprd03.prod.outlook.com (2603:10b6:303:b4::17) To DM6PR19MB4248.namprd19.prod.outlook.com (2603:10b6:5:2b0::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR19MB4248:EE_|BY3PR19MB5028:EE_ X-MS-Office365-Filtering-Correlation-Id: a565de53-4a60-41e5-1795-08dc9f6f1535 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: GcuMzkadVzg1uRgFFK79GIqPLg+m9kcO3Kdxx5j/OeMQ0ScGiT42fScXLm6mvaZPg1qc4jkO9G0m0kS4NSBuNUDRipBr21BEZsaFYxNaK80X7vjHaSGQx0VzH2Mj2CHMIscNMdh+eJc/XvrJnF5TtoFahj4xkeRfq47NbSk5c7Bc/bv2u/VsY2IH664uc5oMd4rPwhfxy7cfc53k9Z+iSgTiBMzqTh9ANjGJ/a1AKkG2nkA1a55FLj4rZLbCHs9yRx72OO6LyuW3VaWgwjFEAEc+Bs2hWQfnaShfqwttPTKbCTBpGEE2j/sK0yOZfgwlvGoiktOYzz49B6NMr2cCv+UjLnGeAWf4t+piU46KPjqusNxs3KtM8cCkNBJcEsG7kd4QnonL2yzw/LmqLoE3opn49HUSORn9zTSVTk29DmPrXEob4woTOfPzN81UReGdatpbsgzwZq+yaqLDEYwsAL1Ta54gz94D0Pz1S1MWfE8Vil7tQ3PeHbGPITFAwq322l+sqmaRTfbh1+0niU/yOzGpINGKuCFf5nyCISrv2WcPHZaqhAEwBKPORa3zfI6vDUu3zhPY0no+vUh66d3tnV2lUR/2SxXMBbmer6kF7EuuaDd6+55+25JA5BA2mRTsPCjT1fqqI/1q/L2fCRE/d+FtsFaNV2zcb86unZZHUYKdX9bjCTnxENu26h2gKXQb5LQ3houNokw/+Lg2fT1TUdP9G6TR60oiMtdt76L3G2905grh00fp1u8xGoVLiIH4CGBoKID2dW6bREWbzrfyHakX50JjSlZYotGUBTao+8tXaIoGxwIx9Rx89qA9+AQnINVa9Kx9AMUFLEwmYprYktz2bXFZdaJW+QY66Anyps0S0Gxfn5adYRqGnYKtfDxRv5mhu6SJB+9VbrGFpgKHzRKigq/6RWA/TLUV6lTq5FeboMDQd5VeMqfxAhgzDOOACh62UfDoaG2icfwmRDEr0AuwlzhuCA5Mdqt2hL0oecO8G8jmxjbIUnsUsr4pWm4KtI+hTmWTaWADIvMN28JEOfiH8CYRu7w4LplGhdCEg43/k8iv0EG5WW33jox1NI9HefbeIZGYVIyvtiO37T+s3U6LifWgDtQv4IdrUU9s+lhG85/mTeDgHkGxqOHaMiW0CylHy98sSI4bDPgY5PaW0TAvY/NEJvbWX2z/E179iZJqyiIZ+nwINjQPPzrb8UBfNIYCwFvU574wQ+6TYVUaT4grawKlcbeFh4bfuti7ATv7+7fTwbd3vUUAaIlWxMHPNwaHSGXkUJHC5fmHOjz9bEzGunXOmpygj7IwRtI56X9oH5X5iiMWxQ3qx768F2apkQ9zcj651KzTH3wGT+CvY1urdlRgwD9pTnLBd6d/GF4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR19MB4248.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cFFfOj8uKA/93kkqnQRtaAUVwOG/smG10ZfVsuknHW4T2wksASUkUJr5ZmxPKr0ePK00ndD+k0Fl2MappZ5WLFVE7kTq8QSE1DHVRcz5g57czfvYQLI2daOVCJ9ZwBee1IkUxWSc9d1hV82kOF/hgSimo/3Ck80YFsxAE0qSx8S7IHp3ZVaXfgcQzqIsjStCoZ/8gkk7Sk46eVpUoaAfJTg9DkPmf13lifbkUa5nf+BcI4vSx6PzusQpU3CNUuMJRO7vDpv5PKY+lzPMjtMTX1hkonwK4FRaHP70RRqB7rjoQlIYmKcR5twl7RXWmo0Z9wMi78u2LYjXk0E6cQGYTooupiP++HtSpMINHFwheN79E+i7P8DJzbwJ8wsDEg8xGOIzpNsM+9dUiWt6BTLYB46ocjjSBu2Yp9i/1UTuURbc9/ln4jW6WfEkl8rgj5qbhNYkJMpI9Mxb+euz4Xv4Odk+6WBjpukgAhYeY8fYq1abkmoVSyjifSjTfYs54eh/cKGOc08wO11ftsgDH1COABEDPcewnete0F+0EIOGYAOe1IkHOl/Clof7JBylhtCS4gbTq7C92dkJ/e1d1kEDh7/G+6s4qRy3cdLnAPDjKerbBhJN3qXpQb9A5Bbd6tXR8Sw3gGcmpqE6tYhnjBgWW7/V5weGPtY6+vDsIZvfiopNHj0F3GkldKBH0AHeNsoUCek333KKIAH++K7bbxlqHSC/qTZ5qPdCzEUcP8pCprCE8JGquDPGeR2e/ZSNBNfcyI3MRqKJD8HnHV6nXO74plx5JEmlcTpBpxb3lgMflRuAmaIaJ2pMqRGzRtLKmgzaHQI1L/ll2mvwJWQDoSDiibZmD2rLExQmNrWueDm3oxB868T4iwn2vTiWe4IAUtuoA1vNQnyUdKwjsYS88UP1Z0Wk7q0n1MutwazxeEMPtwESNjQ0E/UAoyk0/bhApZ9tekUDlEs7WfOyCrsSxNESr44qbUGazquPCbMdHYmxGrtcBWrowHVQAv1plxEAm0RS8Z/UeyxzO84Pb+watDM+IH0ufOWWPwb32VopdAwqMVq+Be/d6wQ0Y/gd86nd2HvHYktpF6+8IHkWgzflJoiYuZ20fx6ZHcugffFRINyYO5wumGTFUGmkekACsELjaWGWm0hi+GNSOTwsYYq4INXMWokvZvF7FgJJLDJguh6bmldfbB3gd1amIFfnU1uJS7K2Wz4Lk9R6aifKnz29UkY/tsW2XtELWDaJ2q93F2B1G+TRGSGSk3D9rtQszoWZnCLkFKy+2mijEgfHZ2aD0z1C7XMosb1BVFGLQpMMorUMp8H1UDr4AwneB4oUVFCweslVddLBthscVvQjeHqagf4cu9tS1s8j/ZcpdT89/SExgY59ww94R6XOuQgoL3nps7NtC3hdO1ZijQXfw98uPde2jsTXXu5GgnqPoDoKjs9ICrC0kskha/d/pO00ux6hWFSgvbcDsHVV2dD2uOdaxzKmAw7VJxoAWVWM3mHIsaRgbheYsBmDFG469eOR2NyV29XMiBcinMeunrJivFoOKM/RrqRaJedglM7/qgf3sUGMmCEtWnG/eBoB0TuQILVjgY1wORQZart1YKnJx9qutXOUag== X-OriginatorOrg: eideticom.com X-MS-Exchange-CrossTenant-Network-Message-Id: a565de53-4a60-41e5-1795-08dc9f6f1535 X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB4248.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 16:57:42.6777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VlP3bq3F83T3k9tXtjmOfcc7f9e2XX4jl57TxugKdT0o40PQnHxuzBuL2LG/zUxSZIzvaO4PnZinMvcWo3mBwSNmEmnfRsmOK5IaxAj9NoE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR19MB5028 X-Rspamd-Queue-Id: 512C540007 X-Stat-Signature: 5b9fjcm8b8dy8156dzm5jkg5q6paogfw X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720457877-965974 X-HE-Meta: U2FsdGVkX18MQK+JpjzM0L4lZaGQztRxrgtjDkecZtk1adAsrdVOBmjPcxtrsTv8vpBBy6DGSv+6i+N8MX+glg59+ydFXI/koiZx0Mpmjcd3E5tkAGXRcB95RPx5i59dYgLc4soY7PwuUIsWp8yVA68po9ZbZMXWOeCnRib63artBS8392FqxzKe+mYPlz+2a7hFBTjoN8czVoK9am4noK0KV5AEsfbQ4vnb1KV8c4HDyiPDuWxc/YXP6WW5tJsNNdHqtxvcIbA+ZxfbchSHwFDD7V64fO13k+T7PIHNVshFrU1UA/DwO1PNgmemkbBk12AjkZvNcbdfg9vOiHk8+63eazpDa6qfyeK9ARVXjybWObGrUO1567lfqvX0f26z8pkccVEKcbFQ0iP6KeFueOkHqvNntB+r3N2TW3M25EP4u4mBgQdPBvYd6m/EO5eCd0XWLqPJhY0hd0ggdtQ5UjF0zp2hoBsWszR7FL4zLiMDwolXA0SSOASRmPDn9dd+cgSSYwS2i2+N8HlZDb6gsW8qeeIPtFp3TSoTgx8DaVL1C8eDFbjfHzS2pISAHFjCtWNx913RkfFuLVFdh/FeQeA6hhh7meUtgunHofhdRGkIJK4CbKJnwFX5D2A/Up9eYUm5tgDPvxAF3ZxVCw/E2xjrN+HUwMwbEYkHSI3Ws+qU7t+wUnhmaAvYyFB+2FDXL0hc7ruoeRyng7p5hDcH5DUxJwl5dBW36OSXhx2RvcMUP3QPYdT03fPK85xcA+TN0gP64Gtf7TmvFmdh2IYTG6QedqoTltSYbmtuk5mX5tmgpa6K3XMtqA5geysEdWZWPYtmWJe+v2CE+6Uny07jp3UYCYaLnB7RkwV9BRZNo2zJQzkGQbRE98Knkl/hLTO9puLCmuk2eMV/xfyYs1BqtjlbWckLCXFalOhrndi4PGVHDfnNwSbUGEOqzFNFMQBs+kBTyUEHFNiAbmcvdYJ NgR6EGgJ 5Aeb0wL2mVTOtuk7imLRWifXO7iUDAfcxmKmdmlZJ30nVHLB8sT7OYU1TbDhj0kJZamWgBf7FqEcWiCi2NIKJh7lGEWJX99ax2bwYFMurToZ7gosPKE+NEmcBz+mnY7CyBtdGLo8Dxwze+5ryRm7R/I9jBRy7iApRXpVzSXZTMiiHy0eFX3IWbAu/bJW8S2mL8EXlrsH004fMqHOX2bDRIWgJI7LwEuRIeHE0tazlmXBLYhOHJKSCewva+ODfSgH5eansQtC6TuY1zXWgWT+oM+SxN2aiUHPSpWIRv9KD8xLjW9DuiEZAp4ivLJj0HxZvyj/1jCxxM+CVbBsqke+ecLV2SwLukxhvUyFHGT5aglEUNTgF59exjw3SPgt34YJp+gLdm8RqJV2KK5KTmpABIQKj7TGu8x3h1emX6olPERLHMHKxAI6wFBsdGIWZ76q8rTUdBY+1GFrtUqVAhnlHWh5Qqpybj7fTCUOakgEOnTNPj9ysGaUQTvDqedGp7R59Ubn0Y++n8W1CapmzvIziK4MJiWmCOCVBfEofEkon0mATo82LvjOHWCCr7qI+45NIrvtjkIWvTr/UOAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This check existed originally due to concerns that P2PDMA needed to copy fsdax until pgmap refcounts were fixed (see [1]). The P2PDMA infrastructure will only call unmap_mapping_range() when the underlying device is unbound, and immediately after unmapping it waits for the reference of all ZONE_DEVICE pages to be released before continuing. This does not allow for a page to be reused and no user access fault is therefore possible. It does not have the same problem as fsdax. The one minor concern with FOLL_LONGTERM pins is they will block device unbind until userspace releases them all. Co-developed-by: Logan Gunthorpe Signed-off-by: Logan Gunthorpe Signed-off-by: Martin Oliveira [1]: https://lkml.kernel.org/r/Yy4Ot5MoOhsgYLTQ@ziepe.ca --- mm/gup.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index ca0f5cedce9b..6922e1c38d75 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2614,11 +2614,6 @@ static bool is_valid_gup_args(struct page **pages, int *locked, if (WARN_ON_ONCE((gup_flags & (FOLL_GET | FOLL_PIN)) && !pages)) return false; - /* We want to allow the pgmap to be hot-unplugged at all times */ - if (WARN_ON_ONCE((gup_flags & FOLL_LONGTERM) && - (gup_flags & FOLL_PCI_P2PDMA))) - return false; - *gup_flags_p = gup_flags; return true; } From patchwork Mon Jul 8 16:57:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Oliveira X-Patchwork-Id: 13726873 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAECC3271E for ; Mon, 8 Jul 2024 16:59:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B19246B00AC; Mon, 8 Jul 2024 12:59:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC9E76B00AE; Mon, 8 Jul 2024 12:59:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96B8C6B00AF; Mon, 8 Jul 2024 12:59:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B0436B00AC for ; Mon, 8 Jul 2024 12:59:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E28E21C0951 for ; Mon, 8 Jul 2024 16:59:14 +0000 (UTC) X-FDA: 82317195828.15.8600A2A Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2091.outbound.protection.outlook.com [40.107.93.91]) by imf17.hostedemail.com (Postfix) with ESMTP id 0BB9540028 for ; Mon, 8 Jul 2024 16:59:11 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b=KnRGtE5f; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=none; spf=pass (imf17.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.93.91 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720457927; a=rsa-sha256; cv=pass; b=vwhwNJJWuQgX0oDBQEP3Qh6baVG9nwuRpdwGNsKfHZXV39ar0vAyMknTxhrpf/obOK4jsb 7DhagwuhqKDISbq+EgrB/XdbeYvklYaUioJSvkGnRhGfl9tyvc1ZAvk9v1cDQouFZsDOYi l9JEalzYVkkTIpdR34j4YvPoixaLVGo= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=eideticcom.onmicrosoft.com header.s=selector2-eideticcom-onmicrosoft-com header.b=KnRGtE5f; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=none; spf=pass (imf17.hostedemail.com: domain of Martin.Oliveira@eideticom.com designates 40.107.93.91 as permitted sender) smtp.mailfrom=Martin.Oliveira@eideticom.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720457927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YueMmbvCvTSA1MKV+udXlu2nutuaCG4yOb4CpEEFNc0=; b=yJHUHowitjRvWCzFwGWr4U39myHPmoKvPdm02T7pInVFCFqixRd0Td8JLs7vRaVjQ7/0Kz 886SwEZZcro16EzvMte76iBfvZERDO61RD6CIDLwt0xdDEPGdF0epn1KaS+3ui97OoxxNx ofY7pMm+He9Ljjnu1mxKDaUd1H04FQY= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8E0F60lBTk2yARSsHbC34QHx0AHYb3dCtVgIktM/4mtKN4e/mw0NCZVpzzasoLpKC13qb3QUskybxTapqbat8PYWsyg/RF3H0akW/P0o+MIJrNd3tgJdA/N1lilPWGxsTOoaO+TDYNqG8QFdi+OPprskp1Wyeyl7+mcr375b3QBYJa7xvjB5C+ETPVuxvq+QPML3bLgwseF+9iyKGYbtEZBrNf5sABSQatEotC3jPrwLHbvvMRiUrc1ofBq+wkkOUD0ba83JxTQxIv76gsMdtY6XJ3PjOlOqGNTGGBcwjLKLJJDQsgI28QJHXVgQ7g0k4jq9ltoL/xS+cjo25frjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YueMmbvCvTSA1MKV+udXlu2nutuaCG4yOb4CpEEFNc0=; b=at7DIGjQwysJf9VB8hv584gL5BcgR/4UQoI4j4drsw08rj4Cu4tzhXNsv4nEOXIQbDTU7KothsrpqnQP9OXJOS7xE8sNpay5O36a5gpVDKNyG4w6eyUV/0is7YDz0Eh4iSOQft6z/SDilwVP6tv0MNut4WgfKYdus8IKSbfMELzxovfsWRqawML6aVncogyiSBEc2tcHS+3NFLCOddJ+Sya8SPkPlBqkQbFkhfRC8aNEQW0gOkGiSDYjjRGyrIAc/HMR1PGi50wK5h9FFvZNSaa5nmbsCzHeWjToKxiD/ylXRjJUY4gZu15R/rIqYVf/oGdSt6RHXZyk3BPIqjcJyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eideticom.com; dmarc=pass action=none header.from=eideticom.com; dkim=pass header.d=eideticom.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eideticcom.onmicrosoft.com; s=selector2-eideticcom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YueMmbvCvTSA1MKV+udXlu2nutuaCG4yOb4CpEEFNc0=; b=KnRGtE5ffnqfvuaoRRYC9bPMkS37lthLEyYLc/ZCo+lK1o/JiSQtq78r5xhc4ENVRHOyZmGc8VCUUD6PT4YqmwkzS3eg3jbRoLp7CwW1A71U3Pvubg3eBvgZOfnlMbTfRJxZLq0rtZcyWP8niXndyNHffCWrW9d8tsXbba6Fx3o= Received: from DM6PR19MB4248.namprd19.prod.outlook.com (2603:10b6:5:2b0::11) by BY3PR19MB5028.namprd19.prod.outlook.com (2603:10b6:a03:361::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 16:57:44 +0000 Received: from DM6PR19MB4248.namprd19.prod.outlook.com ([fe80::d508:c71a:eb4f:7cf4]) by DM6PR19MB4248.namprd19.prod.outlook.com ([fe80::d508:c71a:eb4f:7cf4%6]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 16:57:44 +0000 From: Martin Oliveira To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org Cc: Andrew Morton , Artemy Kovalyov , Greg Kroah-Hartman , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Martin Oliveira , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan , Jason Gunthorpe Subject: [PATCH v4 3/3] RDMA/umem: add support for P2P RDMA Date: Mon, 8 Jul 2024 10:57:14 -0600 Message-Id: <20240708165714.3401377-4-martin.oliveira@eideticom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240708165714.3401377-1-martin.oliveira@eideticom.com> References: <20240708165714.3401377-1-martin.oliveira@eideticom.com> X-ClientProxiedBy: MW4PR03CA0252.namprd03.prod.outlook.com (2603:10b6:303:b4::17) To DM6PR19MB4248.namprd19.prod.outlook.com (2603:10b6:5:2b0::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR19MB4248:EE_|BY3PR19MB5028:EE_ X-MS-Office365-Filtering-Correlation-Id: ff788045-f79f-4488-3ea0-08dc9f6f1618 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: tNsAzoWvN0zCxDPi5mKkCivR5HnFx2660fwqJoXqk2H7xF6xTyIDXUaRj7k3FXHQtMTXeXkKSf1FvZc4enIdLsVZkVoGdTclROijyxnM+K6uKIBjQoWkpnEzwx87ZG/+Mr9vuP/yesuw3hMxSnJsvmSdWvSAGh5ngkGwECmEes4PJQu++B1qEhLqGP/VOQfefnGSsRffQzX3Zd/JmmWalURX7AmiV9FxJJ5uKk7CtOnMoH7pXVzGaOeqk2mVfL852yinuic50r5gtHoiu6JOI24VUD3hfvJujs3Pezvrhnozf+TAasUPsFIpvgJ8YUNKA/enLf+JLMnsZAoJpy7TdazAHXnAPqo8KhNoIfrCh+QVVTp9Dn+07n5AvCIK9kjcrGo1DXbyOdBZoJf02OJLtT0AyD1DdvCvCMe8RUBZatXxFjXiFFQ7gZbH7tm2v1GFei3LvY8sWdyTllLrOA9k8RoC2b20IzIH/v4SPWmUdrXq9R+Z+HaOVjZWqlTedH+z9vwgdnGQ3HYGCw25uw4EhQJJdlI9zUrpQdgZglhU+X7soVrngbm76eqpCrFoonmGPTIblsgLw9+qd9zZgAZRof+uDoBJ+4c4HqIdBgGBU8is9YR/KnJoeY5bQTlgFOY6St5lEpyLsDIERj6+0A0aFF67VRn1at366wB5DNrQbu1i09twc8vzBNglYv2bhg7iKtrin1fxYpKdqe8algaT74+1DPvbekvPPHW5SKTbQWpGVa21kKutFrLFEhNOB5Kp1rMr8jUZqzSFzCme8weNbMpnw/Dd+aehMMjDGdkwen9tCcpFKAxv9pnuq8bb0TpgDF9ecrehYlfbNw1dMJzgClSMeM7ENwN+BX4iUU+8MwIbXwj0Y89PUDKJnGtJnpftuqoZ74hfrjw2UamhxhoxCuYPf3cebINSxih4A8fmXuNh0bDtbR5rqE/pJ/N3qNbDCtLw2WX2/2IhWt/NQXElgT5/Zkao139QSRaLMJ/+Z8avYIw2Pjt6Vc6UxU2Zks9tew+dmzIj4YzjuLckez2i2/bG69jCC1vglmcGIAQJkkRZCSe9f4h718xL8/4BqIlOeZQ0E/1zoaZDtvd2eErKOXVg7xpSoFkpfzODsS4PjnPd3GRWNFUNrcCewx1BBVXoq7hn9RLqFLoHzyKp2JbYt1zn0YBP3YWbLWAyowzDJBVOzPbLIKgDAzoLSPEdxYzeH/ZuL7wfejFhvU/tdySN6vKJucT/ZyMSTCkjYFWOMOEJmaKGJgtayOQcA1WpCFrjSZbsKiokJwHMNWAZm5Tq3YlPPBTcLmgy338YgdjB8rNDY3ZKxYzTrWJ8msKUP5657qX5C3qRgqdjCzrI03JnYS5tBWeBH++BXFcXg3yLcOHccKOvvXCIkq/5GE0E92IqQb9hTYkFWRk5OigR9EwAsg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR19MB4248.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Uj3Tid2uN6Q6b5kuv+ZcA1gAvOvRU9NRTrm40/ehvC2ipNS/kQx9ZhvJSJ/RjJMCbd3RWFmPYlunDVqwj1UtHDGkDsMjLEOwVLMGCYfdQD+rqpqPAOBBMgDkkpzDCsynJHSCy6XRo592vS5+DEBL4Ufh+0vAHn35bOpoKT2ifH5LzupE3Qzwws1NZC0vwbezijPa2Ak20vxIg7L5axFVenHvn3LkBnlVtdEMCDI4O7hOL9XhFeLKOMRY5aAMe4ySllmO4irGFoy9bP9FcvBW3xBZdxgioRqu6GUW2lZWxE/Mvd98Pvqf6wZ94es6QLzLfhg9kXN4oc4g9ODcmoAi6AWFTAUMy5UMZwSuGLvgokFNkc6K1LMzaBDWt8Fz+Of2tn81jIgd4izbXIUZHV0T+p2O8MfHtJV4+qnw6aYl0kchWviPkQkW8PjPF06IH2B0SbSAAy0ay5kqx30TYozK+jJOMWOcZrWdiQE+rAgHWt+Bh5huYTuJU1/YP1zrsQa738VtQegLA4rNxbfmEl9vjTZYhPqe8DhI68mFaJcD2rSckQGh3yJ0Jn1U7714G598s50R1yHhIovwTFcZpEBIZdghMkeB0Ee9QhpuuNmBnMhmdgoXhIJJo7KHb7Wbw8SSLl7u+9KJzaunSpktIF9hKmnpsQ7WQG17H/uiD8/dNahZyAJgwZz5aSjxFTdNDG21obIWqopVkJXwsPOHtsfmYDCjcwMJeX6a1/g1rLgICIKB1d3mIh+eKkfveMEaSvWNR+iNnvAHLCByMFmglkuTbVIYQO1Ogr+EQSSDMLz3vOMj+WRfspJYOcqb76AJqlIwBK6Mb6t+5cKmCTyt8jNFw9xyRSsvlOy3I1iZICuBXT6ADBFYRkucbkHNPd79s0wFesyMemEojfwLCJ+ZUXr5A9Vukp0Q+P5yl44SIasSL5BMhYv/l6mUx/URaggyKElQeU6RqqyYvu0moEuPvD35zXZ6xxFXgVcpFBue/5HjYSS3FugFaaNLCWUw4zDOc5o1nELBYB4M8sjshAhYzKcfXQwksEbRYGMX8P+ihl5d0LTgWOottf+zgjNfZnyUcyzV0eK33okvLY5NWgp6BQ58uOqU1FK3VSvTgXM5ubHpIJlX8rc6kQ3ji93W86EbRGmLNSpjKV2lsVAx9tUXDxfqPinU1pI4/edf6SWB+ncfT9uxR/v0LxkX7PZLE3AF2rKzFE+fX3s18cnfcGajSX8/SIHVBvpIZ4bdWYG2UnxmvN52aeH8O9aV1oniErPFhNW4OFWOovoafLXyLYfgNHuJBhncPzM2UOfZD1KLP60G9anFOt6BA/wNvlJIyOlsDsn4301CES5pDwptWA2wfKGdQdIu2mt+yyFgjjkdXYqiSYb6ALU/HTxT0mZ7RPtQ66Qt845sQgak10lrJqAUyLl4AfdjeNceVnfeHS3MtxKlMYo3YYDI6KVqp+wU6siitSlEBO73sV/CU7R9X88ReRw8SooELakBu7VYYAo+11dkTZU3ekXs44OQWj9q0QBte5XkBxknjgIaMormn/wknGyvYK39X+KX+xA+OalvCpK8g594Vec/G6zX0nS1nAdmA1dYjHzERF6C8AlXk0DKPuJHNg== X-OriginatorOrg: eideticom.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff788045-f79f-4488-3ea0-08dc9f6f1618 X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB4248.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 16:57:44.2254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WqKcl5Hbl2Jd5CKOBgnss6ZhRNBbS8+vCf8BL3Wd44pH09ogyc33Gt7DVYEpEGfpN64kt9pKF3FqAR96LnLgggPshelZNlpmrwgoDtns3Y8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR19MB5028 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0BB9540028 X-Stat-Signature: f6tcswp6ngc6apddk4txp7hppcc1a8cc X-Rspam-User: X-HE-Tag: 1720457951-572566 X-HE-Meta: U2FsdGVkX18iEyq3MhZfiwuAraica0M8+tPLClrp6UDiLUcKb21hI8GuBNI6uo/dSY/ce7r3py3c5mV1XZdRkLz3CB9l2jnbQMhgt/WcTyJoLUke0rgbRG4Ngf2x4///tXDYyuJ9fQkL9ywXioVpW5y6Ij99VbK/YMzCi6cDIxNKJ7doxno71suP8XOVEUuU9rmW+yrSgFycSdcJO/uhoK9JHp69cGFwiLp/07BF+fxrQMN6dIeEqsIX+IrPryrtJZqbmwSbiWMUUbszpDauJ9SKifJn98Kw6XbvYTIkDbBIGHriledKZjzkUa/VN8X1tYx3/S1l/Z8bKFzAmqt+JnYIGUL4qhtDpc4QZ8XK+12L9VIzqa40AyEfnthCxHTylR7DzCpkyxPVrhEbnmzGFzu2IecAlA2jDL97K1vlxaaJ2ooNp7ZcqWqQI+2v5ppKCRntT9Dx0vyzfY/Kaa778ynFmGllV2jB5Qc3u7DUfI4+p/lEOCeGJfRNAo9b6a/7v4Vw0/F8gmxLnDh5svjJxNinhG/yYtmnTPQMw4TyaH3loTsY4xCiDyVvN34h8pMXvmFhEELOe4a0qM9uATF6qmS3g89UGvox7NLkcDccrWiZdPuNmOJxTve8+/2ZZUq0u28gUdqIjUVzTGES4+L2qgufTe2dZnhgaHQTMQRZiPRgkL0xqB3P11glz1Lymmtwlny56NFvJROGCHsFQT9xY3gCxp3d0t2iPaWhEtRP99atRUZXizYcbaFdPeC+Cq98PZf8UOIuCsMtfubd5RqTdzJptehmHbn2Duhs7s1/29IxeNymvOEjP7xLDi99WFxscDboHvBWrIE5WpnX3nensl4w4LQf+Qw4+HGh0YfjssSRpjl3gY8wzlwy42/W4nS5THRW17CVAFDJ3lmGiTX/NWTiATG1BJCeuEFycAY9B/op46F8Xegf2qKxXJBhs392cLRyffMTMm7fiqKDEW3 H43tV7h9 s5qWEVThE/9IDAmb8BGBvnib/8H7Qnl9+kB5xcZgCvIRycpQKsoXbwPwayrpRPn8APXub1JKdg4lFPNKKjmUaqzoNDQqpzpOZuwm/Jms+asqqyhn4DMH3AWM0NU05Ym1gcSO+obc2mWQZjzRpmQfUVNZij2Vcgg1QOXTY9DImbg+iAbXmWMRtJQQWVQV+EIyOMdB89yK84I6FYS973tRA5vSVzzWy11Gw+5mpwyor7lD7Q/spcoeV00Qnx3rK+OKBeLgMuH/YIK+P3APGwO8fGaxoL1+mA0/4Iy+X4nteVmobYMlnznYyC/Vdek4i3GI+orEKbULerUNsqqJPlgLeGUAtbeR7ioKSeLTvZkUewwsPge86a4JWeEaoR5qKCqi6A00fwfABU++CEN9IIqvDtbVB+ncyZW94fQLiqXiodABVHZBOyAFp/N8Q+ufLkg9ubyRt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If the device supports P2PDMA, add the FOLL_PCI_P2PDMA flag This allows ibv_reg_mr() and friends to use P2PDMA memory that has been mmaped into userspace for MRs in IB and RDMA transactions. Co-developed-by: Logan Gunthorpe Signed-off-by: Logan Gunthorpe Signed-off-by: Martin Oliveira Acked-by: Jason Gunthorpe --- drivers/infiniband/core/umem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c index 07c571c7b699..b59bb6e1475e 100644 --- a/drivers/infiniband/core/umem.c +++ b/drivers/infiniband/core/umem.c @@ -208,6 +208,9 @@ struct ib_umem *ib_umem_get(struct ib_device *device, unsigned long addr, if (umem->writable) gup_flags |= FOLL_WRITE; + if (ib_dma_pci_p2p_dma_supported(device)) + gup_flags |= FOLL_PCI_P2PDMA; + while (npages) { cond_resched(); pinned = pin_user_pages_fast(cur_base,