From patchwork Tue Jul 9 21:31:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Vivi, Rodrigo" X-Patchwork-Id: 13728531 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA657C3DA45 for ; Tue, 9 Jul 2024 21:32:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B287110E1FE; Tue, 9 Jul 2024 21:31:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="NjkFehGR"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8125A10E027; Tue, 9 Jul 2024 21:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720560718; x=1752096718; h=date:from:to:cc:subject:message-id: content-transfer-encoding:mime-version; bh=u77mU4i0p4Gnh4Lhp9cWgbg1Gp4XLoVW3lHkxrzAqnE=; b=NjkFehGRvRLvbtv7SQtKsGv4yp+b2NJkP/iW5p1YRpfsiTFnKuVof2Nc H/U8uFe3xg/g8foZjxV2rQ2oBFtUF5A94i0FzA/kC89caaNV4tJT2uv+C 8IG/7VG+Z24u4GjktFJx+Znx0o8ZuheDAf3Ps/qJItenshyvkUMl5tWow NZf55eJ+JG2iCvoIp0GpVWbieetALCWmkq8/XyxC6wQ7elPpnt7AlSLoK zHm+YWuJLiNrtKJXaRpICk5GHWGVP3ukAgxZYkk9cPkLALQ24/WgrF/63 5C6HYQFbK4G6Cyiqcayy8PjVini1xP3SMtp3DpRRGUO0y1VIys23tQhMV g==; X-CSE-ConnectionGUID: A1TKor/JQ4a++Qc8x+2Edw== X-CSE-MsgGUID: ThHNvj0KQQ2Q0WSF/CLKsg== X-IronPort-AV: E=McAfee;i="6700,10204,11128"; a="28442211" X-IronPort-AV: E=Sophos;i="6.09,196,1716274800"; d="scan'208";a="28442211" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2024 14:31:58 -0700 X-CSE-ConnectionGUID: 1vKkArvdRPyYomAhBzlJlw== X-CSE-MsgGUID: YzlE2gDEQJGQvM+PAND0mw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,196,1716274800"; d="scan'208";a="78726009" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Jul 2024 14:31:57 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 9 Jul 2024 14:31:56 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 9 Jul 2024 14:31:56 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 9 Jul 2024 14:31:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGxnJD9ZR7WtjwzM3pSa3IuHKOvYdZXODVnQJeYc0T79E4qqU+YRnLSVY2RxOomAcOGhtgBqd1OnE93+8EXeMOdhXkk8fD+EKQevSdjpY+9GHmezod+iSO4FGubZuGEKeJvyPcCyRoDdAUrOJxCg0xCN40EQhCwaG/zvw85YFk4Seeb7wJ2qDwJy/AEqZFBx3O0cy2zjhGpkgmGQUj/KMAFSUzQuhiiwGPFL/BxOkcVgIs85aa42ZZULAGn7AQiVvumht2YF9uBwFAK/O9UCjrLTM7uvUcAnYw8MTciePy7eOfBwrlLz3RgCLuzudxavsB1aNSi5ccasJfgzU3SMGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bQbYRxukLi6o+8coxYNZ9rJcJw1auLbP37QGwpJKWsk=; b=oYAg/1qirLMCcRwb4KfbwHmioAtkxvS4xZxwNBNeXvCnBldYudjlYE73EYKOKIUI/R6Hjh+86ttiedpHcyxrYIRpOuBoKpTNh3AiVRLLaIhj/lU2br6Y0PFSFCxjAlgo7TNHZz2lGyUR/+3pqXbE+CMlFQ+sE8+5aMLc+igHlthNeKoK369n4FVgsXANRQNf8Xk7HD1UuV6Gj3F8Z6Ox3cou2JkGwgPFleSa8lXJaW8Nm+lZWIdxSoQACcJUE1ywPWpFQt208z6fMuVNzProdzPEhS/pVnNDmRMEqJ12qGVYsn+kIco2wrw+ArmLwJHDx7/7NzUV/gTFgyhkAvL6Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM6PR11MB2859.namprd11.prod.outlook.com (2603:10b6:5:c9::14) by SA0PR11MB4766.namprd11.prod.outlook.com (2603:10b6:806:92::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Tue, 9 Jul 2024 21:31:43 +0000 Received: from DM6PR11MB2859.namprd11.prod.outlook.com ([fe80::4063:4fec:bf76:f095]) by DM6PR11MB2859.namprd11.prod.outlook.com ([fe80::4063:4fec:bf76:f095%3]) with mapi id 15.20.7741.033; Tue, 9 Jul 2024 21:31:43 +0000 Date: Tue, 9 Jul 2024 17:31:39 -0400 From: Rodrigo Vivi To: Dave Airlie , Daniel Vetter CC: Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Rodrigo Vivi , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , Thomas =?iso-8859-1?q?Hellstr=F6m?= , Oded Gabbay , "Lucas De Marchi" , , , , Subject: [PULL] drm-xe-next-fixes Message-ID: Content-Disposition: inline X-ClientProxiedBy: BYAPR03CA0007.namprd03.prod.outlook.com (2603:10b6:a02:a8::20) To DM6PR11MB2859.namprd11.prod.outlook.com (2603:10b6:5:c9::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR11MB2859:EE_|SA0PR11MB4766:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a6b4a8d-8f18-4d3f-1bf1-08dca05e8732 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?q?Y8bA/OFE3ynDl49zSaL1Qs/fEf?= =?iso-8859-1?q?gZf9M0rwAUYmuKF0VcneloBuTGnEf1DcsD9LB9H19x5nXyQUHA47sA0DRyNS?= =?iso-8859-1?q?oP59mLdY7nbza5FD2YAFabjD2IHqg2LB56vEjsX9d5NZ88NWWnxaMHq5ac+8?= =?iso-8859-1?q?lSTKYFcJkz41arWWeXhtX9W0ClHA3S3e26TDCJRlaWOKM0zrIqW4+lk+QyPG?= =?iso-8859-1?q?qOu6XT/T8Fvk4cBJVL9BVynzcARuUhJQwLR5VJIZCdgmwRmC5r/9U2pBda6D?= =?iso-8859-1?q?fkeaLfKEIBD7NYocWVcMiwinXNqvhh9/tU+qJRARvVbZHigvImxrQ2mIa6eO?= =?iso-8859-1?q?S6OyGfTFqmLyIdLxPn8xEQ7B5n0QNXSzux+yDtufDuMVKFKaXDtmtKe0dD1J?= =?iso-8859-1?q?KorvL4zbk+yXfgIxa8OYdxziOC9Z+2grrAD3vjvIrA5W84ESUt20IQbEyLJa?= =?iso-8859-1?q?Yk/SwZO6M2DBze1xZeO3Iygq7kTdExjN21QmN9yhIYUOv+nU6wcOR0CUSa+F?= =?iso-8859-1?q?xEIxLFjqL2OM9SG7IheXmq58GQyLDsz5EepGsEZOCwDYz6+1lRNI7t9juakT?= =?iso-8859-1?q?isG2P/kH46WvV5w01FEiumOdLU6Se7dOfejbyqhRS8nlNsknq1BadICv0sQM?= =?iso-8859-1?q?2gcG3YLir6nW9pbAbf29EpsfDOzgg+7AmBLLZuAvML6R1iULtXrYlJw8SH2M?= =?iso-8859-1?q?DVEoB8k+s/ehBuNSQWx8AjMNSpQqIOe0WF8Flr3a5KHtoCFoELPXnwOVxYkj?= =?iso-8859-1?q?uBfNcBSH0ARSzbhwYyRWoK7HPxyGdDqIMDqSIEZtopG2xeGG/UOZ7IZIIk2I?= =?iso-8859-1?q?FoMTs+tZl/5aPPdJ08mmw+8nktP+hAUAY+eVJQy1bWrP4/vk3FCVhq1lslSb?= =?iso-8859-1?q?OrZSielmKiwk23kFpnEtkiIIh1/iGo/TduCKEmkjhrDZPrR8n2oWVS8FypQk?= =?iso-8859-1?q?iYDN7wDH1lw77Nnma95rQKBWcSF2uqWEiQo4JmZCGvDLInHvc9zW8IrLGxE+?= =?iso-8859-1?q?f+g74MVCDhIc3DZ6Qin16zEoGzEkXY4p3L9huC1AmuTmQvTnEYfkn+Qb3qlA?= =?iso-8859-1?q?+mS4RtM9mxvzkgvlr7bi9zBFJ39J5dXJlTxP/YywC3kBXr9ytVeM7u1tgT2p?= =?iso-8859-1?q?pnx878Y89MEP3o531kaZvdL+sXgFJW/MkbpBNwvgFIJyW2eJey8wqzmY695k?= =?iso-8859-1?q?pQiqK0iS/An6bCuscszYJzG9iPju4HDjkycccVhmYT+GttYyrwB9zS0NU2P3?= =?iso-8859-1?q?FYhUy70rrutkSalduEDFJCHzvLuy7FkqSxrbb+Q5A2hcU7YqB1kYuMvtZGjz?= =?iso-8859-1?q?VU/96yZo1At6j3n+ea4VCvulM/G+KJGhSj6rw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2859.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(7416014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?q?DgWsmZq6/KPavm8N1tnjjfU?= =?iso-8859-1?q?mf38EYCbNjjSAeBzYrTVaxjXUWNoyT/hiDidnq2LFUWgghTwuS5rn5959o7t?= =?iso-8859-1?q?k9fHDP+9HzrZqIXIFiCZx3mfxy5E1lnraDJOApSM6vaqIbPuHeP5S8jFobJd?= =?iso-8859-1?q?ncTQJ+El4XSmideWbBCsxsWCt0Qw2Fm21W7qGZloDe/CClFC0WmCf7xFop1y?= =?iso-8859-1?q?NgvLXb0TSv4MBb/I54WIMbi/bGeWntowPnUNJP1F/XyFuyPr8N0Y61BZcOej?= =?iso-8859-1?q?sDQjZY2wBi+mk5iE5G/33JOqDbeKJqwRYaGcus2Aa0TnzPc98OMe77LxjL3g?= =?iso-8859-1?q?qeTWHa2F5t3m+P+gDQ7kNS027Om6Y5mfKdjMb0UOduYli+Zr+UXlDUYDzxO7?= =?iso-8859-1?q?tNKF2BkPmZ/JDovqXJ5y8jIu8P20GAo5DlIZnq6HHp7NraWhqYmCwUZ/ThgY?= =?iso-8859-1?q?FgklnkIdKdm0axmbDtkb4xMwpqNx4vZxqKmSoI0BGbHfNw2J5/MthpxqjoA0?= =?iso-8859-1?q?jB83NZvvf8TmJ3wAYMeaNJNgqmx8Clsc0glJqrk5JzF5fgqqJS6oyeixCLbB?= =?iso-8859-1?q?M6xNP5NTbHez/BkbUToUcRnbMT65TWxryGTLPlN0zcJd7k/ffswsD+A66+TU?= =?iso-8859-1?q?AlpexTehatgjPPQKgFIb15iO3ElcAxrVJXH1qXeKzmA5xzJhnTmdyfUDmWdm?= =?iso-8859-1?q?f881C2DmLupI7j1e8yo5dZrxSQ6kiWR2QcZ1Pf8lHj4UNMs7OadL/ujISE0F?= =?iso-8859-1?q?+g+Dx8mjNPdnQ2Erew+5iR/0wNhUyfqlOScaoPN5t7O9v+NCgLBcQ7x+ZAWQ?= =?iso-8859-1?q?uZRfx37I19qWRfJT5b5EcXgEeZ+I8ZAIg3rQqoBsrkOl0ysWaAGoohwFf+S2?= =?iso-8859-1?q?v51x6W6gJo7DhRKuQwiO6iX5v6OGaQC3SBrKFuRusf6gkCskVTRn8xmOr0aP?= =?iso-8859-1?q?tC2bwJFrMACHdT6EcJcmCjgGwVZiLT6K48j2e6vuim9EgwK1KeSNUsiUZ7kw?= =?iso-8859-1?q?WF/16uvzEA+9XreSViNkEwhJSAnnxz8TphbYVHBlfp96TtcUE+1K17efFdqr?= =?iso-8859-1?q?EsDYA9kaiqcvlnZEv8pPxEPiAQETO1DjycZawv/0eiBgHTjIhJOXHPbTs4rL?= =?iso-8859-1?q?zfp5COSYz7kClxLgUBVkdcV0MJoBRU0gEEfoSWVsGO+NVwmWSTXuQz12jNir?= =?iso-8859-1?q?5JLxccnYBEWV1tKNU8hSe3GVdpuazTAuGnES3njohBakxgeB+SJNaj0N5gH+?= =?iso-8859-1?q?+KPv/BOaYCFcxGRpFAs2cOw0OwqxbSErvaCFd6RaCWsDHlrTWweam/zfw4n7?= =?iso-8859-1?q?GZE/E8K4HYKZ1SP4ixq/1f1pP9QatGXwybg4c1Adhy802tNrMVfjapos+rpA?= =?iso-8859-1?q?IHpgAkj1mH45K0kTqYgjROpurQLrUyeqLmCe1N4lkISpYjw20bMqiAHgg/Mv?= =?iso-8859-1?q?izBsXBXT4Cv6jFNWPspfMoEqaGpIyISZX0ihYs+9o7W6Aw89b+tIZjcdsnup?= =?iso-8859-1?q?zyPq7J2/a7TuMKBMEi+j/FwC7k6ti8k+U41pNeOYXmyr4cc88F4QnRq3kk0L?= =?iso-8859-1?q?TE0Uuk/UrEUl3VI6WovCLZzCUWiJTMPZpJXR48ShGmvDGPGR9aQKXL+fgDZK?= =?iso-8859-1?q?dCOOSLv88g9qrmCJdyig/xpjBbe3LE75B0zoH2w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6b4a8d-8f18-4d3f-1bf1-08dca05e8732 X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2859.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2024 21:31:43.7504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4mekvc6FzeCLf8D943G6D3D6jx+MohxzrLlZr8Ieq95qwoJLpGA++hCZYJrVELG7uIeojp10ca/1rvyddTSJ+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4766 X-OriginatorOrg: intel.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dave and Sima, Here goes a very early drm-xe-next-fixes with 2 important fixes that are going to impact user space. 1. The first one is the rename of the OA stuff from the bad 'perf' name to the xe_observation. Although the rename in the uapi header is likely inoffensive because our UMDs always copy the header to their code, there's a sysfs filename change that is impacting mesa. For this one Mesa MR is ready and they are only waiting for this pull request to be picked by you so they can merge that to Mesa: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30027 With both sides in place, there won't be any kernel version released with the bad naming and no Mesa released using that filename. This is the main reason that I'm sending this PR earlier than normal. 2. The second case, which also impact user space is the write-back caching mode for system memory on DGFX. In this case we introduce a limitation in the cache selection uapi that is transparent to UMDs. I mean, no change on their side is needed. Coherence is maintained with some know possible visible and acceptable/accepted differences in CPU access speed. Thanks, Rodrigo. drm-xe-next-fixes-2024-07-09: UAPI Changes: - Rename xe perf layer as xe observation layer (Ashutosh) - Use write-back caching mode for system memory on DGFX (Thomas) Driver Changes: - Drop trace_xe_hw_fence_free (Brost) The following changes since commit 62a05f4ae9c1fb70bc75d494c9c1c373d2c2e374: Merge tag 'drm-msm-next-2024-07-04' of https://gitlab.freedesktop.org/drm/msm into drm-next (2024-07-05 12:45:41 +0200) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-next-fixes-2024-07-09 for you to fetch changes up to 463108053c19f24fa228863824698d5ca72826b6: drm/xe: Drop trace_xe_hw_fence_free (2024-07-09 16:21:26 -0400) ---------------------------------------------------------------- UAPI Changes: - Rename xe perf layer as xe observation layer (Ashutosh) - Use write-back caching mode for system memory on DGFX (Thomas) Driver Changes: - Drop trace_xe_hw_fence_free (Brost) ---------------------------------------------------------------- Ashutosh Dixit (1): drm/xe/uapi: Rename xe perf layer as xe observation layer Matthew Brost (1): drm/xe: Drop trace_xe_hw_fence_free Thomas Hellström (1): drm/xe: Use write-back caching mode for system memory on DGFX drivers/gpu/drm/xe/Makefile | 2 +- drivers/gpu/drm/xe/xe_bo.c | 47 +++++++++------ drivers/gpu/drm/xe/xe_bo_types.h | 3 +- drivers/gpu/drm/xe/xe_device.c | 4 +- drivers/gpu/drm/xe/xe_device_types.h | 2 +- drivers/gpu/drm/xe/xe_gt_types.h | 2 +- drivers/gpu/drm/xe/xe_hw_fence.c | 1 - drivers/gpu/drm/xe/xe_module.c | 6 +- drivers/gpu/drm/xe/xe_oa.c | 34 +++++------ drivers/gpu/drm/xe/xe_observation.c | 93 +++++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_observation.h | 20 +++++++ drivers/gpu/drm/xe/xe_perf.c | 92 ----------------------------- drivers/gpu/drm/xe/xe_perf.h | 20 ------- drivers/gpu/drm/xe/xe_trace.h | 5 -- include/uapi/drm/xe_drm.h | 110 +++++++++++++++++++---------------- 15 files changed, 227 insertions(+), 214 deletions(-) create mode 100644 drivers/gpu/drm/xe/xe_observation.c create mode 100644 drivers/gpu/drm/xe/xe_observation.h delete mode 100644 drivers/gpu/drm/xe/xe_perf.c delete mode 100644 drivers/gpu/drm/xe/xe_perf.h