From patchwork Sat Jul 13 06:09:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zeng Heng X-Patchwork-Id: 13732344 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D7C3C3DA45 for ; Sat, 13 Jul 2024 06:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=brU47bW0+7nNUJ0E/xqNnW8xrqFS7bTUYdQSxvuDvkQ=; b=StqRsD6e62ycAIB8KyUU112M1B SMeaxMmU1IemB/emhLoTu+8u0f2W4s/YLLH1kIt/dc74bhmDr35C4gtDXoZFCB27mWck3veQ5bE2R Bud1tKDKvPSWtArXvfqEeV74qAxg1QzBgV1exFTYjdK3JOaJ+Le+8X+s6s7k6ZK+aEeCaXsIB3d62 E99xbQ7Q0erTdvUX5FovhSlg10h2+Fx+Z95Y3iLrbMbJPgbb2Ybq7zDLU3IH6oJSCgCmFB8UQbkLZ QhKcHMPymAir0bvotfFhXSs91UX7I3lvYZKP+BC1EidC6fnYgFshaHHUGYrnAXDbhLE+9o0MGusDw qKNvIoDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW1D-000000020Fe-2FNJ; Sat, 13 Jul 2024 06:14:03 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW0t-0000000209H-2jI2 for linux-arm-kernel@lists.infradead.org; Sat, 13 Jul 2024 06:13:45 +0000 Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4WLdMy2fxgzQlSJ; Sat, 13 Jul 2024 14:09:34 +0800 (CST) Received: from kwepemf100008.china.huawei.com (unknown [7.202.181.222]) by mail.maildlp.com (Postfix) with ESMTPS id 44C87140361; Sat, 13 Jul 2024 14:13:33 +0800 (CST) Received: from huawei.com (10.175.103.91) by kwepemf100008.china.huawei.com (7.202.181.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 13 Jul 2024 14:13:32 +0800 From: Zeng Heng To: CC: , Subject: [PATCH v6.10-rc1 1/4] arm_mpam: Correct MBA granularity calculation Date: Sat, 13 Jul 2024 14:09:41 +0800 Message-ID: <20240713060944.2725647-2-zengheng4@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240713060944.2725647-1-zengheng4@huawei.com> References: <20240713060944.2725647-1-zengheng4@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemf100008.china.huawei.com (7.202.181.222) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_231343_901706_2133D1A9 X-CRM114-Status: GOOD ( 10.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Correct MBA granularity calculation function. As said in the comments, "bwa_wd is the number of bits implemented in the 0.xxx fixed point fraction". Fixes: 867471fefd5c ("SPLIT untested: arm_mpam: resctrl: Add support for MB resource") Signed-off-by: Zeng Heng --- drivers/platform/arm64/mpam/mpam_resctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/arm64/mpam/mpam_resctrl.c b/drivers/platform/arm64/mpam/mpam_resctrl.c index 2fa732a42d4f..a217f2e1f350 100644 --- a/drivers/platform/arm64/mpam/mpam_resctrl.c +++ b/drivers/platform/arm64/mpam/mpam_resctrl.c @@ -523,7 +523,7 @@ static u32 get_mba_granularity(struct mpam_props *cprops) * bwa_wd is the number of bits implemented in the 0.xxx * fixed point fraction. 1 bit is 50%, 2 is 25% etc. */ - return MAX_MBA_BW / (cprops->bwa_wd + 1); + return MAX_MBA_BW / (1 << cprops->bwa_wd); } return 0; From patchwork Sat Jul 13 06:09:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zeng Heng X-Patchwork-Id: 13732347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D44ADC3DA45 for ; Sat, 13 Jul 2024 06:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lkjtJCyKIlSrpPSWGRfMVE8S65/5TmJQlE6/0aPi9RE=; b=UgBF0rlAHqtXi3WyJuoxtTrgRH 6IP74CRtmULsCntKKAVxc0EWDaAOJtgC+CCziSJHsHjc34EmG8aYAUVGN70BHSuvSP8vkTR1DIh7p e5wIaAJdguU7iWyq0/7mpiy/YuU4E1N+PF296to2ykjYFp4D1P1Ho6mV2eMeLggdC5kwhHsgM9q29 pKgngZqTlmDnoi53WHCs5/F4+nrmu1de2tnWj5uFhSK1CJ1+r90TQKKOSCf6cGgTtmTDsGvqZ9qQ9 kjKvz78lDyh9hMDEZ2hRxPKUzE5YhbeNcspv72HlIE6+MPNoFqcJlWyCQHH3cTYzyoebQyeaKrqbU r8TbaJWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW1y-000000020WJ-3rHM; Sat, 13 Jul 2024 06:14:50 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW0v-0000000209F-2F7e for linux-arm-kernel@lists.infradead.org; Sat, 13 Jul 2024 06:13:47 +0000 Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4WLdMf3HwNz1X4dH; Sat, 13 Jul 2024 14:09:18 +0800 (CST) Received: from kwepemf100008.china.huawei.com (unknown [7.202.181.222]) by mail.maildlp.com (Postfix) with ESMTPS id B316D1A016C; Sat, 13 Jul 2024 14:13:33 +0800 (CST) Received: from huawei.com (10.175.103.91) by kwepemf100008.china.huawei.com (7.202.181.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 13 Jul 2024 14:13:33 +0800 From: Zeng Heng To: CC: , Subject: [PATCH v6.10-rc1 2/4] arm_mpam: Fix the range calculation of the implemented bits Date: Sat, 13 Jul 2024 14:09:42 +0800 Message-ID: <20240713060944.2725647-3-zengheng4@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240713060944.2725647-1-zengheng4@huawei.com> References: <20240713060944.2725647-1-zengheng4@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemf100008.china.huawei.com (7.202.181.222) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_231345_932877_768BE50A X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The implemented bits of the MAX field in the MPAMCFG_{MBW_MAX, CMAX} register are always to the left of the field, so the validated range should be like [15, 15 - width + 1]. Fixes: 867471fefd5c ("SPLIT untested: arm_mpam: resctrl: Add support for MB resource") Signed-off-by: Zeng Heng --- drivers/platform/arm64/mpam/mpam_resctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/arm64/mpam/mpam_resctrl.c b/drivers/platform/arm64/mpam/mpam_resctrl.c index a217f2e1f350..e87fca6fc5fd 100644 --- a/drivers/platform/arm64/mpam/mpam_resctrl.c +++ b/drivers/platform/arm64/mpam/mpam_resctrl.c @@ -585,7 +585,7 @@ static u16 percent_to_mbw_max(u8 pc, struct mpam_props *cprops) break; } - value &= GENMASK(15, 15 - cprops->bwa_wd); + value &= GENMASK(15, 15 - cprops->bwa_wd + 1); return value; } From patchwork Sat Jul 13 06:09:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zeng Heng X-Patchwork-Id: 13732345 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B13AC3DA42 for ; Sat, 13 Jul 2024 06:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uX7gFOb8Wusnp2L5nBRr5gMWGtIS6MuUY4LVRDZq1G8=; b=PTpgCadnImNjAUaVb9EDlfWHwJ wsoi7c8gsjRca8kf4TYaTeH/0jTs2xA1mhPysRuUTvpxvZenT7XbRoAXEPGrU663KRjYLuJ2D/KRd pvKk9SHvg9qqhCPQoMJVIcojaLgX88XlXapNze+tbIkq6m33Qe1nbogbWGfM7CcR5PwNuKiDthT8r fyx+fLt3ajYdFuqMMriMPeBD3LFKPHqu2ZiQiCvlc+rGSov7eJ1TpIWYjDvz6numkm0fL1rnKzmJk tOyEdy6s4nrjBx3pNb9F1PzscOA+jBS/MGsDxO4B6983BHHlCSlbGjvKql0rIkso33OPefpFAaMoo wf9lXDfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW1S-000000020LM-1xAf; Sat, 13 Jul 2024 06:14:18 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW0t-0000000209G-2MrW for linux-arm-kernel@lists.infradead.org; Sat, 13 Jul 2024 06:13:45 +0000 Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4WLdMf6WS7z1X4gK; Sat, 13 Jul 2024 14:09:18 +0800 (CST) Received: from kwepemf100008.china.huawei.com (unknown [7.202.181.222]) by mail.maildlp.com (Postfix) with ESMTPS id 2D90F1A0188; Sat, 13 Jul 2024 14:13:34 +0800 (CST) Received: from huawei.com (10.175.103.91) by kwepemf100008.china.huawei.com (7.202.181.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 13 Jul 2024 14:13:33 +0800 From: Zeng Heng To: CC: , Subject: [PATCH v6.10-rc1 3/4] arm_mpam: Correct the judgment condition of the CMAX feature Date: Sat, 13 Jul 2024 14:09:43 +0800 Message-ID: <20240713060944.2725647-4-zengheng4@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240713060944.2725647-1-zengheng4@huawei.com> References: <20240713060944.2725647-1-zengheng4@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemf100008.china.huawei.com (7.202.181.222) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_231343_804967_60E0717B X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org According to Arm Architecture MPAM Reference Manual (version DDI 0598D.b), to check whether hardware supports the CMAX feature or not, not only needs to check the CMAX_WD field of the MPAMF_CCAP_IDR register, but also needs to check the NO_CMAX field. Fixes: a275036b6767 ("arm_mpam: Probe and reset the rest of the features") Signed-off-by: Zeng Heng --- drivers/platform/arm64/mpam/mpam_devices.c | 6 ++++-- drivers/platform/arm64/mpam/mpam_internal.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/platform/arm64/mpam/mpam_devices.c b/drivers/platform/arm64/mpam/mpam_devices.c index acb91352c524..9acac8a22573 100644 --- a/drivers/platform/arm64/mpam/mpam_devices.c +++ b/drivers/platform/arm64/mpam/mpam_devices.c @@ -779,8 +779,10 @@ static void mpam_ris_hw_probe(struct mpam_msc_ris *ris) u32 ccap_features = mpam_read_partsel_reg(msc, CCAP_IDR); props->cmax_wd = FIELD_GET(MPAMF_CCAP_IDR_CMAX_WD, ccap_features); - if (props->cmax_wd) - mpam_set_feature(mpam_feat_ccap_part, props); + if (props->cmax_wd) { + if (!FIELD_GET(MPAMF_CCAP_IDR_NO_CMAX, ccap_features)) + mpam_set_feature(mpam_feat_ccap_part, props); + } } /* Cache Portion partitioning */ diff --git a/drivers/platform/arm64/mpam/mpam_internal.h b/drivers/platform/arm64/mpam/mpam_internal.h index 61aea729aa73..0e714ce7fa96 100644 --- a/drivers/platform/arm64/mpam/mpam_internal.h +++ b/drivers/platform/arm64/mpam/mpam_internal.h @@ -450,6 +450,7 @@ void mpam_resctrl_exit(void); /* MPAMF_CCAP_IDR - MPAM features cache capacity partitioning ID register */ #define MPAMF_CCAP_IDR_CMAX_WD GENMASK(5, 0) +#define MPAMF_CCAP_IDR_NO_CMAX BIT(30) /* MPAMF_MBW_IDR - MPAM features memory bandwidth partitioning ID register */ #define MPAMF_MBW_IDR_BWA_WD GENMASK(5, 0) From patchwork Sat Jul 13 06:09:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zeng Heng X-Patchwork-Id: 13732346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5857BC3DA45 for ; Sat, 13 Jul 2024 06:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SlYYbV2xPEAuFd8QD1Hi2pG4p3EIpg7zIJn3NAl9PsU=; b=UenyS+VeJC6ifYGBkvosHMefe3 7+udt9afdiFAZXMDWv9N5yUL5+UOLnP8+DbQBznsPHLRmZ7xrFmYoky2CbTL3DEWQECXpa0WB27Yi BnCgf2JS5SkJLeNuxqt2rpQ8+TYnDbQcDO2yFZSHn6HxYgH3YK6tGU+U5HC6jPBgherx2ztf4Zow4 fEbWZtSk0MnBMgmQ5qmHUCDH8iDOuG8x1I8fqhIuFelcmuDyqhxKxB8aARfB8tM9BUkO/zY6yN/bB Onx8yclsMpDlD3e+N5oUSweTerQpV2KLpGa0SAYLYGMFaecC2gZElhbv7iPKkJ1oCQIR9/KG39ocl Spn8IjLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW1i-000000020SP-2Xjw; Sat, 13 Jul 2024 06:14:34 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSW0u-0000000209V-1EBC for linux-arm-kernel@lists.infradead.org; Sat, 13 Jul 2024 06:13:47 +0000 Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WLdM41LmHzxSSL; Sat, 13 Jul 2024 14:08:48 +0800 (CST) Received: from kwepemf100008.china.huawei.com (unknown [7.202.181.222]) by mail.maildlp.com (Postfix) with ESMTPS id 96642180088; Sat, 13 Jul 2024 14:13:34 +0800 (CST) Received: from huawei.com (10.175.103.91) by kwepemf100008.china.huawei.com (7.202.181.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 13 Jul 2024 14:13:34 +0800 From: Zeng Heng To: CC: , Subject: [PATCH v6.10-rc1 4/4] arm_mpam: Fix typo about mbw_min controls Date: Sat, 13 Jul 2024 14:09:44 +0800 Message-ID: <20240713060944.2725647-5-zengheng4@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240713060944.2725647-1-zengheng4@huawei.com> References: <20240713060944.2725647-1-zengheng4@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemf100008.china.huawei.com (7.202.181.222) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_231344_552306_8E383DDA X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Correct the judgment condition about mbw_min default value. Fixes: 099f47353bc5 ("arm_mpam: Generate a configuration for min controls") Signed-off-by: Zeng Heng --- drivers/platform/arm64/mpam/mpam_devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/arm64/mpam/mpam_devices.c b/drivers/platform/arm64/mpam/mpam_devices.c index 9acac8a22573..64a1f1767a68 100644 --- a/drivers/platform/arm64/mpam/mpam_devices.c +++ b/drivers/platform/arm64/mpam/mpam_devices.c @@ -1483,7 +1483,7 @@ static void mpam_reprogram_ris_partid(struct mpam_msc_ris *ris, u16 partid, } if (mpam_has_feature(mpam_feat_mbw_min, rprops)) { - if (mpam_has_feature(mpam_feat_mbw_max, cfg)) + if (mpam_has_feature(mpam_feat_mbw_min, cfg)) mpam_write_partsel_reg(msc, MBW_MIN, cfg->mbw_min); else mpam_write_partsel_reg(msc, MBW_MIN, 0);